drivers/gpu/drm/i915/intel_dvo.c

   1 /*
   2  * Copyright 2006 Dave Airlie <airlied@linux.ie>
   3  * Copyright © 2006-2007 Intel Corporation
   4  *
   5  * Permission is hereby granted, free of charge, to any person obtaining a
   6  * copy of this software and associated documentation files (the "Software"),
   7  * to deal in the Software without restriction, including without limitation
   8  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
   9  * and/or sell copies of the Software, and to permit persons to whom the
  10  * Software is furnished to do so, subject to the following conditions:
  11  *
  12  * The above copyright notice and this permission notice (including the next
  13  * paragraph) shall be included in all copies or substantial portions of the
  14  * Software.
  15  *
  16  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  17  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  18  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  19  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  20  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  21  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  22  * DEALINGS IN THE SOFTWARE.
  23  *
  24  * Authors:
  25  *      Eric Anholt <eric@anholt.net>
  26  */
  27 #include <linux/i2c.h>
  28 #include <linux/slab.h>
  29 #include <drm/drmP.h>
  30 #include <drm/drm_atomic_helper.h>
  31 #include <drm/drm_crtc.h>
  32 #include "intel_drv.h"
  33 #include <drm/i915_drm.h>
  34 #include "i915_drv.h"
  35 #include "dvo.h"
  36
  37 #define SIL164_ADDR     0x38
  38 #define CH7xxx_ADDR     0x76
  39 #define TFP410_ADDR     0x38
  40 #define NS2501_ADDR     0x38
  41
  42 static const struct intel_dvo_device intel_dvo_devices[] = {
  43         {
  44                 .type = INTEL_DVO_CHIP_TMDS,
  45                 .name = "sil164",
  46                 .dvo_reg = DVOC,
  47                 .slave_addr = SIL164_ADDR,
  48                 .dev_ops = &sil164_ops,
  49         },
  50         {
  51                 .type = INTEL_DVO_CHIP_TMDS,
  52                 .name = "ch7xxx",
  53                 .dvo_reg = DVOC,
  54                 .slave_addr = CH7xxx_ADDR,
  55                 .dev_ops = &ch7xxx_ops,
  56         },
  57         {
  58                 .type = INTEL_DVO_CHIP_TMDS,
  59                 .name = "ch7xxx",
  60                 .dvo_reg = DVOC,
  61                 .slave_addr = 0x75, /* For some ch7010 */
  62                 .dev_ops = &ch7xxx_ops,
  63         },
  64         {
  65                 .type = INTEL_DVO_CHIP_LVDS,
  66                 .name = "ivch",
  67                 .dvo_reg = DVOA,
  68                 .slave_addr = 0x02, /* Might also be 0x44, 0x84, 0xc4 */
  69                 .dev_ops = &ivch_ops,
  70         },
  71         {
  72                 .type = INTEL_DVO_CHIP_TMDS,
  73                 .name = "tfp410",
  74                 .dvo_reg = DVOC,
  75                 .slave_addr = TFP410_ADDR,
  76                 .dev_ops = &tfp410_ops,
  77         },
  78         {
  79                 .type = INTEL_DVO_CHIP_LVDS,
  80                 .name = "ch7017",
  81                 .dvo_reg = DVOC,
  82                 .slave_addr = 0x75,
  83                 .gpio = GMBUS_PIN_DPB,
  84                 .dev_ops = &ch7017_ops,
  85         },
  86         {
  87                 .type = INTEL_DVO_CHIP_TMDS,
  88                 .name = "ns2501",
  89                 .dvo_reg = DVOB,
  90                 .slave_addr = NS2501_ADDR,
  91                 .dev_ops = &ns2501_ops,
  92        }
  93 };
  94
  95 struct intel_dvo {
  96         struct intel_encoder base;
  97
  98         struct intel_dvo_device dev;
  99
 100         struct drm_display_mode *panel_fixed_mode;
 101         bool panel_wants_dither;
 102 };
 103
 104 static struct intel_dvo *enc_to_dvo(struct intel_encoder *encoder)
 105 {
 106         return container_of(encoder, struct intel_dvo, base);
 107 }
 108
 109 static struct intel_dvo *intel_attached_dvo(struct drm_connector *connector)
 110 {
 111         return enc_to_dvo(intel_attached_encoder(connector));
 112 }
 113
 114 static bool intel_dvo_connector_get_hw_state(struct intel_connector *connector)
 115 {
 116         struct drm_device *dev = connector->base.dev;
 117         struct drm_i915_private *dev_priv = dev->dev_private;
 118         struct intel_dvo *intel_dvo = intel_attached_dvo(&connector->base);
 119         u32 tmp;
 120
 121         tmp = I915_READ(intel_dvo->dev.dvo_reg);
 122
 123         if (!(tmp & DVO_ENABLE))
 124                 return false;
 125
 126         return intel_dvo->dev.dev_ops->get_hw_state(&intel_dvo->dev);
 127 }
 128
 129 static bool intel_dvo_get_hw_state(struct intel_encoder *encoder,
 130                                    enum pipe *pipe)
 131 {
 132         struct drm_device *dev = encoder->base.dev;
 133         struct drm_i915_private *dev_priv = dev->dev_private;
 134         struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 135         u32 tmp;
 136
 137         tmp = I915_READ(intel_dvo->dev.dvo_reg);
 138
 139         if (!(tmp & DVO_ENABLE))
 140                 return false;
 141
 142         *pipe = PORT_TO_PIPE(tmp);
 143
 144         return true;
 145 }
 146
 147 static void intel_dvo_get_config(struct intel_encoder *encoder,
 148                                  struct intel_crtc_state *pipe_config)
 149 {
 150         struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
 151         struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 152         u32 tmp, flags = 0;
 153
 154         tmp = I915_READ(intel_dvo->dev.dvo_reg);
 155         if (tmp & DVO_HSYNC_ACTIVE_HIGH)
 156                 flags |= DRM_MODE_FLAG_PHSYNC;
 157         else
 158                 flags |= DRM_MODE_FLAG_NHSYNC;
 159         if (tmp & DVO_VSYNC_ACTIVE_HIGH)
 160                 flags |= DRM_MODE_FLAG_PVSYNC;
 161         else
 162                 flags |= DRM_MODE_FLAG_NVSYNC;
 163
 164         pipe_config->base.adjusted_mode.flags |= flags;
 165
 166         pipe_config->base.adjusted_mode.crtc_clock = pipe_config->port_clock;
 167 }
 168
 169 static void intel_disable_dvo(struct intel_encoder *encoder)
 170 {
 171         struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
 172         struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 173         u32 dvo_reg = intel_dvo->dev.dvo_reg;
 174         u32 temp = I915_READ(dvo_reg);
 175
 176         intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
 177         I915_WRITE(dvo_reg, temp & ~DVO_ENABLE);
 178         I915_READ(dvo_reg);
 179 }
 180
 181 static void intel_enable_dvo(struct intel_encoder *encoder)
 182 {
 183         struct drm_i915_private *dev_priv = encoder->base.dev->dev_private;
 184         struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 185         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
 186         u32 dvo_reg = intel_dvo->dev.dvo_reg;
 187         u32 temp = I915_READ(dvo_reg);
 188
 189         intel_dvo->dev.dev_ops->mode_set(&intel_dvo->dev,
 190                                          &crtc->config->base.mode,
 191                                          &crtc->config->base.adjusted_mode);
 192
 193         I915_WRITE(dvo_reg, temp | DVO_ENABLE);
 194         I915_READ(dvo_reg);
 195
 196         intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
 197 }
 198
 199 /* Special dpms function to support cloning between dvo/sdvo/crt. */
 200 static int intel_dvo_dpms(struct drm_connector *connector, int mode)
 201 {
 202         struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
 203         struct drm_crtc *crtc;
 204         struct intel_crtc_state *config;
 205
 206         /* dvo supports only 2 dpms states. */
 207         if (mode != DRM_MODE_DPMS_ON)
 208                 mode = DRM_MODE_DPMS_OFF;
 209
 210         if (mode == connector->dpms)
 211                 return 0;
 212
 213         connector->dpms = mode;
 214
 215         /* Only need to change hw state when actually enabled */
 216         crtc = intel_dvo->base.base.crtc;
 217         if (!crtc) {
 218                 intel_dvo->base.connectors_active = false;
 219                 return 0;
 220         }
 221
 222         /* We call connector dpms manually below in case pipe dpms doesn't
 223          * change due to cloning. */
 224         if (mode == DRM_MODE_DPMS_ON) {
 225                 config = to_intel_crtc(crtc)->config;
 226
 227                 intel_dvo->base.connectors_active = true;
 228
 229                 intel_crtc_update_dpms(crtc);
 230
 231                 intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, true);
 232         } else {
 233                 intel_dvo->dev.dev_ops->dpms(&intel_dvo->dev, false);
 234
 235                 intel_dvo->base.connectors_active = false;
 236
 237                 intel_crtc_update_dpms(crtc);
 238         }
 239
 240         intel_modeset_check_state(connector->dev);
 241
 242         return 0;
 243 }
 244
 245 static enum drm_mode_status
 246 intel_dvo_mode_valid(struct drm_connector *connector,
 247                      struct drm_display_mode *mode)
 248 {
 249         struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
 250
 251         if (mode->flags & DRM_MODE_FLAG_DBLSCAN)
 252                 return MODE_NO_DBLESCAN;
 253
 254         /* XXX: Validate clock range */
 255
 256         if (intel_dvo->panel_fixed_mode) {
 257                 if (mode->hdisplay > intel_dvo->panel_fixed_mode->hdisplay)
 258                         return MODE_PANEL;
 259                 if (mode->vdisplay > intel_dvo->panel_fixed_mode->vdisplay)
 260                         return MODE_PANEL;
 261         }
 262
 263         return intel_dvo->dev.dev_ops->mode_valid(&intel_dvo->dev, mode);
 264 }
 265
 266 static bool intel_dvo_compute_config(struct intel_encoder *encoder,
 267                                      struct intel_crtc_state *pipe_config)
 268 {
 269         struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 270         struct drm_display_mode *adjusted_mode = &pipe_config->base.adjusted_mode;
 271
 272         /* If we have timings from the BIOS for the panel, put them in
 273          * to the adjusted mode.  The CRTC will be set up for this mode,
 274          * with the panel scaling set up to source from the H/VDisplay
 275          * of the original mode.
 276          */
 277         if (intel_dvo->panel_fixed_mode != NULL) {
 278 #define C(x) adjusted_mode->x = intel_dvo->panel_fixed_mode->x
 279                 C(hdisplay);
 280                 C(hsync_start);
 281                 C(hsync_end);
 282                 C(htotal);
 283                 C(vdisplay);
 284                 C(vsync_start);
 285                 C(vsync_end);
 286                 C(vtotal);
 287                 C(clock);
 288 #undef C
 289
 290                 drm_mode_set_crtcinfo(adjusted_mode, 0);
 291         }
 292
 293         return true;
 294 }
 295
 296 static void intel_dvo_pre_enable(struct intel_encoder *encoder)
 297 {
 298         struct drm_device *dev = encoder->base.dev;
 299         struct drm_i915_private *dev_priv = dev->dev_private;
 300         struct intel_crtc *crtc = to_intel_crtc(encoder->base.crtc);
 301         struct drm_display_mode *adjusted_mode = &crtc->config->base.adjusted_mode;
 302         struct intel_dvo *intel_dvo = enc_to_dvo(encoder);
 303         int pipe = crtc->pipe;
 304         u32 dvo_val;
 305         u32 dvo_reg = intel_dvo->dev.dvo_reg, dvo_srcdim_reg;
 306
 307         switch (dvo_reg) {
 308         case DVOA:
 309         default:
 310                 dvo_srcdim_reg = DVOA_SRCDIM;
 311                 break;
 312         case DVOB:
 313                 dvo_srcdim_reg = DVOB_SRCDIM;
 314                 break;
 315         case DVOC:
 316                 dvo_srcdim_reg = DVOC_SRCDIM;
 317                 break;
 318         }
 319
 320         /* Save the data order, since I don't know what it should be set to. */
 321         dvo_val = I915_READ(dvo_reg) &
 322                   (DVO_PRESERVE_MASK | DVO_DATA_ORDER_GBRG);
 323         dvo_val |= DVO_DATA_ORDER_FP | DVO_BORDER_ENABLE |
 324                    DVO_BLANK_ACTIVE_HIGH;
 325
 326         if (pipe == 1)
 327                 dvo_val |= DVO_PIPE_B_SELECT;
 328         dvo_val |= DVO_PIPE_STALL;
 329         if (adjusted_mode->flags & DRM_MODE_FLAG_PHSYNC)
 330                 dvo_val |= DVO_HSYNC_ACTIVE_HIGH;
 331         if (adjusted_mode->flags & DRM_MODE_FLAG_PVSYNC)
 332                 dvo_val |= DVO_VSYNC_ACTIVE_HIGH;
 333
 334         /*I915_WRITE(DVOB_SRCDIM,
 335           (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
 336           (adjusted_mode->VDisplay << DVO_SRCDIM_VERTICAL_SHIFT));*/
 337         I915_WRITE(dvo_srcdim_reg,
 338                    (adjusted_mode->hdisplay << DVO_SRCDIM_HORIZONTAL_SHIFT) |
 339                    (adjusted_mode->vdisplay << DVO_SRCDIM_VERTICAL_SHIFT));
 340         /*I915_WRITE(DVOB, dvo_val);*/
 341         I915_WRITE(dvo_reg, dvo_val);
 342 }
 343
 344 /**
 345  * Detect the output connection on our DVO device.
 346  *
 347  * Unimplemented.
 348  */
 349 static enum drm_connector_status
 350 intel_dvo_detect(struct drm_connector *connector, bool force)
 351 {
 352         struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
 353         DRM_DEBUG_KMS("[CONNECTOR:%d:%s]\n",
 354                       connector->base.id, connector->name);
 355         return intel_dvo->dev.dev_ops->detect(&intel_dvo->dev);
 356 }
 357
 358 static int intel_dvo_get_modes(struct drm_connector *connector)
 359 {
 360         struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
 361         struct drm_i915_private *dev_priv = connector->dev->dev_private;
 362
 363         /* We should probably have an i2c driver get_modes function for those
 364          * devices which will have a fixed set of modes determined by the chip
 365          * (TV-out, for example), but for now with just TMDS and LVDS,
 366          * that's not the case.
 367          */
 368         intel_ddc_get_modes(connector,
 369                             intel_gmbus_get_adapter(dev_priv, GMBUS_PIN_DPC));
 370         if (!list_empty(&connector->probed_modes))
 371                 return 1;
 372
 373         if (intel_dvo->panel_fixed_mode != NULL) {
 374                 struct drm_display_mode *mode;
 375                 mode = drm_mode_duplicate(connector->dev, intel_dvo->panel_fixed_mode);
 376                 if (mode) {
 377                         drm_mode_probed_add(connector, mode);
 378                         return 1;
 379                 }
 380         }
 381
 382         return 0;
 383 }
 384
 385 static void intel_dvo_destroy(struct drm_connector *connector)
 386 {
 387         drm_connector_cleanup(connector);
 388         kfree(connector);
 389 }
 390
 391 static const struct drm_connector_funcs intel_dvo_connector_funcs = {
 392         .dpms = intel_dvo_dpms,
 393         .detect = intel_dvo_detect,
 394         .destroy = intel_dvo_destroy,
 395         .fill_modes = drm_helper_probe_single_connector_modes,
 396         .atomic_get_property = intel_connector_atomic_get_property,
 397         .atomic_destroy_state = drm_atomic_helper_connector_destroy_state,
 398         .atomic_duplicate_state = drm_atomic_helper_connector_duplicate_state,
 399 };
 400
 401 static const struct drm_connector_helper_funcs intel_dvo_connector_helper_funcs = {
 402         .mode_valid = intel_dvo_mode_valid,
 403         .get_modes = intel_dvo_get_modes,
 404         .best_encoder = intel_best_encoder,
 405 };
 406
 407 static void intel_dvo_enc_destroy(struct drm_encoder *encoder)
 408 {
 409         struct intel_dvo *intel_dvo = enc_to_dvo(to_intel_encoder(encoder));
 410
 411         if (intel_dvo->dev.dev_ops->destroy)
 412                 intel_dvo->dev.dev_ops->destroy(&intel_dvo->dev);
 413
 414         kfree(intel_dvo->panel_fixed_mode);
 415
 416         intel_encoder_destroy(encoder);
 417 }
 418
 419 static const struct drm_encoder_funcs intel_dvo_enc_funcs = {
 420         .destroy = intel_dvo_enc_destroy,
 421 };
 422
 423 /**
 424  * Attempts to get a fixed panel timing for LVDS (currently only the i830).
 425  *
 426  * Other chips with DVO LVDS will need to extend this to deal with the LVDS
 427  * chip being on DVOB/C and having multiple pipes.
 428  */
 429 static struct drm_display_mode *
 430 intel_dvo_get_current_mode(struct drm_connector *connector)
 431 {
 432         struct drm_device *dev = connector->dev;
 433         struct drm_i915_private *dev_priv = dev->dev_private;
 434         struct intel_dvo *intel_dvo = intel_attached_dvo(connector);
 435         uint32_t dvo_val = I915_READ(intel_dvo->dev.dvo_reg);
 436         struct drm_display_mode *mode = NULL;
 437
 438         /* If the DVO port is active, that'll be the LVDS, so we can pull out
 439          * its timings to get how the BIOS set up the panel.
 440          */
 441         if (dvo_val & DVO_ENABLE) {
 442                 struct drm_crtc *crtc;
 443                 int pipe = (dvo_val & DVO_PIPE_B_SELECT) ? 1 : 0;
 444
 445                 crtc = intel_get_crtc_for_pipe(dev, pipe);
 446                 if (crtc) {
 447                         mode = intel_crtc_mode_get(dev, crtc);
 448                         if (mode) {
 449                                 mode->type |= DRM_MODE_TYPE_PREFERRED;
 450                                 if (dvo_val & DVO_HSYNC_ACTIVE_HIGH)
 451                                         mode->flags |= DRM_MODE_FLAG_PHSYNC;
 452                                 if (dvo_val & DVO_VSYNC_ACTIVE_HIGH)
 453                                         mode->flags |= DRM_MODE_FLAG_PVSYNC;
 454                         }
 455                 }
 456         }
 457
 458         return mode;
 459 }
 460
 461 void intel_dvo_init(struct drm_device *dev)
 462 {
 463         struct drm_i915_private *dev_priv = dev->dev_private;
 464         struct intel_encoder *intel_encoder;
 465         struct intel_dvo *intel_dvo;
 466         struct intel_connector *intel_connector;
 467         int i;
 468         int encoder_type = DRM_MODE_ENCODER_NONE;
 469
 470         intel_dvo = kzalloc(sizeof(*intel_dvo), GFP_KERNEL);
 471         if (!intel_dvo)
 472                 return;
 473
 474         intel_connector = intel_connector_alloc();
 475         if (!intel_connector) {
 476                 kfree(intel_dvo);
 477                 return;
 478         }
 479
 480         intel_encoder = &intel_dvo->base;
 481         drm_encoder_init(dev, &intel_encoder->base,
 482                          &intel_dvo_enc_funcs, encoder_type);
 483
 484         intel_encoder->disable = intel_disable_dvo;
 485         intel_encoder->enable = intel_enable_dvo;
 486         intel_encoder->get_hw_state = intel_dvo_get_hw_state;
 487         intel_encoder->get_config = intel_dvo_get_config;
 488         intel_encoder->compute_config = intel_dvo_compute_config;
 489         intel_encoder->pre_enable = intel_dvo_pre_enable;
 490         intel_connector->get_hw_state = intel_dvo_connector_get_hw_state;
 491         intel_connector->unregister = intel_connector_unregister;
 492
 493         /* Now, try to find a controller */
 494         for (i = 0; i < ARRAY_SIZE(intel_dvo_devices); i++) {
 495                 struct drm_connector *connector = &intel_connector->base;
 496                 const struct intel_dvo_device *dvo = &intel_dvo_devices[i];
 497                 struct i2c_adapter *i2c;
 498                 int gpio;
 499                 bool dvoinit;
 500                 enum pipe pipe;
 501                 uint32_t dpll[I915_MAX_PIPES];
 502
 503                 /* Allow the I2C driver info to specify the GPIO to be used in
 504                  * special cases, but otherwise default to what's defined
 505                  * in the spec.
 506                  */
 507                 if (intel_gmbus_is_valid_pin(dev_priv, dvo->gpio))
 508                         gpio = dvo->gpio;
 509                 else if (dvo->type == INTEL_DVO_CHIP_LVDS)
 510                         gpio = GMBUS_PIN_SSC;
 511                 else
 512                         gpio = GMBUS_PIN_DPB;
 513
 514                 /* Set up the I2C bus necessary for the chip we're probing.
 515                  * It appears that everything is on GPIOE except for panels
 516                  * on i830 laptops, which are on GPIOB (DVOA).
 517                  */
 518                 i2c = intel_gmbus_get_adapter(dev_priv, gpio);
 519
 520                 intel_dvo->dev = *dvo;
 521
 522                 /* GMBUS NAK handling seems to be unstable, hence let the
 523                  * transmitter detection run in bit banging mode for now.
 524                  */
 525                 intel_gmbus_force_bit(i2c, true);
 526
 527                 /* ns2501 requires the DVO 2x clock before it will
 528                  * respond to i2c accesses, so make sure we have
 529                  * have the clock enabled before we attempt to
 530                  * initialize the device.
 531                  */
 532                 for_each_pipe(dev_priv, pipe) {
 533                         dpll[pipe] = I915_READ(DPLL(pipe));
 534                         I915_WRITE(DPLL(pipe), dpll[pipe] | DPLL_DVO_2X_MODE);
 535                 }
 536
 537                 dvoinit = dvo->dev_ops->init(&intel_dvo->dev, i2c);
 538
 539                 /* restore the DVO 2x clock state to original */
 540                 for_each_pipe(dev_priv, pipe) {
 541                         I915_WRITE(DPLL(pipe), dpll[pipe]);
 542                 }
 543
 544                 intel_gmbus_force_bit(i2c, false);
 545
 546                 if (!dvoinit)
 547                         continue;
 548
 549                 intel_encoder->type = INTEL_OUTPUT_DVO;
 550                 intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
 551                 switch (dvo->type) {
 552                 case INTEL_DVO_CHIP_TMDS:
 553                         intel_encoder->cloneable = (1 << INTEL_OUTPUT_ANALOG) |
 554                                 (1 << INTEL_OUTPUT_DVO);
 555                         drm_connector_init(dev, connector,
 556                                            &intel_dvo_connector_funcs,
 557                                            DRM_MODE_CONNECTOR_DVII);
 558                         encoder_type = DRM_MODE_ENCODER_TMDS;
 559                         break;
 560                 case INTEL_DVO_CHIP_LVDS:
 561                         intel_encoder->cloneable = 0;
 562                         drm_connector_init(dev, connector,
 563                                            &intel_dvo_connector_funcs,
 564                                            DRM_MODE_CONNECTOR_LVDS);
 565                         encoder_type = DRM_MODE_ENCODER_LVDS;
 566                         break;
 567                 }
 568
 569                 drm_connector_helper_add(connector,
 570                                          &intel_dvo_connector_helper_funcs);
 571                 connector->display_info.subpixel_order = SubPixelHorizontalRGB;
 572                 connector->interlace_allowed = false;
 573                 connector->doublescan_allowed = false;
 574
 575                 intel_connector_attach_encoder(intel_connector, intel_encoder);
 576                 if (dvo->type == INTEL_DVO_CHIP_LVDS) {
 577                         /* For our LVDS chipsets, we should hopefully be able
 578                          * to dig the fixed panel mode out of the BIOS data.
 579                          * However, it's in a different format from the BIOS
 580                          * data on chipsets with integrated LVDS (stored in AIM
 581                          * headers, likely), so for now, just get the current
 582                          * mode being output through DVO.
 583                          */
 584                         intel_dvo->panel_fixed_mode =
 585                                 intel_dvo_get_current_mode(connector);
 586                         intel_dvo->panel_wants_dither = true;
 587                 }
 588
 589                 drm_connector_register(connector);
 590                 return;
 591         }
 592
 593         drm_encoder_cleanup(&intel_encoder->base);
 594         kfree(intel_dvo);
 595         kfree(intel_connector);
 596 }