4 * TI OMAP3 ISP - Generic video node
6 * Copyright (C) 2009-2010 Nokia Corporation
8 * Contacts: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
9 * Sakari Ailus <sakari.ailus@iki.fi>
11 * This program is free software; you can redistribute it and/or modify
12 * it under the terms of the GNU General Public License version 2 as
13 * published by the Free Software Foundation.
16 #include <asm/cacheflush.h>
17 #include <linux/clk.h>
19 #include <linux/module.h>
20 #include <linux/pagemap.h>
21 #include <linux/scatterlist.h>
22 #include <linux/sched.h>
23 #include <linux/slab.h>
24 #include <linux/vmalloc.h>
25 #include <media/v4l2-dev.h>
26 #include <media/v4l2-ioctl.h>
27 #include <media/videobuf2-dma-contig.h>
33 /* -----------------------------------------------------------------------------
38 * NOTE: When adding new media bus codes, always remember to add
39 * corresponding in-memory formats to the table below!!!
41 static struct isp_format_info formats[] = {
42 { MEDIA_BUS_FMT_Y8_1X8, MEDIA_BUS_FMT_Y8_1X8,
43 MEDIA_BUS_FMT_Y8_1X8, MEDIA_BUS_FMT_Y8_1X8,
44 V4L2_PIX_FMT_GREY, 8, 1, },
45 { MEDIA_BUS_FMT_Y10_1X10, MEDIA_BUS_FMT_Y10_1X10,
46 MEDIA_BUS_FMT_Y10_1X10, MEDIA_BUS_FMT_Y8_1X8,
47 V4L2_PIX_FMT_Y10, 10, 2, },
48 { MEDIA_BUS_FMT_Y12_1X12, MEDIA_BUS_FMT_Y10_1X10,
49 MEDIA_BUS_FMT_Y12_1X12, MEDIA_BUS_FMT_Y8_1X8,
50 V4L2_PIX_FMT_Y12, 12, 2, },
51 { MEDIA_BUS_FMT_SBGGR8_1X8, MEDIA_BUS_FMT_SBGGR8_1X8,
52 MEDIA_BUS_FMT_SBGGR8_1X8, MEDIA_BUS_FMT_SBGGR8_1X8,
53 V4L2_PIX_FMT_SBGGR8, 8, 1, },
54 { MEDIA_BUS_FMT_SGBRG8_1X8, MEDIA_BUS_FMT_SGBRG8_1X8,
55 MEDIA_BUS_FMT_SGBRG8_1X8, MEDIA_BUS_FMT_SGBRG8_1X8,
56 V4L2_PIX_FMT_SGBRG8, 8, 1, },
57 { MEDIA_BUS_FMT_SGRBG8_1X8, MEDIA_BUS_FMT_SGRBG8_1X8,
58 MEDIA_BUS_FMT_SGRBG8_1X8, MEDIA_BUS_FMT_SGRBG8_1X8,
59 V4L2_PIX_FMT_SGRBG8, 8, 1, },
60 { MEDIA_BUS_FMT_SRGGB8_1X8, MEDIA_BUS_FMT_SRGGB8_1X8,
61 MEDIA_BUS_FMT_SRGGB8_1X8, MEDIA_BUS_FMT_SRGGB8_1X8,
62 V4L2_PIX_FMT_SRGGB8, 8, 1, },
63 { MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8, MEDIA_BUS_FMT_SBGGR10_DPCM8_1X8,
64 MEDIA_BUS_FMT_SBGGR10_1X10, 0,
65 V4L2_PIX_FMT_SBGGR10DPCM8, 8, 1, },
66 { MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8, MEDIA_BUS_FMT_SGBRG10_DPCM8_1X8,
67 MEDIA_BUS_FMT_SGBRG10_1X10, 0,
68 V4L2_PIX_FMT_SGBRG10DPCM8, 8, 1, },
69 { MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8, MEDIA_BUS_FMT_SGRBG10_DPCM8_1X8,
70 MEDIA_BUS_FMT_SGRBG10_1X10, 0,
71 V4L2_PIX_FMT_SGRBG10DPCM8, 8, 1, },
72 { MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8, MEDIA_BUS_FMT_SRGGB10_DPCM8_1X8,
73 MEDIA_BUS_FMT_SRGGB10_1X10, 0,
74 V4L2_PIX_FMT_SRGGB10DPCM8, 8, 1, },
75 { MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SBGGR10_1X10,
76 MEDIA_BUS_FMT_SBGGR10_1X10, MEDIA_BUS_FMT_SBGGR8_1X8,
77 V4L2_PIX_FMT_SBGGR10, 10, 2, },
78 { MEDIA_BUS_FMT_SGBRG10_1X10, MEDIA_BUS_FMT_SGBRG10_1X10,
79 MEDIA_BUS_FMT_SGBRG10_1X10, MEDIA_BUS_FMT_SGBRG8_1X8,
80 V4L2_PIX_FMT_SGBRG10, 10, 2, },
81 { MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SGRBG10_1X10,
82 MEDIA_BUS_FMT_SGRBG10_1X10, MEDIA_BUS_FMT_SGRBG8_1X8,
83 V4L2_PIX_FMT_SGRBG10, 10, 2, },
84 { MEDIA_BUS_FMT_SRGGB10_1X10, MEDIA_BUS_FMT_SRGGB10_1X10,
85 MEDIA_BUS_FMT_SRGGB10_1X10, MEDIA_BUS_FMT_SRGGB8_1X8,
86 V4L2_PIX_FMT_SRGGB10, 10, 2, },
87 { MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SBGGR10_1X10,
88 MEDIA_BUS_FMT_SBGGR12_1X12, MEDIA_BUS_FMT_SBGGR8_1X8,
89 V4L2_PIX_FMT_SBGGR12, 12, 2, },
90 { MEDIA_BUS_FMT_SGBRG12_1X12, MEDIA_BUS_FMT_SGBRG10_1X10,
91 MEDIA_BUS_FMT_SGBRG12_1X12, MEDIA_BUS_FMT_SGBRG8_1X8,
92 V4L2_PIX_FMT_SGBRG12, 12, 2, },
93 { MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SGRBG10_1X10,
94 MEDIA_BUS_FMT_SGRBG12_1X12, MEDIA_BUS_FMT_SGRBG8_1X8,
95 V4L2_PIX_FMT_SGRBG12, 12, 2, },
96 { MEDIA_BUS_FMT_SRGGB12_1X12, MEDIA_BUS_FMT_SRGGB10_1X10,
97 MEDIA_BUS_FMT_SRGGB12_1X12, MEDIA_BUS_FMT_SRGGB8_1X8,
98 V4L2_PIX_FMT_SRGGB12, 12, 2, },
99 { MEDIA_BUS_FMT_UYVY8_1X16, MEDIA_BUS_FMT_UYVY8_1X16,
100 MEDIA_BUS_FMT_UYVY8_1X16, 0,
101 V4L2_PIX_FMT_UYVY, 16, 2, },
102 { MEDIA_BUS_FMT_YUYV8_1X16, MEDIA_BUS_FMT_YUYV8_1X16,
103 MEDIA_BUS_FMT_YUYV8_1X16, 0,
104 V4L2_PIX_FMT_YUYV, 16, 2, },
105 { MEDIA_BUS_FMT_UYVY8_2X8, MEDIA_BUS_FMT_UYVY8_2X8,
106 MEDIA_BUS_FMT_UYVY8_2X8, 0,
107 V4L2_PIX_FMT_UYVY, 8, 2, },
108 { MEDIA_BUS_FMT_YUYV8_2X8, MEDIA_BUS_FMT_YUYV8_2X8,
109 MEDIA_BUS_FMT_YUYV8_2X8, 0,
110 V4L2_PIX_FMT_YUYV, 8, 2, },
111 /* Empty entry to catch the unsupported pixel code (0) used by the CCDC
112 * module and avoid NULL pointer dereferences.
117 const struct isp_format_info *omap3isp_video_format_info(u32 code)
121 for (i = 0; i < ARRAY_SIZE(formats); ++i) {
122 if (formats[i].code == code)
130 * isp_video_mbus_to_pix - Convert v4l2_mbus_framefmt to v4l2_pix_format
131 * @video: ISP video instance
132 * @mbus: v4l2_mbus_framefmt format (input)
133 * @pix: v4l2_pix_format format (output)
135 * Fill the output pix structure with information from the input mbus format.
136 * The bytesperline and sizeimage fields are computed from the requested bytes
137 * per line value in the pix format and information from the video instance.
139 * Return the number of padding bytes at end of line.
141 static unsigned int isp_video_mbus_to_pix(const struct isp_video *video,
142 const struct v4l2_mbus_framefmt *mbus,
143 struct v4l2_pix_format *pix)
145 unsigned int bpl = pix->bytesperline;
146 unsigned int min_bpl;
149 memset(pix, 0, sizeof(*pix));
150 pix->width = mbus->width;
151 pix->height = mbus->height;
153 for (i = 0; i < ARRAY_SIZE(formats); ++i) {
154 if (formats[i].code == mbus->code)
158 if (WARN_ON(i == ARRAY_SIZE(formats)))
161 min_bpl = pix->width * formats[i].bpp;
163 /* Clamp the requested bytes per line value. If the maximum bytes per
164 * line value is zero, the module doesn't support user configurable line
165 * sizes. Override the requested value with the minimum in that case.
168 bpl = clamp(bpl, min_bpl, video->bpl_max);
172 if (!video->bpl_zero_padding || bpl != min_bpl)
173 bpl = ALIGN(bpl, video->bpl_alignment);
175 pix->pixelformat = formats[i].pixelformat;
176 pix->bytesperline = bpl;
177 pix->sizeimage = pix->bytesperline * pix->height;
178 pix->colorspace = mbus->colorspace;
179 pix->field = mbus->field;
181 return bpl - min_bpl;
184 static void isp_video_pix_to_mbus(const struct v4l2_pix_format *pix,
185 struct v4l2_mbus_framefmt *mbus)
189 memset(mbus, 0, sizeof(*mbus));
190 mbus->width = pix->width;
191 mbus->height = pix->height;
193 /* Skip the last format in the loop so that it will be selected if no
196 for (i = 0; i < ARRAY_SIZE(formats) - 1; ++i) {
197 if (formats[i].pixelformat == pix->pixelformat)
201 mbus->code = formats[i].code;
202 mbus->colorspace = pix->colorspace;
203 mbus->field = pix->field;
206 static struct v4l2_subdev *
207 isp_video_remote_subdev(struct isp_video *video, u32 *pad)
209 struct media_pad *remote;
211 remote = media_entity_remote_pad(&video->pad);
213 if (remote == NULL ||
214 media_entity_type(remote->entity) != MEDIA_ENT_T_V4L2_SUBDEV)
218 *pad = remote->index;
220 return media_entity_to_v4l2_subdev(remote->entity);
223 /* Return a pointer to the ISP video instance at the far end of the pipeline. */
224 static int isp_video_get_graph_data(struct isp_video *video,
225 struct isp_pipeline *pipe)
227 struct media_entity_graph graph;
228 struct media_entity *entity = &video->video.entity;
229 struct media_device *mdev = entity->parent;
230 struct isp_video *far_end = NULL;
232 mutex_lock(&mdev->graph_mutex);
233 media_entity_graph_walk_start(&graph, entity);
235 while ((entity = media_entity_graph_walk_next(&graph))) {
236 struct isp_video *__video;
238 pipe->entities |= 1 << entity->id;
243 if (entity == &video->video.entity)
246 if (media_entity_type(entity) != MEDIA_ENT_T_DEVNODE)
249 __video = to_isp_video(media_entity_to_video_device(entity));
250 if (__video->type != video->type)
254 mutex_unlock(&mdev->graph_mutex);
256 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
257 pipe->input = far_end;
258 pipe->output = video;
264 pipe->output = far_end;
271 __isp_video_get_format(struct isp_video *video, struct v4l2_format *format)
273 struct v4l2_subdev_format fmt;
274 struct v4l2_subdev *subdev;
278 subdev = isp_video_remote_subdev(video, &pad);
283 fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
285 mutex_lock(&video->mutex);
286 ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);
287 mutex_unlock(&video->mutex);
292 format->type = video->type;
293 return isp_video_mbus_to_pix(video, &fmt.format, &format->fmt.pix);
297 isp_video_check_format(struct isp_video *video, struct isp_video_fh *vfh)
299 struct v4l2_format format;
302 memcpy(&format, &vfh->format, sizeof(format));
303 ret = __isp_video_get_format(video, &format);
307 if (vfh->format.fmt.pix.pixelformat != format.fmt.pix.pixelformat ||
308 vfh->format.fmt.pix.height != format.fmt.pix.height ||
309 vfh->format.fmt.pix.width != format.fmt.pix.width ||
310 vfh->format.fmt.pix.bytesperline != format.fmt.pix.bytesperline ||
311 vfh->format.fmt.pix.sizeimage != format.fmt.pix.sizeimage ||
312 vfh->format.fmt.pix.field != format.fmt.pix.field)
318 /* -----------------------------------------------------------------------------
319 * Video queue operations
322 static int isp_video_queue_setup(struct vb2_queue *queue,
323 const struct v4l2_format *fmt,
324 unsigned int *count, unsigned int *num_planes,
325 unsigned int sizes[], void *alloc_ctxs[])
327 struct isp_video_fh *vfh = vb2_get_drv_priv(queue);
328 struct isp_video *video = vfh->video;
332 sizes[0] = vfh->format.fmt.pix.sizeimage;
336 alloc_ctxs[0] = video->alloc_ctx;
338 *count = min(*count, video->capture_mem / PAGE_ALIGN(sizes[0]));
343 static int isp_video_buffer_prepare(struct vb2_buffer *buf)
345 struct isp_video_fh *vfh = vb2_get_drv_priv(buf->vb2_queue);
346 struct isp_buffer *buffer = to_isp_buffer(buf);
347 struct isp_video *video = vfh->video;
350 /* Refuse to prepare the buffer is the video node has registered an
351 * error. We don't need to take any lock here as the operation is
352 * inherently racy. The authoritative check will be performed in the
353 * queue handler, which can't return an error, this check is just a best
354 * effort to notify userspace as early as possible.
356 if (unlikely(video->error))
359 addr = vb2_dma_contig_plane_dma_addr(buf, 0);
360 if (!IS_ALIGNED(addr, 32)) {
361 dev_dbg(video->isp->dev,
362 "Buffer address must be aligned to 32 bytes boundary.\n");
366 vb2_set_plane_payload(&buffer->vb, 0, vfh->format.fmt.pix.sizeimage);
373 * isp_video_buffer_queue - Add buffer to streaming queue
376 * In memory-to-memory mode, start streaming on the pipeline if buffers are
377 * queued on both the input and the output, if the pipeline isn't already busy.
378 * If the pipeline is busy, it will be restarted in the output module interrupt
381 static void isp_video_buffer_queue(struct vb2_buffer *buf)
383 struct isp_video_fh *vfh = vb2_get_drv_priv(buf->vb2_queue);
384 struct isp_buffer *buffer = to_isp_buffer(buf);
385 struct isp_video *video = vfh->video;
386 struct isp_pipeline *pipe = to_isp_pipeline(&video->video.entity);
387 enum isp_pipeline_state state;
392 spin_lock_irqsave(&video->irqlock, flags);
394 if (unlikely(video->error)) {
395 vb2_buffer_done(&buffer->vb, VB2_BUF_STATE_ERROR);
396 spin_unlock_irqrestore(&video->irqlock, flags);
400 empty = list_empty(&video->dmaqueue);
401 list_add_tail(&buffer->irqlist, &video->dmaqueue);
403 spin_unlock_irqrestore(&video->irqlock, flags);
406 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
407 state = ISP_PIPELINE_QUEUE_OUTPUT;
409 state = ISP_PIPELINE_QUEUE_INPUT;
411 spin_lock_irqsave(&pipe->lock, flags);
412 pipe->state |= state;
413 video->ops->queue(video, buffer);
414 video->dmaqueue_flags |= ISP_VIDEO_DMAQUEUE_QUEUED;
416 start = isp_pipeline_ready(pipe);
418 pipe->state |= ISP_PIPELINE_STREAM;
419 spin_unlock_irqrestore(&pipe->lock, flags);
422 omap3isp_pipeline_set_stream(pipe,
423 ISP_PIPELINE_STREAM_SINGLESHOT);
427 static const struct vb2_ops isp_video_queue_ops = {
428 .queue_setup = isp_video_queue_setup,
429 .buf_prepare = isp_video_buffer_prepare,
430 .buf_queue = isp_video_buffer_queue,
434 * omap3isp_video_buffer_next - Complete the current buffer and return the next
435 * @video: ISP video object
437 * Remove the current video buffer from the DMA queue and fill its timestamp and
438 * field count before handing it back to videobuf2.
440 * For capture video nodes the buffer state is set to VB2_BUF_STATE_DONE if no
441 * error has been flagged in the pipeline, or to VB2_BUF_STATE_ERROR otherwise.
442 * For video output nodes the buffer state is always set to VB2_BUF_STATE_DONE.
444 * The DMA queue is expected to contain at least one buffer.
446 * Return a pointer to the next buffer in the DMA queue, or NULL if the queue is
449 struct isp_buffer *omap3isp_video_buffer_next(struct isp_video *video)
451 struct isp_pipeline *pipe = to_isp_pipeline(&video->video.entity);
452 enum isp_pipeline_state state;
453 struct isp_buffer *buf;
457 spin_lock_irqsave(&video->irqlock, flags);
458 if (WARN_ON(list_empty(&video->dmaqueue))) {
459 spin_unlock_irqrestore(&video->irqlock, flags);
463 buf = list_first_entry(&video->dmaqueue, struct isp_buffer,
465 list_del(&buf->irqlist);
466 spin_unlock_irqrestore(&video->irqlock, flags);
469 buf->vb.v4l2_buf.timestamp.tv_sec = ts.tv_sec;
470 buf->vb.v4l2_buf.timestamp.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
472 /* Do frame number propagation only if this is the output video node.
473 * Frame number either comes from the CSI receivers or it gets
474 * incremented here if H3A is not active.
475 * Note: There is no guarantee that the output buffer will finish
476 * first, so the input number might lag behind by 1 in some cases.
478 if (video == pipe->output && !pipe->do_propagation)
479 buf->vb.v4l2_buf.sequence =
480 atomic_inc_return(&pipe->frame_number);
482 buf->vb.v4l2_buf.sequence = atomic_read(&pipe->frame_number);
484 if (pipe->field != V4L2_FIELD_NONE)
485 buf->vb.v4l2_buf.sequence /= 2;
487 buf->vb.v4l2_buf.field = pipe->field;
489 /* Report pipeline errors to userspace on the capture device side. */
490 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE && pipe->error) {
491 state = VB2_BUF_STATE_ERROR;
494 state = VB2_BUF_STATE_DONE;
497 vb2_buffer_done(&buf->vb, state);
499 spin_lock_irqsave(&video->irqlock, flags);
501 if (list_empty(&video->dmaqueue)) {
502 spin_unlock_irqrestore(&video->irqlock, flags);
504 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
505 state = ISP_PIPELINE_QUEUE_OUTPUT
506 | ISP_PIPELINE_STREAM;
508 state = ISP_PIPELINE_QUEUE_INPUT
509 | ISP_PIPELINE_STREAM;
511 spin_lock_irqsave(&pipe->lock, flags);
512 pipe->state &= ~state;
513 if (video->pipe.stream_state == ISP_PIPELINE_STREAM_CONTINUOUS)
514 video->dmaqueue_flags |= ISP_VIDEO_DMAQUEUE_UNDERRUN;
515 spin_unlock_irqrestore(&pipe->lock, flags);
519 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE && pipe->input != NULL) {
520 spin_lock(&pipe->lock);
521 pipe->state &= ~ISP_PIPELINE_STREAM;
522 spin_unlock(&pipe->lock);
525 buf = list_first_entry(&video->dmaqueue, struct isp_buffer,
527 buf->vb.state = VB2_BUF_STATE_ACTIVE;
529 spin_unlock_irqrestore(&video->irqlock, flags);
535 * omap3isp_video_cancel_stream - Cancel stream on a video node
536 * @video: ISP video object
538 * Cancelling a stream mark all buffers on the video node as erroneous and makes
539 * sure no new buffer can be queued.
541 void omap3isp_video_cancel_stream(struct isp_video *video)
545 spin_lock_irqsave(&video->irqlock, flags);
547 while (!list_empty(&video->dmaqueue)) {
548 struct isp_buffer *buf;
550 buf = list_first_entry(&video->dmaqueue,
551 struct isp_buffer, irqlist);
552 list_del(&buf->irqlist);
553 vb2_buffer_done(&buf->vb, VB2_BUF_STATE_ERROR);
558 spin_unlock_irqrestore(&video->irqlock, flags);
562 * omap3isp_video_resume - Perform resume operation on the buffers
563 * @video: ISP video object
564 * @continuous: Pipeline is in single shot mode if 0 or continuous mode otherwise
566 * This function is intended to be used on suspend/resume scenario. It
567 * requests video queue layer to discard buffers marked as DONE if it's in
568 * continuous mode and requests ISP modules to queue again the ACTIVE buffer
571 void omap3isp_video_resume(struct isp_video *video, int continuous)
573 struct isp_buffer *buf = NULL;
575 if (continuous && video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE) {
576 mutex_lock(&video->queue_lock);
577 vb2_discard_done(video->queue);
578 mutex_unlock(&video->queue_lock);
581 if (!list_empty(&video->dmaqueue)) {
582 buf = list_first_entry(&video->dmaqueue,
583 struct isp_buffer, irqlist);
584 video->ops->queue(video, buf);
585 video->dmaqueue_flags |= ISP_VIDEO_DMAQUEUE_QUEUED;
588 video->dmaqueue_flags |= ISP_VIDEO_DMAQUEUE_UNDERRUN;
592 /* -----------------------------------------------------------------------------
597 isp_video_querycap(struct file *file, void *fh, struct v4l2_capability *cap)
599 struct isp_video *video = video_drvdata(file);
601 strlcpy(cap->driver, ISP_VIDEO_DRIVER_NAME, sizeof(cap->driver));
602 strlcpy(cap->card, video->video.name, sizeof(cap->card));
603 strlcpy(cap->bus_info, "media", sizeof(cap->bus_info));
605 cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_VIDEO_OUTPUT
606 | V4L2_CAP_STREAMING | V4L2_CAP_DEVICE_CAPS;
608 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
609 cap->device_caps = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_STREAMING;
611 cap->device_caps = V4L2_CAP_VIDEO_OUTPUT | V4L2_CAP_STREAMING;
617 isp_video_get_format(struct file *file, void *fh, struct v4l2_format *format)
619 struct isp_video_fh *vfh = to_isp_video_fh(fh);
620 struct isp_video *video = video_drvdata(file);
622 if (format->type != video->type)
625 mutex_lock(&video->mutex);
626 *format = vfh->format;
627 mutex_unlock(&video->mutex);
633 isp_video_set_format(struct file *file, void *fh, struct v4l2_format *format)
635 struct isp_video_fh *vfh = to_isp_video_fh(fh);
636 struct isp_video *video = video_drvdata(file);
637 struct v4l2_mbus_framefmt fmt;
639 if (format->type != video->type)
642 /* Replace unsupported field orders with sane defaults. */
643 switch (format->fmt.pix.field) {
644 case V4L2_FIELD_NONE:
645 /* Progressive is supported everywhere. */
647 case V4L2_FIELD_ALTERNATE:
648 /* ALTERNATE is not supported on output nodes. */
649 if (video->type == V4L2_BUF_TYPE_VIDEO_OUTPUT)
650 format->fmt.pix.field = V4L2_FIELD_NONE;
652 case V4L2_FIELD_INTERLACED:
653 /* The ISP has no concept of video standard, select the
654 * top-bottom order when the unqualified interlaced order is
657 format->fmt.pix.field = V4L2_FIELD_INTERLACED_TB;
659 case V4L2_FIELD_INTERLACED_TB:
660 case V4L2_FIELD_INTERLACED_BT:
661 /* Interlaced orders are only supported at the CCDC output. */
662 if (video != &video->isp->isp_ccdc.video_out)
663 format->fmt.pix.field = V4L2_FIELD_NONE;
666 case V4L2_FIELD_BOTTOM:
667 case V4L2_FIELD_SEQ_TB:
668 case V4L2_FIELD_SEQ_BT:
670 /* All other field orders are currently unsupported, default to
673 format->fmt.pix.field = V4L2_FIELD_NONE;
677 /* Fill the bytesperline and sizeimage fields by converting to media bus
678 * format and back to pixel format.
680 isp_video_pix_to_mbus(&format->fmt.pix, &fmt);
681 isp_video_mbus_to_pix(video, &fmt, &format->fmt.pix);
683 mutex_lock(&video->mutex);
684 vfh->format = *format;
685 mutex_unlock(&video->mutex);
691 isp_video_try_format(struct file *file, void *fh, struct v4l2_format *format)
693 struct isp_video *video = video_drvdata(file);
694 struct v4l2_subdev_format fmt;
695 struct v4l2_subdev *subdev;
699 if (format->type != video->type)
702 subdev = isp_video_remote_subdev(video, &pad);
706 isp_video_pix_to_mbus(&format->fmt.pix, &fmt.format);
709 fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
710 ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &fmt);
712 return ret == -ENOIOCTLCMD ? -ENOTTY : ret;
714 isp_video_mbus_to_pix(video, &fmt.format, &format->fmt.pix);
719 isp_video_cropcap(struct file *file, void *fh, struct v4l2_cropcap *cropcap)
721 struct isp_video *video = video_drvdata(file);
722 struct v4l2_subdev *subdev;
725 subdev = isp_video_remote_subdev(video, NULL);
729 mutex_lock(&video->mutex);
730 ret = v4l2_subdev_call(subdev, video, cropcap, cropcap);
731 mutex_unlock(&video->mutex);
733 return ret == -ENOIOCTLCMD ? -ENOTTY : ret;
737 isp_video_get_crop(struct file *file, void *fh, struct v4l2_crop *crop)
739 struct isp_video *video = video_drvdata(file);
740 struct v4l2_subdev_format format;
741 struct v4l2_subdev *subdev;
745 subdev = isp_video_remote_subdev(video, &pad);
749 /* Try the get crop operation first and fallback to get format if not
752 ret = v4l2_subdev_call(subdev, video, g_crop, crop);
753 if (ret != -ENOIOCTLCMD)
757 format.which = V4L2_SUBDEV_FORMAT_ACTIVE;
758 ret = v4l2_subdev_call(subdev, pad, get_fmt, NULL, &format);
760 return ret == -ENOIOCTLCMD ? -ENOTTY : ret;
764 crop->c.width = format.format.width;
765 crop->c.height = format.format.height;
771 isp_video_set_crop(struct file *file, void *fh, const struct v4l2_crop *crop)
773 struct isp_video *video = video_drvdata(file);
774 struct v4l2_subdev *subdev;
777 subdev = isp_video_remote_subdev(video, NULL);
781 mutex_lock(&video->mutex);
782 ret = v4l2_subdev_call(subdev, video, s_crop, crop);
783 mutex_unlock(&video->mutex);
785 return ret == -ENOIOCTLCMD ? -ENOTTY : ret;
789 isp_video_get_param(struct file *file, void *fh, struct v4l2_streamparm *a)
791 struct isp_video_fh *vfh = to_isp_video_fh(fh);
792 struct isp_video *video = video_drvdata(file);
794 if (video->type != V4L2_BUF_TYPE_VIDEO_OUTPUT ||
795 video->type != a->type)
798 memset(a, 0, sizeof(*a));
799 a->type = V4L2_BUF_TYPE_VIDEO_OUTPUT;
800 a->parm.output.capability = V4L2_CAP_TIMEPERFRAME;
801 a->parm.output.timeperframe = vfh->timeperframe;
807 isp_video_set_param(struct file *file, void *fh, struct v4l2_streamparm *a)
809 struct isp_video_fh *vfh = to_isp_video_fh(fh);
810 struct isp_video *video = video_drvdata(file);
812 if (video->type != V4L2_BUF_TYPE_VIDEO_OUTPUT ||
813 video->type != a->type)
816 if (a->parm.output.timeperframe.denominator == 0)
817 a->parm.output.timeperframe.denominator = 1;
819 vfh->timeperframe = a->parm.output.timeperframe;
825 isp_video_reqbufs(struct file *file, void *fh, struct v4l2_requestbuffers *rb)
827 struct isp_video_fh *vfh = to_isp_video_fh(fh);
828 struct isp_video *video = video_drvdata(file);
831 mutex_lock(&video->queue_lock);
832 ret = vb2_reqbufs(&vfh->queue, rb);
833 mutex_unlock(&video->queue_lock);
839 isp_video_querybuf(struct file *file, void *fh, struct v4l2_buffer *b)
841 struct isp_video_fh *vfh = to_isp_video_fh(fh);
842 struct isp_video *video = video_drvdata(file);
845 mutex_lock(&video->queue_lock);
846 ret = vb2_querybuf(&vfh->queue, b);
847 mutex_unlock(&video->queue_lock);
853 isp_video_qbuf(struct file *file, void *fh, struct v4l2_buffer *b)
855 struct isp_video_fh *vfh = to_isp_video_fh(fh);
856 struct isp_video *video = video_drvdata(file);
859 mutex_lock(&video->queue_lock);
860 ret = vb2_qbuf(&vfh->queue, b);
861 mutex_unlock(&video->queue_lock);
867 isp_video_dqbuf(struct file *file, void *fh, struct v4l2_buffer *b)
869 struct isp_video_fh *vfh = to_isp_video_fh(fh);
870 struct isp_video *video = video_drvdata(file);
873 mutex_lock(&video->queue_lock);
874 ret = vb2_dqbuf(&vfh->queue, b, file->f_flags & O_NONBLOCK);
875 mutex_unlock(&video->queue_lock);
880 static int isp_video_check_external_subdevs(struct isp_video *video,
881 struct isp_pipeline *pipe)
883 struct isp_device *isp = video->isp;
884 struct media_entity *ents[] = {
885 &isp->isp_csi2a.subdev.entity,
886 &isp->isp_csi2c.subdev.entity,
887 &isp->isp_ccp2.subdev.entity,
888 &isp->isp_ccdc.subdev.entity
890 struct media_pad *source_pad;
891 struct media_entity *source = NULL;
892 struct media_entity *sink;
893 struct v4l2_subdev_format fmt;
894 struct v4l2_ext_controls ctrls;
895 struct v4l2_ext_control ctrl;
899 /* Memory-to-memory pipelines have no external subdev. */
900 if (pipe->input != NULL)
903 for (i = 0; i < ARRAY_SIZE(ents); i++) {
904 /* Is the entity part of the pipeline? */
905 if (!(pipe->entities & (1 << ents[i]->id)))
908 /* ISP entities have always sink pad == 0. Find source. */
909 source_pad = media_entity_remote_pad(&ents[i]->pads[0]);
910 if (source_pad == NULL)
913 source = source_pad->entity;
919 dev_warn(isp->dev, "can't find source, failing now\n");
923 if (media_entity_type(source) != MEDIA_ENT_T_V4L2_SUBDEV)
926 pipe->external = media_entity_to_v4l2_subdev(source);
928 fmt.pad = source_pad->index;
929 fmt.which = V4L2_SUBDEV_FORMAT_ACTIVE;
930 ret = v4l2_subdev_call(media_entity_to_v4l2_subdev(sink),
931 pad, get_fmt, NULL, &fmt);
932 if (unlikely(ret < 0)) {
933 dev_warn(isp->dev, "get_fmt returned null!\n");
937 pipe->external_width =
938 omap3isp_video_format_info(fmt.format.code)->width;
940 memset(&ctrls, 0, sizeof(ctrls));
941 memset(&ctrl, 0, sizeof(ctrl));
943 ctrl.id = V4L2_CID_PIXEL_RATE;
946 ctrls.controls = &ctrl;
948 ret = v4l2_g_ext_ctrls(pipe->external->ctrl_handler, &ctrls);
950 dev_warn(isp->dev, "no pixel rate control in subdev %s\n",
951 pipe->external->name);
955 pipe->external_rate = ctrl.value64;
957 if (pipe->entities & (1 << isp->isp_ccdc.subdev.entity.id)) {
958 unsigned int rate = UINT_MAX;
960 * Check that maximum allowed CCDC pixel rate isn't
961 * exceeded by the pixel rate.
963 omap3isp_ccdc_max_rate(&isp->isp_ccdc, &rate);
964 if (pipe->external_rate > rate)
974 * Every ISP pipeline has a single input and a single output. The input can be
975 * either a sensor or a video node. The output is always a video node.
977 * As every pipeline has an output video node, the ISP video objects at the
978 * pipeline output stores the pipeline state. It tracks the streaming state of
979 * both the input and output, as well as the availability of buffers.
981 * In sensor-to-memory mode, frames are always available at the pipeline input.
982 * Starting the sensor usually requires I2C transfers and must be done in
983 * interruptible context. The pipeline is started and stopped synchronously
984 * to the stream on/off commands. All modules in the pipeline will get their
985 * subdev set stream handler called. The module at the end of the pipeline must
986 * delay starting the hardware until buffers are available at its output.
988 * In memory-to-memory mode, starting/stopping the stream requires
989 * synchronization between the input and output. ISP modules can't be stopped
990 * in the middle of a frame, and at least some of the modules seem to become
991 * busy as soon as they're started, even if they don't receive a frame start
992 * event. For that reason frames need to be processed in single-shot mode. The
993 * driver needs to wait until a frame is completely processed and written to
994 * memory before restarting the pipeline for the next frame. Pipelined
995 * processing might be possible but requires more testing.
997 * Stream start must be delayed until buffers are available at both the input
998 * and output. The pipeline must be started in the videobuf queue callback with
999 * the buffers queue spinlock held. The modules subdev set stream operation must
1003 isp_video_streamon(struct file *file, void *fh, enum v4l2_buf_type type)
1005 struct isp_video_fh *vfh = to_isp_video_fh(fh);
1006 struct isp_video *video = video_drvdata(file);
1007 enum isp_pipeline_state state;
1008 struct isp_pipeline *pipe;
1009 unsigned long flags;
1012 if (type != video->type)
1015 mutex_lock(&video->stream_lock);
1017 /* Start streaming on the pipeline. No link touching an entity in the
1018 * pipeline can be activated or deactivated once streaming is started.
1020 pipe = video->video.entity.pipe
1021 ? to_isp_pipeline(&video->video.entity) : &video->pipe;
1025 if (video->isp->pdata->set_constraints)
1026 video->isp->pdata->set_constraints(video->isp, true);
1027 pipe->l3_ick = clk_get_rate(video->isp->clock[ISP_CLK_L3_ICK]);
1028 pipe->max_rate = pipe->l3_ick;
1030 ret = media_entity_pipeline_start(&video->video.entity, &pipe->pipe);
1032 goto err_pipeline_start;
1034 /* Verify that the currently configured format matches the output of
1035 * the connected subdev.
1037 ret = isp_video_check_format(video, vfh);
1039 goto err_check_format;
1041 video->bpl_padding = ret;
1042 video->bpl_value = vfh->format.fmt.pix.bytesperline;
1044 ret = isp_video_get_graph_data(video, pipe);
1046 goto err_check_format;
1048 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
1049 state = ISP_PIPELINE_STREAM_OUTPUT | ISP_PIPELINE_IDLE_OUTPUT;
1051 state = ISP_PIPELINE_STREAM_INPUT | ISP_PIPELINE_IDLE_INPUT;
1053 ret = isp_video_check_external_subdevs(video, pipe);
1055 goto err_check_format;
1057 pipe->error = false;
1059 spin_lock_irqsave(&pipe->lock, flags);
1060 pipe->state &= ~ISP_PIPELINE_STREAM;
1061 pipe->state |= state;
1062 spin_unlock_irqrestore(&pipe->lock, flags);
1064 /* Set the maximum time per frame as the value requested by userspace.
1065 * This is a soft limit that can be overridden if the hardware doesn't
1066 * support the request limit.
1068 if (video->type == V4L2_BUF_TYPE_VIDEO_OUTPUT)
1069 pipe->max_timeperframe = vfh->timeperframe;
1071 video->queue = &vfh->queue;
1072 INIT_LIST_HEAD(&video->dmaqueue);
1073 atomic_set(&pipe->frame_number, -1);
1074 pipe->field = vfh->format.fmt.pix.field;
1076 mutex_lock(&video->queue_lock);
1077 ret = vb2_streamon(&vfh->queue, type);
1078 mutex_unlock(&video->queue_lock);
1080 goto err_check_format;
1082 /* In sensor-to-memory mode, the stream can be started synchronously
1083 * to the stream on command. In memory-to-memory mode, it will be
1084 * started when buffers are queued on both the input and output.
1086 if (pipe->input == NULL) {
1087 ret = omap3isp_pipeline_set_stream(pipe,
1088 ISP_PIPELINE_STREAM_CONTINUOUS);
1090 goto err_set_stream;
1091 spin_lock_irqsave(&video->irqlock, flags);
1092 if (list_empty(&video->dmaqueue))
1093 video->dmaqueue_flags |= ISP_VIDEO_DMAQUEUE_UNDERRUN;
1094 spin_unlock_irqrestore(&video->irqlock, flags);
1097 mutex_unlock(&video->stream_lock);
1101 mutex_lock(&video->queue_lock);
1102 vb2_streamoff(&vfh->queue, type);
1103 mutex_unlock(&video->queue_lock);
1105 media_entity_pipeline_stop(&video->video.entity);
1107 if (video->isp->pdata->set_constraints)
1108 video->isp->pdata->set_constraints(video->isp, false);
1109 /* The DMA queue must be emptied here, otherwise CCDC interrupts that
1110 * will get triggered the next time the CCDC is powered up will try to
1111 * access buffers that might have been freed but still present in the
1112 * DMA queue. This can easily get triggered if the above
1113 * omap3isp_pipeline_set_stream() call fails on a system with a
1114 * free-running sensor.
1116 INIT_LIST_HEAD(&video->dmaqueue);
1117 video->queue = NULL;
1119 mutex_unlock(&video->stream_lock);
1124 isp_video_streamoff(struct file *file, void *fh, enum v4l2_buf_type type)
1126 struct isp_video_fh *vfh = to_isp_video_fh(fh);
1127 struct isp_video *video = video_drvdata(file);
1128 struct isp_pipeline *pipe = to_isp_pipeline(&video->video.entity);
1129 enum isp_pipeline_state state;
1130 unsigned int streaming;
1131 unsigned long flags;
1133 if (type != video->type)
1136 mutex_lock(&video->stream_lock);
1138 /* Make sure we're not streaming yet. */
1139 mutex_lock(&video->queue_lock);
1140 streaming = vb2_is_streaming(&vfh->queue);
1141 mutex_unlock(&video->queue_lock);
1146 /* Update the pipeline state. */
1147 if (video->type == V4L2_BUF_TYPE_VIDEO_CAPTURE)
1148 state = ISP_PIPELINE_STREAM_OUTPUT
1149 | ISP_PIPELINE_QUEUE_OUTPUT;
1151 state = ISP_PIPELINE_STREAM_INPUT
1152 | ISP_PIPELINE_QUEUE_INPUT;
1154 spin_lock_irqsave(&pipe->lock, flags);
1155 pipe->state &= ~state;
1156 spin_unlock_irqrestore(&pipe->lock, flags);
1158 /* Stop the stream. */
1159 omap3isp_pipeline_set_stream(pipe, ISP_PIPELINE_STREAM_STOPPED);
1160 omap3isp_video_cancel_stream(video);
1162 mutex_lock(&video->queue_lock);
1163 vb2_streamoff(&vfh->queue, type);
1164 mutex_unlock(&video->queue_lock);
1165 video->queue = NULL;
1166 video->error = false;
1168 if (video->isp->pdata->set_constraints)
1169 video->isp->pdata->set_constraints(video->isp, false);
1170 media_entity_pipeline_stop(&video->video.entity);
1173 mutex_unlock(&video->stream_lock);
1178 isp_video_enum_input(struct file *file, void *fh, struct v4l2_input *input)
1180 if (input->index > 0)
1183 strlcpy(input->name, "camera", sizeof(input->name));
1184 input->type = V4L2_INPUT_TYPE_CAMERA;
1190 isp_video_g_input(struct file *file, void *fh, unsigned int *input)
1198 isp_video_s_input(struct file *file, void *fh, unsigned int input)
1200 return input == 0 ? 0 : -EINVAL;
1203 static const struct v4l2_ioctl_ops isp_video_ioctl_ops = {
1204 .vidioc_querycap = isp_video_querycap,
1205 .vidioc_g_fmt_vid_cap = isp_video_get_format,
1206 .vidioc_s_fmt_vid_cap = isp_video_set_format,
1207 .vidioc_try_fmt_vid_cap = isp_video_try_format,
1208 .vidioc_g_fmt_vid_out = isp_video_get_format,
1209 .vidioc_s_fmt_vid_out = isp_video_set_format,
1210 .vidioc_try_fmt_vid_out = isp_video_try_format,
1211 .vidioc_cropcap = isp_video_cropcap,
1212 .vidioc_g_crop = isp_video_get_crop,
1213 .vidioc_s_crop = isp_video_set_crop,
1214 .vidioc_g_parm = isp_video_get_param,
1215 .vidioc_s_parm = isp_video_set_param,
1216 .vidioc_reqbufs = isp_video_reqbufs,
1217 .vidioc_querybuf = isp_video_querybuf,
1218 .vidioc_qbuf = isp_video_qbuf,
1219 .vidioc_dqbuf = isp_video_dqbuf,
1220 .vidioc_streamon = isp_video_streamon,
1221 .vidioc_streamoff = isp_video_streamoff,
1222 .vidioc_enum_input = isp_video_enum_input,
1223 .vidioc_g_input = isp_video_g_input,
1224 .vidioc_s_input = isp_video_s_input,
1227 /* -----------------------------------------------------------------------------
1228 * V4L2 file operations
1231 static int isp_video_open(struct file *file)
1233 struct isp_video *video = video_drvdata(file);
1234 struct isp_video_fh *handle;
1235 struct vb2_queue *queue;
1238 handle = kzalloc(sizeof(*handle), GFP_KERNEL);
1242 v4l2_fh_init(&handle->vfh, &video->video);
1243 v4l2_fh_add(&handle->vfh);
1245 /* If this is the first user, initialise the pipeline. */
1246 if (omap3isp_get(video->isp) == NULL) {
1251 ret = omap3isp_pipeline_pm_use(&video->video.entity, 1);
1253 omap3isp_put(video->isp);
1257 queue = &handle->queue;
1258 queue->type = video->type;
1259 queue->io_modes = VB2_MMAP | VB2_USERPTR;
1260 queue->drv_priv = handle;
1261 queue->ops = &isp_video_queue_ops;
1262 queue->mem_ops = &vb2_dma_contig_memops;
1263 queue->buf_struct_size = sizeof(struct isp_buffer);
1264 queue->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_MONOTONIC;
1266 ret = vb2_queue_init(&handle->queue);
1268 omap3isp_put(video->isp);
1272 memset(&handle->format, 0, sizeof(handle->format));
1273 handle->format.type = video->type;
1274 handle->timeperframe.denominator = 1;
1276 handle->video = video;
1277 file->private_data = &handle->vfh;
1281 v4l2_fh_del(&handle->vfh);
1288 static int isp_video_release(struct file *file)
1290 struct isp_video *video = video_drvdata(file);
1291 struct v4l2_fh *vfh = file->private_data;
1292 struct isp_video_fh *handle = to_isp_video_fh(vfh);
1294 /* Disable streaming and free the buffers queue resources. */
1295 isp_video_streamoff(file, vfh, video->type);
1297 mutex_lock(&video->queue_lock);
1298 vb2_queue_release(&handle->queue);
1299 mutex_unlock(&video->queue_lock);
1301 omap3isp_pipeline_pm_use(&video->video.entity, 0);
1303 /* Release the file handle. */
1306 file->private_data = NULL;
1308 omap3isp_put(video->isp);
1313 static unsigned int isp_video_poll(struct file *file, poll_table *wait)
1315 struct isp_video_fh *vfh = to_isp_video_fh(file->private_data);
1316 struct isp_video *video = video_drvdata(file);
1319 mutex_lock(&video->queue_lock);
1320 ret = vb2_poll(&vfh->queue, file, wait);
1321 mutex_unlock(&video->queue_lock);
1326 static int isp_video_mmap(struct file *file, struct vm_area_struct *vma)
1328 struct isp_video_fh *vfh = to_isp_video_fh(file->private_data);
1329 struct isp_video *video = video_drvdata(file);
1332 mutex_lock(&video->queue_lock);
1333 ret = vb2_mmap(&vfh->queue, vma);
1334 mutex_unlock(&video->queue_lock);
1339 static struct v4l2_file_operations isp_video_fops = {
1340 .owner = THIS_MODULE,
1341 .unlocked_ioctl = video_ioctl2,
1342 .open = isp_video_open,
1343 .release = isp_video_release,
1344 .poll = isp_video_poll,
1345 .mmap = isp_video_mmap,
1348 /* -----------------------------------------------------------------------------
1352 static const struct isp_video_operations isp_video_dummy_ops = {
1355 int omap3isp_video_init(struct isp_video *video, const char *name)
1357 const char *direction;
1360 switch (video->type) {
1361 case V4L2_BUF_TYPE_VIDEO_CAPTURE:
1362 direction = "output";
1363 video->pad.flags = MEDIA_PAD_FL_SINK
1364 | MEDIA_PAD_FL_MUST_CONNECT;
1366 case V4L2_BUF_TYPE_VIDEO_OUTPUT:
1367 direction = "input";
1368 video->pad.flags = MEDIA_PAD_FL_SOURCE
1369 | MEDIA_PAD_FL_MUST_CONNECT;
1370 video->video.vfl_dir = VFL_DIR_TX;
1377 video->alloc_ctx = vb2_dma_contig_init_ctx(video->isp->dev);
1378 if (IS_ERR(video->alloc_ctx))
1379 return PTR_ERR(video->alloc_ctx);
1381 ret = media_entity_init(&video->video.entity, 1, &video->pad, 0);
1383 vb2_dma_contig_cleanup_ctx(video->alloc_ctx);
1387 mutex_init(&video->mutex);
1388 atomic_set(&video->active, 0);
1390 spin_lock_init(&video->pipe.lock);
1391 mutex_init(&video->stream_lock);
1392 mutex_init(&video->queue_lock);
1393 spin_lock_init(&video->irqlock);
1395 /* Initialize the video device. */
1396 if (video->ops == NULL)
1397 video->ops = &isp_video_dummy_ops;
1399 video->video.fops = &isp_video_fops;
1400 snprintf(video->video.name, sizeof(video->video.name),
1401 "OMAP3 ISP %s %s", name, direction);
1402 video->video.vfl_type = VFL_TYPE_GRABBER;
1403 video->video.release = video_device_release_empty;
1404 video->video.ioctl_ops = &isp_video_ioctl_ops;
1405 video->pipe.stream_state = ISP_PIPELINE_STREAM_STOPPED;
1407 video_set_drvdata(&video->video, video);
1412 void omap3isp_video_cleanup(struct isp_video *video)
1414 vb2_dma_contig_cleanup_ctx(video->alloc_ctx);
1415 media_entity_cleanup(&video->video.entity);
1416 mutex_destroy(&video->queue_lock);
1417 mutex_destroy(&video->stream_lock);
1418 mutex_destroy(&video->mutex);
1421 int omap3isp_video_register(struct isp_video *video, struct v4l2_device *vdev)
1425 video->video.v4l2_dev = vdev;
1427 ret = video_register_device(&video->video, VFL_TYPE_GRABBER, -1);
1429 dev_err(video->isp->dev,
1430 "%s: could not register video device (%d)\n",
1436 void omap3isp_video_unregister(struct isp_video *video)
1438 if (video_is_registered(&video->video))
1439 video_unregister_device(&video->video);