drivers/net/bonding/bond_options.c

   1 /*
   2  * drivers/net/bond/bond_options.c - bonding options
   3  * Copyright (c) 2013 Jiri Pirko <jiri@resnulli.us>
   4  * Copyright (c) 2013 Scott Feldman <sfeldma@cumulusnetworks.com>
   5  *
   6  * This program is free software; you can redistribute it and/or modify
   7  * it under the terms of the GNU General Public License as published by
   8  * the Free Software Foundation; either version 2 of the License, or
   9  * (at your option) any later version.
  10  */
  11
  12 #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
  13
  14 #include <linux/errno.h>
  15 #include <linux/if.h>
  16 #include <linux/netdevice.h>
  17 #include <linux/rwlock.h>
  18 #include <linux/rcupdate.h>
  19 #include <linux/ctype.h>
  20 #include <linux/inet.h>
  21 #include "bonding.h"
  22
  23 static struct bond_opt_value bond_mode_tbl[] = {
  24         { "balance-rr",    BOND_MODE_ROUNDROBIN,   BOND_VALFLAG_DEFAULT},
  25         { "active-backup", BOND_MODE_ACTIVEBACKUP, 0},
  26         { "balance-xor",   BOND_MODE_XOR,          0},
  27         { "broadcast",     BOND_MODE_BROADCAST,    0},
  28         { "802.3ad",       BOND_MODE_8023AD,       0},
  29         { "balance-tlb",   BOND_MODE_TLB,          0},
  30         { "balance-alb",   BOND_MODE_ALB,          0},
  31         { NULL,            -1,                     0},
  32 };
  33
  34 static struct bond_opt_value bond_pps_tbl[] = {
  35         { "default", 1,         BOND_VALFLAG_DEFAULT},
  36         { "maxval",  USHRT_MAX, BOND_VALFLAG_MAX},
  37         { NULL,      -1,        0},
  38 };
  39
  40 static struct bond_opt_value bond_xmit_hashtype_tbl[] = {
  41         { "layer2",   BOND_XMIT_POLICY_LAYER2, BOND_VALFLAG_DEFAULT},
  42         { "layer3+4", BOND_XMIT_POLICY_LAYER34, 0},
  43         { "layer2+3", BOND_XMIT_POLICY_LAYER23, 0},
  44         { "encap2+3", BOND_XMIT_POLICY_ENCAP23, 0},
  45         { "encap3+4", BOND_XMIT_POLICY_ENCAP34, 0},
  46         { NULL,       -1,                       0},
  47 };
  48
  49 static struct bond_opt_value bond_arp_validate_tbl[] = {
  50         { "none",   BOND_ARP_VALIDATE_NONE,   BOND_VALFLAG_DEFAULT},
  51         { "active", BOND_ARP_VALIDATE_ACTIVE, 0},
  52         { "backup", BOND_ARP_VALIDATE_BACKUP, 0},
  53         { "all",    BOND_ARP_VALIDATE_ALL,    0},
  54         { NULL,     -1,                       0},
  55 };
  56
  57 static struct bond_opt_value bond_arp_all_targets_tbl[] = {
  58         { "any", BOND_ARP_TARGETS_ANY, BOND_VALFLAG_DEFAULT},
  59         { "all", BOND_ARP_TARGETS_ALL, 0},
  60         { NULL,  -1,                   0},
  61 };
  62
  63 static struct bond_opt_value bond_fail_over_mac_tbl[] = {
  64         { "none",   BOND_FOM_NONE,   BOND_VALFLAG_DEFAULT},
  65         { "active", BOND_FOM_ACTIVE, 0},
  66         { "follow", BOND_FOM_FOLLOW, 0},
  67         { NULL,     -1,              0},
  68 };
  69
  70 static struct bond_opt_value bond_intmax_tbl[] = {
  71         { "off",     0,       BOND_VALFLAG_DEFAULT},
  72         { "maxval",  INT_MAX, BOND_VALFLAG_MAX},
  73 };
  74
  75 static struct bond_opt_value bond_lacp_rate_tbl[] = {
  76         { "slow", AD_LACP_SLOW, 0},
  77         { "fast", AD_LACP_FAST, 0},
  78         { NULL,   -1,           0},
  79 };
  80
  81 static struct bond_opt_value bond_ad_select_tbl[] = {
  82         { "stable",    BOND_AD_STABLE,    BOND_VALFLAG_DEFAULT},
  83         { "bandwidth", BOND_AD_BANDWIDTH, 0},
  84         { "count",     BOND_AD_COUNT,     0},
  85         { NULL,        -1,                0},
  86 };
  87
  88 static struct bond_opt_value bond_num_peer_notif_tbl[] = {
  89         { "off",     0,   0},
  90         { "maxval",  255, BOND_VALFLAG_MAX},
  91         { "default", 1,   BOND_VALFLAG_DEFAULT},
  92         { NULL,      -1,  0}
  93 };
  94
  95 static struct bond_opt_value bond_primary_reselect_tbl[] = {
  96         { "always",  BOND_PRI_RESELECT_ALWAYS,  BOND_VALFLAG_DEFAULT},
  97         { "better",  BOND_PRI_RESELECT_BETTER,  0},
  98         { "failure", BOND_PRI_RESELECT_FAILURE, 0},
  99         { NULL,      -1},
 100 };
 101
 102 static struct bond_opt_value bond_use_carrier_tbl[] = {
 103         { "off", 0,  0},
 104         { "on",  1,  BOND_VALFLAG_DEFAULT},
 105         { NULL,  -1, 0}
 106 };
 107
 108 static struct bond_opt_value bond_all_slaves_active_tbl[] = {
 109         { "off", 0,  BOND_VALFLAG_DEFAULT},
 110         { "on",  1,  0},
 111         { NULL,  -1, 0}
 112 };
 113
 114 static struct bond_opt_value bond_resend_igmp_tbl[] = {
 115         { "off",     0,   0},
 116         { "maxval",  255, BOND_VALFLAG_MAX},
 117         { "default", 1,   BOND_VALFLAG_DEFAULT},
 118         { NULL,      -1,  0}
 119 };
 120
 121 static struct bond_opt_value bond_lp_interval_tbl[] = {
 122         { "minval",  1,       BOND_VALFLAG_MIN | BOND_VALFLAG_DEFAULT},
 123         { "maxval",  INT_MAX, BOND_VALFLAG_MAX},
 124 };
 125
 126 static struct bond_option bond_opts[] = {
 127         [BOND_OPT_MODE] = {
 128                 .id = BOND_OPT_MODE,
 129                 .name = "mode",
 130                 .desc = "bond device mode",
 131                 .flags = BOND_OPTFLAG_NOSLAVES | BOND_OPTFLAG_IFDOWN,
 132                 .values = bond_mode_tbl,
 133                 .set = bond_option_mode_set
 134         },
 135         [BOND_OPT_PACKETS_PER_SLAVE] = {
 136                 .id = BOND_OPT_PACKETS_PER_SLAVE,
 137                 .name = "packets_per_slave",
 138                 .desc = "Packets to send per slave in RR mode",
 139                 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ROUNDROBIN)),
 140                 .values = bond_pps_tbl,
 141                 .set = bond_option_pps_set
 142         },
 143         [BOND_OPT_XMIT_HASH] = {
 144                 .id = BOND_OPT_XMIT_HASH,
 145                 .name = "xmit_hash_policy",
 146                 .desc = "balance-xor and 802.3ad hashing method",
 147                 .values = bond_xmit_hashtype_tbl,
 148                 .set = bond_option_xmit_hash_policy_set
 149         },
 150         [BOND_OPT_ARP_VALIDATE] = {
 151                 .id = BOND_OPT_ARP_VALIDATE,
 152                 .name = "arp_validate",
 153                 .desc = "validate src/dst of ARP probes",
 154                 .unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
 155                                BIT(BOND_MODE_ALB),
 156                 .values = bond_arp_validate_tbl,
 157                 .set = bond_option_arp_validate_set
 158         },
 159         [BOND_OPT_ARP_ALL_TARGETS] = {
 160                 .id = BOND_OPT_ARP_ALL_TARGETS,
 161                 .name = "arp_all_targets",
 162                 .desc = "fail on any/all arp targets timeout",
 163                 .values = bond_arp_all_targets_tbl,
 164                 .set = bond_option_arp_all_targets_set
 165         },
 166         [BOND_OPT_FAIL_OVER_MAC] = {
 167                 .id = BOND_OPT_FAIL_OVER_MAC,
 168                 .name = "fail_over_mac",
 169                 .desc = "For active-backup, do not set all slaves to the same MAC",
 170                 .flags = BOND_OPTFLAG_NOSLAVES,
 171                 .values = bond_fail_over_mac_tbl,
 172                 .set = bond_option_fail_over_mac_set
 173         },
 174         [BOND_OPT_ARP_INTERVAL] = {
 175                 .id = BOND_OPT_ARP_INTERVAL,
 176                 .name = "arp_interval",
 177                 .desc = "arp interval in milliseconds",
 178                 .unsuppmodes = BIT(BOND_MODE_8023AD) | BIT(BOND_MODE_TLB) |
 179                                BIT(BOND_MODE_ALB),
 180                 .values = bond_intmax_tbl,
 181                 .set = bond_option_arp_interval_set
 182         },
 183         [BOND_OPT_ARP_TARGETS] = {
 184                 .id = BOND_OPT_ARP_TARGETS,
 185                 .name = "arp_ip_target",
 186                 .desc = "arp targets in n.n.n.n form",
 187                 .flags = BOND_OPTFLAG_RAWVAL,
 188                 .set = bond_option_arp_ip_targets_set
 189         },
 190         [BOND_OPT_DOWNDELAY] = {
 191                 .id = BOND_OPT_DOWNDELAY,
 192                 .name = "downdelay",
 193                 .desc = "Delay before considering link down, in milliseconds",
 194                 .values = bond_intmax_tbl,
 195                 .set = bond_option_downdelay_set
 196         },
 197         [BOND_OPT_UPDELAY] = {
 198                 .id = BOND_OPT_UPDELAY,
 199                 .name = "updelay",
 200                 .desc = "Delay before considering link up, in milliseconds",
 201                 .values = bond_intmax_tbl,
 202                 .set = bond_option_updelay_set
 203         },
 204         [BOND_OPT_LACP_RATE] = {
 205                 .id = BOND_OPT_LACP_RATE,
 206                 .name = "lacp_rate",
 207                 .desc = "LACPDU tx rate to request from 802.3ad partner",
 208                 .flags = BOND_OPTFLAG_IFDOWN,
 209                 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_8023AD)),
 210                 .values = bond_lacp_rate_tbl,
 211                 .set = bond_option_lacp_rate_set
 212         },
 213         [BOND_OPT_MINLINKS] = {
 214                 .id = BOND_OPT_MINLINKS,
 215                 .name = "min_links",
 216                 .desc = "Minimum number of available links before turning on carrier",
 217                 .values = bond_intmax_tbl,
 218                 .set = bond_option_min_links_set
 219         },
 220         [BOND_OPT_AD_SELECT] = {
 221                 .id = BOND_OPT_AD_SELECT,
 222                 .name = "ad_select",
 223                 .desc = "803.ad aggregation selection logic",
 224                 .flags = BOND_OPTFLAG_IFDOWN,
 225                 .values = bond_ad_select_tbl,
 226                 .set = bond_option_ad_select_set
 227         },
 228         [BOND_OPT_NUM_PEER_NOTIF] = {
 229                 .id = BOND_OPT_NUM_PEER_NOTIF,
 230                 .name = "num_unsol_na",
 231                 .desc = "Number of peer notifications to send on failover event",
 232                 .values = bond_num_peer_notif_tbl,
 233                 .set = bond_option_num_peer_notif_set
 234         },
 235         [BOND_OPT_MIIMON] = {
 236                 .id = BOND_OPT_MIIMON,
 237                 .name = "miimon",
 238                 .desc = "Link check interval in milliseconds",
 239                 .values = bond_intmax_tbl,
 240                 .set = bond_option_miimon_set
 241         },
 242         [BOND_OPT_PRIMARY] = {
 243                 .id = BOND_OPT_PRIMARY,
 244                 .name = "primary",
 245                 .desc = "Primary network device to use",
 246                 .flags = BOND_OPTFLAG_RAWVAL,
 247                 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
 248                                                 BIT(BOND_MODE_TLB) |
 249                                                 BIT(BOND_MODE_ALB)),
 250                 .set = bond_option_primary_set
 251         },
 252         [BOND_OPT_PRIMARY_RESELECT] = {
 253                 .id = BOND_OPT_PRIMARY_RESELECT,
 254                 .name = "primary_reselect",
 255                 .desc = "Reselect primary slave once it comes up",
 256                 .values = bond_primary_reselect_tbl,
 257                 .set = bond_option_primary_reselect_set
 258         },
 259         [BOND_OPT_USE_CARRIER] = {
 260                 .id = BOND_OPT_USE_CARRIER,
 261                 .name = "use_carrier",
 262                 .desc = "Use netif_carrier_ok (vs MII ioctls) in miimon",
 263                 .values = bond_use_carrier_tbl,
 264                 .set = bond_option_use_carrier_set
 265         },
 266         [BOND_OPT_ACTIVE_SLAVE] = {
 267                 .id = BOND_OPT_ACTIVE_SLAVE,
 268                 .name = "active_slave",
 269                 .desc = "Currently active slave",
 270                 .flags = BOND_OPTFLAG_RAWVAL,
 271                 .unsuppmodes = BOND_MODE_ALL_EX(BIT(BOND_MODE_ACTIVEBACKUP) |
 272                                                 BIT(BOND_MODE_TLB) |
 273                                                 BIT(BOND_MODE_ALB)),
 274                 .set = bond_option_active_slave_set
 275         },
 276         [BOND_OPT_QUEUE_ID] = {
 277                 .id = BOND_OPT_QUEUE_ID,
 278                 .name = "queue_id",
 279                 .desc = "Set queue id of a slave",
 280                 .flags = BOND_OPTFLAG_RAWVAL,
 281                 .set = bond_option_queue_id_set
 282         },
 283         [BOND_OPT_ALL_SLAVES_ACTIVE] = {
 284                 .id = BOND_OPT_ALL_SLAVES_ACTIVE,
 285                 .name = "all_slaves_active",
 286                 .desc = "Keep all frames received on an interface by setting active flag for all slaves",
 287                 .values = bond_all_slaves_active_tbl,
 288                 .set = bond_option_all_slaves_active_set
 289         },
 290         [BOND_OPT_RESEND_IGMP] = {
 291                 .id = BOND_OPT_RESEND_IGMP,
 292                 .name = "resend_igmp",
 293                 .desc = "Number of IGMP membership reports to send on link failure",
 294                 .values = bond_resend_igmp_tbl,
 295                 .set = bond_option_resend_igmp_set
 296         },
 297         [BOND_OPT_LP_INTERVAL] = {
 298                 .id = BOND_OPT_LP_INTERVAL,
 299                 .name = "lp_interval",
 300                 .desc = "The number of seconds between instances where the bonding driver sends learning packets to each slave's peer switch",
 301                 .values = bond_lp_interval_tbl,
 302                 .set = bond_option_lp_interval_set
 303         },
 304         [BOND_OPT_SLAVES] = {
 305                 .id = BOND_OPT_SLAVES,
 306                 .name = "slaves",
 307                 .desc = "Slave membership management",
 308                 .flags = BOND_OPTFLAG_RAWVAL,
 309                 .set = bond_option_slaves_set
 310         },
 311         { }
 312 };
 313
 314 /* Searches for a value in opt's values[] table */
 315 struct bond_opt_value *bond_opt_get_val(unsigned int option, u64 val)
 316 {
 317         struct bond_option *opt;
 318         int i;
 319
 320         opt = bond_opt_get(option);
 321         if (WARN_ON(!opt))
 322                 return NULL;
 323         for (i = 0; opt->values && opt->values[i].string; i++)
 324                 if (opt->values[i].value == val)
 325                         return &opt->values[i];
 326
 327         return NULL;
 328 }
 329
 330 /* Searches for a value in opt's values[] table which matches the flagmask */
 331 static struct bond_opt_value *bond_opt_get_flags(const struct bond_option *opt,
 332                                                  u32 flagmask)
 333 {
 334         int i;
 335
 336         for (i = 0; opt->values && opt->values[i].string; i++)
 337                 if (opt->values[i].flags & flagmask)
 338                         return &opt->values[i];
 339
 340         return NULL;
 341 }
 342
 343 /* If maxval is missing then there's no range to check. In case minval is
 344  * missing then it's considered to be 0.
 345  */
 346 static bool bond_opt_check_range(const struct bond_option *opt, u64 val)
 347 {
 348         struct bond_opt_value *minval, *maxval;
 349
 350         minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
 351         maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
 352         if (!maxval || (minval && val < minval->value) || val > maxval->value)
 353                 return false;
 354
 355         return true;
 356 }
 357
 358 /**
 359  * bond_opt_parse - parse option value
 360  * @opt: the option to parse against
 361  * @val: value to parse
 362  *
 363  * This function tries to extract the value from @val and check if it's
 364  * a possible match for the option and returns NULL if a match isn't found,
 365  * or the struct_opt_value that matched. It also strips the new line from
 366  * @val->string if it's present.
 367  */
 368 struct bond_opt_value *bond_opt_parse(const struct bond_option *opt,
 369                                       struct bond_opt_value *val)
 370 {
 371         char *p, valstr[BOND_OPT_MAX_NAMELEN + 1] = { 0, };
 372         struct bond_opt_value *tbl, *ret = NULL;
 373         bool checkval;
 374         int i, rv;
 375
 376         /* No parsing if the option wants a raw val */
 377         if (opt->flags & BOND_OPTFLAG_RAWVAL)
 378                 return val;
 379
 380         tbl = opt->values;
 381         if (!tbl)
 382                 goto out;
 383
 384         /* ULLONG_MAX is used to bypass string processing */
 385         checkval = val->value != ULLONG_MAX;
 386         if (!checkval) {
 387                 if (!val->string)
 388                         goto out;
 389                 p = strchr(val->string, '\n');
 390                 if (p)
 391                         *p = '\0';
 392                 for (p = val->string; *p; p++)
 393                         if (!(isdigit(*p) || isspace(*p)))
 394                                 break;
 395                 /* The following code extracts the string to match or the value
 396                  * and sets checkval appropriately
 397                  */
 398                 if (*p) {
 399                         rv = sscanf(val->string, "%32s", valstr);
 400                 } else {
 401                         rv = sscanf(val->string, "%llu", &val->value);
 402                         checkval = true;
 403                 }
 404                 if (!rv)
 405                         goto out;
 406         }
 407
 408         for (i = 0; tbl[i].string; i++) {
 409                 /* Check for exact match */
 410                 if (checkval) {
 411                         if (val->value == tbl[i].value)
 412                                 ret = &tbl[i];
 413                 } else {
 414                         if (!strcmp(valstr, "default") &&
 415                             (tbl[i].flags & BOND_VALFLAG_DEFAULT))
 416                                 ret = &tbl[i];
 417
 418                         if (!strcmp(valstr, tbl[i].string))
 419                                 ret = &tbl[i];
 420                 }
 421                 /* Found an exact match */
 422                 if (ret)
 423                         goto out;
 424         }
 425         /* Possible range match */
 426         if (checkval && bond_opt_check_range(opt, val->value))
 427                 ret = val;
 428 out:
 429         return ret;
 430 }
 431
 432 /* Check opt's dependencies against bond mode and currently set options */
 433 static int bond_opt_check_deps(struct bonding *bond,
 434                                const struct bond_option *opt)
 435 {
 436         struct bond_params *params = &bond->params;
 437
 438         if (test_bit(params->mode, &opt->unsuppmodes))
 439                 return -EACCES;
 440         if ((opt->flags & BOND_OPTFLAG_NOSLAVES) && bond_has_slaves(bond))
 441                 return -ENOTEMPTY;
 442         if ((opt->flags & BOND_OPTFLAG_IFDOWN) && (bond->dev->flags & IFF_UP))
 443                 return -EBUSY;
 444
 445         return 0;
 446 }
 447
 448 static void bond_opt_dep_print(struct bonding *bond,
 449                                const struct bond_option *opt)
 450 {
 451         struct bond_opt_value *modeval;
 452         struct bond_params *params;
 453
 454         params = &bond->params;
 455         modeval = bond_opt_get_val(BOND_OPT_MODE, params->mode);
 456         if (test_bit(params->mode, &opt->unsuppmodes))
 457                 pr_err("%s: option %s: mode dependency failed, not supported in mode %s(%llu)\n",
 458                        bond->dev->name, opt->name,
 459                        modeval->string, modeval->value);
 460 }
 461
 462 static void bond_opt_error_interpret(struct bonding *bond,
 463                                      const struct bond_option *opt,
 464                                      int error, struct bond_opt_value *val)
 465 {
 466         struct bond_opt_value *minval, *maxval;
 467         char *p;
 468
 469         switch (error) {
 470         case -EINVAL:
 471                 if (val) {
 472                         if (val->string) {
 473                                 /* sometimes RAWVAL opts may have new lines */
 474                                 p = strchr(val->string, '\n');
 475                                 if (p)
 476                                         *p = '\0';
 477                                 pr_err("%s: option %s: invalid value (%s)\n",
 478                                        bond->dev->name, opt->name, val->string);
 479                         } else {
 480                                 pr_err("%s: option %s: invalid value (%llu)\n",
 481                                        bond->dev->name, opt->name, val->value);
 482                         }
 483                 }
 484                 minval = bond_opt_get_flags(opt, BOND_VALFLAG_MIN);
 485                 maxval = bond_opt_get_flags(opt, BOND_VALFLAG_MAX);
 486                 if (!maxval)
 487                         break;
 488                 pr_err("%s: option %s: allowed values %llu - %llu\n",
 489                        bond->dev->name, opt->name, minval ? minval->value : 0,
 490                        maxval->value);
 491                 break;
 492         case -EACCES:
 493                 bond_opt_dep_print(bond, opt);
 494                 break;
 495         case -ENOTEMPTY:
 496                 pr_err("%s: option %s: unable to set because the bond device has slaves\n",
 497                        bond->dev->name, opt->name);
 498                 break;
 499         case -EBUSY:
 500                 pr_err("%s: option %s: unable to set because the bond device is up\n",
 501                        bond->dev->name, opt->name);
 502                 break;
 503         default:
 504                 break;
 505         }
 506 }
 507
 508 /**
 509  * __bond_opt_set - set a bonding option
 510  * @bond: target bond device
 511  * @option: option to set
 512  * @val: value to set it to
 513  *
 514  * This function is used to change the bond's option value, it can be
 515  * used for both enabling/changing an option and for disabling it. RTNL lock
 516  * must be obtained before calling this function.
 517  */
 518 int __bond_opt_set(struct bonding *bond,
 519                    unsigned int option, struct bond_opt_value *val)
 520 {
 521         struct bond_opt_value *retval = NULL;
 522         const struct bond_option *opt;
 523         int ret = -ENOENT;
 524
 525         ASSERT_RTNL();
 526
 527         opt = bond_opt_get(option);
 528         if (WARN_ON(!val) || WARN_ON(!opt))
 529                 goto out;
 530         ret = bond_opt_check_deps(bond, opt);
 531         if (ret)
 532                 goto out;
 533         retval = bond_opt_parse(opt, val);
 534         if (!retval) {
 535                 ret = -EINVAL;
 536                 goto out;
 537         }
 538         ret = opt->set(bond, retval);
 539 out:
 540         if (ret)
 541                 bond_opt_error_interpret(bond, opt, ret, val);
 542
 543         return ret;
 544 }
 545
 546 /**
 547  * bond_opt_tryset_rtnl - try to acquire rtnl and call __bond_opt_set
 548  * @bond: target bond device
 549  * @option: option to set
 550  * @buf: value to set it to
 551  *
 552  * This function tries to acquire RTNL without blocking and if successful
 553  * calls __bond_opt_set. It is mainly used for sysfs option manipulation.
 554  */
 555 int bond_opt_tryset_rtnl(struct bonding *bond, unsigned int option, char *buf)
 556 {
 557         struct bond_opt_value optval;
 558         int ret;
 559
 560         if (!rtnl_trylock())
 561                 return restart_syscall();
 562         bond_opt_initstr(&optval, buf);
 563         ret = __bond_opt_set(bond, option, &optval);
 564         rtnl_unlock();
 565
 566         return ret;
 567 }
 568
 569 /**
 570  * bond_opt_get - get a pointer to an option
 571  * @option: option for which to return a pointer
 572  *
 573  * This function checks if option is valid and if so returns a pointer
 574  * to its entry in the bond_opts[] option array.
 575  */
 576 struct bond_option *bond_opt_get(unsigned int option)
 577 {
 578         if (!BOND_OPT_VALID(option))
 579                 return NULL;
 580
 581         return &bond_opts[option];
 582 }
 583
 584 int bond_option_mode_set(struct bonding *bond, struct bond_opt_value *newval)
 585 {
 586         if (BOND_NO_USES_ARP(newval->value) && bond->params.arp_interval) {
 587                 pr_info("%s: %s mode is incompatible with arp monitoring, start mii monitoring\n",
 588                         bond->dev->name, newval->string);
 589                 /* disable arp monitoring */
 590                 bond->params.arp_interval = 0;
 591                 /* set miimon to default value */
 592                 bond->params.miimon = BOND_DEFAULT_MIIMON;
 593                 pr_info("%s: Setting MII monitoring interval to %d\n",
 594                         bond->dev->name, bond->params.miimon);
 595         }
 596
 597         /* don't cache arp_validate between modes */
 598         bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
 599         bond->params.mode = newval->value;
 600
 601         return 0;
 602 }
 603
 604 static struct net_device *__bond_option_active_slave_get(struct bonding *bond,
 605                                                          struct slave *slave)
 606 {
 607         return USES_PRIMARY(bond->params.mode) && slave ? slave->dev : NULL;
 608 }
 609
 610 struct net_device *bond_option_active_slave_get_rcu(struct bonding *bond)
 611 {
 612         struct slave *slave = rcu_dereference(bond->curr_active_slave);
 613
 614         return __bond_option_active_slave_get(bond, slave);
 615 }
 616
 617 struct net_device *bond_option_active_slave_get(struct bonding *bond)
 618 {
 619         return __bond_option_active_slave_get(bond, bond->curr_active_slave);
 620 }
 621
 622 int bond_option_active_slave_set(struct bonding *bond,
 623                                  struct bond_opt_value *newval)
 624 {
 625         char ifname[IFNAMSIZ] = { 0, };
 626         struct net_device *slave_dev;
 627         int ret = 0;
 628
 629         sscanf(newval->string, "%15s", ifname); /* IFNAMSIZ */
 630         if (!strlen(ifname) || newval->string[0] == '\n') {
 631                 slave_dev = NULL;
 632         } else {
 633                 slave_dev = __dev_get_by_name(dev_net(bond->dev), ifname);
 634                 if (!slave_dev)
 635                         return -ENODEV;
 636         }
 637
 638         if (slave_dev) {
 639                 if (!netif_is_bond_slave(slave_dev)) {
 640                         pr_err("Device %s is not bonding slave\n",
 641                                slave_dev->name);
 642                         return -EINVAL;
 643                 }
 644
 645                 if (bond->dev != netdev_master_upper_dev_get(slave_dev)) {
 646                         pr_err("%s: Device %s is not our slave\n",
 647                                bond->dev->name, slave_dev->name);
 648                         return -EINVAL;
 649                 }
 650         }
 651
 652         block_netpoll_tx();
 653         write_lock_bh(&bond->curr_slave_lock);
 654
 655         /* check to see if we are clearing active */
 656         if (!slave_dev) {
 657                 pr_info("%s: Clearing current active slave\n", bond->dev->name);
 658                 rcu_assign_pointer(bond->curr_active_slave, NULL);
 659                 bond_select_active_slave(bond);
 660         } else {
 661                 struct slave *old_active = bond->curr_active_slave;
 662                 struct slave *new_active = bond_slave_get_rtnl(slave_dev);
 663
 664                 BUG_ON(!new_active);
 665
 666                 if (new_active == old_active) {
 667                         /* do nothing */
 668                         pr_info("%s: %s is already the current active slave\n",
 669                                 bond->dev->name, new_active->dev->name);
 670                 } else {
 671                         if (old_active && (new_active->link == BOND_LINK_UP) &&
 672                             IS_UP(new_active->dev)) {
 673                                 pr_info("%s: Setting %s as active slave\n",
 674                                         bond->dev->name, new_active->dev->name);
 675                                 bond_change_active_slave(bond, new_active);
 676                         } else {
 677                                 pr_err("%s: Could not set %s as active slave; either %s is down or the link is down\n",
 678                                        bond->dev->name, new_active->dev->name,
 679                                        new_active->dev->name);
 680                                 ret = -EINVAL;
 681                         }
 682                 }
 683         }
 684
 685         write_unlock_bh(&bond->curr_slave_lock);
 686         unblock_netpoll_tx();
 687
 688         return ret;
 689 }
 690
 691 int bond_option_miimon_set(struct bonding *bond, struct bond_opt_value *newval)
 692 {
 693         pr_info("%s: Setting MII monitoring interval to %llu\n",
 694                 bond->dev->name, newval->value);
 695         bond->params.miimon = newval->value;
 696         if (bond->params.updelay)
 697                 pr_info("%s: Note: Updating updelay (to %d) since it is a multiple of the miimon value\n",
 698                         bond->dev->name,
 699                         bond->params.updelay * bond->params.miimon);
 700         if (bond->params.downdelay)
 701                 pr_info("%s: Note: Updating downdelay (to %d) since it is a multiple of the miimon value\n",
 702                         bond->dev->name,
 703                         bond->params.downdelay * bond->params.miimon);
 704         if (newval->value && bond->params.arp_interval) {
 705                 pr_info("%s: MII monitoring cannot be used with ARP monitoring - disabling ARP monitoring...\n",
 706                         bond->dev->name);
 707                 bond->params.arp_interval = 0;
 708                 if (bond->params.arp_validate)
 709                         bond->params.arp_validate = BOND_ARP_VALIDATE_NONE;
 710         }
 711         if (bond->dev->flags & IFF_UP) {
 712                 /* If the interface is up, we may need to fire off
 713                  * the MII timer. If the interface is down, the
 714                  * timer will get fired off when the open function
 715                  * is called.
 716                  */
 717                 if (!newval->value) {
 718                         cancel_delayed_work_sync(&bond->mii_work);
 719                 } else {
 720                         cancel_delayed_work_sync(&bond->arp_work);
 721                         queue_delayed_work(bond->wq, &bond->mii_work, 0);
 722                 }
 723         }
 724
 725         return 0;
 726 }
 727
 728 int bond_option_updelay_set(struct bonding *bond, struct bond_opt_value *newval)
 729 {
 730         int value = newval->value;
 731
 732         if (!bond->params.miimon) {
 733                 pr_err("%s: Unable to set up delay as MII monitoring is disabled\n",
 734                        bond->dev->name);
 735                 return -EPERM;
 736         }
 737         if ((value % bond->params.miimon) != 0) {
 738                 pr_warn("%s: Warning: up delay (%d) is not a multiple of miimon (%d), updelay rounded to %d ms\n",
 739                         bond->dev->name, value,
 740                         bond->params.miimon,
 741                         (value / bond->params.miimon) *
 742                         bond->params.miimon);
 743         }
 744         bond->params.updelay = value / bond->params.miimon;
 745         pr_info("%s: Setting up delay to %d\n",
 746                 bond->dev->name, bond->params.updelay * bond->params.miimon);
 747
 748         return 0;
 749 }
 750
 751 int bond_option_downdelay_set(struct bonding *bond,
 752                               struct bond_opt_value *newval)
 753 {
 754         int value = newval->value;
 755
 756         if (!bond->params.miimon) {
 757                 pr_err("%s: Unable to set down delay as MII monitoring is disabled\n",
 758                        bond->dev->name);
 759                 return -EPERM;
 760         }
 761         if ((value % bond->params.miimon) != 0) {
 762                 pr_warn("%s: Warning: down delay (%d) is not a multiple of miimon (%d), delay rounded to %d ms\n",
 763                         bond->dev->name, value,
 764                         bond->params.miimon,
 765                         (value / bond->params.miimon) *
 766                         bond->params.miimon);
 767         }
 768         bond->params.downdelay = value / bond->params.miimon;
 769         pr_info("%s: Setting down delay to %d\n",
 770                 bond->dev->name, bond->params.downdelay * bond->params.miimon);
 771
 772         return 0;
 773 }
 774
 775 int bond_option_use_carrier_set(struct bonding *bond,
 776                                 struct bond_opt_value *newval)
 777 {
 778         pr_info("%s: Setting use_carrier to %llu\n",
 779                 bond->dev->name, newval->value);
 780         bond->params.use_carrier = newval->value;
 781
 782         return 0;
 783 }
 784
 785 int bond_option_arp_interval_set(struct bonding *bond,
 786                                  struct bond_opt_value *newval)
 787 {
 788         pr_info("%s: Setting ARP monitoring interval to %llu\n",
 789                 bond->dev->name, newval->value);
 790         bond->params.arp_interval = newval->value;
 791         if (newval->value) {
 792                 if (bond->params.miimon) {
 793                         pr_info("%s: ARP monitoring cannot be used with MII monitoring. %s Disabling MII monitoring\n",
 794                                 bond->dev->name, bond->dev->name);
 795                         bond->params.miimon = 0;
 796                 }
 797                 if (!bond->params.arp_targets[0])
 798                         pr_info("%s: ARP monitoring has been set up, but no ARP targets have been specified\n",
 799                                 bond->dev->name);
 800         }
 801         if (bond->dev->flags & IFF_UP) {
 802                 /* If the interface is up, we may need to fire off
 803                  * the ARP timer.  If the interface is down, the
 804                  * timer will get fired off when the open function
 805                  * is called.
 806                  */
 807                 if (!newval->value) {
 808                         if (bond->params.arp_validate)
 809                                 bond->recv_probe = NULL;
 810                         cancel_delayed_work_sync(&bond->arp_work);
 811                 } else {
 812                         /* arp_validate can be set only in active-backup mode */
 813                         bond->recv_probe = bond_arp_rcv;
 814                         cancel_delayed_work_sync(&bond->mii_work);
 815                         queue_delayed_work(bond->wq, &bond->arp_work, 0);
 816                 }
 817         }
 818
 819         return 0;
 820 }
 821
 822 static void _bond_options_arp_ip_target_set(struct bonding *bond, int slot,
 823                                             __be32 target,
 824                                             unsigned long last_rx)
 825 {
 826         __be32 *targets = bond->params.arp_targets;
 827         struct list_head *iter;
 828         struct slave *slave;
 829
 830         if (slot >= 0 && slot < BOND_MAX_ARP_TARGETS) {
 831                 bond_for_each_slave(bond, slave, iter)
 832                         slave->target_last_arp_rx[slot] = last_rx;
 833                 targets[slot] = target;
 834         }
 835 }
 836
 837 static int _bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
 838 {
 839         __be32 *targets = bond->params.arp_targets;
 840         int ind;
 841
 842         if (IS_IP_TARGET_UNUSABLE_ADDRESS(target)) {
 843                 pr_err("%s: invalid ARP target %pI4 specified for addition\n",
 844                        bond->dev->name, &target);
 845                 return -EINVAL;
 846         }
 847
 848         if (bond_get_targets_ip(targets, target) != -1) { /* dup */
 849                 pr_err("%s: ARP target %pI4 is already present\n",
 850                        bond->dev->name, &target);
 851                 return -EINVAL;
 852         }
 853
 854         ind = bond_get_targets_ip(targets, 0); /* first free slot */
 855         if (ind == -1) {
 856                 pr_err("%s: ARP target table is full!\n", bond->dev->name);
 857                 return -EINVAL;
 858         }
 859
 860         pr_info("%s: Adding ARP target %pI4\n", bond->dev->name, &target);
 861
 862         _bond_options_arp_ip_target_set(bond, ind, target, jiffies);
 863
 864         return 0;
 865 }
 866
 867 int bond_option_arp_ip_target_add(struct bonding *bond, __be32 target)
 868 {
 869         int ret;
 870
 871         /* not to race with bond_arp_rcv */
 872         write_lock_bh(&bond->lock);
 873         ret = _bond_option_arp_ip_target_add(bond, target);
 874         write_unlock_bh(&bond->lock);
 875
 876         return ret;
 877 }
 878
 879 int bond_option_arp_ip_target_rem(struct bonding *bond, __be32 target)
 880 {
 881         __be32 *targets = bond->params.arp_targets;
 882         struct list_head *iter;
 883         struct slave *slave;
 884         unsigned long *targets_rx;
 885         int ind, i;
 886
 887         if (IS_IP_TARGET_UNUSABLE_ADDRESS(target)) {
 888                 pr_err("%s: invalid ARP target %pI4 specified for removal\n",
 889                        bond->dev->name, &target);
 890                 return -EINVAL;
 891         }
 892
 893         ind = bond_get_targets_ip(targets, target);
 894         if (ind == -1) {
 895                 pr_err("%s: unable to remove nonexistent ARP target %pI4\n",
 896                        bond->dev->name, &target);
 897                 return -EINVAL;
 898         }
 899
 900         if (ind == 0 && !targets[1] && bond->params.arp_interval)
 901                 pr_warn("%s: Removing last arp target with arp_interval on\n",
 902                         bond->dev->name);
 903
 904         pr_info("%s: Removing ARP target %pI4\n", bond->dev->name, &target);
 905
 906         /* not to race with bond_arp_rcv */
 907         write_lock_bh(&bond->lock);
 908
 909         bond_for_each_slave(bond, slave, iter) {
 910                 targets_rx = slave->target_last_arp_rx;
 911                 for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
 912                         targets_rx[i] = targets_rx[i+1];
 913                 targets_rx[i] = 0;
 914         }
 915         for (i = ind; (i < BOND_MAX_ARP_TARGETS-1) && targets[i+1]; i++)
 916                 targets[i] = targets[i+1];
 917         targets[i] = 0;
 918
 919         write_unlock_bh(&bond->lock);
 920
 921         return 0;
 922 }
 923
 924 void bond_option_arp_ip_targets_clear(struct bonding *bond)
 925 {
 926         int i;
 927
 928         /* not to race with bond_arp_rcv */
 929         write_lock_bh(&bond->lock);
 930         for (i = 0; i < BOND_MAX_ARP_TARGETS; i++)
 931                 _bond_options_arp_ip_target_set(bond, i, 0, 0);
 932         write_unlock_bh(&bond->lock);
 933 }
 934
 935 int bond_option_arp_ip_targets_set(struct bonding *bond,
 936                                    struct bond_opt_value *newval)
 937 {
 938         int ret = -EPERM;
 939         __be32 target;
 940
 941         if (newval->string) {
 942                 if (!in4_pton(newval->string+1, -1, (u8 *)&target, -1, NULL)) {
 943                         pr_err("%s: invalid ARP target %pI4 specified\n",
 944                                bond->dev->name, &target);
 945                         return ret;
 946                 }
 947                 if (newval->string[0] == '+')
 948                         ret = bond_option_arp_ip_target_add(bond, target);
 949                 else if (newval->string[0] == '-')
 950                         ret = bond_option_arp_ip_target_rem(bond, target);
 951                 else
 952                         pr_err("no command found in arp_ip_targets file for bond %s - use +<addr> or -<addr>\n",
 953                                bond->dev->name);
 954         } else {
 955                 target = newval->value;
 956                 ret = bond_option_arp_ip_target_add(bond, target);
 957         }
 958
 959         return ret;
 960 }
 961
 962 int bond_option_arp_validate_set(struct bonding *bond,
 963                                  struct bond_opt_value *newval)
 964 {
 965         pr_info("%s: Setting arp_validate to %s (%llu)\n",
 966                 bond->dev->name, newval->string, newval->value);
 967
 968         if (bond->dev->flags & IFF_UP) {
 969                 if (!newval->value)
 970                         bond->recv_probe = NULL;
 971                 else if (bond->params.arp_interval)
 972                         bond->recv_probe = bond_arp_rcv;
 973         }
 974         bond->params.arp_validate = newval->value;
 975
 976         return 0;
 977 }
 978
 979 int bond_option_arp_all_targets_set(struct bonding *bond,
 980                                     struct bond_opt_value *newval)
 981 {
 982         pr_info("%s: Setting arp_all_targets to %s (%llu)\n",
 983                 bond->dev->name, newval->string, newval->value);
 984         bond->params.arp_all_targets = newval->value;
 985
 986         return 0;
 987 }
 988
 989 int bond_option_primary_set(struct bonding *bond, struct bond_opt_value *newval)
 990 {
 991         char *p, *primary = newval->string;
 992         struct list_head *iter;
 993         struct slave *slave;
 994
 995         block_netpoll_tx();
 996         read_lock(&bond->lock);
 997         write_lock_bh(&bond->curr_slave_lock);
 998
 999         p = strchr(primary, '\n');
1000         if (p)
1001                 *p = '\0';
1002         /* check to see if we are clearing primary */
1003         if (!strlen(primary)) {
1004                 pr_info("%s: Setting primary slave to None\n", bond->dev->name);
1005                 bond->primary_slave = NULL;
1006                 memset(bond->params.primary, 0, sizeof(bond->params.primary));
1007                 bond_select_active_slave(bond);
1008                 goto out;
1009         }
1010
1011         bond_for_each_slave(bond, slave, iter) {
1012                 if (strncmp(slave->dev->name, primary, IFNAMSIZ) == 0) {
1013                         pr_info("%s: Setting %s as primary slave\n",
1014                                 bond->dev->name, slave->dev->name);
1015                         bond->primary_slave = slave;
1016                         strcpy(bond->params.primary, slave->dev->name);
1017                         bond_select_active_slave(bond);
1018                         goto out;
1019                 }
1020         }
1021
1022         if (bond->primary_slave) {
1023                 pr_info("%s: Setting primary slave to None\n", bond->dev->name);
1024                 bond->primary_slave = NULL;
1025                 bond_select_active_slave(bond);
1026         }
1027         strncpy(bond->params.primary, primary, IFNAMSIZ);
1028         bond->params.primary[IFNAMSIZ - 1] = 0;
1029
1030         pr_info("%s: Recording %s as primary, but it has not been enslaved to %s yet\n",
1031                 bond->dev->name, primary, bond->dev->name);
1032
1033 out:
1034         write_unlock_bh(&bond->curr_slave_lock);
1035         read_unlock(&bond->lock);
1036         unblock_netpoll_tx();
1037
1038         return 0;
1039 }
1040
1041 int bond_option_primary_reselect_set(struct bonding *bond,
1042                                      struct bond_opt_value *newval)
1043 {
1044         pr_info("%s: Setting primary_reselect to %s (%llu)\n",
1045                 bond->dev->name, newval->string, newval->value);
1046         bond->params.primary_reselect = newval->value;
1047
1048         block_netpoll_tx();
1049         write_lock_bh(&bond->curr_slave_lock);
1050         bond_select_active_slave(bond);
1051         write_unlock_bh(&bond->curr_slave_lock);
1052         unblock_netpoll_tx();
1053
1054         return 0;
1055 }
1056
1057 int bond_option_fail_over_mac_set(struct bonding *bond,
1058                                   struct bond_opt_value *newval)
1059 {
1060         pr_info("%s: Setting fail_over_mac to %s (%llu)\n",
1061                 bond->dev->name, newval->string, newval->value);
1062         bond->params.fail_over_mac = newval->value;
1063
1064         return 0;
1065 }
1066
1067 int bond_option_xmit_hash_policy_set(struct bonding *bond,
1068                                      struct bond_opt_value *newval)
1069 {
1070         pr_info("%s: Setting xmit hash policy to %s (%llu)\n",
1071                 bond->dev->name, newval->string, newval->value);
1072         bond->params.xmit_policy = newval->value;
1073
1074         return 0;
1075 }
1076
1077 int bond_option_resend_igmp_set(struct bonding *bond,
1078                                 struct bond_opt_value *newval)
1079 {
1080         pr_info("%s: Setting resend_igmp to %llu\n",
1081                 bond->dev->name, newval->value);
1082         bond->params.resend_igmp = newval->value;
1083
1084         return 0;
1085 }
1086
1087 int bond_option_num_peer_notif_set(struct bonding *bond,
1088                                    struct bond_opt_value *newval)
1089 {
1090         bond->params.num_peer_notif = newval->value;
1091
1092         return 0;
1093 }
1094
1095 int bond_option_all_slaves_active_set(struct bonding *bond,
1096                                       struct bond_opt_value *newval)
1097 {
1098         struct list_head *iter;
1099         struct slave *slave;
1100
1101         if (newval->value == bond->params.all_slaves_active)
1102                 return 0;
1103         bond->params.all_slaves_active = newval->value;
1104         bond_for_each_slave(bond, slave, iter) {
1105                 if (!bond_is_active_slave(slave)) {
1106                         if (newval->value)
1107                                 slave->inactive = 0;
1108                         else
1109                                 slave->inactive = 1;
1110                 }
1111         }
1112
1113         return 0;
1114 }
1115
1116 int bond_option_min_links_set(struct bonding *bond,
1117                               struct bond_opt_value *newval)
1118 {
1119         pr_info("%s: Setting min links value to %llu\n",
1120                 bond->dev->name, newval->value);
1121         bond->params.min_links = newval->value;
1122
1123         return 0;
1124 }
1125
1126 int bond_option_lp_interval_set(struct bonding *bond,
1127                                 struct bond_opt_value *newval)
1128 {
1129         bond->params.lp_interval = newval->value;
1130
1131         return 0;
1132 }
1133
1134 int bond_option_pps_set(struct bonding *bond, struct bond_opt_value *newval)
1135 {
1136         bond->params.packets_per_slave = newval->value;
1137         if (newval->value > 0) {
1138                 bond->params.reciprocal_packets_per_slave =
1139                         reciprocal_value(newval->value);
1140         } else {
1141                 /* reciprocal_packets_per_slave is unused if
1142                  * packets_per_slave is 0 or 1, just initialize it
1143                  */
1144                 bond->params.reciprocal_packets_per_slave =
1145                         (struct reciprocal_value) { 0 };
1146         }
1147
1148         return 0;
1149 }
1150
1151 int bond_option_lacp_rate_set(struct bonding *bond,
1152                               struct bond_opt_value *newval)
1153 {
1154         pr_info("%s: Setting LACP rate to %s (%llu)\n",
1155                 bond->dev->name, newval->string, newval->value);
1156         bond->params.lacp_fast = newval->value;
1157         bond_3ad_update_lacp_rate(bond);
1158
1159         return 0;
1160 }
1161
1162 int bond_option_ad_select_set(struct bonding *bond,
1163                               struct bond_opt_value *newval)
1164 {
1165         pr_info("%s: Setting ad_select to %s (%llu)\n",
1166                 bond->dev->name, newval->string, newval->value);
1167         bond->params.ad_select = newval->value;
1168
1169         return 0;
1170 }
1171
1172 int bond_option_queue_id_set(struct bonding *bond,
1173                              struct bond_opt_value *newval)
1174 {
1175         struct slave *slave, *update_slave;
1176         struct net_device *sdev;
1177         struct list_head *iter;
1178         char *delim;
1179         int ret = 0;
1180         u16 qid;
1181
1182         /* delim will point to queue id if successful */
1183         delim = strchr(newval->string, ':');
1184         if (!delim)
1185                 goto err_no_cmd;
1186
1187         /* Terminate string that points to device name and bump it
1188          * up one, so we can read the queue id there.
1189          */
1190         *delim = '\0';
1191         if (sscanf(++delim, "%hd\n", &qid) != 1)
1192                 goto err_no_cmd;
1193
1194         /* Check buffer length, valid ifname and queue id */
1195         if (!dev_valid_name(newval->string) ||
1196             qid > bond->dev->real_num_tx_queues)
1197                 goto err_no_cmd;
1198
1199         /* Get the pointer to that interface if it exists */
1200         sdev = __dev_get_by_name(dev_net(bond->dev), newval->string);
1201         if (!sdev)
1202                 goto err_no_cmd;
1203
1204         /* Search for thes slave and check for duplicate qids */
1205         update_slave = NULL;
1206         bond_for_each_slave(bond, slave, iter) {
1207                 if (sdev == slave->dev)
1208                         /* We don't need to check the matching
1209                          * slave for dups, since we're overwriting it
1210                          */
1211                         update_slave = slave;
1212                 else if (qid && qid == slave->queue_id) {
1213                         goto err_no_cmd;
1214                 }
1215         }
1216
1217         if (!update_slave)
1218                 goto err_no_cmd;
1219
1220         /* Actually set the qids for the slave */
1221         update_slave->queue_id = qid;
1222
1223 out:
1224         return ret;
1225
1226 err_no_cmd:
1227         pr_info("invalid input for queue_id set for %s\n", bond->dev->name);
1228         ret = -EPERM;
1229         goto out;
1230
1231 }
1232
1233 int bond_option_slaves_set(struct bonding *bond, struct bond_opt_value *newval)
1234 {
1235         char command[IFNAMSIZ + 1] = { 0, };
1236         struct net_device *dev;
1237         char *ifname;
1238         int ret;
1239
1240         sscanf(newval->string, "%16s", command); /* IFNAMSIZ*/
1241         ifname = command + 1;
1242         if ((strlen(command) <= 1) ||
1243             !dev_valid_name(ifname))
1244                 goto err_no_cmd;
1245
1246         dev = __dev_get_by_name(dev_net(bond->dev), ifname);
1247         if (!dev) {
1248                 pr_info("%s: interface %s does not exist!\n",
1249                         bond->dev->name, ifname);
1250                 ret = -ENODEV;
1251                 goto out;
1252         }
1253
1254         switch (command[0]) {
1255         case '+':
1256                 pr_info("%s: Adding slave %s\n", bond->dev->name, dev->name);
1257                 ret = bond_enslave(bond->dev, dev);
1258                 break;
1259
1260         case '-':
1261                 pr_info("%s: Removing slave %s\n", bond->dev->name, dev->name);
1262                 ret = bond_release(bond->dev, dev);
1263                 break;
1264
1265         default:
1266                 goto err_no_cmd;
1267         }
1268
1269 out:
1270         return ret;
1271
1272 err_no_cmd:
1273         pr_err("no command found in slaves file for bond %s - use +ifname or -ifname\n",
1274                bond->dev->name);
1275         ret = -EPERM;
1276         goto out;
1277 }