3 * Copyright (C) 2011 Novell Inc.
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License version 2 as published by
7 * the Free Software Foundation.
11 #include <linux/namei.h>
12 #include <linux/xattr.h>
13 #include <linux/security.h>
14 #include <linux/cred.h>
15 #include <linux/module.h>
16 #include <linux/posix_acl.h>
17 #include <linux/posix_acl_xattr.h>
18 #include <linux/atomic.h>
19 #include <linux/ratelimit.h>
20 #include "overlayfs.h"
22 static unsigned short ovl_redirect_max = 256;
23 module_param_named(redirect_max, ovl_redirect_max, ushort, 0644);
24 MODULE_PARM_DESC(ovl_redirect_max,
25 "Maximum length of absolute redirect xattr value");
27 void ovl_cleanup(struct inode *wdir, struct dentry *wdentry)
32 if (d_is_dir(wdentry))
33 err = ovl_do_rmdir(wdir, wdentry);
35 err = ovl_do_unlink(wdir, wdentry);
39 pr_err("overlayfs: cleanup of '%pd2' failed (%i)\n",
44 struct dentry *ovl_lookup_temp(struct dentry *workdir)
48 static atomic_t temp_id = ATOMIC_INIT(0);
50 /* counter is allowed to wrap, since temp dentries are ephemeral */
51 snprintf(name, sizeof(name), "#%x", atomic_inc_return(&temp_id));
53 temp = lookup_one_len(name, workdir, strlen(name));
54 if (!IS_ERR(temp) && temp->d_inode) {
55 pr_err("overlayfs: workdir/%s already exists\n", name);
63 /* caller holds i_mutex on workdir */
64 static struct dentry *ovl_whiteout(struct dentry *workdir,
65 struct dentry *dentry)
68 struct dentry *whiteout;
69 struct inode *wdir = workdir->d_inode;
71 whiteout = ovl_lookup_temp(workdir);
75 err = ovl_do_whiteout(wdir, whiteout);
78 whiteout = ERR_PTR(err);
84 int ovl_create_real(struct inode *dir, struct dentry *newdentry,
85 struct cattr *attr, struct dentry *hardlink, bool debug)
89 if (newdentry->d_inode)
93 err = ovl_do_link(hardlink, dir, newdentry, debug);
95 switch (attr->mode & S_IFMT) {
97 err = ovl_do_create(dir, newdentry, attr->mode, debug);
101 err = ovl_do_mkdir(dir, newdentry, attr->mode, debug);
108 err = ovl_do_mknod(dir, newdentry,
109 attr->mode, attr->rdev, debug);
113 err = ovl_do_symlink(dir, newdentry, attr->link, debug);
120 if (!err && WARN_ON(!newdentry->d_inode)) {
122 * Not quite sure if non-instantiated dentry is legal or not.
123 * VFS doesn't seem to care so check and warn here.
130 static int ovl_set_opaque_xerr(struct dentry *dentry, struct dentry *upper,
135 err = ovl_check_setxattr(dentry, upper, OVL_XATTR_OPAQUE, "y", 1, xerr);
137 ovl_dentry_set_opaque(dentry);
142 static int ovl_set_opaque(struct dentry *dentry, struct dentry *upperdentry)
145 * Fail with -EIO when trying to create opaque dir and upper doesn't
146 * support xattrs. ovl_rename() calls ovl_set_opaque_xerr(-EXDEV) to
147 * return a specific error for noxattr case.
149 return ovl_set_opaque_xerr(dentry, upperdentry, -EIO);
152 static int ovl_set_impure(struct dentry *dentry, struct dentry *upperdentry)
157 * Do not fail when upper doesn't support xattrs.
158 * Upper inodes won't have origin nor redirect xattr anyway.
160 err = ovl_check_setxattr(dentry, upperdentry, OVL_XATTR_IMPURE,
163 ovl_dentry_set_impure(dentry);
168 /* Common operations required to be done after creation of file on upper */
169 static void ovl_instantiate(struct dentry *dentry, struct inode *inode,
170 struct dentry *newdentry, bool hardlink)
172 ovl_dentry_version_inc(dentry->d_parent);
173 ovl_dentry_update(dentry, newdentry);
175 ovl_inode_update(inode, d_inode(newdentry));
176 ovl_copyattr(newdentry->d_inode, inode);
178 WARN_ON(ovl_inode_real(inode, NULL) != d_inode(newdentry));
181 d_instantiate(dentry, inode);
182 /* Force lookup of new upper hardlink to find its lower */
187 static bool ovl_type_merge(struct dentry *dentry)
189 return OVL_TYPE_MERGE(ovl_path_type(dentry));
192 static bool ovl_type_origin(struct dentry *dentry)
194 return OVL_TYPE_ORIGIN(ovl_path_type(dentry));
197 static int ovl_create_upper(struct dentry *dentry, struct inode *inode,
198 struct cattr *attr, struct dentry *hardlink)
200 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
201 struct inode *udir = upperdir->d_inode;
202 struct dentry *newdentry;
205 if (!hardlink && !IS_POSIXACL(udir))
206 attr->mode &= ~current_umask();
208 inode_lock_nested(udir, I_MUTEX_PARENT);
209 newdentry = lookup_one_len(dentry->d_name.name, upperdir,
211 err = PTR_ERR(newdentry);
212 if (IS_ERR(newdentry))
214 err = ovl_create_real(udir, newdentry, attr, hardlink, false);
218 if (ovl_type_merge(dentry->d_parent) && d_is_dir(newdentry)) {
219 /* Setting opaque here is just an optimization, allow to fail */
220 ovl_set_opaque(dentry, newdentry);
223 ovl_instantiate(dentry, inode, newdentry, !!hardlink);
232 static int ovl_lock_rename_workdir(struct dentry *workdir,
233 struct dentry *upperdir)
235 /* Workdir should not be the same as upperdir */
236 if (workdir == upperdir)
239 /* Workdir should not be subdir of upperdir and vice versa */
240 if (lock_rename(workdir, upperdir) != NULL)
246 unlock_rename(workdir, upperdir);
248 pr_err("overlayfs: failed to lock workdir+upperdir\n");
252 static struct dentry *ovl_clear_empty(struct dentry *dentry,
253 struct list_head *list)
255 struct dentry *workdir = ovl_workdir(dentry);
256 struct inode *wdir = workdir->d_inode;
257 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
258 struct inode *udir = upperdir->d_inode;
259 struct path upperpath;
260 struct dentry *upper;
261 struct dentry *opaquedir;
265 if (WARN_ON(!workdir))
266 return ERR_PTR(-EROFS);
268 err = ovl_lock_rename_workdir(workdir, upperdir);
272 ovl_path_upper(dentry, &upperpath);
273 err = vfs_getattr(&upperpath, &stat,
274 STATX_BASIC_STATS, AT_STATX_SYNC_AS_STAT);
279 if (!S_ISDIR(stat.mode))
281 upper = upperpath.dentry;
282 if (upper->d_parent->d_inode != udir)
285 opaquedir = ovl_lookup_temp(workdir);
286 err = PTR_ERR(opaquedir);
287 if (IS_ERR(opaquedir))
290 err = ovl_create_real(wdir, opaquedir,
291 &(struct cattr){.mode = stat.mode}, NULL, true);
295 err = ovl_copy_xattr(upper, opaquedir);
299 err = ovl_set_opaque(dentry, opaquedir);
303 inode_lock(opaquedir->d_inode);
304 err = ovl_set_attr(opaquedir, &stat);
305 inode_unlock(opaquedir->d_inode);
309 err = ovl_do_rename(wdir, opaquedir, udir, upper, RENAME_EXCHANGE);
313 ovl_cleanup_whiteouts(upper, list);
314 ovl_cleanup(wdir, upper);
315 unlock_rename(workdir, upperdir);
317 /* dentry's upper doesn't match now, get rid of it */
323 ovl_cleanup(wdir, opaquedir);
327 unlock_rename(workdir, upperdir);
332 static struct dentry *ovl_check_empty_and_clear(struct dentry *dentry)
335 struct dentry *ret = NULL;
336 enum ovl_path_type type = ovl_path_type(dentry);
339 err = ovl_check_empty_dir(dentry, &list);
346 * When removing an empty opaque directory, then it makes no sense to
347 * replace it with an exact replica of itself.
349 * If no upperdentry then skip clearing whiteouts.
351 * Can race with copy-up, since we don't hold the upperdir mutex.
352 * Doesn't matter, since copy-up can't create a non-empty directory
355 if (OVL_TYPE_UPPER(type) && OVL_TYPE_MERGE(type))
356 ret = ovl_clear_empty(dentry, &list);
359 ovl_cache_free(&list);
364 static int ovl_set_upper_acl(struct dentry *upperdentry, const char *name,
365 const struct posix_acl *acl)
371 if (!IS_ENABLED(CONFIG_FS_POSIX_ACL) || !acl)
374 size = posix_acl_to_xattr(NULL, acl, NULL, 0);
375 buffer = kmalloc(size, GFP_KERNEL);
379 size = posix_acl_to_xattr(&init_user_ns, acl, buffer, size);
384 err = vfs_setxattr(upperdentry, name, buffer, size, XATTR_CREATE);
390 static int ovl_create_over_whiteout(struct dentry *dentry, struct inode *inode,
392 struct dentry *hardlink)
394 struct dentry *workdir = ovl_workdir(dentry);
395 struct inode *wdir = workdir->d_inode;
396 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
397 struct inode *udir = upperdir->d_inode;
398 struct dentry *upper;
399 struct dentry *newdentry;
401 struct posix_acl *acl, *default_acl;
403 if (WARN_ON(!workdir))
407 err = posix_acl_create(dentry->d_parent->d_inode,
408 &cattr->mode, &default_acl, &acl);
413 err = ovl_lock_rename_workdir(workdir, upperdir);
417 newdentry = ovl_lookup_temp(workdir);
418 err = PTR_ERR(newdentry);
419 if (IS_ERR(newdentry))
422 upper = lookup_one_len(dentry->d_name.name, upperdir,
424 err = PTR_ERR(upper);
428 err = ovl_create_real(wdir, newdentry, cattr, hardlink, true);
433 * mode could have been mutilated due to umask (e.g. sgid directory)
436 !S_ISLNK(cattr->mode) &&
437 newdentry->d_inode->i_mode != cattr->mode) {
438 struct iattr attr = {
439 .ia_valid = ATTR_MODE,
440 .ia_mode = cattr->mode,
442 inode_lock(newdentry->d_inode);
443 err = notify_change(newdentry, &attr, NULL);
444 inode_unlock(newdentry->d_inode);
449 err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_ACCESS,
454 err = ovl_set_upper_acl(newdentry, XATTR_NAME_POSIX_ACL_DEFAULT,
460 if (!hardlink && S_ISDIR(cattr->mode)) {
461 err = ovl_set_opaque(dentry, newdentry);
465 err = ovl_do_rename(wdir, newdentry, udir, upper,
470 ovl_cleanup(wdir, upper);
472 err = ovl_do_rename(wdir, newdentry, udir, upper, 0);
476 ovl_instantiate(dentry, inode, newdentry, !!hardlink);
483 unlock_rename(workdir, upperdir);
486 posix_acl_release(acl);
487 posix_acl_release(default_acl);
492 ovl_cleanup(wdir, newdentry);
496 static int ovl_create_or_link(struct dentry *dentry, struct inode *inode,
497 struct cattr *attr, struct dentry *hardlink)
500 const struct cred *old_cred;
501 struct cred *override_cred;
503 err = ovl_copy_up(dentry->d_parent);
507 old_cred = ovl_override_creds(dentry->d_sb);
509 override_cred = prepare_creds();
511 override_cred->fsuid = inode->i_uid;
512 override_cred->fsgid = inode->i_gid;
514 err = security_dentry_create_files_as(dentry,
515 attr->mode, &dentry->d_name, old_cred,
518 put_cred(override_cred);
519 goto out_revert_creds;
522 put_cred(override_creds(override_cred));
523 put_cred(override_cred);
525 if (!ovl_dentry_is_whiteout(dentry))
526 err = ovl_create_upper(dentry, inode, attr,
529 err = ovl_create_over_whiteout(dentry, inode, attr,
533 revert_creds(old_cred);
535 struct inode *realinode = d_inode(ovl_dentry_upper(dentry));
537 WARN_ON(inode->i_mode != realinode->i_mode);
538 WARN_ON(!uid_eq(inode->i_uid, realinode->i_uid));
539 WARN_ON(!gid_eq(inode->i_gid, realinode->i_gid));
544 static int ovl_create_object(struct dentry *dentry, int mode, dev_t rdev,
549 struct cattr attr = {
554 err = ovl_want_write(dentry);
559 inode = ovl_new_inode(dentry->d_sb, mode, rdev);
563 inode_init_owner(inode, dentry->d_parent->d_inode, mode);
564 attr.mode = inode->i_mode;
566 err = ovl_create_or_link(dentry, inode, &attr, NULL);
571 ovl_drop_write(dentry);
576 static int ovl_create(struct inode *dir, struct dentry *dentry, umode_t mode,
579 return ovl_create_object(dentry, (mode & 07777) | S_IFREG, 0, NULL);
582 static int ovl_mkdir(struct inode *dir, struct dentry *dentry, umode_t mode)
584 return ovl_create_object(dentry, (mode & 07777) | S_IFDIR, 0, NULL);
587 static int ovl_mknod(struct inode *dir, struct dentry *dentry, umode_t mode,
590 /* Don't allow creation of "whiteout" on overlay */
591 if (S_ISCHR(mode) && rdev == WHITEOUT_DEV)
594 return ovl_create_object(dentry, mode, rdev, NULL);
597 static int ovl_symlink(struct inode *dir, struct dentry *dentry,
600 return ovl_create_object(dentry, S_IFLNK, 0, link);
603 static int ovl_link(struct dentry *old, struct inode *newdir,
609 err = ovl_want_write(old);
613 err = ovl_copy_up(old);
617 inode = d_inode(old);
620 err = ovl_create_or_link(new, inode, NULL, ovl_dentry_upper(old));
630 static int ovl_remove_and_whiteout(struct dentry *dentry, bool is_dir)
632 struct dentry *workdir = ovl_workdir(dentry);
633 struct inode *wdir = workdir->d_inode;
634 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
635 struct inode *udir = upperdir->d_inode;
636 struct dentry *whiteout;
637 struct dentry *upper;
638 struct dentry *opaquedir = NULL;
642 if (WARN_ON(!workdir))
646 opaquedir = ovl_check_empty_and_clear(dentry);
647 err = PTR_ERR(opaquedir);
648 if (IS_ERR(opaquedir))
652 err = ovl_lock_rename_workdir(workdir, upperdir);
656 upper = lookup_one_len(dentry->d_name.name, upperdir,
658 err = PTR_ERR(upper);
663 if ((opaquedir && upper != opaquedir) ||
664 (!opaquedir && ovl_dentry_upper(dentry) &&
665 upper != ovl_dentry_upper(dentry))) {
669 whiteout = ovl_whiteout(workdir, dentry);
670 err = PTR_ERR(whiteout);
671 if (IS_ERR(whiteout))
675 flags = RENAME_EXCHANGE;
677 err = ovl_do_rename(wdir, whiteout, udir, upper, flags);
681 ovl_cleanup(wdir, upper);
683 ovl_dentry_version_inc(dentry->d_parent);
690 unlock_rename(workdir, upperdir);
697 ovl_cleanup(wdir, whiteout);
701 static int ovl_remove_upper(struct dentry *dentry, bool is_dir)
703 struct dentry *upperdir = ovl_dentry_upper(dentry->d_parent);
704 struct inode *dir = upperdir->d_inode;
705 struct dentry *upper;
706 struct dentry *opaquedir = NULL;
709 /* Redirect dir can be !ovl_lower_positive && OVL_TYPE_MERGE */
710 if (is_dir && ovl_dentry_get_redirect(dentry)) {
711 opaquedir = ovl_check_empty_and_clear(dentry);
712 err = PTR_ERR(opaquedir);
713 if (IS_ERR(opaquedir))
717 inode_lock_nested(dir, I_MUTEX_PARENT);
718 upper = lookup_one_len(dentry->d_name.name, upperdir,
720 err = PTR_ERR(upper);
725 if ((opaquedir && upper != opaquedir) ||
726 (!opaquedir && upper != ovl_dentry_upper(dentry)))
730 err = vfs_rmdir(dir, upper);
732 err = vfs_unlink(dir, upper, NULL);
733 ovl_dentry_version_inc(dentry->d_parent);
736 * Keeping this dentry hashed would mean having to release
737 * upperpath/lowerpath, which could only be done if we are the
738 * sole user of this dentry. Too tricky... Just unhash for
752 static int ovl_do_remove(struct dentry *dentry, bool is_dir)
754 enum ovl_path_type type;
756 const struct cred *old_cred;
758 err = ovl_want_write(dentry);
762 err = ovl_copy_up(dentry->d_parent);
766 type = ovl_path_type(dentry);
768 old_cred = ovl_override_creds(dentry->d_sb);
769 if (!ovl_lower_positive(dentry))
770 err = ovl_remove_upper(dentry, is_dir);
772 err = ovl_remove_and_whiteout(dentry, is_dir);
773 revert_creds(old_cred);
776 clear_nlink(dentry->d_inode);
778 drop_nlink(dentry->d_inode);
781 ovl_drop_write(dentry);
786 static int ovl_unlink(struct inode *dir, struct dentry *dentry)
788 return ovl_do_remove(dentry, false);
791 static int ovl_rmdir(struct inode *dir, struct dentry *dentry)
793 return ovl_do_remove(dentry, true);
796 static bool ovl_type_merge_or_lower(struct dentry *dentry)
798 enum ovl_path_type type = ovl_path_type(dentry);
800 return OVL_TYPE_MERGE(type) || !OVL_TYPE_UPPER(type);
803 static bool ovl_can_move(struct dentry *dentry)
805 return ovl_redirect_dir(dentry->d_sb) ||
806 !d_is_dir(dentry) || !ovl_type_merge_or_lower(dentry);
809 static char *ovl_get_redirect(struct dentry *dentry, bool samedir)
812 struct dentry *d, *tmp;
813 int buflen = ovl_redirect_max + 1;
816 ret = kstrndup(dentry->d_name.name, dentry->d_name.len,
821 buf = ret = kmalloc(buflen, GFP_TEMPORARY);
827 for (d = dget(dentry); !IS_ROOT(d);) {
831 spin_lock(&d->d_lock);
832 name = ovl_dentry_get_redirect(d);
834 thislen = strlen(name);
836 name = d->d_name.name;
837 thislen = d->d_name.len;
840 /* If path is too long, fall back to userspace move */
841 if (thislen + (name[0] != '/') > buflen) {
842 ret = ERR_PTR(-EXDEV);
843 spin_unlock(&d->d_lock);
848 memcpy(&buf[buflen], name, thislen);
849 tmp = dget_dlock(d->d_parent);
850 spin_unlock(&d->d_lock);
855 /* Absolute redirect: finished */
856 if (buf[buflen] == '/')
861 ret = kstrdup(&buf[buflen], GFP_KERNEL);
866 return ret ? ret : ERR_PTR(-ENOMEM);
869 static int ovl_set_redirect(struct dentry *dentry, bool samedir)
872 const char *redirect = ovl_dentry_get_redirect(dentry);
874 if (redirect && (samedir || redirect[0] == '/'))
877 redirect = ovl_get_redirect(dentry, samedir);
878 if (IS_ERR(redirect))
879 return PTR_ERR(redirect);
881 err = ovl_check_setxattr(dentry, ovl_dentry_upper(dentry),
883 redirect, strlen(redirect), -EXDEV);
885 spin_lock(&dentry->d_lock);
886 ovl_dentry_set_redirect(dentry, redirect);
887 spin_unlock(&dentry->d_lock);
890 pr_warn_ratelimited("overlay: failed to set redirect (%i)\n", err);
891 /* Fall back to userspace copy-up */
897 static int ovl_rename(struct inode *olddir, struct dentry *old,
898 struct inode *newdir, struct dentry *new,
902 struct dentry *old_upperdir;
903 struct dentry *new_upperdir;
904 struct dentry *olddentry;
905 struct dentry *newdentry;
909 bool cleanup_whiteout = false;
910 bool overwrite = !(flags & RENAME_EXCHANGE);
911 bool is_dir = d_is_dir(old);
912 bool new_is_dir = d_is_dir(new);
913 bool samedir = olddir == newdir;
914 struct dentry *opaquedir = NULL;
915 const struct cred *old_cred = NULL;
918 if (flags & ~(RENAME_EXCHANGE | RENAME_NOREPLACE))
921 flags &= ~RENAME_NOREPLACE;
923 /* Don't copy up directory trees */
925 if (!ovl_can_move(old))
927 if (!overwrite && !ovl_can_move(new))
930 err = ovl_want_write(old);
934 err = ovl_copy_up(old);
938 err = ovl_copy_up(new->d_parent);
942 err = ovl_copy_up(new);
947 old_cred = ovl_override_creds(old->d_sb);
949 if (overwrite && new_is_dir && ovl_type_merge_or_lower(new)) {
950 opaquedir = ovl_check_empty_and_clear(new);
951 err = PTR_ERR(opaquedir);
952 if (IS_ERR(opaquedir)) {
954 goto out_revert_creds;
959 if (ovl_lower_positive(old)) {
960 if (!ovl_dentry_is_whiteout(new)) {
961 /* Whiteout source */
962 flags |= RENAME_WHITEOUT;
964 /* Switch whiteouts */
965 flags |= RENAME_EXCHANGE;
967 } else if (is_dir && ovl_dentry_is_whiteout(new)) {
968 flags |= RENAME_EXCHANGE;
969 cleanup_whiteout = true;
973 old_upperdir = ovl_dentry_upper(old->d_parent);
974 new_upperdir = ovl_dentry_upper(new->d_parent);
978 * When moving a merge dir or non-dir with copy up origin into
979 * a non-merge upper dir (a.k.a pure upper dir), we are making
980 * the target parent dir "impure". ovl_iterate() iterates pure
981 * upper dirs directly, because there is no need to filter out
982 * whiteouts and merge dir content with lower dir. But for the
983 * case of an "impure" upper dir, ovl_iterate() cannot iterate
984 * the real directory directly, because it looks for the inode
985 * numbers to fill d_ino in the entries origin inode.
987 if (ovl_type_origin(old) && !ovl_type_merge(new->d_parent)) {
988 err = ovl_set_impure(new->d_parent, new_upperdir);
990 goto out_revert_creds;
992 if (!overwrite && ovl_type_origin(new) &&
993 !ovl_type_merge(old->d_parent)) {
994 err = ovl_set_impure(old->d_parent, old_upperdir);
996 goto out_revert_creds;
1000 trap = lock_rename(new_upperdir, old_upperdir);
1002 olddentry = lookup_one_len(old->d_name.name, old_upperdir,
1004 err = PTR_ERR(olddentry);
1005 if (IS_ERR(olddentry))
1009 if (olddentry != ovl_dentry_upper(old))
1012 newdentry = lookup_one_len(new->d_name.name, new_upperdir,
1014 err = PTR_ERR(newdentry);
1015 if (IS_ERR(newdentry))
1018 old_opaque = ovl_dentry_is_opaque(old);
1019 new_opaque = ovl_dentry_is_opaque(new);
1022 if (ovl_dentry_upper(new)) {
1024 if (newdentry != opaquedir)
1027 if (newdentry != ovl_dentry_upper(new))
1031 if (!d_is_negative(newdentry) &&
1032 (!new_opaque || !ovl_is_whiteout(newdentry)))
1036 if (olddentry == trap)
1038 if (newdentry == trap)
1041 if (WARN_ON(olddentry->d_inode == newdentry->d_inode))
1046 if (ovl_type_merge_or_lower(old))
1047 err = ovl_set_redirect(old, samedir);
1048 else if (!old_opaque && ovl_type_merge(new->d_parent))
1049 err = ovl_set_opaque_xerr(old, olddentry, -EXDEV);
1053 if (!overwrite && new_is_dir) {
1054 if (ovl_type_merge_or_lower(new))
1055 err = ovl_set_redirect(new, samedir);
1056 else if (!new_opaque && ovl_type_merge(old->d_parent))
1057 err = ovl_set_opaque_xerr(new, newdentry, -EXDEV);
1062 err = ovl_do_rename(old_upperdir->d_inode, olddentry,
1063 new_upperdir->d_inode, newdentry, flags);
1067 if (cleanup_whiteout)
1068 ovl_cleanup(old_upperdir->d_inode, newdentry);
1070 ovl_dentry_version_inc(old->d_parent);
1071 ovl_dentry_version_inc(new->d_parent);
1078 unlock_rename(new_upperdir, old_upperdir);
1080 revert_creds(old_cred);
1082 ovl_drop_write(old);
1088 const struct inode_operations ovl_dir_inode_operations = {
1089 .lookup = ovl_lookup,
1091 .symlink = ovl_symlink,
1092 .unlink = ovl_unlink,
1094 .rename = ovl_rename,
1096 .setattr = ovl_setattr,
1097 .create = ovl_create,
1099 .permission = ovl_permission,
1100 .getattr = ovl_getattr,
1101 .listxattr = ovl_listxattr,
1102 .get_acl = ovl_get_acl,
1103 .update_time = ovl_update_time,