scripts/checkpatch.pl

   1 #!/usr/bin/perl -w
   2 # (c) 2001, Dave Jones. (the file handling bit)
   3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
   4 # (c) 2007,2008, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite)
   5 # (c) 2008-2010 Andy Whitcroft <apw@canonical.com>
   6 # Licensed under the terms of the GNU GPL License version 2
   7
   8 use strict;
   9 use POSIX;
  10
  11 my $P = $0;
  12 $P =~ s@.*/@@g;
  13
  14 my $V = '0.32';
  15
  16 use Getopt::Long qw(:config no_auto_abbrev);
  17
  18 my $quiet = 0;
  19 my $tree = 1;
  20 my $chk_signoff = 1;
  21 my $chk_patch = 1;
  22 my $tst_only;
  23 my $emacs = 0;
  24 my $terse = 0;
  25 my $file = 0;
  26 my $check = 0;
  27 my $summary = 1;
  28 my $mailback = 0;
  29 my $summary_file = 0;
  30 my $show_types = 0;
  31 my $fix = 0;
  32 my $root;
  33 my %debug;
  34 my %ignore_type = ();
  35 my %camelcase = ();
  36 my @ignore = ();
  37 my $help = 0;
  38 my $configuration_file = ".checkpatch.conf";
  39 my $max_line_length = 80;
  40
  41 sub help {
  42         my ($exitcode) = @_;
  43
  44         print << "EOM";
  45 Usage: $P [OPTION]... [FILE]...
  46 Version: $V
  47
  48 Options:
  49   -q, --quiet                quiet
  50   --no-tree                  run without a kernel tree
  51   --no-signoff               do not check for 'Signed-off-by' line
  52   --patch                    treat FILE as patchfile (default)
  53   --emacs                    emacs compile window format
  54   --terse                    one line per report
  55   -f, --file                 treat FILE as regular source file
  56   --subjective, --strict     enable more subjective tests
  57   --ignore TYPE(,TYPE2...)   ignore various comma separated message types
  58   --max-line-length=n        set the maximum line length, if exceeded, warn
  59   --show-types               show the message "types" in the output
  60   --root=PATH                PATH to the kernel tree root
  61   --no-summary               suppress the per-file summary
  62   --mailback                 only produce a report in case of warnings/errors
  63   --summary-file             include the filename in summary
  64   --debug KEY=[0|1]          turn on/off debugging of KEY, where KEY is one of
  65                              'values', 'possible', 'type', and 'attr' (default
  66                              is all off)
  67   --test-only=WORD           report only warnings/errors containing WORD
  68                              literally
  69   --fix                      EXPERIMENTAL - may create horrible results
  70                              If correctable single-line errors exist, create
  71                              "<inputfile>.EXPERIMENTAL-checkpatch-fixes"
  72                              with potential errors corrected to the preferred
  73                              checkpatch style
  74   -h, --help, --version      display this help and exit
  75
  76 When FILE is - read standard input.
  77 EOM
  78
  79         exit($exitcode);
  80 }
  81
  82 my $conf = which_conf($configuration_file);
  83 if (-f $conf) {
  84         my @conf_args;
  85         open(my $conffile, '<', "$conf")
  86             or warn "$P: Can't find a readable $configuration_file file $!\n";
  87
  88         while (<$conffile>) {
  89                 my $line = $_;
  90
  91                 $line =~ s/\s*\n?$//g;
  92                 $line =~ s/^\s*//g;
  93                 $line =~ s/\s+/ /g;
  94
  95                 next if ($line =~ m/^\s*#/);
  96                 next if ($line =~ m/^\s*$/);
  97
  98                 my @words = split(" ", $line);
  99                 foreach my $word (@words) {
 100                         last if ($word =~ m/^#/);
 101                         push (@conf_args, $word);
 102                 }
 103         }
 104         close($conffile);
 105         unshift(@ARGV, @conf_args) if @conf_args;
 106 }
 107
 108 GetOptions(
 109         'q|quiet+'      => \$quiet,
 110         'tree!'         => \$tree,
 111         'signoff!'      => \$chk_signoff,
 112         'patch!'        => \$chk_patch,
 113         'emacs!'        => \$emacs,
 114         'terse!'        => \$terse,
 115         'f|file!'       => \$file,
 116         'subjective!'   => \$check,
 117         'strict!'       => \$check,
 118         'ignore=s'      => \@ignore,
 119         'show-types!'   => \$show_types,
 120         'max-line-length=i' => \$max_line_length,
 121         'root=s'        => \$root,
 122         'summary!'      => \$summary,
 123         'mailback!'     => \$mailback,
 124         'summary-file!' => \$summary_file,
 125         'fix!'          => \$fix,
 126         'debug=s'       => \%debug,
 127         'test-only=s'   => \$tst_only,
 128         'h|help'        => \$help,
 129         'version'       => \$help
 130 ) or help(1);
 131
 132 help(0) if ($help);
 133
 134 my $exit = 0;
 135
 136 if ($#ARGV < 0) {
 137         print "$P: no input files\n";
 138         exit(1);
 139 }
 140
 141 @ignore = split(/,/, join(',',@ignore));
 142 foreach my $word (@ignore) {
 143         $word =~ s/\s*\n?$//g;
 144         $word =~ s/^\s*//g;
 145         $word =~ s/\s+/ /g;
 146         $word =~ tr/[a-z]/[A-Z]/;
 147
 148         next if ($word =~ m/^\s*#/);
 149         next if ($word =~ m/^\s*$/);
 150
 151         $ignore_type{$word}++;
 152 }
 153
 154 my $dbg_values = 0;
 155 my $dbg_possible = 0;
 156 my $dbg_type = 0;
 157 my $dbg_attr = 0;
 158 for my $key (keys %debug) {
 159         ## no critic
 160         eval "\${dbg_$key} = '$debug{$key}';";
 161         die "$@" if ($@);
 162 }
 163
 164 my $rpt_cleaners = 0;
 165
 166 if ($terse) {
 167         $emacs = 1;
 168         $quiet++;
 169 }
 170
 171 if ($tree) {
 172         if (defined $root) {
 173                 if (!top_of_kernel_tree($root)) {
 174                         die "$P: $root: --root does not point at a valid tree\n";
 175                 }
 176         } else {
 177                 if (top_of_kernel_tree('.')) {
 178                         $root = '.';
 179                 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
 180                                                 top_of_kernel_tree($1)) {
 181                         $root = $1;
 182                 }
 183         }
 184
 185         if (!defined $root) {
 186                 print "Must be run from the top-level dir. of a kernel tree\n";
 187                 exit(2);
 188         }
 189 }
 190
 191 my $emitted_corrupt = 0;
 192
 193 our $Ident      = qr{
 194                         [A-Za-z_][A-Za-z\d_]*
 195                         (?:\s*\#\#\s*[A-Za-z_][A-Za-z\d_]*)*
 196                 }x;
 197 our $Storage    = qr{extern|static|asmlinkage};
 198 our $Sparse     = qr{
 199                         __user|
 200                         __kernel|
 201                         __force|
 202                         __iomem|
 203                         __must_check|
 204                         __init_refok|
 205                         __kprobes|
 206                         __ref|
 207                         __rcu
 208                 }x;
 209
 210 # Notes to $Attribute:
 211 # We need \b after 'init' otherwise 'initconst' will cause a false positive in a check
 212 our $Attribute  = qr{
 213                         const|
 214                         __percpu|
 215                         __nocast|
 216                         __safe|
 217                         __bitwise__|
 218                         __packed__|
 219                         __packed2__|
 220                         __naked|
 221                         __maybe_unused|
 222                         __always_unused|
 223                         __noreturn|
 224                         __used|
 225                         __cold|
 226                         __noclone|
 227                         __deprecated|
 228                         __read_mostly|
 229                         __kprobes|
 230                         __(?:mem|cpu|dev|)(?:initdata|initconst|init\b)|
 231                         ____cacheline_aligned|
 232                         ____cacheline_aligned_in_smp|
 233                         ____cacheline_internodealigned_in_smp|
 234                         __weak
 235                   }x;
 236 our $Modifier;
 237 our $Inline     = qr{inline|__always_inline|noinline};
 238 our $Member     = qr{->$Ident|\.$Ident|\[[^]]*\]};
 239 our $Lval       = qr{$Ident(?:$Member)*};
 240
 241 our $Int_type   = qr{(?i)llu|ull|ll|lu|ul|l|u};
 242 our $Binary     = qr{(?i)0b[01]+$Int_type?};
 243 our $Hex        = qr{(?i)0x[0-9a-f]+$Int_type?};
 244 our $Int        = qr{[0-9]+$Int_type?};
 245 our $Float_hex  = qr{(?i)0x[0-9a-f]+p-?[0-9]+[fl]?};
 246 our $Float_dec  = qr{(?i)(?:[0-9]+\.[0-9]*|[0-9]*\.[0-9]+)(?:e-?[0-9]+)?[fl]?};
 247 our $Float_int  = qr{(?i)[0-9]+e-?[0-9]+[fl]?};
 248 our $Float      = qr{$Float_hex|$Float_dec|$Float_int};
 249 our $Constant   = qr{$Float|$Binary|$Hex|$Int};
 250 our $Assignment = qr{\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=};
 251 our $Compare    = qr{<=|>=|==|!=|<|>};
 252 our $Arithmetic = qr{\+|-|\*|\/|%};
 253 our $Operators  = qr{
 254                         <=|>=|==|!=|
 255                         =>|->|<<|>>|<|>|!|~|
 256                         &&|\|\||,|\^|\+\+|--|&|\||$Arithmetic
 257                   }x;
 258
 259 our $NonptrType;
 260 our $Type;
 261 our $Declare;
 262
 263 our $NON_ASCII_UTF8     = qr{
 264         [\xC2-\xDF][\x80-\xBF]               # non-overlong 2-byte
 265         |  \xE0[\xA0-\xBF][\x80-\xBF]        # excluding overlongs
 266         | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2}  # straight 3-byte
 267         |  \xED[\x80-\x9F][\x80-\xBF]        # excluding surrogates
 268         |  \xF0[\x90-\xBF][\x80-\xBF]{2}     # planes 1-3
 269         | [\xF1-\xF3][\x80-\xBF]{3}          # planes 4-15
 270         |  \xF4[\x80-\x8F][\x80-\xBF]{2}     # plane 16
 271 }x;
 272
 273 our $UTF8       = qr{
 274         [\x09\x0A\x0D\x20-\x7E]              # ASCII
 275         | $NON_ASCII_UTF8
 276 }x;
 277
 278 our $typeTypedefs = qr{(?x:
 279         (?:__)?(?:u|s|be|le)(?:8|16|32|64)|
 280         atomic_t
 281 )};
 282
 283 our $logFunctions = qr{(?x:
 284         printk(?:_ratelimited|_once|)|
 285         (?:[a-z0-9]+_){1,2}(?:printk|emerg|alert|crit|err|warning|warn|notice|info|debug|dbg|vdbg|devel|cont|WARN)(?:_ratelimited|_once|)|
 286         WARN(?:_RATELIMIT|_ONCE|)|
 287         panic|
 288         MODULE_[A-Z_]+
 289 )};
 290
 291 our $signature_tags = qr{(?xi:
 292         Signed-off-by:|
 293         Acked-by:|
 294         Tested-by:|
 295         Reviewed-by:|
 296         Reported-by:|
 297         Suggested-by:|
 298         To:|
 299         Cc:
 300 )};
 301
 302 our @typeList = (
 303         qr{void},
 304         qr{(?:unsigned\s+)?char},
 305         qr{(?:unsigned\s+)?short},
 306         qr{(?:unsigned\s+)?int},
 307         qr{(?:unsigned\s+)?long},
 308         qr{(?:unsigned\s+)?long\s+int},
 309         qr{(?:unsigned\s+)?long\s+long},
 310         qr{(?:unsigned\s+)?long\s+long\s+int},
 311         qr{unsigned},
 312         qr{float},
 313         qr{double},
 314         qr{bool},
 315         qr{struct\s+$Ident},
 316         qr{union\s+$Ident},
 317         qr{enum\s+$Ident},
 318         qr{${Ident}_t},
 319         qr{${Ident}_handler},
 320         qr{${Ident}_handler_fn},
 321 );
 322 our @modifierList = (
 323         qr{fastcall},
 324 );
 325
 326 our $allowed_asm_includes = qr{(?x:
 327         irq|
 328         memory
 329 )};
 330 # memory.h: ARM has a custom one
 331
 332 sub build_types {
 333         my $mods = "(?x:  \n" . join("|\n  ", @modifierList) . "\n)";
 334         my $all = "(?x:  \n" . join("|\n  ", @typeList) . "\n)";
 335         $Modifier       = qr{(?:$Attribute|$Sparse|$mods)};
 336         $NonptrType     = qr{
 337                         (?:$Modifier\s+|const\s+)*
 338                         (?:
 339                                 (?:typeof|__typeof__)\s*\([^\)]*\)|
 340                                 (?:$typeTypedefs\b)|
 341                                 (?:${all}\b)
 342                         )
 343                         (?:\s+$Modifier|\s+const)*
 344                   }x;
 345         $Type   = qr{
 346                         $NonptrType
 347                         (?:(?:\s|\*|\[\])+\s*const|(?:\s|\*|\[\])+|(?:\s*\[\s*\])+)?
 348                         (?:\s+$Inline|\s+$Modifier)*
 349                   }x;
 350         $Declare        = qr{(?:$Storage\s+)?$Type};
 351 }
 352 build_types();
 353
 354 our $Typecast   = qr{\s*(\(\s*$NonptrType\s*\)){0,1}\s*};
 355
 356 # Using $balanced_parens, $LvalOrFunc, or $FuncArg
 357 # requires at least perl version v5.10.0
 358 # Any use must be runtime checked with $^V
 359
 360 our $balanced_parens = qr/(\((?:[^\(\)]++|(?-1))*\))/;
 361 our $LvalOrFunc = qr{($Lval)\s*($balanced_parens{0,1})\s*};
 362 our $FuncArg = qr{$Typecast{0,1}($LvalOrFunc|$Constant)};
 363
 364 sub deparenthesize {
 365         my ($string) = @_;
 366         return "" if (!defined($string));
 367         $string =~ s@^\s*\(\s*@@g;
 368         $string =~ s@\s*\)\s*$@@g;
 369         $string =~ s@\s+@ @g;
 370         return $string;
 371 }
 372
 373 sub seed_camelcase_file {
 374         my ($file) = @_;
 375
 376         return if (!(-f $file));
 377
 378         local $/;
 379
 380         open(my $include_file, '<', "$file")
 381             or warn "$P: Can't read '$file' $!\n";
 382         my $text = <$include_file>;
 383         close($include_file);
 384
 385         my @lines = split('\n', $text);
 386
 387         foreach my $line (@lines) {
 388                 next if ($line !~ /(?:[A-Z][a-z]|[a-z][A-Z])/);
 389                 if ($line =~ /^[ \t]*(?:#[ \t]*define|typedef\s+$Type)\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)/) {
 390                         $camelcase{$1} = 1;
 391                 }
 392                 elsif ($line =~ /^\s*$Declare\s+(\w*(?:[A-Z][a-z]|[a-z][A-Z])\w*)\s*\(/) {
 393                         $camelcase{$1} = 1;
 394                 }
 395         }
 396 }
 397
 398 my $camelcase_seeded = 0;
 399 sub seed_camelcase_includes {
 400         return if ($camelcase_seeded);
 401
 402         my $files;
 403         my $camelcase_cache = "";
 404         my @include_files = ();
 405
 406         $camelcase_seeded = 1;
 407
 408         if (-d ".git") {
 409                 my $git_last_include_commit = `git log --no-merges --pretty=format:"%h%n" -1 -- include`;
 410                 chomp $git_last_include_commit;
 411                 $camelcase_cache = ".checkpatch-camelcase.git.$git_last_include_commit";
 412         } else {
 413                 my $last_mod_date = 0;
 414                 $files = `find $root/include -name "*.h"`;
 415                 @include_files = split('\n', $files);
 416                 foreach my $file (@include_files) {
 417                         my $date = POSIX::strftime("%Y%m%d%H%M",
 418                                                    localtime((stat $file)[9]));
 419                         $last_mod_date = $date if ($last_mod_date < $date);
 420                 }
 421                 $camelcase_cache = ".checkpatch-camelcase.date.$last_mod_date";
 422         }
 423
 424         if ($camelcase_cache ne "" && -f $camelcase_cache) {
 425                 open(my $camelcase_file, '<', "$camelcase_cache")
 426                     or warn "$P: Can't read '$camelcase_cache' $!\n";
 427                 while (<$camelcase_file>) {
 428                         chomp;
 429                         $camelcase{$_} = 1;
 430                 }
 431                 close($camelcase_file);
 432
 433                 return;
 434         }
 435
 436         if (-d ".git") {
 437                 $files = `git ls-files "include/*.h"`;
 438                 @include_files = split('\n', $files);
 439         }
 440
 441         foreach my $file (@include_files) {
 442                 seed_camelcase_file($file);
 443         }
 444
 445         if ($camelcase_cache ne "") {
 446                 unlink glob ".checkpatch-camelcase.*";
 447                 open(my $camelcase_file, '>', "$camelcase_cache")
 448                     or warn "$P: Can't write '$camelcase_cache' $!\n";
 449                 foreach (sort { lc($a) cmp lc($b) } keys(%camelcase)) {
 450                         print $camelcase_file ("$_\n");
 451                 }
 452                 close($camelcase_file);
 453         }
 454 }
 455
 456 $chk_signoff = 0 if ($file);
 457
 458 my @rawlines = ();
 459 my @lines = ();
 460 my @fixed = ();
 461 my $vname;
 462 for my $filename (@ARGV) {
 463         my $FILE;
 464         if ($file) {
 465                 open($FILE, '-|', "diff -u /dev/null $filename") ||
 466                         die "$P: $filename: diff failed - $!\n";
 467         } elsif ($filename eq '-') {
 468                 open($FILE, '<&STDIN');
 469         } else {
 470                 open($FILE, '<', "$filename") ||
 471                         die "$P: $filename: open failed - $!\n";
 472         }
 473         if ($filename eq '-') {
 474                 $vname = 'Your patch';
 475         } else {
 476                 $vname = $filename;
 477         }
 478         while (<$FILE>) {
 479                 chomp;
 480                 push(@rawlines, $_);
 481         }
 482         close($FILE);
 483         if (!process($filename)) {
 484                 $exit = 1;
 485         }
 486         @rawlines = ();
 487         @lines = ();
 488         @fixed = ();
 489 }
 490
 491 exit($exit);
 492
 493 sub top_of_kernel_tree {
 494         my ($root) = @_;
 495
 496         my @tree_check = (
 497                 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
 498                 "README", "Documentation", "arch", "include", "drivers",
 499                 "fs", "init", "ipc", "kernel", "lib", "scripts",
 500         );
 501
 502         foreach my $check (@tree_check) {
 503                 if (! -e $root . '/' . $check) {
 504                         return 0;
 505                 }
 506         }
 507         return 1;
 508 }
 509
 510 sub parse_email {
 511         my ($formatted_email) = @_;
 512
 513         my $name = "";
 514         my $address = "";
 515         my $comment = "";
 516
 517         if ($formatted_email =~ /^(.*)<(\S+\@\S+)>(.*)$/) {
 518                 $name = $1;
 519                 $address = $2;
 520                 $comment = $3 if defined $3;
 521         } elsif ($formatted_email =~ /^\s*<(\S+\@\S+)>(.*)$/) {
 522                 $address = $1;
 523                 $comment = $2 if defined $2;
 524         } elsif ($formatted_email =~ /(\S+\@\S+)(.*)$/) {
 525                 $address = $1;
 526                 $comment = $2 if defined $2;
 527                 $formatted_email =~ s/$address.*$//;
 528                 $name = $formatted_email;
 529                 $name = trim($name);
 530                 $name =~ s/^\"|\"$//g;
 531                 # If there's a name left after stripping spaces and
 532                 # leading quotes, and the address doesn't have both
 533                 # leading and trailing angle brackets, the address
 534                 # is invalid. ie:
 535                 #   "joe smith joe@smith.com" bad
 536                 #   "joe smith <joe@smith.com" bad
 537                 if ($name ne "" && $address !~ /^<[^>]+>$/) {
 538                         $name = "";
 539                         $address = "";
 540                         $comment = "";
 541                 }
 542         }
 543
 544         $name = trim($name);
 545         $name =~ s/^\"|\"$//g;
 546         $address = trim($address);
 547         $address =~ s/^\<|\>$//g;
 548
 549         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 550                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
 551                 $name = "\"$name\"";
 552         }
 553
 554         return ($name, $address, $comment);
 555 }
 556
 557 sub format_email {
 558         my ($name, $address) = @_;
 559
 560         my $formatted_email;
 561
 562         $name = trim($name);
 563         $name =~ s/^\"|\"$//g;
 564         $address = trim($address);
 565
 566         if ($name =~ /[^\w \-]/i) { ##has "must quote" chars
 567                 $name =~ s/(?<!\\)"/\\"/g; ##escape quotes
 568                 $name = "\"$name\"";
 569         }
 570
 571         if ("$name" eq "") {
 572                 $formatted_email = "$address";
 573         } else {
 574                 $formatted_email = "$name <$address>";
 575         }
 576
 577         return $formatted_email;
 578 }
 579
 580 sub which_conf {
 581         my ($conf) = @_;
 582
 583         foreach my $path (split(/:/, ".:$ENV{HOME}:.scripts")) {
 584                 if (-e "$path/$conf") {
 585                         return "$path/$conf";
 586                 }
 587         }
 588
 589         return "";
 590 }
 591
 592 sub expand_tabs {
 593         my ($str) = @_;
 594
 595         my $res = '';
 596         my $n = 0;
 597         for my $c (split(//, $str)) {
 598                 if ($c eq "\t") {
 599                         $res .= ' ';
 600                         $n++;
 601                         for (; ($n % 8) != 0; $n++) {
 602                                 $res .= ' ';
 603                         }
 604                         next;
 605                 }
 606                 $res .= $c;
 607                 $n++;
 608         }
 609
 610         return $res;
 611 }
 612 sub copy_spacing {
 613         (my $res = shift) =~ tr/\t/ /c;
 614         return $res;
 615 }
 616
 617 sub line_stats {
 618         my ($line) = @_;
 619
 620         # Drop the diff line leader and expand tabs
 621         $line =~ s/^.//;
 622         $line = expand_tabs($line);
 623
 624         # Pick the indent from the front of the line.
 625         my ($white) = ($line =~ /^(\s*)/);
 626
 627         return (length($line), length($white));
 628 }
 629
 630 my $sanitise_quote = '';
 631
 632 sub sanitise_line_reset {
 633         my ($in_comment) = @_;
 634
 635         if ($in_comment) {
 636                 $sanitise_quote = '*/';
 637         } else {
 638                 $sanitise_quote = '';
 639         }
 640 }
 641 sub sanitise_line {
 642         my ($line) = @_;
 643
 644         my $res = '';
 645         my $l = '';
 646
 647         my $qlen = 0;
 648         my $off = 0;
 649         my $c;
 650
 651         # Always copy over the diff marker.
 652         $res = substr($line, 0, 1);
 653
 654         for ($off = 1; $off < length($line); $off++) {
 655                 $c = substr($line, $off, 1);
 656
 657                 # Comments we are wacking completly including the begin
 658                 # and end, all to $;.
 659                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
 660                         $sanitise_quote = '*/';
 661
 662                         substr($res, $off, 2, "$;$;");
 663                         $off++;
 664                         next;
 665                 }
 666                 if ($sanitise_quote eq '*/' && substr($line, $off, 2) eq '*/') {
 667                         $sanitise_quote = '';
 668                         substr($res, $off, 2, "$;$;");
 669                         $off++;
 670                         next;
 671                 }
 672                 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '//') {
 673                         $sanitise_quote = '//';
 674
 675                         substr($res, $off, 2, $sanitise_quote);
 676                         $off++;
 677                         next;
 678                 }
 679
 680                 # A \ in a string means ignore the next character.
 681                 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
 682                     $c eq "\\") {
 683                         substr($res, $off, 2, 'XX');
 684                         $off++;
 685                         next;
 686                 }
 687                 # Regular quotes.
 688                 if ($c eq "'" || $c eq '"') {
 689                         if ($sanitise_quote eq '') {
 690                                 $sanitise_quote = $c;
 691
 692                                 substr($res, $off, 1, $c);
 693                                 next;
 694                         } elsif ($sanitise_quote eq $c) {
 695                                 $sanitise_quote = '';
 696                         }
 697                 }
 698
 699                 #print "c<$c> SQ<$sanitise_quote>\n";
 700                 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
 701                         substr($res, $off, 1, $;);
 702                 } elsif ($off != 0 && $sanitise_quote eq '//' && $c ne "\t") {
 703                         substr($res, $off, 1, $;);
 704                 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
 705                         substr($res, $off, 1, 'X');
 706                 } else {
 707                         substr($res, $off, 1, $c);
 708                 }
 709         }
 710
 711         if ($sanitise_quote eq '//') {
 712                 $sanitise_quote = '';
 713         }
 714
 715         # The pathname on a #include may be surrounded by '<' and '>'.
 716         if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
 717                 my $clean = 'X' x length($1);
 718                 $res =~ s@\<.*\>@<$clean>@;
 719
 720         # The whole of a #error is a string.
 721         } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
 722                 my $clean = 'X' x length($1);
 723                 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
 724         }
 725
 726         return $res;
 727 }
 728
 729 sub get_quoted_string {
 730         my ($line, $rawline) = @_;
 731
 732         return "" if ($line !~ m/(\"[X]+\")/g);
 733         return substr($rawline, $-[0], $+[0] - $-[0]);
 734 }
 735
 736 sub ctx_statement_block {
 737         my ($linenr, $remain, $off) = @_;
 738         my $line = $linenr - 1;
 739         my $blk = '';
 740         my $soff = $off;
 741         my $coff = $off - 1;
 742         my $coff_set = 0;
 743
 744         my $loff = 0;
 745
 746         my $type = '';
 747         my $level = 0;
 748         my @stack = ();
 749         my $p;
 750         my $c;
 751         my $len = 0;
 752
 753         my $remainder;
 754         while (1) {
 755                 @stack = (['', 0]) if ($#stack == -1);
 756
 757                 #warn "CSB: blk<$blk> remain<$remain>\n";
 758                 # If we are about to drop off the end, pull in more
 759                 # context.
 760                 if ($off >= $len) {
 761                         for (; $remain > 0; $line++) {
 762                                 last if (!defined $lines[$line]);
 763                                 next if ($lines[$line] =~ /^-/);
 764                                 $remain--;
 765                                 $loff = $len;
 766                                 $blk .= $lines[$line] . "\n";
 767                                 $len = length($blk);
 768                                 $line++;
 769                                 last;
 770                         }
 771                         # Bail if there is no further context.
 772                         #warn "CSB: blk<$blk> off<$off> len<$len>\n";
 773                         if ($off >= $len) {
 774                                 last;
 775                         }
 776                         if ($level == 0 && substr($blk, $off) =~ /^.\s*#\s*define/) {
 777                                 $level++;
 778                                 $type = '#';
 779                         }
 780                 }
 781                 $p = $c;
 782                 $c = substr($blk, $off, 1);
 783                 $remainder = substr($blk, $off);
 784
 785                 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
 786
 787                 # Handle nested #if/#else.
 788                 if ($remainder =~ /^#\s*(?:ifndef|ifdef|if)\s/) {
 789                         push(@stack, [ $type, $level ]);
 790                 } elsif ($remainder =~ /^#\s*(?:else|elif)\b/) {
 791                         ($type, $level) = @{$stack[$#stack - 1]};
 792                 } elsif ($remainder =~ /^#\s*endif\b/) {
 793                         ($type, $level) = @{pop(@stack)};
 794                 }
 795
 796                 # Statement ends at the ';' or a close '}' at the
 797                 # outermost level.
 798                 if ($level == 0 && $c eq ';') {
 799                         last;
 800                 }
 801
 802                 # An else is really a conditional as long as its not else if
 803                 if ($level == 0 && $coff_set == 0 &&
 804                                 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
 805                                 $remainder =~ /^(else)(?:\s|{)/ &&
 806                                 $remainder !~ /^else\s+if\b/) {
 807                         $coff = $off + length($1) - 1;
 808                         $coff_set = 1;
 809                         #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
 810                         #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
 811                 }
 812
 813                 if (($type eq '' || $type eq '(') && $c eq '(') {
 814                         $level++;
 815                         $type = '(';
 816                 }
 817                 if ($type eq '(' && $c eq ')') {
 818                         $level--;
 819                         $type = ($level != 0)? '(' : '';
 820
 821                         if ($level == 0 && $coff < $soff) {
 822                                 $coff = $off;
 823                                 $coff_set = 1;
 824                                 #warn "CSB: mark coff<$coff>\n";
 825                         }
 826                 }
 827                 if (($type eq '' || $type eq '{') && $c eq '{') {
 828                         $level++;
 829                         $type = '{';
 830                 }
 831                 if ($type eq '{' && $c eq '}') {
 832                         $level--;
 833                         $type = ($level != 0)? '{' : '';
 834
 835                         if ($level == 0) {
 836                                 if (substr($blk, $off + 1, 1) eq ';') {
 837                                         $off++;
 838                                 }
 839                                 last;
 840                         }
 841                 }
 842                 # Preprocessor commands end at the newline unless escaped.
 843                 if ($type eq '#' && $c eq "\n" && $p ne "\\") {
 844                         $level--;
 845                         $type = '';
 846                         $off++;
 847                         last;
 848                 }
 849                 $off++;
 850         }
 851         # We are truly at the end, so shuffle to the next line.
 852         if ($off == $len) {
 853                 $loff = $len + 1;
 854                 $line++;
 855                 $remain--;
 856         }
 857
 858         my $statement = substr($blk, $soff, $off - $soff + 1);
 859         my $condition = substr($blk, $soff, $coff - $soff + 1);
 860
 861         #warn "STATEMENT<$statement>\n";
 862         #warn "CONDITION<$condition>\n";
 863
 864         #print "coff<$coff> soff<$off> loff<$loff>\n";
 865
 866         return ($statement, $condition,
 867                         $line, $remain + 1, $off - $loff + 1, $level);
 868 }
 869
 870 sub statement_lines {
 871         my ($stmt) = @_;
 872
 873         # Strip the diff line prefixes and rip blank lines at start and end.
 874         $stmt =~ s/(^|\n)./$1/g;
 875         $stmt =~ s/^\s*//;
 876         $stmt =~ s/\s*$//;
 877
 878         my @stmt_lines = ($stmt =~ /\n/g);
 879
 880         return $#stmt_lines + 2;
 881 }
 882
 883 sub statement_rawlines {
 884         my ($stmt) = @_;
 885
 886         my @stmt_lines = ($stmt =~ /\n/g);
 887
 888         return $#stmt_lines + 2;
 889 }
 890
 891 sub statement_block_size {
 892         my ($stmt) = @_;
 893
 894         $stmt =~ s/(^|\n)./$1/g;
 895         $stmt =~ s/^\s*{//;
 896         $stmt =~ s/}\s*$//;
 897         $stmt =~ s/^\s*//;
 898         $stmt =~ s/\s*$//;
 899
 900         my @stmt_lines = ($stmt =~ /\n/g);
 901         my @stmt_statements = ($stmt =~ /;/g);
 902
 903         my $stmt_lines = $#stmt_lines + 2;
 904         my $stmt_statements = $#stmt_statements + 1;
 905
 906         if ($stmt_lines > $stmt_statements) {
 907                 return $stmt_lines;
 908         } else {
 909                 return $stmt_statements;
 910         }
 911 }
 912
 913 sub ctx_statement_full {
 914         my ($linenr, $remain, $off) = @_;
 915         my ($statement, $condition, $level);
 916
 917         my (@chunks);
 918
 919         # Grab the first conditional/block pair.
 920         ($statement, $condition, $linenr, $remain, $off, $level) =
 921                                 ctx_statement_block($linenr, $remain, $off);
 922         #print "F: c<$condition> s<$statement> remain<$remain>\n";
 923         push(@chunks, [ $condition, $statement ]);
 924         if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
 925                 return ($level, $linenr, @chunks);
 926         }
 927
 928         # Pull in the following conditional/block pairs and see if they
 929         # could continue the statement.
 930         for (;;) {
 931                 ($statement, $condition, $linenr, $remain, $off, $level) =
 932                                 ctx_statement_block($linenr, $remain, $off);
 933                 #print "C: c<$condition> s<$statement> remain<$remain>\n";
 934                 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
 935                 #print "C: push\n";
 936                 push(@chunks, [ $condition, $statement ]);
 937         }
 938
 939         return ($level, $linenr, @chunks);
 940 }
 941
 942 sub ctx_block_get {
 943         my ($linenr, $remain, $outer, $open, $close, $off) = @_;
 944         my $line;
 945         my $start = $linenr - 1;
 946         my $blk = '';
 947         my @o;
 948         my @c;
 949         my @res = ();
 950
 951         my $level = 0;
 952         my @stack = ($level);
 953         for ($line = $start; $remain > 0; $line++) {
 954                 next if ($rawlines[$line] =~ /^-/);
 955                 $remain--;
 956
 957                 $blk .= $rawlines[$line];
 958
 959                 # Handle nested #if/#else.
 960                 if ($lines[$line] =~ /^.\s*#\s*(?:ifndef|ifdef|if)\s/) {
 961                         push(@stack, $level);
 962                 } elsif ($lines[$line] =~ /^.\s*#\s*(?:else|elif)\b/) {
 963                         $level = $stack[$#stack - 1];
 964                 } elsif ($lines[$line] =~ /^.\s*#\s*endif\b/) {
 965                         $level = pop(@stack);
 966                 }
 967
 968                 foreach my $c (split(//, $lines[$line])) {
 969                         ##print "C<$c>L<$level><$open$close>O<$off>\n";
 970                         if ($off > 0) {
 971                                 $off--;
 972                                 next;
 973                         }
 974
 975                         if ($c eq $close && $level > 0) {
 976                                 $level--;
 977                                 last if ($level == 0);
 978                         } elsif ($c eq $open) {
 979                                 $level++;
 980                         }
 981                 }
 982
 983                 if (!$outer || $level <= 1) {
 984                         push(@res, $rawlines[$line]);
 985                 }
 986
 987                 last if ($level == 0);
 988         }
 989
 990         return ($level, @res);
 991 }
 992 sub ctx_block_outer {
 993         my ($linenr, $remain) = @_;
 994
 995         my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
 996         return @r;
 997 }
 998 sub ctx_block {
 999         my ($linenr, $remain) = @_;
1000
1001         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
1002         return @r;
1003 }
1004 sub ctx_statement {
1005         my ($linenr, $remain, $off) = @_;
1006
1007         my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
1008         return @r;
1009 }
1010 sub ctx_block_level {
1011         my ($linenr, $remain) = @_;
1012
1013         return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
1014 }
1015 sub ctx_statement_level {
1016         my ($linenr, $remain, $off) = @_;
1017
1018         return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
1019 }
1020
1021 sub ctx_locate_comment {
1022         my ($first_line, $end_line) = @_;
1023
1024         # Catch a comment on the end of the line itself.
1025         my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
1026         return $current_comment if (defined $current_comment);
1027
1028         # Look through the context and try and figure out if there is a
1029         # comment.
1030         my $in_comment = 0;
1031         $current_comment = '';
1032         for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
1033                 my $line = $rawlines[$linenr - 1];
1034                 #warn "           $line\n";
1035                 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
1036                         $in_comment = 1;
1037                 }
1038                 if ($line =~ m@/\*@) {
1039                         $in_comment = 1;
1040                 }
1041                 if (!$in_comment && $current_comment ne '') {
1042                         $current_comment = '';
1043                 }
1044                 $current_comment .= $line . "\n" if ($in_comment);
1045                 if ($line =~ m@\*/@) {
1046                         $in_comment = 0;
1047                 }
1048         }
1049
1050         chomp($current_comment);
1051         return($current_comment);
1052 }
1053 sub ctx_has_comment {
1054         my ($first_line, $end_line) = @_;
1055         my $cmt = ctx_locate_comment($first_line, $end_line);
1056
1057         ##print "LINE: $rawlines[$end_line - 1 ]\n";
1058         ##print "CMMT: $cmt\n";
1059
1060         return ($cmt ne '');
1061 }
1062
1063 sub raw_line {
1064         my ($linenr, $cnt) = @_;
1065
1066         my $offset = $linenr - 1;
1067         $cnt++;
1068
1069         my $line;
1070         while ($cnt) {
1071                 $line = $rawlines[$offset++];
1072                 next if (defined($line) && $line =~ /^-/);
1073                 $cnt--;
1074         }
1075
1076         return $line;
1077 }
1078
1079 sub cat_vet {
1080         my ($vet) = @_;
1081         my ($res, $coded);
1082
1083         $res = '';
1084         while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
1085                 $res .= $1;
1086                 if ($2 ne '') {
1087                         $coded = sprintf("^%c", unpack('C', $2) + 64);
1088                         $res .= $coded;
1089                 }
1090         }
1091         $res =~ s/$/\$/;
1092
1093         return $res;
1094 }
1095
1096 my $av_preprocessor = 0;
1097 my $av_pending;
1098 my @av_paren_type;
1099 my $av_pend_colon;
1100
1101 sub annotate_reset {
1102         $av_preprocessor = 0;
1103         $av_pending = '_';
1104         @av_paren_type = ('E');
1105         $av_pend_colon = 'O';
1106 }
1107
1108 sub annotate_values {
1109         my ($stream, $type) = @_;
1110
1111         my $res;
1112         my $var = '_' x length($stream);
1113         my $cur = $stream;
1114
1115         print "$stream\n" if ($dbg_values > 1);
1116
1117         while (length($cur)) {
1118                 @av_paren_type = ('E') if ($#av_paren_type < 0);
1119                 print " <" . join('', @av_paren_type) .
1120                                 "> <$type> <$av_pending>" if ($dbg_values > 1);
1121                 if ($cur =~ /^(\s+)/o) {
1122                         print "WS($1)\n" if ($dbg_values > 1);
1123                         if ($1 =~ /\n/ && $av_preprocessor) {
1124                                 $type = pop(@av_paren_type);
1125                                 $av_preprocessor = 0;
1126                         }
1127
1128                 } elsif ($cur =~ /^(\(\s*$Type\s*)\)/ && $av_pending eq '_') {
1129                         print "CAST($1)\n" if ($dbg_values > 1);
1130                         push(@av_paren_type, $type);
1131                         $type = 'c';
1132
1133                 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\(|\s*$)/) {
1134                         print "DECLARE($1)\n" if ($dbg_values > 1);
1135                         $type = 'T';
1136
1137                 } elsif ($cur =~ /^($Modifier)\s*/) {
1138                         print "MODIFIER($1)\n" if ($dbg_values > 1);
1139                         $type = 'T';
1140
1141                 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
1142                         print "DEFINE($1,$2)\n" if ($dbg_values > 1);
1143                         $av_preprocessor = 1;
1144                         push(@av_paren_type, $type);
1145                         if ($2 ne '') {
1146                                 $av_pending = 'N';
1147                         }
1148                         $type = 'E';
1149
1150                 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
1151                         print "UNDEF($1)\n" if ($dbg_values > 1);
1152                         $av_preprocessor = 1;
1153                         push(@av_paren_type, $type);
1154
1155                 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
1156                         print "PRE_START($1)\n" if ($dbg_values > 1);
1157                         $av_preprocessor = 1;
1158
1159                         push(@av_paren_type, $type);
1160                         push(@av_paren_type, $type);
1161                         $type = 'E';
1162
1163                 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
1164                         print "PRE_RESTART($1)\n" if ($dbg_values > 1);
1165                         $av_preprocessor = 1;
1166
1167                         push(@av_paren_type, $av_paren_type[$#av_paren_type]);
1168
1169                         $type = 'E';
1170
1171                 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
1172                         print "PRE_END($1)\n" if ($dbg_values > 1);
1173
1174                         $av_preprocessor = 1;
1175
1176                         # Assume all arms of the conditional end as this
1177                         # one does, and continue as if the #endif was not here.
1178                         pop(@av_paren_type);
1179                         push(@av_paren_type, $type);
1180                         $type = 'E';
1181
1182                 } elsif ($cur =~ /^(\\\n)/o) {
1183                         print "PRECONT($1)\n" if ($dbg_values > 1);
1184
1185                 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
1186                         print "ATTR($1)\n" if ($dbg_values > 1);
1187                         $av_pending = $type;
1188                         $type = 'N';
1189
1190                 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
1191                         print "SIZEOF($1)\n" if ($dbg_values > 1);
1192                         if (defined $2) {
1193                                 $av_pending = 'V';
1194                         }
1195                         $type = 'N';
1196
1197                 } elsif ($cur =~ /^(if|while|for)\b/o) {
1198                         print "COND($1)\n" if ($dbg_values > 1);
1199                         $av_pending = 'E';
1200                         $type = 'N';
1201
1202                 } elsif ($cur =~/^(case)/o) {
1203                         print "CASE($1)\n" if ($dbg_values > 1);
1204                         $av_pend_colon = 'C';
1205                         $type = 'N';
1206
1207                 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
1208                         print "KEYWORD($1)\n" if ($dbg_values > 1);
1209                         $type = 'N';
1210
1211                 } elsif ($cur =~ /^(\()/o) {
1212                         print "PAREN('$1')\n" if ($dbg_values > 1);
1213                         push(@av_paren_type, $av_pending);
1214                         $av_pending = '_';
1215                         $type = 'N';
1216
1217                 } elsif ($cur =~ /^(\))/o) {
1218                         my $new_type = pop(@av_paren_type);
1219                         if ($new_type ne '_') {
1220                                 $type = $new_type;
1221                                 print "PAREN('$1') -> $type\n"
1222                                                         if ($dbg_values > 1);
1223                         } else {
1224                                 print "PAREN('$1')\n" if ($dbg_values > 1);
1225                         }
1226
1227                 } elsif ($cur =~ /^($Ident)\s*\(/o) {
1228                         print "FUNC($1)\n" if ($dbg_values > 1);
1229                         $type = 'V';
1230                         $av_pending = 'V';
1231
1232                 } elsif ($cur =~ /^($Ident\s*):(?:\s*\d+\s*(,|=|;))?/) {
1233                         if (defined $2 && $type eq 'C' || $type eq 'T') {
1234                                 $av_pend_colon = 'B';
1235                         } elsif ($type eq 'E') {
1236                                 $av_pend_colon = 'L';
1237                         }
1238                         print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
1239                         $type = 'V';
1240
1241                 } elsif ($cur =~ /^($Ident|$Constant)/o) {
1242                         print "IDENT($1)\n" if ($dbg_values > 1);
1243                         $type = 'V';
1244
1245                 } elsif ($cur =~ /^($Assignment)/o) {
1246                         print "ASSIGN($1)\n" if ($dbg_values > 1);
1247                         $type = 'N';
1248
1249                 } elsif ($cur =~/^(;|{|})/) {
1250                         print "END($1)\n" if ($dbg_values > 1);
1251                         $type = 'E';
1252                         $av_pend_colon = 'O';
1253
1254                 } elsif ($cur =~/^(,)/) {
1255                         print "COMMA($1)\n" if ($dbg_values > 1);
1256                         $type = 'C';
1257
1258                 } elsif ($cur =~ /^(\?)/o) {
1259                         print "QUESTION($1)\n" if ($dbg_values > 1);
1260                         $type = 'N';
1261
1262                 } elsif ($cur =~ /^(:)/o) {
1263                         print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
1264
1265                         substr($var, length($res), 1, $av_pend_colon);
1266                         if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
1267                                 $type = 'E';
1268                         } else {
1269                                 $type = 'N';
1270                         }
1271                         $av_pend_colon = 'O';
1272
1273                 } elsif ($cur =~ /^(\[)/o) {
1274                         print "CLOSE($1)\n" if ($dbg_values > 1);
1275                         $type = 'N';
1276
1277                 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
1278                         my $variant;
1279
1280                         print "OPV($1)\n" if ($dbg_values > 1);
1281                         if ($type eq 'V') {
1282                                 $variant = 'B';
1283                         } else {
1284                                 $variant = 'U';
1285                         }
1286
1287                         substr($var, length($res), 1, $variant);
1288                         $type = 'N';
1289
1290                 } elsif ($cur =~ /^($Operators)/o) {
1291                         print "OP($1)\n" if ($dbg_values > 1);
1292                         if ($1 ne '++' && $1 ne '--') {
1293                                 $type = 'N';
1294                         }
1295
1296                 } elsif ($cur =~ /(^.)/o) {
1297                         print "C($1)\n" if ($dbg_values > 1);
1298                 }
1299                 if (defined $1) {
1300                         $cur = substr($cur, length($1));
1301                         $res .= $type x length($1);
1302                 }
1303         }
1304
1305         return ($res, $var);
1306 }
1307
1308 sub possible {
1309         my ($possible, $line) = @_;
1310         my $notPermitted = qr{(?:
1311                 ^(?:
1312                         $Modifier|
1313                         $Storage|
1314                         $Type|
1315                         DEFINE_\S+
1316                 )$|
1317                 ^(?:
1318                         goto|
1319                         return|
1320                         case|
1321                         else|
1322                         asm|__asm__|
1323                         do|
1324                         \#|
1325                         \#\#|
1326                 )(?:\s|$)|
1327                 ^(?:typedef|struct|enum)\b
1328             )}x;
1329         warn "CHECK<$possible> ($line)\n" if ($dbg_possible > 2);
1330         if ($possible !~ $notPermitted) {
1331                 # Check for modifiers.
1332                 $possible =~ s/\s*$Storage\s*//g;
1333                 $possible =~ s/\s*$Sparse\s*//g;
1334                 if ($possible =~ /^\s*$/) {
1335
1336                 } elsif ($possible =~ /\s/) {
1337                         $possible =~ s/\s*$Type\s*//g;
1338                         for my $modifier (split(' ', $possible)) {
1339                                 if ($modifier !~ $notPermitted) {
1340                                         warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
1341                                         push(@modifierList, $modifier);
1342                                 }
1343                         }
1344
1345                 } else {
1346                         warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
1347                         push(@typeList, $possible);
1348                 }
1349                 build_types();
1350         } else {
1351                 warn "NOTPOSS: $possible ($line)\n" if ($dbg_possible > 1);
1352         }
1353 }
1354
1355 my $prefix = '';
1356
1357 sub show_type {
1358        return !defined $ignore_type{$_[0]};
1359 }
1360
1361 sub report {
1362         if (!show_type($_[1]) ||
1363             (defined $tst_only && $_[2] !~ /\Q$tst_only\E/)) {
1364                 return 0;
1365         }
1366         my $line;
1367         if ($show_types) {
1368                 $line = "$prefix$_[0]:$_[1]: $_[2]\n";
1369         } else {
1370                 $line = "$prefix$_[0]: $_[2]\n";
1371         }
1372         $line = (split('\n', $line))[0] . "\n" if ($terse);
1373
1374         push(our @report, $line);
1375
1376         return 1;
1377 }
1378 sub report_dump {
1379         our @report;
1380 }
1381
1382 sub ERROR {
1383         if (report("ERROR", $_[0], $_[1])) {
1384                 our $clean = 0;
1385                 our $cnt_error++;
1386                 return 1;
1387         }
1388         return 0;
1389 }
1390 sub WARN {
1391         if (report("WARNING", $_[0], $_[1])) {
1392                 our $clean = 0;
1393                 our $cnt_warn++;
1394                 return 1;
1395         }
1396         return 0;
1397 }
1398 sub CHK {
1399         if ($check && report("CHECK", $_[0], $_[1])) {
1400                 our $clean = 0;
1401                 our $cnt_chk++;
1402                 return 1;
1403         }
1404         return 0;
1405 }
1406
1407 sub check_absolute_file {
1408         my ($absolute, $herecurr) = @_;
1409         my $file = $absolute;
1410
1411         ##print "absolute<$absolute>\n";
1412
1413         # See if any suffix of this path is a path within the tree.
1414         while ($file =~ s@^[^/]*/@@) {
1415                 if (-f "$root/$file") {
1416                         ##print "file<$file>\n";
1417                         last;
1418                 }
1419         }
1420         if (! -f _)  {
1421                 return 0;
1422         }
1423
1424         # It is, so see if the prefix is acceptable.
1425         my $prefix = $absolute;
1426         substr($prefix, -length($file)) = '';
1427
1428         ##print "prefix<$prefix>\n";
1429         if ($prefix ne ".../") {
1430                 WARN("USE_RELATIVE_PATH",
1431                      "use relative pathname instead of absolute in changelog text\n" . $herecurr);
1432         }
1433 }
1434
1435 sub trim {
1436         my ($string) = @_;
1437
1438         $string =~ s/(^\s+|\s+$)//g;
1439
1440         return $string;
1441 }
1442
1443 sub tabify {
1444         my ($leading) = @_;
1445
1446         my $source_indent = 8;
1447         my $max_spaces_before_tab = $source_indent - 1;
1448         my $spaces_to_tab = " " x $source_indent;
1449
1450         #convert leading spaces to tabs
1451         1 while $leading =~ s@^([\t]*)$spaces_to_tab@$1\t@g;
1452         #Remove spaces before a tab
1453         1 while $leading =~ s@^([\t]*)( {1,$max_spaces_before_tab})\t@$1\t@g;
1454
1455         return "$leading";
1456 }
1457
1458 sub pos_last_openparen {
1459         my ($line) = @_;
1460
1461         my $pos = 0;
1462
1463         my $opens = $line =~ tr/\(/\(/;
1464         my $closes = $line =~ tr/\)/\)/;
1465
1466         my $last_openparen = 0;
1467
1468         if (($opens == 0) || ($closes >= $opens)) {
1469                 return -1;
1470         }
1471
1472         my $len = length($line);
1473
1474         for ($pos = 0; $pos < $len; $pos++) {
1475                 my $string = substr($line, $pos);
1476                 if ($string =~ /^($FuncArg|$balanced_parens)/) {
1477                         $pos += length($1) - 1;
1478                 } elsif (substr($line, $pos, 1) eq '(') {
1479                         $last_openparen = $pos;
1480                 } elsif (index($string, '(') == -1) {
1481                         last;
1482                 }
1483         }
1484
1485         return $last_openparen + 1;
1486 }
1487
1488 sub process {
1489         my $filename = shift;
1490
1491         my $linenr=0;
1492         my $prevline="";
1493         my $prevrawline="";
1494         my $stashline="";
1495         my $stashrawline="";
1496
1497         my $length;
1498         my $indent;
1499         my $previndent=0;
1500         my $stashindent=0;
1501
1502         our $clean = 1;
1503         my $signoff = 0;
1504         my $is_patch = 0;
1505
1506         my $in_header_lines = 1;
1507         my $in_commit_log = 0;          #Scanning lines before patch
1508
1509         my $non_utf8_charset = 0;
1510
1511         our @report = ();
1512         our $cnt_lines = 0;
1513         our $cnt_error = 0;
1514         our $cnt_warn = 0;
1515         our $cnt_chk = 0;
1516
1517         # Trace the real file/line as we go.
1518         my $realfile = '';
1519         my $realline = 0;
1520         my $realcnt = 0;
1521         my $here = '';
1522         my $in_comment = 0;
1523         my $comment_edge = 0;
1524         my $first_line = 0;
1525         my $p1_prefix = '';
1526
1527         my $prev_values = 'E';
1528
1529         # suppression flags
1530         my %suppress_ifbraces;
1531         my %suppress_whiletrailers;
1532         my %suppress_export;
1533         my $suppress_statement = 0;
1534
1535
1536         # Pre-scan the patch sanitizing the lines.
1537         # Pre-scan the patch looking for any __setup documentation.
1538         #
1539         my @setup_docs = ();
1540         my $setup_docs = 0;
1541
1542         sanitise_line_reset();
1543         my $line;
1544         foreach my $rawline (@rawlines) {
1545                 $linenr++;
1546                 $line = $rawline;
1547
1548                 push(@fixed, $rawline) if ($fix);
1549
1550                 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1551                         $setup_docs = 0;
1552                         if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1553                                 $setup_docs = 1;
1554                         }
1555                         #next;
1556                 }
1557                 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1558                         $realline=$1-1;
1559                         if (defined $2) {
1560                                 $realcnt=$3+1;
1561                         } else {
1562                                 $realcnt=1+1;
1563                         }
1564                         $in_comment = 0;
1565
1566                         # Guestimate if this is a continuing comment.  Run
1567                         # the context looking for a comment "edge".  If this
1568                         # edge is a close comment then we must be in a comment
1569                         # at context start.
1570                         my $edge;
1571                         my $cnt = $realcnt;
1572                         for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1573                                 next if (defined $rawlines[$ln - 1] &&
1574                                          $rawlines[$ln - 1] =~ /^-/);
1575                                 $cnt--;
1576                                 #print "RAW<$rawlines[$ln - 1]>\n";
1577                                 last if (!defined $rawlines[$ln - 1]);
1578                                 if ($rawlines[$ln - 1] =~ m@(/\*|\*/)@ &&
1579                                     $rawlines[$ln - 1] !~ m@"[^"]*(?:/\*|\*/)[^"]*"@) {
1580                                         ($edge) = $1;
1581                                         last;
1582                                 }
1583                         }
1584                         if (defined $edge && $edge eq '*/') {
1585                                 $in_comment = 1;
1586                         }
1587
1588                         # Guestimate if this is a continuing comment.  If this
1589                         # is the start of a diff block and this line starts
1590                         # ' *' then it is very likely a comment.
1591                         if (!defined $edge &&
1592                             $rawlines[$linenr] =~ m@^.\s*(?:\*\*+| \*)(?:\s|$)@)
1593                         {
1594                                 $in_comment = 1;
1595                         }
1596
1597                         ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1598                         sanitise_line_reset($in_comment);
1599
1600                 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1601                         # Standardise the strings and chars within the input to
1602                         # simplify matching -- only bother with positive lines.
1603                         $line = sanitise_line($rawline);
1604                 }
1605                 push(@lines, $line);
1606
1607                 if ($realcnt > 1) {
1608                         $realcnt-- if ($line =~ /^(?:\+| |$)/);
1609                 } else {
1610                         $realcnt = 0;
1611                 }
1612
1613                 #print "==>$rawline\n";
1614                 #print "-->$line\n";
1615
1616                 if ($setup_docs && $line =~ /^\+/) {
1617                         push(@setup_docs, $line);
1618                 }
1619         }
1620
1621         $prefix = '';
1622
1623         $realcnt = 0;
1624         $linenr = 0;
1625         foreach my $line (@lines) {
1626                 $linenr++;
1627
1628                 my $rawline = $rawlines[$linenr - 1];
1629
1630 #extract the line range in the file after the patch is applied
1631                 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1632                         $is_patch = 1;
1633                         $first_line = $linenr + 1;
1634                         $realline=$1-1;
1635                         if (defined $2) {
1636                                 $realcnt=$3+1;
1637                         } else {
1638                                 $realcnt=1+1;
1639                         }
1640                         annotate_reset();
1641                         $prev_values = 'E';
1642
1643                         %suppress_ifbraces = ();
1644                         %suppress_whiletrailers = ();
1645                         %suppress_export = ();
1646                         $suppress_statement = 0;
1647                         next;
1648
1649 # track the line number as we move through the hunk, note that
1650 # new versions of GNU diff omit the leading space on completely
1651 # blank context lines so we need to count that too.
1652                 } elsif ($line =~ /^( |\+|$)/) {
1653                         $realline++;
1654                         $realcnt-- if ($realcnt != 0);
1655
1656                         # Measure the line length and indent.
1657                         ($length, $indent) = line_stats($rawline);
1658
1659                         # Track the previous line.
1660                         ($prevline, $stashline) = ($stashline, $line);
1661                         ($previndent, $stashindent) = ($stashindent, $indent);
1662                         ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1663
1664                         #warn "line<$line>\n";
1665
1666                 } elsif ($realcnt == 1) {
1667                         $realcnt--;
1668                 }
1669
1670                 my $hunk_line = ($realcnt != 0);
1671
1672 #make up the handle for any error we report on this line
1673                 $prefix = "$filename:$realline: " if ($emacs && $file);
1674                 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1675
1676                 $here = "#$linenr: " if (!$file);
1677                 $here = "#$realline: " if ($file);
1678
1679                 # extract the filename as it passes
1680                 if ($line =~ /^diff --git.*?(\S+)$/) {
1681                         $realfile = $1;
1682                         $realfile =~ s@^([^/]*)/@@;
1683                         $in_commit_log = 0;
1684                 } elsif ($line =~ /^\+\+\+\s+(\S+)/) {
1685                         $realfile = $1;
1686                         $realfile =~ s@^([^/]*)/@@;
1687                         $in_commit_log = 0;
1688
1689                         $p1_prefix = $1;
1690                         if (!$file && $tree && $p1_prefix ne '' &&
1691                             -e "$root/$p1_prefix") {
1692                                 WARN("PATCH_PREFIX",
1693                                      "patch prefix '$p1_prefix' exists, appears to be a -p0 patch\n");
1694                         }
1695
1696                         if ($realfile =~ m@^include/asm/@) {
1697                                 ERROR("MODIFIED_INCLUDE_ASM",
1698                                       "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1699                         }
1700                         next;
1701                 }
1702
1703                 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1704
1705                 my $hereline = "$here\n$rawline\n";
1706                 my $herecurr = "$here\n$rawline\n";
1707                 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1708
1709                 $cnt_lines++ if ($realcnt != 0);
1710
1711 # Check for incorrect file permissions
1712                 if ($line =~ /^new (file )?mode.*[7531]\d{0,2}$/) {
1713                         my $permhere = $here . "FILE: $realfile\n";
1714                         if ($realfile !~ m@scripts/@ &&
1715                             $realfile !~ /\.(py|pl|awk|sh)$/) {
1716                                 ERROR("EXECUTE_PERMISSIONS",
1717                                       "do not set execute permissions for source files\n" . $permhere);
1718                         }
1719                 }
1720
1721 # Check the patch for a signoff:
1722                 if ($line =~ /^\s*signed-off-by:/i) {
1723                         $signoff++;
1724                         $in_commit_log = 0;
1725                 }
1726
1727 # Check signature styles
1728                 if (!$in_header_lines &&
1729                     $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
1730                         my $space_before = $1;
1731                         my $sign_off = $2;
1732                         my $space_after = $3;
1733                         my $email = $4;
1734                         my $ucfirst_sign_off = ucfirst(lc($sign_off));
1735
1736                         if ($sign_off !~ /$signature_tags/) {
1737                                 WARN("BAD_SIGN_OFF",
1738                                      "Non-standard signature: $sign_off\n" . $herecurr);
1739                         }
1740                         if (defined $space_before && $space_before ne "") {
1741                                 if (WARN("BAD_SIGN_OFF",
1742                                          "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr) &&
1743                                     $fix) {
1744                                         $fixed[$linenr - 1] =
1745                                             "$ucfirst_sign_off $email";
1746                                 }
1747                         }
1748                         if ($sign_off =~ /-by:$/i && $sign_off ne $ucfirst_sign_off) {
1749                                 if (WARN("BAD_SIGN_OFF",
1750                                          "'$ucfirst_sign_off' is the preferred signature form\n" . $herecurr) &&
1751                                     $fix) {
1752                                         $fixed[$linenr - 1] =
1753                                             "$ucfirst_sign_off $email";
1754                                 }
1755
1756                         }
1757                         if (!defined $space_after || $space_after ne " ") {
1758                                 if (WARN("BAD_SIGN_OFF",
1759                                          "Use a single space after $ucfirst_sign_off\n" . $herecurr) &&
1760                                     $fix) {
1761                                         $fixed[$linenr - 1] =
1762                                             "$ucfirst_sign_off $email";
1763                                 }
1764                         }
1765
1766                         my ($email_name, $email_address, $comment) = parse_email($email);
1767                         my $suggested_email = format_email(($email_name, $email_address));
1768                         if ($suggested_email eq "") {
1769                                 ERROR("BAD_SIGN_OFF",
1770                                       "Unrecognized email address: '$email'\n" . $herecurr);
1771                         } else {
1772                                 my $dequoted = $suggested_email;
1773                                 $dequoted =~ s/^"//;
1774                                 $dequoted =~ s/" </ </;
1775                                 # Don't force email to have quotes
1776                                 # Allow just an angle bracketed address
1777                                 if ("$dequoted$comment" ne $email &&
1778                                     "<$email_address>$comment" ne $email &&
1779                                     "$suggested_email$comment" ne $email) {
1780                                         WARN("BAD_SIGN_OFF",
1781                                              "email address '$email' might be better as '$suggested_email$comment'\n" . $herecurr);
1782                                 }
1783                         }
1784                 }
1785
1786 # Check for wrappage within a valid hunk of the file
1787                 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1788                         ERROR("CORRUPTED_PATCH",
1789                               "patch seems to be corrupt (line wrapped?)\n" .
1790                                 $herecurr) if (!$emitted_corrupt++);
1791                 }
1792
1793 # Check for absolute kernel paths.
1794                 if ($tree) {
1795                         while ($line =~ m{(?:^|\s)(/\S*)}g) {
1796                                 my $file = $1;
1797
1798                                 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1799                                     check_absolute_file($1, $herecurr)) {
1800                                         #
1801                                 } else {
1802                                         check_absolute_file($file, $herecurr);
1803                                 }
1804                         }
1805                 }
1806
1807 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1808                 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1809                     $rawline !~ m/^$UTF8*$/) {
1810                         my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1811
1812                         my $blank = copy_spacing($rawline);
1813                         my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1814                         my $hereptr = "$hereline$ptr\n";
1815
1816                         CHK("INVALID_UTF8",
1817                             "Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1818                 }
1819
1820 # Check if it's the start of a commit log
1821 # (not a header line and we haven't seen the patch filename)
1822                 if ($in_header_lines && $realfile =~ /^$/ &&
1823                     $rawline !~ /^(commit\b|from\b|[\w-]+:).+$/i) {
1824                         $in_header_lines = 0;
1825                         $in_commit_log = 1;
1826                 }
1827
1828 # Check if there is UTF-8 in a commit log when a mail header has explicitly
1829 # declined it, i.e defined some charset where it is missing.
1830                 if ($in_header_lines &&
1831                     $rawline =~ /^Content-Type:.+charset="(.+)".*$/ &&
1832                     $1 !~ /utf-8/i) {
1833                         $non_utf8_charset = 1;
1834                 }
1835
1836                 if ($in_commit_log && $non_utf8_charset && $realfile =~ /^$/ &&
1837                     $rawline =~ /$NON_ASCII_UTF8/) {
1838                         WARN("UTF8_BEFORE_PATCH",
1839                             "8-bit UTF-8 used in possible commit log\n" . $herecurr);
1840                 }
1841
1842 # ignore non-hunk lines and lines being removed
1843                 next if (!$hunk_line || $line =~ /^-/);
1844
1845 #trailing whitespace
1846                 if ($line =~ /^\+.*\015/) {
1847                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1848                         if (ERROR("DOS_LINE_ENDINGS",
1849                                   "DOS line endings\n" . $herevet) &&
1850                             $fix) {
1851                                 $fixed[$linenr - 1] =~ s/[\s\015]+$//;
1852                         }
1853                 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1854                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1855                         if (ERROR("TRAILING_WHITESPACE",
1856                                   "trailing whitespace\n" . $herevet) &&
1857                             $fix) {
1858                                 $fixed[$linenr - 1] =~ s/\s+$//;
1859                         }
1860
1861                         $rpt_cleaners = 1;
1862                 }
1863
1864 # check for Kconfig help text having a real description
1865 # Only applies when adding the entry originally, after that we do not have
1866 # sufficient context to determine whether it is indeed long enough.
1867                 if ($realfile =~ /Kconfig/ &&
1868                     $line =~ /.\s*config\s+/) {
1869                         my $length = 0;
1870                         my $cnt = $realcnt;
1871                         my $ln = $linenr + 1;
1872                         my $f;
1873                         my $is_start = 0;
1874                         my $is_end = 0;
1875                         for (; $cnt > 0 && defined $lines[$ln - 1]; $ln++) {
1876                                 $f = $lines[$ln - 1];
1877                                 $cnt-- if ($lines[$ln - 1] !~ /^-/);
1878                                 $is_end = $lines[$ln - 1] =~ /^\+/;
1879
1880                                 next if ($f =~ /^-/);
1881
1882                                 if ($lines[$ln - 1] =~ /.\s*(?:bool|tristate)\s*\"/) {
1883                                         $is_start = 1;
1884                                 } elsif ($lines[$ln - 1] =~ /.\s*(?:---)?help(?:---)?$/) {
1885                                         $length = -1;
1886                                 }
1887
1888                                 $f =~ s/^.//;
1889                                 $f =~ s/#.*//;
1890                                 $f =~ s/^\s+//;
1891                                 next if ($f =~ /^$/);
1892                                 if ($f =~ /^\s*config\s/) {
1893                                         $is_end = 1;
1894                                         last;
1895                                 }
1896                                 $length++;
1897                         }
1898                         WARN("CONFIG_DESCRIPTION",
1899                              "please write a paragraph that describes the config symbol fully\n" . $herecurr) if ($is_start && $is_end && $length < 4);
1900                         #print "is_start<$is_start> is_end<$is_end> length<$length>\n";
1901                 }
1902
1903 # discourage the addition of CONFIG_EXPERIMENTAL in Kconfig.
1904                 if ($realfile =~ /Kconfig/ &&
1905                     $line =~ /.\s*depends on\s+.*\bEXPERIMENTAL\b/) {
1906                         WARN("CONFIG_EXPERIMENTAL",
1907                              "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
1908                 }
1909
1910                 if (($realfile =~ /Makefile.*/ || $realfile =~ /Kbuild.*/) &&
1911                     ($line =~ /\+(EXTRA_[A-Z]+FLAGS).*/)) {
1912                         my $flag = $1;
1913                         my $replacement = {
1914                                 'EXTRA_AFLAGS' =>   'asflags-y',
1915                                 'EXTRA_CFLAGS' =>   'ccflags-y',
1916                                 'EXTRA_CPPFLAGS' => 'cppflags-y',
1917                                 'EXTRA_LDFLAGS' =>  'ldflags-y',
1918                         };
1919
1920                         WARN("DEPRECATED_VARIABLE",
1921                              "Use of $flag is deprecated, please use \`$replacement->{$flag} instead.\n" . $herecurr) if ($replacement->{$flag});
1922                 }
1923
1924 # check we are in a valid source file if not then ignore this hunk
1925                 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1926
1927 #line length limit
1928                 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1929                     $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1930                     !($line =~ /^\+\s*$logFunctions\s*\(\s*(?:(KERN_\S+\s*|[^"]*))?"[X\t]*"\s*(?:|,|\)\s*;)\s*$/ ||
1931                     $line =~ /^\+\s*"[^"]*"\s*(?:\s*|,|\)\s*;)\s*$/) &&
1932                     $length > $max_line_length)
1933                 {
1934                         WARN("LONG_LINE",
1935                              "line over $max_line_length characters\n" . $herecurr);
1936                 }
1937
1938 # Check for user-visible strings broken across lines, which breaks the ability
1939 # to grep for the string.  Limited to strings used as parameters (those
1940 # following an open parenthesis), which almost completely eliminates false
1941 # positives, as well as warning only once per parameter rather than once per
1942 # line of the string.  Make an exception when the previous string ends in a
1943 # newline (multiple lines in one string constant) or \n\t (common in inline
1944 # assembly to indent the instruction on the following line).
1945                 if ($line =~ /^\+\s*"/ &&
1946                     $prevline =~ /"\s*$/ &&
1947                     $prevline =~ /\(/ &&
1948                     $prevrawline !~ /\\n(?:\\t)*"\s*$/) {
1949                         WARN("SPLIT_STRING",
1950                              "quoted string split across lines\n" . $hereprev);
1951                 }
1952
1953 # check for spaces before a quoted newline
1954                 if ($rawline =~ /^.*\".*\s\\n/) {
1955                         if (WARN("QUOTED_WHITESPACE_BEFORE_NEWLINE",
1956                                  "unnecessary whitespace before a quoted newline\n" . $herecurr) &&
1957                             $fix) {
1958                                 $fixed[$linenr - 1] =~ s/^(\+.*\".*)\s+\\n/$1\\n/;
1959                         }
1960
1961                 }
1962
1963 # check for adding lines without a newline.
1964                 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1965                         WARN("MISSING_EOF_NEWLINE",
1966                              "adding a line without newline at end of file\n" . $herecurr);
1967                 }
1968
1969 # Blackfin: use hi/lo macros
1970                 if ($realfile =~ m@arch/blackfin/.*\.S$@) {
1971                         if ($line =~ /\.[lL][[:space:]]*=.*&[[:space:]]*0x[fF][fF][fF][fF]/) {
1972                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1973                                 ERROR("LO_MACRO",
1974                                       "use the LO() macro, not (... & 0xFFFF)\n" . $herevet);
1975                         }
1976                         if ($line =~ /\.[hH][[:space:]]*=.*>>[[:space:]]*16/) {
1977                                 my $herevet = "$here\n" . cat_vet($line) . "\n";
1978                                 ERROR("HI_MACRO",
1979                                       "use the HI() macro, not (... >> 16)\n" . $herevet);
1980                         }
1981                 }
1982
1983 # check we are in a valid source file C or perl if not then ignore this hunk
1984                 next if ($realfile !~ /\.(h|c|pl)$/);
1985
1986 # at the beginning of a line any tabs must come first and anything
1987 # more than 8 must use tabs.
1988                 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1989                     $rawline =~ /^\+\s*        \s*/) {
1990                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1991                         $rpt_cleaners = 1;
1992                         if (ERROR("CODE_INDENT",
1993                                   "code indent should use tabs where possible\n" . $herevet) &&
1994                             $fix) {
1995                                 $fixed[$linenr - 1] =~ s/^\+([ \t]+)/"\+" . tabify($1)/e;
1996                         }
1997                 }
1998
1999 # check for space before tabs.
2000                 if ($rawline =~ /^\+/ && $rawline =~ / \t/) {
2001                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2002                         if (WARN("SPACE_BEFORE_TAB",
2003                                 "please, no space before tabs\n" . $herevet) &&
2004                             $fix) {
2005                                 $fixed[$linenr - 1] =~
2006                                     s/(^\+.*) +\t/$1\t/;
2007                         }
2008                 }
2009
2010 # check for && or || at the start of a line
2011                 if ($rawline =~ /^\+\s*(&&|\|\|)/) {
2012                         CHK("LOGICAL_CONTINUATIONS",
2013                             "Logical continuations should be on the previous line\n" . $hereprev);
2014                 }
2015
2016 # check multi-line statement indentation matches previous line
2017                 if ($^V && $^V ge 5.10.0 &&
2018                     $prevline =~ /^\+(\t*)(if \(|$Ident\().*(\&\&|\|\||,)\s*$/) {
2019                         $prevline =~ /^\+(\t*)(.*)$/;
2020                         my $oldindent = $1;
2021                         my $rest = $2;
2022
2023                         my $pos = pos_last_openparen($rest);
2024                         if ($pos >= 0) {
2025                                 $line =~ /^(\+| )([ \t]*)/;
2026                                 my $newindent = $2;
2027
2028                                 my $goodtabindent = $oldindent .
2029                                         "\t" x ($pos / 8) .
2030                                         " "  x ($pos % 8);
2031                                 my $goodspaceindent = $oldindent . " "  x $pos;
2032
2033                                 if ($newindent ne $goodtabindent &&
2034                                     $newindent ne $goodspaceindent) {
2035
2036                                         if (CHK("PARENTHESIS_ALIGNMENT",
2037                                                 "Alignment should match open parenthesis\n" . $hereprev) &&
2038                                             $fix && $line =~ /^\+/) {
2039                                                 $fixed[$linenr - 1] =~
2040                                                     s/^\+[ \t]*/\+$goodtabindent/;
2041                                         }
2042                                 }
2043                         }
2044                 }
2045
2046                 if ($line =~ /^\+.*\*[ \t]*\)[ \t]+(?!$Assignment|$Arithmetic)/) {
2047                         if (CHK("SPACING",
2048                                 "No space is necessary after a cast\n" . $hereprev) &&
2049                             $fix) {
2050                                 $fixed[$linenr - 1] =~
2051                                     s/^(\+.*\*[ \t]*\))[ \t]+/$1/;
2052                         }
2053                 }
2054
2055                 if ($realfile =~ m@^(drivers/net/|net/)@ &&
2056                     $prevrawline =~ /^\+[ \t]*\/\*[ \t]*$/ &&
2057                     $rawline =~ /^\+[ \t]*\*/) {
2058                         WARN("NETWORKING_BLOCK_COMMENT_STYLE",
2059                              "networking block comments don't use an empty /* line, use /* Comment...\n" . $hereprev);
2060                 }
2061
2062                 if ($realfile =~ m@^(drivers/net/|net/)@ &&
2063                     $prevrawline =~ /^\+[ \t]*\/\*/ &&          #starting /*
2064                     $prevrawline !~ /\*\/[ \t]*$/ &&            #no trailing */
2065                     $rawline !~ /^\+[ \t]*\*/) {                #no leading *
2066                         WARN("NETWORKING_BLOCK_COMMENT_STYLE",
2067                              "networking block comments start with * on subsequent lines\n" . $hereprev);
2068                 }
2069
2070                 if ($realfile =~ m@^(drivers/net/|net/)@ &&
2071                     $rawline !~ m@^\+[ \t]*\*/[ \t]*$@ &&       #trailing */
2072                     $rawline !~ m@^\+.*/\*.*\*/[ \t]*$@ &&      #inline /*...*/
2073                     $rawline !~ m@^\+.*\*{2,}/[ \t]*$@ &&       #trailing **/
2074                     $rawline =~ m@^\+[ \t]*.+\*\/[ \t]*$@) {    #non blank */
2075                         WARN("NETWORKING_BLOCK_COMMENT_STYLE",
2076                              "networking block comments put the trailing */ on a separate line\n" . $herecurr);
2077                 }
2078
2079 # check for spaces at the beginning of a line.
2080 # Exceptions:
2081 #  1) within comments
2082 #  2) indented preprocessor commands
2083 #  3) hanging labels
2084                 if ($rawline =~ /^\+ / && $line !~ /^\+ *(?:$;|#|$Ident:)/)  {
2085                         my $herevet = "$here\n" . cat_vet($rawline) . "\n";
2086                         if (WARN("LEADING_SPACE",
2087                                  "please, no spaces at the start of a line\n" . $herevet) &&
2088                             $fix) {
2089                                 $fixed[$linenr - 1] =~ s/^\+([ \t]+)/"\+" . tabify($1)/e;
2090                         }
2091                 }
2092
2093 # check we are in a valid C source file if not then ignore this hunk
2094                 next if ($realfile !~ /\.(h|c)$/);
2095
2096 # discourage the addition of CONFIG_EXPERIMENTAL in #if(def).
2097                 if ($line =~ /^\+\s*\#\s*if.*\bCONFIG_EXPERIMENTAL\b/) {
2098                         WARN("CONFIG_EXPERIMENTAL",
2099                              "Use of CONFIG_EXPERIMENTAL is deprecated. For alternatives, see https://lkml.org/lkml/2012/10/23/580\n");
2100                 }
2101
2102 # check for RCS/CVS revision markers
2103                 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
2104                         WARN("CVS_KEYWORD",
2105                              "CVS style keyword markers, these will _not_ be updated\n". $herecurr);
2106                 }
2107
2108 # Blackfin: don't use __builtin_bfin_[cs]sync
2109                 if ($line =~ /__builtin_bfin_csync/) {
2110                         my $herevet = "$here\n" . cat_vet($line) . "\n";
2111                         ERROR("CSYNC",
2112                               "use the CSYNC() macro in asm/blackfin.h\n" . $herevet);
2113                 }
2114                 if ($line =~ /__builtin_bfin_ssync/) {
2115                         my $herevet = "$here\n" . cat_vet($line) . "\n";
2116                         ERROR("SSYNC",
2117                               "use the SSYNC() macro in asm/blackfin.h\n" . $herevet);
2118                 }
2119
2120 # check for old HOTPLUG __dev<foo> section markings
2121                 if ($line =~ /\b(__dev(init|exit)(data|const|))\b/) {
2122                         WARN("HOTPLUG_SECTION",
2123                              "Using $1 is unnecessary\n" . $herecurr);
2124                 }
2125
2126 # Check for potential 'bare' types
2127                 my ($stat, $cond, $line_nr_next, $remain_next, $off_next,
2128                     $realline_next);
2129 #print "LINE<$line>\n";
2130                 if ($linenr >= $suppress_statement &&
2131                     $realcnt && $line =~ /.\s*\S/) {
2132                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2133                                 ctx_statement_block($linenr, $realcnt, 0);
2134                         $stat =~ s/\n./\n /g;
2135                         $cond =~ s/\n./\n /g;
2136
2137 #print "linenr<$linenr> <$stat>\n";
2138                         # If this statement has no statement boundaries within
2139                         # it there is no point in retrying a statement scan
2140                         # until we hit end of it.
2141                         my $frag = $stat; $frag =~ s/;+\s*$//;
2142                         if ($frag !~ /(?:{|;)/) {
2143 #print "skip<$line_nr_next>\n";
2144                                 $suppress_statement = $line_nr_next;
2145                         }
2146
2147                         # Find the real next line.
2148                         $realline_next = $line_nr_next;
2149                         if (defined $realline_next &&
2150                             (!defined $lines[$realline_next - 1] ||
2151                              substr($lines[$realline_next - 1], $off_next) =~ /^\s*$/)) {
2152                                 $realline_next++;
2153                         }
2154
2155                         my $s = $stat;
2156                         $s =~ s/{.*$//s;
2157
2158                         # Ignore goto labels.
2159                         if ($s =~ /$Ident:\*$/s) {
2160
2161                         # Ignore functions being called
2162                         } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
2163
2164                         } elsif ($s =~ /^.\s*else\b/s) {
2165
2166                         # declarations always start with types
2167                         } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
2168                                 my $type = $1;
2169                                 $type =~ s/\s+/ /g;
2170                                 possible($type, "A:" . $s);
2171
2172                         # definitions in global scope can only start with types
2173                         } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b\s*(?!:)/s) {
2174                                 possible($1, "B:" . $s);
2175                         }
2176
2177                         # any (foo ... *) is a pointer cast, and foo is a type
2178                         while ($s =~ /\(($Ident)(?:\s+$Sparse)*[\s\*]+\s*\)/sg) {
2179                                 possible($1, "C:" . $s);
2180                         }
2181
2182                         # Check for any sort of function declaration.
2183                         # int foo(something bar, other baz);
2184                         # void (*store_gdt)(x86_descr_ptr *);
2185                         if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
2186                                 my ($name_len) = length($1);
2187
2188                                 my $ctx = $s;
2189                                 substr($ctx, 0, $name_len + 1, '');
2190                                 $ctx =~ s/\)[^\)]*$//;
2191
2192                                 for my $arg (split(/\s*,\s*/, $ctx)) {
2193                                         if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
2194
2195                                                 possible($1, "D:" . $s);
2196                                         }
2197                                 }
2198                         }
2199
2200                 }
2201
2202 #
2203 # Checks which may be anchored in the context.
2204 #
2205
2206 # Check for switch () and associated case and default
2207 # statements should be at the same indent.
2208                 if ($line=~/\bswitch\s*\(.*\)/) {
2209                         my $err = '';
2210                         my $sep = '';
2211                         my @ctx = ctx_block_outer($linenr, $realcnt);
2212                         shift(@ctx);
2213                         for my $ctx (@ctx) {
2214                                 my ($clen, $cindent) = line_stats($ctx);
2215                                 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
2216                                                         $indent != $cindent) {
2217                                         $err .= "$sep$ctx\n";
2218                                         $sep = '';
2219                                 } else {
2220                                         $sep = "[...]\n";
2221                                 }
2222                         }
2223                         if ($err ne '') {
2224                                 ERROR("SWITCH_CASE_INDENT_LEVEL",
2225                                       "switch and case should be at the same indent\n$hereline$err");
2226                         }
2227                 }
2228
2229 # if/while/etc brace do not go on next line, unless defining a do while loop,
2230 # or if that brace on the next line is for something else
2231                 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
2232                         my $pre_ctx = "$1$2";
2233
2234                         my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
2235
2236                         if ($line =~ /^\+\t{6,}/) {
2237                                 WARN("DEEP_INDENTATION",
2238                                      "Too many leading tabs - consider code refactoring\n" . $herecurr);
2239                         }
2240
2241                         my $ctx_cnt = $realcnt - $#ctx - 1;
2242                         my $ctx = join("\n", @ctx);
2243
2244                         my $ctx_ln = $linenr;
2245                         my $ctx_skip = $realcnt;
2246
2247                         while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
2248                                         defined $lines[$ctx_ln - 1] &&
2249                                         $lines[$ctx_ln - 1] =~ /^-/)) {
2250                                 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
2251                                 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
2252                                 $ctx_ln++;
2253                         }
2254
2255                         #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
2256                         #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
2257
2258                         if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
2259                                 ERROR("OPEN_BRACE",
2260                                       "that open brace { should be on the previous line\n" .
2261                                         "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2262                         }
2263                         if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
2264                             $ctx =~ /\)\s*\;\s*$/ &&
2265                             defined $lines[$ctx_ln - 1])
2266                         {
2267                                 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
2268                                 if ($nindent > $indent) {
2269                                         WARN("TRAILING_SEMICOLON",
2270                                              "trailing semicolon indicates no statements, indent implies otherwise\n" .
2271                                                 "$here\n$ctx\n$rawlines[$ctx_ln - 1]\n");
2272                                 }
2273                         }
2274                 }
2275
2276 # Check relative indent for conditionals and blocks.
2277                 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
2278                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
2279                                 ctx_statement_block($linenr, $realcnt, 0)
2280                                         if (!defined $stat);
2281                         my ($s, $c) = ($stat, $cond);
2282
2283                         substr($s, 0, length($c), '');
2284
2285                         # Make sure we remove the line prefixes as we have
2286                         # none on the first line, and are going to readd them
2287                         # where necessary.
2288                         $s =~ s/\n./\n/gs;
2289
2290                         # Find out how long the conditional actually is.
2291                         my @newlines = ($c =~ /\n/gs);
2292                         my $cond_lines = 1 + $#newlines;
2293
2294                         # We want to check the first line inside the block
2295                         # starting at the end of the conditional, so remove:
2296                         #  1) any blank line termination
2297                         #  2) any opening brace { on end of the line
2298                         #  3) any do (...) {
2299                         my $continuation = 0;
2300                         my $check = 0;
2301                         $s =~ s/^.*\bdo\b//;
2302                         $s =~ s/^\s*{//;
2303                         if ($s =~ s/^\s*\\//) {
2304                                 $continuation = 1;
2305                         }
2306                         if ($s =~ s/^\s*?\n//) {
2307                                 $check = 1;
2308                                 $cond_lines++;
2309                         }
2310
2311                         # Also ignore a loop construct at the end of a
2312                         # preprocessor statement.
2313                         if (($prevline =~ /^.\s*#\s*define\s/ ||
2314                             $prevline =~ /\\\s*$/) && $continuation == 0) {
2315                                 $check = 0;
2316                         }
2317
2318                         my $cond_ptr = -1;
2319                         $continuation = 0;
2320                         while ($cond_ptr != $cond_lines) {
2321                                 $cond_ptr = $cond_lines;
2322
2323                                 # If we see an #else/#elif then the code
2324                                 # is not linear.
2325                                 if ($s =~ /^\s*\#\s*(?:else|elif)/) {
2326                                         $check = 0;
2327                                 }
2328
2329                                 # Ignore:
2330                                 #  1) blank lines, they should be at 0,
2331                                 #  2) preprocessor lines, and
2332                                 #  3) labels.
2333                                 if ($continuation ||
2334                                     $s =~ /^\s*?\n/ ||
2335                                     $s =~ /^\s*#\s*?/ ||
2336                                     $s =~ /^\s*$Ident\s*:/) {
2337                                         $continuation = ($s =~ /^.*?\\\n/) ? 1 : 0;
2338                                         if ($s =~ s/^.*?\n//) {
2339                                                 $cond_lines++;
2340                                         }
2341                                 }
2342                         }
2343
2344                         my (undef, $sindent) = line_stats("+" . $s);
2345                         my $stat_real = raw_line($linenr, $cond_lines);
2346
2347                         # Check if either of these lines are modified, else
2348                         # this is not this patch's fault.
2349                         if (!defined($stat_real) ||
2350                             $stat !~ /^\+/ && $stat_real !~ /^\+/) {
2351                                 $check = 0;
2352                         }
2353                         if (defined($stat_real) && $cond_lines > 1) {
2354                                 $stat_real = "[...]\n$stat_real";
2355                         }
2356
2357                         #print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s> cond_lines<$cond_lines> stat_real<$stat_real> stat<$stat>\n";
2358
2359                         if ($check && (($sindent % 8) != 0 ||
2360                             ($sindent <= $indent && $s ne ''))) {
2361                                 WARN("SUSPECT_CODE_INDENT",
2362                                      "suspect code indent for conditional statements ($indent, $sindent)\n" . $herecurr . "$stat_real\n");
2363                         }
2364                 }
2365
2366                 # Track the 'values' across context and added lines.
2367                 my $opline = $line; $opline =~ s/^./ /;
2368                 my ($curr_values, $curr_vars) =
2369                                 annotate_values($opline . "\n", $prev_values);
2370                 $curr_values = $prev_values . $curr_values;
2371                 if ($dbg_values) {
2372                         my $outline = $opline; $outline =~ s/\t/ /g;
2373                         print "$linenr > .$outline\n";
2374                         print "$linenr > $curr_values\n";
2375                         print "$linenr >  $curr_vars\n";
2376                 }
2377                 $prev_values = substr($curr_values, -1);
2378
2379 #ignore lines not being added
2380                 next if ($line =~ /^[^\+]/);
2381
2382 # TEST: allow direct testing of the type matcher.
2383                 if ($dbg_type) {
2384                         if ($line =~ /^.\s*$Declare\s*$/) {
2385                                 ERROR("TEST_TYPE",
2386                                       "TEST: is type\n" . $herecurr);
2387                         } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
2388                                 ERROR("TEST_NOT_TYPE",
2389                                       "TEST: is not type ($1 is)\n". $herecurr);
2390                         }
2391                         next;
2392                 }
2393 # TEST: allow direct testing of the attribute matcher.
2394                 if ($dbg_attr) {
2395                         if ($line =~ /^.\s*$Modifier\s*$/) {
2396                                 ERROR("TEST_ATTR",
2397                                       "TEST: is attr\n" . $herecurr);
2398                         } elsif ($dbg_attr > 1 && $line =~ /^.+($Modifier)/) {
2399                                 ERROR("TEST_NOT_ATTR",
2400                                       "TEST: is not attr ($1 is)\n". $herecurr);
2401                         }
2402                         next;
2403                 }
2404
2405 # check for initialisation to aggregates open brace on the next line
2406                 if ($line =~ /^.\s*{/ &&
2407                     $prevline =~ /(?:^|[^=])=\s*$/) {
2408                         ERROR("OPEN_BRACE",
2409                               "that open brace { should be on the previous line\n" . $hereprev);
2410                 }
2411
2412 #
2413 # Checks which are anchored on the added line.
2414 #
2415
2416 # check for malformed paths in #include statements (uses RAW line)
2417                 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
2418                         my $path = $1;
2419                         if ($path =~ m{//}) {
2420                                 ERROR("MALFORMED_INCLUDE",
2421                                       "malformed #include filename\n" . $herecurr);
2422                         }
2423                         if ($path =~ "^uapi/" && $realfile =~ m@\binclude/uapi/@) {
2424                                 ERROR("UAPI_INCLUDE",
2425                                       "No #include in ...include/uapi/... should use a uapi/ path prefix\n" . $herecurr);
2426                         }
2427                 }
2428
2429 # no C99 // comments
2430                 if ($line =~ m{//}) {
2431                         if (ERROR("C99_COMMENTS",
2432                                   "do not use C99 // comments\n" . $herecurr) &&
2433                             $fix) {
2434                                 my $line = $fixed[$linenr - 1];
2435                                 if ($line =~ /\/\/(.*)$/) {
2436                                         my $comment = trim($1);
2437                                         $fixed[$linenr - 1] =~ s@\/\/(.*)$@/\* $comment \*/@;
2438                                 }
2439                         }
2440                 }
2441                 # Remove C99 comments.
2442                 $line =~ s@//.*@@;
2443                 $opline =~ s@//.*@@;
2444
2445 # EXPORT_SYMBOL should immediately follow the thing it is exporting, consider
2446 # the whole statement.
2447 #print "APW <$lines[$realline_next - 1]>\n";
2448                 if (defined $realline_next &&
2449                     exists $lines[$realline_next - 1] &&
2450                     !defined $suppress_export{$realline_next} &&
2451                     ($lines[$realline_next - 1] =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2452                      $lines[$realline_next - 1] =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2453                         # Handle definitions which produce identifiers with
2454                         # a prefix:
2455                         #   XXX(foo);
2456                         #   EXPORT_SYMBOL(something_foo);
2457                         my $name = $1;
2458                         if ($stat =~ /^(?:.\s*}\s*\n)?.([A-Z_]+)\s*\(\s*($Ident)/ &&
2459                             $name =~ /^${Ident}_$2/) {
2460 #print "FOO C name<$name>\n";
2461                                 $suppress_export{$realline_next} = 1;
2462
2463                         } elsif ($stat !~ /(?:
2464                                 \n.}\s*$|
2465                                 ^.DEFINE_$Ident\(\Q$name\E\)|
2466                                 ^.DECLARE_$Ident\(\Q$name\E\)|
2467                                 ^.LIST_HEAD\(\Q$name\E\)|
2468                                 ^.(?:$Storage\s+)?$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(|
2469                                 \b\Q$name\E(?:\s+$Attribute)*\s*(?:;|=|\[|\()
2470                             )/x) {
2471 #print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
2472                                 $suppress_export{$realline_next} = 2;
2473                         } else {
2474                                 $suppress_export{$realline_next} = 1;
2475                         }
2476                 }
2477                 if (!defined $suppress_export{$linenr} &&
2478                     $prevline =~ /^.\s*$/ &&
2479                     ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
2480                      $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
2481 #print "FOO B <$lines[$linenr - 1]>\n";
2482                         $suppress_export{$linenr} = 2;
2483                 }
2484                 if (defined $suppress_export{$linenr} &&
2485                     $suppress_export{$linenr} == 2) {
2486                         WARN("EXPORT_SYMBOL",
2487                              "EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
2488                 }
2489
2490 # check for global initialisers.
2491                 if ($line =~ /^\+(\s*$Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL|false)\s*;/) {
2492                         if (ERROR("GLOBAL_INITIALISERS",
2493                                   "do not initialise globals to 0 or NULL\n" .
2494                                       $herecurr) &&
2495                             $fix) {
2496                                 $fixed[$linenr - 1] =~ s/($Type\s*$Ident\s*(?:\s+$Modifier))*\s*=\s*(0|NULL|false)\s*;/$1;/;
2497                         }
2498                 }
2499 # check for static initialisers.
2500                 if ($line =~ /^\+.*\bstatic\s.*=\s*(0|NULL|false)\s*;/) {
2501                         if (ERROR("INITIALISED_STATIC",
2502                                   "do not initialise statics to 0 or NULL\n" .
2503                                       $herecurr) &&
2504                             $fix) {
2505                                 $fixed[$linenr - 1] =~ s/(\bstatic\s.*?)\s*=\s*(0|NULL|false)\s*;/$1;/;
2506                         }
2507                 }
2508
2509 # check for static const char * arrays.
2510                 if ($line =~ /\bstatic\s+const\s+char\s*\*\s*(\w+)\s*\[\s*\]\s*=\s*/) {
2511                         WARN("STATIC_CONST_CHAR_ARRAY",
2512                              "static const char * array should probably be static const char * const\n" .
2513                                 $herecurr);
2514                }
2515
2516 # check for static char foo[] = "bar" declarations.
2517                 if ($line =~ /\bstatic\s+char\s+(\w+)\s*\[\s*\]\s*=\s*"/) {
2518                         WARN("STATIC_CONST_CHAR_ARRAY",
2519                              "static char array declaration should probably be static const char\n" .
2520                                 $herecurr);
2521                }
2522
2523 # check for declarations of struct pci_device_id
2524                 if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) {
2525                         WARN("DEFINE_PCI_DEVICE_TABLE",
2526                              "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr);
2527                 }
2528
2529 # check for new typedefs, only function parameters and sparse annotations
2530 # make sense.
2531                 if ($line =~ /\btypedef\s/ &&
2532                     $line !~ /\btypedef\s+$Type\s*\(\s*\*?$Ident\s*\)\s*\(/ &&
2533                     $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
2534                     $line !~ /\b$typeTypedefs\b/ &&
2535                     $line !~ /\b__bitwise(?:__|)\b/) {
2536                         WARN("NEW_TYPEDEFS",
2537                              "do not add new typedefs\n" . $herecurr);
2538                 }
2539
2540 # * goes on variable not on type
2541                 # (char*[ const])
2542                 while ($line =~ m{(\($NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)\))}g) {
2543                         #print "AA<$1>\n";
2544                         my ($ident, $from, $to) = ($1, $2, $2);
2545
2546                         # Should start with a space.
2547                         $to =~ s/^(\S)/ $1/;
2548                         # Should not end with a space.
2549                         $to =~ s/\s+$//;
2550                         # '*'s should not have spaces between.
2551                         while ($to =~ s/\*\s+\*/\*\*/) {
2552                         }
2553
2554 ##                      print "1: from<$from> to<$to> ident<$ident>\n";
2555                         if ($from ne $to) {
2556                                 if (ERROR("POINTER_LOCATION",
2557                                           "\"(foo$from)\" should be \"(foo$to)\"\n" .  $herecurr) &&
2558                                     $fix) {
2559                                         my $sub_from = $ident;
2560                                         my $sub_to = $ident;
2561                                         $sub_to =~ s/\Q$from\E/$to/;
2562                                         $fixed[$linenr - 1] =~
2563                                             s@\Q$sub_from\E@$sub_to@;
2564                                 }
2565                         }
2566                 }
2567                 while ($line =~ m{(\b$NonptrType(\s*(?:$Modifier\b\s*|\*\s*)+)($Ident))}g) {
2568                         #print "BB<$1>\n";
2569                         my ($match, $from, $to, $ident) = ($1, $2, $2, $3);
2570
2571                         # Should start with a space.
2572                         $to =~ s/^(\S)/ $1/;
2573                         # Should not end with a space.
2574                         $to =~ s/\s+$//;
2575                         # '*'s should not have spaces between.
2576                         while ($to =~ s/\*\s+\*/\*\*/) {
2577                         }
2578                         # Modifiers should have spaces.
2579                         $to =~ s/(\b$Modifier$)/$1 /;
2580
2581 ##                      print "2: from<$from> to<$to> ident<$ident>\n";
2582                         if ($from ne $to && $ident !~ /^$Modifier$/) {
2583                                 if (ERROR("POINTER_LOCATION",
2584                                           "\"foo${from}bar\" should be \"foo${to}bar\"\n" .  $herecurr) &&
2585                                     $fix) {
2586
2587                                         my $sub_from = $match;
2588                                         my $sub_to = $match;
2589                                         $sub_to =~ s/\Q$from\E/$to/;
2590                                         $fixed[$linenr - 1] =~
2591                                             s@\Q$sub_from\E@$sub_to@;
2592                                 }
2593                         }
2594                 }
2595
2596 # # no BUG() or BUG_ON()
2597 #               if ($line =~ /\b(BUG|BUG_ON)\b/) {
2598 #                       print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
2599 #                       print "$herecurr";
2600 #                       $clean = 0;
2601 #               }
2602
2603                 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
2604                         WARN("LINUX_VERSION_CODE",
2605                              "LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
2606                 }
2607
2608 # check for uses of printk_ratelimit
2609                 if ($line =~ /\bprintk_ratelimit\s*\(/) {
2610                         WARN("PRINTK_RATELIMITED",
2611 "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
2612                 }
2613
2614 # printk should use KERN_* levels.  Note that follow on printk's on the
2615 # same line do not need a level, so we use the current block context
2616 # to try and find and validate the current printk.  In summary the current
2617 # printk includes all preceding printk's which have no newline on the end.
2618 # we assume the first bad printk is the one to report.
2619                 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
2620                         my $ok = 0;
2621                         for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
2622                                 #print "CHECK<$lines[$ln - 1]\n";
2623                                 # we have a preceding printk if it ends
2624                                 # with "\n" ignore it, else it is to blame
2625                                 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
2626                                         if ($rawlines[$ln - 1] !~ m{\\n"}) {
2627                                                 $ok = 1;
2628                                         }
2629                                         last;
2630                                 }
2631                         }
2632                         if ($ok == 0) {
2633                                 WARN("PRINTK_WITHOUT_KERN_LEVEL",
2634                                      "printk() should include KERN_ facility level\n" . $herecurr);
2635                         }
2636                 }
2637
2638                 if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) {
2639                         my $orig = $1;
2640                         my $level = lc($orig);
2641                         $level = "warn" if ($level eq "warning");
2642                         my $level2 = $level;
2643                         $level2 = "dbg" if ($level eq "debug");
2644                         WARN("PREFER_PR_LEVEL",
2645                              "Prefer netdev_$level2(netdev, ... then dev_$level2(dev, ... then pr_$level(...  to printk(KERN_$orig ...\n" . $herecurr);
2646                 }
2647
2648                 if ($line =~ /\bpr_warning\s*\(/) {
2649                         if (WARN("PREFER_PR_LEVEL",
2650                                  "Prefer pr_warn(... to pr_warning(...\n" . $herecurr) &&
2651                             $fix) {
2652                                 $fixed[$linenr - 1] =~
2653                                     s/\bpr_warning\b/pr_warn/;
2654                         }
2655                 }
2656
2657                 if ($line =~ /\bdev_printk\s*\(\s*KERN_([A-Z]+)/) {
2658                         my $orig = $1;
2659                         my $level = lc($orig);
2660                         $level = "warn" if ($level eq "warning");
2661                         $level = "dbg" if ($level eq "debug");
2662                         WARN("PREFER_DEV_LEVEL",
2663                              "Prefer dev_$level(... to dev_printk(KERN_$orig, ...\n" . $herecurr);
2664                 }
2665
2666 # function brace can't be on same line, except for #defines of do while,
2667 # or if closed on same line
2668                 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
2669                     !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
2670                         ERROR("OPEN_BRACE",
2671                               "open brace '{' following function declarations go on the next line\n" . $herecurr);
2672                 }
2673
2674 # open braces for enum, union and struct go on the same line.
2675                 if ($line =~ /^.\s*{/ &&
2676                     $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
2677                         ERROR("OPEN_BRACE",
2678                               "open brace '{' following $1 go on the same line\n" . $hereprev);
2679                 }
2680
2681 # missing space after union, struct or enum definition
2682                 if ($line =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident){1,2}[=\{]/) {
2683                         if (WARN("SPACING",
2684                                  "missing space after $1 definition\n" . $herecurr) &&
2685                             $fix) {
2686                                 $fixed[$linenr - 1] =~
2687                                     s/^(.\s*(?:typedef\s+)?(?:enum|union|struct)(?:\s+$Ident){1,2})([=\{])/$1 $2/;
2688                         }
2689                 }
2690
2691 # check for spacing round square brackets; allowed:
2692 #  1. with a type on the left -- int [] a;
2693 #  2. at the beginning of a line for slice initialisers -- [0...10] = 5,
2694 #  3. inside a curly brace -- = { [0...10] = 5 }
2695                 while ($line =~ /(.*?\s)\[/g) {
2696                         my ($where, $prefix) = ($-[1], $1);
2697                         if ($prefix !~ /$Type\s+$/ &&
2698                             ($where != 0 || $prefix !~ /^.\s+$/) &&
2699                             $prefix !~ /[{,]\s+$/) {
2700                                 if (ERROR("BRACKET_SPACE",
2701                                           "space prohibited before open square bracket '['\n" . $herecurr) &&
2702                                     $fix) {
2703                                     $fixed[$linenr - 1] =~
2704                                         s/^(\+.*?)\s+\[/$1\[/;
2705                                 }
2706                         }
2707                 }
2708
2709 # check for spaces between functions and their parentheses.
2710                 while ($line =~ /($Ident)\s+\(/g) {
2711                         my $name = $1;
2712                         my $ctx_before = substr($line, 0, $-[1]);
2713                         my $ctx = "$ctx_before$name";
2714
2715                         # Ignore those directives where spaces _are_ permitted.
2716                         if ($name =~ /^(?:
2717                                 if|for|while|switch|return|case|
2718                                 volatile|__volatile__|
2719                                 __attribute__|format|__extension__|
2720                                 asm|__asm__)$/x)
2721                         {
2722                         # cpp #define statements have non-optional spaces, ie
2723                         # if there is a space between the name and the open
2724                         # parenthesis it is simply not a parameter group.
2725                         } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
2726
2727                         # cpp #elif statement condition may start with a (
2728                         } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
2729
2730                         # If this whole things ends with a type its most
2731                         # likely a typedef for a function.
2732                         } elsif ($ctx =~ /$Type$/) {
2733
2734                         } else {
2735                                 if (WARN("SPACING",
2736                                          "space prohibited between function name and open parenthesis '('\n" . $herecurr) &&
2737                                              $fix) {
2738                                         $fixed[$linenr - 1] =~
2739                                             s/\b$name\s+\(/$name\(/;
2740                                 }
2741                         }
2742                 }
2743
2744 # Check operator spacing.
2745                 if (!($line=~/\#\s*include/)) {
2746                         my $fixed_line = "";
2747                         my $line_fixed = 0;
2748
2749                         my $ops = qr{
2750                                 <<=|>>=|<=|>=|==|!=|
2751                                 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
2752                                 =>|->|<<|>>|<|>|=|!|~|
2753                                 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
2754                                 \?|:
2755                         }x;
2756                         my @elements = split(/($ops|;)/, $opline);
2757
2758 ##                      print("element count: <" . $#elements . ">\n");
2759 ##                      foreach my $el (@elements) {
2760 ##                              print("el: <$el>\n");
2761 ##                      }
2762
2763                         my @fix_elements = ();
2764                         my $off = 0;
2765
2766                         foreach my $el (@elements) {
2767                                 push(@fix_elements, substr($rawline, $off, length($el)));
2768                                 $off += length($el);
2769                         }
2770
2771                         $off = 0;
2772
2773                         my $blank = copy_spacing($opline);
2774
2775                         for (my $n = 0; $n < $#elements; $n += 2) {
2776
2777                                 my $good = $fix_elements[$n] . $fix_elements[$n + 1];
2778
2779 ##                              print("n: <$n> good: <$good>\n");
2780
2781                                 $off += length($elements[$n]);
2782
2783                                 # Pick up the preceding and succeeding characters.
2784                                 my $ca = substr($opline, 0, $off);
2785                                 my $cc = '';
2786                                 if (length($opline) >= ($off + length($elements[$n + 1]))) {
2787                                         $cc = substr($opline, $off + length($elements[$n + 1]));
2788                                 }
2789                                 my $cb = "$ca$;$cc";
2790
2791                                 my $a = '';
2792                                 $a = 'V' if ($elements[$n] ne '');
2793                                 $a = 'W' if ($elements[$n] =~ /\s$/);
2794                                 $a = 'C' if ($elements[$n] =~ /$;$/);
2795                                 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
2796                                 $a = 'O' if ($elements[$n] eq '');
2797                                 $a = 'E' if ($ca =~ /^\s*$/);
2798
2799                                 my $op = $elements[$n + 1];
2800
2801                                 my $c = '';
2802                                 if (defined $elements[$n + 2]) {
2803                                         $c = 'V' if ($elements[$n + 2] ne '');
2804                                         $c = 'W' if ($elements[$n + 2] =~ /^\s/);
2805                                         $c = 'C' if ($elements[$n + 2] =~ /^$;/);
2806                                         $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
2807                                         $c = 'O' if ($elements[$n + 2] eq '');
2808                                         $c = 'E' if ($elements[$n + 2] =~ /^\s*\\$/);
2809                                 } else {
2810                                         $c = 'E';
2811                                 }
2812
2813                                 my $ctx = "${a}x${c}";
2814
2815                                 my $at = "(ctx:$ctx)";
2816
2817                                 my $ptr = substr($blank, 0, $off) . "^";
2818                                 my $hereptr = "$hereline$ptr\n";
2819
2820                                 # Pull out the value of this operator.
2821                                 my $op_type = substr($curr_values, $off + 1, 1);
2822
2823                                 # Get the full operator variant.
2824                                 my $opv = $op . substr($curr_vars, $off, 1);
2825
2826                                 # Ignore operators passed as parameters.
2827                                 if ($op_type ne 'V' &&
2828                                     $ca =~ /\s$/ && $cc =~ /^\s*,/) {
2829
2830 #                               # Ignore comments
2831 #                               } elsif ($op =~ /^$;+$/) {
2832
2833                                 # ; should have either the end of line or a space or \ after it
2834                                 } elsif ($op eq ';') {
2835                                         if ($ctx !~ /.x[WEBC]/ &&
2836                                             $cc !~ /^\\/ && $cc !~ /^;/) {
2837                                                 if (ERROR("SPACING",
2838                                                           "space required after that '$op' $at\n" . $hereptr)) {
2839                                                         $good = trim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
2840                                                         $line_fixed = 1;
2841                                                 }
2842                                         }
2843
2844                                 # // is a comment
2845                                 } elsif ($op eq '//') {
2846
2847                                 # No spaces for:
2848                                 #   ->
2849                                 #   :   when part of a bitfield
2850                                 } elsif ($op eq '->' || $opv eq ':B') {
2851                                         if ($ctx =~ /Wx.|.xW/) {
2852                                                 if (ERROR("SPACING",
2853                                                           "spaces prohibited around that '$op' $at\n" . $hereptr)) {
2854                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
2855                                                         $line_fixed = 1;
2856                                                         if (defined $fix_elements[$n + 2]) {
2857                                                                 $fix_elements[$n + 2] =~ s/^\s+//;
2858                                                         }
2859                                                 }
2860                                         }
2861
2862                                 # , must have a space on the right.
2863                                 } elsif ($op eq ',') {
2864                                         if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
2865                                                 if (ERROR("SPACING",
2866                                                           "space required after that '$op' $at\n" . $hereptr)) {
2867                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]) . " ";
2868                                                         $line_fixed = 1;
2869                                                 }
2870                                         }
2871
2872                                 # '*' as part of a type definition -- reported already.
2873                                 } elsif ($opv eq '*_') {
2874                                         #warn "'*' is part of type\n";
2875
2876                                 # unary operators should have a space before and
2877                                 # none after.  May be left adjacent to another
2878                                 # unary operator, or a cast
2879                                 } elsif ($op eq '!' || $op eq '~' ||
2880                                          $opv eq '*U' || $opv eq '-U' ||
2881                                          $opv eq '&U' || $opv eq '&&U') {
2882                                         if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
2883                                                 if (ERROR("SPACING",
2884                                                           "space required before that '$op' $at\n" . $hereptr)) {
2885                                                         $good = trim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]);
2886                                                         $line_fixed = 1;
2887                                                 }
2888                                         }
2889                                         if ($op eq '*' && $cc =~/\s*$Modifier\b/) {
2890                                                 # A unary '*' may be const
2891
2892                                         } elsif ($ctx =~ /.xW/) {
2893                                                 if (ERROR("SPACING",
2894                                                           "space prohibited after that '$op' $at\n" . $hereptr)) {
2895                                                         $fixed_line =~ s/\s+$//;
2896                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
2897                                                         $line_fixed = 1;
2898                                                         if (defined $fix_elements[$n + 2]) {
2899                                                                 $fix_elements[$n + 2] =~ s/^\s+//;
2900                                                         }
2901                                                 }
2902                                         }
2903
2904                                 # unary ++ and unary -- are allowed no space on one side.
2905                                 } elsif ($op eq '++' or $op eq '--') {
2906                                         if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
2907                                                 if (ERROR("SPACING",
2908                                                           "space required one side of that '$op' $at\n" . $hereptr)) {
2909                                                         $fixed_line =~ s/\s+$//;
2910                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]) . " ";
2911                                                         $line_fixed = 1;
2912                                                 }
2913                                         }
2914                                         if ($ctx =~ /Wx[BE]/ ||
2915                                             ($ctx =~ /Wx./ && $cc =~ /^;/)) {
2916                                                 if (ERROR("SPACING",
2917                                                           "space prohibited before that '$op' $at\n" . $hereptr)) {
2918                                                         $fixed_line =~ s/\s+$//;
2919                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
2920                                                         $line_fixed = 1;
2921                                                 }
2922                                         }
2923                                         if ($ctx =~ /ExW/) {
2924                                                 if (ERROR("SPACING",
2925                                                           "space prohibited after that '$op' $at\n" . $hereptr)) {
2926                                                         $fixed_line =~ s/\s+$//;
2927                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
2928                                                         $line_fixed = 1;
2929                                                         if (defined $fix_elements[$n + 2]) {
2930                                                                 $fix_elements[$n + 2] =~ s/^\s+//;
2931                                                         }
2932                                                 }
2933                                         }
2934
2935                                 # << and >> may either have or not have spaces both sides
2936                                 } elsif ($op eq '<<' or $op eq '>>' or
2937                                          $op eq '&' or $op eq '^' or $op eq '|' or
2938                                          $op eq '+' or $op eq '-' or
2939                                          $op eq '*' or $op eq '/' or
2940                                          $op eq '%')
2941                                 {
2942                                         if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
2943                                                 if (ERROR("SPACING",
2944                                                           "need consistent spacing around '$op' $at\n" . $hereptr)) {
2945                                                         $fixed_line =~ s/\s+$//;
2946                                                         $good = trim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
2947                                                         $line_fixed = 1;
2948                                                 }
2949                                         }
2950
2951                                 # A colon needs no spaces before when it is
2952                                 # terminating a case value or a label.
2953                                 } elsif ($opv eq ':C' || $opv eq ':L') {
2954                                         if ($ctx =~ /Wx./) {
2955                                                 if (ERROR("SPACING",
2956                                                           "space prohibited before that '$op' $at\n" . $hereptr)) {
2957                                                         $good = trim($fix_elements[$n]) . trim($fix_elements[$n + 1]);
2958                                                         $line_fixed = 1;
2959                                                 }
2960                                         }
2961
2962                                 # All the others need spaces both sides.
2963                                 } elsif ($ctx !~ /[EWC]x[CWE]/) {
2964                                         my $ok = 0;
2965
2966                                         # Ignore email addresses <foo@bar>
2967                                         if (($op eq '<' &&
2968                                              $cc =~ /^\S+\@\S+>/) ||
2969                                             ($op eq '>' &&
2970                                              $ca =~ /<\S+\@\S+$/))
2971                                         {
2972                                                 $ok = 1;
2973                                         }
2974
2975                                         # Ignore ?:
2976                                         if (($opv eq ':O' && $ca =~ /\?$/) ||
2977                                             ($op eq '?' && $cc =~ /^:/)) {
2978                                                 $ok = 1;
2979                                         }
2980
2981                                         if ($ok == 0) {
2982                                                 if (ERROR("SPACING",
2983                                                           "spaces required around that '$op' $at\n" . $hereptr)) {
2984                                                         $good = trim($fix_elements[$n]) . " " . trim($fix_elements[$n + 1]) . " ";
2985                                                         $good = $fix_elements[$n] . " " . trim($fix_elements[$n + 1]) . " ";
2986                                                         $line_fixed = 1;
2987                                                 }
2988                                         }
2989                                 }
2990                                 $off += length($elements[$n + 1]);
2991
2992 ##                              print("n: <$n> GOOD: <$good>\n");
2993
2994                                 $fixed_line = $fixed_line . $good;
2995                         }
2996
2997                         if (($#elements % 2) == 0) {
2998                                 $fixed_line = $fixed_line . $fix_elements[$#elements];
2999                         }
3000
3001                         if ($fix && $line_fixed && $fixed_line ne $fixed[$linenr - 1]) {
3002                                 $fixed[$linenr - 1] = $fixed_line;
3003                         }
3004
3005
3006                 }
3007
3008 # check for whitespace before a non-naked semicolon
3009                 if ($line =~ /^\+.*\S\s+;/) {
3010                         if (WARN("SPACING",
3011                                  "space prohibited before semicolon\n" . $herecurr) &&
3012                             $fix) {
3013                                 1 while $fixed[$linenr - 1] =~
3014                                     s/^(\+.*\S)\s+;/$1;/;
3015                         }
3016                 }
3017
3018 # check for multiple assignments
3019                 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
3020                         CHK("MULTIPLE_ASSIGNMENTS",
3021                             "multiple assignments should be avoided\n" . $herecurr);
3022                 }
3023
3024 ## # check for multiple declarations, allowing for a function declaration
3025 ## # continuation.
3026 ##              if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
3027 ##                  $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
3028 ##
3029 ##                      # Remove any bracketed sections to ensure we do not
3030 ##                      # falsly report the parameters of functions.
3031 ##                      my $ln = $line;
3032 ##                      while ($ln =~ s/\([^\(\)]*\)//g) {
3033 ##                      }
3034 ##                      if ($ln =~ /,/) {
3035 ##                              WARN("MULTIPLE_DECLARATION",
3036 ##                                   "declaring multiple variables together should be avoided\n" . $herecurr);
3037 ##                      }
3038 ##              }
3039
3040 #need space before brace following if, while, etc
3041                 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
3042                     $line =~ /do{/) {
3043                         if (ERROR("SPACING",
3044                                   "space required before the open brace '{'\n" . $herecurr) &&
3045                             $fix) {
3046                                 $fixed[$linenr - 1] =~ s/^(\+.*(?:do|\))){/$1 {/;
3047                         }
3048                 }
3049
3050 ## # check for blank lines before declarations
3051 ##              if ($line =~ /^.\t+$Type\s+$Ident(?:\s*=.*)?;/ &&
3052 ##                  $prevrawline =~ /^.\s*$/) {
3053 ##                      WARN("SPACING",
3054 ##                           "No blank lines before declarations\n" . $hereprev);
3055 ##              }
3056 ##
3057
3058 # closing brace should have a space following it when it has anything
3059 # on the line
3060                 if ($line =~ /}(?!(?:,|;|\)))\S/) {
3061                         if (ERROR("SPACING",
3062                                   "space required after that close brace '}'\n" . $herecurr) &&
3063                             $fix) {
3064                                 $fixed[$linenr - 1] =~
3065                                     s/}((?!(?:,|;|\)))\S)/} $1/;
3066                         }
3067                 }
3068
3069 # check spacing on square brackets
3070                 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
3071                         if (ERROR("SPACING",
3072                                   "space prohibited after that open square bracket '['\n" . $herecurr) &&
3073                             $fix) {
3074                                 $fixed[$linenr - 1] =~
3075                                     s/\[\s+/\[/;
3076                         }
3077                 }
3078                 if ($line =~ /\s\]/) {
3079                         if (ERROR("SPACING",
3080                                   "space prohibited before that close square bracket ']'\n" . $herecurr) &&
3081                             $fix) {
3082                                 $fixed[$linenr - 1] =~
3083                                     s/\s+\]/\]/;
3084                         }
3085                 }
3086
3087 # check spacing on parentheses
3088                 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
3089                     $line !~ /for\s*\(\s+;/) {
3090                         if (ERROR("SPACING",
3091                                   "space prohibited after that open parenthesis '('\n" . $herecurr) &&
3092                             $fix) {
3093                                 $fixed[$linenr - 1] =~
3094                                     s/\(\s+/\(/;
3095                         }
3096                 }
3097                 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
3098                     $line !~ /for\s*\(.*;\s+\)/ &&
3099                     $line !~ /:\s+\)/) {
3100                         if (ERROR("SPACING",
3101                                   "space prohibited before that close parenthesis ')'\n" . $herecurr) &&
3102                             $fix) {
3103                                 $fixed[$linenr - 1] =~
3104                                     s/\s+\)/\)/;
3105                         }
3106                 }
3107
3108 #goto labels aren't indented, allow a single space however
3109                 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
3110                    !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
3111                         if (WARN("INDENTED_LABEL",
3112                                  "labels should not be indented\n" . $herecurr) &&
3113                             $fix) {
3114                                 $fixed[$linenr - 1] =~
3115                                     s/^(.)\s+/$1/;
3116                         }
3117                 }
3118
3119 # Return is not a function.
3120                 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
3121                         my $spacing = $1;
3122                         my $value = $2;
3123
3124                         # Flatten any parentheses
3125                         $value =~ s/\(/ \(/g;
3126                         $value =~ s/\)/\) /g;
3127                         while ($value =~ s/\[[^\[\]]*\]/1/ ||
3128                                $value !~ /(?:$Ident|-?$Constant)\s*
3129                                              $Compare\s*
3130                                              (?:$Ident|-?$Constant)/x &&
3131                                $value =~ s/\([^\(\)]*\)/1/) {
3132                         }
3133 #print "value<$value>\n";
3134                         if ($value =~ /^\s*(?:$Ident|-?$Constant)\s*$/) {
3135                                 ERROR("RETURN_PARENTHESES",
3136                                       "return is not a function, parentheses are not required\n" . $herecurr);
3137
3138                         } elsif ($spacing !~ /\s+/) {
3139                                 ERROR("SPACING",
3140                                       "space required before the open parenthesis '('\n" . $herecurr);
3141                         }
3142                 }
3143 # Return of what appears to be an errno should normally be -'ve
3144                 if ($line =~ /^.\s*return\s*(E[A-Z]*)\s*;/) {
3145                         my $name = $1;
3146                         if ($name ne 'EOF' && $name ne 'ERROR') {
3147                                 WARN("USE_NEGATIVE_ERRNO",
3148                                      "return of an errno should typically be -ve (return -$1)\n" . $herecurr);
3149                         }
3150                 }
3151
3152 # Need a space before open parenthesis after if, while etc
3153                 if ($line =~ /\b(if|while|for|switch)\(/) {
3154                         if (ERROR("SPACING",
3155                                   "space required before the open parenthesis '('\n" . $herecurr) &&
3156                             $fix) {
3157                                 $fixed[$linenr - 1] =~
3158                                     s/\b(if|while|for|switch)\(/$1 \(/;
3159                         }
3160                 }
3161
3162 # Check for illegal assignment in if conditional -- and check for trailing
3163 # statements after the conditional.
3164                 if ($line =~ /do\s*(?!{)/) {
3165                         ($stat, $cond, $line_nr_next, $remain_next, $off_next) =
3166                                 ctx_statement_block($linenr, $realcnt, 0)
3167                                         if (!defined $stat);
3168                         my ($stat_next) = ctx_statement_block($line_nr_next,
3169                                                 $remain_next, $off_next);
3170                         $stat_next =~ s/\n./\n /g;
3171                         ##print "stat<$stat> stat_next<$stat_next>\n";
3172
3173                         if ($stat_next =~ /^\s*while\b/) {
3174                                 # If the statement carries leading newlines,
3175                                 # then count those as offsets.
3176                                 my ($whitespace) =
3177                                         ($stat_next =~ /^((?:\s*\n[+-])*\s*)/s);
3178                                 my $offset =
3179                                         statement_rawlines($whitespace) - 1;
3180
3181                                 $suppress_whiletrailers{$line_nr_next +
3182                                                                 $offset} = 1;
3183                         }
3184                 }
3185                 if (!defined $suppress_whiletrailers{$linenr} &&
3186                     $line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
3187                         my ($s, $c) = ($stat, $cond);
3188
3189                         if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/s) {
3190                                 ERROR("ASSIGN_IN_IF",
3191                                       "do not use assignment in if condition\n" . $herecurr);
3192                         }
3193
3194                         # Find out what is on the end of the line after the
3195                         # conditional.
3196                         substr($s, 0, length($c), '');
3197                         $s =~ s/\n.*//g;
3198                         $s =~ s/$;//g;  # Remove any comments
3199                         if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
3200                             $c !~ /}\s*while\s*/)
3201                         {
3202                                 # Find out how long the conditional actually is.
3203                                 my @newlines = ($c =~ /\n/gs);
3204                                 my $cond_lines = 1 + $#newlines;
3205                                 my $stat_real = '';
3206
3207                                 $stat_real = raw_line($linenr, $cond_lines)
3208                                                         . "\n" if ($cond_lines);
3209                                 if (defined($stat_real) && $cond_lines > 1) {
3210                                         $stat_real = "[...]\n$stat_real";
3211                                 }
3212
3213                                 ERROR("TRAILING_STATEMENTS",
3214                                       "trailing statements should be on next line\n" . $herecurr . $stat_real);
3215                         }
3216                 }
3217
3218 # Check for bitwise tests written as boolean
3219                 if ($line =~ /
3220                         (?:
3221                                 (?:\[|\(|\&\&|\|\|)
3222                                 \s*0[xX][0-9]+\s*
3223                                 (?:\&\&|\|\|)
3224                         |
3225                                 (?:\&\&|\|\|)
3226                                 \s*0[xX][0-9]+\s*
3227                                 (?:\&\&|\|\||\)|\])
3228                         )/x)
3229                 {
3230                         WARN("HEXADECIMAL_BOOLEAN_TEST",
3231                              "boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
3232                 }
3233
3234 # if and else should not have general statements after it
3235                 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
3236                         my $s = $1;
3237                         $s =~ s/$;//g;  # Remove any comments
3238                         if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
3239                                 ERROR("TRAILING_STATEMENTS",
3240                                       "trailing statements should be on next line\n" . $herecurr);
3241                         }
3242                 }
3243 # if should not continue a brace
3244                 if ($line =~ /}\s*if\b/) {
3245                         ERROR("TRAILING_STATEMENTS",
3246                               "trailing statements should be on next line\n" .
3247                                 $herecurr);
3248                 }
3249 # case and default should not have general statements after them
3250                 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
3251                     $line !~ /\G(?:
3252                         (?:\s*$;*)(?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
3253                         \s*return\s+
3254                     )/xg)
3255                 {
3256                         ERROR("TRAILING_STATEMENTS",
3257                               "trailing statements should be on next line\n" . $herecurr);
3258                 }
3259
3260                 # Check for }<nl>else {, these must be at the same
3261                 # indent level to be relevant to each other.
3262                 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
3263                                                 $previndent == $indent) {
3264                         ERROR("ELSE_AFTER_BRACE",
3265                               "else should follow close brace '}'\n" . $hereprev);
3266                 }
3267
3268                 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
3269                                                 $previndent == $indent) {
3270                         my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
3271
3272                         # Find out what is on the end of the line after the
3273                         # conditional.
3274                         substr($s, 0, length($c), '');
3275                         $s =~ s/\n.*//g;
3276
3277                         if ($s =~ /^\s*;/) {
3278                                 ERROR("WHILE_AFTER_BRACE",
3279                                       "while should follow close brace '}'\n" . $hereprev);
3280                         }
3281                 }
3282
3283 #Specific variable tests
3284                 while ($line =~ m{($Constant|$Lval)}g) {
3285                         my $var = $1;
3286
3287 #gcc binary extension
3288                         if ($var =~ /^$Binary$/) {
3289                                 if (WARN("GCC_BINARY_CONSTANT",
3290                                          "Avoid gcc v4.3+ binary constant extension: <$var>\n" . $herecurr) &&
3291                                     $fix) {
3292                                         my $hexval = sprintf("0x%x", oct($var));
3293                                         $fixed[$linenr - 1] =~
3294                                             s/\b$var\b/$hexval/;
3295                                 }
3296                         }
3297
3298 #CamelCase
3299                         if ($var !~ /^$Constant$/ &&
3300                             $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
3301 #Ignore Page<foo> variants
3302                             $var !~ /^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
3303 #Ignore SI style variants like nS, mV and dB (ie: max_uV, regulator_min_uA_show)
3304                             $var !~ /^(?:[a-z_]*?)_?[a-z][A-Z](?:_[a-z_]+)?$/) {
3305                                 while ($var =~ m{($Ident)}g) {
3306                                         my $word = $1;
3307                                         next if ($word !~ /[A-Z][a-z]|[a-z][A-Z]/);
3308                                         seed_camelcase_includes() if ($check);
3309                                         if (!defined $camelcase{$word}) {
3310                                                 $camelcase{$word} = 1;
3311                                                 CHK("CAMELCASE",
3312                                                     "Avoid CamelCase: <$word>\n" . $herecurr);
3313                                         }
3314                                 }
3315                         }
3316                 }
3317
3318 #no spaces allowed after \ in define
3319                 if ($line =~ /\#\s*define.*\\\s+$/) {
3320                         if (WARN("WHITESPACE_AFTER_LINE_CONTINUATION",
3321                                  "Whitespace after \\ makes next lines useless\n" . $herecurr) &&
3322                             $fix) {
3323                                 $fixed[$linenr - 1] =~ s/\s+$//;
3324                         }
3325                 }
3326
3327 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
3328                 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
3329                         my $file = "$1.h";
3330                         my $checkfile = "include/linux/$file";
3331                         if (-f "$root/$checkfile" &&
3332                             $realfile ne $checkfile &&
3333                             $1 !~ /$allowed_asm_includes/)
3334                         {
3335                                 if ($realfile =~ m{^arch/}) {
3336                                         CHK("ARCH_INCLUDE_LINUX",
3337                                             "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
3338                                 } else {
3339                                         WARN("INCLUDE_LINUX",
3340                                              "Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
3341                                 }
3342                         }
3343                 }
3344
3345 # multi-statement macros should be enclosed in a do while loop, grab the
3346 # first statement and ensure its the whole macro if its not enclosed
3347 # in a known good container
3348                 if ($realfile !~ m@/vmlinux.lds.h$@ &&
3349                     $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
3350                         my $ln = $linenr;
3351                         my $cnt = $realcnt;
3352                         my ($off, $dstat, $dcond, $rest);
3353                         my $ctx = '';
3354                         ($dstat, $dcond, $ln, $cnt, $off) =
3355                                 ctx_statement_block($linenr, $realcnt, 0);
3356                         $ctx = $dstat;
3357                         #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
3358                         #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
3359
3360                         $dstat =~ s/^.\s*\#\s*define\s+$Ident(?:\([^\)]*\))?\s*//;
3361                         $dstat =~ s/$;//g;
3362                         $dstat =~ s/\\\n.//g;
3363                         $dstat =~ s/^\s*//s;
3364                         $dstat =~ s/\s*$//s;
3365
3366                         # Flatten any parentheses and braces
3367                         while ($dstat =~ s/\([^\(\)]*\)/1/ ||
3368                                $dstat =~ s/\{[^\{\}]*\}/1/ ||
3369                                $dstat =~ s/\[[^\[\]]*\]/1/)
3370                         {
3371                         }
3372
3373                         # Flatten any obvious string concatentation.
3374                         while ($dstat =~ s/("X*")\s*$Ident/$1/ ||
3375                                $dstat =~ s/$Ident\s*("X*")/$1/)
3376                         {
3377                         }
3378
3379                         my $exceptions = qr{
3380                                 $Declare|
3381                                 module_param_named|
3382                                 MODULE_PARM_DESC|
3383                                 DECLARE_PER_CPU|
3384                                 DEFINE_PER_CPU|
3385                                 __typeof__\(|
3386                                 union|
3387                                 struct|
3388                                 \.$Ident\s*=\s*|
3389                                 ^\"|\"$
3390                         }x;
3391                         #print "REST<$rest> dstat<$dstat> ctx<$ctx>\n";
3392                         if ($dstat ne '' &&
3393                             $dstat !~ /^(?:$Ident|-?$Constant),$/ &&                    # 10, // foo(),
3394                             $dstat !~ /^(?:$Ident|-?$Constant);$/ &&                    # foo();
3395                             $dstat !~ /^[!~-]?(?:$Lval|$Constant)$/ &&          # 10 // foo() // !foo // ~foo // -foo // foo->bar // foo.bar->baz
3396                             $dstat !~ /^'X'$/ &&                                        # character constants
3397                             $dstat !~ /$exceptions/ &&
3398                             $dstat !~ /^\.$Ident\s*=/ &&                                # .foo =
3399                             $dstat !~ /^(?:\#\s*$Ident|\#\s*$Constant)\s*$/ &&          # stringification #foo
3400                             $dstat !~ /^do\s*$Constant\s*while\s*$Constant;?$/ &&       # do {...} while (...); // do {...} while (...)
3401                             $dstat !~ /^for\s*$Constant$/ &&                            # for (...)
3402                             $dstat !~ /^for\s*$Constant\s+(?:$Ident|-?$Constant)$/ &&   # for (...) bar()
3403                             $dstat !~ /^do\s*{/ &&                                      # do {...
3404                             $dstat !~ /^\({/)                                           # ({...
3405                         {
3406                                 $ctx =~ s/\n*$//;
3407                                 my $herectx = $here . "\n";
3408                                 my $cnt = statement_rawlines($ctx);
3409
3410                                 for (my $n = 0; $n < $cnt; $n++) {
3411                                         $herectx .= raw_line($linenr, $n) . "\n";
3412                                 }
3413
3414                                 if ($dstat =~ /;/) {
3415                                         ERROR("MULTISTATEMENT_MACRO_USE_DO_WHILE",
3416                                               "Macros with multiple statements should be enclosed in a do - while loop\n" . "$herectx");
3417                                 } else {
3418                                         ERROR("COMPLEX_MACRO",
3419                                               "Macros with complex values should be enclosed in parenthesis\n" . "$herectx");
3420                                 }
3421                         }
3422
3423 # check for line continuations outside of #defines, preprocessor #, and asm
3424
3425                 } else {
3426                         if ($prevline !~ /^..*\\$/ &&
3427                             $line !~ /^\+\s*\#.*\\$/ &&         # preprocessor
3428                             $line !~ /^\+.*\b(__asm__|asm)\b.*\\$/ &&   # asm
3429                             $line =~ /^\+.*\\$/) {
3430                                 WARN("LINE_CONTINUATIONS",
3431                                      "Avoid unnecessary line continuations\n" . $herecurr);
3432                         }
3433                 }
3434
3435 # do {} while (0) macro tests:
3436 # single-statement macros do not need to be enclosed in do while (0) loop,
3437 # macro should not end with a semicolon
3438                 if ($^V && $^V ge 5.10.0 &&
3439                     $realfile !~ m@/vmlinux.lds.h$@ &&
3440                     $line =~ /^.\s*\#\s*define\s+$Ident(\()?/) {
3441                         my $ln = $linenr;
3442                         my $cnt = $realcnt;
3443                         my ($off, $dstat, $dcond, $rest);
3444                         my $ctx = '';
3445                         ($dstat, $dcond, $ln, $cnt, $off) =
3446                                 ctx_statement_block($linenr, $realcnt, 0);
3447                         $ctx = $dstat;
3448
3449                         $dstat =~ s/\\\n.//g;
3450
3451                         if ($dstat =~ /^\+\s*#\s*define\s+$Ident\s*${balanced_parens}\s*do\s*{(.*)\s*}\s*while\s*\(\s*0\s*\)\s*([;\s]*)\s*$/) {
3452                                 my $stmts = $2;
3453                                 my $semis = $3;
3454
3455                                 $ctx =~ s/\n*$//;
3456                                 my $cnt = statement_rawlines($ctx);
3457                                 my $herectx = $here . "\n";
3458
3459                                 for (my $n = 0; $n < $cnt; $n++) {
3460                                         $herectx .= raw_line($linenr, $n) . "\n";
3461                                 }
3462
3463                                 if (($stmts =~ tr/;/;/) == 1 &&
3464                                     $stmts !~ /^\s*(if|while|for|switch)\b/) {
3465                                         WARN("SINGLE_STATEMENT_DO_WHILE_MACRO",
3466                                              "Single statement macros should not use a do {} while (0) loop\n" . "$herectx");
3467                                 }
3468                                 if (defined $semis && $semis ne "") {
3469                                         WARN("DO_WHILE_MACRO_WITH_TRAILING_SEMICOLON",
3470                                              "do {} while (0) macros should not be semicolon terminated\n" . "$herectx");
3471                                 }
3472                         }
3473                 }
3474
3475 # make sure symbols are always wrapped with VMLINUX_SYMBOL() ...
3476 # all assignments may have only one of the following with an assignment:
3477 #       .
3478 #       ALIGN(...)
3479 #       VMLINUX_SYMBOL(...)
3480                 if ($realfile eq 'vmlinux.lds.h' && $line =~ /(?:(?:^|\s)$Ident\s*=|=\s*$Ident(?:\s|$))/) {
3481                         WARN("MISSING_VMLINUX_SYMBOL",
3482                              "vmlinux.lds.h needs VMLINUX_SYMBOL() around C-visible symbols\n" . $herecurr);
3483                 }
3484
3485 # check for redundant bracing round if etc
3486                 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
3487                         my ($level, $endln, @chunks) =
3488                                 ctx_statement_full($linenr, $realcnt, 1);
3489                         #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
3490                         #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
3491                         if ($#chunks > 0 && $level == 0) {
3492                                 my @allowed = ();
3493                                 my $allow = 0;
3494                                 my $seen = 0;
3495                                 my $herectx = $here . "\n";
3496                                 my $ln = $linenr - 1;
3497                                 for my $chunk (@chunks) {
3498                                         my ($cond, $block) = @{$chunk};
3499
3500                                         # If the condition carries leading newlines, then count those as offsets.
3501                                         my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
3502                                         my $offset = statement_rawlines($whitespace) - 1;
3503
3504                                         $allowed[$allow] = 0;
3505                                         #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
3506
3507                                         # We have looked at and allowed this specific line.
3508                                         $suppress_ifbraces{$ln + $offset} = 1;
3509
3510                                         $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
3511                                         $ln += statement_rawlines($block) - 1;
3512
3513                                         substr($block, 0, length($cond), '');
3514
3515                                         $seen++ if ($block =~ /^\s*{/);
3516
3517                                         #print "cond<$cond> block<$block> allowed<$allowed[$allow]>\n";
3518                                         if (statement_lines($cond) > 1) {
3519                                                 #print "APW: ALLOWED: cond<$cond>\n";
3520                                                 $allowed[$allow] = 1;
3521                                         }
3522                                         if ($block =~/\b(?:if|for|while)\b/) {
3523                                                 #print "APW: ALLOWED: block<$block>\n";
3524                                                 $allowed[$allow] = 1;
3525                                         }
3526                                         if (statement_block_size($block) > 1) {
3527                                                 #print "APW: ALLOWED: lines block<$block>\n";
3528                                                 $allowed[$allow] = 1;
3529                                         }
3530                                         $allow++;
3531                                 }
3532                                 if ($seen) {
3533                                         my $sum_allowed = 0;
3534                                         foreach (@allowed) {
3535                                                 $sum_allowed += $_;
3536                                         }
3537                                         if ($sum_allowed == 0) {
3538                                                 WARN("BRACES",
3539                                                      "braces {} are not necessary for any arm of this statement\n" . $herectx);
3540                                         } elsif ($sum_allowed != $allow &&
3541                                                  $seen != $allow) {
3542                                                 CHK("BRACES",
3543                                                     "braces {} should be used on all arms of this statement\n" . $herectx);
3544                                         }
3545                                 }
3546                         }
3547                 }
3548                 if (!defined $suppress_ifbraces{$linenr - 1} &&
3549                                         $line =~ /\b(if|while|for|else)\b/) {
3550                         my $allowed = 0;
3551
3552                         # Check the pre-context.
3553                         if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
3554                                 #print "APW: ALLOWED: pre<$1>\n";
3555                                 $allowed = 1;
3556                         }
3557
3558                         my ($level, $endln, @chunks) =
3559                                 ctx_statement_full($linenr, $realcnt, $-[0]);
3560
3561                         # Check the condition.
3562                         my ($cond, $block) = @{$chunks[0]};
3563                         #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
3564                         if (defined $cond) {
3565                                 substr($block, 0, length($cond), '');
3566                         }
3567                         if (statement_lines($cond) > 1) {
3568                                 #print "APW: ALLOWED: cond<$cond>\n";
3569                                 $allowed = 1;
3570                         }
3571                         if ($block =~/\b(?:if|for|while)\b/) {
3572                                 #print "APW: ALLOWED: block<$block>\n";
3573                                 $allowed = 1;
3574                         }
3575                         if (statement_block_size($block) > 1) {
3576                                 #print "APW: ALLOWED: lines block<$block>\n";
3577                                 $allowed = 1;
3578                         }
3579                         # Check the post-context.
3580                         if (defined $chunks[1]) {
3581                                 my ($cond, $block) = @{$chunks[1]};
3582                                 if (defined $cond) {
3583                                         substr($block, 0, length($cond), '');
3584                                 }
3585                                 if ($block =~ /^\s*\{/) {
3586                                         #print "APW: ALLOWED: chunk-1 block<$block>\n";
3587                                         $allowed = 1;
3588                                 }
3589                         }
3590                         if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
3591                                 my $herectx = $here . "\n";
3592                                 my $cnt = statement_rawlines($block);
3593
3594                                 for (my $n = 0; $n < $cnt; $n++) {
3595                                         $herectx .= raw_line($linenr, $n) . "\n";
3596                                 }
3597
3598                                 WARN("BRACES",
3599                                      "braces {} are not necessary for single statement blocks\n" . $herectx);
3600                         }
3601                 }
3602
3603 # check for unnecessary blank lines around braces
3604                 if (($line =~ /^.\s*}\s*$/ && $prevrawline =~ /^.\s*$/)) {
3605                         CHK("BRACES",
3606                             "Blank lines aren't necessary before a close brace '}'\n" . $hereprev);
3607                 }
3608                 if (($rawline =~ /^.\s*$/ && $prevline =~ /^..*{\s*$/)) {
3609                         CHK("BRACES",
3610                             "Blank lines aren't necessary after an open brace '{'\n" . $hereprev);
3611                 }
3612
3613 # no volatiles please
3614                 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
3615                 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
3616                         WARN("VOLATILE",
3617                              "Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
3618                 }
3619
3620 # warn about #if 0
3621                 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
3622                         CHK("REDUNDANT_CODE",
3623                             "if this code is redundant consider removing it\n" .
3624                                 $herecurr);
3625                 }
3626
3627 # check for needless "if (<foo>) fn(<foo>)" uses
3628                 if ($prevline =~ /\bif\s*\(\s*($Lval)\s*\)/) {
3629                         my $expr = '\s*\(\s*' . quotemeta($1) . '\s*\)\s*;';
3630                         if ($line =~ /\b(kfree|usb_free_urb|debugfs_remove(?:_recursive)?)$expr/) {
3631                                 WARN('NEEDLESS_IF',
3632                                      "$1(NULL) is safe this check is probably not required\n" . $hereprev);
3633                         }
3634                 }
3635
3636 # prefer usleep_range over udelay
3637                 if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) {
3638                         # ignore udelay's < 10, however
3639                         if (! ($1 < 10) ) {
3640                                 CHK("USLEEP_RANGE",
3641                                     "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line);
3642                         }
3643                 }
3644
3645 # warn about unexpectedly long msleep's
3646                 if ($line =~ /\bmsleep\s*\((\d+)\);/) {
3647                         if ($1 < 20) {
3648                                 WARN("MSLEEP",
3649                                      "msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt\n" . $line);
3650                         }
3651                 }
3652
3653 # check for comparisons of jiffies
3654                 if ($line =~ /\bjiffies\s*$Compare|$Compare\s*jiffies\b/) {
3655                         WARN("JIFFIES_COMPARISON",
3656                              "Comparing jiffies is almost always wrong; prefer time_after, time_before and friends\n" . $herecurr);
3657                 }
3658
3659 # check for comparisons of get_jiffies_64()
3660                 if ($line =~ /\bget_jiffies_64\s*\(\s*\)\s*$Compare|$Compare\s*get_jiffies_64\s*\(\s*\)/) {
3661                         WARN("JIFFIES_COMPARISON",
3662                              "Comparing get_jiffies_64() is almost always wrong; prefer time_after64, time_before64 and friends\n" . $herecurr);
3663                 }
3664
3665 # warn about #ifdefs in C files
3666 #               if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
3667 #                       print "#ifdef in C files should be avoided\n";
3668 #                       print "$herecurr";
3669 #                       $clean = 0;
3670 #               }
3671
3672 # warn about spacing in #ifdefs
3673                 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
3674                         if (ERROR("SPACING",
3675                                   "exactly one space required after that #$1\n" . $herecurr) &&
3676                             $fix) {
3677                                 $fixed[$linenr - 1] =~
3678                                     s/^(.\s*\#\s*(ifdef|ifndef|elif))\s{2,}/$1 /;
3679                         }
3680
3681                 }
3682
3683 # check for spinlock_t definitions without a comment.
3684                 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
3685                     $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
3686                         my $which = $1;
3687                         if (!ctx_has_comment($first_line, $linenr)) {
3688                                 CHK("UNCOMMENTED_DEFINITION",
3689                                     "$1 definition without comment\n" . $herecurr);
3690                         }
3691                 }
3692 # check for memory barriers without a comment.
3693                 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
3694                         if (!ctx_has_comment($first_line, $linenr)) {
3695                                 CHK("MEMORY_BARRIER",
3696                                     "memory barrier without comment\n" . $herecurr);
3697                         }
3698                 }
3699 # check of hardware specific defines
3700                 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
3701                         CHK("ARCH_DEFINES",
3702                             "architecture specific defines should be avoided\n" .  $herecurr);
3703                 }
3704
3705 # Check that the storage class is at the beginning of a declaration
3706                 if ($line =~ /\b$Storage\b/ && $line !~ /^.\s*$Storage\b/) {
3707                         WARN("STORAGE_CLASS",
3708                              "storage class should be at the beginning of the declaration\n" . $herecurr)
3709                 }
3710
3711 # check the location of the inline attribute, that it is between
3712 # storage class and type.
3713                 if ($line =~ /\b$Type\s+$Inline\b/ ||
3714                     $line =~ /\b$Inline\s+$Storage\b/) {
3715                         ERROR("INLINE_LOCATION",
3716                               "inline keyword should sit between storage class and type\n" . $herecurr);
3717                 }
3718
3719 # Check for __inline__ and __inline, prefer inline
3720                 if ($line =~ /\b(__inline__|__inline)\b/) {
3721                         if (WARN("INLINE",
3722                                  "plain inline is preferred over $1\n" . $herecurr) &&
3723                             $fix) {
3724                                 $fixed[$linenr - 1] =~ s/\b(__inline__|__inline)\b/inline/;
3725
3726                         }
3727                 }
3728
3729 # Check for __attribute__ packed, prefer __packed
3730                 if ($line =~ /\b__attribute__\s*\(\s*\(.*\bpacked\b/) {
3731                         WARN("PREFER_PACKED",
3732                              "__packed is preferred over __attribute__((packed))\n" . $herecurr);
3733                 }
3734
3735 # Check for __attribute__ aligned, prefer __aligned
3736                 if ($line =~ /\b__attribute__\s*\(\s*\(.*aligned/) {
3737                         WARN("PREFER_ALIGNED",
3738                              "__aligned(size) is preferred over __attribute__((aligned(size)))\n" . $herecurr);
3739                 }
3740
3741 # Check for __attribute__ format(printf, prefer __printf
3742                 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf/) {
3743                         if (WARN("PREFER_PRINTF",
3744                                  "__printf(string-index, first-to-check) is preferred over __attribute__((format(printf, string-index, first-to-check)))\n" . $herecurr) &&
3745                             $fix) {
3746                                 $fixed[$linenr - 1] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*printf\s*,\s*(.*)\)\s*\)\s*\)/"__printf(" . trim($1) . ")"/ex;
3747
3748                         }
3749                 }
3750
3751 # Check for __attribute__ format(scanf, prefer __scanf
3752                 if ($line =~ /\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\b/) {
3753                         if (WARN("PREFER_SCANF",
3754                                  "__scanf(string-index, first-to-check) is preferred over __attribute__((format(scanf, string-index, first-to-check)))\n" . $herecurr) &&
3755                             $fix) {
3756                                 $fixed[$linenr - 1] =~ s/\b__attribute__\s*\(\s*\(\s*format\s*\(\s*scanf\s*,\s*(.*)\)\s*\)\s*\)/"__scanf(" . trim($1) . ")"/ex;
3757                         }
3758                 }
3759
3760 # check for sizeof(&)
3761                 if ($line =~ /\bsizeof\s*\(\s*\&/) {
3762                         WARN("SIZEOF_ADDRESS",
3763                              "sizeof(& should be avoided\n" . $herecurr);
3764                 }
3765
3766 # check for sizeof without parenthesis
3767                 if ($line =~ /\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/) {
3768                         if (WARN("SIZEOF_PARENTHESIS",
3769                                  "sizeof $1 should be sizeof($1)\n" . $herecurr) &&
3770                             $fix) {
3771                                 $fixed[$linenr - 1] =~ s/\bsizeof\s+((?:\*\s*|)$Lval|$Type(?:\s+$Lval|))/"sizeof(" . trim($1) . ")"/ex;
3772                         }
3773                 }
3774
3775 # check for line continuations in quoted strings with odd counts of "
3776                 if ($rawline =~ /\\$/ && $rawline =~ tr/"/"/ % 2) {
3777                         WARN("LINE_CONTINUATIONS",
3778                              "Avoid line continuations in quoted strings\n" . $herecurr);
3779                 }
3780
3781 # check for struct spinlock declarations
3782                 if ($line =~ /^.\s*\bstruct\s+spinlock\s+\w+\s*;/) {
3783                         WARN("USE_SPINLOCK_T",
3784                              "struct spinlock should be spinlock_t\n" . $herecurr);
3785                 }
3786
3787 # check for seq_printf uses that could be seq_puts
3788                 if ($line =~ /\bseq_printf\s*\(/) {
3789                         my $fmt = get_quoted_string($line, $rawline);
3790                         if ($fmt !~ /[^\\]\%/) {
3791                                 if (WARN("PREFER_SEQ_PUTS",
3792                                          "Prefer seq_puts to seq_printf\n" . $herecurr) &&
3793                                     $fix) {
3794                                         $fixed[$linenr - 1] =~ s/\bseq_printf\b/seq_puts/;
3795                                 }
3796                         }
3797                 }
3798
3799 # Check for misused memsets
3800                 if ($^V && $^V ge 5.10.0 &&
3801                     defined $stat &&
3802                     $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*$FuncArg\s*\)/s) {
3803
3804                         my $ms_addr = $2;
3805                         my $ms_val = $7;
3806                         my $ms_size = $12;
3807
3808                         if ($ms_size =~ /^(0x|)0$/i) {
3809                                 ERROR("MEMSET",
3810                                       "memset to 0's uses 0 as the 2nd argument, not the 3rd\n" . "$here\n$stat\n");
3811                         } elsif ($ms_size =~ /^(0x|)1$/i) {
3812                                 WARN("MEMSET",
3813                                      "single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . "$here\n$stat\n");
3814                         }
3815                 }
3816
3817 # typecasts on min/max could be min_t/max_t
3818                 if ($^V && $^V ge 5.10.0 &&
3819                     defined $stat &&
3820                     $stat =~ /^\+(?:.*?)\b(min|max)\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\)/) {
3821                         if (defined $2 || defined $7) {
3822                                 my $call = $1;
3823                                 my $cast1 = deparenthesize($2);
3824                                 my $arg1 = $3;
3825                                 my $cast2 = deparenthesize($7);
3826                                 my $arg2 = $8;
3827                                 my $cast;
3828
3829                                 if ($cast1 ne "" && $cast2 ne "" && $cast1 ne $cast2) {
3830                                         $cast = "$cast1 or $cast2";
3831                                 } elsif ($cast1 ne "") {
3832                                         $cast = $cast1;
3833                                 } else {
3834                                         $cast = $cast2;
3835                                 }
3836                                 WARN("MINMAX",
3837                                      "$call() should probably be ${call}_t($cast, $arg1, $arg2)\n" . "$here\n$stat\n");
3838                         }
3839                 }
3840
3841 # check usleep_range arguments
3842                 if ($^V && $^V ge 5.10.0 &&
3843                     defined $stat &&
3844                     $stat =~ /^\+(?:.*?)\busleep_range\s*\(\s*($FuncArg)\s*,\s*($FuncArg)\s*\)/) {
3845                         my $min = $1;
3846                         my $max = $7;
3847                         if ($min eq $max) {
3848                                 WARN("USLEEP_RANGE",
3849                                      "usleep_range should not use min == max args; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
3850                         } elsif ($min =~ /^\d+$/ && $max =~ /^\d+$/ &&
3851                                  $min > $max) {
3852                                 WARN("USLEEP_RANGE",
3853                                      "usleep_range args reversed, use min then max; see Documentation/timers/timers-howto.txt\n" . "$here\n$stat\n");
3854                         }
3855                 }
3856
3857 # check for new externs in .c files.
3858                 if ($realfile =~ /\.c$/ && defined $stat &&
3859                     $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
3860                 {
3861                         my $function_name = $1;
3862                         my $paren_space = $2;
3863
3864                         my $s = $stat;
3865                         if (defined $cond) {
3866                                 substr($s, 0, length($cond), '');
3867                         }
3868                         if ($s =~ /^\s*;/ &&
3869                             $function_name ne 'uninitialized_var')
3870                         {
3871                                 WARN("AVOID_EXTERNS",
3872                                      "externs should be avoided in .c files\n" .  $herecurr);
3873                         }
3874
3875                         if ($paren_space =~ /\n/) {
3876                                 WARN("FUNCTION_ARGUMENTS",
3877                                      "arguments for function declarations should follow identifier\n" . $herecurr);
3878                         }
3879
3880                 } elsif ($realfile =~ /\.c$/ && defined $stat &&
3881                     $stat =~ /^.\s*extern\s+/)
3882                 {
3883                         WARN("AVOID_EXTERNS",
3884                              "externs should be avoided in .c files\n" .  $herecurr);
3885                 }
3886
3887 # checks for new __setup's
3888                 if ($rawline =~ /\b__setup\("([^"]*)"/) {
3889                         my $name = $1;
3890
3891                         if (!grep(/$name/, @setup_docs)) {
3892                                 CHK("UNDOCUMENTED_SETUP",
3893                                     "__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
3894                         }
3895                 }
3896
3897 # check for pointless casting of kmalloc return
3898                 if ($line =~ /\*\s*\)\s*[kv][czm]alloc(_node){0,1}\b/) {
3899                         WARN("UNNECESSARY_CASTS",
3900                              "unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
3901                 }
3902
3903 # alloc style
3904 # p = alloc(sizeof(struct foo), ...) should be p = alloc(sizeof(*p), ...)
3905                 if ($^V && $^V ge 5.10.0 &&
3906                     $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*([kv][mz]alloc(?:_node)?)\s*\(\s*(sizeof\s*\(\s*struct\s+$Lval\s*\))/) {
3907                         CHK("ALLOC_SIZEOF_STRUCT",
3908                             "Prefer $3(sizeof(*$1)...) over $3($4...)\n" . $herecurr);
3909                 }
3910
3911 # check for krealloc arg reuse
3912                 if ($^V && $^V ge 5.10.0 &&
3913                     $line =~ /\b($Lval)\s*\=\s*(?:$balanced_parens)?\s*krealloc\s*\(\s*\1\s*,/) {
3914                         WARN("KREALLOC_ARG_REUSE",
3915                              "Reusing the krealloc arg is almost always a bug\n" . $herecurr);
3916                 }
3917
3918 # check for alloc argument mismatch
3919                 if ($line =~ /\b(kcalloc|kmalloc_array)\s*\(\s*sizeof\b/) {
3920                         WARN("ALLOC_ARRAY_ARGS",
3921                              "$1 uses number as first arg, sizeof is generally wrong\n" . $herecurr);
3922                 }
3923
3924 # check for multiple semicolons
3925                 if ($line =~ /;\s*;\s*$/) {
3926                         if (WARN("ONE_SEMICOLON",
3927                                  "Statements terminations use 1 semicolon\n" . $herecurr) &&
3928                             $fix) {
3929                                 $fixed[$linenr - 1] =~ s/(\s*;\s*){2,}$/;/g;
3930                         }
3931                 }
3932
3933 # check for switch/default statements without a break;
3934                 if ($^V && $^V ge 5.10.0 &&
3935                     defined $stat &&
3936                     $stat =~ /^\+[$;\s]*(?:case[$;\s]+\w+[$;\s]*:[$;\s]*|)*[$;\s]*\bdefault[$;\s]*:[$;\s]*;/g) {
3937                         my $ctx = '';
3938                         my $herectx = $here . "\n";
3939                         my $cnt = statement_rawlines($stat);
3940                         for (my $n = 0; $n < $cnt; $n++) {
3941                                 $herectx .= raw_line($linenr, $n) . "\n";
3942                         }
3943                         WARN("DEFAULT_NO_BREAK",
3944                              "switch default: should use break\n" . $herectx);
3945                 }
3946
3947 # check for gcc specific __FUNCTION__
3948                 if ($line =~ /\b__FUNCTION__\b/) {
3949                         if (WARN("USE_FUNC",
3950                                  "__func__ should be used instead of gcc specific __FUNCTION__\n"  . $herecurr) &&
3951                             $fix) {
3952                                 $fixed[$linenr - 1] =~ s/\b__FUNCTION__\b/__func__/g;
3953                         }
3954                 }
3955
3956 # check for use of yield()
3957                 if ($line =~ /\byield\s*\(\s*\)/) {
3958                         WARN("YIELD",
3959                              "Using yield() is generally wrong. See yield() kernel-doc (sched/core.c)\n"  . $herecurr);
3960                 }
3961
3962 # check for comparisons against true and false
3963                 if ($line =~ /\+\s*(.*?)\b(true|false|$Lval)\s*(==|\!=)\s*(true|false|$Lval)\b(.*)$/i) {
3964                         my $lead = $1;
3965                         my $arg = $2;
3966                         my $test = $3;
3967                         my $otype = $4;
3968                         my $trail = $5;
3969                         my $op = "!";
3970
3971                         ($arg, $otype) = ($otype, $arg) if ($arg =~ /^(?:true|false)$/i);
3972
3973                         my $type = lc($otype);
3974                         if ($type =~ /^(?:true|false)$/) {
3975                                 if (("$test" eq "==" && "$type" eq "true") ||
3976                                     ("$test" eq "!=" && "$type" eq "false")) {
3977                                         $op = "";
3978                                 }
3979
3980                                 CHK("BOOL_COMPARISON",
3981                                     "Using comparison to $otype is error prone\n" . $herecurr);
3982
3983 ## maybe suggesting a correct construct would better
3984 ##                                  "Using comparison to $otype is error prone.  Perhaps use '${lead}${op}${arg}${trail}'\n" . $herecurr);
3985
3986                         }
3987                 }
3988
3989 # check for semaphores initialized locked
3990                 if ($line =~ /^.\s*sema_init.+,\W?0\W?\)/) {
3991                         WARN("CONSIDER_COMPLETION",
3992                              "consider using a completion\n" . $herecurr);
3993                 }
3994
3995 # recommend kstrto* over simple_strto* and strict_strto*
3996                 if ($line =~ /\b((simple|strict)_(strto(l|ll|ul|ull)))\s*\(/) {
3997                         WARN("CONSIDER_KSTRTO",
3998                              "$1 is obsolete, use k$3 instead\n" . $herecurr);
3999                 }
4000
4001 # check for __initcall(), use device_initcall() explicitly please
4002                 if ($line =~ /^.\s*__initcall\s*\(/) {
4003                         WARN("USE_DEVICE_INITCALL",
4004                              "please use device_initcall() instead of __initcall()\n" . $herecurr);
4005                 }
4006
4007 # check for various ops structs, ensure they are const.
4008                 my $struct_ops = qr{acpi_dock_ops|
4009                                 address_space_operations|
4010                                 backlight_ops|
4011                                 block_device_operations|
4012                                 dentry_operations|
4013                                 dev_pm_ops|
4014                                 dma_map_ops|
4015                                 extent_io_ops|
4016                                 file_lock_operations|
4017                                 file_operations|
4018                                 hv_ops|
4019                                 ide_dma_ops|
4020                                 intel_dvo_dev_ops|
4021                                 item_operations|
4022                                 iwl_ops|
4023                                 kgdb_arch|
4024                                 kgdb_io|
4025                                 kset_uevent_ops|
4026                                 lock_manager_operations|
4027                                 microcode_ops|
4028                                 mtrr_ops|
4029                                 neigh_ops|
4030                                 nlmsvc_binding|
4031                                 pci_raw_ops|
4032                                 pipe_buf_operations|
4033                                 platform_hibernation_ops|
4034                                 platform_suspend_ops|
4035                                 proto_ops|
4036                                 rpc_pipe_ops|
4037                                 seq_operations|
4038                                 snd_ac97_build_ops|
4039                                 soc_pcmcia_socket_ops|
4040                                 stacktrace_ops|
4041                                 sysfs_ops|
4042                                 tty_operations|
4043                                 usb_mon_operations|
4044                                 wd_ops}x;
4045                 if ($line !~ /\bconst\b/ &&
4046                     $line =~ /\bstruct\s+($struct_ops)\b/) {
4047                         WARN("CONST_STRUCT",
4048                              "struct $1 should normally be const\n" .
4049                                 $herecurr);
4050                 }
4051
4052 # use of NR_CPUS is usually wrong
4053 # ignore definitions of NR_CPUS and usage to define arrays as likely right
4054                 if ($line =~ /\bNR_CPUS\b/ &&
4055                     $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
4056                     $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
4057                     $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
4058                     $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
4059                     $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
4060                 {
4061                         WARN("NR_CPUS",
4062                              "usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
4063                 }
4064
4065 # check for %L{u,d,i} in strings
4066                 my $string;
4067                 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
4068                         $string = substr($rawline, $-[1], $+[1] - $-[1]);
4069                         $string =~ s/%%/__/g;
4070                         if ($string =~ /(?<!%)%L[udi]/) {
4071                                 WARN("PRINTF_L",
4072                                      "\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
4073                                 last;
4074                         }
4075                 }
4076
4077 # whine mightly about in_atomic
4078                 if ($line =~ /\bin_atomic\s*\(/) {
4079                         if ($realfile =~ m@^drivers/@) {
4080                                 ERROR("IN_ATOMIC",
4081                                       "do not use in_atomic in drivers\n" . $herecurr);
4082                         } elsif ($realfile !~ m@^kernel/@) {
4083                                 WARN("IN_ATOMIC",
4084                                      "use of in_atomic() is incorrect outside core kernel code\n" . $herecurr);
4085                         }
4086                 }
4087
4088 # check for lockdep_set_novalidate_class
4089                 if ($line =~ /^.\s*lockdep_set_novalidate_class\s*\(/ ||
4090                     $line =~ /__lockdep_no_validate__\s*\)/ ) {
4091                         if ($realfile !~ m@^kernel/lockdep@ &&
4092                             $realfile !~ m@^include/linux/lockdep@ &&
4093                             $realfile !~ m@^drivers/base/core@) {
4094                                 ERROR("LOCKDEP",
4095                                       "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr);
4096                         }
4097                 }
4098
4099                 if ($line =~ /debugfs_create_file.*S_IWUGO/ ||
4100                     $line =~ /DEVICE_ATTR.*S_IWUGO/ ) {
4101                         WARN("EXPORTED_WORLD_WRITABLE",
4102                              "Exporting world writable files is usually an error. Consider more restrictive permissions.\n" . $herecurr);
4103                 }
4104         }
4105
4106         # If we have no input at all, then there is nothing to report on
4107         # so just keep quiet.
4108         if ($#rawlines == -1) {
4109                 exit(0);
4110         }
4111
4112         # In mailback mode only produce a report in the negative, for
4113         # things that appear to be patches.
4114         if ($mailback && ($clean == 1 || !$is_patch)) {
4115                 exit(0);
4116         }
4117
4118         # This is not a patch, and we are are in 'no-patch' mode so
4119         # just keep quiet.
4120         if (!$chk_patch && !$is_patch) {
4121                 exit(0);
4122         }
4123
4124         if (!$is_patch) {
4125                 ERROR("NOT_UNIFIED_DIFF",
4126                       "Does not appear to be a unified-diff format patch\n");
4127         }
4128         if ($is_patch && $chk_signoff && $signoff == 0) {
4129                 ERROR("MISSING_SIGN_OFF",
4130                       "Missing Signed-off-by: line(s)\n");
4131         }
4132
4133         print report_dump();
4134         if ($summary && !($clean == 1 && $quiet == 1)) {
4135                 print "$filename " if ($summary_file);
4136                 print "total: $cnt_error errors, $cnt_warn warnings, " .
4137                         (($check)? "$cnt_chk checks, " : "") .
4138                         "$cnt_lines lines checked\n";
4139                 print "\n" if ($quiet == 0);
4140         }
4141
4142         if ($quiet == 0) {
4143
4144                 if ($^V lt 5.10.0) {
4145                         print("NOTE: perl $^V is not modern enough to detect all possible issues.\n");
4146                         print("An upgrade to at least perl v5.10.0 is suggested.\n\n");
4147                 }
4148
4149                 # If there were whitespace errors which cleanpatch can fix
4150                 # then suggest that.
4151                 if ($rpt_cleaners) {
4152                         print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
4153                         print "      scripts/cleanfile\n\n";
4154                         $rpt_cleaners = 0;
4155                 }
4156         }
4157
4158         if ($quiet == 0 && keys %ignore_type) {
4159             print "NOTE: Ignored message types:";
4160             foreach my $ignore (sort keys %ignore_type) {
4161                 print " $ignore";
4162             }
4163             print "\n\n";
4164         }
4165
4166         if ($clean == 0 && $fix && "@rawlines" ne "@fixed") {
4167                 my $newfile = $filename . ".EXPERIMENTAL-checkpatch-fixes";
4168                 my $linecount = 0;
4169                 my $f;
4170
4171                 open($f, '>', $newfile)
4172                     or die "$P: Can't open $newfile for write\n";
4173                 foreach my $fixed_line (@fixed) {
4174                         $linecount++;
4175                         if ($file) {
4176                                 if ($linecount > 3) {
4177                                         $fixed_line =~ s/^\+//;
4178                                         print $f $fixed_line. "\n";
4179                                 }
4180                         } else {
4181                                 print $f $fixed_line . "\n";
4182                         }
4183                 }
4184                 close($f);
4185
4186                 if (!$quiet) {
4187                         print << "EOM";
4188 Wrote EXPERIMENTAL --fix correction(s) to '$newfile'
4189
4190 Do _NOT_ trust the results written to this file.
4191 Do _NOT_ submit these changes without inspecting them for correctness.
4192
4193 This EXPERIMENTAL file is simply a convenience to help rewrite patches.
4194 No warranties, expressed or implied...
4195
4196 EOM
4197                 }
4198         }
4199
4200         if ($clean == 1 && $quiet == 0) {
4201                 print "$vname has no obvious style problems and is ready for submission.\n"
4202         }
4203         if ($clean == 0 && $quiet == 0) {
4204                 print << "EOM";
4205 $vname has style problems, please review.
4206
4207 If any of these errors are false positives, please report
4208 them to the maintainer, see CHECKPATCH in MAINTAINERS.
4209 EOM
4210         }
4211
4212         return $clean;
4213 }