2 # (c) 2001, Dave Jones. <davej@codemonkey.org.uk> (the file handling bit)
3 # (c) 2005, Joel Schopp <jschopp@austin.ibm.com> (the ugly bit)
4 # (c) 2007, Andy Whitcroft <apw@uk.ibm.com> (new conditions, test suite, etc)
5 # Licensed under the terms of the GNU GPL License version 2
14 use Getopt::Long qw(:config no_auto_abbrev);
31 'q|quiet+' => \$quiet,
33 'signoff!' => \$chk_signoff,
34 'patch!' => \$chk_patch,
38 'subjective!' => \$check,
41 'summary!' => \$summary,
42 'mailback!' => \$mailback,
43 'summary-file!' => \$summary_file,
46 'test-only=s' => \$tst_only,
52 print "usage: $P [options] patchfile\n";
53 print "version: $V\n";
54 print "options: -q => quiet\n";
55 print " --no-tree => run without a kernel tree\n";
56 print " --terse => one line per report\n";
57 print " --emacs => emacs compile window format\n";
58 print " --file => check a source file\n";
59 print " --strict => enable more subjective tests\n";
60 print " --root => path to the kernel tree root\n";
61 print " --no-summary => suppress the per-file summary\n";
62 print " --summary-file => include the filename in summary\n";
70 for my $key (keys %debug) {
71 eval "\${dbg_$key} = '$debug{$key}';"
81 if (!top_of_kernel_tree($root)) {
82 die "$P: $root: --root does not point at a valid tree\n";
85 if (top_of_kernel_tree('.')) {
87 } elsif ($0 =~ m@(.*)/scripts/[^/]*$@ &&
88 top_of_kernel_tree($1)) {
94 print "Must be run from the top-level dir. of a kernel tree\n";
99 my $emitted_corrupt = 0;
101 our $Ident = qr{[A-Za-z_][A-Za-z\d_]*};
102 our $Storage = qr{extern|static|asmlinkage};
116 __(?:mem|cpu|dev|)(?:initdata|init)|
117 ____cacheline_aligned|
118 ____cacheline_aligned_in_smp|
119 ____cacheline_internodealigned_in_smp
122 our $Inline = qr{inline|__always_inline|noinline};
123 our $Member = qr{->$Ident|\.$Ident|\[[^]]*\]};
124 our $Lval = qr{$Ident(?:$Member)*};
126 our $Constant = qr{(?:[0-9]+|0x[0-9a-fA-F]+)[UL]*};
127 our $Assignment = qr{(?:\*\=|/=|%=|\+=|-=|<<=|>>=|&=|\^=|\|=|=)};
131 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%
139 [\x09\x0A\x0D\x20-\x7E] # ASCII
140 | [\xC2-\xDF][\x80-\xBF] # non-overlong 2-byte
141 | \xE0[\xA0-\xBF][\x80-\xBF] # excluding overlongs
142 | [\xE1-\xEC\xEE\xEF][\x80-\xBF]{2} # straight 3-byte
143 | \xED[\x80-\x9F][\x80-\xBF] # excluding surrogates
144 | \xF0[\x90-\xBF][\x80-\xBF]{2} # planes 1-3
145 | [\xF1-\xF3][\x80-\xBF]{3} # planes 4-15
146 | \xF4[\x80-\x8F][\x80-\xBF]{2} # plane 16
151 qr{(?:unsigned\s+)?char},
152 qr{(?:unsigned\s+)?short},
153 qr{(?:unsigned\s+)?int},
154 qr{(?:unsigned\s+)?long},
155 qr{(?:unsigned\s+)?long\s+int},
156 qr{(?:unsigned\s+)?long\s+long},
157 qr{(?:unsigned\s+)?long\s+long\s+int},
162 qr{(?:__)?(?:u|s|be|le)(?:8|16|32|64)},
167 qr{${Ident}_handler},
168 qr{${Ident}_handler_fn},
170 our @modifierList = (
175 my $mods = "(?x: \n" . join("|\n ", @modifierList) . "\n)";
176 my $all = "(?x: \n" . join("|\n ", @typeList) . "\n)";
177 $Modifier = qr{(?:$Attribute|$Sparse|$mods)};
179 (?:$Modifier\s+|const\s+)*
181 (?:typeof|__typeof__)\s*\(\s*\**\s*$Ident\s*\)|
184 (?:\s+$Modifier|\s+const)*
188 (?:\s*\*+\s*const|\s*\*+|(?:\s*\[\s*\])+)?
189 (?:\s+$Inline|\s+$Modifier)*
191 $Declare = qr{(?:$Storage\s+)?$Type};
195 $chk_signoff = 0 if ($file);
197 my @dep_includes = ();
198 my @dep_functions = ();
199 my $removal = "Documentation/feature-removal-schedule.txt";
200 if ($tree && -f "$root/$removal") {
201 open(REMOVE, "<$root/$removal") ||
202 die "$P: $removal: open failed - $!\n";
204 if (/^Check:\s+(.*\S)/) {
205 for my $entry (split(/[, ]+/, $1)) {
206 if ($entry =~ m@include/(.*)@) {
207 push(@dep_includes, $1);
209 } elsif ($entry !~ m@/@) {
210 push(@dep_functions, $entry);
220 for my $filename (@ARGV) {
222 open(FILE, "diff -u /dev/null $filename|") ||
223 die "$P: $filename: diff failed - $!\n";
225 open(FILE, "<$filename") ||
226 die "$P: $filename: open failed - $!\n";
228 if ($filename eq '-') {
229 $vname = 'Your patch';
238 if (!process($filename)) {
247 sub top_of_kernel_tree {
251 "COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
252 "README", "Documentation", "arch", "include", "drivers",
253 "fs", "init", "ipc", "kernel", "lib", "scripts",
256 foreach my $check (@tree_check) {
257 if (! -e $root . '/' . $check) {
269 for my $c (split(//, $str)) {
273 for (; ($n % 8) != 0; $n++) {
285 (my $res = shift) =~ tr/\t/ /c;
292 # Drop the diff line leader and expand tabs
294 $line = expand_tabs($line);
296 # Pick the indent from the front of the line.
297 my ($white) = ($line =~ /^(\s*)/);
299 return (length($line), length($white));
302 my $sanitise_quote = '';
304 sub sanitise_line_reset {
305 my ($in_comment) = @_;
308 $sanitise_quote = '*/';
310 $sanitise_quote = '';
323 # Always copy over the diff marker.
324 $res = substr($line, 0, 1);
326 for ($off = 1; $off < length($line); $off++) {
327 $c = substr($line, $off, 1);
329 # Comments we are wacking completly including the begin
330 # and end, all to $;.
331 if ($sanitise_quote eq '' && substr($line, $off, 2) eq '/*') {
332 $sanitise_quote = '*/';
334 substr($res, $off, 2, "$;$;");
338 if (substr($line, $off, 2) eq '*/') {
339 $sanitise_quote = '';
340 substr($res, $off, 2, "$;$;");
345 # A \ in a string means ignore the next character.
346 if (($sanitise_quote eq "'" || $sanitise_quote eq '"') &&
348 substr($res, $off, 2, 'XX');
353 if ($c eq "'" || $c eq '"') {
354 if ($sanitise_quote eq '') {
355 $sanitise_quote = $c;
357 substr($res, $off, 1, $c);
359 } elsif ($sanitise_quote eq $c) {
360 $sanitise_quote = '';
364 #print "SQ:$sanitise_quote\n";
365 if ($off != 0 && $sanitise_quote eq '*/' && $c ne "\t") {
366 substr($res, $off, 1, $;);
367 } elsif ($off != 0 && $sanitise_quote && $c ne "\t") {
368 substr($res, $off, 1, 'X');
370 substr($res, $off, 1, $c);
374 # The pathname on a #include may be surrounded by '<' and '>'.
375 if ($res =~ /^.\s*\#\s*include\s+\<(.*)\>/) {
376 my $clean = 'X' x length($1);
377 $res =~ s@\<.*\>@<$clean>@;
379 # The whole of a #error is a string.
380 } elsif ($res =~ /^.\s*\#\s*(?:error|warning)\s+(.*)\b/) {
381 my $clean = 'X' x length($1);
382 $res =~ s@(\#\s*(?:error|warning)\s+).*@$1$clean@;
388 sub ctx_statement_block {
389 my ($linenr, $remain, $off) = @_;
390 my $line = $linenr - 1;
406 #warn "CSB: blk<$blk> remain<$remain>\n";
407 # If we are about to drop off the end, pull in more
410 for (; $remain > 0; $line++) {
411 next if ($lines[$line] =~ /^-/);
414 $blk .= $lines[$line] . "\n";
419 # Bail if there is no further context.
420 #warn "CSB: blk<$blk> off<$off> len<$len>\n";
426 $c = substr($blk, $off, 1);
427 $remainder = substr($blk, $off);
429 #warn "CSB: c<$c> type<$type> level<$level> remainder<$remainder> coff_set<$coff_set>\n";
430 # Statement ends at the ';' or a close '}' at the
432 if ($level == 0 && $c eq ';') {
436 # An else is really a conditional as long as its not else if
437 if ($level == 0 && $coff_set == 0 &&
438 (!defined($p) || $p =~ /(?:\s|\}|\+)/) &&
439 $remainder =~ /^(else)(?:\s|{)/ &&
440 $remainder !~ /^else\s+if\b/) {
441 $coff = $off + length($1) - 1;
443 #warn "CSB: mark coff<$coff> soff<$soff> 1<$1>\n";
444 #warn "[" . substr($blk, $soff, $coff - $soff + 1) . "]\n";
447 if (($type eq '' || $type eq '(') && $c eq '(') {
451 if ($type eq '(' && $c eq ')') {
453 $type = ($level != 0)? '(' : '';
455 if ($level == 0 && $coff < $soff) {
458 #warn "CSB: mark coff<$coff>\n";
461 if (($type eq '' || $type eq '{') && $c eq '{') {
465 if ($type eq '{' && $c eq '}') {
467 $type = ($level != 0)? '{' : '';
475 # We are truly at the end, so shuffle to the next line.
482 my $statement = substr($blk, $soff, $off - $soff + 1);
483 my $condition = substr($blk, $soff, $coff - $soff + 1);
485 #warn "STATEMENT<$statement>\n";
486 #warn "CONDITION<$condition>\n";
488 #print "coff<$coff> soff<$off> loff<$loff>\n";
490 return ($statement, $condition,
491 $line, $remain + 1, $off - $loff + 1, $level);
494 sub statement_lines {
497 # Strip the diff line prefixes and rip blank lines at start and end.
498 $stmt =~ s/(^|\n)./$1/g;
502 my @stmt_lines = ($stmt =~ /\n/g);
504 return $#stmt_lines + 2;
507 sub statement_rawlines {
510 my @stmt_lines = ($stmt =~ /\n/g);
512 return $#stmt_lines + 2;
515 sub statement_block_size {
518 $stmt =~ s/(^|\n)./$1/g;
524 my @stmt_lines = ($stmt =~ /\n/g);
525 my @stmt_statements = ($stmt =~ /;/g);
527 my $stmt_lines = $#stmt_lines + 2;
528 my $stmt_statements = $#stmt_statements + 1;
530 if ($stmt_lines > $stmt_statements) {
533 return $stmt_statements;
537 sub ctx_statement_full {
538 my ($linenr, $remain, $off) = @_;
539 my ($statement, $condition, $level);
543 # Grab the first conditional/block pair.
544 ($statement, $condition, $linenr, $remain, $off, $level) =
545 ctx_statement_block($linenr, $remain, $off);
546 #print "F: c<$condition> s<$statement> remain<$remain>\n";
547 push(@chunks, [ $condition, $statement ]);
548 if (!($remain > 0 && $condition =~ /^\s*(?:\n[+-])?\s*(?:if|else|do)\b/s)) {
549 return ($level, $linenr, @chunks);
552 # Pull in the following conditional/block pairs and see if they
553 # could continue the statement.
555 ($statement, $condition, $linenr, $remain, $off, $level) =
556 ctx_statement_block($linenr, $remain, $off);
557 #print "C: c<$condition> s<$statement> remain<$remain>\n";
558 last if (!($remain > 0 && $condition =~ /^(?:\s*\n[+-])*\s*(?:else|do)\b/s));
560 push(@chunks, [ $condition, $statement ]);
563 return ($level, $linenr, @chunks);
567 my ($linenr, $remain, $outer, $open, $close, $off) = @_;
569 my $start = $linenr - 1;
576 for ($line = $start; $remain > 0; $line++) {
577 next if ($rawlines[$line] =~ /^-/);
580 $blk .= $rawlines[$line];
581 foreach my $c (split(//, $rawlines[$line])) {
582 ##print "C<$c>L<$level><$open$close>O<$off>\n";
588 if ($c eq $close && $level > 0) {
590 last if ($level == 0);
591 } elsif ($c eq $open) {
596 if (!$outer || $level <= 1) {
597 push(@res, $rawlines[$line]);
600 last if ($level == 0);
603 return ($level, @res);
605 sub ctx_block_outer {
606 my ($linenr, $remain) = @_;
608 my ($level, @r) = ctx_block_get($linenr, $remain, 1, '{', '}', 0);
612 my ($linenr, $remain) = @_;
614 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '{', '}', 0);
618 my ($linenr, $remain, $off) = @_;
620 my ($level, @r) = ctx_block_get($linenr, $remain, 0, '(', ')', $off);
623 sub ctx_block_level {
624 my ($linenr, $remain) = @_;
626 return ctx_block_get($linenr, $remain, 0, '{', '}', 0);
628 sub ctx_statement_level {
629 my ($linenr, $remain, $off) = @_;
631 return ctx_block_get($linenr, $remain, 0, '(', ')', $off);
634 sub ctx_locate_comment {
635 my ($first_line, $end_line) = @_;
637 # Catch a comment on the end of the line itself.
638 my ($current_comment) = ($rawlines[$end_line - 1] =~ m@.*(/\*.*\*/)\s*(?:\\\s*)?$@);
639 return $current_comment if (defined $current_comment);
641 # Look through the context and try and figure out if there is a
644 $current_comment = '';
645 for (my $linenr = $first_line; $linenr < $end_line; $linenr++) {
646 my $line = $rawlines[$linenr - 1];
648 if ($linenr == $first_line and $line =~ m@^.\s*\*@) {
651 if ($line =~ m@/\*@) {
654 if (!$in_comment && $current_comment ne '') {
655 $current_comment = '';
657 $current_comment .= $line . "\n" if ($in_comment);
658 if ($line =~ m@\*/@) {
663 chomp($current_comment);
664 return($current_comment);
666 sub ctx_has_comment {
667 my ($first_line, $end_line) = @_;
668 my $cmt = ctx_locate_comment($first_line, $end_line);
670 ##print "LINE: $rawlines[$end_line - 1 ]\n";
671 ##print "CMMT: $cmt\n";
681 while ($vet =~ /([^[:cntrl:]]*)([[:cntrl:]]|$)/g) {
684 $coded = sprintf("^%c", unpack('C', $2) + 64);
693 my $av_preprocessor = 0;
699 $av_preprocessor = 0;
701 @av_paren_type = ('E');
702 $av_pend_colon = 'O';
705 sub annotate_values {
706 my ($stream, $type) = @_;
709 my $var = '_' x length($stream);
712 print "$stream\n" if ($dbg_values > 1);
714 while (length($cur)) {
715 @av_paren_type = ('E') if ($#av_paren_type < 0);
716 print " <" . join('', @av_paren_type) .
717 "> <$type> <$av_pending>" if ($dbg_values > 1);
718 if ($cur =~ /^(\s+)/o) {
719 print "WS($1)\n" if ($dbg_values > 1);
720 if ($1 =~ /\n/ && $av_preprocessor) {
721 $type = pop(@av_paren_type);
722 $av_preprocessor = 0;
725 } elsif ($cur =~ /^($Type)\s*(?:$Ident|,|\)|\()/) {
726 print "DECLARE($1)\n" if ($dbg_values > 1);
729 } elsif ($cur =~ /^($Modifier)\s*/) {
730 print "MODIFIER($1)\n" if ($dbg_values > 1);
733 } elsif ($cur =~ /^(\#\s*define\s*$Ident)(\(?)/o) {
734 print "DEFINE($1,$2)\n" if ($dbg_values > 1);
735 $av_preprocessor = 1;
736 push(@av_paren_type, $type);
742 } elsif ($cur =~ /^(\#\s*(?:undef\s*$Ident|include\b))/o) {
743 print "UNDEF($1)\n" if ($dbg_values > 1);
744 $av_preprocessor = 1;
745 push(@av_paren_type, $type);
747 } elsif ($cur =~ /^(\#\s*(?:ifdef|ifndef|if))/o) {
748 print "PRE_START($1)\n" if ($dbg_values > 1);
749 $av_preprocessor = 1;
751 push(@av_paren_type, $type);
752 push(@av_paren_type, $type);
755 } elsif ($cur =~ /^(\#\s*(?:else|elif))/o) {
756 print "PRE_RESTART($1)\n" if ($dbg_values > 1);
757 $av_preprocessor = 1;
759 push(@av_paren_type, $av_paren_type[$#av_paren_type]);
763 } elsif ($cur =~ /^(\#\s*(?:endif))/o) {
764 print "PRE_END($1)\n" if ($dbg_values > 1);
766 $av_preprocessor = 1;
768 # Assume all arms of the conditional end as this
769 # one does, and continue as if the #endif was not here.
771 push(@av_paren_type, $type);
774 } elsif ($cur =~ /^(\\\n)/o) {
775 print "PRECONT($1)\n" if ($dbg_values > 1);
777 } elsif ($cur =~ /^(__attribute__)\s*\(?/o) {
778 print "ATTR($1)\n" if ($dbg_values > 1);
782 } elsif ($cur =~ /^(sizeof)\s*(\()?/o) {
783 print "SIZEOF($1)\n" if ($dbg_values > 1);
789 } elsif ($cur =~ /^(if|while|for)\b/o) {
790 print "COND($1)\n" if ($dbg_values > 1);
794 } elsif ($cur =~/^(case)/o) {
795 print "CASE($1)\n" if ($dbg_values > 1);
796 $av_pend_colon = 'C';
799 } elsif ($cur =~/^(return|else|goto|typeof|__typeof__)\b/o) {
800 print "KEYWORD($1)\n" if ($dbg_values > 1);
803 } elsif ($cur =~ /^(\()/o) {
804 print "PAREN('$1')\n" if ($dbg_values > 1);
805 push(@av_paren_type, $av_pending);
809 } elsif ($cur =~ /^(\))/o) {
810 my $new_type = pop(@av_paren_type);
811 if ($new_type ne '_') {
813 print "PAREN('$1') -> $type\n"
814 if ($dbg_values > 1);
816 print "PAREN('$1')\n" if ($dbg_values > 1);
819 } elsif ($cur =~ /^($Ident)\s*\(/o) {
820 print "FUNC($1)\n" if ($dbg_values > 1);
824 } elsif ($cur =~ /^($Ident\s*):/) {
826 $av_pend_colon = 'L';
827 } elsif ($type eq 'T') {
828 $av_pend_colon = 'B';
830 print "IDENT_COLON($1,$type>$av_pend_colon)\n" if ($dbg_values > 1);
833 } elsif ($cur =~ /^($Ident|$Constant)/o) {
834 print "IDENT($1)\n" if ($dbg_values > 1);
837 } elsif ($cur =~ /^($Assignment)/o) {
838 print "ASSIGN($1)\n" if ($dbg_values > 1);
841 } elsif ($cur =~/^(;|{|})/) {
842 print "END($1)\n" if ($dbg_values > 1);
844 $av_pend_colon = 'O';
846 } elsif ($cur =~ /^(\?)/o) {
847 print "QUESTION($1)\n" if ($dbg_values > 1);
850 } elsif ($cur =~ /^(:)/o) {
851 print "COLON($1,$av_pend_colon)\n" if ($dbg_values > 1);
853 substr($var, length($res), 1, $av_pend_colon);
854 if ($av_pend_colon eq 'C' || $av_pend_colon eq 'L') {
859 $av_pend_colon = 'O';
861 } elsif ($cur =~ /^(;|\[)/o) {
862 print "CLOSE($1)\n" if ($dbg_values > 1);
865 } elsif ($cur =~ /^(-(?![->])|\+(?!\+)|\*|\&\&|\&)/o) {
868 print "OPV($1)\n" if ($dbg_values > 1);
875 substr($var, length($res), 1, $variant);
878 } elsif ($cur =~ /^($Operators)/o) {
879 print "OP($1)\n" if ($dbg_values > 1);
880 if ($1 ne '++' && $1 ne '--') {
884 } elsif ($cur =~ /(^.)/o) {
885 print "C($1)\n" if ($dbg_values > 1);
888 $cur = substr($cur, length($1));
889 $res .= $type x length($1);
897 my ($possible, $line) = @_;
899 print "CHECK<$possible> ($line)\n" if ($dbg_possible > 1);
900 if ($possible !~ /^(?:$Modifier|$Storage|$Type|DEFINE_\S+)$/ &&
901 $possible ne 'goto' && $possible ne 'return' &&
902 $possible ne 'case' && $possible ne 'else' &&
903 $possible ne 'asm' && $possible ne '__asm__' &&
904 $possible !~ /^(typedef|struct|enum)\b/) {
905 # Check for modifiers.
906 $possible =~ s/\s*$Storage\s*//g;
907 $possible =~ s/\s*$Sparse\s*//g;
908 if ($possible =~ /^\s*$/) {
910 } elsif ($possible =~ /\s/) {
911 $possible =~ s/\s*$Type\s*//g;
912 for my $modifier (split(' ', $possible)) {
913 warn "MODIFIER: $modifier ($possible) ($line)\n" if ($dbg_possible);
914 push(@modifierList, $modifier);
918 warn "POSSIBLE: $possible ($line)\n" if ($dbg_possible);
919 push(@typeList, $possible);
928 if (defined $tst_only && $_[0] !~ /\Q$tst_only\E/) {
931 my $line = $prefix . $_[0];
933 $line = (split('\n', $line))[0] . "\n" if ($terse);
935 push(our @report, $line);
943 if (report("ERROR: $_[0]\n")) {
949 if (report("WARNING: $_[0]\n")) {
955 if ($check && report("CHECK: $_[0]\n")) {
961 sub check_absolute_file {
962 my ($absolute, $herecurr) = @_;
963 my $file = $absolute;
965 ##print "absolute<$absolute>\n";
967 # See if any suffix of this path is a path within the tree.
968 while ($file =~ s@^[^/]*/@@) {
969 if (-f "$root/$file") {
970 ##print "file<$file>\n";
978 # It is, so see if the prefix is acceptable.
979 my $prefix = $absolute;
980 substr($prefix, -length($file)) = '';
982 ##print "prefix<$prefix>\n";
983 if ($prefix ne ".../") {
984 WARN("use relative pathname instead of absolute in changelog text\n" . $herecurr);
989 my $filename = shift;
1012 # Trace the real file/line as we go.
1018 my $comment_edge = 0;
1021 my $prev_values = 'E';
1024 my %suppress_ifbraces;
1026 # Pre-scan the patch sanitizing the lines.
1027 # Pre-scan the patch looking for any __setup documentation.
1029 my @setup_docs = ();
1032 sanitise_line_reset();
1034 foreach my $rawline (@rawlines) {
1038 if ($rawline=~/^\+\+\+\s+(\S+)/) {
1040 if ($1 =~ m@Documentation/kernel-parameters.txt$@) {
1045 if ($rawline=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1054 # Guestimate if this is a continuing comment. Run
1055 # the context looking for a comment "edge". If this
1056 # edge is a close comment then we must be in a comment
1060 for (my $ln = $linenr + 1; $cnt > 0; $ln++) {
1061 next if (defined $rawlines[$ln - 1] &&
1062 $rawlines[$ln - 1] =~ /^-/);
1064 #print "RAW<$rawlines[$ln - 1]>\n";
1065 ($edge) = (defined $rawlines[$ln - 1] &&
1066 $rawlines[$ln - 1] =~ m@(/\*|\*/)@);
1067 last if (defined $edge);
1069 if (defined $edge && $edge eq '*/') {
1073 # Guestimate if this is a continuing comment. If this
1074 # is the start of a diff block and this line starts
1075 # ' *' then it is very likely a comment.
1076 if (!defined $edge &&
1077 $rawlines[$linenr] =~ m@^.\s* \*(?:\s|$)@)
1082 ##print "COMMENT:$in_comment edge<$edge> $rawline\n";
1083 sanitise_line_reset($in_comment);
1085 } elsif ($realcnt && $rawline =~ /^(?:\+| |$)/) {
1086 # Standardise the strings and chars within the input to
1087 # simplify matching -- only bother with positive lines.
1088 $line = sanitise_line($rawline);
1090 push(@lines, $line);
1093 $realcnt-- if ($line =~ /^(?:\+| |$)/);
1098 #print "==>$rawline\n";
1099 #print "-->$line\n";
1101 if ($setup_docs && $line =~ /^\+/) {
1102 push(@setup_docs, $line);
1110 foreach my $line (@lines) {
1113 my $rawline = $rawlines[$linenr - 1];
1115 #extract the line range in the file after the patch is applied
1116 if ($line=~/^\@\@ -\d+(?:,\d+)? \+(\d+)(,(\d+))? \@\@/) {
1118 $first_line = $linenr + 1;
1128 %suppress_ifbraces = ();
1131 # track the line number as we move through the hunk, note that
1132 # new versions of GNU diff omit the leading space on completely
1133 # blank context lines so we need to count that too.
1134 } elsif ($line =~ /^( |\+|$)/) {
1136 $realcnt-- if ($realcnt != 0);
1138 # Measure the line length and indent.
1139 ($length, $indent) = line_stats($rawline);
1141 # Track the previous line.
1142 ($prevline, $stashline) = ($stashline, $line);
1143 ($previndent, $stashindent) = ($stashindent, $indent);
1144 ($prevrawline, $stashrawline) = ($stashrawline, $rawline);
1146 #warn "line<$line>\n";
1148 } elsif ($realcnt == 1) {
1152 #make up the handle for any error we report on this line
1153 $prefix = "$filename:$realline: " if ($emacs && $file);
1154 $prefix = "$filename:$linenr: " if ($emacs && !$file);
1156 $here = "#$linenr: " if (!$file);
1157 $here = "#$realline: " if ($file);
1159 # extract the filename as it passes
1160 if ($line=~/^\+\+\+\s+(\S+)/) {
1162 $realfile =~ s@^[^/]*/@@;
1164 if ($realfile =~ m@^include/asm/@) {
1165 ERROR("do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n");
1170 $here .= "FILE: $realfile:$realline:" if ($realcnt != 0);
1172 my $hereline = "$here\n$rawline\n";
1173 my $herecurr = "$here\n$rawline\n";
1174 my $hereprev = "$here\n$prevrawline\n$rawline\n";
1176 $cnt_lines++ if ($realcnt != 0);
1178 #check the patch for a signoff:
1179 if ($line =~ /^\s*signed-off-by:/i) {
1180 # This is a signoff, if ugly, so do not double report.
1182 if (!($line =~ /^\s*Signed-off-by:/)) {
1183 WARN("Signed-off-by: is the preferred form\n" .
1186 if ($line =~ /^\s*signed-off-by:\S/i) {
1187 WARN("space required after Signed-off-by:\n" .
1192 # Check for wrappage within a valid hunk of the file
1193 if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
1194 ERROR("patch seems to be corrupt (line wrapped?)\n" .
1195 $herecurr) if (!$emitted_corrupt++);
1198 # Check for absolute kernel paths.
1200 while ($line =~ m{(?:^|\s)(/\S*)}g) {
1203 if ($file =~ m{^(.*?)(?::\d+)+:?$} &&
1204 check_absolute_file($1, $herecurr)) {
1207 check_absolute_file($file, $herecurr);
1212 # UTF-8 regex found at http://www.w3.org/International/questions/qa-forms-utf-8.en.php
1213 if (($realfile =~ /^$/ || $line =~ /^\+/) &&
1214 $rawline !~ m/^$UTF8*$/) {
1215 my ($utf8_prefix) = ($rawline =~ /^($UTF8*)/);
1217 my $blank = copy_spacing($rawline);
1218 my $ptr = substr($blank, 0, length($utf8_prefix)) . "^";
1219 my $hereptr = "$hereline$ptr\n";
1221 ERROR("Invalid UTF-8, patch and commit message should be encoded in UTF-8\n" . $hereptr);
1224 #ignore lines being removed
1225 if ($line=~/^-/) {next;}
1227 # check we are in a valid source file if not then ignore this hunk
1228 next if ($realfile !~ /\.(h|c|s|S|pl|sh)$/);
1230 #trailing whitespace
1231 if ($line =~ /^\+.*\015/) {
1232 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1233 ERROR("DOS line endings\n" . $herevet);
1235 } elsif ($rawline =~ /^\+.*\S\s+$/ || $rawline =~ /^\+\s+$/) {
1236 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1237 ERROR("trailing whitespace\n" . $herevet);
1240 if ($line =~ /^\+/ && $prevrawline !~ /\/\*\*/ &&
1241 $rawline !~ /^.\s*\*\s*\@$Ident\s/ &&
1242 $line !~ /^\+\s*printk\s*\(\s*(?:KERN_\S+\s*)?"[X\t]*"\s*(?:,|\)\s*;)\s*$/ &&
1245 WARN("line over 80 characters\n" . $herecurr);
1248 # check for adding lines without a newline.
1249 if ($line =~ /^\+/ && defined $lines[$linenr] && $lines[$linenr] =~ /^\\ No newline at end of file/) {
1250 WARN("adding a line without newline at end of file\n" . $herecurr);
1253 # check we are in a valid source file *.[hc] if not then ignore this hunk
1254 next if ($realfile !~ /\.[hc]$/);
1256 # at the beginning of a line any tabs must come first and anything
1257 # more than 8 must use tabs.
1258 if ($rawline =~ /^\+\s* \t\s*\S/ ||
1259 $rawline =~ /^\+\s* \s*/) {
1260 my $herevet = "$here\n" . cat_vet($rawline) . "\n";
1261 ERROR("code indent should use tabs where possible\n" . $herevet);
1264 # check for RCS/CVS revision markers
1265 if ($rawline =~ /^\+.*\$(Revision|Log|Id)(?:\$|)/) {
1266 WARN("CVS style keyword markers, these will _not_ be updated\n". $herecurr);
1269 # Check for potential 'bare' types
1270 my ($stat, $cond, $line_nr_next, $remain_next);
1271 if ($realcnt && $line =~ /.\s*\S/) {
1272 ($stat, $cond, $line_nr_next, $remain_next) =
1273 ctx_statement_block($linenr, $realcnt, 0);
1274 $stat =~ s/\n./\n /g;
1275 $cond =~ s/\n./\n /g;
1280 # Ignore goto labels.
1281 if ($s =~ /$Ident:\*$/s) {
1283 # Ignore functions being called
1284 } elsif ($s =~ /^.\s*$Ident\s*\(/s) {
1286 # declarations always start with types
1287 } elsif ($prev_values eq 'E' && $s =~ /^.\s*(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?((?:\s*$Ident)+?)\b(?:\s+$Sparse)?\s*\**\s*(?:$Ident|\(\*[^\)]*\))(?:\s*$Modifier)?\s*(?:;|=|,|\()/s) {
1290 possible($type, "A:" . $s);
1292 # definitions in global scope can only start with types
1293 } elsif ($s =~ /^.(?:$Storage\s+)?(?:$Inline\s+)?(?:const\s+)?($Ident)\b/s) {
1294 possible($1, "B:" . $s);
1297 # any (foo ... *) is a pointer cast, and foo is a type
1298 while ($s =~ /\(($Ident)(?:\s+$Sparse)*\s*\*+\s*\)/sg) {
1299 possible($1, "C:" . $s);
1302 # Check for any sort of function declaration.
1303 # int foo(something bar, other baz);
1304 # void (*store_gdt)(x86_descr_ptr *);
1305 if ($prev_values eq 'E' && $s =~ /^(.(?:typedef\s*)?(?:(?:$Storage|$Inline)\s*)*\s*$Type\s*(?:\b$Ident|\(\*\s*$Ident\))\s*)\(/s) {
1306 my ($name_len) = length($1);
1309 substr($ctx, 0, $name_len + 1, '');
1310 $ctx =~ s/\)[^\)]*$//;
1312 for my $arg (split(/\s*,\s*/, $ctx)) {
1313 if ($arg =~ /^(?:const\s+)?($Ident)(?:\s+$Sparse)*\s*\**\s*(:?\b$Ident)?$/s || $arg =~ /^($Ident)$/s) {
1315 possible($1, "D:" . $s);
1323 # Checks which may be anchored in the context.
1326 # Check for switch () and associated case and default
1327 # statements should be at the same indent.
1328 if ($line=~/\bswitch\s*\(.*\)/) {
1331 my @ctx = ctx_block_outer($linenr, $realcnt);
1333 for my $ctx (@ctx) {
1334 my ($clen, $cindent) = line_stats($ctx);
1335 if ($ctx =~ /^\+\s*(case\s+|default:)/ &&
1336 $indent != $cindent) {
1337 $err .= "$sep$ctx\n";
1344 ERROR("switch and case should be at the same indent\n$hereline$err");
1347 if ($line =~ /^.\s*(?:case\s*.*|default\s*):/g &&
1349 (?:\s*{)?(?:\s*$;*)(?:\s*\\)?\s*$|
1353 ERROR("trailing statements should be on next line\n" . $herecurr);
1356 # if/while/etc brace do not go on next line, unless defining a do while loop,
1357 # or if that brace on the next line is for something else
1358 if ($line =~ /(.*)\b((?:if|while|for|switch)\s*\(|do\b|else\b)/ && $line !~ /^.\s*\#/) {
1359 my $pre_ctx = "$1$2";
1361 my ($level, @ctx) = ctx_statement_level($linenr, $realcnt, 0);
1362 my $ctx_cnt = $realcnt - $#ctx - 1;
1363 my $ctx = join("\n", @ctx);
1365 my $ctx_ln = $linenr;
1366 my $ctx_skip = $realcnt;
1368 while ($ctx_skip > $ctx_cnt || ($ctx_skip == $ctx_cnt &&
1369 defined $lines[$ctx_ln - 1] &&
1370 $lines[$ctx_ln - 1] =~ /^-/)) {
1371 ##print "SKIP<$ctx_skip> CNT<$ctx_cnt>\n";
1372 $ctx_skip-- if (!defined $lines[$ctx_ln - 1] || $lines[$ctx_ln - 1] !~ /^-/);
1376 #print "realcnt<$realcnt> ctx_cnt<$ctx_cnt>\n";
1377 #print "pre<$pre_ctx>\nline<$line>\nctx<$ctx>\nnext<$lines[$ctx_ln - 1]>\n";
1379 if ($ctx !~ /{\s*/ && defined($lines[$ctx_ln -1]) && $lines[$ctx_ln - 1] =~ /^\+\s*{/) {
1380 ERROR("that open brace { should be on the previous line\n" .
1381 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1383 if ($level == 0 && $pre_ctx !~ /}\s*while\s*\($/ &&
1384 $ctx =~ /\)\s*\;\s*$/ &&
1385 defined $lines[$ctx_ln - 1])
1387 my ($nlength, $nindent) = line_stats($lines[$ctx_ln - 1]);
1388 if ($nindent > $indent) {
1389 WARN("trailing semicolon indicates no statements, indent implies otherwise\n" .
1390 "$here\n$ctx\n$lines[$ctx_ln - 1]\n");
1395 # Track the 'values' across context and added lines.
1396 my $opline = $line; $opline =~ s/^./ /;
1397 my ($curr_values, $curr_vars) =
1398 annotate_values($opline . "\n", $prev_values);
1399 $curr_values = $prev_values . $curr_values;
1401 my $outline = $opline; $outline =~ s/\t/ /g;
1402 print "$linenr > .$outline\n";
1403 print "$linenr > $curr_values\n";
1404 print "$linenr > $curr_vars\n";
1406 $prev_values = substr($curr_values, -1);
1408 #ignore lines not being added
1409 if ($line=~/^[^\+]/) {next;}
1411 # TEST: allow direct testing of the type matcher.
1413 if ($line =~ /^.\s*$Declare\s*$/) {
1414 ERROR("TEST: is type\n" . $herecurr);
1415 } elsif ($dbg_type > 1 && $line =~ /^.+($Declare)/) {
1416 ERROR("TEST: is not type ($1 is)\n". $herecurr);
1420 # TEST: allow direct testing of the attribute matcher.
1422 if ($line =~ /^.\s*$Attribute\s*$/) {
1423 ERROR("TEST: is attr\n" . $herecurr);
1424 } elsif ($dbg_attr > 1 && $line =~ /^.+($Attribute)/) {
1425 ERROR("TEST: is not attr ($1 is)\n". $herecurr);
1430 # check for initialisation to aggregates open brace on the next line
1431 if ($prevline =~ /$Declare\s*$Ident\s*=\s*$/ &&
1432 $line =~ /^.\s*{/) {
1433 ERROR("that open brace { should be on the previous line\n" . $hereprev);
1437 # Checks which are anchored on the added line.
1440 # check for malformed paths in #include statements (uses RAW line)
1441 if ($rawline =~ m{^.\s*\#\s*include\s+[<"](.*)[">]}) {
1443 if ($path =~ m{//}) {
1444 ERROR("malformed #include filename\n" .
1449 # no C99 // comments
1450 if ($line =~ m{//}) {
1451 ERROR("do not use C99 // comments\n" . $herecurr);
1453 # Remove C99 comments.
1455 $opline =~ s@//.*@@;
1457 #EXPORT_SYMBOL should immediately follow its function closing }.
1458 if (($line =~ /EXPORT_SYMBOL.*\((.*)\)/) ||
1459 ($line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
1461 if (($prevline !~ /^}/) &&
1462 ($prevline !~ /^\+}/) &&
1463 ($prevline !~ /^ }/) &&
1464 ($prevline !~ /^.DECLARE_$Ident\(\Q$name\E\)/) &&
1465 ($prevline !~ /^.LIST_HEAD\(\Q$name\E\)/) &&
1466 ($prevline !~ /^.$Type\s*\(\s*\*\s*\Q$name\E\s*\)\s*\(/) &&
1467 ($prevline !~ /\b\Q$name\E(?:\s+$Attribute)?\s*(?:;|=|\[)/)) {
1468 WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
1472 # check for external initialisers.
1473 if ($line =~ /^.$Type\s*$Ident\s*(?:\s+$Modifier)*\s*=\s*(0|NULL|false)\s*;/) {
1474 ERROR("do not initialise externals to 0 or NULL\n" .
1477 # check for static initialisers.
1478 if ($line =~ /\s*static\s.*=\s*(0|NULL|false)\s*;/) {
1479 ERROR("do not initialise statics to 0 or NULL\n" .
1483 # check for new typedefs, only function parameters and sparse annotations
1485 if ($line =~ /\btypedef\s/ &&
1486 $line !~ /\btypedef\s+$Type\s+\(\s*\*?$Ident\s*\)\s*\(/ &&
1487 $line !~ /\btypedef\s+$Type\s+$Ident\s*\(/ &&
1488 $line !~ /\b__bitwise(?:__|)\b/) {
1489 WARN("do not add new typedefs\n" . $herecurr);
1492 # * goes on variable not on type
1493 if ($line =~ m{\($NonptrType(\*+)(?:\s+const)?\)}) {
1494 ERROR("\"(foo$1)\" should be \"(foo $1)\"\n" .
1497 } elsif ($line =~ m{\($NonptrType\s+(\*+)(?!\s+const)\s+\)}) {
1498 ERROR("\"(foo $1 )\" should be \"(foo $1)\"\n" .
1501 } elsif ($line =~ m{\b$NonptrType(\*+)(?:\s+(?:$Attribute|$Sparse))?\s+[A-Za-z\d_]+}) {
1502 ERROR("\"foo$1 bar\" should be \"foo $1bar\"\n" .
1505 } elsif ($line =~ m{\b$NonptrType\s+(\*+)(?!\s+(?:$Attribute|$Sparse))\s+[A-Za-z\d_]+}) {
1506 ERROR("\"foo $1 bar\" should be \"foo $1bar\"\n" .
1510 # # no BUG() or BUG_ON()
1511 # if ($line =~ /\b(BUG|BUG_ON)\b/) {
1512 # print "Try to use WARN_ON & Recovery code rather than BUG() or BUG_ON()\n";
1513 # print "$herecurr";
1517 if ($line =~ /\bLINUX_VERSION_CODE\b/) {
1518 WARN("LINUX_VERSION_CODE should be avoided, code should be for the version to which it is merged\n" . $herecurr);
1521 # printk should use KERN_* levels. Note that follow on printk's on the
1522 # same line do not need a level, so we use the current block context
1523 # to try and find and validate the current printk. In summary the current
1524 # printk includes all preceeding printk's which have no newline on the end.
1525 # we assume the first bad printk is the one to report.
1526 if ($line =~ /\bprintk\((?!KERN_)\s*"/) {
1528 for (my $ln = $linenr - 1; $ln >= $first_line; $ln--) {
1529 #print "CHECK<$lines[$ln - 1]\n";
1530 # we have a preceeding printk if it ends
1531 # with "\n" ignore it, else it is to blame
1532 if ($lines[$ln - 1] =~ m{\bprintk\(}) {
1533 if ($rawlines[$ln - 1] !~ m{\\n"}) {
1540 WARN("printk() should include KERN_ facility level\n" . $herecurr);
1544 # function brace can't be on same line, except for #defines of do while,
1545 # or if closed on same line
1546 if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
1547 !($line=~/\#\s*define.*do\s{/) and !($line=~/}/)) {
1548 ERROR("open brace '{' following function declarations go on the next line\n" . $herecurr);
1551 # open braces for enum, union and struct go on the same line.
1552 if ($line =~ /^.\s*{/ &&
1553 $prevline =~ /^.\s*(?:typedef\s+)?(enum|union|struct)(?:\s+$Ident)?\s*$/) {
1554 ERROR("open brace '{' following $1 go on the same line\n" . $hereprev);
1557 # check for spacing round square brackets; allowed:
1558 # 1. with a type on the left -- int [] a;
1559 # 2. at the beginning of a line for slice initialisers -- [0...10] = 5,
1560 # 3. inside a curly brace -- = { [0...10] = 5 }
1561 while ($line =~ /(.*?\s)\[/g) {
1562 my ($where, $prefix) = ($-[1], $1);
1563 if ($prefix !~ /$Type\s+$/ &&
1564 ($where != 0 || $prefix !~ /^.\s+$/) &&
1565 $prefix !~ /{\s+$/) {
1566 ERROR("space prohibited before open square bracket '['\n" . $herecurr);
1570 # check for spaces between functions and their parentheses.
1571 while ($line =~ /($Ident)\s+\(/g) {
1573 my $ctx_before = substr($line, 0, $-[1]);
1574 my $ctx = "$ctx_before$name";
1576 # Ignore those directives where spaces _are_ permitted.
1578 if|for|while|switch|return|case|
1579 volatile|__volatile__|
1580 __attribute__|format|__extension__|
1584 # cpp #define statements have non-optional spaces, ie
1585 # if there is a space between the name and the open
1586 # parenthesis it is simply not a parameter group.
1587 } elsif ($ctx_before =~ /^.\s*\#\s*define\s*$/) {
1589 # cpp #elif statement condition may start with a (
1590 } elsif ($ctx =~ /^.\s*\#\s*elif\s*$/) {
1592 # If this whole things ends with a type its most
1593 # likely a typedef for a function.
1594 } elsif ($ctx =~ /$Type$/) {
1597 WARN("space prohibited between function name and open parenthesis '('\n" . $herecurr);
1600 # Check operator spacing.
1601 if (!($line=~/\#\s*include/)) {
1603 <<=|>>=|<=|>=|==|!=|
1604 \+=|-=|\*=|\/=|%=|\^=|\|=|&=|
1605 =>|->|<<|>>|<|>|=|!|~|
1606 &&|\|\||,|\^|\+\+|--|&|\||\+|-|\*|\/|%|
1609 my @elements = split(/($ops|;)/, $opline);
1612 my $blank = copy_spacing($opline);
1614 for (my $n = 0; $n < $#elements; $n += 2) {
1615 $off += length($elements[$n]);
1617 # Pick up the preceeding and succeeding characters.
1618 my $ca = substr($opline, 0, $off);
1620 if (length($opline) >= ($off + length($elements[$n + 1]))) {
1621 $cc = substr($opline, $off + length($elements[$n + 1]));
1623 my $cb = "$ca$;$cc";
1626 $a = 'V' if ($elements[$n] ne '');
1627 $a = 'W' if ($elements[$n] =~ /\s$/);
1628 $a = 'C' if ($elements[$n] =~ /$;$/);
1629 $a = 'B' if ($elements[$n] =~ /(\[|\()$/);
1630 $a = 'O' if ($elements[$n] eq '');
1631 $a = 'E' if ($ca =~ /^\s*$/);
1633 my $op = $elements[$n + 1];
1636 if (defined $elements[$n + 2]) {
1637 $c = 'V' if ($elements[$n + 2] ne '');
1638 $c = 'W' if ($elements[$n + 2] =~ /^\s/);
1639 $c = 'C' if ($elements[$n + 2] =~ /^$;/);
1640 $c = 'B' if ($elements[$n + 2] =~ /^(\)|\]|;)/);
1641 $c = 'O' if ($elements[$n + 2] eq '');
1642 $c = 'E' if ($elements[$n + 2] =~ /\s*\\$/);
1647 my $ctx = "${a}x${c}";
1649 my $at = "(ctx:$ctx)";
1651 my $ptr = substr($blank, 0, $off) . "^";
1652 my $hereptr = "$hereline$ptr\n";
1654 # Pull out the value of this operator.
1655 my $op_type = substr($curr_values, $off + 1, 1);
1657 # Get the full operator variant.
1658 my $opv = $op . substr($curr_vars, $off, 1);
1660 # Ignore operators passed as parameters.
1661 if ($op_type ne 'V' &&
1662 $ca =~ /\s$/ && $cc =~ /^\s*,/) {
1665 # } elsif ($op =~ /^$;+$/) {
1667 # ; should have either the end of line or a space or \ after it
1668 } elsif ($op eq ';') {
1669 if ($ctx !~ /.x[WEBC]/ &&
1670 $cc !~ /^\\/ && $cc !~ /^;/) {
1671 ERROR("space required after that '$op' $at\n" . $hereptr);
1675 } elsif ($op eq '//') {
1679 # : when part of a bitfield
1680 } elsif ($op eq '->' || $opv eq ':B') {
1681 if ($ctx =~ /Wx.|.xW/) {
1682 ERROR("spaces prohibited around that '$op' $at\n" . $hereptr);
1685 # , must have a space on the right.
1686 } elsif ($op eq ',') {
1687 if ($ctx !~ /.x[WEC]/ && $cc !~ /^}/) {
1688 ERROR("space required after that '$op' $at\n" . $hereptr);
1691 # '*' as part of a type definition -- reported already.
1692 } elsif ($opv eq '*_') {
1693 #warn "'*' is part of type\n";
1695 # unary operators should have a space before and
1696 # none after. May be left adjacent to another
1697 # unary operator, or a cast
1698 } elsif ($op eq '!' || $op eq '~' ||
1699 $opv eq '*U' || $opv eq '-U' ||
1700 $opv eq '&U' || $opv eq '&&U') {
1701 if ($ctx !~ /[WEBC]x./ && $ca !~ /(?:\)|!|~|\*|-|\&|\||\+\+|\-\-|\{)$/) {
1702 ERROR("space required before that '$op' $at\n" . $hereptr);
1704 if ($op eq '*' && $cc =~/\s*const\b/) {
1705 # A unary '*' may be const
1707 } elsif ($ctx =~ /.xW/) {
1708 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1711 # unary ++ and unary -- are allowed no space on one side.
1712 } elsif ($op eq '++' or $op eq '--') {
1713 if ($ctx !~ /[WEOBC]x[^W]/ && $ctx !~ /[^W]x[WOBEC]/) {
1714 ERROR("space required one side of that '$op' $at\n" . $hereptr);
1716 if ($ctx =~ /Wx[BE]/ ||
1717 ($ctx =~ /Wx./ && $cc =~ /^;/)) {
1718 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
1720 if ($ctx =~ /ExW/) {
1721 ERROR("space prohibited after that '$op' $at\n" . $hereptr);
1725 # << and >> may either have or not have spaces both sides
1726 } elsif ($op eq '<<' or $op eq '>>' or
1727 $op eq '&' or $op eq '^' or $op eq '|' or
1728 $op eq '+' or $op eq '-' or
1729 $op eq '*' or $op eq '/' or
1732 if ($ctx =~ /Wx[^WCE]|[^WCE]xW/) {
1733 ERROR("need consistent spacing around '$op' $at\n" .
1737 # A colon needs no spaces before when it is
1738 # terminating a case value or a label.
1739 } elsif ($opv eq ':C' || $opv eq ':L') {
1740 if ($ctx =~ /Wx./) {
1741 ERROR("space prohibited before that '$op' $at\n" . $hereptr);
1744 # All the others need spaces both sides.
1745 } elsif ($ctx !~ /[EWC]x[CWE]/) {
1748 # Ignore email addresses <foo@bar>
1750 $cc =~ /^\S+\@\S+>/) ||
1752 $ca =~ /<\S+\@\S+$/))
1758 if (($opv eq ':O' && $ca =~ /\?$/) ||
1759 ($op eq '?' && $cc =~ /^:/)) {
1764 ERROR("spaces required around that '$op' $at\n" . $hereptr);
1767 $off += length($elements[$n + 1]);
1771 # check for multiple assignments
1772 if ($line =~ /^.\s*$Lval\s*=\s*$Lval\s*=(?!=)/) {
1773 CHK("multiple assignments should be avoided\n" . $herecurr);
1776 ## # check for multiple declarations, allowing for a function declaration
1778 ## if ($line =~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Ident.*/ &&
1779 ## $line !~ /^.\s*$Type\s+$Ident(?:\s*=[^,{]*)?\s*,\s*$Type\s*$Ident.*/) {
1781 ## # Remove any bracketed sections to ensure we do not
1782 ## # falsly report the parameters of functions.
1784 ## while ($ln =~ s/\([^\(\)]*\)//g) {
1786 ## if ($ln =~ /,/) {
1787 ## WARN("declaring multiple variables together should be avoided\n" . $herecurr);
1791 #need space before brace following if, while, etc
1792 if (($line =~ /\(.*\){/ && $line !~ /\($Type\){/) ||
1794 ERROR("space required before the open brace '{'\n" . $herecurr);
1797 # closing brace should have a space following it when it has anything
1799 if ($line =~ /}(?!(?:,|;|\)))\S/) {
1800 ERROR("space required after that close brace '}'\n" . $herecurr);
1803 # check spacing on square brackets
1804 if ($line =~ /\[\s/ && $line !~ /\[\s*$/) {
1805 ERROR("space prohibited after that open square bracket '['\n" . $herecurr);
1807 if ($line =~ /\s\]/) {
1808 ERROR("space prohibited before that close square bracket ']'\n" . $herecurr);
1811 # check spacing on parentheses
1812 if ($line =~ /\(\s/ && $line !~ /\(\s*(?:\\)?$/ &&
1813 $line !~ /for\s*\(\s+;/) {
1814 ERROR("space prohibited after that open parenthesis '('\n" . $herecurr);
1816 if ($line =~ /(\s+)\)/ && $line !~ /^.\s*\)/ &&
1817 $line !~ /for\s*\(.*;\s+\)/ &&
1818 $line !~ /:\s+\)/) {
1819 ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr);
1822 #goto labels aren't indented, allow a single space however
1823 if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and
1824 !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) {
1825 WARN("labels should not be indented\n" . $herecurr);
1828 # Return is not a function.
1829 if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) {
1833 # Flatten any parentheses and braces
1834 $value =~ s/\)\(/\) \(/g;
1835 while ($value =~ s/\([^\(\)]*\)/1/) {
1838 if ($value =~ /^(?:$Ident|-?$Constant)$/) {
1839 ERROR("return is not a function, parentheses are not required\n" . $herecurr);
1841 } elsif ($spacing !~ /\s+/) {
1842 ERROR("space required before the open parenthesis '('\n" . $herecurr);
1846 # Need a space before open parenthesis after if, while etc
1847 if ($line=~/\b(if|while|for|switch)\(/) {
1848 ERROR("space required before the open parenthesis '('\n" . $herecurr);
1851 # Check for illegal assignment in if conditional -- and check for trailing
1852 # statements after the conditional.
1853 if ($line =~ /\b(?:if|while|for)\s*\(/ && $line !~ /^.\s*#/) {
1854 my ($s, $c) = ($stat, $cond);
1856 if ($c =~ /\bif\s*\(.*[^<>!=]=[^=].*/) {
1857 ERROR("do not use assignment in if condition\n" . $herecurr);
1860 # Find out what is on the end of the line after the
1862 substr($s, 0, length($c), '');
1864 $s =~ s/$;//g; # Remove any comments
1865 if (length($c) && $s !~ /^\s*{?\s*\\*\s*$/ &&
1866 $c !~ /}\s*while\s*/)
1868 ERROR("trailing statements should be on next line\n" . $herecurr);
1872 # Check relative indent for conditionals and blocks.
1873 if ($line =~ /\b(?:(?:if|while|for)\s*\(|do\b)/ && $line !~ /^.\s*#/ && $line !~ /\}\s*while\s*/) {
1874 my ($s, $c) = ($stat, $cond);
1876 substr($s, 0, length($c), '');
1878 # Make sure we remove the line prefixes as we have
1879 # none on the first line, and are going to readd them
1883 # We want to check the first line inside the block
1884 # starting at the end of the conditional, so remove:
1885 # 1) any blank line termination
1886 # 2) any opening brace { on end of the line
1888 my $continuation = 0;
1890 $s =~ s/^.*\bdo\b//;
1892 if ($s =~ s/^\s*\\//) {
1895 if ($s =~ s/^\s*\n//) {
1899 # Also ignore a loop construct at the end of a
1900 # preprocessor statement.
1901 if (($prevline =~ /^.\s*#\s*define\s/ ||
1902 $prevline =~ /\\\s*$/) && $continuation == 0) {
1906 # Ignore the current line if its is a preprocessor
1908 if ($s =~ /^\s*#\s*/) {
1912 # Ignore the current line if it is label.
1913 if ($s =~ /^\s*$Ident\s*:/) {
1917 my (undef, $sindent) = line_stats("+" . $s);
1919 ##print "line<$line> prevline<$prevline> indent<$indent> sindent<$sindent> check<$check> continuation<$continuation> s<$s>\n";
1921 if ($check && (($sindent % 8) != 0 ||
1922 ($sindent <= $indent && $s ne ''))) {
1923 WARN("suspect code indent for conditional statements\n" . $herecurr);
1927 # Check for bitwise tests written as boolean
1939 WARN("boolean test with hexadecimal, perhaps just 1 \& or \|?\n" . $herecurr);
1942 # if and else should not have general statements after it
1943 if ($line =~ /^.\s*(?:}\s*)?else\b(.*)/) {
1945 $s =~ s/$;//g; # Remove any comments
1946 if ($s !~ /^\s*(?:\sif|(?:{|)\s*\\?\s*$)/) {
1947 ERROR("trailing statements should be on next line\n" . $herecurr);
1951 # Check for }<nl>else {, these must be at the same
1952 # indent level to be relevant to each other.
1953 if ($prevline=~/}\s*$/ and $line=~/^.\s*else\s*/ and
1954 $previndent == $indent) {
1955 ERROR("else should follow close brace '}'\n" . $hereprev);
1958 if ($prevline=~/}\s*$/ and $line=~/^.\s*while\s*/ and
1959 $previndent == $indent) {
1960 my ($s, $c) = ctx_statement_block($linenr, $realcnt, 0);
1962 # Find out what is on the end of the line after the
1964 substr($s, 0, length($c), '');
1967 if ($s =~ /^\s*;/) {
1968 ERROR("while should follow close brace '}'\n" . $hereprev);
1972 #studly caps, commented out until figure out how to distinguish between use of existing and adding new
1973 # if (($line=~/[\w_][a-z\d]+[A-Z]/) and !($line=~/print/)) {
1974 # print "No studly caps, use _\n";
1975 # print "$herecurr";
1979 #no spaces allowed after \ in define
1980 if ($line=~/\#\s*define.*\\\s$/) {
1981 WARN("Whitepspace after \\ makes next lines useless\n" . $herecurr);
1984 #warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line)
1985 if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
1987 my $checkfile = "include/linux/$file";
1988 if (-f "$root/$checkfile" &&
1989 $realfile ne $checkfile &&
1992 if ($realfile =~ m{^arch/}) {
1993 CHK("Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
1995 WARN("Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
2000 # multi-statement macros should be enclosed in a do while loop, grab the
2001 # first statement and ensure its the whole macro if its not enclosed
2002 # in a known good container
2003 if ($realfile !~ m@/vmlinux.lds.h$@ &&
2004 $line =~ /^.\s*\#\s*define\s*$Ident(\()?/) {
2007 my ($off, $dstat, $dcond, $rest);
2010 my $args = defined($1);
2012 # Find the end of the macro and limit our statement
2014 while ($cnt > 0 && defined $lines[$ln - 1] &&
2015 $lines[$ln - 1] =~ /^(?:-|..*\\$)/)
2017 $ctx .= $rawlines[$ln - 1] . "\n";
2018 $cnt-- if ($lines[$ln - 1] !~ /^-/);
2021 $ctx .= $rawlines[$ln - 1];
2023 ($dstat, $dcond, $ln, $cnt, $off) =
2024 ctx_statement_block($linenr, $ln - $linenr + 1, 0);
2025 #print "dstat<$dstat> dcond<$dcond> cnt<$cnt> off<$off>\n";
2026 #print "LINE<$lines[$ln-1]> len<" . length($lines[$ln-1]) . "\n";
2028 # Extract the remainder of the define (if any) and
2029 # rip off surrounding spaces, and trailing \'s.
2031 while ($off != 0 || ($cnt > 0 && $rest =~ /\\\s*$/)) {
2032 #print "ADDING cnt<$cnt> $off <" . substr($lines[$ln - 1], $off) . "> rest<$rest>\n";
2033 if ($off != 0 || $lines[$ln - 1] !~ /^-/) {
2034 $rest .= substr($lines[$ln - 1], $off) . "\n";
2040 $rest =~ s/\\\n.//g;
2044 # Clean up the original statement.
2046 substr($dstat, 0, length($dcond), '');
2048 $dstat =~ s/^.\s*\#\s*define\s+$Ident\s*//;
2051 $dstat =~ s/\\\n.//g;
2052 $dstat =~ s/^\s*//s;
2053 $dstat =~ s/\s*$//s;
2055 # Flatten any parentheses and braces
2056 while ($dstat =~ s/\([^\(\)]*\)/1/) {
2058 while ($dstat =~ s/\{[^\{\}]*\}/1/) {
2061 my $exceptions = qr{
2069 #print "REST<$rest>\n";
2071 if ($rest !~ /while\s*\(/ &&
2072 $dstat !~ /$exceptions/)
2074 ERROR("Macros with multiple statements should be enclosed in a do - while loop\n" . "$here\n$ctx\n");
2077 } elsif ($ctx !~ /;/) {
2079 $dstat !~ /^(?:$Ident|-?$Constant)$/ &&
2080 $dstat !~ /$exceptions/ &&
2081 $dstat =~ /$Operators/)
2083 ERROR("Macros with complex values should be enclosed in parenthesis\n" . "$here\n$ctx\n");
2088 # check for redundant bracing round if etc
2089 if ($line =~ /(^.*)\bif\b/ && $1 !~ /else\s*$/) {
2090 my ($level, $endln, @chunks) =
2091 ctx_statement_full($linenr, $realcnt, 1);
2092 #print "chunks<$#chunks> linenr<$linenr> endln<$endln> level<$level>\n";
2093 #print "APW: <<$chunks[1][0]>><<$chunks[1][1]>>\n";
2094 if ($#chunks > 0 && $level == 0) {
2097 my $herectx = $here . "\n";
2098 my $ln = $linenr - 1;
2099 for my $chunk (@chunks) {
2100 my ($cond, $block) = @{$chunk};
2102 # If the condition carries leading newlines, then count those as offsets.
2103 my ($whitespace) = ($cond =~ /^((?:\s*\n[+-])*\s*)/s);
2104 my $offset = statement_rawlines($whitespace) - 1;
2106 #print "COND<$cond> whitespace<$whitespace> offset<$offset>\n";
2108 # We have looked at and allowed this specific line.
2109 $suppress_ifbraces{$ln + $offset} = 1;
2111 $herectx .= "$rawlines[$ln + $offset]\n[...]\n";
2112 $ln += statement_rawlines($block) - 1;
2114 substr($block, 0, length($cond), '');
2116 $seen++ if ($block =~ /^\s*{/);
2118 #print "cond<$cond> block<$block> allowed<$allowed>\n";
2119 if (statement_lines($cond) > 1) {
2120 #print "APW: ALLOWED: cond<$cond>\n";
2123 if ($block =~/\b(?:if|for|while)\b/) {
2124 #print "APW: ALLOWED: block<$block>\n";
2127 if (statement_block_size($block) > 1) {
2128 #print "APW: ALLOWED: lines block<$block>\n";
2132 if ($seen && !$allowed) {
2133 WARN("braces {} are not necessary for any arm of this statement\n" . $herectx);
2137 if (!defined $suppress_ifbraces{$linenr - 1} &&
2138 $line =~ /\b(if|while|for|else)\b/) {
2141 # Check the pre-context.
2142 if (substr($line, 0, $-[0]) =~ /(\}\s*)$/) {
2143 #print "APW: ALLOWED: pre<$1>\n";
2147 my ($level, $endln, @chunks) =
2148 ctx_statement_full($linenr, $realcnt, $-[0]);
2150 # Check the condition.
2151 my ($cond, $block) = @{$chunks[0]};
2152 #print "CHECKING<$linenr> cond<$cond> block<$block>\n";
2153 if (defined $cond) {
2154 substr($block, 0, length($cond), '');
2156 if (statement_lines($cond) > 1) {
2157 #print "APW: ALLOWED: cond<$cond>\n";
2160 if ($block =~/\b(?:if|for|while)\b/) {
2161 #print "APW: ALLOWED: block<$block>\n";
2164 if (statement_block_size($block) > 1) {
2165 #print "APW: ALLOWED: lines block<$block>\n";
2168 # Check the post-context.
2169 if (defined $chunks[1]) {
2170 my ($cond, $block) = @{$chunks[1]};
2171 if (defined $cond) {
2172 substr($block, 0, length($cond), '');
2174 if ($block =~ /^\s*\{/) {
2175 #print "APW: ALLOWED: chunk-1 block<$block>\n";
2179 if ($level == 0 && $block =~ /^\s*\{/ && !$allowed) {
2180 my $herectx = $here . "\n";;
2181 my $end = $linenr + statement_rawlines($block) - 1;
2183 for (my $ln = $linenr - 1; $ln < $end; $ln++) {
2184 $herectx .= $rawlines[$ln] . "\n";;
2187 WARN("braces {} are not necessary for single statement blocks\n" . $herectx);
2191 # don't include deprecated include files (uses RAW line)
2192 for my $inc (@dep_includes) {
2193 if ($rawline =~ m@^.\s*\#\s*include\s*\<$inc>@) {
2194 ERROR("Don't use <$inc>: see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2198 # don't use deprecated functions
2199 for my $func (@dep_functions) {
2200 if ($line =~ /\b$func\b/) {
2201 ERROR("Don't use $func(): see Documentation/feature-removal-schedule.txt\n" . $herecurr);
2205 # no volatiles please
2206 my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
2207 if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
2208 WARN("Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
2211 # SPIN_LOCK_UNLOCKED & RW_LOCK_UNLOCKED are deprecated
2212 if ($line =~ /\b(SPIN_LOCK_UNLOCKED|RW_LOCK_UNLOCKED)/) {
2213 ERROR("Use of $1 is deprecated: see Documentation/spinlocks.txt\n" . $herecurr);
2217 if ($line =~ /^.\s*\#\s*if\s+0\b/) {
2218 CHK("if this code is redundant consider removing it\n" .
2222 # check for needless kfree() checks
2223 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2225 if ($line =~ /\bkfree\(\Q$expr\E\);/) {
2226 WARN("kfree(NULL) is safe this check is probably not required\n" . $hereprev);
2229 # check for needless usb_free_urb() checks
2230 if ($prevline =~ /\bif\s*\(([^\)]*)\)/) {
2232 if ($line =~ /\busb_free_urb\(\Q$expr\E\);/) {
2233 WARN("usb_free_urb(NULL) is safe this check is probably not required\n" . $hereprev);
2237 # warn about #ifdefs in C files
2238 # if ($line =~ /^.\s*\#\s*if(|n)def/ && ($realfile =~ /\.c$/)) {
2239 # print "#ifdef in C files should be avoided\n";
2240 # print "$herecurr";
2244 # warn about spacing in #ifdefs
2245 if ($line =~ /^.\s*\#\s*(ifdef|ifndef|elif)\s\s+/) {
2246 ERROR("exactly one space required after that #$1\n" . $herecurr);
2249 # check for spinlock_t definitions without a comment.
2250 if ($line =~ /^.\s*(struct\s+mutex|spinlock_t)\s+\S+;/ ||
2251 $line =~ /^.\s*(DEFINE_MUTEX)\s*\(/) {
2253 if (!ctx_has_comment($first_line, $linenr)) {
2254 CHK("$1 definition without comment\n" . $herecurr);
2257 # check for memory barriers without a comment.
2258 if ($line =~ /\b(mb|rmb|wmb|read_barrier_depends|smp_mb|smp_rmb|smp_wmb|smp_read_barrier_depends)\(/) {
2259 if (!ctx_has_comment($first_line, $linenr)) {
2260 CHK("memory barrier without comment\n" . $herecurr);
2263 # check of hardware specific defines
2264 if ($line =~ m@^.\s*\#\s*if.*\b(__i386__|__powerpc64__|__sun__|__s390x__)\b@ && $realfile !~ m@include/asm-@) {
2265 CHK("architecture specific defines should be avoided\n" . $herecurr);
2268 # check the location of the inline attribute, that it is between
2269 # storage class and type.
2270 if ($line =~ /\b$Type\s+$Inline\b/ ||
2271 $line =~ /\b$Inline\s+$Storage\b/) {
2272 ERROR("inline keyword should sit between storage class and type\n" . $herecurr);
2275 # Check for __inline__ and __inline, prefer inline
2276 if ($line =~ /\b(__inline__|__inline)\b/) {
2277 WARN("plain inline is preferred over $1\n" . $herecurr);
2280 # check for new externs in .c files.
2281 if ($realfile =~ /\.c$/ && defined $stat &&
2282 $stat =~ /^.\s*(?:extern\s+)?$Type\s+($Ident)(\s*)\(/s)
2284 my $function_name = $1;
2285 my $paren_space = $2;
2288 if (defined $cond) {
2289 substr($s, 0, length($cond), '');
2291 if ($s =~ /^\s*;/ &&
2292 $function_name ne 'uninitialized_var')
2294 WARN("externs should be avoided in .c files\n" . $herecurr);
2297 if ($paren_space =~ /\n/) {
2298 WARN("arguments for function declarations should follow identifier\n" . $herecurr);
2301 } elsif ($realfile =~ /\.c$/ && defined $stat &&
2302 $stat =~ /^.\s*extern\s+/)
2304 WARN("externs should be avoided in .c files\n" . $herecurr);
2307 # checks for new __setup's
2308 if ($rawline =~ /\b__setup\("([^"]*)"/) {
2311 if (!grep(/$name/, @setup_docs)) {
2312 CHK("__setup appears un-documented -- check Documentation/kernel-parameters.txt\n" . $herecurr);
2316 # check for pointless casting of kmalloc return
2317 if ($line =~ /\*\s*\)\s*k[czm]alloc\b/) {
2318 WARN("unnecessary cast may hide bugs, see http://c-faq.com/malloc/mallocnocast.html\n" . $herecurr);
2321 # check for gcc specific __FUNCTION__
2322 if ($line =~ /__FUNCTION__/) {
2323 WARN("__func__ should be used instead of gcc specific __FUNCTION__\n" . $herecurr);
2326 # check for semaphores used as mutexes
2327 if ($line =~ /^.\s*(DECLARE_MUTEX|init_MUTEX)\s*\(/) {
2328 WARN("mutexes are preferred for single holder semaphores\n" . $herecurr);
2330 # check for semaphores used as mutexes
2331 if ($line =~ /^.\s*init_MUTEX_LOCKED\s*\(/) {
2332 WARN("consider using a completion\n" . $herecurr);
2334 # recommend strict_strto* over simple_strto*
2335 if ($line =~ /\bsimple_(strto.*?)\s*\(/) {
2336 WARN("consider using strict_$1 in preference to simple_$1\n" . $herecurr);
2338 # check for __initcall(), use device_initcall() explicitly please
2339 if ($line =~ /^.\s*__initcall\s*\(/) {
2340 WARN("please use device_initcall() instead of __initcall()\n" . $herecurr);
2343 # use of NR_CPUS is usually wrong
2344 # ignore definitions of NR_CPUS and usage to define arrays as likely right
2345 if ($line =~ /\bNR_CPUS\b/ &&
2346 $line !~ /^.\s*\s*#\s*if\b.*\bNR_CPUS\b/ &&
2347 $line !~ /^.\s*\s*#\s*define\b.*\bNR_CPUS\b/ &&
2348 $line !~ /^.\s*$Declare\s.*\[[^\]]*NR_CPUS[^\]]*\]/ &&
2349 $line !~ /\[[^\]]*\.\.\.[^\]]*NR_CPUS[^\]]*\]/ &&
2350 $line !~ /\[[^\]]*NR_CPUS[^\]]*\.\.\.[^\]]*\]/)
2352 WARN("usage of NR_CPUS is often wrong - consider using cpu_possible(), num_possible_cpus(), for_each_possible_cpu(), etc\n" . $herecurr);
2355 # check for %L{u,d,i} in strings
2357 while ($line =~ /(?:^|")([X\t]*)(?:"|$)/g) {
2358 $string = substr($rawline, $-[1], $+[1] - $-[1]);
2359 if ($string =~ /(?<!%)%L[udi]/) {
2360 WARN("\%Ld/%Lu are not-standard C, use %lld/%llu\n" . $herecurr);
2366 # If we have no input at all, then there is nothing to report on
2367 # so just keep quiet.
2368 if ($#rawlines == -1) {
2372 # In mailback mode only produce a report in the negative, for
2373 # things that appear to be patches.
2374 if ($mailback && ($clean == 1 || !$is_patch)) {
2378 # This is not a patch, and we are are in 'no-patch' mode so
2380 if (!$chk_patch && !$is_patch) {
2385 ERROR("Does not appear to be a unified-diff format patch\n");
2387 if ($is_patch && $chk_signoff && $signoff == 0) {
2388 ERROR("Missing Signed-off-by: line(s)\n");
2391 print report_dump();
2392 if ($summary && !($clean == 1 && $quiet == 1)) {
2393 print "$filename " if ($summary_file);
2394 print "total: $cnt_error errors, $cnt_warn warnings, " .
2395 (($check)? "$cnt_chk checks, " : "") .
2396 "$cnt_lines lines checked\n";
2397 print "\n" if ($quiet == 0);
2400 if ($clean == 1 && $quiet == 0) {
2401 print "$vname has no obvious style problems and is ready for submission.\n"
2403 if ($clean == 0 && $quiet == 0) {
2404 print "$vname has style problems, please review. If any of these errors\n";
2405 print "are false positives report them to the maintainer, see\n";
2406 print "CHECKPATCH in MAINTAINERS.\n";