]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/edac/mce_amd.c
Merge tag 'upstream-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik...
[karo-tx-linux.git] / drivers / edac / mce_amd.c
index ad637572d8c77420c6da8e213890adb4f077e2fe..f3f0c930d550ebb34509eb05dec7faf17c579151 100644 (file)
@@ -39,30 +39,28 @@ EXPORT_SYMBOL_GPL(amd_unregister_ecc_decoder);
  */
 
 /* transaction type */
-const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" };
-EXPORT_SYMBOL_GPL(tt_msgs);
+static const char * const tt_msgs[] = { "INSN", "DATA", "GEN", "RESV" };
 
 /* cache level */
-const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" };
-EXPORT_SYMBOL_GPL(ll_msgs);
+static const char * const ll_msgs[] = { "RESV", "L1", "L2", "L3/GEN" };
 
 /* memory transaction type */
-const char * const rrrr_msgs[] = {
+static const char * const rrrr_msgs[] = {
        "GEN", "RD", "WR", "DRD", "DWR", "IRD", "PRF", "EV", "SNP"
 };
-EXPORT_SYMBOL_GPL(rrrr_msgs);
 
 /* participating processor */
 const char * const pp_msgs[] = { "SRC", "RES", "OBS", "GEN" };
 EXPORT_SYMBOL_GPL(pp_msgs);
 
 /* request timeout */
-const char * const to_msgs[] = { "no timeout", "timed out" };
-EXPORT_SYMBOL_GPL(to_msgs);
+static const char * const to_msgs[] = { "no timeout", "timed out" };
 
 /* memory or i/o */
-const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GEN" };
-EXPORT_SYMBOL_GPL(ii_msgs);
+static const char * const ii_msgs[] = { "MEM", "RESV", "IO", "GEN" };
+
+/* internal error type */
+static const char * const uu_msgs[] = { "RESV", "RESV", "HWA", "RESV" };
 
 static const char * const f15h_mc1_mce_desc[] = {
        "UC during a demand linefill from L2",
@@ -176,7 +174,7 @@ static bool k8_mc0_mce(u16 ec, u8 xec)
        return f10h_mc0_mce(ec, xec);
 }
 
-static bool f14h_mc0_mce(u16 ec, u8 xec)
+static bool cat_mc0_mce(u16 ec, u8 xec)
 {
        u8 r4    = R4(ec);
        bool ret = true;
@@ -330,22 +328,28 @@ static bool k8_mc1_mce(u16 ec, u8 xec)
        return ret;
 }
 
-static bool f14h_mc1_mce(u16 ec, u8 xec)
+static bool cat_mc1_mce(u16 ec, u8 xec)
 {
        u8 r4    = R4(ec);
        bool ret = true;
 
-       if (MEM_ERROR(ec)) {
-               if (TT(ec) != 0 || LL(ec) != 1)
-                       ret = false;
+       if (!MEM_ERROR(ec))
+               return false;
+
+       if (TT(ec) != TT_INSTR)
+               return false;
+
+       if (r4 == R4_IRD)
+               pr_cont("Data/tag array parity error for a tag hit.\n");
+       else if (r4 == R4_SNOOP)
+               pr_cont("Tag error during snoop/victimization.\n");
+       else if (xec == 0x0)
+               pr_cont("Tag parity error from victim castout.\n");
+       else if (xec == 0x2)
+               pr_cont("Microcode patch RAM parity error.\n");
+       else
+               ret = false;
 
-               if (r4 == R4_IRD)
-                       pr_cont("Data/tag array parity error for a tag hit.\n");
-               else if (r4 == R4_SNOOP)
-                       pr_cont("Tag error during snoop/victimization.\n");
-               else
-                       ret = false;
-       }
        return ret;
 }
 
@@ -399,12 +403,9 @@ static void decode_mc1_mce(struct mce *m)
                pr_emerg(HW_ERR "Corrupted MC1 MCE info?\n");
 }
 
-static void decode_mc2_mce(struct mce *m)
+static bool k8_mc2_mce(u16 ec, u8 xec)
 {
-       u16 ec = EC(m->status);
-       u8 xec = XEC(m->status, xec_mask);
-
-       pr_emerg(HW_ERR "MC2 Error");
+       bool ret = true;
 
        if (xec == 0x1)
                pr_cont(" in the write data buffers.\n");
@@ -429,24 +430,18 @@ static void decode_mc2_mce(struct mce *m)
                                pr_cont(": %s parity/ECC error during data "
                                        "access from L2.\n", R4_MSG(ec));
                        else
-                               goto wrong_mc2_mce;
+                               ret = false;
                } else
-                       goto wrong_mc2_mce;
+                       ret = false;
        } else
-               goto wrong_mc2_mce;
-
-       return;
+               ret = false;
 
- wrong_mc2_mce:
-       pr_emerg(HW_ERR "Corrupted MC2 MCE info?\n");
+       return ret;
 }
 
-static void decode_f15_mc2_mce(struct mce *m)
+static bool f15h_mc2_mce(u16 ec, u8 xec)
 {
-       u16 ec = EC(m->status);
-       u8 xec = XEC(m->status, xec_mask);
-
-       pr_emerg(HW_ERR "MC2 Error: ");
+       bool ret = true;
 
        if (TLB_ERROR(ec)) {
                if (xec == 0x0)
@@ -454,10 +449,10 @@ static void decode_f15_mc2_mce(struct mce *m)
                else if (xec == 0x1)
                        pr_cont("Poison data provided for TLB fill.\n");
                else
-                       goto wrong_f15_mc2_mce;
+                       ret = false;
        } else if (BUS_ERROR(ec)) {
                if (xec > 2)
-                       goto wrong_f15_mc2_mce;
+                       ret = false;
 
                pr_cont("Error during attempted NB data read.\n");
        } else if (MEM_ERROR(ec)) {
@@ -471,14 +466,63 @@ static void decode_f15_mc2_mce(struct mce *m)
                        break;
 
                default:
-                       goto wrong_f15_mc2_mce;
+                       ret = false;
                }
        }
 
-       return;
+       return ret;
+}
 
- wrong_f15_mc2_mce:
-       pr_emerg(HW_ERR "Corrupted MC2 MCE info?\n");
+static bool f16h_mc2_mce(u16 ec, u8 xec)
+{
+       u8 r4 = R4(ec);
+
+       if (!MEM_ERROR(ec))
+               return false;
+
+       switch (xec) {
+       case 0x04 ... 0x05:
+               pr_cont("%cBUFF parity error.\n", (r4 == R4_RD) ? 'I' : 'O');
+               break;
+
+       case 0x09 ... 0x0b:
+       case 0x0d ... 0x0f:
+               pr_cont("ECC error in L2 tag (%s).\n",
+                       ((r4 == R4_GEN)   ? "BankReq" :
+                       ((r4 == R4_SNOOP) ? "Prb"     : "Fill")));
+               break;
+
+       case 0x10 ... 0x19:
+       case 0x1b:
+               pr_cont("ECC error in L2 data array (%s).\n",
+                       (((r4 == R4_RD) && !(xec & 0x3)) ? "Hit"  :
+                       ((r4 == R4_GEN)   ? "Attr" :
+                       ((r4 == R4_EVICT) ? "Vict" : "Fill"))));
+               break;
+
+       case 0x1c ... 0x1d:
+       case 0x1f:
+               pr_cont("Parity error in L2 attribute bits (%s).\n",
+                       ((r4 == R4_RD)  ? "Hit"  :
+                       ((r4 == R4_GEN) ? "Attr" : "Fill")));
+               break;
+
+       default:
+               return false;
+       }
+
+       return true;
+}
+
+static void decode_mc2_mce(struct mce *m)
+{
+       u16 ec = EC(m->status);
+       u8 xec = XEC(m->status, xec_mask);
+
+       pr_emerg(HW_ERR "MC2 Error: ");
+
+       if (!fam_ops->mc2_mce(ec, xec))
+               pr_cont(HW_ERR "Corrupted MC2 MCE info?\n");
 }
 
 static void decode_mc3_mce(struct mce *m)
@@ -547,7 +591,7 @@ static void decode_mc4_mce(struct mce *m)
                return;
 
        case 0x19:
-               if (boot_cpu_data.x86 == 0x15)
+               if (boot_cpu_data.x86 == 0x15 || boot_cpu_data.x86 == 0x16)
                        pr_cont("Compute Unit Data Error.\n");
                else
                        goto wrong_mc4_mce;
@@ -633,6 +677,10 @@ static void decode_mc6_mce(struct mce *m)
 
 static inline void amd_decode_err_code(u16 ec)
 {
+       if (INT_ERROR(ec)) {
+               pr_emerg(HW_ERR "internal: %s\n", UU_MSG(ec));
+               return;
+       }
 
        pr_emerg(HW_ERR "cache level: %s", LL_MSG(ec));
 
@@ -702,10 +750,7 @@ int amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
                break;
 
        case 2:
-               if (c->x86 == 0x15)
-                       decode_f15_mc2_mce(m);
-               else
-                       decode_mc2_mce(m);
+               decode_mc2_mce(m);
                break;
 
        case 3:
@@ -740,7 +785,7 @@ int amd_decode_mce(struct notifier_block *nb, unsigned long val, void *data)
                ((m->status & MCI_STATUS_PCC)   ? "PCC"   : "-"),
                ((m->status & MCI_STATUS_ADDRV) ? "AddrV" : "-"));
 
-       if (c->x86 == 0x15)
+       if (c->x86 == 0x15 || c->x86 == 0x16)
                pr_cont("|%s|%s",
                        ((m->status & MCI_STATUS_DEFERRED) ? "Deferred" : "-"),
                        ((m->status & MCI_STATUS_POISON)   ? "Poison"   : "-"));
@@ -772,7 +817,7 @@ static int __init mce_amd_init(void)
        if (c->x86_vendor != X86_VENDOR_AMD)
                return 0;
 
-       if (c->x86 < 0xf || c->x86 > 0x15)
+       if (c->x86 < 0xf || c->x86 > 0x16)
                return 0;
 
        fam_ops = kzalloc(sizeof(struct amd_decoder_ops), GFP_KERNEL);
@@ -783,33 +828,46 @@ static int __init mce_amd_init(void)
        case 0xf:
                fam_ops->mc0_mce = k8_mc0_mce;
                fam_ops->mc1_mce = k8_mc1_mce;
+               fam_ops->mc2_mce = k8_mc2_mce;
                break;
 
        case 0x10:
                fam_ops->mc0_mce = f10h_mc0_mce;
                fam_ops->mc1_mce = k8_mc1_mce;
+               fam_ops->mc2_mce = k8_mc2_mce;
                break;
 
        case 0x11:
                fam_ops->mc0_mce = k8_mc0_mce;
                fam_ops->mc1_mce = k8_mc1_mce;
+               fam_ops->mc2_mce = k8_mc2_mce;
                break;
 
        case 0x12:
                fam_ops->mc0_mce = f12h_mc0_mce;
                fam_ops->mc1_mce = k8_mc1_mce;
+               fam_ops->mc2_mce = k8_mc2_mce;
                break;
 
        case 0x14:
                nb_err_cpumask  = 0x3;
-               fam_ops->mc0_mce = f14h_mc0_mce;
-               fam_ops->mc1_mce = f14h_mc1_mce;
+               fam_ops->mc0_mce = cat_mc0_mce;
+               fam_ops->mc1_mce = cat_mc1_mce;
+               fam_ops->mc2_mce = k8_mc2_mce;
                break;
 
        case 0x15:
                xec_mask = 0x1f;
                fam_ops->mc0_mce = f15h_mc0_mce;
                fam_ops->mc1_mce = f15h_mc1_mce;
+               fam_ops->mc2_mce = f15h_mc2_mce;
+               break;
+
+       case 0x16:
+               xec_mask = 0x1f;
+               fam_ops->mc0_mce = cat_mc0_mce;
+               fam_ops->mc1_mce = cat_mc1_mce;
+               fam_ops->mc2_mce = f16h_mc2_mce;
                break;
 
        default: