]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/gpu/drm/nouveau/nv50_display.c
drm/nouveau/kms/nv50: fix atomic regression on original G80
[karo-tx-linux.git] / drivers / gpu / drm / nouveau / nv50_display.c
index 7d0edcbcfca7794b9f05c55dd3184ee3ebf90f2f..2c2c645076614b4f9c187d24a5e9d2667ea27778 100644 (file)
 #include <linux/dma-mapping.h>
 
 #include <drm/drmP.h>
+#include <drm/drm_atomic.h>
+#include <drm/drm_atomic_helper.h>
 #include <drm/drm_crtc_helper.h>
-#include <drm/drm_plane_helper.h>
 #include <drm/drm_dp_helper.h>
 #include <drm/drm_fb_helper.h>
+#include <drm/drm_plane_helper.h>
 
 #include <nvif/class.h>
 #include <nvif/cl0002.h>
@@ -38,6 +40,7 @@
 #include <nvif/cl507c.h>
 #include <nvif/cl507d.h>
 #include <nvif/cl507e.h>
+#include <nvif/event.h>
 
 #include "nouveau_drv.h"
 #include "nouveau_dma.h"
@@ -46,6 +49,7 @@
 #include "nouveau_encoder.h"
 #include "nouveau_crtc.h"
 #include "nouveau_fence.h"
+#include "nouveau_fbcon.h"
 #include "nv50_display.h"
 
 #define EVO_DMA_NR 9
 #define EVO_MAST_NTFY     EVO_SYNC(      0, 0x00)
 #define EVO_FLIP_SEM0(c)  EVO_SYNC((c) + 1, 0x00)
 #define EVO_FLIP_SEM1(c)  EVO_SYNC((c) + 1, 0x10)
+#define EVO_FLIP_NTFY0(c) EVO_SYNC((c) + 1, 0x20)
+#define EVO_FLIP_NTFY1(c) EVO_SYNC((c) + 1, 0x30)
+
+/******************************************************************************
+ * Atomic state
+ *****************************************************************************/
+#define nv50_atom(p) container_of((p), struct nv50_atom, state)
+
+struct nv50_atom {
+       struct drm_atomic_state state;
+
+       struct list_head outp;
+       bool lock_core;
+       bool flush_disable;
+};
+
+struct nv50_outp_atom {
+       struct list_head head;
+
+       struct drm_encoder *encoder;
+       bool flush_disable;
+
+       union {
+               struct {
+                       bool ctrl:1;
+               };
+               u8 mask;
+       } clr;
+
+       union {
+               struct {
+                       bool ctrl:1;
+               };
+               u8 mask;
+       } set;
+};
+
+#define nv50_head_atom(p) container_of((p), struct nv50_head_atom, state)
+
+struct nv50_head_atom {
+       struct drm_crtc_state state;
+
+       struct {
+               u16 iW;
+               u16 iH;
+               u16 oW;
+               u16 oH;
+       } view;
+
+       struct nv50_head_mode {
+               bool interlace;
+               u32 clock;
+               struct {
+                       u16 active;
+                       u16 synce;
+                       u16 blanke;
+                       u16 blanks;
+               } h;
+               struct {
+                       u32 active;
+                       u16 synce;
+                       u16 blanke;
+                       u16 blanks;
+                       u16 blank2s;
+                       u16 blank2e;
+                       u16 blankus;
+               } v;
+       } mode;
+
+       struct {
+               u32 handle;
+               u64 offset:40;
+       } lut;
+
+       struct {
+               bool visible;
+               u32 handle;
+               u64 offset:40;
+               u8  format;
+               u8  kind:7;
+               u8  layout:1;
+               u8  block:4;
+               u32 pitch:20;
+               u16 x;
+               u16 y;
+               u16 w;
+               u16 h;
+       } core;
+
+       struct {
+               bool visible;
+               u32 handle;
+               u64 offset:40;
+               u8  layout:1;
+               u8  format:1;
+       } curs;
+
+       struct {
+               u8  depth;
+               u8  cpp;
+               u16 x;
+               u16 y;
+               u16 w;
+               u16 h;
+       } base;
+
+       struct {
+               u8 cpp;
+       } ovly;
+
+       struct {
+               bool enable:1;
+               u8 bits:2;
+               u8 mode:4;
+       } dither;
+
+       struct {
+               struct {
+                       u16 cos:12;
+                       u16 sin:12;
+               } sat;
+       } procamp;
+
+       union {
+               struct {
+                       bool core:1;
+                       bool curs:1;
+               };
+               u8 mask;
+       } clr;
+
+       union {
+               struct {
+                       bool core:1;
+                       bool curs:1;
+                       bool view:1;
+                       bool mode:1;
+                       bool base:1;
+                       bool ovly:1;
+                       bool dither:1;
+                       bool procamp:1;
+               };
+               u16 mask;
+       } set;
+};
+
+static inline struct nv50_head_atom *
+nv50_head_atom_get(struct drm_atomic_state *state, struct drm_crtc *crtc)
+{
+       struct drm_crtc_state *statec = drm_atomic_get_crtc_state(state, crtc);
+       if (IS_ERR(statec))
+               return (void *)statec;
+       return nv50_head_atom(statec);
+}
+
+#define nv50_wndw_atom(p) container_of((p), struct nv50_wndw_atom, state)
+
+struct nv50_wndw_atom {
+       struct drm_plane_state state;
+       u8 interval;
+
+       struct drm_rect clip;
+
+       struct {
+               u32  handle;
+               u16  offset:12;
+               bool awaken:1;
+       } ntfy;
+
+       struct {
+               u32 handle;
+               u16 offset:12;
+               u32 acquire;
+               u32 release;
+       } sema;
+
+       struct {
+               u8 enable:2;
+       } lut;
+
+       struct {
+               u8  mode:2;
+               u8  interval:4;
+
+               u8  format;
+               u8  kind:7;
+               u8  layout:1;
+               u8  block:4;
+               u32 pitch:20;
+               u16 w;
+               u16 h;
+
+               u32 handle;
+               u64 offset;
+       } image;
+
+       struct {
+               u16 x;
+               u16 y;
+       } point;
+
+       union {
+               struct {
+                       bool ntfy:1;
+                       bool sema:1;
+                       bool image:1;
+               };
+               u8 mask;
+       } clr;
+
+       union {
+               struct {
+                       bool ntfy:1;
+                       bool sema:1;
+                       bool image:1;
+                       bool lut:1;
+                       bool point:1;
+               };
+               u8 mask;
+       } set;
+};
 
 /******************************************************************************
  * EVO channel
@@ -132,34 +357,6 @@ nv50_pioc_create(struct nvif_device *device, struct nvif_object *disp,
                                &pioc->base);
 }
 
-/******************************************************************************
- * Cursor Immediate
- *****************************************************************************/
-
-struct nv50_curs {
-       struct nv50_pioc base;
-};
-
-static int
-nv50_curs_create(struct nvif_device *device, struct nvif_object *disp,
-                int head, struct nv50_curs *curs)
-{
-       struct nv50_disp_cursor_v0 args = {
-               .head = head,
-       };
-       static const s32 oclass[] = {
-               GK104_DISP_CURSOR,
-               GF110_DISP_CURSOR,
-               GT214_DISP_CURSOR,
-               G82_DISP_CURSOR,
-               NV50_DISP_CURSOR,
-               0
-       };
-
-       return nv50_pioc_create(device, disp, oclass, head, &args, sizeof(args),
-                               &curs->base);
-}
-
 /******************************************************************************
  * Overlay Immediate
  *****************************************************************************/
@@ -192,6 +389,11 @@ nv50_oimm_create(struct nvif_device *device, struct nvif_object *disp,
  * DMA EVO channel
  *****************************************************************************/
 
+struct nv50_dmac_ctxdma {
+       struct list_head head;
+       struct nvif_object object;
+};
+
 struct nv50_dmac {
        struct nv50_chan base;
        dma_addr_t handle;
@@ -199,6 +401,7 @@ struct nv50_dmac {
 
        struct nvif_object sync;
        struct nvif_object vram;
+       struct list_head ctxdma;
 
        /* Protects against concurrent pushbuf access to this channel, lock is
         * grabbed by evo_wait (if the pushbuf reservation is successful) and
@@ -206,10 +409,83 @@ struct nv50_dmac {
        struct mutex lock;
 };
 
+static void
+nv50_dmac_ctxdma_del(struct nv50_dmac_ctxdma *ctxdma)
+{
+       nvif_object_fini(&ctxdma->object);
+       list_del(&ctxdma->head);
+       kfree(ctxdma);
+}
+
+static struct nv50_dmac_ctxdma *
+nv50_dmac_ctxdma_new(struct nv50_dmac *dmac, struct nouveau_framebuffer *fb)
+{
+       struct nouveau_drm *drm = nouveau_drm(fb->base.dev);
+       struct nv50_dmac_ctxdma *ctxdma;
+       const u8    kind = (fb->nvbo->tile_flags & 0x0000ff00) >> 8;
+       const u32 handle = 0xfb000000 | kind;
+       struct {
+               struct nv_dma_v0 base;
+               union {
+                       struct nv50_dma_v0 nv50;
+                       struct gf100_dma_v0 gf100;
+                       struct gf119_dma_v0 gf119;
+               };
+       } args = {};
+       u32 argc = sizeof(args.base);
+       int ret;
+
+       list_for_each_entry(ctxdma, &dmac->ctxdma, head) {
+               if (ctxdma->object.handle == handle)
+                       return ctxdma;
+       }
+
+       if (!(ctxdma = kzalloc(sizeof(*ctxdma), GFP_KERNEL)))
+               return ERR_PTR(-ENOMEM);
+       list_add(&ctxdma->head, &dmac->ctxdma);
+
+       args.base.target = NV_DMA_V0_TARGET_VRAM;
+       args.base.access = NV_DMA_V0_ACCESS_RDWR;
+       args.base.start  = 0;
+       args.base.limit  = drm->device.info.ram_user - 1;
+
+       if (drm->device.info.chipset < 0x80) {
+               args.nv50.part = NV50_DMA_V0_PART_256;
+               argc += sizeof(args.nv50);
+       } else
+       if (drm->device.info.chipset < 0xc0) {
+               args.nv50.part = NV50_DMA_V0_PART_256;
+               args.nv50.kind = kind;
+               argc += sizeof(args.nv50);
+       } else
+       if (drm->device.info.chipset < 0xd0) {
+               args.gf100.kind = kind;
+               argc += sizeof(args.gf100);
+       } else {
+               args.gf119.page = GF119_DMA_V0_PAGE_LP;
+               args.gf119.kind = kind;
+               argc += sizeof(args.gf119);
+       }
+
+       ret = nvif_object_init(&dmac->base.user, handle, NV_DMA_IN_MEMORY,
+                              &args, argc, &ctxdma->object);
+       if (ret) {
+               nv50_dmac_ctxdma_del(ctxdma);
+               return ERR_PTR(ret);
+       }
+
+       return ctxdma;
+}
+
 static void
 nv50_dmac_destroy(struct nv50_dmac *dmac, struct nvif_object *disp)
 {
        struct nvif_device *device = dmac->base.device;
+       struct nv50_dmac_ctxdma *ctxdma, *ctxtmp;
+
+       list_for_each_entry_safe(ctxdma, ctxtmp, &dmac->ctxdma, head) {
+               nv50_dmac_ctxdma_del(ctxdma);
+       }
 
        nvif_object_fini(&dmac->vram);
        nvif_object_fini(&dmac->sync);
@@ -278,6 +554,7 @@ nv50_dmac_create(struct nvif_device *device, struct nvif_object *disp,
        if (ret)
                return ret;
 
+       INIT_LIST_HEAD(&dmac->ctxdma);
        return ret;
 }
 
@@ -297,7 +574,7 @@ nv50_core_create(struct nvif_device *device, struct nvif_object *disp,
                .pushbuf = 0xb0007d00,
        };
        static const s32 oclass[] = {
-               GP104_DISP_CORE_CHANNEL_DMA,
+               GP102_DISP_CORE_CHANNEL_DMA,
                GP100_DISP_CORE_CHANNEL_DMA,
                GM200_DISP_CORE_CHANNEL_DMA,
                GM107_DISP_CORE_CHANNEL_DMA,
@@ -381,34 +658,23 @@ nv50_ovly_create(struct nvif_device *device, struct nvif_object *disp,
 
 struct nv50_head {
        struct nouveau_crtc base;
-       struct nouveau_bo *image;
-       struct nv50_curs curs;
-       struct nv50_sync sync;
        struct nv50_ovly ovly;
        struct nv50_oimm oimm;
 };
 
 #define nv50_head(c) ((struct nv50_head *)nouveau_crtc(c))
-#define nv50_curs(c) (&nv50_head(c)->curs)
-#define nv50_sync(c) (&nv50_head(c)->sync)
 #define nv50_ovly(c) (&nv50_head(c)->ovly)
 #define nv50_oimm(c) (&nv50_head(c)->oimm)
 #define nv50_chan(c) (&(c)->base.base)
 #define nv50_vers(c) nv50_chan(c)->user.oclass
 
-struct nv50_fbdma {
-       struct list_head head;
-       struct nvif_object core;
-       struct nvif_object base[4];
-};
-
 struct nv50_disp {
        struct nvif_object *disp;
        struct nv50_mast mast;
 
-       struct list_head fbdma;
-
        struct nouveau_bo *sync;
+
+       struct mutex mutex;
 };
 
 static struct nv50_disp *
@@ -419,12 +685,6 @@ nv50_disp(struct drm_device *dev)
 
 #define nv50_mast(d) (&nv50_disp(d)->mast)
 
-static struct drm_crtc *
-nv50_display_crtc_get(struct drm_encoder *encoder)
-{
-       return nouveau_encoder(encoder)->crtc;
-}
-
 /******************************************************************************
  * EVO channel helpers
  *****************************************************************************/
@@ -463,1384 +723,2715 @@ evo_kick(u32 *push, void *evoc)
        mutex_unlock(&dmac->lock);
 }
 
-#if 1
-#define evo_mthd(p,m,s) *((p)++) = (((s) << 18) | (m))
-#define evo_data(p,d)   *((p)++) = (d)
-#else
 #define evo_mthd(p,m,s) do {                                                   \
        const u32 _m = (m), _s = (s);                                          \
-       printk(KERN_ERR "%04x %d %s\n", _m, _s, __func__);                     \
+       if (drm_debug & DRM_UT_KMS)                                            \
+               printk(KERN_ERR "%04x %d %s\n", _m, _s, __func__);             \
        *((p)++) = ((_s << 18) | _m);                                          \
 } while(0)
+
 #define evo_data(p,d) do {                                                     \
        const u32 _d = (d);                                                    \
-       printk(KERN_ERR "\t%08x\n", _d);                                       \
+       if (drm_debug & DRM_UT_KMS)                                            \
+               printk(KERN_ERR "\t%08x\n", _d);                               \
        *((p)++) = _d;                                                         \
 } while(0)
-#endif
 
-static bool
-evo_sync_wait(void *data)
-{
-       if (nouveau_bo_rd32(data, EVO_MAST_NTFY) != 0x00000000)
-               return true;
-       usleep_range(1, 2);
-       return false;
-}
+/******************************************************************************
+ * Plane
+ *****************************************************************************/
+#define nv50_wndw(p) container_of((p), struct nv50_wndw, plane)
 
-static int
-evo_sync(struct drm_device *dev)
-{
-       struct nvif_device *device = &nouveau_drm(dev)->device;
-       struct nv50_disp *disp = nv50_disp(dev);
-       struct nv50_mast *mast = nv50_mast(dev);
-       u32 *push = evo_wait(mast, 8);
-       if (push) {
-               nouveau_bo_wr32(disp->sync, EVO_MAST_NTFY, 0x00000000);
-               evo_mthd(push, 0x0084, 1);
-               evo_data(push, 0x80000000 | EVO_MAST_NTFY);
-               evo_mthd(push, 0x0080, 2);
-               evo_data(push, 0x00000000);
-               evo_data(push, 0x00000000);
-               evo_kick(push, mast);
-               if (nvif_msec(device, 2000,
-                       if (evo_sync_wait(disp->sync))
-                               break;
-               ) >= 0)
-                       return 0;
-       }
+struct nv50_wndw {
+       const struct nv50_wndw_func *func;
+       struct nv50_dmac *dmac;
 
-       return -EBUSY;
-}
+       struct drm_plane plane;
 
-/******************************************************************************
- * Page flipping channel
- *****************************************************************************/
-struct nouveau_bo *
-nv50_display_crtc_sema(struct drm_device *dev, int crtc)
-{
-       return nv50_disp(dev)->sync;
-}
+       struct nvif_notify notify;
+       u16 ntfy;
+       u16 sema;
+       u32 data;
+};
 
-struct nv50_display_flip {
-       struct nv50_disp *disp;
-       struct nv50_sync *chan;
+struct nv50_wndw_func {
+       void *(*dtor)(struct nv50_wndw *);
+       int (*acquire)(struct nv50_wndw *, struct nv50_wndw_atom *asyw,
+                      struct nv50_head_atom *asyh);
+       void (*release)(struct nv50_wndw *, struct nv50_wndw_atom *asyw,
+                       struct nv50_head_atom *asyh);
+       void (*prepare)(struct nv50_wndw *, struct nv50_head_atom *asyh,
+                       struct nv50_wndw_atom *asyw);
+
+       void (*sema_set)(struct nv50_wndw *, struct nv50_wndw_atom *);
+       void (*sema_clr)(struct nv50_wndw *);
+       void (*ntfy_set)(struct nv50_wndw *, struct nv50_wndw_atom *);
+       void (*ntfy_clr)(struct nv50_wndw *);
+       int (*ntfy_wait_begun)(struct nv50_wndw *, struct nv50_wndw_atom *);
+       void (*image_set)(struct nv50_wndw *, struct nv50_wndw_atom *);
+       void (*image_clr)(struct nv50_wndw *);
+       void (*lut)(struct nv50_wndw *, struct nv50_wndw_atom *);
+       void (*point)(struct nv50_wndw *, struct nv50_wndw_atom *);
+
+       u32 (*update)(struct nv50_wndw *, u32 interlock);
 };
 
-static bool
-nv50_display_flip_wait(void *data)
+static int
+nv50_wndw_wait_armed(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
 {
-       struct nv50_display_flip *flip = data;
-       if (nouveau_bo_rd32(flip->disp->sync, flip->chan->addr / 4) ==
-                                             flip->chan->data)
-               return true;
-       usleep_range(1, 2);
-       return false;
+       if (asyw->set.ntfy)
+               return wndw->func->ntfy_wait_begun(wndw, asyw);
+       return 0;
 }
 
-void
-nv50_display_flip_stop(struct drm_crtc *crtc)
+static u32
+nv50_wndw_flush_clr(struct nv50_wndw *wndw, u32 interlock, bool flush,
+                   struct nv50_wndw_atom *asyw)
 {
-       struct nvif_device *device = &nouveau_drm(crtc->dev)->device;
-       struct nv50_display_flip flip = {
-               .disp = nv50_disp(crtc->dev),
-               .chan = nv50_sync(crtc),
-       };
-       u32 *push;
-
-       push = evo_wait(flip.chan, 8);
-       if (push) {
-               evo_mthd(push, 0x0084, 1);
-               evo_data(push, 0x00000000);
-               evo_mthd(push, 0x0094, 1);
-               evo_data(push, 0x00000000);
-               evo_mthd(push, 0x00c0, 1);
-               evo_data(push, 0x00000000);
-               evo_mthd(push, 0x0080, 1);
-               evo_data(push, 0x00000000);
-               evo_kick(push, flip.chan);
-       }
-
-       nvif_msec(device, 2000,
-               if (nv50_display_flip_wait(&flip))
-                       break;
-       );
+       if (asyw->clr.sema && (!asyw->set.sema || flush))
+               wndw->func->sema_clr(wndw);
+       if (asyw->clr.ntfy && (!asyw->set.ntfy || flush))
+               wndw->func->ntfy_clr(wndw);
+       if (asyw->clr.image && (!asyw->set.image || flush))
+               wndw->func->image_clr(wndw);
+
+       return flush ? wndw->func->update(wndw, interlock) : 0;
 }
 
-int
-nv50_display_flip_next(struct drm_crtc *crtc, struct drm_framebuffer *fb,
-                      struct nouveau_channel *chan, u32 swap_interval)
+static u32
+nv50_wndw_flush_set(struct nv50_wndw *wndw, u32 interlock,
+                   struct nv50_wndw_atom *asyw)
 {
-       struct nouveau_framebuffer *nv_fb = nouveau_framebuffer(fb);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct nv50_head *head = nv50_head(crtc);
-       struct nv50_sync *sync = nv50_sync(crtc);
-       u32 *push;
-       int ret;
+       if (interlock) {
+               asyw->image.mode = 0;
+               asyw->image.interval = 1;
+       }
 
-       if (crtc->primary->fb->width != fb->width ||
-           crtc->primary->fb->height != fb->height)
-               return -EINVAL;
+       if (asyw->set.sema ) wndw->func->sema_set (wndw, asyw);
+       if (asyw->set.ntfy ) wndw->func->ntfy_set (wndw, asyw);
+       if (asyw->set.image) wndw->func->image_set(wndw, asyw);
+       if (asyw->set.lut  ) wndw->func->lut      (wndw, asyw);
+       if (asyw->set.point) wndw->func->point    (wndw, asyw);
 
-       swap_interval <<= 4;
-       if (swap_interval == 0)
-               swap_interval |= 0x100;
-       if (chan == NULL)
-               evo_sync(crtc->dev);
+       return wndw->func->update(wndw, interlock);
+}
 
-       push = evo_wait(sync, 128);
-       if (unlikely(push == NULL))
-               return -EBUSY;
+static void
+nv50_wndw_atomic_check_release(struct nv50_wndw *wndw,
+                              struct nv50_wndw_atom *asyw,
+                              struct nv50_head_atom *asyh)
+{
+       struct nouveau_drm *drm = nouveau_drm(wndw->plane.dev);
+       NV_ATOMIC(drm, "%s release\n", wndw->plane.name);
+       wndw->func->release(wndw, asyw, asyh);
+       asyw->ntfy.handle = 0;
+       asyw->sema.handle = 0;
+}
 
-       if (chan && chan->user.oclass < G82_CHANNEL_GPFIFO) {
-               ret = RING_SPACE(chan, 8);
-               if (ret)
-                       return ret;
+static int
+nv50_wndw_atomic_check_acquire(struct nv50_wndw *wndw,
+                              struct nv50_wndw_atom *asyw,
+                              struct nv50_head_atom *asyh)
+{
+       struct nouveau_framebuffer *fb = nouveau_framebuffer(asyw->state.fb);
+       struct nouveau_drm *drm = nouveau_drm(wndw->plane.dev);
+       int ret;
 
-               BEGIN_NV04(chan, 0, NV11_SUBCHAN_DMA_SEMAPHORE, 2);
-               OUT_RING  (chan, NvEvoSema0 + nv_crtc->index);
-               OUT_RING  (chan, sync->addr ^ 0x10);
-               BEGIN_NV04(chan, 0, NV11_SUBCHAN_SEMAPHORE_RELEASE, 1);
-               OUT_RING  (chan, sync->data + 1);
-               BEGIN_NV04(chan, 0, NV11_SUBCHAN_SEMAPHORE_OFFSET, 2);
-               OUT_RING  (chan, sync->addr);
-               OUT_RING  (chan, sync->data);
-       } else
-       if (chan && chan->user.oclass < FERMI_CHANNEL_GPFIFO) {
-               u64 addr = nv84_fence_crtc(chan, nv_crtc->index) + sync->addr;
-               ret = RING_SPACE(chan, 12);
-               if (ret)
-                       return ret;
+       NV_ATOMIC(drm, "%s acquire\n", wndw->plane.name);
+       asyw->clip.x1 = 0;
+       asyw->clip.y1 = 0;
+       asyw->clip.x2 = asyh->state.mode.hdisplay;
+       asyw->clip.y2 = asyh->state.mode.vdisplay;
+
+       asyw->image.w = fb->base.width;
+       asyw->image.h = fb->base.height;
+       asyw->image.kind = (fb->nvbo->tile_flags & 0x0000ff00) >> 8;
+       if (asyw->image.kind) {
+               asyw->image.layout = 0;
+               if (drm->device.info.chipset >= 0xc0)
+                       asyw->image.block = fb->nvbo->tile_mode >> 4;
+               else
+                       asyw->image.block = fb->nvbo->tile_mode;
+               asyw->image.pitch = (fb->base.pitches[0] / 4) << 4;
+       } else {
+               asyw->image.layout = 1;
+               asyw->image.block  = 0;
+               asyw->image.pitch  = fb->base.pitches[0];
+       }
 
-               BEGIN_NV04(chan, 0, NV11_SUBCHAN_DMA_SEMAPHORE, 1);
-               OUT_RING  (chan, chan->vram.handle);
-               BEGIN_NV04(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-               OUT_RING  (chan, upper_32_bits(addr ^ 0x10));
-               OUT_RING  (chan, lower_32_bits(addr ^ 0x10));
-               OUT_RING  (chan, sync->data + 1);
-               OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_WRITE_LONG);
-               BEGIN_NV04(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-               OUT_RING  (chan, upper_32_bits(addr));
-               OUT_RING  (chan, lower_32_bits(addr));
-               OUT_RING  (chan, sync->data);
-               OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_ACQUIRE_EQUAL);
-       } else
-       if (chan) {
-               u64 addr = nv84_fence_crtc(chan, nv_crtc->index) + sync->addr;
-               ret = RING_SPACE(chan, 10);
-               if (ret)
-                       return ret;
+       ret = wndw->func->acquire(wndw, asyw, asyh);
+       if (ret)
+               return ret;
 
-               BEGIN_NVC0(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-               OUT_RING  (chan, upper_32_bits(addr ^ 0x10));
-               OUT_RING  (chan, lower_32_bits(addr ^ 0x10));
-               OUT_RING  (chan, sync->data + 1);
-               OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_WRITE_LONG |
-                                NVC0_SUBCHAN_SEMAPHORE_TRIGGER_YIELD);
-               BEGIN_NVC0(chan, 0, NV84_SUBCHAN_SEMAPHORE_ADDRESS_HIGH, 4);
-               OUT_RING  (chan, upper_32_bits(addr));
-               OUT_RING  (chan, lower_32_bits(addr));
-               OUT_RING  (chan, sync->data);
-               OUT_RING  (chan, NV84_SUBCHAN_SEMAPHORE_TRIGGER_ACQUIRE_EQUAL |
-                                NVC0_SUBCHAN_SEMAPHORE_TRIGGER_YIELD);
-       }
-
-       if (chan) {
-               sync->addr ^= 0x10;
-               sync->data++;
-               FIRE_RING (chan);
-       }
-
-       /* queue the flip */
-       evo_mthd(push, 0x0100, 1);
-       evo_data(push, 0xfffe0000);
-       evo_mthd(push, 0x0084, 1);
-       evo_data(push, swap_interval);
-       if (!(swap_interval & 0x00000100)) {
-               evo_mthd(push, 0x00e0, 1);
-               evo_data(push, 0x40000000);
-       }
-       evo_mthd(push, 0x0088, 4);
-       evo_data(push, sync->addr);
-       evo_data(push, sync->data++);
-       evo_data(push, sync->data);
-       evo_data(push, sync->base.sync.handle);
-       evo_mthd(push, 0x00a0, 2);
-       evo_data(push, 0x00000000);
-       evo_data(push, 0x00000000);
-       evo_mthd(push, 0x00c0, 1);
-       evo_data(push, nv_fb->r_handle);
-       evo_mthd(push, 0x0110, 2);
-       evo_data(push, 0x00000000);
-       evo_data(push, 0x00000000);
-       if (nv50_vers(sync) < GF110_DISP_BASE_CHANNEL_DMA) {
-               evo_mthd(push, 0x0800, 5);
-               evo_data(push, nv_fb->nvbo->bo.offset >> 8);
-               evo_data(push, 0);
-               evo_data(push, (fb->height << 16) | fb->width);
-               evo_data(push, nv_fb->r_pitch);
-               evo_data(push, nv_fb->r_format);
-       } else {
-               evo_mthd(push, 0x0400, 5);
-               evo_data(push, nv_fb->nvbo->bo.offset >> 8);
-               evo_data(push, 0);
-               evo_data(push, (fb->height << 16) | fb->width);
-               evo_data(push, nv_fb->r_pitch);
-               evo_data(push, nv_fb->r_format);
+       if (asyw->set.image) {
+               if (!(asyw->image.mode = asyw->interval ? 0 : 1))
+                       asyw->image.interval = asyw->interval;
+               else
+                       asyw->image.interval = 0;
        }
-       evo_mthd(push, 0x0080, 1);
-       evo_data(push, 0x00000000);
-       evo_kick(push, sync);
 
-       nouveau_bo_ref(nv_fb->nvbo, &head->image);
        return 0;
 }
 
-/******************************************************************************
- * CRTC
- *****************************************************************************/
 static int
-nv50_crtc_set_dither(struct nouveau_crtc *nv_crtc, bool update)
+nv50_wndw_atomic_check(struct drm_plane *plane, struct drm_plane_state *state)
 {
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       struct nouveau_connector *nv_connector;
-       struct drm_connector *connector;
-       u32 *push, mode = 0x00;
+       struct nouveau_drm *drm = nouveau_drm(plane->dev);
+       struct nv50_wndw *wndw = nv50_wndw(plane);
+       struct nv50_wndw_atom *armw = nv50_wndw_atom(wndw->plane.state);
+       struct nv50_wndw_atom *asyw = nv50_wndw_atom(state);
+       struct nv50_head_atom *harm = NULL, *asyh = NULL;
+       bool varm = false, asyv = false, asym = false;
+       int ret;
 
-       nv_connector = nouveau_crtc_connector_get(nv_crtc);
-       connector = &nv_connector->base;
-       if (nv_connector->dithering_mode == DITHERING_MODE_AUTO) {
-               if (nv_crtc->base.primary->fb->depth > connector->display_info.bpc * 3)
-                       mode = DITHERING_MODE_DYNAMIC2X2;
-       } else {
-               mode = nv_connector->dithering_mode;
+       NV_ATOMIC(drm, "%s atomic_check\n", plane->name);
+       if (asyw->state.crtc) {
+               asyh = nv50_head_atom_get(asyw->state.state, asyw->state.crtc);
+               if (IS_ERR(asyh))
+                       return PTR_ERR(asyh);
+               asym = drm_atomic_crtc_needs_modeset(&asyh->state);
+               asyv = asyh->state.active;
        }
 
-       if (nv_connector->dithering_depth == DITHERING_DEPTH_AUTO) {
-               if (connector->display_info.bpc >= 8)
-                       mode |= DITHERING_DEPTH_8BPC;
-       } else {
-               mode |= nv_connector->dithering_depth;
+       if (armw->state.crtc) {
+               harm = nv50_head_atom_get(asyw->state.state, armw->state.crtc);
+               if (IS_ERR(harm))
+                       return PTR_ERR(harm);
+               varm = harm->state.crtc->state->active;
        }
 
-       push = evo_wait(mast, 4);
-       if (push) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x08a0 + (nv_crtc->index * 0x0400), 1);
-                       evo_data(push, mode);
-               } else
-               if (nv50_vers(mast) < GK104_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0490 + (nv_crtc->index * 0x0300), 1);
-                       evo_data(push, mode);
-               } else {
-                       evo_mthd(push, 0x04a0 + (nv_crtc->index * 0x0300), 1);
-                       evo_data(push, mode);
-               }
+       if (asyv) {
+               asyw->point.x = asyw->state.crtc_x;
+               asyw->point.y = asyw->state.crtc_y;
+               if (memcmp(&armw->point, &asyw->point, sizeof(asyw->point)))
+                       asyw->set.point = true;
 
-               if (update) {
-                       evo_mthd(push, 0x0080, 1);
-                       evo_data(push, 0x00000000);
+               if (!varm || asym || armw->state.fb != asyw->state.fb) {
+                       ret = nv50_wndw_atomic_check_acquire(wndw, asyw, asyh);
+                       if (ret)
+                               return ret;
                }
-               evo_kick(push, mast);
+       } else
+       if (varm) {
+               nv50_wndw_atomic_check_release(wndw, asyw, harm);
+       } else {
+               return 0;
+       }
+
+       if (!asyv || asym) {
+               asyw->clr.ntfy = armw->ntfy.handle != 0;
+               asyw->clr.sema = armw->sema.handle != 0;
+               if (wndw->func->image_clr)
+                       asyw->clr.image = armw->image.handle != 0;
+               asyw->set.lut = wndw->func->lut && asyv;
        }
 
        return 0;
 }
 
-static int
-nv50_crtc_set_scale(struct nouveau_crtc *nv_crtc, bool update)
+static void
+nv50_wndw_cleanup_fb(struct drm_plane *plane, struct drm_plane_state *old_state)
 {
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       struct drm_display_mode *omode, *umode = &nv_crtc->base.mode;
-       struct drm_crtc *crtc = &nv_crtc->base;
-       struct nouveau_connector *nv_connector;
-       int mode = DRM_MODE_SCALE_NONE;
-       u32 oX, oY, *push;
+       struct nouveau_framebuffer *fb = nouveau_framebuffer(old_state->fb);
+       struct nouveau_drm *drm = nouveau_drm(plane->dev);
 
-       /* start off at the resolution we programmed the crtc for, this
-        * effectively handles NONE/FULL scaling
-        */
-       nv_connector = nouveau_crtc_connector_get(nv_crtc);
-       if (nv_connector && nv_connector->native_mode) {
-               mode = nv_connector->scaling_mode;
-               if (nv_connector->scaling_full) /* non-EDID LVDS/eDP mode */
-                       mode = DRM_MODE_SCALE_FULLSCREEN;
-       }
+       NV_ATOMIC(drm, "%s cleanup: %p\n", plane->name, old_state->fb);
+       if (!old_state->fb)
+               return;
 
-       if (mode != DRM_MODE_SCALE_NONE)
-               omode = nv_connector->native_mode;
-       else
-               omode = umode;
+       nouveau_bo_unpin(fb->nvbo);
+}
 
-       oX = omode->hdisplay;
-       oY = omode->vdisplay;
-       if (omode->flags & DRM_MODE_FLAG_DBLSCAN)
-               oY *= 2;
+static int
+nv50_wndw_prepare_fb(struct drm_plane *plane, struct drm_plane_state *state)
+{
+       struct nouveau_framebuffer *fb = nouveau_framebuffer(state->fb);
+       struct nouveau_drm *drm = nouveau_drm(plane->dev);
+       struct nv50_wndw *wndw = nv50_wndw(plane);
+       struct nv50_wndw_atom *asyw = nv50_wndw_atom(state);
+       struct nv50_head_atom *asyh;
+       struct nv50_dmac_ctxdma *ctxdma;
+       int ret;
 
-       /* add overscan compensation if necessary, will keep the aspect
-        * ratio the same as the backend mode unless overridden by the
-        * user setting both hborder and vborder properties.
-        */
-       if (nv_connector && ( nv_connector->underscan == UNDERSCAN_ON ||
-                            (nv_connector->underscan == UNDERSCAN_AUTO &&
-                             drm_detect_hdmi_monitor(nv_connector->edid)))) {
-               u32 bX = nv_connector->underscan_hborder;
-               u32 bY = nv_connector->underscan_vborder;
-               u32 aspect = (oY << 19) / oX;
+       NV_ATOMIC(drm, "%s prepare: %p\n", plane->name, state->fb);
+       if (!asyw->state.fb)
+               return 0;
 
-               if (bX) {
-                       oX -= (bX * 2);
-                       if (bY) oY -= (bY * 2);
-                       else    oY  = ((oX * aspect) + (aspect / 2)) >> 19;
-               } else {
-                       oX -= (oX >> 4) + 32;
-                       if (bY) oY -= (bY * 2);
-                       else    oY  = ((oX * aspect) + (aspect / 2)) >> 19;
-               }
-       }
+       ret = nouveau_bo_pin(fb->nvbo, TTM_PL_FLAG_VRAM, true);
+       if (ret)
+               return ret;
 
-       /* handle CENTER/ASPECT scaling, taking into account the areas
-        * removed already for overscan compensation
-        */
-       switch (mode) {
-       case DRM_MODE_SCALE_CENTER:
-               oX = min((u32)umode->hdisplay, oX);
-               oY = min((u32)umode->vdisplay, oY);
-               /* fall-through */
-       case DRM_MODE_SCALE_ASPECT:
-               if (oY < oX) {
-                       u32 aspect = (umode->hdisplay << 19) / umode->vdisplay;
-                       oX = ((oY * aspect) + (aspect / 2)) >> 19;
-               } else {
-                       u32 aspect = (umode->vdisplay << 19) / umode->hdisplay;
-                       oY = ((oX * aspect) + (aspect / 2)) >> 19;
-               }
-               break;
-       default:
-               break;
+       ctxdma = nv50_dmac_ctxdma_new(wndw->dmac, fb);
+       if (IS_ERR(ctxdma)) {
+               nouveau_bo_unpin(fb->nvbo);
+               return PTR_ERR(ctxdma);
        }
 
-       push = evo_wait(mast, 8);
-       if (push) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       /*XXX: SCALE_CTRL_ACTIVE??? */
-                       evo_mthd(push, 0x08d8 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, (oY << 16) | oX);
-                       evo_data(push, (oY << 16) | oX);
-                       evo_mthd(push, 0x08a4 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x08c8 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, umode->vdisplay << 16 | umode->hdisplay);
-               } else {
-                       evo_mthd(push, 0x04c0 + (nv_crtc->index * 0x300), 3);
-                       evo_data(push, (oY << 16) | oX);
-                       evo_data(push, (oY << 16) | oX);
-                       evo_data(push, (oY << 16) | oX);
-                       evo_mthd(push, 0x0494 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x04b8 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, umode->vdisplay << 16 | umode->hdisplay);
-               }
+       asyw->state.fence = reservation_object_get_excl_rcu(fb->nvbo->bo.resv);
+       asyw->image.handle = ctxdma->object.handle;
+       asyw->image.offset = fb->nvbo->bo.offset;
 
-               evo_kick(push, mast);
+       if (wndw->func->prepare) {
+               asyh = nv50_head_atom_get(asyw->state.state, asyw->state.crtc);
+               if (IS_ERR(asyh))
+                       return PTR_ERR(asyh);
 
-               if (update) {
-                       nv50_display_flip_stop(crtc);
-                       nv50_display_flip_next(crtc, crtc->primary->fb,
-                                              NULL, 1);
-               }
+               wndw->func->prepare(wndw, asyh, asyw);
        }
 
        return 0;
 }
 
-static int
-nv50_crtc_set_raster_vblank_dmi(struct nouveau_crtc *nv_crtc, u32 usec)
-{
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       u32 *push;
+static const struct drm_plane_helper_funcs
+nv50_wndw_helper = {
+       .prepare_fb = nv50_wndw_prepare_fb,
+       .cleanup_fb = nv50_wndw_cleanup_fb,
+       .atomic_check = nv50_wndw_atomic_check,
+};
 
-       push = evo_wait(mast, 8);
-       if (!push)
-               return -ENOMEM;
+static void
+nv50_wndw_atomic_destroy_state(struct drm_plane *plane,
+                              struct drm_plane_state *state)
+{
+       struct nv50_wndw_atom *asyw = nv50_wndw_atom(state);
+       __drm_atomic_helper_plane_destroy_state(&asyw->state);
+       dma_fence_put(asyw->state.fence);
+       kfree(asyw);
+}
 
-       evo_mthd(push, 0x0828 + (nv_crtc->index * 0x400), 1);
-       evo_data(push, usec);
-       evo_kick(push, mast);
-       return 0;
+static struct drm_plane_state *
+nv50_wndw_atomic_duplicate_state(struct drm_plane *plane)
+{
+       struct nv50_wndw_atom *armw = nv50_wndw_atom(plane->state);
+       struct nv50_wndw_atom *asyw;
+       if (!(asyw = kmalloc(sizeof(*asyw), GFP_KERNEL)))
+               return NULL;
+       __drm_atomic_helper_plane_duplicate_state(plane, &asyw->state);
+       asyw->state.fence = NULL;
+       asyw->interval = 1;
+       asyw->sema = armw->sema;
+       asyw->ntfy = armw->ntfy;
+       asyw->image = armw->image;
+       asyw->point = armw->point;
+       asyw->lut = armw->lut;
+       asyw->clr.mask = 0;
+       asyw->set.mask = 0;
+       return &asyw->state;
 }
 
-static int
-nv50_crtc_set_color_vibrance(struct nouveau_crtc *nv_crtc, bool update)
+static void
+nv50_wndw_reset(struct drm_plane *plane)
 {
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       u32 *push, hue, vib;
-       int adj;
+       struct nv50_wndw_atom *asyw;
 
-       adj = (nv_crtc->color_vibrance > 0) ? 50 : 0;
-       vib = ((nv_crtc->color_vibrance * 2047 + adj) / 100) & 0xfff;
-       hue = ((nv_crtc->vibrant_hue * 2047) / 100) & 0xfff;
+       if (WARN_ON(!(asyw = kzalloc(sizeof(*asyw), GFP_KERNEL))))
+               return;
 
-       push = evo_wait(mast, 16);
-       if (push) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x08a8 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, (hue << 20) | (vib << 8));
-               } else {
-                       evo_mthd(push, 0x0498 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, (hue << 20) | (vib << 8));
-               }
+       if (plane->state)
+               plane->funcs->atomic_destroy_state(plane, plane->state);
+       plane->state = &asyw->state;
+       plane->state->plane = plane;
+       plane->state->rotation = DRM_ROTATE_0;
+}
 
-               if (update) {
-                       evo_mthd(push, 0x0080, 1);
-                       evo_data(push, 0x00000000);
-               }
-               evo_kick(push, mast);
-       }
+static void
+nv50_wndw_destroy(struct drm_plane *plane)
+{
+       struct nv50_wndw *wndw = nv50_wndw(plane);
+       void *data;
+       nvif_notify_fini(&wndw->notify);
+       data = wndw->func->dtor(wndw);
+       drm_plane_cleanup(&wndw->plane);
+       kfree(data);
+}
 
-       return 0;
+static const struct drm_plane_funcs
+nv50_wndw = {
+       .update_plane = drm_atomic_helper_update_plane,
+       .disable_plane = drm_atomic_helper_disable_plane,
+       .destroy = nv50_wndw_destroy,
+       .reset = nv50_wndw_reset,
+       .set_property = drm_atomic_helper_plane_set_property,
+       .atomic_duplicate_state = nv50_wndw_atomic_duplicate_state,
+       .atomic_destroy_state = nv50_wndw_atomic_destroy_state,
+};
+
+static void
+nv50_wndw_fini(struct nv50_wndw *wndw)
+{
+       nvif_notify_put(&wndw->notify);
+}
+
+static void
+nv50_wndw_init(struct nv50_wndw *wndw)
+{
+       nvif_notify_get(&wndw->notify);
 }
 
 static int
-nv50_crtc_set_image(struct nouveau_crtc *nv_crtc, struct drm_framebuffer *fb,
-                   int x, int y, bool update)
+nv50_wndw_ctor(const struct nv50_wndw_func *func, struct drm_device *dev,
+              enum drm_plane_type type, const char *name, int index,
+              struct nv50_dmac *dmac, const u32 *format, int nformat,
+              struct nv50_wndw *wndw)
 {
-       struct nouveau_framebuffer *nvfb = nouveau_framebuffer(fb);
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       u32 *push;
+       int ret;
 
-       push = evo_wait(mast, 16);
-       if (push) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0860 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, nvfb->nvbo->bo.offset >> 8);
-                       evo_mthd(push, 0x0868 + (nv_crtc->index * 0x400), 3);
-                       evo_data(push, (fb->height << 16) | fb->width);
-                       evo_data(push, nvfb->r_pitch);
-                       evo_data(push, nvfb->r_format);
-                       evo_mthd(push, 0x08c0 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, (y << 16) | x);
-                       if (nv50_vers(mast) > NV50_DISP_CORE_CHANNEL_DMA) {
-                               evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                               evo_data(push, nvfb->r_handle);
-                       }
-               } else {
-                       evo_mthd(push, 0x0460 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, nvfb->nvbo->bo.offset >> 8);
-                       evo_mthd(push, 0x0468 + (nv_crtc->index * 0x300), 4);
-                       evo_data(push, (fb->height << 16) | fb->width);
-                       evo_data(push, nvfb->r_pitch);
-                       evo_data(push, nvfb->r_format);
-                       evo_data(push, nvfb->r_handle);
-                       evo_mthd(push, 0x04b0 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, (y << 16) | x);
-               }
+       wndw->func = func;
+       wndw->dmac = dmac;
 
-               if (update) {
-                       evo_mthd(push, 0x0080, 1);
-                       evo_data(push, 0x00000000);
-               }
-               evo_kick(push, mast);
-       }
+       ret = drm_universal_plane_init(dev, &wndw->plane, 0, &nv50_wndw, format,
+                                      nformat, type, "%s-%d", name, index);
+       if (ret)
+               return ret;
 
-       nv_crtc->fb.handle = nvfb->r_handle;
+       drm_plane_helper_add(&wndw->plane, &nv50_wndw_helper);
        return 0;
 }
 
-static void
-nv50_crtc_cursor_show(struct nouveau_crtc *nv_crtc)
+/******************************************************************************
+ * Cursor plane
+ *****************************************************************************/
+#define nv50_curs(p) container_of((p), struct nv50_curs, wndw)
+
+struct nv50_curs {
+       struct nv50_wndw wndw;
+       struct nvif_object chan;
+};
+
+static u32
+nv50_curs_update(struct nv50_wndw *wndw, u32 interlock)
 {
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       u32 *push = evo_wait(mast, 16);
-       if (push) {
-               if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, 0x85000000);
-                       evo_data(push, nv_crtc->cursor.nvbo->bo.offset >> 8);
-               } else
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, 0x85000000);
-                       evo_data(push, nv_crtc->cursor.nvbo->bo.offset >> 8);
-                       evo_mthd(push, 0x089c + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, mast->base.vram.handle);
-               } else {
-                       evo_mthd(push, 0x0480 + (nv_crtc->index * 0x300), 2);
-                       evo_data(push, 0x85000000);
-                       evo_data(push, nv_crtc->cursor.nvbo->bo.offset >> 8);
-                       evo_mthd(push, 0x048c + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, mast->base.vram.handle);
-               }
-               evo_kick(push, mast);
-       }
-       nv_crtc->cursor.visible = true;
+       struct nv50_curs *curs = nv50_curs(wndw);
+       nvif_wr32(&curs->chan, 0x0080, 0x00000000);
+       return 0;
 }
 
 static void
-nv50_crtc_cursor_hide(struct nouveau_crtc *nv_crtc)
+nv50_curs_point(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
 {
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-       u32 *push = evo_wait(mast, 16);
-       if (push) {
-               if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x05000000);
-               } else
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0880 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x05000000);
-                       evo_mthd(push, 0x089c + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x00000000);
-               } else {
-                       evo_mthd(push, 0x0480 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x05000000);
-                       evo_mthd(push, 0x048c + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x00000000);
-               }
-               evo_kick(push, mast);
-       }
-       nv_crtc->cursor.visible = false;
+       struct nv50_curs *curs = nv50_curs(wndw);
+       nvif_wr32(&curs->chan, 0x0084, (asyw->point.y << 16) | asyw->point.x);
 }
 
 static void
-nv50_crtc_cursor_show_hide(struct nouveau_crtc *nv_crtc, bool show, bool update)
+nv50_curs_prepare(struct nv50_wndw *wndw, struct nv50_head_atom *asyh,
+                 struct nv50_wndw_atom *asyw)
 {
-       struct nv50_mast *mast = nv50_mast(nv_crtc->base.dev);
-
-       if (show && nv_crtc->cursor.nvbo && nv_crtc->base.enabled)
-               nv50_crtc_cursor_show(nv_crtc);
-       else
-               nv50_crtc_cursor_hide(nv_crtc);
-
-       if (update) {
-               u32 *push = evo_wait(mast, 2);
-               if (push) {
-                       evo_mthd(push, 0x0080, 1);
-                       evo_data(push, 0x00000000);
-                       evo_kick(push, mast);
-               }
-       }
+       asyh->curs.handle = nv50_disp(wndw->plane.dev)->mast.base.vram.handle;
+       asyh->curs.offset = asyw->image.offset;
+       asyh->set.curs = asyh->curs.visible;
 }
 
 static void
-nv50_crtc_dpms(struct drm_crtc *crtc, int mode)
+nv50_curs_release(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                 struct nv50_head_atom *asyh)
 {
+       asyh->curs.visible = false;
 }
 
-static void
-nv50_crtc_prepare(struct drm_crtc *crtc)
+static int
+nv50_curs_acquire(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                 struct nv50_head_atom *asyh)
 {
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct nv50_mast *mast = nv50_mast(crtc->dev);
-       u32 *push;
-
-       nv50_display_flip_stop(crtc);
+       int ret;
 
-       push = evo_wait(mast, 6);
-       if (push) {
-               if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x40000000);
-               } else
-               if (nv50_vers(mast) <  GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x40000000);
-                       evo_mthd(push, 0x085c + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, 0x00000000);
-               } else {
-                       evo_mthd(push, 0x0474 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x0440 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x03000000);
-                       evo_mthd(push, 0x045c + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x00000000);
-               }
+       ret = drm_plane_helper_check_state(&asyw->state, &asyw->clip,
+                                          DRM_PLANE_HELPER_NO_SCALING,
+                                          DRM_PLANE_HELPER_NO_SCALING,
+                                          true, true);
+       asyh->curs.visible = asyw->state.visible;
+       if (ret || !asyh->curs.visible)
+               return ret;
 
-               evo_kick(push, mast);
+       switch (asyw->state.fb->width) {
+       case 32: asyh->curs.layout = 0; break;
+       case 64: asyh->curs.layout = 1; break;
+       default:
+               return -EINVAL;
        }
 
-       nv50_crtc_cursor_show_hide(nv_crtc, false, false);
-}
-
-static void
-nv50_crtc_commit(struct drm_crtc *crtc)
-{
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct nv50_mast *mast = nv50_mast(crtc->dev);
-       u32 *push;
-
-       push = evo_wait(mast, 32);
-       if (push) {
-               if (nv50_vers(mast) < G82_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, nv_crtc->fb.handle);
-                       evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, 0xc0000000);
-                       evo_data(push, nv_crtc->lut.nvbo->bo.offset >> 8);
-               } else
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0874 + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, nv_crtc->fb.handle);
-                       evo_mthd(push, 0x0840 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, 0xc0000000);
-                       evo_data(push, nv_crtc->lut.nvbo->bo.offset >> 8);
-                       evo_mthd(push, 0x085c + (nv_crtc->index * 0x400), 1);
-                       evo_data(push, mast->base.vram.handle);
-               } else {
-                       evo_mthd(push, 0x0474 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, nv_crtc->fb.handle);
-                       evo_mthd(push, 0x0440 + (nv_crtc->index * 0x300), 4);
-                       evo_data(push, 0x83000000);
-                       evo_data(push, nv_crtc->lut.nvbo->bo.offset >> 8);
-                       evo_data(push, 0x00000000);
-                       evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x045c + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, mast->base.vram.handle);
-                       evo_mthd(push, 0x0430 + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0xffffff00);
-               }
+       if (asyw->state.fb->width != asyw->state.fb->height)
+               return -EINVAL;
 
-               evo_kick(push, mast);
+       switch (asyw->state.fb->pixel_format) {
+       case DRM_FORMAT_ARGB8888: asyh->curs.format = 1; break;
+       default:
+               WARN_ON(1);
+               return -EINVAL;
        }
 
-       nv50_crtc_cursor_show_hide(nv_crtc, true, true);
-       nv50_display_flip_next(crtc, crtc->primary->fb, NULL, 1);
+       return 0;
 }
 
-static bool
-nv50_crtc_mode_fixup(struct drm_crtc *crtc, const struct drm_display_mode *mode,
-                    struct drm_display_mode *adjusted_mode)
+static void *
+nv50_curs_dtor(struct nv50_wndw *wndw)
 {
-       drm_mode_set_crtcinfo(adjusted_mode, CRTC_INTERLACE_HALVE_V);
-       return true;
+       struct nv50_curs *curs = nv50_curs(wndw);
+       nvif_object_fini(&curs->chan);
+       return curs;
 }
 
+static const u32
+nv50_curs_format[] = {
+       DRM_FORMAT_ARGB8888,
+};
+
+static const struct nv50_wndw_func
+nv50_curs = {
+       .dtor = nv50_curs_dtor,
+       .acquire = nv50_curs_acquire,
+       .release = nv50_curs_release,
+       .prepare = nv50_curs_prepare,
+       .point = nv50_curs_point,
+       .update = nv50_curs_update,
+};
+
 static int
-nv50_crtc_swap_fbs(struct drm_crtc *crtc, struct drm_framebuffer *old_fb)
+nv50_curs_new(struct nouveau_drm *drm, struct nv50_head *head,
+             struct nv50_curs **pcurs)
 {
-       struct nouveau_framebuffer *nvfb = nouveau_framebuffer(crtc->primary->fb);
-       struct nv50_head *head = nv50_head(crtc);
-       int ret;
+       static const struct nvif_mclass curses[] = {
+               { GK104_DISP_CURSOR, 0 },
+               { GF110_DISP_CURSOR, 0 },
+               { GT214_DISP_CURSOR, 0 },
+               {   G82_DISP_CURSOR, 0 },
+               {  NV50_DISP_CURSOR, 0 },
+               {}
+       };
+       struct nv50_disp_cursor_v0 args = {
+               .head = head->base.index,
+       };
+       struct nv50_disp *disp = nv50_disp(drm->dev);
+       struct nv50_curs *curs;
+       int cid, ret;
+
+       cid = nvif_mclass(disp->disp, curses);
+       if (cid < 0) {
+               NV_ERROR(drm, "No supported cursor immediate class\n");
+               return cid;
+       }
+
+       if (!(curs = *pcurs = kzalloc(sizeof(*curs), GFP_KERNEL)))
+               return -ENOMEM;
 
-       ret = nouveau_bo_pin(nvfb->nvbo, TTM_PL_FLAG_VRAM, true);
-       if (ret == 0) {
-               if (head->image)
-                       nouveau_bo_unpin(head->image);
-               nouveau_bo_ref(nvfb->nvbo, &head->image);
+       ret = nv50_wndw_ctor(&nv50_curs, drm->dev, DRM_PLANE_TYPE_CURSOR,
+                            "curs", head->base.index, &disp->mast.base,
+                            nv50_curs_format, ARRAY_SIZE(nv50_curs_format),
+                            &curs->wndw);
+       if (ret) {
+               kfree(curs);
+               return ret;
        }
 
-       return ret;
+       ret = nvif_object_init(disp->disp, 0, curses[cid].oclass, &args,
+                              sizeof(args), &curs->chan);
+       if (ret) {
+               NV_ERROR(drm, "curs%04x allocation failed: %d\n",
+                        curses[cid].oclass, ret);
+               return ret;
+       }
+
+       return 0;
 }
 
+/******************************************************************************
+ * Primary plane
+ *****************************************************************************/
+#define nv50_base(p) container_of((p), struct nv50_base, wndw)
+
+struct nv50_base {
+       struct nv50_wndw wndw;
+       struct nv50_sync chan;
+       int id;
+};
+
 static int
-nv50_crtc_mode_set(struct drm_crtc *crtc, struct drm_display_mode *umode,
-                  struct drm_display_mode *mode, int x, int y,
-                  struct drm_framebuffer *old_fb)
+nv50_base_notify(struct nvif_notify *notify)
 {
-       struct nv50_mast *mast = nv50_mast(crtc->dev);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct nouveau_connector *nv_connector;
-       u32 ilace = (mode->flags & DRM_MODE_FLAG_INTERLACE) ? 2 : 1;
-       u32 vscan = (mode->flags & DRM_MODE_FLAG_DBLSCAN) ? 2 : 1;
-       u32 hactive, hsynce, hbackp, hfrontp, hblanke, hblanks;
-       u32 vactive, vsynce, vbackp, vfrontp, vblanke, vblanks;
-       u32 vblan2e = 0, vblan2s = 1, vblankus = 0;
-       u32 *push;
-       int ret;
-
-       hactive = mode->htotal;
-       hsynce  = mode->hsync_end - mode->hsync_start - 1;
-       hbackp  = mode->htotal - mode->hsync_end;
-       hblanke = hsynce + hbackp;
-       hfrontp = mode->hsync_start - mode->hdisplay;
-       hblanks = mode->htotal - hfrontp - 1;
-
-       vactive = mode->vtotal * vscan / ilace;
-       vsynce  = ((mode->vsync_end - mode->vsync_start) * vscan / ilace) - 1;
-       vbackp  = (mode->vtotal - mode->vsync_end) * vscan / ilace;
-       vblanke = vsynce + vbackp;
-       vfrontp = (mode->vsync_start - mode->vdisplay) * vscan / ilace;
-       vblanks = vactive - vfrontp - 1;
-       /* XXX: Safe underestimate, even "0" works */
-       vblankus = (vactive - mode->vdisplay - 2) * hactive;
-       vblankus *= 1000;
-       vblankus /= mode->clock;
+       return NVIF_NOTIFY_KEEP;
+}
 
-       if (mode->flags & DRM_MODE_FLAG_INTERLACE) {
-               vblan2e = vactive + vsynce + vbackp;
-               vblan2s = vblan2e + (mode->vdisplay * vscan / ilace);
-               vactive = (vactive * 2) + 1;
+static void
+nv50_base_lut(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 2))) {
+               evo_mthd(push, 0x00e0, 1);
+               evo_data(push, asyw->lut.enable << 30);
+               evo_kick(push, &base->chan);
        }
+}
 
-       ret = nv50_crtc_swap_fbs(crtc, old_fb);
-       if (ret)
-               return ret;
+static void
+nv50_base_image_clr(struct nv50_wndw *wndw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 4))) {
+               evo_mthd(push, 0x0084, 1);
+               evo_data(push, 0x00000000);
+               evo_mthd(push, 0x00c0, 1);
+               evo_data(push, 0x00000000);
+               evo_kick(push, &base->chan);
+       }
+}
 
-       push = evo_wait(mast, 64);
-       if (push) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       evo_mthd(push, 0x0804 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, 0x00800000 | mode->clock);
-                       evo_data(push, (ilace == 2) ? 2 : 0);
-                       evo_mthd(push, 0x0810 + (nv_crtc->index * 0x400), 6);
+static void
+nv50_base_image_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       const s32 oclass = base->chan.base.base.user.oclass;
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 10))) {
+               evo_mthd(push, 0x0084, 1);
+               evo_data(push, (asyw->image.mode << 8) |
+                              (asyw->image.interval << 4));
+               evo_mthd(push, 0x00c0, 1);
+               evo_data(push, asyw->image.handle);
+               if (oclass < G82_DISP_BASE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0800, 5);
+                       evo_data(push, asyw->image.offset >> 8);
                        evo_data(push, 0x00000000);
-                       evo_data(push, (vactive << 16) | hactive);
-                       evo_data(push, ( vsynce << 16) | hsynce);
-                       evo_data(push, (vblanke << 16) | hblanke);
-                       evo_data(push, (vblanks << 16) | hblanks);
-                       evo_data(push, (vblan2e << 16) | vblan2s);
-                       evo_mthd(push, 0x082c + (nv_crtc->index * 0x400), 1);
+                       evo_data(push, (asyw->image.h << 16) | asyw->image.w);
+                       evo_data(push, (asyw->image.layout << 20) |
+                                       asyw->image.pitch |
+                                       asyw->image.block);
+                       evo_data(push, (asyw->image.kind << 16) |
+                                      (asyw->image.format << 8));
+               } else
+               if (oclass < GF110_DISP_BASE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0800, 5);
+                       evo_data(push, asyw->image.offset >> 8);
                        evo_data(push, 0x00000000);
-                       evo_mthd(push, 0x0900 + (nv_crtc->index * 0x400), 2);
-                       evo_data(push, 0x00000311);
-                       evo_data(push, 0x00000100);
+                       evo_data(push, (asyw->image.h << 16) | asyw->image.w);
+                       evo_data(push, (asyw->image.layout << 20) |
+                                       asyw->image.pitch |
+                                       asyw->image.block);
+                       evo_data(push, asyw->image.format << 8);
                } else {
-                       evo_mthd(push, 0x0410 + (nv_crtc->index * 0x300), 6);
+                       evo_mthd(push, 0x0400, 5);
+                       evo_data(push, asyw->image.offset >> 8);
                        evo_data(push, 0x00000000);
-                       evo_data(push, (vactive << 16) | hactive);
-                       evo_data(push, ( vsynce << 16) | hsynce);
-                       evo_data(push, (vblanke << 16) | hblanke);
-                       evo_data(push, (vblanks << 16) | hblanks);
-                       evo_data(push, (vblan2e << 16) | vblan2s);
-                       evo_mthd(push, 0x042c + (nv_crtc->index * 0x300), 1);
-                       evo_data(push, 0x00000000); /* ??? */
-                       evo_mthd(push, 0x0450 + (nv_crtc->index * 0x300), 3);
-                       evo_data(push, mode->clock * 1000);
-                       evo_data(push, 0x00200000); /* ??? */
-                       evo_data(push, mode->clock * 1000);
-                       evo_mthd(push, 0x04d0 + (nv_crtc->index * 0x300), 2);
-                       evo_data(push, 0x00000311);
-                       evo_data(push, 0x00000100);
+                       evo_data(push, (asyw->image.h << 16) | asyw->image.w);
+                       evo_data(push, (asyw->image.layout << 24) |
+                                       asyw->image.pitch |
+                                       asyw->image.block);
+                       evo_data(push, asyw->image.format << 8);
                }
+               evo_kick(push, &base->chan);
+       }
+}
 
-               evo_kick(push, mast);
+static void
+nv50_base_ntfy_clr(struct nv50_wndw *wndw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 2))) {
+               evo_mthd(push, 0x00a4, 1);
+               evo_data(push, 0x00000000);
+               evo_kick(push, &base->chan);
        }
+}
 
-       nv_connector = nouveau_crtc_connector_get(nv_crtc);
-       nv50_crtc_set_dither(nv_crtc, false);
-       nv50_crtc_set_scale(nv_crtc, false);
+static void
+nv50_base_ntfy_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 3))) {
+               evo_mthd(push, 0x00a0, 2);
+               evo_data(push, (asyw->ntfy.awaken << 30) | asyw->ntfy.offset);
+               evo_data(push, asyw->ntfy.handle);
+               evo_kick(push, &base->chan);
+       }
+}
 
-       /* G94 only accepts this after setting scale */
-       if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA)
-               nv50_crtc_set_raster_vblank_dmi(nv_crtc, vblankus);
+static void
+nv50_base_sema_clr(struct nv50_wndw *wndw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 2))) {
+               evo_mthd(push, 0x0094, 1);
+               evo_data(push, 0x00000000);
+               evo_kick(push, &base->chan);
+       }
+}
 
-       nv50_crtc_set_color_vibrance(nv_crtc, false);
-       nv50_crtc_set_image(nv_crtc, crtc->primary->fb, x, y, false);
-       return 0;
+static void
+nv50_base_sema_set(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
+{
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
+       if ((push = evo_wait(&base->chan, 5))) {
+               evo_mthd(push, 0x0088, 4);
+               evo_data(push, asyw->sema.offset);
+               evo_data(push, asyw->sema.acquire);
+               evo_data(push, asyw->sema.release);
+               evo_data(push, asyw->sema.handle);
+               evo_kick(push, &base->chan);
+       }
 }
 
-static int
-nv50_crtc_mode_set_base(struct drm_crtc *crtc, int x, int y,
-                       struct drm_framebuffer *old_fb)
+static u32
+nv50_base_update(struct nv50_wndw *wndw, u32 interlock)
 {
-       struct nouveau_drm *drm = nouveau_drm(crtc->dev);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       int ret;
+       struct nv50_base *base = nv50_base(wndw);
+       u32 *push;
 
-       if (!crtc->primary->fb) {
-               NV_DEBUG(drm, "No FB bound\n");
+       if (!(push = evo_wait(&base->chan, 2)))
                return 0;
-       }
-
-       ret = nv50_crtc_swap_fbs(crtc, old_fb);
-       if (ret)
-               return ret;
+       evo_mthd(push, 0x0080, 1);
+       evo_data(push, interlock);
+       evo_kick(push, &base->chan);
 
-       nv50_display_flip_stop(crtc);
-       nv50_crtc_set_image(nv_crtc, crtc->primary->fb, x, y, true);
-       nv50_display_flip_next(crtc, crtc->primary->fb, NULL, 1);
-       return 0;
+       if (base->chan.base.base.user.oclass < GF110_DISP_BASE_CHANNEL_DMA)
+               return interlock ? 2 << (base->id * 8) : 0;
+       return interlock ? 2 << (base->id * 4) : 0;
 }
 
 static int
-nv50_crtc_mode_set_base_atomic(struct drm_crtc *crtc,
-                              struct drm_framebuffer *fb, int x, int y,
-                              enum mode_set_atomic state)
+nv50_base_ntfy_wait_begun(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw)
 {
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       nv50_display_flip_stop(crtc);
-       nv50_crtc_set_image(nv_crtc, fb, x, y, true);
+       struct nouveau_drm *drm = nouveau_drm(wndw->plane.dev);
+       struct nv50_disp *disp = nv50_disp(wndw->plane.dev);
+       if (nvif_msec(&drm->device, 2000ULL,
+               u32 data = nouveau_bo_rd32(disp->sync, asyw->ntfy.offset / 4);
+               if ((data & 0xc0000000) == 0x40000000)
+                       break;
+               usleep_range(1, 2);
+       ) < 0)
+               return -ETIMEDOUT;
        return 0;
 }
 
 static void
-nv50_crtc_lut_load(struct drm_crtc *crtc)
+nv50_base_release(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                 struct nv50_head_atom *asyh)
 {
-       struct nv50_disp *disp = nv50_disp(crtc->dev);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       void __iomem *lut = nvbo_kmap_obj_iovirtual(nv_crtc->lut.nvbo);
-       int i;
+       asyh->base.cpp = 0;
+}
 
-       for (i = 0; i < 256; i++) {
-               u16 r = nv_crtc->lut.r[i] >> 2;
-               u16 g = nv_crtc->lut.g[i] >> 2;
-               u16 b = nv_crtc->lut.b[i] >> 2;
+static int
+nv50_base_acquire(struct nv50_wndw *wndw, struct nv50_wndw_atom *asyw,
+                 struct nv50_head_atom *asyh)
+{
+       const u32 format = asyw->state.fb->pixel_format;
+       const struct drm_format_info *info;
+       int ret;
 
-               if (disp->disp->oclass < GF110_DISP) {
-                       writew(r + 0x0000, lut + (i * 0x08) + 0);
-                       writew(g + 0x0000, lut + (i * 0x08) + 2);
-                       writew(b + 0x0000, lut + (i * 0x08) + 4);
+       info = drm_format_info(format);
+       if (!info || !info->depth)
+               return -EINVAL;
+
+       ret = drm_plane_helper_check_state(&asyw->state, &asyw->clip,
+                                          DRM_PLANE_HELPER_NO_SCALING,
+                                          DRM_PLANE_HELPER_NO_SCALING,
+                                          false, true);
+       if (ret)
+               return ret;
+
+       asyh->base.depth = info->depth;
+       asyh->base.cpp = info->cpp[0];
+       asyh->base.x = asyw->state.src.x1 >> 16;
+       asyh->base.y = asyw->state.src.y1 >> 16;
+       asyh->base.w = asyw->state.fb->width;
+       asyh->base.h = asyw->state.fb->height;
+
+       switch (format) {
+       case DRM_FORMAT_C8         : asyw->image.format = 0x1e; break;
+       case DRM_FORMAT_RGB565     : asyw->image.format = 0xe8; break;
+       case DRM_FORMAT_XRGB1555   :
+       case DRM_FORMAT_ARGB1555   : asyw->image.format = 0xe9; break;
+       case DRM_FORMAT_XRGB8888   :
+       case DRM_FORMAT_ARGB8888   : asyw->image.format = 0xcf; break;
+       case DRM_FORMAT_XBGR2101010:
+       case DRM_FORMAT_ABGR2101010: asyw->image.format = 0xd1; break;
+       case DRM_FORMAT_XBGR8888   :
+       case DRM_FORMAT_ABGR8888   : asyw->image.format = 0xd5; break;
+       default:
+               WARN_ON(1);
+               return -EINVAL;
+       }
+
+       asyw->lut.enable = 1;
+       asyw->set.image = true;
+       return 0;
+}
+
+static void *
+nv50_base_dtor(struct nv50_wndw *wndw)
+{
+       struct nv50_disp *disp = nv50_disp(wndw->plane.dev);
+       struct nv50_base *base = nv50_base(wndw);
+       nv50_dmac_destroy(&base->chan.base, disp->disp);
+       return base;
+}
+
+static const u32
+nv50_base_format[] = {
+       DRM_FORMAT_C8,
+       DRM_FORMAT_RGB565,
+       DRM_FORMAT_XRGB1555,
+       DRM_FORMAT_ARGB1555,
+       DRM_FORMAT_XRGB8888,
+       DRM_FORMAT_ARGB8888,
+       DRM_FORMAT_XBGR2101010,
+       DRM_FORMAT_ABGR2101010,
+       DRM_FORMAT_XBGR8888,
+       DRM_FORMAT_ABGR8888,
+};
+
+static const struct nv50_wndw_func
+nv50_base = {
+       .dtor = nv50_base_dtor,
+       .acquire = nv50_base_acquire,
+       .release = nv50_base_release,
+       .sema_set = nv50_base_sema_set,
+       .sema_clr = nv50_base_sema_clr,
+       .ntfy_set = nv50_base_ntfy_set,
+       .ntfy_clr = nv50_base_ntfy_clr,
+       .ntfy_wait_begun = nv50_base_ntfy_wait_begun,
+       .image_set = nv50_base_image_set,
+       .image_clr = nv50_base_image_clr,
+       .lut = nv50_base_lut,
+       .update = nv50_base_update,
+};
+
+static int
+nv50_base_new(struct nouveau_drm *drm, struct nv50_head *head,
+             struct nv50_base **pbase)
+{
+       struct nv50_disp *disp = nv50_disp(drm->dev);
+       struct nv50_base *base;
+       int ret;
+
+       if (!(base = *pbase = kzalloc(sizeof(*base), GFP_KERNEL)))
+               return -ENOMEM;
+       base->id = head->base.index;
+       base->wndw.ntfy = EVO_FLIP_NTFY0(base->id);
+       base->wndw.sema = EVO_FLIP_SEM0(base->id);
+       base->wndw.data = 0x00000000;
+
+       ret = nv50_wndw_ctor(&nv50_base, drm->dev, DRM_PLANE_TYPE_PRIMARY,
+                            "base", base->id, &base->chan.base,
+                            nv50_base_format, ARRAY_SIZE(nv50_base_format),
+                            &base->wndw);
+       if (ret) {
+               kfree(base);
+               return ret;
+       }
+
+       ret = nv50_base_create(&drm->device, disp->disp, base->id,
+                              disp->sync->bo.offset, &base->chan);
+       if (ret)
+               return ret;
+
+       return nvif_notify_init(&base->chan.base.base.user, nv50_base_notify,
+                               false,
+                               NV50_DISP_BASE_CHANNEL_DMA_V0_NTFY_UEVENT,
+                               &(struct nvif_notify_uevent_req) {},
+                               sizeof(struct nvif_notify_uevent_req),
+                               sizeof(struct nvif_notify_uevent_rep),
+                               &base->wndw.notify);
+}
+
+/******************************************************************************
+ * Head
+ *****************************************************************************/
+static void
+nv50_head_procamp(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 2))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                       evo_mthd(push, 0x08a8 + (head->base.index * 0x400), 1);
+               else
+                       evo_mthd(push, 0x0498 + (head->base.index * 0x300), 1);
+               evo_data(push, (asyh->procamp.sat.sin << 20) |
+                              (asyh->procamp.sat.cos << 8));
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_dither(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 2))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                       evo_mthd(push, 0x08a0 + (head->base.index * 0x0400), 1);
+               else
+               if (core->base.user.oclass < GK104_DISP_CORE_CHANNEL_DMA)
+                       evo_mthd(push, 0x0490 + (head->base.index * 0x0300), 1);
+               else
+                       evo_mthd(push, 0x04a0 + (head->base.index * 0x0300), 1);
+               evo_data(push, (asyh->dither.mode << 3) |
+                              (asyh->dither.bits << 1) |
+                               asyh->dither.enable);
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_ovly(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 bounds = 0;
+       u32 *push;
+
+       if (asyh->base.cpp) {
+               switch (asyh->base.cpp) {
+               case 8: bounds |= 0x00000500; break;
+               case 4: bounds |= 0x00000300; break;
+               case 2: bounds |= 0x00000100; break;
+               default:
+                       WARN_ON(1);
+                       break;
+               }
+               bounds |= 0x00000001;
+       }
+
+       if ((push = evo_wait(core, 2))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                       evo_mthd(push, 0x0904 + head->base.index * 0x400, 1);
+               else
+                       evo_mthd(push, 0x04d4 + head->base.index * 0x300, 1);
+               evo_data(push, bounds);
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_base(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 bounds = 0;
+       u32 *push;
+
+       if (asyh->base.cpp) {
+               switch (asyh->base.cpp) {
+               case 8: bounds |= 0x00000500; break;
+               case 4: bounds |= 0x00000300; break;
+               case 2: bounds |= 0x00000100; break;
+               case 1: bounds |= 0x00000000; break;
+               default:
+                       WARN_ON(1);
+                       break;
+               }
+               bounds |= 0x00000001;
+       }
+
+       if ((push = evo_wait(core, 2))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                       evo_mthd(push, 0x0900 + head->base.index * 0x400, 1);
+               else
+                       evo_mthd(push, 0x04d0 + head->base.index * 0x300, 1);
+               evo_data(push, bounds);
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_curs_clr(struct nv50_head *head)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 4))) {
+               if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0880 + head->base.index * 0x400, 1);
+                       evo_data(push, 0x05000000);
+               } else
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0880 + head->base.index * 0x400, 1);
+                       evo_data(push, 0x05000000);
+                       evo_mthd(push, 0x089c + head->base.index * 0x400, 1);
+                       evo_data(push, 0x00000000);
                } else {
-                       writew(r + 0x6000, lut + (i * 0x20) + 0);
-                       writew(g + 0x6000, lut + (i * 0x20) + 2);
-                       writew(b + 0x6000, lut + (i * 0x20) + 4);
+                       evo_mthd(push, 0x0480 + head->base.index * 0x300, 1);
+                       evo_data(push, 0x05000000);
+                       evo_mthd(push, 0x048c + head->base.index * 0x300, 1);
+                       evo_data(push, 0x00000000);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_curs_set(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 5))) {
+               if (core->base.user.oclass < G82_DISP_BASE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0880 + head->base.index * 0x400, 2);
+                       evo_data(push, 0x80000000 | (asyh->curs.layout << 26) |
+                                                   (asyh->curs.format << 24));
+                       evo_data(push, asyh->curs.offset >> 8);
+               } else
+               if (core->base.user.oclass < GF110_DISP_BASE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0880 + head->base.index * 0x400, 2);
+                       evo_data(push, 0x80000000 | (asyh->curs.layout << 26) |
+                                                   (asyh->curs.format << 24));
+                       evo_data(push, asyh->curs.offset >> 8);
+                       evo_mthd(push, 0x089c + head->base.index * 0x400, 1);
+                       evo_data(push, asyh->curs.handle);
+               } else {
+                       evo_mthd(push, 0x0480 + head->base.index * 0x300, 2);
+                       evo_data(push, 0x80000000 | (asyh->curs.layout << 26) |
+                                                   (asyh->curs.format << 24));
+                       evo_data(push, asyh->curs.offset >> 8);
+                       evo_mthd(push, 0x048c + head->base.index * 0x300, 1);
+                       evo_data(push, asyh->curs.handle);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_core_clr(struct nv50_head *head)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 2))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA)
+                       evo_mthd(push, 0x0874 + head->base.index * 0x400, 1);
+               else
+                       evo_mthd(push, 0x0474 + head->base.index * 0x300, 1);
+               evo_data(push, 0x00000000);
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_core_set(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 9))) {
+               if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0860 + head->base.index * 0x400, 1);
+                       evo_data(push, asyh->core.offset >> 8);
+                       evo_mthd(push, 0x0868 + head->base.index * 0x400, 4);
+                       evo_data(push, (asyh->core.h << 16) | asyh->core.w);
+                       evo_data(push, asyh->core.layout << 20 |
+                                      (asyh->core.pitch >> 8) << 8 |
+                                      asyh->core.block);
+                       evo_data(push, asyh->core.kind << 16 |
+                                      asyh->core.format << 8);
+                       evo_data(push, asyh->core.handle);
+                       evo_mthd(push, 0x08c0 + head->base.index * 0x400, 1);
+                       evo_data(push, (asyh->core.y << 16) | asyh->core.x);
+                       /* EVO will complain with INVALID_STATE if we have an
+                        * active cursor and (re)specify HeadSetContextDmaIso
+                        * without also updating HeadSetOffsetCursor.
+                        */
+                       asyh->set.curs = asyh->curs.visible;
+               } else
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0860 + head->base.index * 0x400, 1);
+                       evo_data(push, asyh->core.offset >> 8);
+                       evo_mthd(push, 0x0868 + head->base.index * 0x400, 4);
+                       evo_data(push, (asyh->core.h << 16) | asyh->core.w);
+                       evo_data(push, asyh->core.layout << 20 |
+                                      (asyh->core.pitch >> 8) << 8 |
+                                      asyh->core.block);
+                       evo_data(push, asyh->core.format << 8);
+                       evo_data(push, asyh->core.handle);
+                       evo_mthd(push, 0x08c0 + head->base.index * 0x400, 1);
+                       evo_data(push, (asyh->core.y << 16) | asyh->core.x);
+               } else {
+                       evo_mthd(push, 0x0460 + head->base.index * 0x300, 1);
+                       evo_data(push, asyh->core.offset >> 8);
+                       evo_mthd(push, 0x0468 + head->base.index * 0x300, 4);
+                       evo_data(push, (asyh->core.h << 16) | asyh->core.w);
+                       evo_data(push, asyh->core.layout << 24 |
+                                      (asyh->core.pitch >> 8) << 8 |
+                                      asyh->core.block);
+                       evo_data(push, asyh->core.format << 8);
+                       evo_data(push, asyh->core.handle);
+                       evo_mthd(push, 0x04b0 + head->base.index * 0x300, 1);
+                       evo_data(push, (asyh->core.y << 16) | asyh->core.x);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_lut_clr(struct nv50_head *head)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 4))) {
+               if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0840 + (head->base.index * 0x400), 1);
+                       evo_data(push, 0x40000000);
+               } else
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0840 + (head->base.index * 0x400), 1);
+                       evo_data(push, 0x40000000);
+                       evo_mthd(push, 0x085c + (head->base.index * 0x400), 1);
+                       evo_data(push, 0x00000000);
+               } else {
+                       evo_mthd(push, 0x0440 + (head->base.index * 0x300), 1);
+                       evo_data(push, 0x03000000);
+                       evo_mthd(push, 0x045c + (head->base.index * 0x300), 1);
+                       evo_data(push, 0x00000000);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_lut_set(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 7))) {
+               if (core->base.user.oclass < G82_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0840 + (head->base.index * 0x400), 2);
+                       evo_data(push, 0xc0000000);
+                       evo_data(push, asyh->lut.offset >> 8);
+               } else
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0840 + (head->base.index * 0x400), 2);
+                       evo_data(push, 0xc0000000);
+                       evo_data(push, asyh->lut.offset >> 8);
+                       evo_mthd(push, 0x085c + (head->base.index * 0x400), 1);
+                       evo_data(push, asyh->lut.handle);
+               } else {
+                       evo_mthd(push, 0x0440 + (head->base.index * 0x300), 4);
+                       evo_data(push, 0x83000000);
+                       evo_data(push, asyh->lut.offset >> 8);
+                       evo_data(push, 0x00000000);
+                       evo_data(push, 0x00000000);
+                       evo_mthd(push, 0x045c + (head->base.index * 0x300), 1);
+                       evo_data(push, asyh->lut.handle);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_mode(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       struct nv50_head_mode *m = &asyh->mode;
+       u32 *push;
+       if ((push = evo_wait(core, 14))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x0804 + (head->base.index * 0x400), 2);
+                       evo_data(push, 0x00800000 | m->clock);
+                       evo_data(push, m->interlace ? 0x00000002 : 0x00000000);
+                       evo_mthd(push, 0x0810 + (head->base.index * 0x400), 7);
+                       evo_data(push, 0x00000000);
+                       evo_data(push, (m->v.active  << 16) | m->h.active );
+                       evo_data(push, (m->v.synce   << 16) | m->h.synce  );
+                       evo_data(push, (m->v.blanke  << 16) | m->h.blanke );
+                       evo_data(push, (m->v.blanks  << 16) | m->h.blanks );
+                       evo_data(push, (m->v.blank2e << 16) | m->v.blank2s);
+                       evo_data(push, asyh->mode.v.blankus);
+                       evo_mthd(push, 0x082c + (head->base.index * 0x400), 1);
+                       evo_data(push, 0x00000000);
+               } else {
+                       evo_mthd(push, 0x0410 + (head->base.index * 0x300), 6);
+                       evo_data(push, 0x00000000);
+                       evo_data(push, (m->v.active  << 16) | m->h.active );
+                       evo_data(push, (m->v.synce   << 16) | m->h.synce  );
+                       evo_data(push, (m->v.blanke  << 16) | m->h.blanke );
+                       evo_data(push, (m->v.blanks  << 16) | m->h.blanks );
+                       evo_data(push, (m->v.blank2e << 16) | m->v.blank2s);
+                       evo_mthd(push, 0x042c + (head->base.index * 0x300), 2);
+                       evo_data(push, 0x00000000); /* ??? */
+                       evo_data(push, 0xffffff00);
+                       evo_mthd(push, 0x0450 + (head->base.index * 0x300), 3);
+                       evo_data(push, m->clock * 1000);
+                       evo_data(push, 0x00200000); /* ??? */
+                       evo_data(push, m->clock * 1000);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_view(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct nv50_dmac *core = &nv50_disp(head->base.base.dev)->mast.base;
+       u32 *push;
+       if ((push = evo_wait(core, 10))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       evo_mthd(push, 0x08a4 + (head->base.index * 0x400), 1);
+                       evo_data(push, 0x00000000);
+                       evo_mthd(push, 0x08c8 + (head->base.index * 0x400), 1);
+                       evo_data(push, (asyh->view.iH << 16) | asyh->view.iW);
+                       evo_mthd(push, 0x08d8 + (head->base.index * 0x400), 2);
+                       evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                       evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+               } else {
+                       evo_mthd(push, 0x0494 + (head->base.index * 0x300), 1);
+                       evo_data(push, 0x00000000);
+                       evo_mthd(push, 0x04b8 + (head->base.index * 0x300), 1);
+                       evo_data(push, (asyh->view.iH << 16) | asyh->view.iW);
+                       evo_mthd(push, 0x04c0 + (head->base.index * 0x300), 3);
+                       evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                       evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+                       evo_data(push, (asyh->view.oH << 16) | asyh->view.oW);
+               }
+               evo_kick(push, core);
+       }
+}
+
+static void
+nv50_head_flush_clr(struct nv50_head *head, struct nv50_head_atom *asyh, bool y)
+{
+       if (asyh->clr.core && (!asyh->set.core || y))
+               nv50_head_lut_clr(head);
+       if (asyh->clr.core && (!asyh->set.core || y))
+               nv50_head_core_clr(head);
+       if (asyh->clr.curs && (!asyh->set.curs || y))
+               nv50_head_curs_clr(head);
+}
+
+static void
+nv50_head_flush_set(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       if (asyh->set.view   ) nv50_head_view    (head, asyh);
+       if (asyh->set.mode   ) nv50_head_mode    (head, asyh);
+       if (asyh->set.core   ) nv50_head_lut_set (head, asyh);
+       if (asyh->set.core   ) nv50_head_core_set(head, asyh);
+       if (asyh->set.curs   ) nv50_head_curs_set(head, asyh);
+       if (asyh->set.base   ) nv50_head_base    (head, asyh);
+       if (asyh->set.ovly   ) nv50_head_ovly    (head, asyh);
+       if (asyh->set.dither ) nv50_head_dither  (head, asyh);
+       if (asyh->set.procamp) nv50_head_procamp (head, asyh);
+}
+
+static void
+nv50_head_atomic_check_procamp(struct nv50_head_atom *armh,
+                              struct nv50_head_atom *asyh,
+                              struct nouveau_conn_atom *asyc)
+{
+       const int vib = asyc->procamp.color_vibrance - 100;
+       const int hue = asyc->procamp.vibrant_hue - 90;
+       const int adj = (vib > 0) ? 50 : 0;
+       asyh->procamp.sat.cos = ((vib * 2047 + adj) / 100) & 0xfff;
+       asyh->procamp.sat.sin = ((hue * 2047) / 100) & 0xfff;
+       asyh->set.procamp = true;
+}
+
+static void
+nv50_head_atomic_check_dither(struct nv50_head_atom *armh,
+                             struct nv50_head_atom *asyh,
+                             struct nouveau_conn_atom *asyc)
+{
+       struct drm_connector *connector = asyc->state.connector;
+       u32 mode = 0x00;
+
+       if (asyc->dither.mode == DITHERING_MODE_AUTO) {
+               if (asyh->base.depth > connector->display_info.bpc * 3)
+                       mode = DITHERING_MODE_DYNAMIC2X2;
+       } else {
+               mode = asyc->dither.mode;
+       }
+
+       if (asyc->dither.depth == DITHERING_DEPTH_AUTO) {
+               if (connector->display_info.bpc >= 8)
+                       mode |= DITHERING_DEPTH_8BPC;
+       } else {
+               mode |= asyc->dither.depth;
+       }
+
+       asyh->dither.enable = mode;
+       asyh->dither.bits = mode >> 1;
+       asyh->dither.mode = mode >> 3;
+       asyh->set.dither = true;
+}
+
+static void
+nv50_head_atomic_check_view(struct nv50_head_atom *armh,
+                           struct nv50_head_atom *asyh,
+                           struct nouveau_conn_atom *asyc)
+{
+       struct drm_connector *connector = asyc->state.connector;
+       struct drm_display_mode *omode = &asyh->state.adjusted_mode;
+       struct drm_display_mode *umode = &asyh->state.mode;
+       int mode = asyc->scaler.mode;
+       struct edid *edid;
+
+       if (connector->edid_blob_ptr)
+               edid = (struct edid *)connector->edid_blob_ptr->data;
+       else
+               edid = NULL;
+
+       if (!asyc->scaler.full) {
+               if (mode == DRM_MODE_SCALE_NONE)
+                       omode = umode;
+       } else {
+               /* Non-EDID LVDS/eDP mode. */
+               mode = DRM_MODE_SCALE_FULLSCREEN;
+       }
+
+       asyh->view.iW = umode->hdisplay;
+       asyh->view.iH = umode->vdisplay;
+       asyh->view.oW = omode->hdisplay;
+       asyh->view.oH = omode->vdisplay;
+       if (omode->flags & DRM_MODE_FLAG_DBLSCAN)
+               asyh->view.oH *= 2;
+
+       /* Add overscan compensation if necessary, will keep the aspect
+        * ratio the same as the backend mode unless overridden by the
+        * user setting both hborder and vborder properties.
+        */
+       if ((asyc->scaler.underscan.mode == UNDERSCAN_ON ||
+           (asyc->scaler.underscan.mode == UNDERSCAN_AUTO &&
+            drm_detect_hdmi_monitor(edid)))) {
+               u32 bX = asyc->scaler.underscan.hborder;
+               u32 bY = asyc->scaler.underscan.vborder;
+               u32 r = (asyh->view.oH << 19) / asyh->view.oW;
+
+               if (bX) {
+                       asyh->view.oW -= (bX * 2);
+                       if (bY) asyh->view.oH -= (bY * 2);
+                       else    asyh->view.oH  = ((asyh->view.oW * r) + (r / 2)) >> 19;
+               } else {
+                       asyh->view.oW -= (asyh->view.oW >> 4) + 32;
+                       if (bY) asyh->view.oH -= (bY * 2);
+                       else    asyh->view.oH  = ((asyh->view.oW * r) + (r / 2)) >> 19;
+               }
+       }
+
+       /* Handle CENTER/ASPECT scaling, taking into account the areas
+        * removed already for overscan compensation.
+        */
+       switch (mode) {
+       case DRM_MODE_SCALE_CENTER:
+               asyh->view.oW = min((u16)umode->hdisplay, asyh->view.oW);
+               asyh->view.oH = min((u16)umode->vdisplay, asyh->view.oH);
+               /* fall-through */
+       case DRM_MODE_SCALE_ASPECT:
+               if (asyh->view.oH < asyh->view.oW) {
+                       u32 r = (asyh->view.iW << 19) / asyh->view.iH;
+                       asyh->view.oW = ((asyh->view.oH * r) + (r / 2)) >> 19;
+               } else {
+                       u32 r = (asyh->view.iH << 19) / asyh->view.iW;
+                       asyh->view.oH = ((asyh->view.oW * r) + (r / 2)) >> 19;
+               }
+               break;
+       default:
+               break;
+       }
+
+       asyh->set.view = true;
+}
+
+static void
+nv50_head_atomic_check_mode(struct nv50_head *head, struct nv50_head_atom *asyh)
+{
+       struct drm_display_mode *mode = &asyh->state.adjusted_mode;
+       u32 ilace   = (mode->flags & DRM_MODE_FLAG_INTERLACE) ? 2 : 1;
+       u32 vscan   = (mode->flags & DRM_MODE_FLAG_DBLSCAN) ? 2 : 1;
+       u32 hbackp  =  mode->htotal - mode->hsync_end;
+       u32 vbackp  = (mode->vtotal - mode->vsync_end) * vscan / ilace;
+       u32 hfrontp =  mode->hsync_start - mode->hdisplay;
+       u32 vfrontp = (mode->vsync_start - mode->vdisplay) * vscan / ilace;
+       struct nv50_head_mode *m = &asyh->mode;
+
+       m->h.active = mode->htotal;
+       m->h.synce  = mode->hsync_end - mode->hsync_start - 1;
+       m->h.blanke = m->h.synce + hbackp;
+       m->h.blanks = mode->htotal - hfrontp - 1;
+
+       m->v.active = mode->vtotal * vscan / ilace;
+       m->v.synce  = ((mode->vsync_end - mode->vsync_start) * vscan / ilace) - 1;
+       m->v.blanke = m->v.synce + vbackp;
+       m->v.blanks = m->v.active - vfrontp - 1;
+
+       /*XXX: Safe underestimate, even "0" works */
+       m->v.blankus = (m->v.active - mode->vdisplay - 2) * m->h.active;
+       m->v.blankus *= 1000;
+       m->v.blankus /= mode->clock;
+
+       if (mode->flags & DRM_MODE_FLAG_INTERLACE) {
+               m->v.blank2e =  m->v.active + m->v.synce + vbackp;
+               m->v.blank2s =  m->v.blank2e + (mode->vdisplay * vscan / ilace);
+               m->v.active  = (m->v.active * 2) + 1;
+               m->interlace = true;
+       } else {
+               m->v.blank2e = 0;
+               m->v.blank2s = 1;
+               m->interlace = false;
+       }
+       m->clock = mode->clock;
+
+       drm_mode_set_crtcinfo(mode, CRTC_INTERLACE_HALVE_V);
+       asyh->set.mode = true;
+}
+
+static int
+nv50_head_atomic_check(struct drm_crtc *crtc, struct drm_crtc_state *state)
+{
+       struct nouveau_drm *drm = nouveau_drm(crtc->dev);
+       struct nv50_disp *disp = nv50_disp(crtc->dev);
+       struct nv50_head *head = nv50_head(crtc);
+       struct nv50_head_atom *armh = nv50_head_atom(crtc->state);
+       struct nv50_head_atom *asyh = nv50_head_atom(state);
+       struct nouveau_conn_atom *asyc = NULL;
+       struct drm_connector_state *conns;
+       struct drm_connector *conn;
+       int i;
+
+       NV_ATOMIC(drm, "%s atomic_check %d\n", crtc->name, asyh->state.active);
+       if (asyh->state.active) {
+               for_each_connector_in_state(asyh->state.state, conn, conns, i) {
+                       if (conns->crtc == crtc) {
+                               asyc = nouveau_conn_atom(conns);
+                               break;
+                       }
+               }
+
+               if (armh->state.active) {
+                       if (asyc) {
+                               if (asyh->state.mode_changed)
+                                       asyc->set.scaler = true;
+                               if (armh->base.depth != asyh->base.depth)
+                                       asyc->set.dither = true;
+                       }
+               } else {
+                       asyc->set.mask = ~0;
+                       asyh->set.mask = ~0;
+               }
+
+               if (asyh->state.mode_changed)
+                       nv50_head_atomic_check_mode(head, asyh);
+
+               if (asyc) {
+                       if (asyc->set.scaler)
+                               nv50_head_atomic_check_view(armh, asyh, asyc);
+                       if (asyc->set.dither)
+                               nv50_head_atomic_check_dither(armh, asyh, asyc);
+                       if (asyc->set.procamp)
+                               nv50_head_atomic_check_procamp(armh, asyh, asyc);
+               }
+
+               if ((asyh->core.visible = (asyh->base.cpp != 0))) {
+                       asyh->core.x = asyh->base.x;
+                       asyh->core.y = asyh->base.y;
+                       asyh->core.w = asyh->base.w;
+                       asyh->core.h = asyh->base.h;
+               } else
+               if ((asyh->core.visible = asyh->curs.visible)) {
+                       /*XXX: We need to either find some way of having the
+                        *     primary base layer appear black, while still
+                        *     being able to display the other layers, or we
+                        *     need to allocate a dummy black surface here.
+                        */
+                       asyh->core.x = 0;
+                       asyh->core.y = 0;
+                       asyh->core.w = asyh->state.mode.hdisplay;
+                       asyh->core.h = asyh->state.mode.vdisplay;
+               }
+               asyh->core.handle = disp->mast.base.vram.handle;
+               asyh->core.offset = 0;
+               asyh->core.format = 0xcf;
+               asyh->core.kind = 0;
+               asyh->core.layout = 1;
+               asyh->core.block = 0;
+               asyh->core.pitch = ALIGN(asyh->core.w, 64) * 4;
+               asyh->lut.handle = disp->mast.base.vram.handle;
+               asyh->lut.offset = head->base.lut.nvbo->bo.offset;
+               asyh->set.base = armh->base.cpp != asyh->base.cpp;
+               asyh->set.ovly = armh->ovly.cpp != asyh->ovly.cpp;
+       } else {
+               asyh->core.visible = false;
+               asyh->curs.visible = false;
+               asyh->base.cpp = 0;
+               asyh->ovly.cpp = 0;
+       }
+
+       if (!drm_atomic_crtc_needs_modeset(&asyh->state)) {
+               if (asyh->core.visible) {
+                       if (memcmp(&armh->core, &asyh->core, sizeof(asyh->core)))
+                               asyh->set.core = true;
+               } else
+               if (armh->core.visible) {
+                       asyh->clr.core = true;
+               }
+
+               if (asyh->curs.visible) {
+                       if (memcmp(&armh->curs, &asyh->curs, sizeof(asyh->curs)))
+                               asyh->set.curs = true;
+               } else
+               if (armh->curs.visible) {
+                       asyh->clr.curs = true;
+               }
+       } else {
+               asyh->clr.core = armh->core.visible;
+               asyh->clr.curs = armh->curs.visible;
+               asyh->set.core = asyh->core.visible;
+               asyh->set.curs = asyh->curs.visible;
+       }
+
+       if (asyh->clr.mask || asyh->set.mask)
+               nv50_atom(asyh->state.state)->lock_core = true;
+       return 0;
+}
+
+static void
+nv50_head_lut_load(struct drm_crtc *crtc)
+{
+       struct nv50_disp *disp = nv50_disp(crtc->dev);
+       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
+       void __iomem *lut = nvbo_kmap_obj_iovirtual(nv_crtc->lut.nvbo);
+       int i;
+
+       for (i = 0; i < 256; i++) {
+               u16 r = nv_crtc->lut.r[i] >> 2;
+               u16 g = nv_crtc->lut.g[i] >> 2;
+               u16 b = nv_crtc->lut.b[i] >> 2;
+
+               if (disp->disp->oclass < GF110_DISP) {
+                       writew(r + 0x0000, lut + (i * 0x08) + 0);
+                       writew(g + 0x0000, lut + (i * 0x08) + 2);
+                       writew(b + 0x0000, lut + (i * 0x08) + 4);
+               } else {
+                       writew(r + 0x6000, lut + (i * 0x20) + 0);
+                       writew(g + 0x6000, lut + (i * 0x20) + 2);
+                       writew(b + 0x6000, lut + (i * 0x20) + 4);
+               }
+       }
+}
+
+static int
+nv50_head_mode_set_base_atomic(struct drm_crtc *crtc,
+                              struct drm_framebuffer *fb, int x, int y,
+                              enum mode_set_atomic state)
+{
+       WARN_ON(1);
+       return 0;
+}
+
+static const struct drm_crtc_helper_funcs
+nv50_head_help = {
+       .mode_set_base_atomic = nv50_head_mode_set_base_atomic,
+       .load_lut = nv50_head_lut_load,
+       .atomic_check = nv50_head_atomic_check,
+};
+
+/* This is identical to the version in the atomic helpers, except that
+ * it supports non-vblanked ("async") page flips.
+ */
+static int
+nv50_head_page_flip(struct drm_crtc *crtc, struct drm_framebuffer *fb,
+                   struct drm_pending_vblank_event *event, u32 flags)
+{
+       struct drm_plane *plane = crtc->primary;
+       struct drm_atomic_state *state;
+       struct drm_plane_state *plane_state;
+       struct drm_crtc_state *crtc_state;
+       int ret = 0;
+
+       state = drm_atomic_state_alloc(plane->dev);
+       if (!state)
+               return -ENOMEM;
+
+       state->acquire_ctx = drm_modeset_legacy_acquire_ctx(crtc);
+retry:
+       crtc_state = drm_atomic_get_crtc_state(state, crtc);
+       if (IS_ERR(crtc_state)) {
+               ret = PTR_ERR(crtc_state);
+               goto fail;
+       }
+       crtc_state->event = event;
+
+       plane_state = drm_atomic_get_plane_state(state, plane);
+       if (IS_ERR(plane_state)) {
+               ret = PTR_ERR(plane_state);
+               goto fail;
+       }
+
+       ret = drm_atomic_set_crtc_for_plane(plane_state, crtc);
+       if (ret != 0)
+               goto fail;
+       drm_atomic_set_fb_for_plane(plane_state, fb);
+
+       /* Make sure we don't accidentally do a full modeset. */
+       state->allow_modeset = false;
+       if (!crtc_state->active) {
+               DRM_DEBUG_ATOMIC("[CRTC:%d] disabled, rejecting legacy flip\n",
+                                crtc->base.id);
+               ret = -EINVAL;
+               goto fail;
+       }
+
+       if (flags & DRM_MODE_PAGE_FLIP_ASYNC)
+               nv50_wndw_atom(plane_state)->interval = 0;
+
+       ret = drm_atomic_nonblocking_commit(state);
+fail:
+       if (ret == -EDEADLK)
+               goto backoff;
+
+       drm_atomic_state_put(state);
+       return ret;
+
+backoff:
+       drm_atomic_state_clear(state);
+       drm_atomic_legacy_backoff(state);
+
+       /*
+        * Someone might have exchanged the framebuffer while we dropped locks
+        * in the backoff code. We need to fix up the fb refcount tracking the
+        * core does for us.
+        */
+       plane->old_fb = plane->fb;
+
+       goto retry;
+}
+
+static int
+nv50_head_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,
+                   uint32_t size)
+{
+       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
+       u32 i;
+
+       for (i = 0; i < size; i++) {
+               nv_crtc->lut.r[i] = r[i];
+               nv_crtc->lut.g[i] = g[i];
+               nv_crtc->lut.b[i] = b[i];
+       }
+
+       nv50_head_lut_load(crtc);
+       return 0;
+}
+
+static void
+nv50_head_atomic_destroy_state(struct drm_crtc *crtc,
+                              struct drm_crtc_state *state)
+{
+       struct nv50_head_atom *asyh = nv50_head_atom(state);
+       __drm_atomic_helper_crtc_destroy_state(&asyh->state);
+       kfree(asyh);
+}
+
+static struct drm_crtc_state *
+nv50_head_atomic_duplicate_state(struct drm_crtc *crtc)
+{
+       struct nv50_head_atom *armh = nv50_head_atom(crtc->state);
+       struct nv50_head_atom *asyh;
+       if (!(asyh = kmalloc(sizeof(*asyh), GFP_KERNEL)))
+               return NULL;
+       __drm_atomic_helper_crtc_duplicate_state(crtc, &asyh->state);
+       asyh->view = armh->view;
+       asyh->mode = armh->mode;
+       asyh->lut  = armh->lut;
+       asyh->core = armh->core;
+       asyh->curs = armh->curs;
+       asyh->base = armh->base;
+       asyh->ovly = armh->ovly;
+       asyh->dither = armh->dither;
+       asyh->procamp = armh->procamp;
+       asyh->clr.mask = 0;
+       asyh->set.mask = 0;
+       return &asyh->state;
+}
+
+static void
+__drm_atomic_helper_crtc_reset(struct drm_crtc *crtc,
+                              struct drm_crtc_state *state)
+{
+       if (crtc->state)
+               crtc->funcs->atomic_destroy_state(crtc, crtc->state);
+       crtc->state = state;
+       crtc->state->crtc = crtc;
+}
+
+static void
+nv50_head_reset(struct drm_crtc *crtc)
+{
+       struct nv50_head_atom *asyh;
+
+       if (WARN_ON(!(asyh = kzalloc(sizeof(*asyh), GFP_KERNEL))))
+               return;
+
+       __drm_atomic_helper_crtc_reset(crtc, &asyh->state);
+}
+
+static void
+nv50_head_destroy(struct drm_crtc *crtc)
+{
+       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
+       struct nv50_disp *disp = nv50_disp(crtc->dev);
+       struct nv50_head *head = nv50_head(crtc);
+
+       nv50_dmac_destroy(&head->ovly.base, disp->disp);
+       nv50_pioc_destroy(&head->oimm.base);
+
+       nouveau_bo_unmap(nv_crtc->lut.nvbo);
+       if (nv_crtc->lut.nvbo)
+               nouveau_bo_unpin(nv_crtc->lut.nvbo);
+       nouveau_bo_ref(NULL, &nv_crtc->lut.nvbo);
+
+       drm_crtc_cleanup(crtc);
+       kfree(crtc);
+}
+
+static const struct drm_crtc_funcs
+nv50_head_func = {
+       .reset = nv50_head_reset,
+       .gamma_set = nv50_head_gamma_set,
+       .destroy = nv50_head_destroy,
+       .set_config = drm_atomic_helper_set_config,
+       .page_flip = nv50_head_page_flip,
+       .set_property = drm_atomic_helper_crtc_set_property,
+       .atomic_duplicate_state = nv50_head_atomic_duplicate_state,
+       .atomic_destroy_state = nv50_head_atomic_destroy_state,
+};
+
+static int
+nv50_head_create(struct drm_device *dev, int index)
+{
+       struct nouveau_drm *drm = nouveau_drm(dev);
+       struct nvif_device *device = &drm->device;
+       struct nv50_disp *disp = nv50_disp(dev);
+       struct nv50_head *head;
+       struct nv50_base *base;
+       struct nv50_curs *curs;
+       struct drm_crtc *crtc;
+       int ret, i;
+
+       head = kzalloc(sizeof(*head), GFP_KERNEL);
+       if (!head)
+               return -ENOMEM;
+
+       head->base.index = index;
+       for (i = 0; i < 256; i++) {
+               head->base.lut.r[i] = i << 8;
+               head->base.lut.g[i] = i << 8;
+               head->base.lut.b[i] = i << 8;
+       }
+
+       ret = nv50_base_new(drm, head, &base);
+       if (ret == 0)
+               ret = nv50_curs_new(drm, head, &curs);
+       if (ret) {
+               kfree(head);
+               return ret;
+       }
+
+       crtc = &head->base.base;
+       drm_crtc_init_with_planes(dev, crtc, &base->wndw.plane,
+                                 &curs->wndw.plane, &nv50_head_func,
+                                 "head-%d", head->base.index);
+       drm_crtc_helper_add(crtc, &nv50_head_help);
+       drm_mode_crtc_set_gamma_size(crtc, 256);
+
+       ret = nouveau_bo_new(dev, 8192, 0x100, TTM_PL_FLAG_VRAM,
+                            0, 0x0000, NULL, NULL, &head->base.lut.nvbo);
+       if (!ret) {
+               ret = nouveau_bo_pin(head->base.lut.nvbo, TTM_PL_FLAG_VRAM, true);
+               if (!ret) {
+                       ret = nouveau_bo_map(head->base.lut.nvbo);
+                       if (ret)
+                               nouveau_bo_unpin(head->base.lut.nvbo);
+               }
+               if (ret)
+                       nouveau_bo_ref(NULL, &head->base.lut.nvbo);
+       }
+
+       if (ret)
+               goto out;
+
+       /* allocate overlay resources */
+       ret = nv50_oimm_create(device, disp->disp, index, &head->oimm);
+       if (ret)
+               goto out;
+
+       ret = nv50_ovly_create(device, disp->disp, index, disp->sync->bo.offset,
+                              &head->ovly);
+       if (ret)
+               goto out;
+
+out:
+       if (ret)
+               nv50_head_destroy(crtc);
+       return ret;
+}
+
+/******************************************************************************
+ * Output path helpers
+ *****************************************************************************/
+static int
+nv50_outp_atomic_check_view(struct drm_encoder *encoder,
+                           struct drm_crtc_state *crtc_state,
+                           struct drm_connector_state *conn_state,
+                           struct drm_display_mode *native_mode)
+{
+       struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode;
+       struct drm_display_mode *mode = &crtc_state->mode;
+       struct drm_connector *connector = conn_state->connector;
+       struct nouveau_conn_atom *asyc = nouveau_conn_atom(conn_state);
+       struct nouveau_drm *drm = nouveau_drm(encoder->dev);
+
+       NV_ATOMIC(drm, "%s atomic_check\n", encoder->name);
+       asyc->scaler.full = false;
+       if (!native_mode)
+               return 0;
+
+       if (asyc->scaler.mode == DRM_MODE_SCALE_NONE) {
+               switch (connector->connector_type) {
+               case DRM_MODE_CONNECTOR_LVDS:
+               case DRM_MODE_CONNECTOR_eDP:
+                       /* Force use of scaler for non-EDID modes. */
+                       if (adjusted_mode->type & DRM_MODE_TYPE_DRIVER)
+                               break;
+                       mode = native_mode;
+                       asyc->scaler.full = true;
+                       break;
+               default:
+                       break;
+               }
+       } else {
+               mode = native_mode;
+       }
+
+       if (!drm_mode_equal(adjusted_mode, mode)) {
+               drm_mode_copy(adjusted_mode, mode);
+               crtc_state->mode_changed = true;
+       }
+
+       return 0;
+}
+
+static int
+nv50_outp_atomic_check(struct drm_encoder *encoder,
+                      struct drm_crtc_state *crtc_state,
+                      struct drm_connector_state *conn_state)
+{
+       struct nouveau_connector *nv_connector =
+               nouveau_connector(conn_state->connector);
+       return nv50_outp_atomic_check_view(encoder, crtc_state, conn_state,
+                                          nv_connector->native_mode);
+}
+
+/******************************************************************************
+ * DAC
+ *****************************************************************************/
+static void
+nv50_dac_dpms(struct drm_encoder *encoder, int mode)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nv50_disp *disp = nv50_disp(encoder->dev);
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_dac_pwr_v0 pwr;
+       } args = {
+               .base.version = 1,
+               .base.method = NV50_DISP_MTHD_V1_DAC_PWR,
+               .base.hasht  = nv_encoder->dcb->hasht,
+               .base.hashm  = nv_encoder->dcb->hashm,
+               .pwr.state = 1,
+               .pwr.data  = 1,
+               .pwr.vsync = (mode != DRM_MODE_DPMS_SUSPEND &&
+                             mode != DRM_MODE_DPMS_OFF),
+               .pwr.hsync = (mode != DRM_MODE_DPMS_STANDBY &&
+                             mode != DRM_MODE_DPMS_OFF),
+       };
+
+       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+}
+
+static void
+nv50_dac_disable(struct drm_encoder *encoder)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nv50_mast *mast = nv50_mast(encoder->dev);
+       const int or = nv_encoder->or;
+       u32 *push;
+
+       if (nv_encoder->crtc) {
+               push = evo_wait(mast, 4);
+               if (push) {
+                       if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+                               evo_mthd(push, 0x0400 + (or * 0x080), 1);
+                               evo_data(push, 0x00000000);
+                       } else {
+                               evo_mthd(push, 0x0180 + (or * 0x020), 1);
+                               evo_data(push, 0x00000000);
+                       }
+                       evo_kick(push, mast);
+               }
+       }
+
+       nv_encoder->crtc = NULL;
+}
+
+static void
+nv50_dac_enable(struct drm_encoder *encoder)
+{
+       struct nv50_mast *mast = nv50_mast(encoder->dev);
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
+       struct drm_display_mode *mode = &nv_crtc->base.state->adjusted_mode;
+       u32 *push;
+
+       push = evo_wait(mast, 8);
+       if (push) {
+               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+                       u32 syncs = 0x00000000;
+
+                       if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                               syncs |= 0x00000001;
+                       if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                               syncs |= 0x00000002;
+
+                       evo_mthd(push, 0x0400 + (nv_encoder->or * 0x080), 2);
+                       evo_data(push, 1 << nv_crtc->index);
+                       evo_data(push, syncs);
+               } else {
+                       u32 magic = 0x31ec6000 | (nv_crtc->index << 25);
+                       u32 syncs = 0x00000001;
+
+                       if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                               syncs |= 0x00000008;
+                       if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                               syncs |= 0x00000010;
+
+                       if (mode->flags & DRM_MODE_FLAG_INTERLACE)
+                               magic |= 0x00000001;
+
+                       evo_mthd(push, 0x0404 + (nv_crtc->index * 0x300), 2);
+                       evo_data(push, syncs);
+                       evo_data(push, magic);
+                       evo_mthd(push, 0x0180 + (nv_encoder->or * 0x020), 1);
+                       evo_data(push, 1 << nv_crtc->index);
+               }
+
+               evo_kick(push, mast);
+       }
+
+       nv_encoder->crtc = encoder->crtc;
+}
+
+static enum drm_connector_status
+nv50_dac_detect(struct drm_encoder *encoder, struct drm_connector *connector)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nv50_disp *disp = nv50_disp(encoder->dev);
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_dac_load_v0 load;
+       } args = {
+               .base.version = 1,
+               .base.method = NV50_DISP_MTHD_V1_DAC_LOAD,
+               .base.hasht  = nv_encoder->dcb->hasht,
+               .base.hashm  = nv_encoder->dcb->hashm,
+       };
+       int ret;
+
+       args.load.data = nouveau_drm(encoder->dev)->vbios.dactestval;
+       if (args.load.data == 0)
+               args.load.data = 340;
+
+       ret = nvif_mthd(disp->disp, 0, &args, sizeof(args));
+       if (ret || !args.load.load)
+               return connector_status_disconnected;
+
+       return connector_status_connected;
+}
+
+static const struct drm_encoder_helper_funcs
+nv50_dac_help = {
+       .dpms = nv50_dac_dpms,
+       .atomic_check = nv50_outp_atomic_check,
+       .enable = nv50_dac_enable,
+       .disable = nv50_dac_disable,
+       .detect = nv50_dac_detect
+};
+
+static void
+nv50_dac_destroy(struct drm_encoder *encoder)
+{
+       drm_encoder_cleanup(encoder);
+       kfree(encoder);
+}
+
+static const struct drm_encoder_funcs
+nv50_dac_func = {
+       .destroy = nv50_dac_destroy,
+};
+
+static int
+nv50_dac_create(struct drm_connector *connector, struct dcb_output *dcbe)
+{
+       struct nouveau_drm *drm = nouveau_drm(connector->dev);
+       struct nvkm_i2c *i2c = nvxx_i2c(&drm->device);
+       struct nvkm_i2c_bus *bus;
+       struct nouveau_encoder *nv_encoder;
+       struct drm_encoder *encoder;
+       int type = DRM_MODE_ENCODER_DAC;
+
+       nv_encoder = kzalloc(sizeof(*nv_encoder), GFP_KERNEL);
+       if (!nv_encoder)
+               return -ENOMEM;
+       nv_encoder->dcb = dcbe;
+       nv_encoder->or = ffs(dcbe->or) - 1;
+
+       bus = nvkm_i2c_bus_find(i2c, dcbe->i2c_index);
+       if (bus)
+               nv_encoder->i2c = &bus->i2c;
+
+       encoder = to_drm_encoder(nv_encoder);
+       encoder->possible_crtcs = dcbe->heads;
+       encoder->possible_clones = 0;
+       drm_encoder_init(connector->dev, encoder, &nv50_dac_func, type,
+                        "dac-%04x-%04x", dcbe->hasht, dcbe->hashm);
+       drm_encoder_helper_add(encoder, &nv50_dac_help);
+
+       drm_mode_connector_attach_encoder(connector, encoder);
+       return 0;
+}
+
+/******************************************************************************
+ * Audio
+ *****************************************************************************/
+static void
+nv50_audio_disable(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nv50_disp *disp = nv50_disp(encoder->dev);
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_sor_hda_eld_v0 eld;
+       } args = {
+               .base.version = 1,
+               .base.method  = NV50_DISP_MTHD_V1_SOR_HDA_ELD,
+               .base.hasht   = nv_encoder->dcb->hasht,
+               .base.hashm   = (0xf0ff & nv_encoder->dcb->hashm) |
+                               (0x0100 << nv_crtc->index),
+       };
+
+       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+}
+
+static void
+nv50_audio_enable(struct drm_encoder *encoder, struct drm_display_mode *mode)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
+       struct nouveau_connector *nv_connector;
+       struct nv50_disp *disp = nv50_disp(encoder->dev);
+       struct __packed {
+               struct {
+                       struct nv50_disp_mthd_v1 mthd;
+                       struct nv50_disp_sor_hda_eld_v0 eld;
+               } base;
+               u8 data[sizeof(nv_connector->base.eld)];
+       } args = {
+               .base.mthd.version = 1,
+               .base.mthd.method  = NV50_DISP_MTHD_V1_SOR_HDA_ELD,
+               .base.mthd.hasht   = nv_encoder->dcb->hasht,
+               .base.mthd.hashm   = (0xf0ff & nv_encoder->dcb->hashm) |
+                                    (0x0100 << nv_crtc->index),
+       };
+
+       nv_connector = nouveau_encoder_connector_get(nv_encoder);
+       if (!drm_detect_monitor_audio(nv_connector->edid))
+               return;
+
+       drm_edid_to_eld(&nv_connector->base, nv_connector->edid);
+       memcpy(args.data, nv_connector->base.eld, sizeof(args.data));
+
+       nvif_mthd(disp->disp, 0, &args,
+                 sizeof(args.base) + drm_eld_size(args.data));
+}
+
+/******************************************************************************
+ * HDMI
+ *****************************************************************************/
+static void
+nv50_hdmi_disable(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nv50_disp *disp = nv50_disp(encoder->dev);
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_sor_hdmi_pwr_v0 pwr;
+       } args = {
+               .base.version = 1,
+               .base.method = NV50_DISP_MTHD_V1_SOR_HDMI_PWR,
+               .base.hasht  = nv_encoder->dcb->hasht,
+               .base.hashm  = (0xf0ff & nv_encoder->dcb->hashm) |
+                              (0x0100 << nv_crtc->index),
+       };
+
+       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+}
+
+static void
+nv50_hdmi_enable(struct drm_encoder *encoder, struct drm_display_mode *mode)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
+       struct nv50_disp *disp = nv50_disp(encoder->dev);
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_sor_hdmi_pwr_v0 pwr;
+       } args = {
+               .base.version = 1,
+               .base.method = NV50_DISP_MTHD_V1_SOR_HDMI_PWR,
+               .base.hasht  = nv_encoder->dcb->hasht,
+               .base.hashm  = (0xf0ff & nv_encoder->dcb->hashm) |
+                              (0x0100 << nv_crtc->index),
+               .pwr.state = 1,
+               .pwr.rekey = 56, /* binary driver, and tegra, constant */
+       };
+       struct nouveau_connector *nv_connector;
+       u32 max_ac_packet;
+
+       nv_connector = nouveau_encoder_connector_get(nv_encoder);
+       if (!drm_detect_hdmi_monitor(nv_connector->edid))
+               return;
+
+       max_ac_packet  = mode->htotal - mode->hdisplay;
+       max_ac_packet -= args.pwr.rekey;
+       max_ac_packet -= 18; /* constant from tegra */
+       args.pwr.max_ac_packet = max_ac_packet / 32;
+
+       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+       nv50_audio_enable(encoder, mode);
+}
+
+/******************************************************************************
+ * MST
+ *****************************************************************************/
+#define nv50_mstm(p) container_of((p), struct nv50_mstm, mgr)
+#define nv50_mstc(p) container_of((p), struct nv50_mstc, connector)
+#define nv50_msto(p) container_of((p), struct nv50_msto, encoder)
+
+struct nv50_mstm {
+       struct nouveau_encoder *outp;
+
+       struct drm_dp_mst_topology_mgr mgr;
+       struct nv50_msto *msto[4];
+
+       bool modified;
+};
+
+struct nv50_mstc {
+       struct nv50_mstm *mstm;
+       struct drm_dp_mst_port *port;
+       struct drm_connector connector;
+
+       struct drm_display_mode *native;
+       struct edid *edid;
+
+       int pbn;
+};
+
+struct nv50_msto {
+       struct drm_encoder encoder;
+
+       struct nv50_head *head;
+       struct nv50_mstc *mstc;
+       bool disabled;
+};
+
+static struct drm_dp_payload *
+nv50_msto_payload(struct nv50_msto *msto)
+{
+       struct nouveau_drm *drm = nouveau_drm(msto->encoder.dev);
+       struct nv50_mstc *mstc = msto->mstc;
+       struct nv50_mstm *mstm = mstc->mstm;
+       int vcpi = mstc->port->vcpi.vcpi, i;
+
+       NV_ATOMIC(drm, "%s: vcpi %d\n", msto->encoder.name, vcpi);
+       for (i = 0; i < mstm->mgr.max_payloads; i++) {
+               struct drm_dp_payload *payload = &mstm->mgr.payloads[i];
+               NV_ATOMIC(drm, "%s: %d: vcpi %d start 0x%02x slots 0x%02x\n",
+                         mstm->outp->base.base.name, i, payload->vcpi,
+                         payload->start_slot, payload->num_slots);
+       }
+
+       for (i = 0; i < mstm->mgr.max_payloads; i++) {
+               struct drm_dp_payload *payload = &mstm->mgr.payloads[i];
+               if (payload->vcpi == vcpi)
+                       return payload;
+       }
+
+       return NULL;
+}
+
+static void
+nv50_msto_cleanup(struct nv50_msto *msto)
+{
+       struct nouveau_drm *drm = nouveau_drm(msto->encoder.dev);
+       struct nv50_mstc *mstc = msto->mstc;
+       struct nv50_mstm *mstm = mstc->mstm;
+
+       NV_ATOMIC(drm, "%s: msto cleanup\n", msto->encoder.name);
+       if (mstc->port && mstc->port->vcpi.vcpi > 0 && !nv50_msto_payload(msto))
+               drm_dp_mst_deallocate_vcpi(&mstm->mgr, mstc->port);
+       if (msto->disabled) {
+               msto->mstc = NULL;
+               msto->head = NULL;
+               msto->disabled = false;
+       }
+}
+
+static void
+nv50_msto_prepare(struct nv50_msto *msto)
+{
+       struct nouveau_drm *drm = nouveau_drm(msto->encoder.dev);
+       struct nv50_mstc *mstc = msto->mstc;
+       struct nv50_mstm *mstm = mstc->mstm;
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_sor_dp_mst_vcpi_v0 vcpi;
+       } args = {
+               .base.version = 1,
+               .base.method = NV50_DISP_MTHD_V1_SOR_DP_MST_VCPI,
+               .base.hasht  = mstm->outp->dcb->hasht,
+               .base.hashm  = (0xf0ff & mstm->outp->dcb->hashm) |
+                              (0x0100 << msto->head->base.index),
+       };
+
+       NV_ATOMIC(drm, "%s: msto prepare\n", msto->encoder.name);
+       if (mstc->port && mstc->port->vcpi.vcpi > 0) {
+               struct drm_dp_payload *payload = nv50_msto_payload(msto);
+               if (payload) {
+                       args.vcpi.start_slot = payload->start_slot;
+                       args.vcpi.num_slots = payload->num_slots;
+                       args.vcpi.pbn = mstc->port->vcpi.pbn;
+                       args.vcpi.aligned_pbn = mstc->port->vcpi.aligned_pbn;
+               }
+       }
+
+       NV_ATOMIC(drm, "%s: %s: %02x %02x %04x %04x\n",
+                 msto->encoder.name, msto->head->base.base.name,
+                 args.vcpi.start_slot, args.vcpi.num_slots,
+                 args.vcpi.pbn, args.vcpi.aligned_pbn);
+       nvif_mthd(&drm->display->disp, 0, &args, sizeof(args));
+}
+
+static int
+nv50_msto_atomic_check(struct drm_encoder *encoder,
+                      struct drm_crtc_state *crtc_state,
+                      struct drm_connector_state *conn_state)
+{
+       struct nv50_mstc *mstc = nv50_mstc(conn_state->connector);
+       struct nv50_mstm *mstm = mstc->mstm;
+       int bpp = conn_state->connector->display_info.bpc * 3;
+       int slots;
+
+       mstc->pbn = drm_dp_calc_pbn_mode(crtc_state->adjusted_mode.clock, bpp);
+
+       slots = drm_dp_find_vcpi_slots(&mstm->mgr, mstc->pbn);
+       if (slots < 0)
+               return slots;
+
+       return nv50_outp_atomic_check_view(encoder, crtc_state, conn_state,
+                                          mstc->native);
+}
+
+static void
+nv50_msto_enable(struct drm_encoder *encoder)
+{
+       struct nv50_head *head = nv50_head(encoder->crtc);
+       struct nv50_msto *msto = nv50_msto(encoder);
+       struct nv50_mstc *mstc = NULL;
+       struct nv50_mstm *mstm = NULL;
+       struct drm_connector *connector;
+       u8 proto, depth;
+       int slots;
+       bool r;
+
+       drm_for_each_connector(connector, encoder->dev) {
+               if (connector->state->best_encoder == &msto->encoder) {
+                       mstc = nv50_mstc(connector);
+                       mstm = mstc->mstm;
+                       break;
                }
        }
-}
-
-static void
-nv50_crtc_disable(struct drm_crtc *crtc)
-{
-       struct nv50_head *head = nv50_head(crtc);
-       evo_sync(crtc->dev);
-       if (head->image)
-               nouveau_bo_unpin(head->image);
-       nouveau_bo_ref(NULL, &head->image);
-}
 
-static int
-nv50_crtc_cursor_set(struct drm_crtc *crtc, struct drm_file *file_priv,
-                    uint32_t handle, uint32_t width, uint32_t height)
-{
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct drm_gem_object *gem = NULL;
-       struct nouveau_bo *nvbo = NULL;
-       int ret = 0;
+       if (WARN_ON(!mstc))
+               return;
 
-       if (handle) {
-               if (width != 64 || height != 64)
-                       return -EINVAL;
+       r = drm_dp_mst_allocate_vcpi(&mstm->mgr, mstc->port, mstc->pbn, &slots);
+       WARN_ON(!r);
 
-               gem = drm_gem_object_lookup(file_priv, handle);
-               if (unlikely(!gem))
-                       return -ENOENT;
-               nvbo = nouveau_gem_object(gem);
+       if (mstm->outp->dcb->sorconf.link & 1)
+               proto = 0x8;
+       else
+               proto = 0x9;
 
-               ret = nouveau_bo_pin(nvbo, TTM_PL_FLAG_VRAM, true);
+       switch (mstc->connector.display_info.bpc) {
+       case  6: depth = 0x2; break;
+       case  8: depth = 0x5; break;
+       case 10:
+       default: depth = 0x6; break;
        }
 
-       if (ret == 0) {
-               if (nv_crtc->cursor.nvbo)
-                       nouveau_bo_unpin(nv_crtc->cursor.nvbo);
-               nouveau_bo_ref(nvbo, &nv_crtc->cursor.nvbo);
-       }
-       drm_gem_object_unreference_unlocked(gem);
+       mstm->outp->update(mstm->outp, head->base.index,
+                          &head->base.base.state->adjusted_mode, proto, depth);
 
-       nv50_crtc_cursor_show_hide(nv_crtc, true, true);
-       return ret;
+       msto->head = head;
+       msto->mstc = mstc;
+       mstm->modified = true;
 }
 
-static int
-nv50_crtc_cursor_move(struct drm_crtc *crtc, int x, int y)
+static void
+nv50_msto_disable(struct drm_encoder *encoder)
 {
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct nv50_curs *curs = nv50_curs(crtc);
-       struct nv50_chan *chan = nv50_chan(curs);
-       nvif_wr32(&chan->user, 0x0084, (y << 16) | (x & 0xffff));
-       nvif_wr32(&chan->user, 0x0080, 0x00000000);
+       struct nv50_msto *msto = nv50_msto(encoder);
+       struct nv50_mstc *mstc = msto->mstc;
+       struct nv50_mstm *mstm = mstc->mstm;
 
-       nv_crtc->cursor_saved_x = x;
-       nv_crtc->cursor_saved_y = y;
-       return 0;
+       if (mstc->port)
+               drm_dp_mst_reset_vcpi_slots(&mstm->mgr, mstc->port);
+
+       mstm->outp->update(mstm->outp, msto->head->base.index, NULL, 0, 0);
+       mstm->modified = true;
+       msto->disabled = true;
+}
+
+static const struct drm_encoder_helper_funcs
+nv50_msto_help = {
+       .disable = nv50_msto_disable,
+       .enable = nv50_msto_enable,
+       .atomic_check = nv50_msto_atomic_check,
+};
+
+static void
+nv50_msto_destroy(struct drm_encoder *encoder)
+{
+       struct nv50_msto *msto = nv50_msto(encoder);
+       drm_encoder_cleanup(&msto->encoder);
+       kfree(msto);
 }
 
+static const struct drm_encoder_funcs
+nv50_msto = {
+       .destroy = nv50_msto_destroy,
+};
+
 static int
-nv50_crtc_gamma_set(struct drm_crtc *crtc, u16 *r, u16 *g, u16 *b,
-                   uint32_t size)
+nv50_msto_new(struct drm_device *dev, u32 heads, const char *name, int id,
+             struct nv50_msto **pmsto)
 {
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       u32 i;
+       struct nv50_msto *msto;
+       int ret;
 
-       for (i = 0; i < size; i++) {
-               nv_crtc->lut.r[i] = r[i];
-               nv_crtc->lut.g[i] = g[i];
-               nv_crtc->lut.b[i] = b[i];
-       }
+       if (!(msto = *pmsto = kzalloc(sizeof(*msto), GFP_KERNEL)))
+               return -ENOMEM;
 
-       nv50_crtc_lut_load(crtc);
+       ret = drm_encoder_init(dev, &msto->encoder, &nv50_msto,
+                              DRM_MODE_ENCODER_DPMST, "%s-mst-%d", name, id);
+       if (ret) {
+               kfree(*pmsto);
+               *pmsto = NULL;
+               return ret;
+       }
 
+       drm_encoder_helper_add(&msto->encoder, &nv50_msto_help);
+       msto->encoder.possible_crtcs = heads;
        return 0;
 }
 
-static void
-nv50_crtc_cursor_restore(struct nouveau_crtc *nv_crtc, int x, int y)
+static struct drm_encoder *
+nv50_mstc_atomic_best_encoder(struct drm_connector *connector,
+                             struct drm_connector_state *connector_state)
 {
-       nv50_crtc_cursor_move(&nv_crtc->base, x, y);
-
-       nv50_crtc_cursor_show_hide(nv_crtc, true, true);
+       struct nv50_head *head = nv50_head(connector_state->crtc);
+       struct nv50_mstc *mstc = nv50_mstc(connector);
+       if (mstc->port) {
+               struct nv50_mstm *mstm = mstc->mstm;
+               return &mstm->msto[head->base.index]->encoder;
+       }
+       return NULL;
 }
 
-static void
-nv50_crtc_destroy(struct drm_crtc *crtc)
+static struct drm_encoder *
+nv50_mstc_best_encoder(struct drm_connector *connector)
 {
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(crtc);
-       struct nv50_disp *disp = nv50_disp(crtc->dev);
-       struct nv50_head *head = nv50_head(crtc);
-       struct nv50_fbdma *fbdma;
-
-       list_for_each_entry(fbdma, &disp->fbdma, head) {
-               nvif_object_fini(&fbdma->base[nv_crtc->index]);
+       struct nv50_mstc *mstc = nv50_mstc(connector);
+       if (mstc->port) {
+               struct nv50_mstm *mstm = mstc->mstm;
+               return &mstm->msto[0]->encoder;
        }
+       return NULL;
+}
 
-       nv50_dmac_destroy(&head->ovly.base, disp->disp);
-       nv50_pioc_destroy(&head->oimm.base);
-       nv50_dmac_destroy(&head->sync.base, disp->disp);
-       nv50_pioc_destroy(&head->curs.base);
+static enum drm_mode_status
+nv50_mstc_mode_valid(struct drm_connector *connector,
+                    struct drm_display_mode *mode)
+{
+       return MODE_OK;
+}
 
-       /*XXX: this shouldn't be necessary, but the core doesn't call
-        *     disconnect() during the cleanup paths
-        */
-       if (head->image)
-               nouveau_bo_unpin(head->image);
-       nouveau_bo_ref(NULL, &head->image);
+static int
+nv50_mstc_get_modes(struct drm_connector *connector)
+{
+       struct nv50_mstc *mstc = nv50_mstc(connector);
+       int ret = 0;
 
-       /*XXX: ditto */
-       if (nv_crtc->cursor.nvbo)
-               nouveau_bo_unpin(nv_crtc->cursor.nvbo);
-       nouveau_bo_ref(NULL, &nv_crtc->cursor.nvbo);
+       mstc->edid = drm_dp_mst_get_edid(&mstc->connector, mstc->port->mgr, mstc->port);
+       drm_mode_connector_update_edid_property(&mstc->connector, mstc->edid);
+       if (mstc->edid) {
+               ret = drm_add_edid_modes(&mstc->connector, mstc->edid);
+               drm_edid_to_eld(&mstc->connector, mstc->edid);
+       }
 
-       nouveau_bo_unmap(nv_crtc->lut.nvbo);
-       if (nv_crtc->lut.nvbo)
-               nouveau_bo_unpin(nv_crtc->lut.nvbo);
-       nouveau_bo_ref(NULL, &nv_crtc->lut.nvbo);
+       if (!mstc->connector.display_info.bpc)
+               mstc->connector.display_info.bpc = 8;
 
-       drm_crtc_cleanup(crtc);
-       kfree(crtc);
+       if (mstc->native)
+               drm_mode_destroy(mstc->connector.dev, mstc->native);
+       mstc->native = nouveau_conn_native_mode(&mstc->connector);
+       return ret;
 }
 
-static const struct drm_crtc_helper_funcs nv50_crtc_hfunc = {
-       .dpms = nv50_crtc_dpms,
-       .prepare = nv50_crtc_prepare,
-       .commit = nv50_crtc_commit,
-       .mode_fixup = nv50_crtc_mode_fixup,
-       .mode_set = nv50_crtc_mode_set,
-       .mode_set_base = nv50_crtc_mode_set_base,
-       .mode_set_base_atomic = nv50_crtc_mode_set_base_atomic,
-       .load_lut = nv50_crtc_lut_load,
-       .disable = nv50_crtc_disable,
+static const struct drm_connector_helper_funcs
+nv50_mstc_help = {
+       .get_modes = nv50_mstc_get_modes,
+       .mode_valid = nv50_mstc_mode_valid,
+       .best_encoder = nv50_mstc_best_encoder,
+       .atomic_best_encoder = nv50_mstc_atomic_best_encoder,
 };
 
-static const struct drm_crtc_funcs nv50_crtc_func = {
-       .cursor_set = nv50_crtc_cursor_set,
-       .cursor_move = nv50_crtc_cursor_move,
-       .gamma_set = nv50_crtc_gamma_set,
-       .set_config = nouveau_crtc_set_config,
-       .destroy = nv50_crtc_destroy,
-       .page_flip = nouveau_crtc_page_flip,
+static enum drm_connector_status
+nv50_mstc_detect(struct drm_connector *connector, bool force)
+{
+       struct nv50_mstc *mstc = nv50_mstc(connector);
+       if (!mstc->port)
+               return connector_status_disconnected;
+       return drm_dp_mst_detect_port(connector, mstc->port->mgr, mstc->port);
+}
+
+static void
+nv50_mstc_destroy(struct drm_connector *connector)
+{
+       struct nv50_mstc *mstc = nv50_mstc(connector);
+       drm_connector_cleanup(&mstc->connector);
+       kfree(mstc);
+}
+
+static const struct drm_connector_funcs
+nv50_mstc = {
+       .dpms = drm_atomic_helper_connector_dpms,
+       .reset = nouveau_conn_reset,
+       .detect = nv50_mstc_detect,
+       .fill_modes = drm_helper_probe_single_connector_modes,
+       .set_property = drm_atomic_helper_connector_set_property,
+       .destroy = nv50_mstc_destroy,
+       .atomic_duplicate_state = nouveau_conn_atomic_duplicate_state,
+       .atomic_destroy_state = nouveau_conn_atomic_destroy_state,
+       .atomic_set_property = nouveau_conn_atomic_set_property,
+       .atomic_get_property = nouveau_conn_atomic_get_property,
 };
 
 static int
-nv50_crtc_create(struct drm_device *dev, int index)
+nv50_mstc_new(struct nv50_mstm *mstm, struct drm_dp_mst_port *port,
+             const char *path, struct nv50_mstc **pmstc)
 {
-       struct nouveau_drm *drm = nouveau_drm(dev);
-       struct nvif_device *device = &drm->device;
-       struct nv50_disp *disp = nv50_disp(dev);
-       struct nv50_head *head;
-       struct drm_crtc *crtc;
+       struct drm_device *dev = mstm->outp->base.base.dev;
+       struct nv50_mstc *mstc;
        int ret, i;
 
-       head = kzalloc(sizeof(*head), GFP_KERNEL);
-       if (!head)
+       if (!(mstc = *pmstc = kzalloc(sizeof(*mstc), GFP_KERNEL)))
                return -ENOMEM;
+       mstc->mstm = mstm;
+       mstc->port = port;
 
-       head->base.index = index;
-       head->base.set_dither = nv50_crtc_set_dither;
-       head->base.set_scale = nv50_crtc_set_scale;
-       head->base.set_color_vibrance = nv50_crtc_set_color_vibrance;
-       head->base.color_vibrance = 50;
-       head->base.vibrant_hue = 0;
-       head->base.cursor.set_pos = nv50_crtc_cursor_restore;
-       for (i = 0; i < 256; i++) {
-               head->base.lut.r[i] = i << 8;
-               head->base.lut.g[i] = i << 8;
-               head->base.lut.b[i] = i << 8;
-       }
-
-       crtc = &head->base.base;
-       drm_crtc_init(dev, crtc, &nv50_crtc_func);
-       drm_crtc_helper_add(crtc, &nv50_crtc_hfunc);
-       drm_mode_crtc_set_gamma_size(crtc, 256);
-
-       ret = nouveau_bo_new(dev, 8192, 0x100, TTM_PL_FLAG_VRAM,
-                            0, 0x0000, NULL, NULL, &head->base.lut.nvbo);
-       if (!ret) {
-               ret = nouveau_bo_pin(head->base.lut.nvbo, TTM_PL_FLAG_VRAM, true);
-               if (!ret) {
-                       ret = nouveau_bo_map(head->base.lut.nvbo);
-                       if (ret)
-                               nouveau_bo_unpin(head->base.lut.nvbo);
-               }
-               if (ret)
-                       nouveau_bo_ref(NULL, &head->base.lut.nvbo);
+       ret = drm_connector_init(dev, &mstc->connector, &nv50_mstc,
+                                DRM_MODE_CONNECTOR_DisplayPort);
+       if (ret) {
+               kfree(*pmstc);
+               *pmstc = NULL;
+               return ret;
        }
 
-       if (ret)
-               goto out;
-
-       /* allocate cursor resources */
-       ret = nv50_curs_create(device, disp->disp, index, &head->curs);
-       if (ret)
-               goto out;
-
-       /* allocate page flip / sync resources */
-       ret = nv50_base_create(device, disp->disp, index, disp->sync->bo.offset,
-                              &head->sync);
-       if (ret)
-               goto out;
+       drm_connector_helper_add(&mstc->connector, &nv50_mstc_help);
 
-       head->sync.addr = EVO_FLIP_SEM0(index);
-       head->sync.data = 0x00000000;
-
-       /* allocate overlay resources */
-       ret = nv50_oimm_create(device, disp->disp, index, &head->oimm);
-       if (ret)
-               goto out;
+       mstc->connector.funcs->reset(&mstc->connector);
+       nouveau_conn_attach_properties(&mstc->connector);
 
-       ret = nv50_ovly_create(device, disp->disp, index, disp->sync->bo.offset,
-                              &head->ovly);
-       if (ret)
-               goto out;
+       for (i = 0; i < ARRAY_SIZE(mstm->msto) && mstm->msto; i++)
+               drm_mode_connector_attach_encoder(&mstc->connector, &mstm->msto[i]->encoder);
 
-out:
-       if (ret)
-               nv50_crtc_destroy(crtc);
-       return ret;
+       drm_object_attach_property(&mstc->connector.base, dev->mode_config.path_property, 0);
+       drm_object_attach_property(&mstc->connector.base, dev->mode_config.tile_property, 0);
+       drm_mode_connector_set_path_property(&mstc->connector, path);
+       return 0;
 }
 
-/******************************************************************************
- * Encoder helpers
- *****************************************************************************/
-static bool
-nv50_encoder_mode_fixup(struct drm_encoder *encoder,
-                       const struct drm_display_mode *mode,
-                       struct drm_display_mode *adjusted_mode)
+static void
+nv50_mstm_cleanup(struct nv50_mstm *mstm)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nouveau_connector *nv_connector;
+       struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev);
+       struct drm_encoder *encoder;
+       int ret;
 
-       nv_connector = nouveau_encoder_connector_get(nv_encoder);
-       if (nv_connector && nv_connector->native_mode) {
-               nv_connector->scaling_full = false;
-               if (nv_connector->scaling_mode == DRM_MODE_SCALE_NONE) {
-                       switch (nv_connector->type) {
-                       case DCB_CONNECTOR_LVDS:
-                       case DCB_CONNECTOR_LVDS_SPWG:
-                       case DCB_CONNECTOR_eDP:
-                               /* force use of scaler for non-edid modes */
-                               if (adjusted_mode->type & DRM_MODE_TYPE_DRIVER)
-                                       return true;
-                               nv_connector->scaling_full = true;
-                               break;
-                       default:
-                               return true;
-                       }
-               }
+       NV_ATOMIC(drm, "%s: mstm cleanup\n", mstm->outp->base.base.name);
+       ret = drm_dp_check_act_status(&mstm->mgr);
+
+       ret = drm_dp_update_payload_part2(&mstm->mgr);
 
-               drm_mode_copy(adjusted_mode, nv_connector->native_mode);
+       drm_for_each_encoder(encoder, mstm->outp->base.base.dev) {
+               if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {
+                       struct nv50_msto *msto = nv50_msto(encoder);
+                       struct nv50_mstc *mstc = msto->mstc;
+                       if (mstc && mstc->mstm == mstm)
+                               nv50_msto_cleanup(msto);
+               }
        }
 
-       return true;
+       mstm->modified = false;
 }
 
-/******************************************************************************
- * DAC
- *****************************************************************************/
 static void
-nv50_dac_dpms(struct drm_encoder *encoder, int mode)
+nv50_mstm_prepare(struct nv50_mstm *mstm)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct {
-               struct nv50_disp_mthd_v1 base;
-               struct nv50_disp_dac_pwr_v0 pwr;
-       } args = {
-               .base.version = 1,
-               .base.method = NV50_DISP_MTHD_V1_DAC_PWR,
-               .base.hasht  = nv_encoder->dcb->hasht,
-               .base.hashm  = nv_encoder->dcb->hashm,
-               .pwr.state = 1,
-               .pwr.data  = 1,
-               .pwr.vsync = (mode != DRM_MODE_DPMS_SUSPEND &&
-                             mode != DRM_MODE_DPMS_OFF),
-               .pwr.hsync = (mode != DRM_MODE_DPMS_STANDBY &&
-                             mode != DRM_MODE_DPMS_OFF),
-       };
+       struct nouveau_drm *drm = nouveau_drm(mstm->outp->base.base.dev);
+       struct drm_encoder *encoder;
+       int ret;
 
-       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+       NV_ATOMIC(drm, "%s: mstm prepare\n", mstm->outp->base.base.name);
+       ret = drm_dp_update_payload_part1(&mstm->mgr);
+
+       drm_for_each_encoder(encoder, mstm->outp->base.base.dev) {
+               if (encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {
+                       struct nv50_msto *msto = nv50_msto(encoder);
+                       struct nv50_mstc *mstc = msto->mstc;
+                       if (mstc && mstc->mstm == mstm)
+                               nv50_msto_prepare(msto);
+               }
+       }
 }
 
 static void
-nv50_dac_commit(struct drm_encoder *encoder)
+nv50_mstm_hotplug(struct drm_dp_mst_topology_mgr *mgr)
 {
+       struct nv50_mstm *mstm = nv50_mstm(mgr);
+       drm_kms_helper_hotplug_event(mstm->outp->base.base.dev);
 }
 
 static void
-nv50_dac_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
-                 struct drm_display_mode *adjusted_mode)
+nv50_mstm_destroy_connector(struct drm_dp_mst_topology_mgr *mgr,
+                           struct drm_connector *connector)
 {
-       struct nv50_mast *mast = nv50_mast(encoder->dev);
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
-       u32 *push;
-
-       nv50_dac_dpms(encoder, DRM_MODE_DPMS_ON);
-
-       push = evo_wait(mast, 8);
-       if (push) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                       u32 syncs = 0x00000000;
-
-                       if (mode->flags & DRM_MODE_FLAG_NHSYNC)
-                               syncs |= 0x00000001;
-                       if (mode->flags & DRM_MODE_FLAG_NVSYNC)
-                               syncs |= 0x00000002;
+       struct nouveau_drm *drm = nouveau_drm(connector->dev);
+       struct nv50_mstc *mstc = nv50_mstc(connector);
 
-                       evo_mthd(push, 0x0400 + (nv_encoder->or * 0x080), 2);
-                       evo_data(push, 1 << nv_crtc->index);
-                       evo_data(push, syncs);
-               } else {
-                       u32 magic = 0x31ec6000 | (nv_crtc->index << 25);
-                       u32 syncs = 0x00000001;
+       drm_connector_unregister(&mstc->connector);
 
-                       if (mode->flags & DRM_MODE_FLAG_NHSYNC)
-                               syncs |= 0x00000008;
-                       if (mode->flags & DRM_MODE_FLAG_NVSYNC)
-                               syncs |= 0x00000010;
+       drm_modeset_lock_all(drm->dev);
+       drm_fb_helper_remove_one_connector(&drm->fbcon->helper, &mstc->connector);
+       mstc->port = NULL;
+       drm_modeset_unlock_all(drm->dev);
 
-                       if (mode->flags & DRM_MODE_FLAG_INTERLACE)
-                               magic |= 0x00000001;
+       drm_connector_unreference(&mstc->connector);
+}
 
-                       evo_mthd(push, 0x0404 + (nv_crtc->index * 0x300), 2);
-                       evo_data(push, syncs);
-                       evo_data(push, magic);
-                       evo_mthd(push, 0x0180 + (nv_encoder->or * 0x020), 1);
-                       evo_data(push, 1 << nv_crtc->index);
-               }
+static void
+nv50_mstm_register_connector(struct drm_connector *connector)
+{
+       struct nouveau_drm *drm = nouveau_drm(connector->dev);
 
-               evo_kick(push, mast);
-       }
+       drm_modeset_lock_all(drm->dev);
+       drm_fb_helper_add_one_connector(&drm->fbcon->helper, connector);
+       drm_modeset_unlock_all(drm->dev);
 
-       nv_encoder->crtc = encoder->crtc;
+       drm_connector_register(connector);
 }
 
-static void
-nv50_dac_disconnect(struct drm_encoder *encoder)
+static struct drm_connector *
+nv50_mstm_add_connector(struct drm_dp_mst_topology_mgr *mgr,
+                       struct drm_dp_mst_port *port, const char *path)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nv50_mast *mast = nv50_mast(encoder->dev);
-       const int or = nv_encoder->or;
-       u32 *push;
-
-       if (nv_encoder->crtc) {
-               nv50_crtc_prepare(nv_encoder->crtc);
+       struct nv50_mstm *mstm = nv50_mstm(mgr);
+       struct nv50_mstc *mstc;
+       int ret;
 
-               push = evo_wait(mast, 4);
-               if (push) {
-                       if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                               evo_mthd(push, 0x0400 + (or * 0x080), 1);
-                               evo_data(push, 0x00000000);
-                       } else {
-                               evo_mthd(push, 0x0180 + (or * 0x020), 1);
-                               evo_data(push, 0x00000000);
-                       }
-                       evo_kick(push, mast);
-               }
+       ret = nv50_mstc_new(mstm, port, path, &mstc);
+       if (ret) {
+               if (mstc)
+                       mstc->connector.funcs->destroy(&mstc->connector);
+               return NULL;
        }
 
-       nv_encoder->crtc = NULL;
+       return &mstc->connector;
 }
 
-static enum drm_connector_status
-nv50_dac_detect(struct drm_encoder *encoder, struct drm_connector *connector)
+static const struct drm_dp_mst_topology_cbs
+nv50_mstm = {
+       .add_connector = nv50_mstm_add_connector,
+       .register_connector = nv50_mstm_register_connector,
+       .destroy_connector = nv50_mstm_destroy_connector,
+       .hotplug = nv50_mstm_hotplug,
+};
+
+void
+nv50_mstm_service(struct nv50_mstm *mstm)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct {
-               struct nv50_disp_mthd_v1 base;
-               struct nv50_disp_dac_load_v0 load;
-       } args = {
-               .base.version = 1,
-               .base.method = NV50_DISP_MTHD_V1_DAC_LOAD,
-               .base.hasht  = nv_encoder->dcb->hasht,
-               .base.hashm  = nv_encoder->dcb->hashm,
-       };
+       struct drm_dp_aux *aux = mstm->mgr.aux;
+       bool handled = true;
        int ret;
+       u8 esi[8] = {};
 
-       args.load.data = nouveau_drm(encoder->dev)->vbios.dactestval;
-       if (args.load.data == 0)
-               args.load.data = 340;
+       while (handled) {
+               ret = drm_dp_dpcd_read(aux, DP_SINK_COUNT_ESI, esi, 8);
+               if (ret != 8) {
+                       drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, false);
+                       return;
+               }
 
-       ret = nvif_mthd(disp->disp, 0, &args, sizeof(args));
-       if (ret || !args.load.load)
-               return connector_status_disconnected;
+               drm_dp_mst_hpd_irq(&mstm->mgr, esi, &handled);
+               if (!handled)
+                       break;
 
-       return connector_status_connected;
+               drm_dp_dpcd_write(aux, DP_SINK_COUNT_ESI + 1, &esi[1], 3);
+       }
 }
 
-static void
-nv50_dac_destroy(struct drm_encoder *encoder)
+void
+nv50_mstm_remove(struct nv50_mstm *mstm)
 {
-       drm_encoder_cleanup(encoder);
-       kfree(encoder);
+       if (mstm)
+               drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, false);
 }
 
-static const struct drm_encoder_helper_funcs nv50_dac_hfunc = {
-       .dpms = nv50_dac_dpms,
-       .mode_fixup = nv50_encoder_mode_fixup,
-       .prepare = nv50_dac_disconnect,
-       .commit = nv50_dac_commit,
-       .mode_set = nv50_dac_mode_set,
-       .disable = nv50_dac_disconnect,
-       .get_crtc = nv50_display_crtc_get,
-       .detect = nv50_dac_detect
-};
-
-static const struct drm_encoder_funcs nv50_dac_func = {
-       .destroy = nv50_dac_destroy,
-};
-
 static int
-nv50_dac_create(struct drm_connector *connector, struct dcb_output *dcbe)
+nv50_mstm_enable(struct nv50_mstm *mstm, u8 dpcd, int state)
 {
-       struct nouveau_drm *drm = nouveau_drm(connector->dev);
-       struct nvkm_i2c *i2c = nvxx_i2c(&drm->device);
-       struct nvkm_i2c_bus *bus;
-       struct nouveau_encoder *nv_encoder;
-       struct drm_encoder *encoder;
-       int type = DRM_MODE_ENCODER_DAC;
+       struct nouveau_encoder *outp = mstm->outp;
+       struct {
+               struct nv50_disp_mthd_v1 base;
+               struct nv50_disp_sor_dp_mst_link_v0 mst;
+       } args = {
+               .base.version = 1,
+               .base.method = NV50_DISP_MTHD_V1_SOR_DP_MST_LINK,
+               .base.hasht = outp->dcb->hasht,
+               .base.hashm = outp->dcb->hashm,
+               .mst.state = state,
+       };
+       struct nouveau_drm *drm = nouveau_drm(outp->base.base.dev);
+       struct nvif_object *disp = &drm->display->disp;
+       int ret;
 
-       nv_encoder = kzalloc(sizeof(*nv_encoder), GFP_KERNEL);
-       if (!nv_encoder)
-               return -ENOMEM;
-       nv_encoder->dcb = dcbe;
-       nv_encoder->or = ffs(dcbe->or) - 1;
+       if (dpcd >= 0x12) {
+               ret = drm_dp_dpcd_readb(mstm->mgr.aux, DP_MSTM_CTRL, &dpcd);
+               if (ret < 0)
+                       return ret;
 
-       bus = nvkm_i2c_bus_find(i2c, dcbe->i2c_index);
-       if (bus)
-               nv_encoder->i2c = &bus->i2c;
+               dpcd &= ~DP_MST_EN;
+               if (state)
+                       dpcd |= DP_MST_EN;
 
-       encoder = to_drm_encoder(nv_encoder);
-       encoder->possible_crtcs = dcbe->heads;
-       encoder->possible_clones = 0;
-       drm_encoder_init(connector->dev, encoder, &nv50_dac_func, type, NULL);
-       drm_encoder_helper_add(encoder, &nv50_dac_hfunc);
+               ret = drm_dp_dpcd_writeb(mstm->mgr.aux, DP_MSTM_CTRL, dpcd);
+               if (ret < 0)
+                       return ret;
+       }
 
-       drm_mode_connector_attach_encoder(connector, encoder);
-       return 0;
+       return nvif_mthd(disp, 0, &args, sizeof(args));
 }
 
-/******************************************************************************
- * Audio
- *****************************************************************************/
-static void
-nv50_audio_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode)
+int
+nv50_mstm_detect(struct nv50_mstm *mstm, u8 dpcd[8], int allow)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
-       struct nouveau_connector *nv_connector;
-       struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct __packed {
-               struct {
-                       struct nv50_disp_mthd_v1 mthd;
-                       struct nv50_disp_sor_hda_eld_v0 eld;
-               } base;
-               u8 data[sizeof(nv_connector->base.eld)];
-       } args = {
-               .base.mthd.version = 1,
-               .base.mthd.method  = NV50_DISP_MTHD_V1_SOR_HDA_ELD,
-               .base.mthd.hasht   = nv_encoder->dcb->hasht,
-               .base.mthd.hashm   = (0xf0ff & nv_encoder->dcb->hashm) |
-                                    (0x0100 << nv_crtc->index),
-       };
+       int ret, state = 0;
 
-       nv_connector = nouveau_encoder_connector_get(nv_encoder);
-       if (!drm_detect_monitor_audio(nv_connector->edid))
-               return;
+       if (!mstm)
+               return 0;
 
-       drm_edid_to_eld(&nv_connector->base, nv_connector->edid);
-       memcpy(args.data, nv_connector->base.eld, sizeof(args.data));
+       if (dpcd[0] >= 0x12) {
+               ret = drm_dp_dpcd_readb(mstm->mgr.aux, DP_MSTM_CAP, &dpcd[1]);
+               if (ret < 0)
+                       return ret;
 
-       nvif_mthd(disp->disp, 0, &args,
-                 sizeof(args.base) + drm_eld_size(args.data));
+               if (!(dpcd[1] & DP_MST_CAP))
+                       dpcd[0] = 0x11;
+               else
+                       state = allow;
+       }
+
+       ret = nv50_mstm_enable(mstm, dpcd[0], state);
+       if (ret)
+               return ret;
+
+       ret = drm_dp_mst_topology_mgr_set_mst(&mstm->mgr, state);
+       if (ret)
+               return nv50_mstm_enable(mstm, dpcd[0], 0);
+
+       return mstm->mgr.mst_state;
 }
 
 static void
-nv50_audio_disconnect(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
+nv50_mstm_fini(struct nv50_mstm *mstm)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct {
-               struct nv50_disp_mthd_v1 base;
-               struct nv50_disp_sor_hda_eld_v0 eld;
-       } args = {
-               .base.version = 1,
-               .base.method  = NV50_DISP_MTHD_V1_SOR_HDA_ELD,
-               .base.hasht   = nv_encoder->dcb->hasht,
-               .base.hashm   = (0xf0ff & nv_encoder->dcb->hashm) |
-                               (0x0100 << nv_crtc->index),
-       };
+       if (mstm && mstm->mgr.mst_state)
+               drm_dp_mst_topology_mgr_suspend(&mstm->mgr);
+}
 
-       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+static void
+nv50_mstm_init(struct nv50_mstm *mstm)
+{
+       if (mstm && mstm->mgr.mst_state)
+               drm_dp_mst_topology_mgr_resume(&mstm->mgr);
 }
 
-/******************************************************************************
- * HDMI
- *****************************************************************************/
 static void
-nv50_hdmi_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode)
+nv50_mstm_del(struct nv50_mstm **pmstm)
 {
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
-       struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct {
-               struct nv50_disp_mthd_v1 base;
-               struct nv50_disp_sor_hdmi_pwr_v0 pwr;
-       } args = {
-               .base.version = 1,
-               .base.method = NV50_DISP_MTHD_V1_SOR_HDMI_PWR,
-               .base.hasht  = nv_encoder->dcb->hasht,
-               .base.hashm  = (0xf0ff & nv_encoder->dcb->hashm) |
-                              (0x0100 << nv_crtc->index),
-               .pwr.state = 1,
-               .pwr.rekey = 56, /* binary driver, and tegra, constant */
-       };
-       struct nouveau_connector *nv_connector;
-       u32 max_ac_packet;
+       struct nv50_mstm *mstm = *pmstm;
+       if (mstm) {
+               kfree(*pmstm);
+               *pmstm = NULL;
+       }
+}
 
-       nv_connector = nouveau_encoder_connector_get(nv_encoder);
-       if (!drm_detect_hdmi_monitor(nv_connector->edid))
-               return;
+static int
+nv50_mstm_new(struct nouveau_encoder *outp, struct drm_dp_aux *aux, int aux_max,
+             int conn_base_id, struct nv50_mstm **pmstm)
+{
+       const int max_payloads = hweight8(outp->dcb->heads);
+       struct drm_device *dev = outp->base.base.dev;
+       struct nv50_mstm *mstm;
+       int ret, i;
+       u8 dpcd;
 
-       max_ac_packet  = mode->htotal - mode->hdisplay;
-       max_ac_packet -= args.pwr.rekey;
-       max_ac_packet -= 18; /* constant from tegra */
-       args.pwr.max_ac_packet = max_ac_packet / 32;
+       /* This is a workaround for some monitors not functioning
+        * correctly in MST mode on initial module load.  I think
+        * some bad interaction with the VBIOS may be responsible.
+        *
+        * A good ol' off and on again seems to work here ;)
+        */
+       ret = drm_dp_dpcd_readb(aux, DP_DPCD_REV, &dpcd);
+       if (ret >= 0 && dpcd >= 0x12)
+               drm_dp_dpcd_writeb(aux, DP_MSTM_CTRL, 0);
 
-       nvif_mthd(disp->disp, 0, &args, sizeof(args));
-       nv50_audio_mode_set(encoder, mode);
-}
+       if (!(mstm = *pmstm = kzalloc(sizeof(*mstm), GFP_KERNEL)))
+               return -ENOMEM;
+       mstm->outp = outp;
+       mstm->mgr.cbs = &nv50_mstm;
 
-static void
-nv50_hdmi_disconnect(struct drm_encoder *encoder, struct nouveau_crtc *nv_crtc)
-{
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct {
-               struct nv50_disp_mthd_v1 base;
-               struct nv50_disp_sor_hdmi_pwr_v0 pwr;
-       } args = {
-               .base.version = 1,
-               .base.method = NV50_DISP_MTHD_V1_SOR_HDMI_PWR,
-               .base.hasht  = nv_encoder->dcb->hasht,
-               .base.hashm  = (0xf0ff & nv_encoder->dcb->hashm) |
-                              (0x0100 << nv_crtc->index),
-       };
+       ret = drm_dp_mst_topology_mgr_init(&mstm->mgr, dev->dev, aux, aux_max,
+                                          max_payloads, conn_base_id);
+       if (ret)
+               return ret;
 
-       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+       for (i = 0; i < max_payloads; i++) {
+               ret = nv50_msto_new(dev, outp->dcb->heads, outp->base.base.name,
+                                   i, &mstm->msto[i]);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
 }
 
 /******************************************************************************
@@ -1861,89 +3452,91 @@ nv50_sor_dpms(struct drm_encoder *encoder, int mode)
                .base.hashm  = nv_encoder->dcb->hashm,
                .pwr.state = mode == DRM_MODE_DPMS_ON,
        };
-       struct {
-               struct nv50_disp_mthd_v1 base;
-               struct nv50_disp_sor_dp_pwr_v0 pwr;
-       } link = {
-               .base.version = 1,
-               .base.method = NV50_DISP_MTHD_V1_SOR_DP_PWR,
-               .base.hasht  = nv_encoder->dcb->hasht,
-               .base.hashm  = nv_encoder->dcb->hashm,
-               .pwr.state = mode == DRM_MODE_DPMS_ON,
-       };
-       struct drm_device *dev = encoder->dev;
-       struct drm_encoder *partner;
-
-       nv_encoder->last_dpms = mode;
-
-       list_for_each_entry(partner, &dev->mode_config.encoder_list, head) {
-               struct nouveau_encoder *nv_partner = nouveau_encoder(partner);
 
-               if (partner->encoder_type != DRM_MODE_ENCODER_TMDS)
-                       continue;
+       nvif_mthd(disp->disp, 0, &args, sizeof(args));
+}
 
-               if (nv_partner != nv_encoder &&
-                   nv_partner->dcb->or == nv_encoder->dcb->or) {
-                       if (nv_partner->last_dpms == DRM_MODE_DPMS_ON)
-                               return;
-                       break;
-               }
-       }
+static void
+nv50_sor_update(struct nouveau_encoder *nv_encoder, u8 head,
+               struct drm_display_mode *mode, u8 proto, u8 depth)
+{
+       struct nv50_dmac *core = &nv50_mast(nv_encoder->base.base.dev)->base;
+       u32 *push;
 
-       if (nv_encoder->dcb->type == DCB_OUTPUT_DP) {
-               args.pwr.state = 1;
-               nvif_mthd(disp->disp, 0, &args, sizeof(args));
-               nvif_mthd(disp->disp, 0, &link, sizeof(link));
+       if (!mode) {
+               nv_encoder->ctrl &= ~BIT(head);
+               if (!(nv_encoder->ctrl & 0x0000000f))
+                       nv_encoder->ctrl = 0;
        } else {
-               nvif_mthd(disp->disp, 0, &args, sizeof(args));
+               nv_encoder->ctrl |= proto << 8;
+               nv_encoder->ctrl |= BIT(head);
        }
-}
 
-static void
-nv50_sor_ctrl(struct nouveau_encoder *nv_encoder, u32 mask, u32 data)
-{
-       struct nv50_mast *mast = nv50_mast(nv_encoder->base.base.dev);
-       u32 temp = (nv_encoder->ctrl & ~mask) | (data & mask), *push;
-       if (temp != nv_encoder->ctrl && (push = evo_wait(mast, 2))) {
-               if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+       if ((push = evo_wait(core, 6))) {
+               if (core->base.user.oclass < GF110_DISP_CORE_CHANNEL_DMA) {
+                       if (mode) {
+                               if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                                       nv_encoder->ctrl |= 0x00001000;
+                               if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                                       nv_encoder->ctrl |= 0x00002000;
+                               nv_encoder->ctrl |= depth << 16;
+                       }
                        evo_mthd(push, 0x0600 + (nv_encoder->or * 0x40), 1);
-                       evo_data(push, (nv_encoder->ctrl = temp));
                } else {
+                       if (mode) {
+                               u32 magic = 0x31ec6000 | (head << 25);
+                               u32 syncs = 0x00000001;
+                               if (mode->flags & DRM_MODE_FLAG_NHSYNC)
+                                       syncs |= 0x00000008;
+                               if (mode->flags & DRM_MODE_FLAG_NVSYNC)
+                                       syncs |= 0x00000010;
+                               if (mode->flags & DRM_MODE_FLAG_INTERLACE)
+                                       magic |= 0x00000001;
+
+                               evo_mthd(push, 0x0404 + (head * 0x300), 2);
+                               evo_data(push, syncs | (depth << 6));
+                               evo_data(push, magic);
+                       }
                        evo_mthd(push, 0x0200 + (nv_encoder->or * 0x20), 1);
-                       evo_data(push, (nv_encoder->ctrl = temp));
                }
-               evo_kick(push, mast);
+               evo_data(push, nv_encoder->ctrl);
+               evo_kick(push, core);
        }
 }
 
 static void
-nv50_sor_disconnect(struct drm_encoder *encoder)
+nv50_sor_disable(struct drm_encoder *encoder)
 {
        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
        struct nouveau_crtc *nv_crtc = nouveau_crtc(nv_encoder->crtc);
 
-       nv_encoder->last_dpms = DRM_MODE_DPMS_OFF;
        nv_encoder->crtc = NULL;
 
        if (nv_crtc) {
-               nv50_crtc_prepare(&nv_crtc->base);
-               nv50_sor_ctrl(nv_encoder, 1 << nv_crtc->index, 0);
-               nv50_audio_disconnect(encoder, nv_crtc);
-               nv50_hdmi_disconnect(&nv_encoder->base.base, nv_crtc);
-       }
-}
+               struct nvkm_i2c_aux *aux = nv_encoder->aux;
+               u8 pwr;
 
-static void
-nv50_sor_commit(struct drm_encoder *encoder)
-{
+               if (aux) {
+                       int ret = nvkm_rdaux(aux, DP_SET_POWER, &pwr, 1);
+                       if (ret == 0) {
+                               pwr &= ~DP_SET_POWER_MASK;
+                               pwr |=  DP_SET_POWER_D3;
+                               nvkm_wraux(aux, DP_SET_POWER, &pwr, 1);
+                       }
+               }
+
+               nv_encoder->update(nv_encoder, nv_crtc->index, NULL, 0, 0);
+               nv50_audio_disable(encoder, nv_crtc);
+               nv50_hdmi_disable(&nv_encoder->base.base, nv_crtc);
+       }
 }
 
 static void
-nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
-                 struct drm_display_mode *mode)
+nv50_sor_enable(struct drm_encoder *encoder)
 {
        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
        struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
+       struct drm_display_mode *mode = &nv_crtc->base.state->adjusted_mode;
        struct {
                struct nv50_disp_mthd_v1 base;
                struct nv50_disp_sor_lvds_script_v0 lvds;
@@ -1954,13 +3547,10 @@ nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
                .base.hashm   = nv_encoder->dcb->hashm,
        };
        struct nv50_disp *disp = nv50_disp(encoder->dev);
-       struct nv50_mast *mast = nv50_mast(encoder->dev);
        struct drm_device *dev = encoder->dev;
        struct nouveau_drm *drm = nouveau_drm(dev);
        struct nouveau_connector *nv_connector;
        struct nvbios *bios = &drm->vbios;
-       u32 mask, ctrl;
-       u8 owner = 1 << nv_crtc->index;
        u8 proto = 0xf;
        u8 depth = 0x0;
 
@@ -1985,7 +3575,7 @@ nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
                        proto = 0x2;
                }
 
-               nv50_hdmi_mode_set(&nv_encoder->base.base, mode);
+               nv50_hdmi_enable(&nv_encoder->base.base, mode);
                break;
        case DCB_OUTPUT_LVDS:
                proto = 0x0;
@@ -2019,94 +3609,60 @@ nv50_sor_mode_set(struct drm_encoder *encoder, struct drm_display_mode *umode,
                nvif_mthd(disp->disp, 0, &lvds, sizeof(lvds));
                break;
        case DCB_OUTPUT_DP:
-               if (nv_connector->base.display_info.bpc == 6) {
-                       nv_encoder->dp.datarate = mode->clock * 18 / 8;
+               if (nv_connector->base.display_info.bpc == 6)
                        depth = 0x2;
-               } else
-               if (nv_connector->base.display_info.bpc == 8) {
-                       nv_encoder->dp.datarate = mode->clock * 24 / 8;
+               else
+               if (nv_connector->base.display_info.bpc == 8)
                        depth = 0x5;
-               } else {
-                       nv_encoder->dp.datarate = mode->clock * 30 / 8;
+               else
                        depth = 0x6;
-               }
 
                if (nv_encoder->dcb->sorconf.link & 1)
                        proto = 0x8;
                else
                        proto = 0x9;
-               nv50_audio_mode_set(encoder, mode);
+
+               nv50_audio_enable(encoder, mode);
                break;
        default:
                BUG_ON(1);
                break;
        }
 
-       nv50_sor_dpms(&nv_encoder->base.base, DRM_MODE_DPMS_ON);
-
-       if (nv50_vers(mast) >= GF110_DISP) {
-               u32 *push = evo_wait(mast, 3);
-               if (push) {
-                       u32 magic = 0x31ec6000 | (nv_crtc->index << 25);
-                       u32 syncs = 0x00000001;
-
-                       if (mode->flags & DRM_MODE_FLAG_NHSYNC)
-                               syncs |= 0x00000008;
-                       if (mode->flags & DRM_MODE_FLAG_NVSYNC)
-                               syncs |= 0x00000010;
-
-                       if (mode->flags & DRM_MODE_FLAG_INTERLACE)
-                               magic |= 0x00000001;
-
-                       evo_mthd(push, 0x0404 + (nv_crtc->index * 0x300), 2);
-                       evo_data(push, syncs | (depth << 6));
-                       evo_data(push, magic);
-                       evo_kick(push, mast);
-               }
-
-               ctrl = proto << 8;
-               mask = 0x00000f00;
-       } else {
-               ctrl = (depth << 16) | (proto << 8);
-               if (mode->flags & DRM_MODE_FLAG_NHSYNC)
-                       ctrl |= 0x00001000;
-               if (mode->flags & DRM_MODE_FLAG_NVSYNC)
-                       ctrl |= 0x00002000;
-               mask = 0x000f3f00;
-       }
-
-       nv50_sor_ctrl(nv_encoder, mask | owner, ctrl | owner);
+       nv_encoder->update(nv_encoder, nv_crtc->index, mode, proto, depth);
 }
 
+static const struct drm_encoder_helper_funcs
+nv50_sor_help = {
+       .dpms = nv50_sor_dpms,
+       .atomic_check = nv50_outp_atomic_check,
+       .enable = nv50_sor_enable,
+       .disable = nv50_sor_disable,
+};
+
 static void
 nv50_sor_destroy(struct drm_encoder *encoder)
 {
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       nv50_mstm_del(&nv_encoder->dp.mstm);
        drm_encoder_cleanup(encoder);
        kfree(encoder);
 }
 
-static const struct drm_encoder_helper_funcs nv50_sor_hfunc = {
-       .dpms = nv50_sor_dpms,
-       .mode_fixup = nv50_encoder_mode_fixup,
-       .prepare = nv50_sor_disconnect,
-       .commit = nv50_sor_commit,
-       .mode_set = nv50_sor_mode_set,
-       .disable = nv50_sor_disconnect,
-       .get_crtc = nv50_display_crtc_get,
-};
-
-static const struct drm_encoder_funcs nv50_sor_func = {
+static const struct drm_encoder_funcs
+nv50_sor_func = {
        .destroy = nv50_sor_destroy,
 };
 
 static int
 nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
 {
+       struct nouveau_connector *nv_connector = nouveau_connector(connector);
        struct nouveau_drm *drm = nouveau_drm(connector->dev);
        struct nvkm_i2c *i2c = nvxx_i2c(&drm->device);
        struct nouveau_encoder *nv_encoder;
        struct drm_encoder *encoder;
-       int type;
+       int type, ret;
 
        switch (dcbe->type) {
        case DCB_OUTPUT_LVDS: type = DRM_MODE_ENCODER_LVDS; break;
@@ -2122,7 +3678,16 @@ nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
                return -ENOMEM;
        nv_encoder->dcb = dcbe;
        nv_encoder->or = ffs(dcbe->or) - 1;
-       nv_encoder->last_dpms = DRM_MODE_DPMS_OFF;
+       nv_encoder->update = nv50_sor_update;
+
+       encoder = to_drm_encoder(nv_encoder);
+       encoder->possible_crtcs = dcbe->heads;
+       encoder->possible_clones = 0;
+       drm_encoder_init(connector->dev, encoder, &nv50_sor_func, type,
+                        "sor-%04x-%04x", dcbe->hasht, dcbe->hashm);
+       drm_encoder_helper_add(encoder, &nv50_sor_help);
+
+       drm_mode_connector_attach_encoder(connector, encoder);
 
        if (dcbe->type == DCB_OUTPUT_DP) {
                struct nvkm_i2c_aux *aux =
@@ -2131,6 +3696,15 @@ nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
                        nv_encoder->i2c = &aux->i2c;
                        nv_encoder->aux = aux;
                }
+
+               /*TODO: Use DP Info Table to check for support. */
+               if (nv50_disp(encoder->dev)->disp->oclass >= GF110_DISP) {
+                       ret = nv50_mstm_new(nv_encoder, &nv_connector->aux, 16,
+                                           nv_connector->base.base.id,
+                                           &nv_encoder->dp.mstm);
+                       if (ret)
+                               return ret;
+               }
        } else {
                struct nvkm_i2c_bus *bus =
                        nvkm_i2c_bus_find(i2c, dcbe->i2c_index);
@@ -2138,20 +3712,12 @@ nv50_sor_create(struct drm_connector *connector, struct dcb_output *dcbe)
                        nv_encoder->i2c = &bus->i2c;
        }
 
-       encoder = to_drm_encoder(nv_encoder);
-       encoder->possible_crtcs = dcbe->heads;
-       encoder->possible_clones = 0;
-       drm_encoder_init(connector->dev, encoder, &nv50_sor_func, type, NULL);
-       drm_encoder_helper_add(encoder, &nv50_sor_hfunc);
-
-       drm_mode_connector_attach_encoder(connector, encoder);
        return 0;
 }
 
 /******************************************************************************
  * PIOR
  *****************************************************************************/
-
 static void
 nv50_pior_dpms(struct drm_encoder *encoder, int mode)
 {
@@ -2172,30 +3738,48 @@ nv50_pior_dpms(struct drm_encoder *encoder, int mode)
        nvif_mthd(disp->disp, 0, &args, sizeof(args));
 }
 
-static bool
-nv50_pior_mode_fixup(struct drm_encoder *encoder,
-                    const struct drm_display_mode *mode,
-                    struct drm_display_mode *adjusted_mode)
-{
-       if (!nv50_encoder_mode_fixup(encoder, mode, adjusted_mode))
-               return false;
-       adjusted_mode->clock *= 2;
-       return true;
-}
+static int
+nv50_pior_atomic_check(struct drm_encoder *encoder,
+                      struct drm_crtc_state *crtc_state,
+                      struct drm_connector_state *conn_state)
+{
+       int ret = nv50_outp_atomic_check(encoder, crtc_state, conn_state);
+       if (ret)
+               return ret;
+       crtc_state->adjusted_mode.clock *= 2;
+       return 0;
+}
+
+static void
+nv50_pior_disable(struct drm_encoder *encoder)
+{
+       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
+       struct nv50_mast *mast = nv50_mast(encoder->dev);
+       const int or = nv_encoder->or;
+       u32 *push;
+
+       if (nv_encoder->crtc) {
+               push = evo_wait(mast, 4);
+               if (push) {
+                       if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
+                               evo_mthd(push, 0x0700 + (or * 0x040), 1);
+                               evo_data(push, 0x00000000);
+                       }
+                       evo_kick(push, mast);
+               }
+       }
 
-static void
-nv50_pior_commit(struct drm_encoder *encoder)
-{
+       nv_encoder->crtc = NULL;
 }
 
 static void
-nv50_pior_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
-                  struct drm_display_mode *adjusted_mode)
+nv50_pior_enable(struct drm_encoder *encoder)
 {
        struct nv50_mast *mast = nv50_mast(encoder->dev);
        struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
        struct nouveau_crtc *nv_crtc = nouveau_crtc(encoder->crtc);
        struct nouveau_connector *nv_connector;
+       struct drm_display_mode *mode = &nv_crtc->base.state->adjusted_mode;
        u8 owner = 1 << nv_crtc->index;
        u8 proto, depth;
        u32 *push;
@@ -2218,8 +3802,6 @@ nv50_pior_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
                break;
        }
 
-       nv50_pior_dpms(encoder, DRM_MODE_DPMS_ON);
-
        push = evo_wait(mast, 8);
        if (push) {
                if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
@@ -2238,29 +3820,13 @@ nv50_pior_mode_set(struct drm_encoder *encoder, struct drm_display_mode *mode,
        nv_encoder->crtc = encoder->crtc;
 }
 
-static void
-nv50_pior_disconnect(struct drm_encoder *encoder)
-{
-       struct nouveau_encoder *nv_encoder = nouveau_encoder(encoder);
-       struct nv50_mast *mast = nv50_mast(encoder->dev);
-       const int or = nv_encoder->or;
-       u32 *push;
-
-       if (nv_encoder->crtc) {
-               nv50_crtc_prepare(nv_encoder->crtc);
-
-               push = evo_wait(mast, 4);
-               if (push) {
-                       if (nv50_vers(mast) < GF110_DISP_CORE_CHANNEL_DMA) {
-                               evo_mthd(push, 0x0700 + (or * 0x040), 1);
-                               evo_data(push, 0x00000000);
-                       }
-                       evo_kick(push, mast);
-               }
-       }
-
-       nv_encoder->crtc = NULL;
-}
+static const struct drm_encoder_helper_funcs
+nv50_pior_help = {
+       .dpms = nv50_pior_dpms,
+       .atomic_check = nv50_pior_atomic_check,
+       .enable = nv50_pior_enable,
+       .disable = nv50_pior_disable,
+};
 
 static void
 nv50_pior_destroy(struct drm_encoder *encoder)
@@ -2269,17 +3835,8 @@ nv50_pior_destroy(struct drm_encoder *encoder)
        kfree(encoder);
 }
 
-static const struct drm_encoder_helper_funcs nv50_pior_hfunc = {
-       .dpms = nv50_pior_dpms,
-       .mode_fixup = nv50_pior_mode_fixup,
-       .prepare = nv50_pior_disconnect,
-       .commit = nv50_pior_commit,
-       .mode_set = nv50_pior_mode_set,
-       .disable = nv50_pior_disconnect,
-       .get_crtc = nv50_display_crtc_get,
-};
-
-static const struct drm_encoder_funcs nv50_pior_func = {
+static const struct drm_encoder_funcs
+nv50_pior_func = {
        .destroy = nv50_pior_destroy,
 };
 
@@ -2321,149 +3878,464 @@ nv50_pior_create(struct drm_connector *connector, struct dcb_output *dcbe)
        encoder = to_drm_encoder(nv_encoder);
        encoder->possible_crtcs = dcbe->heads;
        encoder->possible_clones = 0;
-       drm_encoder_init(connector->dev, encoder, &nv50_pior_func, type, NULL);
-       drm_encoder_helper_add(encoder, &nv50_pior_hfunc);
+       drm_encoder_init(connector->dev, encoder, &nv50_pior_func, type,
+                        "pior-%04x-%04x", dcbe->hasht, dcbe->hashm);
+       drm_encoder_helper_add(encoder, &nv50_pior_help);
 
        drm_mode_connector_attach_encoder(connector, encoder);
        return 0;
 }
 
 /******************************************************************************
- * Framebuffer
+ * Atomic
  *****************************************************************************/
 
 static void
-nv50_fbdma_fini(struct nv50_fbdma *fbdma)
+nv50_disp_atomic_commit_core(struct nouveau_drm *drm, u32 interlock)
 {
-       int i;
-       for (i = 0; i < ARRAY_SIZE(fbdma->base); i++)
-               nvif_object_fini(&fbdma->base[i]);
-       nvif_object_fini(&fbdma->core);
-       list_del(&fbdma->head);
-       kfree(fbdma);
+       struct nv50_disp *disp = nv50_disp(drm->dev);
+       struct nv50_dmac *core = &disp->mast.base;
+       struct nv50_mstm *mstm;
+       struct drm_encoder *encoder;
+       u32 *push;
+
+       NV_ATOMIC(drm, "commit core %08x\n", interlock);
+
+       drm_for_each_encoder(encoder, drm->dev) {
+               if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                       mstm = nouveau_encoder(encoder)->dp.mstm;
+                       if (mstm && mstm->modified)
+                               nv50_mstm_prepare(mstm);
+               }
+       }
+
+       if ((push = evo_wait(core, 5))) {
+               evo_mthd(push, 0x0084, 1);
+               evo_data(push, 0x80000000);
+               evo_mthd(push, 0x0080, 2);
+               evo_data(push, interlock);
+               evo_data(push, 0x00000000);
+               nouveau_bo_wr32(disp->sync, 0, 0x00000000);
+               evo_kick(push, core);
+               if (nvif_msec(&drm->device, 2000ULL,
+                       if (nouveau_bo_rd32(disp->sync, 0))
+                               break;
+                       usleep_range(1, 2);
+               ) < 0)
+                       NV_ERROR(drm, "EVO timeout\n");
+       }
+
+       drm_for_each_encoder(encoder, drm->dev) {
+               if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                       mstm = nouveau_encoder(encoder)->dp.mstm;
+                       if (mstm && mstm->modified)
+                               nv50_mstm_cleanup(mstm);
+               }
+       }
 }
 
-static int
-nv50_fbdma_init(struct drm_device *dev, u32 name, u64 offset, u64 length, u8 kind)
+static void
+nv50_disp_atomic_commit_tail(struct drm_atomic_state *state)
 {
+       struct drm_device *dev = state->dev;
+       struct drm_crtc_state *crtc_state;
+       struct drm_crtc *crtc;
+       struct drm_plane_state *plane_state;
+       struct drm_plane *plane;
        struct nouveau_drm *drm = nouveau_drm(dev);
        struct nv50_disp *disp = nv50_disp(dev);
-       struct nv50_mast *mast = nv50_mast(dev);
-       struct __attribute__ ((packed)) {
-               struct nv_dma_v0 base;
-               union {
-                       struct nv50_dma_v0 nv50;
-                       struct gf100_dma_v0 gf100;
-                       struct gf119_dma_v0 gf119;
-               };
-       } args = {};
-       struct nv50_fbdma *fbdma;
-       struct drm_crtc *crtc;
-       u32 size = sizeof(args.base);
-       int ret;
+       struct nv50_atom *atom = nv50_atom(state);
+       struct nv50_outp_atom *outp, *outt;
+       u32 interlock_core = 0;
+       u32 interlock_chan = 0;
+       int i;
+
+       NV_ATOMIC(drm, "commit %d %d\n", atom->lock_core, atom->flush_disable);
+       drm_atomic_helper_wait_for_fences(dev, state, false);
+       drm_atomic_helper_wait_for_dependencies(state);
+       drm_atomic_helper_update_legacy_modeset_state(dev, state);
 
-       list_for_each_entry(fbdma, &disp->fbdma, head) {
-               if (fbdma->core.handle == name)
-                       return 0;
+       if (atom->lock_core)
+               mutex_lock(&disp->mutex);
+
+       /* Disable head(s). */
+       for_each_crtc_in_state(state, crtc, crtc_state, i) {
+               struct nv50_head_atom *asyh = nv50_head_atom(crtc->state);
+               struct nv50_head *head = nv50_head(crtc);
+
+               NV_ATOMIC(drm, "%s: clr %04x (set %04x)\n", crtc->name,
+                         asyh->clr.mask, asyh->set.mask);
+
+               if (asyh->clr.mask) {
+                       nv50_head_flush_clr(head, asyh, atom->flush_disable);
+                       interlock_core |= 1;
+               }
        }
 
-       fbdma = kzalloc(sizeof(*fbdma), GFP_KERNEL);
-       if (!fbdma)
-               return -ENOMEM;
-       list_add(&fbdma->head, &disp->fbdma);
+       /* Disable plane(s). */
+       for_each_plane_in_state(state, plane, plane_state, i) {
+               struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane->state);
+               struct nv50_wndw *wndw = nv50_wndw(plane);
 
-       args.base.target = NV_DMA_V0_TARGET_VRAM;
-       args.base.access = NV_DMA_V0_ACCESS_RDWR;
-       args.base.start = offset;
-       args.base.limit = offset + length - 1;
+               NV_ATOMIC(drm, "%s: clr %02x (set %02x)\n", plane->name,
+                         asyw->clr.mask, asyw->set.mask);
+               if (!asyw->clr.mask)
+                       continue;
 
-       if (drm->device.info.chipset < 0x80) {
-               args.nv50.part = NV50_DMA_V0_PART_256;
-               size += sizeof(args.nv50);
-       } else
-       if (drm->device.info.chipset < 0xc0) {
-               args.nv50.part = NV50_DMA_V0_PART_256;
-               args.nv50.kind = kind;
-               size += sizeof(args.nv50);
-       } else
-       if (drm->device.info.chipset < 0xd0) {
-               args.gf100.kind = kind;
-               size += sizeof(args.gf100);
-       } else {
-               args.gf119.page = GF119_DMA_V0_PAGE_LP;
-               args.gf119.kind = kind;
-               size += sizeof(args.gf119);
+               interlock_chan |= nv50_wndw_flush_clr(wndw, interlock_core,
+                                                     atom->flush_disable,
+                                                     asyw);
+       }
+
+       /* Disable output path(s). */
+       list_for_each_entry(outp, &atom->outp, head) {
+               const struct drm_encoder_helper_funcs *help;
+               struct drm_encoder *encoder;
+
+               encoder = outp->encoder;
+               help = encoder->helper_private;
+
+               NV_ATOMIC(drm, "%s: clr %02x (set %02x)\n", encoder->name,
+                         outp->clr.mask, outp->set.mask);
+
+               if (outp->clr.mask) {
+                       help->disable(encoder);
+                       interlock_core |= 1;
+                       if (outp->flush_disable) {
+                               nv50_disp_atomic_commit_core(drm, interlock_chan);
+                               interlock_core = 0;
+                               interlock_chan = 0;
+                       }
+               }
+       }
+
+       /* Flush disable. */
+       if (interlock_core) {
+               if (atom->flush_disable) {
+                       nv50_disp_atomic_commit_core(drm, interlock_chan);
+                       interlock_core = 0;
+                       interlock_chan = 0;
+               }
+       }
+
+       /* Update output path(s). */
+       list_for_each_entry_safe(outp, outt, &atom->outp, head) {
+               const struct drm_encoder_helper_funcs *help;
+               struct drm_encoder *encoder;
+
+               encoder = outp->encoder;
+               help = encoder->helper_private;
+
+               NV_ATOMIC(drm, "%s: set %02x (clr %02x)\n", encoder->name,
+                         outp->set.mask, outp->clr.mask);
+
+               if (outp->set.mask) {
+                       help->enable(encoder);
+                       interlock_core = 1;
+               }
+
+               list_del(&outp->head);
+               kfree(outp);
        }
 
-       list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
+       /* Update head(s). */
+       for_each_crtc_in_state(state, crtc, crtc_state, i) {
+               struct nv50_head_atom *asyh = nv50_head_atom(crtc->state);
                struct nv50_head *head = nv50_head(crtc);
-               int ret = nvif_object_init(&head->sync.base.base.user, name,
-                                          NV_DMA_IN_MEMORY, &args, size,
-                                          &fbdma->base[head->base.index]);
-               if (ret) {
-                       nv50_fbdma_fini(fbdma);
-                       return ret;
+
+               NV_ATOMIC(drm, "%s: set %04x (clr %04x)\n", crtc->name,
+                         asyh->set.mask, asyh->clr.mask);
+
+               if (asyh->set.mask) {
+                       nv50_head_flush_set(head, asyh);
+                       interlock_core = 1;
                }
        }
 
-       ret = nvif_object_init(&mast->base.base.user, name, NV_DMA_IN_MEMORY,
-                              &args, size, &fbdma->core);
-       if (ret) {
-               nv50_fbdma_fini(fbdma);
+       /* Update plane(s). */
+       for_each_plane_in_state(state, plane, plane_state, i) {
+               struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane->state);
+               struct nv50_wndw *wndw = nv50_wndw(plane);
+
+               NV_ATOMIC(drm, "%s: set %02x (clr %02x)\n", plane->name,
+                         asyw->set.mask, asyw->clr.mask);
+               if ( !asyw->set.mask &&
+                   (!asyw->clr.mask || atom->flush_disable))
+                       continue;
+
+               interlock_chan |= nv50_wndw_flush_set(wndw, interlock_core, asyw);
+       }
+
+       /* Flush update. */
+       if (interlock_core) {
+               if (!interlock_chan && atom->state.legacy_cursor_update) {
+                       u32 *push = evo_wait(&disp->mast, 2);
+                       if (push) {
+                               evo_mthd(push, 0x0080, 1);
+                               evo_data(push, 0x00000000);
+                               evo_kick(push, &disp->mast);
+                       }
+               } else {
+                       nv50_disp_atomic_commit_core(drm, interlock_chan);
+               }
+       }
+
+       if (atom->lock_core)
+               mutex_unlock(&disp->mutex);
+
+       /* Wait for HW to signal completion. */
+       for_each_plane_in_state(state, plane, plane_state, i) {
+               struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane->state);
+               struct nv50_wndw *wndw = nv50_wndw(plane);
+               int ret = nv50_wndw_wait_armed(wndw, asyw);
+               if (ret)
+                       NV_ERROR(drm, "%s: timeout\n", plane->name);
+       }
+
+       for_each_crtc_in_state(state, crtc, crtc_state, i) {
+               if (crtc->state->event) {
+                       unsigned long flags;
+                       /* Get correct count/ts if racing with vblank irq */
+                       drm_accurate_vblank_count(crtc);
+                       spin_lock_irqsave(&crtc->dev->event_lock, flags);
+                       drm_crtc_send_vblank_event(crtc, crtc->state->event);
+                       spin_unlock_irqrestore(&crtc->dev->event_lock, flags);
+                       crtc->state->event = NULL;
+               }
+       }
+
+       drm_atomic_helper_commit_hw_done(state);
+       drm_atomic_helper_cleanup_planes(dev, state);
+       drm_atomic_helper_commit_cleanup_done(state);
+       drm_atomic_state_put(state);
+}
+
+static void
+nv50_disp_atomic_commit_work(struct work_struct *work)
+{
+       struct drm_atomic_state *state =
+               container_of(work, typeof(*state), commit_work);
+       nv50_disp_atomic_commit_tail(state);
+}
+
+static int
+nv50_disp_atomic_commit(struct drm_device *dev,
+                       struct drm_atomic_state *state, bool nonblock)
+{
+       struct nouveau_drm *drm = nouveau_drm(dev);
+       struct nv50_disp *disp = nv50_disp(dev);
+       struct drm_plane_state *plane_state;
+       struct drm_plane *plane;
+       struct drm_crtc *crtc;
+       bool active = false;
+       int ret, i;
+
+       ret = pm_runtime_get_sync(dev->dev);
+       if (ret < 0 && ret != -EACCES)
                return ret;
+
+       ret = drm_atomic_helper_setup_commit(state, nonblock);
+       if (ret)
+               goto done;
+
+       INIT_WORK(&state->commit_work, nv50_disp_atomic_commit_work);
+
+       ret = drm_atomic_helper_prepare_planes(dev, state);
+       if (ret)
+               goto done;
+
+       if (!nonblock) {
+               ret = drm_atomic_helper_wait_for_fences(dev, state, true);
+               if (ret)
+                       goto done;
+       }
+
+       for_each_plane_in_state(state, plane, plane_state, i) {
+               struct nv50_wndw_atom *asyw = nv50_wndw_atom(plane_state);
+               struct nv50_wndw *wndw = nv50_wndw(plane);
+               if (asyw->set.image) {
+                       asyw->ntfy.handle = wndw->dmac->sync.handle;
+                       asyw->ntfy.offset = wndw->ntfy;
+                       asyw->ntfy.awaken = false;
+                       asyw->set.ntfy = true;
+                       nouveau_bo_wr32(disp->sync, wndw->ntfy / 4, 0x00000000);
+                       wndw->ntfy ^= 0x10;
+               }
+       }
+
+       drm_atomic_helper_swap_state(state, true);
+       drm_atomic_state_get(state);
+
+       if (nonblock)
+               queue_work(system_unbound_wq, &state->commit_work);
+       else
+               nv50_disp_atomic_commit_tail(state);
+
+       drm_for_each_crtc(crtc, dev) {
+               if (crtc->state->enable) {
+                       if (!drm->have_disp_power_ref) {
+                               drm->have_disp_power_ref = true;
+                               return ret;
+                       }
+                       active = true;
+                       break;
+               }
+       }
+
+       if (!active && drm->have_disp_power_ref) {
+               pm_runtime_put_autosuspend(dev->dev);
+               drm->have_disp_power_ref = false;
+       }
+
+done:
+       pm_runtime_put_autosuspend(dev->dev);
+       return ret;
+}
+
+static struct nv50_outp_atom *
+nv50_disp_outp_atomic_add(struct nv50_atom *atom, struct drm_encoder *encoder)
+{
+       struct nv50_outp_atom *outp;
+
+       list_for_each_entry(outp, &atom->outp, head) {
+               if (outp->encoder == encoder)
+                       return outp;
+       }
+
+       outp = kzalloc(sizeof(*outp), GFP_KERNEL);
+       if (!outp)
+               return ERR_PTR(-ENOMEM);
+
+       list_add(&outp->head, &atom->outp);
+       outp->encoder = encoder;
+       return outp;
+}
+
+static int
+nv50_disp_outp_atomic_check_clr(struct nv50_atom *atom,
+                               struct drm_connector *connector)
+{
+       struct drm_encoder *encoder = connector->state->best_encoder;
+       struct drm_crtc_state *crtc_state;
+       struct drm_crtc *crtc;
+       struct nv50_outp_atom *outp;
+
+       if (!(crtc = connector->state->crtc))
+               return 0;
+
+       crtc_state = drm_atomic_get_existing_crtc_state(&atom->state, crtc);
+       if (crtc->state->active && drm_atomic_crtc_needs_modeset(crtc_state)) {
+               outp = nv50_disp_outp_atomic_add(atom, encoder);
+               if (IS_ERR(outp))
+                       return PTR_ERR(outp);
+
+               if (outp->encoder->encoder_type == DRM_MODE_ENCODER_DPMST) {
+                       outp->flush_disable = true;
+                       atom->flush_disable = true;
+               }
+               outp->clr.ctrl = true;
+               atom->lock_core = true;
        }
 
        return 0;
 }
 
-static void
-nv50_fb_dtor(struct drm_framebuffer *fb)
+static int
+nv50_disp_outp_atomic_check_set(struct nv50_atom *atom,
+                               struct drm_connector_state *connector_state)
 {
+       struct drm_encoder *encoder = connector_state->best_encoder;
+       struct drm_crtc_state *crtc_state;
+       struct drm_crtc *crtc;
+       struct nv50_outp_atom *outp;
+
+       if (!(crtc = connector_state->crtc))
+               return 0;
+
+       crtc_state = drm_atomic_get_existing_crtc_state(&atom->state, crtc);
+       if (crtc_state->active && drm_atomic_crtc_needs_modeset(crtc_state)) {
+               outp = nv50_disp_outp_atomic_add(atom, encoder);
+               if (IS_ERR(outp))
+                       return PTR_ERR(outp);
+
+               outp->set.ctrl = true;
+               atom->lock_core = true;
+       }
+
+       return 0;
 }
 
 static int
-nv50_fb_ctor(struct drm_framebuffer *fb)
-{
-       struct nouveau_framebuffer *nv_fb = nouveau_framebuffer(fb);
-       struct nouveau_drm *drm = nouveau_drm(fb->dev);
-       struct nouveau_bo *nvbo = nv_fb->nvbo;
-       struct nv50_disp *disp = nv50_disp(fb->dev);
-       u8 kind = nouveau_bo_tile_layout(nvbo) >> 8;
-       u8 tile = nvbo->tile_mode;
-
-       if (drm->device.info.chipset >= 0xc0)
-               tile >>= 4; /* yep.. */
-
-       switch (fb->depth) {
-       case  8: nv_fb->r_format = 0x1e00; break;
-       case 15: nv_fb->r_format = 0xe900; break;
-       case 16: nv_fb->r_format = 0xe800; break;
-       case 24:
-       case 32: nv_fb->r_format = 0xcf00; break;
-       case 30: nv_fb->r_format = 0xd100; break;
-       default:
-                NV_ERROR(drm, "unknown depth %d\n", fb->depth);
-                return -EINVAL;
+nv50_disp_atomic_check(struct drm_device *dev, struct drm_atomic_state *state)
+{
+       struct nv50_atom *atom = nv50_atom(state);
+       struct drm_connector_state *connector_state;
+       struct drm_connector *connector;
+       int ret, i;
+
+       ret = drm_atomic_helper_check(dev, state);
+       if (ret)
+               return ret;
+
+       for_each_connector_in_state(state, connector, connector_state, i) {
+               ret = nv50_disp_outp_atomic_check_clr(atom, connector);
+               if (ret)
+                       return ret;
+
+               ret = nv50_disp_outp_atomic_check_set(atom, connector_state);
+               if (ret)
+                       return ret;
        }
 
-       if (disp->disp->oclass < G82_DISP) {
-               nv_fb->r_pitch   = kind ? (((fb->pitches[0] / 4) << 4) | tile) :
-                                           (fb->pitches[0] | 0x00100000);
-               nv_fb->r_format |= kind << 16;
-       } else
-       if (disp->disp->oclass < GF110_DISP) {
-               nv_fb->r_pitch  = kind ? (((fb->pitches[0] / 4) << 4) | tile) :
-                                          (fb->pitches[0] | 0x00100000);
-       } else {
-               nv_fb->r_pitch  = kind ? (((fb->pitches[0] / 4) << 4) | tile) :
-                                          (fb->pitches[0] | 0x01000000);
+       return 0;
+}
+
+static void
+nv50_disp_atomic_state_clear(struct drm_atomic_state *state)
+{
+       struct nv50_atom *atom = nv50_atom(state);
+       struct nv50_outp_atom *outp, *outt;
+
+       list_for_each_entry_safe(outp, outt, &atom->outp, head) {
+               list_del(&outp->head);
+               kfree(outp);
        }
-       nv_fb->r_handle = 0xffff0000 | kind;
 
-       return nv50_fbdma_init(fb->dev, nv_fb->r_handle, 0,
-                              drm->device.info.ram_user, kind);
+       drm_atomic_state_default_clear(state);
+}
+
+static void
+nv50_disp_atomic_state_free(struct drm_atomic_state *state)
+{
+       struct nv50_atom *atom = nv50_atom(state);
+       drm_atomic_state_default_release(&atom->state);
+       kfree(atom);
+}
+
+static struct drm_atomic_state *
+nv50_disp_atomic_state_alloc(struct drm_device *dev)
+{
+       struct nv50_atom *atom;
+       if (!(atom = kzalloc(sizeof(*atom), GFP_KERNEL)) ||
+           drm_atomic_state_init(dev, &atom->state) < 0) {
+               kfree(atom);
+               return NULL;
+       }
+       INIT_LIST_HEAD(&atom->outp);
+       return &atom->state;
 }
 
+static const struct drm_mode_config_funcs
+nv50_disp_func = {
+       .fb_create = nouveau_user_framebuffer_create,
+       .output_poll_changed = nouveau_fbcon_output_poll_changed,
+       .atomic_check = nv50_disp_atomic_check,
+       .atomic_commit = nv50_disp_atomic_commit,
+       .atomic_state_alloc = nv50_disp_atomic_state_alloc,
+       .atomic_state_clear = nv50_disp_atomic_state_clear,
+       .atomic_state_free = nv50_disp_atomic_state_free,
+};
+
 /******************************************************************************
  * Init
  *****************************************************************************/
@@ -2471,12 +4343,30 @@ nv50_fb_ctor(struct drm_framebuffer *fb)
 void
 nv50_display_fini(struct drm_device *dev)
 {
+       struct nouveau_encoder *nv_encoder;
+       struct drm_encoder *encoder;
+       struct drm_plane *plane;
+
+       drm_for_each_plane(plane, dev) {
+               struct nv50_wndw *wndw = nv50_wndw(plane);
+               if (plane->funcs != &nv50_wndw)
+                       continue;
+               nv50_wndw_fini(wndw);
+       }
+
+       list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
+               if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                       nv_encoder = nouveau_encoder(encoder);
+                       nv50_mstm_fini(nv_encoder->dp.mstm);
+               }
+       }
 }
 
 int
 nv50_display_init(struct drm_device *dev)
 {
-       struct nv50_disp *disp = nv50_disp(dev);
+       struct drm_encoder *encoder;
+       struct drm_plane *plane;
        struct drm_crtc *crtc;
        u32 *push;
 
@@ -2484,16 +4374,35 @@ nv50_display_init(struct drm_device *dev)
        if (!push)
                return -EBUSY;
 
-       list_for_each_entry(crtc, &dev->mode_config.crtc_list, head) {
-               struct nv50_sync *sync = nv50_sync(crtc);
-
-               nv50_crtc_lut_load(crtc);
-               nouveau_bo_wr32(disp->sync, sync->addr / 4, sync->data);
-       }
-
        evo_mthd(push, 0x0088, 1);
        evo_data(push, nv50_mast(dev)->base.sync.handle);
        evo_kick(push, nv50_mast(dev));
+
+       list_for_each_entry(encoder, &dev->mode_config.encoder_list, head) {
+               if (encoder->encoder_type != DRM_MODE_ENCODER_DPMST) {
+                       const struct drm_encoder_helper_funcs *help;
+                       struct nouveau_encoder *nv_encoder;
+
+                       nv_encoder = nouveau_encoder(encoder);
+                       help = encoder->helper_private;
+                       if (help && help->dpms)
+                               help->dpms(encoder, DRM_MODE_DPMS_ON);
+
+                       nv50_mstm_init(nv_encoder->dp.mstm);
+               }
+       }
+
+       drm_for_each_crtc(crtc, dev) {
+               nv50_head_lut_load(crtc);
+       }
+
+       drm_for_each_plane(plane, dev) {
+               struct nv50_wndw *wndw = nv50_wndw(plane);
+               if (plane->funcs != &nv50_wndw)
+                       continue;
+               nv50_wndw_init(wndw);
+       }
+
        return 0;
 }
 
@@ -2501,11 +4410,6 @@ void
 nv50_display_destroy(struct drm_device *dev)
 {
        struct nv50_disp *disp = nv50_disp(dev);
-       struct nv50_fbdma *fbdma, *fbtmp;
-
-       list_for_each_entry_safe(fbdma, fbtmp, &disp->fbdma, head) {
-               nv50_fbdma_fini(fbdma);
-       }
 
        nv50_dmac_destroy(&disp->mast.base, disp->disp);
 
@@ -2518,6 +4422,10 @@ nv50_display_destroy(struct drm_device *dev)
        kfree(disp);
 }
 
+MODULE_PARM_DESC(atomic, "Expose atomic ioctl (default: disabled)");
+static int nouveau_atomic = 0;
+module_param_named(atomic, nouveau_atomic, int, 0400);
+
 int
 nv50_display_create(struct drm_device *dev)
 {
@@ -2532,15 +4440,17 @@ nv50_display_create(struct drm_device *dev)
        disp = kzalloc(sizeof(*disp), GFP_KERNEL);
        if (!disp)
                return -ENOMEM;
-       INIT_LIST_HEAD(&disp->fbdma);
+
+       mutex_init(&disp->mutex);
 
        nouveau_display(dev)->priv = disp;
        nouveau_display(dev)->dtor = nv50_display_destroy;
        nouveau_display(dev)->init = nv50_display_init;
        nouveau_display(dev)->fini = nv50_display_fini;
-       nouveau_display(dev)->fb_ctor = nv50_fb_ctor;
-       nouveau_display(dev)->fb_dtor = nv50_fb_dtor;
        disp->disp = &nouveau_display(dev)->disp;
+       dev->mode_config.funcs = &nv50_disp_func;
+       if (nouveau_atomic)
+               dev->driver->driver_features |= DRIVER_ATOMIC;
 
        /* small shared memory area we use for notifiers and semaphores */
        ret = nouveau_bo_new(dev, 4096, 0x1000, TTM_PL_FLAG_VRAM,
@@ -2572,7 +4482,7 @@ nv50_display_create(struct drm_device *dev)
                crtcs = 2;
 
        for (i = 0; i < crtcs; i++) {
-               ret = nv50_crtc_create(dev, i);
+               ret = nv50_head_create(dev, i);
                if (ret)
                        goto out;
        }