Merge tag 'random_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso...

[karo-tx-linux.git] / drivers / hwmon / adt7475.c

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index df29d13a5349d0c09957fb9ba9c911ebe4d73478..861c756e95366ceb6a3fcc4e7a5dfa5b838feb9a 100644 (file)
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1260,7 +1260,7 @@ static int adt7475_probe(struct i2c_client *client,
        int i, ret = 0, revision;
        u8 config2, config3;
 
-       data = kzalloc(sizeof(*data), GFP_KERNEL);
+       data = devm_kzalloc(&client->dev, sizeof(*data), GFP_KERNEL);
        if (data == NULL)
                return -ENOMEM;
 
@@ -1344,7 +1344,7 @@ static int adt7475_probe(struct i2c_client *client,
 
        ret = sysfs_create_group(&client->dev.kobj, &adt7475_attr_group);
        if (ret)
-               goto efree;
+               return ret;
 
        /* Features that can be disabled individually */
        if (data->has_fan4) {
@@ -1410,8 +1410,6 @@ static int adt7475_probe(struct i2c_client *client,
 
 eremove:
        adt7475_remove_files(client, data);
-efree:
-       kfree(data);
        return ret;
 }
 
@@ -1421,7 +1419,6 @@ static int adt7475_remove(struct i2c_client *client)
 
        hwmon_device_unregister(data->hwmon_dev);
        adt7475_remove_files(client, data);
-       kfree(data);
 
        return 0;
 }