]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - drivers/media/video/msp3400.c
[PATCH] v4l: 885: second round of i2c ids redefinition cleanup
[mv-sheeva.git] / drivers / media / video / msp3400.c
index 262890cb20a7daf55de5d25d6840db40a6eb9dc3..d603229c9f2f9ccd4689872bba477572e4d92e4a 100644 (file)
@@ -54,7 +54,6 @@
 #include <asm/pgtable.h>
 
 #include <media/audiochip.h>
-#include <media/id.h>
 #include "msp3400.h"
 
 #define OPMODE_AUTO    -1
@@ -73,13 +72,22 @@ static int dolby    = 0;
 
 static int stereo_threshold = 0x190; /* a2 threshold for stereo/bilingual
                                        (msp34xxg only) 0x00a0-0x03c0 */
+#define DFP_COUNT 0x41
+static const int bl_dfp[] = {
+       0x00, 0x01, 0x02, 0x03, 0x06, 0x08, 0x09, 0x0a,
+       0x0b, 0x0d, 0x0e, 0x10
+};
+
+#define IS_MSP34XX_G(msp) ((msp)->opmode==2)
 
 struct msp3400c {
        int rev1,rev2;
 
        int opmode;
+       int nicam;
        int mode;
        int norm;
+       int stereo;
        int nicam_on;
        int acb;
        int main, second;       /* sound carrier */
@@ -91,9 +99,12 @@ struct msp3400c {
        int rxsubchans;
 
        int muted;
-       int volume, balance;
+       int left, right;        /* volume */
        int bass, treble;
 
+       /* shadow register set */
+       int dfp_regs[DFP_COUNT];
+
        /* thread */
        struct task_struct   *kthread;
        wait_queue_head_t    wq;
@@ -101,6 +112,8 @@ struct msp3400c {
        int                  watch_stereo:1;
 };
 
+#define MIN(a,b) (((a)>(b))?(b):(a))
+#define MAX(a,b) (((a)>(b))?(a):(b))
 #define HAVE_NICAM(msp)   (((msp->rev2>>8) & 0xff) != 00)
 #define HAVE_SIMPLE(msp)  ((msp->rev1      & 0xff) >= 'D'-'@')
 #define HAVE_SIMPLER(msp) ((msp->rev1      & 0xff) >= 'G'-'@')
@@ -112,6 +125,7 @@ struct msp3400c {
 
 #define dprintk      if (debug >= 1) printk
 #define d2printk     if (debug >= 2) printk
+#define dprintk_trace if (debug>=16) printk
 
 /* read-only */
 module_param(opmode,           int, 0444);
@@ -132,11 +146,6 @@ MODULE_PARM_DESC(standard, "Specify audio standard: 32 = NTSC, 64 = radio, Defau
 MODULE_PARM_DESC(amsound, "Hardwire AM sound at 6.5Hz (France), FM can autoscan");
 MODULE_PARM_DESC(dolby, "Activates Dolby processsing");
 
-
-MODULE_DESCRIPTION("device driver for msp34xx TV sound processor");
-MODULE_AUTHOR("Gerd Knorr");
-MODULE_LICENSE("Dual BSD/GPL"); /* FreeBSD uses this too */
-
 /* ---------------------------------------------------------------------- */
 
 #define I2C_MSP3400C       0x80
@@ -153,6 +162,10 @@ static unsigned short normal_i2c[] = {
 };
 I2C_CLIENT_INSMOD;
 
+MODULE_DESCRIPTION("device driver for msp34xx TV sound processor");
+MODULE_AUTHOR("Gerd Knorr");
+MODULE_LICENSE("GPL");
+
 /* ----------------------------------------------------------------------- */
 /* functions for talking to the MSP3400C Sound processor                   */
 
@@ -172,68 +185,79 @@ static int msp3400c_reset(struct i2c_client *client)
                { client->addr, I2C_M_RD, 2, read  },
        };
 
+       dprintk_trace("trace: msp3400c_reset\n");
        if ( (1 != i2c_transfer(client->adapter,&reset[0],1)) ||
             (1 != i2c_transfer(client->adapter,&reset[1],1)) ||
             (2 != i2c_transfer(client->adapter,test,2)) ) {
                printk(KERN_ERR "msp3400: chip reset failed\n");
                return -1;
-        }
+       }
        return 0;
 }
 
-static int
-msp3400c_read(struct i2c_client *client, int dev, int addr)
+static int msp3400c_read(struct i2c_client *client, int dev, int addr)
 {
-       int err;
+       int err,retval;
 
-        unsigned char write[3];
-        unsigned char read[2];
-        struct i2c_msg msgs[2] = {
-                { client->addr, 0,        3, write },
-                { client->addr, I2C_M_RD, 2, read  }
-        };
-        write[0] = dev+1;
-        write[1] = addr >> 8;
-        write[2] = addr & 0xff;
+       unsigned char write[3];
+       unsigned char read[2];
+       struct i2c_msg msgs[2] = {
+               { client->addr, 0,        3, write },
+               { client->addr, I2C_M_RD, 2, read  }
+       };
+
+       write[0] = dev+1;
+       write[1] = addr >> 8;
+       write[2] = addr & 0xff;
 
        for (err = 0; err < 3;) {
                if (2 == i2c_transfer(client->adapter,msgs,2))
                        break;
                err++;
-               printk(KERN_WARNING "msp34xx: I/O error #%d (read 0x%02x/0x%02x)\n",
-                      err, dev, addr);
-               msleep(10);
+               printk(KERN_WARNING
+                      "msp34xx: I/O error #%d (read 0x%02x/0x%02x)\n", err,
+                      dev, addr);
+               current->state = TASK_INTERRUPTIBLE;
+               schedule_timeout(msecs_to_jiffies(10));
        }
        if (3 == err) {
-               printk(KERN_WARNING "msp34xx: giving up, reseting chip. Sound will go off, sorry folks :-|\n");
+               printk(KERN_WARNING
+                      "msp34xx: giving up, reseting chip. Sound will go off, sorry folks :-|\n");
                msp3400c_reset(client);
                return -1;
        }
-       return read[0] << 8 | read[1];
+       retval = read[0] << 8 | read[1];
+       dprintk_trace("trace: msp3400c_read(0x%x, 0x%x): 0x%x\n", dev, addr,
+                     retval);
+       return retval;
 }
 
-static int
-msp3400c_write(struct i2c_client *client, int dev, int addr, int val)
+static int msp3400c_write(struct i2c_client *client, int dev, int addr, int val)
 {
        int err;
-        unsigned char buffer[5];
+       unsigned char buffer[5];
 
-        buffer[0] = dev;
-        buffer[1] = addr >> 8;
-        buffer[2] = addr &  0xff;
-        buffer[3] = val  >> 8;
-        buffer[4] = val  &  0xff;
+       buffer[0] = dev;
+       buffer[1] = addr >> 8;
+       buffer[2] = addr &  0xff;
+       buffer[3] = val  >> 8;
+       buffer[4] = val  &  0xff;
 
+       dprintk_trace("trace: msp3400c_write(0x%x, 0x%x, 0x%x)\n", dev, addr,
+                     val);
        for (err = 0; err < 3;) {
                if (5 == i2c_master_send(client, buffer, 5))
                        break;
                err++;
-               printk(KERN_WARNING "msp34xx: I/O error #%d (write 0x%02x/0x%02x)\n",
-                      err, dev, addr);
-               msleep(10);
+               printk(KERN_WARNING
+                      "msp34xx: I/O error #%d (write 0x%02x/0x%02x)\n", err,
+                      dev, addr);
+               current->state = TASK_INTERRUPTIBLE;
+               schedule_timeout(msecs_to_jiffies(10));
        }
        if (3 == err) {
-               printk(KERN_WARNING "msp34xx: giving up, reseting chip. Sound will go off, sorry folks :-|\n");
+               printk(KERN_WARNING
+                      "msp34xx: giving up, reseting chip. Sound will go off, sorry folks :-|\n");
                msp3400c_reset(client);
                return -1;
        }
@@ -266,45 +290,47 @@ static struct MSP_INIT_DATA_DEM {
        int dfp_src;
        int dfp_matrix;
 } msp_init_data[] = {
-       /* AM (for carrier detect / msp3400) */
-       { { 75, 19, 36, 35, 39, 40 }, { 75, 19, 36, 35, 39, 40 },
-         MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-         0x00d0, 0x0500,   0x0020, 0x3000},
-
-       /* AM (for carrier detect / msp3410) */
-       { { -1, -1, -8, 2, 59, 126 }, { -1, -1, -8, 2, 59, 126 },
-         MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-         0x00d0, 0x0100,   0x0020, 0x3000},
-
-       /* FM Radio */
-       { { -8, -8, 4, 6, 78, 107 }, { -8, -8, 4, 6, 78, 107 },
-         MSP_CARRIER(10.7), MSP_CARRIER(10.7),
-         0x00d0, 0x0480, 0x0020, 0x3000 },
-
-       /* Terrestial FM-mono + FM-stereo */
-       { {  3, 18, 27, 48, 66, 72 }, {  3, 18, 27, 48, 66, 72 },
-         MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-         0x00d0, 0x0480,   0x0030, 0x3000},
-
-       /* Sat FM-mono */
-       { {  1,  9, 14, 24, 33, 37 }, {  3, 18, 27, 48, 66, 72 },
-         MSP_CARRIER(6.5), MSP_CARRIER(6.5),
-         0x00c6, 0x0480,   0x0000, 0x3000},
-
-       /* NICAM/FM --  B/G (5.5/5.85), D/K (6.5/5.85) */
-       { { -2, -8, -10, 10, 50, 86 }, {  3, 18, 27, 48, 66, 72 },
-         MSP_CARRIER(5.5), MSP_CARRIER(5.5),
-         0x00d0, 0x0040,   0x0120, 0x3000},
-
-       /* NICAM/FM -- I (6.0/6.552) */
-       { {  2, 4, -6, -4, 40, 94 }, {  3, 18, 27, 48, 66, 72 },
-         MSP_CARRIER(6.0), MSP_CARRIER(6.0),
-         0x00d0, 0x0040,   0x0120, 0x3000},
-
-       /* NICAM/AM -- L (6.5/5.85) */
-       { {  -2, -8, -10, 10, 50, 86 }, {  -4, -12, -9, 23, 79, 126 },
-         MSP_CARRIER(6.5), MSP_CARRIER(6.5),
-         0x00c6, 0x0140,   0x0120, 0x7c03},
+       {       /* AM (for carrier detect / msp3400) */
+               {75, 19, 36, 35, 39, 40},
+               {75, 19, 36, 35, 39, 40},
+               MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+               0x00d0, 0x0500, 0x0020, 0x3000
+       },{     /* AM (for carrier detect / msp3410) */
+               {-1, -1, -8, 2, 59, 126},
+               {-1, -1, -8, 2, 59, 126},
+               MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+               0x00d0, 0x0100, 0x0020, 0x3000
+       },{     /* FM Radio */
+               {-8, -8, 4, 6, 78, 107},
+               {-8, -8, 4, 6, 78, 107},
+               MSP_CARRIER(10.7), MSP_CARRIER(10.7),
+               0x00d0, 0x0480, 0x0020, 0x3000
+       },{     /* Terrestial FM-mono + FM-stereo */
+               {3, 18, 27, 48, 66, 72},
+               {3, 18, 27, 48, 66, 72},
+               MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+               0x00d0, 0x0480, 0x0030, 0x3000
+       },{     /* Sat FM-mono */
+               { 1, 9, 14, 24, 33, 37},
+               { 3, 18, 27, 48, 66, 72},
+               MSP_CARRIER(6.5), MSP_CARRIER(6.5),
+               0x00c6, 0x0480, 0x0000, 0x3000
+       },{     /* NICAM/FM --  B/G (5.5/5.85), D/K (6.5/5.85) */
+               {-2, -8, -10, 10, 50, 86},
+               {3, 18, 27, 48, 66, 72},
+               MSP_CARRIER(5.5), MSP_CARRIER(5.5),
+               0x00d0, 0x0040, 0x0120, 0x3000
+       },{     /* NICAM/FM -- I (6.0/6.552) */
+               {2, 4, -6, -4, 40, 94},
+               {3, 18, 27, 48, 66, 72},
+               MSP_CARRIER(6.0), MSP_CARRIER(6.0),
+               0x00d0, 0x0040, 0x0120, 0x3000
+       },{     /* NICAM/AM -- L (6.5/5.85) */
+               {-2, -8, -10, 10, 50, 86},
+               {-4, -12, -9, 23, 79, 126},
+               MSP_CARRIER(6.5), MSP_CARRIER(6.5),
+               0x00c6, 0x0140, 0x0120, 0x7c03
+       },
 };
 
 struct CARRIER_DETECT {
@@ -341,26 +367,24 @@ static struct CARRIER_DETECT carrier_detect_65[] = {
 /* ----------------------------------------------------------------------- */
 
 static int scarts[3][9] = {
-  /* MASK    IN1     IN2     IN1_DA  IN2_DA  IN3     IN4     MONO    MUTE   */
-   0x0320, 0x0000, 0x0200, -1,     -1,     0x0300, 0x0020, 0x0100, 0x0320 },
-   0x0c40, 0x0440, 0x0400, 0x0c00, 0x0040, 0x0000, 0x0840, 0x0800, 0x0c40 },
-   0x3080, 0x1000, 0x1080, 0x0000, 0x0080, 0x2080, 0x3080, 0x2000, 0x3000 },
+       /* MASK    IN1     IN2     IN1_DA  IN2_DA  IN3     IN4     MONO    MUTE   */
+       { 0x0320, 0x0000, 0x0200, -1,     -1,     0x0300, 0x0020, 0x0100, 0x0320 },
+       { 0x0c40, 0x0440, 0x0400, 0x0c00, 0x0040, 0x0000, 0x0840, 0x0800, 0x0c40 },
+       { 0x3080, 0x1000, 0x1080, 0x0000, 0x0080, 0x2080, 0x3080, 0x2000, 0x3000 },
 };
 
 static char *scart_names[] = {
-  "mask", "in1", "in2", "in1 da", "in2 da", "in3", "in4", "mono", "mute"
+       "mask", "in1", "in2", "in1 da", "in2 da", "in3", "in4", "mono", "mute"
 };
 
-static void
-msp3400c_set_scart(struct i2c_client *client, int in, int out)
+static void msp3400c_set_scart(struct i2c_client *client, int in, int out)
 {
        struct msp3400c *msp = i2c_get_clientdata(client);
 
        if (-1 == scarts[out][in])
                return;
 
-       dprintk(KERN_DEBUG
-               "msp34xx: scart switch: %s => %d\n",scart_names[in],out);
+       dprintk("msp34xx: scart switch: %s => %d\n", scart_names[in], out);
        msp->acb &= ~scarts[out][SCART_MASK];
        msp->acb |=  scarts[out][in];
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0013, msp->acb);
@@ -378,33 +402,34 @@ static void msp3400c_setcarrier(struct i2c_client *client, int cdo1, int cdo2)
 }
 
 static void msp3400c_setvolume(struct i2c_client *client,
-                              int muted, int volume, int balance)
-{
-       int val = 0, bal = 0;
+                              int muted, int left, int right)
+ {
+       int vol = 0, val = 0, balance = 0;
 
        if (!muted) {
                /* 0x7f instead if 0x73 here has sound quality issues,
                 * probably due to overmodulation + clipping ... */
-               val = (volume * 0x73 / 65535) << 8;
+               vol = (left > right) ? left : right;
+               val = (vol * 0x73 / 65535) << 8;
        }
-       if (val) {
-               bal = (balance / 256) - 128;
+       if (vol > 0) {
+               balance = ((right - left) * 127) / vol;
        }
-       dprintk(KERN_DEBUG
-               "msp34xx: setvolume: mute=%s %d:%d  v=0x%02x b=0x%02x\n",
-               muted ? "on" : "off", volume, balance, val>>8, bal);
+
+       dprintk("msp34xx: setvolume: mute=%s %d:%d  v=0x%02x b=0x%02x\n",
+               muted ? "on" : "off", left, right, val >> 8, balance);
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0000, val); /* loudspeaker */
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0006, val); /* headphones  */
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0007,
-                      muted ? 0x01 : (val | 0x01));
-       msp3400c_write(client,I2C_MSP3400C_DFP, 0x0001, bal << 8);
+                                       muted ? 0x1 : (val | 0x1));
+       msp3400c_write(client, I2C_MSP3400C_DFP, 0x0001, balance << 8);
 }
 
 static void msp3400c_setbass(struct i2c_client *client, int bass)
 {
        int val = ((bass-32768) * 0x60 / 65535) << 8;
 
-       dprintk(KERN_DEBUG "msp34xx: setbass: %d 0x%02x\n",bass, val>>8);
+       dprintk("msp34xx: setbass: %d 0x%02x\n", bass, val >> 8);
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0002, val); /* loudspeaker */
 }
 
@@ -412,7 +437,7 @@ static void msp3400c_settreble(struct i2c_client *client, int treble)
 {
        int val = ((treble-32768) * 0x60 / 65535) << 8;
 
-       dprintk(KERN_DEBUG "msp34xx: settreble: %d 0x%02x\n",treble, val>>8);
+       dprintk("msp34xx: settreble: %d 0x%02x\n",treble, val>>8);
        msp3400c_write(client,I2C_MSP3400C_DFP, 0x0003, val); /* loudspeaker */
 }
 
@@ -421,7 +446,7 @@ static void msp3400c_setmode(struct i2c_client *client, int type)
        struct msp3400c *msp = i2c_get_clientdata(client);
        int i;
 
-       dprintk(KERN_DEBUG "msp3400: setmode: %d\n",type);
+       dprintk("msp3400: setmode: %d\n",type);
        msp->mode       = type;
        msp->audmode    = V4L2_TUNER_MODE_MONO;
        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
@@ -474,7 +499,8 @@ static void msp3400c_setmode(struct i2c_client *client, int type)
        }
 }
 
-static int best_audio_mode(int rxsubchans)
+/* given a bitmask of VIDEO_SOUND_XXX returns the "best" in the bitmask */
+static int best_video_sound(int rxsubchans)
 {
        if (rxsubchans & V4L2_TUNER_SUB_STEREO)
                return V4L2_TUNER_MODE_STEREO;
@@ -486,31 +512,32 @@ static int best_audio_mode(int rxsubchans)
 }
 
 /* turn on/off nicam + stereo */
-static void msp3400c_set_audmode(struct i2c_client *client, int audmode)
+static void msp3400c_setstereo(struct i2c_client *client, int mode)
 {
-       static char *strmode[16] = {
-#if __GNUC__ >= 3
-               [ 0 ... 15 ]               = "invalid",
-#endif
-               [ V4L2_TUNER_MODE_MONO   ] = "mono",
-               [ V4L2_TUNER_MODE_STEREO ] = "stereo",
-               [ V4L2_TUNER_MODE_LANG1  ] = "lang1",
-               [ V4L2_TUNER_MODE_LANG2  ] = "lang2",
+       static char *strmode[] = { "0", "mono", "stereo", "3",
+               "lang1", "5", "6", "7", "lang2"
        };
        struct msp3400c *msp = i2c_get_clientdata(client);
-       int nicam=0; /* channel source: FM/AM or nicam */
-       int src=0;
+       int nicam = 0;          /* channel source: FM/AM or nicam */
+       int src = 0;
 
-       BUG_ON(msp->opmode == OPMODE_SIMPLER);
-       msp->audmode = audmode;
+       if (IS_MSP34XX_G(msp)) {
+               /* this method would break everything, let's make sure
+                * it's never called
+                */
+               dprintk
+                   ("msp34xxg: DEBUG WARNING setstereo called with mode=%d instead of set_source (ignored)\n",
+                    mode);
+               return;
+       }
 
        /* switch demodulator */
        switch (msp->mode) {
        case MSP_MODE_FM_TERRA:
-               dprintk(KERN_DEBUG "msp3400: FM setstereo: %s\n",
-                       strmode[audmode]);
+               dprintk("msp3400: FM setstereo: %s\n",
+                       strmode[mode]);
                msp3400c_setcarrier(client,msp->second,msp->main);
-               switch (audmode) {
+               switch (mode) {
                case V4L2_TUNER_MODE_STEREO:
                        msp3400c_write(client,I2C_MSP3400C_DFP, 0x000e, 0x3001);
                        break;
@@ -522,9 +549,8 @@ static void msp3400c_set_audmode(struct i2c_client *client, int audmode)
                }
                break;
        case MSP_MODE_FM_SAT:
-               dprintk(KERN_DEBUG "msp3400: SAT setstereo: %s\n",
-                       strmode[audmode]);
-               switch (audmode) {
+               dprintk("msp3400: SAT setstereo: %s\n", strmode[mode]);
+               switch (mode) {
                case V4L2_TUNER_MODE_MONO:
                        msp3400c_setcarrier(client, MSP_CARRIER(6.5), MSP_CARRIER(6.5));
                        break;
@@ -542,33 +568,29 @@ static void msp3400c_set_audmode(struct i2c_client *client, int audmode)
        case MSP_MODE_FM_NICAM1:
        case MSP_MODE_FM_NICAM2:
        case MSP_MODE_AM_NICAM:
-               dprintk(KERN_DEBUG "msp3400: NICAM setstereo: %s\n",
-                       strmode[audmode]);
+               dprintk("msp3400: NICAM setstereo: %s\n",strmode[mode]);
                msp3400c_setcarrier(client,msp->second,msp->main);
                if (msp->nicam_on)
                        nicam=0x0100;
                break;
        case MSP_MODE_BTSC:
-               dprintk(KERN_DEBUG "msp3400: BTSC setstereo: %s\n",
-                       strmode[audmode]);
+               dprintk("msp3400: BTSC setstereo: %s\n",strmode[mode]);
                nicam=0x0300;
                break;
        case MSP_MODE_EXTERN:
-               dprintk(KERN_DEBUG "msp3400: extern setstereo: %s\n",
-                       strmode[audmode]);
+               dprintk("msp3400: extern setstereo: %s\n",strmode[mode]);
                nicam = 0x0200;
                break;
        case MSP_MODE_FM_RADIO:
-               dprintk(KERN_DEBUG "msp3400: FM-Radio setstereo: %s\n",
-                       strmode[audmode]);
+               dprintk("msp3400: FM-Radio setstereo: %s\n",strmode[mode]);
                break;
        default:
-               dprintk(KERN_DEBUG "msp3400: mono setstereo\n");
+               dprintk("msp3400: mono setstereo\n");
                return;
        }
 
        /* switch audio */
-       switch (audmode) {
+       switch (best_video_sound(mode)) {
        case V4L2_TUNER_MODE_STEREO:
                src = 0x0020 | nicam;
                break;
@@ -588,8 +610,7 @@ static void msp3400c_set_audmode(struct i2c_client *client, int audmode)
                src = 0x0010 | nicam;
                break;
        }
-       dprintk(KERN_DEBUG
-               "msp3400: setstereo final source/matrix = 0x%x\n", src);
+       dprintk("msp3400: setstereo final source/matrix = 0x%x\n", src);
 
        if (dolby) {
                msp3400c_write(client,I2C_MSP3400C_DFP, 0x0008,0x0520);
@@ -608,26 +629,50 @@ static void
 msp3400c_print_mode(struct msp3400c *msp)
 {
        if (msp->main == msp->second) {
-               printk(KERN_DEBUG "msp3400: mono sound carrier: %d.%03d MHz\n",
+               dprintk("msp3400: mono sound carrier: %d.%03d MHz\n",
                       msp->main/910000,(msp->main/910)%1000);
        } else {
-               printk(KERN_DEBUG "msp3400: main sound carrier: %d.%03d MHz\n",
+               dprintk("msp3400: main sound carrier: %d.%03d MHz\n",
                       msp->main/910000,(msp->main/910)%1000);
        }
-       if (msp->mode == MSP_MODE_FM_NICAM1 ||
-           msp->mode == MSP_MODE_FM_NICAM2)
-               printk(KERN_DEBUG "msp3400: NICAM/FM carrier   : %d.%03d MHz\n",
+       if (msp->mode == MSP_MODE_FM_NICAM1 || msp->mode == MSP_MODE_FM_NICAM2)
+               dprintk("msp3400: NICAM/FM carrier   : %d.%03d MHz\n",
                       msp->second/910000,(msp->second/910)%1000);
        if (msp->mode == MSP_MODE_AM_NICAM)
-               printk(KERN_DEBUG "msp3400: NICAM/AM carrier   : %d.%03d MHz\n",
+               dprintk("msp3400: NICAM/AM carrier   : %d.%03d MHz\n",
                       msp->second/910000,(msp->second/910)%1000);
        if (msp->mode == MSP_MODE_FM_TERRA &&
            msp->main != msp->second) {
-               printk(KERN_DEBUG "msp3400: FM-stereo carrier : %d.%03d MHz\n",
+               dprintk("msp3400: FM-stereo carrier : %d.%03d MHz\n",
                       msp->second/910000,(msp->second/910)%1000);
        }
 }
 
+#define MSP3400_MAX 4
+static struct i2c_client *msps[MSP3400_MAX];
+static void msp3400c_restore_dfp(struct i2c_client *client)
+{
+       struct msp3400c *msp = i2c_get_clientdata(client);
+       int i;
+
+       for (i = 0; i < DFP_COUNT; i++) {
+               if (-1 == msp->dfp_regs[i])
+                       continue;
+               msp3400c_write(client, I2C_MSP3400C_DFP, i, msp->dfp_regs[i]);
+       }
+}
+
+/* if the dfp_regs is set, set what's in there. Otherwise, set the default value */
+static int msp3400c_write_dfp_with_default(struct i2c_client *client,
+                                       int addr, int default_value)
+{
+       struct msp3400c *msp = i2c_get_clientdata(client);
+       int value = default_value;
+       if (addr < DFP_COUNT && -1 != msp->dfp_regs[addr])
+               value = msp->dfp_regs[addr];
+       return msp3400c_write(client, I2C_MSP3400C_DFP, addr, value);
+}
+
 /* ----------------------------------------------------------------------- */
 
 struct REGISTER_DUMP {
@@ -635,8 +680,15 @@ struct REGISTER_DUMP {
        char *name;
 };
 
-static int
-autodetect_stereo(struct i2c_client *client)
+struct REGISTER_DUMP d1[] = {
+       {0x007e, "autodetect"},
+       {0x0023, "C_AD_BITS "},
+       {0x0038, "ADD_BITS  "},
+       {0x003e, "CIB_BITS  "},
+       {0x0057, "ERROR_RATE"},
+};
+
+static int autodetect_stereo(struct i2c_client *client)
 {
        struct msp3400c *msp = i2c_get_clientdata(client);
        int val;
@@ -649,8 +701,7 @@ autodetect_stereo(struct i2c_client *client)
                val = msp3400c_read(client, I2C_MSP3400C_DFP, 0x18);
                if (val > 32767)
                        val -= 65536;
-               dprintk(KERN_DEBUG
-                       "msp34xx: stereo detect register: %d\n",val);
+               dprintk("msp34xx: stereo detect register: %d\n",val);
                if (val > 4096) {
                        rxsubchans = V4L2_TUNER_SUB_STEREO | V4L2_TUNER_SUB_MONO;
                } else if (val < -4096) {
@@ -664,8 +715,7 @@ autodetect_stereo(struct i2c_client *client)
        case MSP_MODE_FM_NICAM2:
        case MSP_MODE_AM_NICAM:
                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x23);
-               dprintk(KERN_DEBUG
-                       "msp34xx: nicam sync=%d, mode=%d\n",
+               dprintk("msp34xx: nicam sync=%d, mode=%d\n",
                        val & 1, (val & 0x1e) >> 1);
 
                if (val & 1) {
@@ -698,8 +748,7 @@ autodetect_stereo(struct i2c_client *client)
                break;
        case MSP_MODE_BTSC:
                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x200);
-               dprintk(KERN_DEBUG
-                       "msp3410: status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
+               dprintk("msp3410: status=0x%x (pri=%s, sec=%s, %s%s%s)\n",
                        val,
                        (val & 0x0002) ? "no"     : "yes",
                        (val & 0x0004) ? "no"     : "yes",
@@ -713,13 +762,13 @@ autodetect_stereo(struct i2c_client *client)
        }
        if (rxsubchans != msp->rxsubchans) {
                update = 1;
-               dprintk(KERN_DEBUG "msp34xx: watch: rxsubchans %d => %d\n",
+               dprintk("msp34xx: watch: rxsubchans %d => %d\n",
                        msp->rxsubchans,rxsubchans);
                msp->rxsubchans = rxsubchans;
        }
        if (newnicam != msp->nicam_on) {
                update = 1;
-               dprintk(KERN_DEBUG "msp34xx: watch: nicam %d => %d\n",
+               dprintk("msp34xx: watch: nicam %d => %d\n",
                        msp->nicam_on,newnicam);
                msp->nicam_on = newnicam;
        }
@@ -741,8 +790,8 @@ static int msp34xx_sleep(struct msp3400c *msp, int timeout)
                        set_current_state(TASK_INTERRUPTIBLE);
                        schedule();
                } else {
-                       set_current_state(TASK_INTERRUPTIBLE);
-                       schedule_timeout(msecs_to_jiffies(timeout));
+                       schedule_timeout_interruptible
+                                               (msecs_to_jiffies(timeout));
                }
        }
 
@@ -756,8 +805,15 @@ static void watch_stereo(struct i2c_client *client)
 {
        struct msp3400c *msp = i2c_get_clientdata(client);
 
-       if (autodetect_stereo(client))
-               msp3400c_set_audmode(client,best_audio_mode(msp->rxsubchans));
+       if (autodetect_stereo(client)) {
+               if (msp->stereo & V4L2_TUNER_MODE_STEREO)
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_STEREO);
+               else if (msp->stereo & VIDEO_SOUND_LANG1)
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_LANG1);
+               else
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
+       }
+
        if (once)
                msp->watch_stereo = 0;
 }
@@ -785,8 +841,7 @@ static int msp3400c_thread(void *data)
                    MSP_MODE_EXTERN  == msp->mode) {
                        /* no carrier scan, just unmute */
                        printk("msp3400: thread: no carrier scan\n");
-                       msp3400c_setvolume(client, msp->muted,
-                                          msp->volume, msp->balance);
+                       msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                        continue;
                }
 
@@ -802,7 +857,8 @@ static int msp3400c_thread(void *data)
                        goto restart;
 
                /* carrier detect pass #1 -- main carrier */
-               cd = carrier_detect_main; count = CARRIER_COUNT(carrier_detect_main);
+               cd = carrier_detect_main;
+               count = CARRIER_COUNT(carrier_detect_main);
 
                if (amsound && (msp->norm == VIDEO_MODE_SECAM)) {
                        /* autodetect doesn't work well with AM ... */
@@ -836,13 +892,16 @@ static int msp3400c_thread(void *data)
                case 0: /* 4.5 */
                case 2: /* 6.0 */
                default:
-                       cd = NULL; count = 0;
+                       cd = NULL;
+                       count = 0;
                        break;
                }
 
                if (amsound && (msp->norm == VIDEO_MODE_SECAM)) {
                        /* autodetect doesn't work well with AM ... */
-                       cd = NULL; count = 0; max2 = 0;
+                       cd = NULL;
+                       count = 0;
+                       max2 = 0;
                }
                for (this = 0; this < count; this++) {
                        msp3400c_setcarrier(client, cd[this].cdo,cd[this].cdo);
@@ -865,7 +924,7 @@ static int msp3400c_thread(void *data)
                                msp->second = carrier_detect_55[max2].cdo;
                                msp3400c_setmode(client, MSP_MODE_FM_TERRA);
                                msp->nicam_on = 0;
-                               msp3400c_set_audmode(client, V4L2_TUNER_MODE_MONO);
+                               msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                                msp->watch_stereo = 1;
                        } else if (max2 == 1 && HAVE_NICAM(msp)) {
                                /* B/G NICAM */
@@ -892,7 +951,7 @@ static int msp3400c_thread(void *data)
                                msp->second = carrier_detect_65[max2].cdo;
                                msp3400c_setmode(client, MSP_MODE_FM_TERRA);
                                msp->nicam_on = 0;
-                               msp3400c_set_audmode(client, V4L2_TUNER_MODE_MONO);
+                               msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                                msp->watch_stereo = 1;
                        } else if (max2 == 0 &&
                                   msp->norm == VIDEO_MODE_SECAM) {
@@ -900,7 +959,7 @@ static int msp3400c_thread(void *data)
                                msp->second = carrier_detect_65[max2].cdo;
                                msp3400c_setmode(client, MSP_MODE_AM_NICAM);
                                msp->nicam_on = 0;
-                               msp3400c_set_audmode(client, V4L2_TUNER_MODE_MONO);
+                               msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                                msp3400c_setcarrier(client, msp->second, msp->main);
                                /* volume prescale for SCART (AM mono input) */
                                msp3400c_write(client,I2C_MSP3400C_DFP, 0x000d, 0x1900);
@@ -924,13 +983,14 @@ static int msp3400c_thread(void *data)
                        msp->nicam_on = 0;
                        msp3400c_setcarrier(client, msp->second, msp->main);
                        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
-                       msp3400c_set_audmode(client, V4L2_TUNER_MODE_MONO);
+                       msp3400c_setstereo(client, V4L2_TUNER_MODE_MONO);
                        break;
                }
 
                /* unmute */
-               msp3400c_setvolume(client, msp->muted,
-                                  msp->volume, msp->balance);
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
+               msp3400c_restore_dfp(client);
+
                if (debug)
                        msp3400c_print_mode(msp);
 
@@ -941,7 +1001,7 @@ static int msp3400c_thread(void *data)
                        watch_stereo(client);
                }
        }
-       dprintk(KERN_DEBUG "msp3400: thread: exit\n");
+       dprintk("msp3400: thread: exit\n");
        return 0;
 }
 
@@ -989,6 +1049,8 @@ static int msp34xx_modus(int norm)
 {
        switch (norm) {
        case VIDEO_MODE_PAL:
+               dprintk("msp34xx: video mode selected to PAL\n");
+
 #if 1
                /* experimental: not sure this works with all chip versions */
                return 0x7003;
@@ -997,12 +1059,16 @@ static int msp34xx_modus(int norm)
                return 0x1003;
 #endif
        case VIDEO_MODE_NTSC:  /* BTSC */
+               dprintk("msp34xx: video mode selected to NTSC\n");
                return 0x2003;
        case VIDEO_MODE_SECAM:
+               dprintk("msp34xx: video mode selected to SECAM\n");
                return 0x0003;
        case VIDEO_MODE_RADIO:
+               dprintk("msp34xx: video mode selected to Radio\n");
                return 0x0003;
        case VIDEO_MODE_AUTO:
+               dprintk("msp34xx: video mode selected to Auto\n");
                return 0x2003;
        default:
                return 0x0003;
@@ -1033,9 +1099,9 @@ static int msp3410d_thread(void *data)
 
        printk("msp3410: daemon started\n");
        for (;;) {
-               d2printk(KERN_DEBUG "msp3410: thread: sleep\n");
+               d2printk("msp3410: thread: sleep\n");
                msp34xx_sleep(msp,-1);
-               d2printk(KERN_DEBUG "msp3410: thread: wakeup\n");
+               d2printk("msp3410: thread: wakeup\n");
 
        restart:
                dprintk("msp3410: thread: restart scan\n");
@@ -1045,9 +1111,8 @@ static int msp3410d_thread(void *data)
 
                if (msp->mode == MSP_MODE_EXTERN) {
                        /* no carrier scan needed, just unmute */
-                       dprintk(KERN_DEBUG "msp3410: thread: no carrier scan\n");
-                       msp3400c_setvolume(client, msp->muted,
-                                          msp->volume, msp->balance);
+                       dprintk("msp3410: thread: no carrier scan\n");
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                        continue;
                }
 
@@ -1066,7 +1131,7 @@ static int msp3410d_thread(void *data)
                msp->watch_stereo = 0;
 
                if (debug)
-                       printk(KERN_DEBUG "msp3410: setting mode: %s (0x%04x)\n",
+                       dprintk("msp3410: setting mode: %s (0x%04x)\n",
                               msp34xx_standard_mode_name(std) ,std);
 
                if (std != 1) {
@@ -1082,13 +1147,13 @@ static int msp3410d_thread(void *data)
                                val = msp3400c_read(client, I2C_MSP3400C_DEM, 0x7e);
                                if (val < 0x07ff)
                                        break;
-                               dprintk(KERN_DEBUG "msp3410: detection still in progress\n");
+                               dprintk("msp3410: detection still in progress\n");
                        }
                }
                for (i = 0; modelist[i].name != NULL; i++)
                        if (modelist[i].retval == val)
                                break;
-               dprintk(KERN_DEBUG "msp3410: current mode: %s (0x%04x)\n",
+               dprintk("msp3410: current mode: %s (0x%04x)\n",
                        modelist[i].name ? modelist[i].name : "unknown",
                        val);
                msp->main   = modelist[i].main;
@@ -1096,7 +1161,7 @@ static int msp3410d_thread(void *data)
 
                if (amsound && (msp->norm == VIDEO_MODE_SECAM) && (val != 0x0009)) {
                        /* autodetection has failed, let backup */
-                       dprintk(KERN_DEBUG "msp3410: autodetection failed,"
+                       dprintk("msp3410: autodetection failed,"
                                " switching to backup mode: %s (0x%04x)\n",
                                modelist[8].name ? modelist[8].name : "unknown",val);
                        val = 0x0009;
@@ -1120,13 +1185,13 @@ static int msp3410d_thread(void *data)
                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
                        msp->nicam_on = 1;
                        msp->watch_stereo = 1;
-                       msp3400c_set_audmode(client,V4L2_TUNER_MODE_STEREO);
+                       msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
                        break;
                case 0x0009:
                        msp->mode = MSP_MODE_AM_NICAM;
                        msp->rxsubchans = V4L2_TUNER_SUB_MONO;
                        msp->nicam_on = 1;
-                       msp3400c_set_audmode(client,V4L2_TUNER_MODE_MONO);
+                       msp3400c_setstereo(client,V4L2_TUNER_MODE_MONO);
                        msp->watch_stereo = 1;
                        break;
                case 0x0020: /* BTSC */
@@ -1135,7 +1200,7 @@ static int msp3410d_thread(void *data)
                        msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
                        msp->nicam_on = 0;
                        msp->watch_stereo = 1;
-                       msp3400c_set_audmode(client,V4L2_TUNER_MODE_STEREO);
+                       msp3400c_setstereo(client,V4L2_TUNER_MODE_STEREO);
                        break;
                case 0x0040: /* FM radio */
                        msp->mode   = MSP_MODE_FM_RADIO;
@@ -1169,9 +1234,9 @@ static int msp3410d_thread(void *data)
                /* unmute, restore misc registers */
                msp3400c_setbass(client, msp->bass);
                msp3400c_settreble(client, msp->treble);
-               msp3400c_setvolume(client, msp->muted,
-                                   msp->volume, msp->balance);
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                msp3400c_write(client, I2C_MSP3400C_DFP, 0x0013, msp->acb);
+               msp3400c_restore_dfp(client);
 
                /* monitor tv audio mode */
                while (msp->watch_stereo) {
@@ -1180,7 +1245,7 @@ static int msp3410d_thread(void *data)
                        watch_stereo(client);
                }
        }
-       dprintk(KERN_DEBUG "msp3410: thread: exit\n");
+       dprintk("msp3410: thread: exit\n");
        return 0;
 }
 
@@ -1195,7 +1260,7 @@ static void msp34xxg_set_source(struct i2c_client *client, int source);
 /* (re-)initialize the msp34xxg, according to the current norm in msp->norm
  * return 0 if it worked, -1 if it failed
  */
-static int msp34xxg_init(struct i2c_client *client)
+static int msp34xxg_reset(struct i2c_client *client)
 {
        struct msp3400c *msp = i2c_get_clientdata(client);
        int modus,std;
@@ -1222,7 +1287,7 @@ static int msp34xxg_init(struct i2c_client *client)
                return -1;
        if (msp3400c_write(client,
                           I2C_MSP3400C_DEM,
-                          0x20/*stanard*/,
+                          0x20/*standard*/,
                           std))
                return -1;
 
@@ -1230,21 +1295,18 @@ static int msp34xxg_init(struct i2c_client *client)
           standard/audio autodetection right now */
        msp34xxg_set_source(client, msp->source);
 
-       if (msp3400c_write(client, I2C_MSP3400C_DFP,
-                          0x0e, /* AM/FM Prescale */
-                          0x3000 /* default: [15:8] 75khz deviation */))
+       if (msp3400c_write_dfp_with_default(client, 0x0e,       /* AM/FM Prescale */
+                                           0x3000
+                                           /* default: [15:8] 75khz deviation */
+           ))
                return -1;
 
-       if (msp3400c_write(client, I2C_MSP3400C_DFP,
-                          0x10, /* NICAM Prescale */
-                          0x5a00 /* default: 9db gain (as recommended) */))
+       if (msp3400c_write_dfp_with_default(client, 0x10,       /* NICAM Prescale */
+                                           0x5a00
+                                           /* default: 9db gain (as recommended) */
+           ))
                return -1;
 
-       if (msp3400c_write(client,
-                          I2C_MSP3400C_DEM,
-                          0x20, /* STANDARD SELECT  */
-                          standard /* default: 0x01 for automatic standard select*/))
-               return -1;
        return 0;
 }
 
@@ -1257,9 +1319,9 @@ static int msp34xxg_thread(void *data)
        printk("msp34xxg: daemon started\n");
        msp->source = 1; /* default */
        for (;;) {
-               d2printk(KERN_DEBUG "msp34xxg: thread: sleep\n");
+               d2printk("msp34xxg: thread: sleep\n");
                msp34xx_sleep(msp,-1);
-               d2printk(KERN_DEBUG "msp34xxg: thread: wakeup\n");
+               d2printk("msp34xxg: thread: wakeup\n");
 
        restart:
                dprintk("msp34xxg: thread: restart scan\n");
@@ -1268,7 +1330,7 @@ static int msp34xxg_thread(void *data)
                        break;
 
                /* setup the chip*/
-               msp34xxg_init(client);
+               msp34xxg_reset(client);
                std = standard;
                if (std != 0x01)
                        goto unmute;
@@ -1301,7 +1363,7 @@ static int msp34xxg_thread(void *data)
 
                msp3400c_setbass(client, msp->bass);
                msp3400c_settreble(client, msp->treble);
-               msp3400c_setvolume(client, msp->muted, msp->volume, msp->balance);
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
 
                /* restore ACB */
                if (msp3400c_write(client,
@@ -1310,7 +1372,7 @@ static int msp34xxg_thread(void *data)
                                   msp->acb))
                        return -1;
        }
-       dprintk(KERN_DEBUG "msp34xxg: thread: exit\n");
+       dprintk("msp34xxg: thread: exit\n");
        return 0;
 }
 
@@ -1449,32 +1511,36 @@ static struct i2c_client client_template =
 static int msp_attach(struct i2c_adapter *adap, int addr, int kind)
 {
        struct msp3400c *msp;
-        struct i2c_client *c;
+       struct i2c_client *c;
        int (*thread_func)(void *data) = NULL;
+       int i;
 
-        client_template.adapter = adap;
-        client_template.addr = addr;
+       client_template.adapter = adap;
+       client_template.addr = addr;
 
-        if (-1 == msp3400c_reset(&client_template)) {
-                dprintk("msp34xx: no chip found\n");
-                return -1;
-        }
+       if (-1 == msp3400c_reset(&client_template)) {
+               dprintk("msp34xx: no chip found\n");
+               return -1;
+       }
 
-        if (NULL == (c = kmalloc(sizeof(struct i2c_client),GFP_KERNEL)))
-                return -ENOMEM;
-        memcpy(c,&client_template,sizeof(struct i2c_client));
+       if (NULL == (c = kmalloc(sizeof(struct i2c_client),GFP_KERNEL)))
+               return -ENOMEM;
+       memcpy(c,&client_template,sizeof(struct i2c_client));
        if (NULL == (msp = kmalloc(sizeof(struct msp3400c),GFP_KERNEL))) {
                kfree(c);
                return -ENOMEM;
        }
 
        memset(msp,0,sizeof(struct msp3400c));
-       msp->volume  = 58880;  /* 0db gain */
-       msp->balance = 32768;
-       msp->bass    = 32768;
-       msp->treble  = 32768;
-       msp->input   = -1;
-       msp->muted   = 1;
+       msp->norm = VIDEO_MODE_NTSC;
+       msp->left = 58880;      /* 0db gain */
+       msp->right = 58880;     /* 0db gain */
+       msp->bass = 32768;
+       msp->treble = 32768;
+       msp->input = -1;
+       msp->muted = 0;
+       for (i = 0; i < DFP_COUNT; i++)
+               msp->dfp_regs[i] = -1;
 
        i2c_set_clientdata(c, msp);
        init_waitqueue_head(&msp->wq);
@@ -1495,8 +1561,9 @@ static int msp_attach(struct i2c_adapter *adap, int addr, int kind)
                dprintk("msp34xx: error while reading chip version\n");
                return -1;
        }
+       printk(KERN_INFO "msp34xx: rev1=0x%04x, rev2=0x%04x\n", msp->rev1, msp->rev2);
 
-       msp3400c_setvolume(c, msp->muted, msp->volume, msp->balance);
+       msp3400c_setvolume(c, msp->muted, msp->left, msp->right);
 
        snprintf(c->name, sizeof(c->name), "MSP34%02d%c-%c%d",
                 (msp->rev2>>8)&0xff, (msp->rev1&0xff)+'@',
@@ -1543,28 +1610,48 @@ static int msp_attach(struct i2c_adapter *adap, int addr, int kind)
        /* startup control thread if needed */
        if (thread_func) {
                msp->kthread = kthread_run(thread_func, c, "msp34xx");
+
                if (NULL == msp->kthread)
                        printk(KERN_WARNING "msp34xx: kernel_thread() failed\n");
                msp_wake_thread(c);
        }
 
        /* done */
-        i2c_attach_client(c);
+       i2c_attach_client(c);
+
+       /* update our own array */
+       for (i = 0; i < MSP3400_MAX; i++) {
+               if (NULL == msps[i]) {
+                       msps[i] = c;
+                       break;
+               }
+       }
+
        return 0;
 }
 
 static int msp_detach(struct i2c_client *client)
 {
        struct msp3400c *msp  = i2c_get_clientdata(client);
+       int i;
 
        /* shutdown control thread */
-       if (msp->kthread >= 0) {
+       if (msp->kthread) {
                msp->restart = 1;
                kthread_stop(msp->kthread);
        }
-       msp3400c_reset(client);
+       msp3400c_reset(client);
+
+       /* update our own array */
+       for (i = 0; i < MSP3400_MAX; i++) {
+               if (client == msps[i]) {
+                       msps[i] = NULL;
+                       break;
+               }
+       }
 
        i2c_detach_client(client);
+
        kfree(msp);
        kfree(client);
        return 0;
@@ -1640,7 +1727,7 @@ static void msp_any_set_audmode(struct i2c_client *client, int audmode)
        case OPMODE_MANUAL:
        case OPMODE_SIMPLE:
                msp->watch_stereo = 0;
-               msp3400c_set_audmode(client, audmode);
+               msp3400c_setstereo(client, audmode);
                break;
        case OPMODE_SIMPLER:
                msp34xxg_set_audmode(client, audmode);
@@ -1651,13 +1738,13 @@ static void msp_any_set_audmode(struct i2c_client *client, int audmode)
 static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
 {
        struct msp3400c *msp  = i2c_get_clientdata(client);
-        __u16           *sarg = arg;
+       __u16           *sarg = arg;
        int scart = 0;
 
        switch (cmd) {
 
        case AUDC_SET_INPUT:
-               dprintk(KERN_DEBUG "msp34xx: AUDC_SET_INPUT(%d)\n",*sarg);
+               dprintk("msp34xx: AUDC_SET_INPUT(%d)\n",*sarg);
                if (*sarg == msp->input)
                        break;
                msp->input = *sarg;
@@ -1691,15 +1778,18 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                        msp3400c_set_scart(client,scart,0);
                        msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
                        if (msp->opmode != OPMODE_SIMPLER)
-                               msp3400c_set_audmode(client, msp->audmode);
+                               msp3400c_setstereo(client, msp->audmode);
                }
                msp_wake_thread(client);
                break;
 
        case AUDC_SET_RADIO:
-               dprintk(KERN_DEBUG "msp34xx: AUDC_SET_RADIO\n");
+               dprintk("msp34xx: AUDC_SET_RADIO\n");
                msp->norm = VIDEO_MODE_RADIO;
-               dprintk(KERN_DEBUG "msp34xx: switching to radio mode\n");
+               dprintk("msp34xx: switching to radio mode\n");
+               if (IS_MSP34XX_G(msp))
+                       msp34xxg_reset(client);
+
                msp->watch_stereo = 0;
                switch (msp->opmode) {
                case OPMODE_MANUAL:
@@ -1707,8 +1797,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                        msp3400c_setmode(client,MSP_MODE_FM_RADIO);
                        msp3400c_setcarrier(client, MSP_CARRIER(10.7),
                                            MSP_CARRIER(10.7));
-                       msp3400c_setvolume(client, msp->muted,
-                                          msp->volume, msp->balance);
+                       msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
                        break;
                case OPMODE_SIMPLE:
                case OPMODE_SIMPLER:
@@ -1717,6 +1806,30 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                        break;
                }
                break;
+               /* work-in-progress:  hook to control the DFP registers */
+       case MSP_SET_DFPREG:
+       {
+               struct msp_dfpreg *r = arg;
+               int i;
+
+               if (r->reg < 0 || r->reg >= DFP_COUNT)
+                       return -EINVAL;
+               for (i = 0; i < sizeof(bl_dfp) / sizeof(int); i++)
+                       if (r->reg == bl_dfp[i])
+                               return -EINVAL;
+               msp->dfp_regs[r->reg] = r->value;
+               msp3400c_write(client, I2C_MSP3400C_DFP, r->reg, r->value);
+               return 0;
+       }
+       case MSP_GET_DFPREG:
+       {
+               struct msp_dfpreg *r = arg;
+
+               if (r->reg < 0 || r->reg >= DFP_COUNT)
+                       return -EINVAL;
+               r->value = msp3400c_read(client, I2C_MSP3400C_DFP, r->reg);
+               return 0;
+       }
 
        /* --- v4l ioctls --- */
        /* take care: bttv does userspace copying, we'll get a
@@ -1725,7 +1838,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        {
                struct video_audio *va = arg;
 
-               dprintk(KERN_DEBUG "msp34xx: VIDIOCGAUDIO\n");
+               dprintk("msp34xx: VIDIOCGAUDIO\n");
                va->flags |= VIDEO_AUDIO_VOLUME |
                        VIDEO_AUDIO_BASS |
                        VIDEO_AUDIO_TREBLE |
@@ -1733,8 +1846,15 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
                if (msp->muted)
                        va->flags |= VIDEO_AUDIO_MUTE;
 
-               va->volume = msp->volume;
-               va->balance = (va->volume) ? msp->balance : 32768;
+               if (msp->muted)
+                       va->flags |= VIDEO_AUDIO_MUTE;
+               va->volume = MAX(msp->left, msp->right);
+               va->balance = (32768 * MIN(msp->left, msp->right)) /
+                   (va->volume ? va->volume : 1);
+               va->balance = (msp->left < msp->right) ?
+                   (65535 - va->balance) : va->balance;
+               if (0 == va->volume)
+                       va->balance = 32768;
                va->bass = msp->bass;
                va->treble = msp->treble;
 
@@ -1746,28 +1866,47 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        {
                struct video_audio *va = arg;
 
-               dprintk(KERN_DEBUG "msp34xx: VIDIOCSAUDIO\n");
+               dprintk("msp34xx: VIDIOCSAUDIO\n");
                msp->muted = (va->flags & VIDEO_AUDIO_MUTE);
-               msp->volume = va->volume;
-               msp->balance = va->balance;
+               msp->left = (MIN(65536 - va->balance, 32768) *
+                            va->volume) / 32768;
+               msp->right = (MIN(va->balance, 32768) * va->volume) / 32768;
                msp->bass = va->bass;
                msp->treble = va->treble;
-
-               msp3400c_setvolume(client, msp->muted,
-                                  msp->volume, msp->balance);
-               msp3400c_setbass(client,msp->bass);
-               msp3400c_settreble(client,msp->treble);
+               dprintk("msp34xx: VIDIOCSAUDIO setting va->volume to %d\n",
+                       va->volume);
+               dprintk("msp34xx: VIDIOCSAUDIO setting va->balance to %d\n",
+                       va->balance);
+               dprintk("msp34xx: VIDIOCSAUDIO setting va->flags to %d\n",
+                       va->flags);
+               dprintk("msp34xx: VIDIOCSAUDIO setting msp->left to %d\n",
+                       msp->left);
+               dprintk("msp34xx: VIDIOCSAUDIO setting msp->right to %d\n",
+                       msp->right);
+               dprintk("msp34xx: VIDIOCSAUDIO setting msp->bass to %d\n",
+                       msp->bass);
+               dprintk("msp34xx: VIDIOCSAUDIO setting msp->treble to %d\n",
+                       msp->treble);
+               dprintk("msp34xx: VIDIOCSAUDIO setting msp->mode to %d\n",
+                       msp->mode);
+               msp3400c_setvolume(client, msp->muted, msp->left, msp->right);
+               msp3400c_setbass(client, msp->bass);
+               msp3400c_settreble(client, msp->treble);
 
                if (va->mode != 0 && msp->norm != VIDEO_MODE_RADIO)
                        msp_any_set_audmode(client,mode_v4l1_to_v4l2(va->mode));
                break;
        }
+
        case VIDIOCSCHAN:
        {
                struct video_channel *vc = arg;
 
-               dprintk(KERN_DEBUG "msp34xx: VIDIOCSCHAN (norm=%d)\n",vc->norm);
+               dprintk("msp34xx: VIDIOCSCHAN (norm=%d)\n",vc->norm);
                msp->norm = vc->norm;
+               if (IS_MSP34XX_G(msp))
+                       msp34xxg_reset(client);
+
                msp_wake_thread(client);
                break;
        }
@@ -1776,12 +1915,101 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        case VIDIOC_S_FREQUENCY:
        {
                /* new channel -- kick audio carrier scan */
-               dprintk(KERN_DEBUG "msp34xx: VIDIOCSFREQ\n");
+               dprintk("msp34xx: VIDIOCSFREQ\n");
+               if (IS_MSP34XX_G(msp))
+                       msp34xxg_reset(client);
+
                msp_wake_thread(client);
                break;
        }
 
        /* --- v4l2 ioctls --- */
+       case VIDIOC_S_STD:
+       {
+               v4l2_std_id *id = arg;
+
+               /*FIXME: use V4L2 mode flags on msp3400 instead of V4L1*/
+               if (*id & V4L2_STD_PAL) {
+                       msp->norm=VIDEO_MODE_PAL;
+               } else if (*id & V4L2_STD_SECAM) {
+                       msp->norm=VIDEO_MODE_SECAM;
+               } else {
+                       msp->norm=VIDEO_MODE_NTSC;
+               }
+
+               msp_wake_thread(client);
+               return 0;
+       }
+
+       case VIDIOC_G_AUDIO:
+       {
+               struct v4l2_audio *a = arg;
+
+               memset(a,0,sizeof(*a));
+
+               switch (a->index) {
+               case AUDIO_RADIO:
+                       strcpy(a->name,"Radio");
+                       break;
+               case AUDIO_EXTERN_1:
+                       strcpy(a->name,"Extern 1");
+                       break;
+               case AUDIO_EXTERN_2:
+                       strcpy(a->name,"Extern 2");
+                       break;
+               case AUDIO_TUNER:
+                       strcpy(a->name,"Television");
+                       break;
+               default:
+                       return -EINVAL;
+               }
+
+               msp_any_detect_stereo(client);
+               if (msp->audmode == V4L2_TUNER_MODE_STEREO) {
+                       a->capability=V4L2_AUDCAP_STEREO;
+               }
+
+               break;
+       }
+       case VIDIOC_S_AUDIO:
+       {
+               struct v4l2_audio *sarg = arg;
+
+               switch (sarg->index) {
+               case AUDIO_RADIO:
+                       /* Hauppauge uses IN2 for the radio */
+                       msp->mode   = MSP_MODE_FM_RADIO;
+                       scart       = SCART_IN2;
+                       break;
+               case AUDIO_EXTERN_1:
+                       /* IN1 is often used for external input ... */
+                       msp->mode   = MSP_MODE_EXTERN;
+                       scart       = SCART_IN1;
+                       break;
+               case AUDIO_EXTERN_2:
+                       /* ... sometimes it is IN2 through ;) */
+                       msp->mode   = MSP_MODE_EXTERN;
+                       scart       = SCART_IN2;
+                       break;
+               case AUDIO_TUNER:
+                       msp->mode   = -1;
+                       break;
+               }
+               if (scart) {
+                       msp->rxsubchans = V4L2_TUNER_SUB_STEREO;
+                       msp->audmode = V4L2_TUNER_MODE_STEREO;
+                       msp3400c_set_scart(client,scart,0);
+                       msp3400c_write(client,I2C_MSP3400C_DFP,0x000d,0x1900);
+               }
+               if (sarg->capability==V4L2_AUDCAP_STEREO) {
+                       msp->audmode = V4L2_TUNER_MODE_STEREO;
+               } else {
+                       msp->audmode &= ~V4L2_TUNER_MODE_STEREO;
+               }
+               msp_any_set_audmode(client, msp->audmode);
+               msp_wake_thread(client);
+               break;
+       }
        case VIDIOC_G_TUNER:
        {
                struct v4l2_tuner *vt = arg;
@@ -1809,7 +2037,7 @@ static int msp_command(struct i2c_client *client, unsigned int cmd, void *arg)
        {
                struct msp_matrix *mspm = arg;
 
-               dprintk(KERN_DEBUG "msp34xx: MSP_SET_MATRIX\n");
+               dprintk("msp34xx: MSP_SET_MATRIX\n");
                msp3400c_set_scart(client, mspm->input, mspm->output);
                break;
        }