]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/net/wireless/libertas/debugfs.c
[PATCH] libertas: fix 'keep previous scan' behavior
[karo-tx-linux.git] / drivers / net / wireless / libertas / debugfs.c
index 51dfd202f5588b79e71f025c54c859c2d5ad7c45..1545935f7a9949e152d2c964d169a6f95eee0361 100644 (file)
@@ -4,9 +4,11 @@
 #include <linux/delay.h>
 #include <linux/mm.h>
 #include <net/iw_handler.h>
+
 #include "dev.h"
 #include "decl.h"
 #include "host.h"
+#include "debugfs.h"
 
 static struct dentry *libertas_dir = NULL;
 static char *szStates[] = {
@@ -14,7 +16,9 @@ static char *szStates[] = {
        "Disconnected"
 };
 
-void libertas_debug_init(wlan_private * priv, struct net_device *dev);
+#ifdef PROC_DEBUG
+static void libertas_debug_init(wlan_private * priv, struct net_device *dev);
+#endif
 
 static int open_file_generic(struct inode *inode, struct file *file)
 {
@@ -59,43 +63,34 @@ static ssize_t libertas_getscantable(struct file *file, char __user *userbuf,
        int numscansdone = 0, res;
        unsigned long addr = get_zeroed_page(GFP_KERNEL);
        char *buf = (char *)addr;
+       struct bss_descriptor * iter_bss;
 
-       pos += snprintf(buf+pos, len-pos,
-                       "---------------------------------------");
-       pos += snprintf(buf+pos, len-pos,
-                       "---------------------------------------\n");
        pos += snprintf(buf+pos, len-pos,
                "# | ch  | ss  |       bssid       |   cap    |    TSF   | Qual | SSID \n");
-       pos += snprintf(buf+pos, len-pos,
-               "---------------------------------------");
-       pos += snprintf(buf+pos, len-pos,
-               "---------------------------------------\n");
 
-       while (numscansdone < priv->adapter->numinscantable) {
-               struct bss_descriptor *pbssinfo;
+       mutex_lock(&priv->adapter->lock);
+       list_for_each_entry (iter_bss, &priv->adapter->network_list, list) {
                u16 cap;
 
-               pbssinfo = &priv->adapter->scantable[numscansdone];
-               memcpy(&cap, &pbssinfo->cap, sizeof(cap));
+               memcpy(&cap, &iter_bss->cap, sizeof(cap));
                pos += snprintf(buf+pos, len-pos,
                        "%02u| %03d | %03ld | %02x:%02x:%02x:%02x:%02x:%02x |",
-                       numscansdone, pbssinfo->channel, pbssinfo->rssi,
-                       pbssinfo->macaddress[0], pbssinfo->macaddress[1],
-                       pbssinfo->macaddress[2], pbssinfo->macaddress[3],
-                       pbssinfo->macaddress[4], pbssinfo->macaddress[5]);
+                       numscansdone, iter_bss->channel, iter_bss->rssi,
+                       iter_bss->bssid[0], iter_bss->bssid[1],
+                       iter_bss->bssid[2], iter_bss->bssid[3],
+                       iter_bss->bssid[4], iter_bss->bssid[5]);
                pos += snprintf(buf+pos, len-pos, " %04x-", cap);
                pos += snprintf(buf+pos, len-pos, "%c%c%c |",
-                               pbssinfo->cap.ibss ? 'A' : 'I',
-                               pbssinfo->cap.privacy ? 'P' : ' ',
-                               pbssinfo->cap.spectrummgmt ? 'S' : ' ');
-               pos += snprintf(buf+pos, len-pos, " %08llx |", pbssinfo->networktsf);
-               pos += snprintf(buf+pos, len-pos, " %d |",
-                       SCAN_RSSI(priv->adapter->scantable[numscansdone].rssi));
-
-               pos += snprintf(buf+pos, len-pos, " %s\n", pbssinfo->ssid.ssid);
+                               iter_bss->cap.ibss ? 'A' : 'I',
+                               iter_bss->cap.privacy ? 'P' : ' ',
+                               iter_bss->cap.spectrummgmt ? 'S' : ' ');
+               pos += snprintf(buf+pos, len-pos, " %08llx |", iter_bss->networktsf);
+               pos += snprintf(buf+pos, len-pos, " %d |", SCAN_RSSI(iter_bss->rssi));
+               pos += snprintf(buf+pos, len-pos, " %s\n", iter_bss->ssid.ssid);
 
                numscansdone++;
        }
+       mutex_unlock(&priv->adapter->lock);
 
        res = simple_read_from_buffer(userbuf, count, ppos, buf, pos);
 
@@ -198,10 +193,10 @@ static ssize_t libertas_extscan(struct file *file, const char __user *userbuf,
        memcpy(&extscan_ssid.ssid, buf, strlen(buf)-1);
        extscan_ssid.ssidlength = strlen(buf)-1;
 
-       libertas_send_specific_SSID_scan(priv, &extscan_ssid, 1);
+       libertas_send_specific_SSID_scan(priv, &extscan_ssid, 0);
 
        memset(&wrqu, 0, sizeof(union iwreq_data));
-       wireless_send_event(priv->wlan_dev.netdev, SIOCGIWSCAN, &wrqu, NULL);
+       wireless_send_event(priv->dev, SIOCGIWSCAN, &wrqu, NULL);
 
 out_unlock:
        free_page(addr);
@@ -250,16 +245,13 @@ static void libertas_parse_bssid(char *buf, size_t count,
 {
        char *hold;
        unsigned int mac[ETH_ALEN];
-       int i;
 
        hold = strstr(buf, "bssid=");
        if (!hold)
                return;
        hold += 6;
-       sscanf(hold, "%2x:%2x:%2x:%2x:%2x:%2x", mac, mac+1, mac+2, mac+3,
-                       mac+4, mac+5);
-       for(i=0;i<ETH_ALEN;i++)
-               scan_cfg->specificBSSID[i] = mac[i];
+       sscanf(hold, MAC_FMT, mac, mac+1, mac+2, mac+3, mac+4, mac+5);
+       memcpy(scan_cfg->bssid, mac, ETH_ALEN);
 }
 
 static void libertas_parse_ssid(char *buf, size_t count,
@@ -276,29 +268,27 @@ static void libertas_parse_ssid(char *buf, size_t count,
        if (!end)
                end = buf + count - 1;
 
-       size = min(IW_ESSID_MAX_SIZE, end - hold);
-       strncpy(scan_cfg->specificSSID, hold, size);
+       size = min((size_t)IW_ESSID_MAX_SIZE, (size_t) (end - hold));
+       strncpy(scan_cfg->ssid, hold, size);
 
        return;
 }
 
-static void libertas_parse_keep(char *buf, size_t count,
-                        struct wlan_ioctl_user_scan_cfg *scan_cfg)
+static int libertas_parse_clear(char *buf, size_t count, const char *tag)
 {
        char *hold;
        int val;
 
-       hold = strstr(buf, "keep=");
+       hold = strstr(buf, tag);
        if (!hold)
-               return;
-       hold += 5;
+               return 0;
+       hold += strlen(tag);
        sscanf(hold, "%d", &val);
 
        if (val != 0)
                val = 1;
 
-       scan_cfg->keeppreviousscan = val;
-       return;
+       return val;
 }
 
 static int libertas_parse_dur(char *buf, size_t count,
@@ -381,17 +371,18 @@ static ssize_t libertas_setuserscan(struct file *file,
        dur = libertas_parse_dur(buf, count, scan_cfg);
        libertas_parse_chan(buf, count, scan_cfg, dur);
        libertas_parse_bssid(buf, count, scan_cfg);
+       scan_cfg->clear_bssid = libertas_parse_clear(buf, count, "clear_bssid=");
        libertas_parse_ssid(buf, count, scan_cfg);
-       libertas_parse_keep(buf, count, scan_cfg);
+       scan_cfg->clear_ssid = libertas_parse_clear(buf, count, "clear_ssid=");
        libertas_parse_probes(buf, count, scan_cfg);
        libertas_parse_type(buf, count, scan_cfg);
 
-       wlan_scan_networks(priv, scan_cfg);
+       wlan_scan_networks(priv, scan_cfg, 1);
        wait_event_interruptible(priv->adapter->cmd_pending,
                                 !priv->adapter->nr_cmd_pending);
 
        memset(&wrqu, 0x00, sizeof(union iwreq_data));
-       wireless_send_event(priv->wlan_dev.netdev, SIOCGIWSCAN, &wrqu, NULL);
+       wireless_send_event(priv->dev, SIOCGIWSCAN, &wrqu, NULL);
 
 out_unlock:
        free_page(addr);
@@ -406,11 +397,11 @@ static int libertas_event_initcmd(wlan_private *priv, void **response_buf,
        u16 wait_option = cmd_option_waitforrsp;
 
        if (!(*cmdnode = libertas_get_free_cmd_ctrl_node(priv))) {
-               lbs_pr_debug(1, "failed libertas_get_free_cmd_ctrl_node\n");
+               lbs_deb_debugfs("failed libertas_get_free_cmd_ctrl_node\n");
                return -ENOMEM;
        }
        if (!(*response_buf = kmalloc(3000, GFP_KERNEL))) {
-               lbs_pr_debug(1, "failed to allocate response buffer!\n");
+               lbs_deb_debugfs("failed to allocate response buffer!\n");
                return -ENOMEM;
        }
        libertas_set_cmd_ctrl_node(priv, *cmdnode, 0, wait_option, NULL);
@@ -1648,7 +1639,7 @@ struct libertas_debugfs_files {
        struct file_operations fops;
 };
 
-struct libertas_debugfs_files debugfs_files[] = {
+static struct libertas_debugfs_files debugfs_files[] = {
        { "info", 0444, FOPS(libertas_dev_info, write_file_dummy), },
        { "getscantable", 0444, FOPS(libertas_getscantable,
                                        write_file_dummy), },
@@ -1658,7 +1649,7 @@ struct libertas_debugfs_files debugfs_files[] = {
        { "setuserscan", 0600, FOPS(NULL, libertas_setuserscan), },
 };
 
-struct libertas_debugfs_files debugfs_events_files[] = {
+static struct libertas_debugfs_files debugfs_events_files[] = {
        {"low_rssi", 0644, FOPS(libertas_lowrssi_read,
                                libertas_lowrssi_write), },
        {"low_snr", 0644, FOPS(libertas_lowsnr_read,
@@ -1673,7 +1664,7 @@ struct libertas_debugfs_files debugfs_events_files[] = {
                                libertas_highsnr_write), },
 };
 
-struct libertas_debugfs_files debugfs_regs_files[] = {
+static struct libertas_debugfs_files debugfs_regs_files[] = {
        {"rdmac", 0644, FOPS(libertas_rdmac_read, libertas_rdmac_write), },
        {"wrmac", 0600, FOPS(NULL, libertas_wrmac_write), },
        {"rdbbp", 0644, FOPS(libertas_rdbbp_read, libertas_rdbbp_write), },
@@ -1759,7 +1750,7 @@ void libertas_debugfs_remove_one(wlan_private *priv)
 
        debugfs_remove(priv->regs_dir);
 
-       for(i=0; i<ARRAY_SIZE(debugfs_files); i++)
+       for(i=0; i<ARRAY_SIZE(debugfs_events_files); i++)
                debugfs_remove(priv->debugfs_events_files[i]);
 
        debugfs_remove(priv->events_dir);
@@ -1768,17 +1759,23 @@ void libertas_debugfs_remove_one(wlan_private *priv)
 #endif
        for(i=0; i<ARRAY_SIZE(debugfs_files); i++)
                debugfs_remove(priv->debugfs_files[i]);
+       debugfs_remove(priv->debugfs_dir);
 }
 
+
+
 /* debug entry */
 
+#ifdef PROC_DEBUG
+
 #define item_size(n)   (FIELD_SIZEOF(wlan_adapter, n))
 #define item_addr(n)   (offsetof(wlan_adapter, n))
 
+
 struct debug_data {
        char name[32];
        u32 size;
-       u32 addr;
+       size_t addr;
 };
 
 /* To debug any member of wlan_adapter, simply add one line here.
@@ -1825,6 +1822,8 @@ static ssize_t wlan_debugfs_read(struct file *file, char __user *userbuf,
                        val = *((u16 *) d[i].addr);
                else if (d[i].size == 4)
                        val = *((u32 *) d[i].addr);
+               else if (d[i].size == 8)
+                       val = *((u64 *) d[i].addr);
 
                pos += sprintf(p + pos, "%s=%d\n", d[i].name, val);
        }
@@ -1844,7 +1843,7 @@ static ssize_t wlan_debugfs_read(struct file *file, char __user *userbuf,
  *  @param data    data to write
  *  @return       number of data
  */
-static int wlan_debugfs_write(struct file *f, const char __user *buf,
+static ssize_t wlan_debugfs_write(struct file *f, const char __user *buf,
                            size_t cnt, loff_t *ppos)
 {
        int r, i;
@@ -1860,7 +1859,7 @@ static int wlan_debugfs_write(struct file *f, const char __user *buf,
                return 0;
 
        if (copy_from_user(pdata, buf, cnt)) {
-               lbs_pr_debug(1, "Copy from user failed\n");
+               lbs_deb_debugfs("Copy from user failed\n");
                kfree(pdata);
                return 0;
        }
@@ -1886,12 +1885,14 @@ static int wlan_debugfs_write(struct file *f, const char __user *buf,
                                *((u16 *) d[i].addr) = (u16) r;
                        else if (d[i].size == 4)
                                *((u32 *) d[i].addr) = (u32) r;
+                       else if (d[i].size == 8)
+                               *((u64 *) d[i].addr) = (u64) r;
                        break;
                } while (1);
        }
        kfree(pdata);
 
-       return cnt;
+       return (ssize_t)cnt;
 }
 
 static struct file_operations libertas_debug_fops = {
@@ -1908,7 +1909,7 @@ static struct file_operations libertas_debug_fops = {
  *  @param dev     pointer net_device
  *  @return       N/A
  */
-void libertas_debug_init(wlan_private * priv, struct net_device *dev)
+static void libertas_debug_init(wlan_private * priv, struct net_device *dev)
 {
        int i;
 
@@ -1916,20 +1917,11 @@ void libertas_debug_init(wlan_private * priv, struct net_device *dev)
                return;
 
        for (i = 0; i < num_of_items; i++)
-               items[i].addr += (u32) priv->adapter;
+               items[i].addr += (size_t) priv->adapter;
 
        priv->debugfs_debug = debugfs_create_file("debug", 0644,
                                                  priv->debugfs_dir, &items[0],
                                                  &libertas_debug_fops);
 }
+#endif
 
-/**
- *  @brief remove proc file
- *
- *  @param priv           pointer wlan_private
- *  @return       N/A
- */
-void libertas_debug_remove(wlan_private * priv)
-{
-       debugfs_remove(priv->debugfs_debug);
-}