]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - drivers/net/wireless/mwl8k.c
mwl8k: get rid of the struct mwl8k_firmware abstraction
[mv-sheeva.git] / drivers / net / wireless / mwl8k.c
index 746532ebe5a8c90555e2f6b7100c66f62549e003..19fe7124d93a991eb070a1ba57934f650bd35a02 100644 (file)
@@ -12,6 +12,7 @@
 #include <linux/init.h>
 #include <linux/module.h>
 #include <linux/kernel.h>
+#include <linux/sched.h>
 #include <linux/spinlock.h>
 #include <linux/list.h>
 #include <linux/pci.h>
 #define MWL8K_NAME     KBUILD_MODNAME
 #define MWL8K_VERSION  "0.10"
 
-MODULE_DESCRIPTION(MWL8K_DESC);
-MODULE_VERSION(MWL8K_VERSION);
-MODULE_AUTHOR("Lennert Buytenhek <buytenh@marvell.com>");
-MODULE_LICENSE("GPL");
-
-static DEFINE_PCI_DEVICE_TABLE(mwl8k_table) = {
-       { PCI_VDEVICE(MARVELL, 0x2a2b), .driver_data = 8687, },
-       { PCI_VDEVICE(MARVELL, 0x2a30), .driver_data = 8687, },
-       { }
-};
-MODULE_DEVICE_TABLE(pci, mwl8k_table);
-
 /* Register definitions */
 #define MWL8K_HIU_GEN_PTR                      0x00000c10
 #define  MWL8K_MODE_STA                                 0x0000005a
@@ -88,72 +77,82 @@ MODULE_DEVICE_TABLE(pci, mwl8k_table);
                                 MWL8K_A2H_INT_RX_READY | \
                                 MWL8K_A2H_INT_TX_DONE)
 
-/* WME stream classes */
-#define WME_AC_BE      0               /* best effort */
-#define WME_AC_BK      1               /* background */
-#define WME_AC_VI      2               /* video */
-#define WME_AC_VO      3               /* voice */
-
 #define MWL8K_RX_QUEUES                1
 #define MWL8K_TX_QUEUES                4
 
+struct rxd_ops {
+       int rxd_size;
+       void (*rxd_init)(void *rxd, dma_addr_t next_dma_addr);
+       void (*rxd_refill)(void *rxd, dma_addr_t addr, int len);
+       int (*rxd_process)(void *rxd, struct ieee80211_rx_status *status,
+                          __le16 *qos);
+};
+
+struct mwl8k_device_info {
+       char *part_name;
+       char *helper_image;
+       char *fw_image;
+       struct rxd_ops *rxd_ops;
+       u16 modes;
+};
+
 struct mwl8k_rx_queue {
-       int rx_desc_count;
+       int rxd_count;
 
        /* hw receives here */
-       int rx_head;
+       int head;
 
        /* refill descs here */
-       int rx_tail;
+       int tail;
 
-       struct mwl8k_rx_desc *rx_desc_area;
-       dma_addr_t rx_desc_dma;
-       struct sk_buff **rx_skb;
+       void *rxd;
+       dma_addr_t rxd_dma;
+       struct {
+               struct sk_buff *skb;
+               DECLARE_PCI_UNMAP_ADDR(dma)
+       } *buf;
 };
 
 struct mwl8k_tx_queue {
        /* hw transmits here */
-       int tx_head;
+       int head;
 
        /* sw appends here */
-       int tx_tail;
-
-       struct ieee80211_tx_queue_stats tx_stats;
-       struct mwl8k_tx_desc *tx_desc_area;
-       dma_addr_t tx_desc_dma;
-       struct sk_buff **tx_skb;
-};
-
-/* Pointers to the firmware data and meta information about it.  */
-struct mwl8k_firmware {
-       /* Microcode */
-       struct firmware *ucode;
+       int tail;
 
-       /* Boot helper code */
-       struct firmware *helper;
+       struct ieee80211_tx_queue_stats stats;
+       struct mwl8k_tx_desc *txd;
+       dma_addr_t txd_dma;
+       struct sk_buff **skb;
 };
 
 struct mwl8k_priv {
+       void __iomem *sram;
        void __iomem *regs;
        struct ieee80211_hw *hw;
 
        struct pci_dev *pdev;
-       u8 name[16];
+
+       struct mwl8k_device_info *device_info;
+       bool ap_fw;
+       struct rxd_ops *rxd_ops;
 
        /* firmware files and meta data */
-       struct mwl8k_firmware fw;
-       u32 part_num;
+       struct firmware *fw_helper;
+       struct firmware *fw_ucode;
 
        /* firmware access */
        struct mutex fw_mutex;
        struct task_struct *fw_mutex_owner;
        int fw_mutex_depth;
-       struct completion *tx_wait;
        struct completion *hostcmd_wait;
 
        /* lock held over TX and TX reap */
        spinlock_t tx_lock;
 
+       /* TX quiesce completion, protected by fw_mutex and tx_lock */
+       struct completion *tx_wait;
+
        struct ieee80211_vif *vif;
 
        struct ieee80211_channel *current_channel;
@@ -178,10 +177,11 @@ struct mwl8k_priv {
        /* PHY parameters */
        struct ieee80211_supported_band band;
        struct ieee80211_channel channels[14];
-       struct ieee80211_rate rates[12];
+       struct ieee80211_rate rates[14];
 
        bool radio_on;
        bool radio_short_preamble;
+       bool sniffer_enabled;
        bool wmm_enabled;
 
        /* XXX need to convert this to handle multiple interfaces */
@@ -199,9 +199,6 @@ struct mwl8k_priv {
 
        /* Tasklet to reclaim TX descriptors and buffers after tx */
        struct tasklet_struct tx_reclaim_task;
-
-       /* Work thread to serialize configuration requests */
-       struct workqueue_struct *config_wq;
 };
 
 /* Per interface specific private data */
@@ -216,16 +213,7 @@ struct mwl8k_vif {
        u8      bssid[ETH_ALEN];
        u8      mac_addr[ETH_ALEN];
 
-       /*
-        * Subset of supported legacy rates.
-        * Intersection of AP and STA supported rates.
-        */
-       struct ieee80211_rate legacy_rates[12];
-
-       /* number of supported legacy rates */
-       u8      legacy_nrates;
-
-        /* Index into station database.Returned by update_sta_db call */
+       /* Index into station database. Returned by UPDATE_STADB.  */
        u8      peer_id;
 
        /* Non AMPDU sequence number assigned by driver */
@@ -246,21 +234,30 @@ static const struct ieee80211_channel mwl8k_channels[] = {
        { .center_freq = 2452, .hw_value = 9, },
        { .center_freq = 2457, .hw_value = 10, },
        { .center_freq = 2462, .hw_value = 11, },
+       { .center_freq = 2467, .hw_value = 12, },
+       { .center_freq = 2472, .hw_value = 13, },
+       { .center_freq = 2484, .hw_value = 14, },
 };
 
 static const struct ieee80211_rate mwl8k_rates[] = {
        { .bitrate = 10, .hw_value = 2, },
        { .bitrate = 20, .hw_value = 4, },
        { .bitrate = 55, .hw_value = 11, },
+       { .bitrate = 110, .hw_value = 22, },
+       { .bitrate = 220, .hw_value = 44, },
        { .bitrate = 60, .hw_value = 12, },
        { .bitrate = 90, .hw_value = 18, },
-       { .bitrate = 110, .hw_value = 22, },
        { .bitrate = 120, .hw_value = 24, },
        { .bitrate = 180, .hw_value = 36, },
        { .bitrate = 240, .hw_value = 48, },
        { .bitrate = 360, .hw_value = 72, },
        { .bitrate = 480, .hw_value = 96, },
        { .bitrate = 540, .hw_value = 108, },
+       { .bitrate = 720, .hw_value = 144, },
+};
+
+static const u8 mwl8k_rateids[12] = {
+       2, 4, 11, 22, 12, 18, 24, 36, 48, 72, 96, 108,
 };
 
 /* Set or get info from Firmware */
@@ -270,10 +267,12 @@ static const struct ieee80211_rate mwl8k_rates[] = {
 /* Firmware command codes */
 #define MWL8K_CMD_CODE_DNLD            0x0001
 #define MWL8K_CMD_GET_HW_SPEC          0x0003
+#define MWL8K_CMD_SET_HW_SPEC          0x0004
 #define MWL8K_CMD_MAC_MULTICAST_ADR    0x0010
 #define MWL8K_CMD_GET_STAT             0x0014
 #define MWL8K_CMD_RADIO_CONTROL                0x001c
 #define MWL8K_CMD_RF_TX_POWER          0x001e
+#define MWL8K_CMD_RF_ANTENNA           0x0020
 #define MWL8K_CMD_SET_PRE_SCAN         0x0107
 #define MWL8K_CMD_SET_POST_SCAN                0x0108
 #define MWL8K_CMD_SET_RF_CHANNEL       0x010a
@@ -287,6 +286,7 @@ static const struct ieee80211_rate mwl8k_rates[] = {
 #define MWL8K_CMD_MIMO_CONFIG          0x0125
 #define MWL8K_CMD_USE_FIXED_RATE       0x0126
 #define MWL8K_CMD_ENABLE_SNIFFER       0x0150
+#define MWL8K_CMD_SET_MAC_ADDR         0x0202
 #define MWL8K_CMD_SET_RATEADAPT_MODE   0x0203
 #define MWL8K_CMD_UPDATE_STADB         0x1123
 
@@ -299,10 +299,12 @@ static const char *mwl8k_cmd_name(u16 cmd, char *buf, int bufsize)
        switch (cmd & ~0x8000) {
                MWL8K_CMDNAME(CODE_DNLD);
                MWL8K_CMDNAME(GET_HW_SPEC);
+               MWL8K_CMDNAME(SET_HW_SPEC);
                MWL8K_CMDNAME(MAC_MULTICAST_ADR);
                MWL8K_CMDNAME(GET_STAT);
                MWL8K_CMDNAME(RADIO_CONTROL);
                MWL8K_CMDNAME(RF_TX_POWER);
+               MWL8K_CMDNAME(RF_ANTENNA);
                MWL8K_CMDNAME(SET_PRE_SCAN);
                MWL8K_CMDNAME(SET_POST_SCAN);
                MWL8K_CMDNAME(SET_RF_CHANNEL);
@@ -316,6 +318,7 @@ static const char *mwl8k_cmd_name(u16 cmd, char *buf, int bufsize)
                MWL8K_CMDNAME(MIMO_CONFIG);
                MWL8K_CMDNAME(USE_FIXED_RATE);
                MWL8K_CMDNAME(ENABLE_SNIFFER);
+               MWL8K_CMDNAME(SET_MAC_ADDR);
                MWL8K_CMDNAME(SET_RATEADAPT_MODE);
                MWL8K_CMDNAME(UPDATE_STADB);
        default:
@@ -347,54 +350,51 @@ static void mwl8k_release_fw(struct firmware **fw)
 
 static void mwl8k_release_firmware(struct mwl8k_priv *priv)
 {
-       mwl8k_release_fw(&priv->fw.ucode);
-       mwl8k_release_fw(&priv->fw.helper);
+       mwl8k_release_fw(&priv->fw_ucode);
+       mwl8k_release_fw(&priv->fw_helper);
 }
 
 /* Request fw image */
 static int mwl8k_request_fw(struct mwl8k_priv *priv,
-                               const char *fname, struct firmware **fw)
+                           const char *fname, struct firmware **fw)
 {
        /* release current image */
        if (*fw != NULL)
                mwl8k_release_fw(fw);
 
        return request_firmware((const struct firmware **)fw,
-                                               fname, &priv->pdev->dev);
+                               fname, &priv->pdev->dev);
 }
 
-static int mwl8k_request_firmware(struct mwl8k_priv *priv, u32 part_num)
+static int mwl8k_request_firmware(struct mwl8k_priv *priv)
 {
-       u8 filename[64];
+       struct mwl8k_device_info *di = priv->device_info;
        int rc;
 
-       priv->part_num = part_num;
-
-       snprintf(filename, sizeof(filename),
-                "mwl8k/helper_%u.fw", priv->part_num);
-
-       rc = mwl8k_request_fw(priv, filename, &priv->fw.helper);
-       if (rc) {
-               printk(KERN_ERR
-                       "%s Error requesting helper firmware file %s\n",
-                       pci_name(priv->pdev), filename);
-               return rc;
+       if (di->helper_image != NULL) {
+               rc = mwl8k_request_fw(priv, di->helper_image, &priv->fw_helper);
+               if (rc) {
+                       printk(KERN_ERR "%s: Error requesting helper "
+                              "firmware file %s\n", pci_name(priv->pdev),
+                              di->helper_image);
+                       return rc;
+               }
        }
 
-       snprintf(filename, sizeof(filename),
-                "mwl8k/fmimage_%u.fw", priv->part_num);
-
-       rc = mwl8k_request_fw(priv, filename, &priv->fw.ucode);
+       rc = mwl8k_request_fw(priv, di->fw_image, &priv->fw_ucode);
        if (rc) {
-               printk(KERN_ERR "%s Error requesting firmware file %s\n",
-                                       pci_name(priv->pdev), filename);
-               mwl8k_release_fw(&priv->fw.helper);
+               printk(KERN_ERR "%s: Error requesting firmware file %s\n",
+                      pci_name(priv->pdev), di->fw_image);
+               mwl8k_release_fw(&priv->fw_helper);
                return rc;
        }
 
        return 0;
 }
 
+MODULE_FIRMWARE("mwl8k/helper_8687.fw");
+MODULE_FIRMWARE("mwl8k/fmimage_8687.fw");
+
 struct mwl8k_cmd_pkt {
        __le16  code;
        __le16  length;
@@ -434,6 +434,7 @@ mwl8k_send_fw_load_cmd(struct mwl8k_priv *priv, void *data, int length)
                        break;
                }
 
+               cond_resched();
                udelay(1);
        } while (--loops);
 
@@ -542,43 +543,61 @@ static int mwl8k_feed_fw_image(struct mwl8k_priv *priv,
        return rc;
 }
 
-static int mwl8k_load_firmware(struct mwl8k_priv *priv)
+static int mwl8k_load_firmware(struct ieee80211_hw *hw)
 {
-       int loops, rc;
+       struct mwl8k_priv *priv = hw->priv;
+       struct firmware *fw = priv->fw_ucode;
+       struct mwl8k_device_info *di = priv->device_info;
+       int rc;
+       int loops;
+
+       if (!memcmp(fw->data, "\x01\x00\x00\x00", 4)) {
+               struct firmware *helper = priv->fw_helper;
 
-       const u8 *ucode = priv->fw.ucode->data;
-       size_t ucode_len = priv->fw.ucode->size;
-       const u8 *helper = priv->fw.helper->data;
-       size_t helper_len = priv->fw.helper->size;
+               if (helper == NULL) {
+                       printk(KERN_ERR "%s: helper image needed but none "
+                              "given\n", pci_name(priv->pdev));
+                       return -EINVAL;
+               }
 
-       if (!memcmp(ucode, "\x01\x00\x00\x00", 4)) {
-               rc = mwl8k_load_fw_image(priv, helper, helper_len);
+               rc = mwl8k_load_fw_image(priv, helper->data, helper->size);
                if (rc) {
                        printk(KERN_ERR "%s: unable to load firmware "
-                               "helper image\n", pci_name(priv->pdev));
+                              "helper image\n", pci_name(priv->pdev));
                        return rc;
                }
-               msleep(1);
+               msleep(5);
 
-               rc = mwl8k_feed_fw_image(priv, ucode, ucode_len);
+               rc = mwl8k_feed_fw_image(priv, fw->data, fw->size);
        } else {
-               rc = mwl8k_load_fw_image(priv, ucode, ucode_len);
+               rc = mwl8k_load_fw_image(priv, fw->data, fw->size);
        }
 
        if (rc) {
-               printk(KERN_ERR "%s: unable to load firmware data\n",
-                       pci_name(priv->pdev));
+               printk(KERN_ERR "%s: unable to load firmware image\n",
+                      pci_name(priv->pdev));
                return rc;
        }
 
-       iowrite32(MWL8K_MODE_STA, priv->regs + MWL8K_HIU_GEN_PTR);
-       msleep(1);
+       if (di->modes & BIT(NL80211_IFTYPE_AP))
+               iowrite32(MWL8K_MODE_AP, priv->regs + MWL8K_HIU_GEN_PTR);
+       else
+               iowrite32(MWL8K_MODE_STA, priv->regs + MWL8K_HIU_GEN_PTR);
 
-       loops = 200000;
+       loops = 500000;
        do {
-               if (ioread32(priv->regs + MWL8K_HIU_INT_CODE)
-                                               == MWL8K_FWSTA_READY)
+               u32 ready_code;
+
+               ready_code = ioread32(priv->regs + MWL8K_HIU_INT_CODE);
+               if (ready_code == MWL8K_FWAP_READY) {
+                       priv->ap_fw = 1;
+                       break;
+               } else if (ready_code == MWL8K_FWSTA_READY) {
+                       priv->ap_fw = 0;
                        break;
+               }
+
+               cond_resched();
                udelay(1);
        } while (--loops);
 
@@ -605,9 +624,6 @@ struct ewc_ht_info {
 /* Peer Entry flags - used to define the type of the peer node */
 #define MWL8K_PEER_TYPE_ACCESSPOINT    2
 
-#define MWL8K_IEEE_LEGACY_DATA_RATES   12
-#define MWL8K_MCS_BITMAP_SIZE          16
-
 struct peer_capability_info {
        /* Peer type - AP vs. STA.  */
        __u8    peer_type;
@@ -624,10 +640,10 @@ struct peer_capability_info {
        struct ewc_ht_info      ewc_info;
 
        /* Legacy rate table. Intersection of our rates and peer rates.  */
-       __u8    legacy_rates[MWL8K_IEEE_LEGACY_DATA_RATES];
+       __u8    legacy_rates[12];
 
        /* HT rate table. Intersection of our rates and peer rates.  */
-       __u8    ht_rates[MWL8K_MCS_BITMAP_SIZE];
+       __u8    ht_rates[16];
        __u8    pad[16];
 
        /* If set, interoperability mode, no proprietary extensions.  */
@@ -637,110 +653,171 @@ struct peer_capability_info {
        __le16  amsdu_enabled;
 } __attribute__((packed));
 
-/* Inline functions to manipulate QoS field in data descriptor.  */
-static inline u16 mwl8k_qos_setbit_eosp(u16 qos)
-{
-       u16 val_mask = 1 << 4;
-
-       /* End of Service Period Bit 4 */
-       return qos | val_mask;
-}
-
-static inline u16 mwl8k_qos_setbit_ack(u16 qos, u8 ack_policy)
-{
-       u16 val_mask = 0x3;
-       u8      shift = 5;
-       u16 qos_mask = ~(val_mask << shift);
-
-       /* Ack Policy Bit 5-6 */
-       return (qos & qos_mask) | ((ack_policy & val_mask) << shift);
-}
-
-static inline u16 mwl8k_qos_setbit_amsdu(u16 qos)
-{
-       u16 val_mask = 1 << 7;
-
-       /* AMSDU present Bit 7 */
-       return qos | val_mask;
-}
-
-static inline u16 mwl8k_qos_setbit_qlen(u16 qos, u8 len)
-{
-       u16 val_mask = 0xff;
-       u8      shift = 8;
-       u16 qos_mask = ~(val_mask << shift);
-
-       /* Queue Length Bits 8-15 */
-       return (qos & qos_mask) | ((len & val_mask) << shift);
-}
-
 /* DMA header used by firmware and hardware.  */
 struct mwl8k_dma_data {
        __le16 fwlen;
        struct ieee80211_hdr wh;
+       char data[0];
 } __attribute__((packed));
 
 /* Routines to add/remove DMA header from skb.  */
-static inline void mwl8k_remove_dma_header(struct sk_buff *skb)
+static inline void mwl8k_remove_dma_header(struct sk_buff *skb, __le16 qos)
 {
-       struct mwl8k_dma_data *tr = (struct mwl8k_dma_data *)skb->data;
-       void *dst, *src = &tr->wh;
-       int hdrlen = ieee80211_hdrlen(tr->wh.frame_control);
-       u16 space = sizeof(struct mwl8k_dma_data) - hdrlen;
+       struct mwl8k_dma_data *tr;
+       int hdrlen;
+
+       tr = (struct mwl8k_dma_data *)skb->data;
+       hdrlen = ieee80211_hdrlen(tr->wh.frame_control);
 
-       dst = (void *)tr + space;
-       if (dst != src) {
-               memmove(dst, src, hdrlen);
-               skb_pull(skb, space);
+       if (hdrlen != sizeof(tr->wh)) {
+               if (ieee80211_is_data_qos(tr->wh.frame_control)) {
+                       memmove(tr->data - hdrlen, &tr->wh, hdrlen - 2);
+                       *((__le16 *)(tr->data - 2)) = qos;
+               } else {
+                       memmove(tr->data - hdrlen, &tr->wh, hdrlen);
+               }
        }
+
+       if (hdrlen != sizeof(*tr))
+               skb_pull(skb, sizeof(*tr) - hdrlen);
 }
 
 static inline void mwl8k_add_dma_header(struct sk_buff *skb)
 {
        struct ieee80211_hdr *wh;
-       u32 hdrlen, pktlen;
+       int hdrlen;
        struct mwl8k_dma_data *tr;
 
+       /*
+        * Add a firmware DMA header; the firmware requires that we
+        * present a 2-byte payload length followed by a 4-address
+        * header (without QoS field), followed (optionally) by any
+        * WEP/ExtIV header (but only filled in for CCMP).
+        */
        wh = (struct ieee80211_hdr *)skb->data;
+
        hdrlen = ieee80211_hdrlen(wh->frame_control);
-       pktlen = skb->len;
+       if (hdrlen != sizeof(*tr))
+               skb_push(skb, sizeof(*tr) - hdrlen);
 
-       /*
-        * Copy up/down the 802.11 header; the firmware requires
-        * we present a 2-byte payload length followed by a
-        * 4-address header (w/o QoS), followed (optionally) by
-        * any WEP/ExtIV header (but only filled in for CCMP).
-        */
-       if (hdrlen != sizeof(struct mwl8k_dma_data))
-               skb_push(skb, sizeof(struct mwl8k_dma_data) - hdrlen);
+       if (ieee80211_is_data_qos(wh->frame_control))
+               hdrlen -= 2;
 
        tr = (struct mwl8k_dma_data *)skb->data;
        if (wh != &tr->wh)
                memmove(&tr->wh, wh, hdrlen);
-
-       /* Clear addr4 */
-       memset(tr->wh.addr4, 0, ETH_ALEN);
+       if (hdrlen != sizeof(tr->wh))
+               memset(((void *)&tr->wh) + hdrlen, 0, sizeof(tr->wh) - hdrlen);
 
        /*
         * Firmware length is the length of the fully formed "802.11
         * payload".  That is, everything except for the 802.11 header.
         * This includes all crypto material including the MIC.
         */
-       tr->fwlen = cpu_to_le16(pktlen - hdrlen);
+       tr->fwlen = cpu_to_le16(skb->len - sizeof(*tr));
 }
 
 
 /*
- * Packet reception.
+ * Packet reception for 88w8366.
  */
-#define MWL8K_RX_CTRL_OWNED_BY_HOST    0x02
+struct mwl8k_rxd_8366 {
+       __le16 pkt_len;
+       __u8 sq2;
+       __u8 rate;
+       __le32 pkt_phys_addr;
+       __le32 next_rxd_phys_addr;
+       __le16 qos_control;
+       __le16 htsig2;
+       __le32 hw_rssi_info;
+       __le32 hw_noise_floor_info;
+       __u8 noise_floor;
+       __u8 pad0[3];
+       __u8 rssi;
+       __u8 rx_status;
+       __u8 channel;
+       __u8 rx_ctrl;
+} __attribute__((packed));
+
+#define MWL8K_8366_RATE_INFO_MCS_FORMAT                0x80
+#define MWL8K_8366_RATE_INFO_40MHZ             0x40
+#define MWL8K_8366_RATE_INFO_RATEID(x)         ((x) & 0x3f)
+
+#define MWL8K_8366_RX_CTRL_OWNED_BY_HOST       0x80
+
+static void mwl8k_rxd_8366_init(void *_rxd, dma_addr_t next_dma_addr)
+{
+       struct mwl8k_rxd_8366 *rxd = _rxd;
+
+       rxd->next_rxd_phys_addr = cpu_to_le32(next_dma_addr);
+       rxd->rx_ctrl = MWL8K_8366_RX_CTRL_OWNED_BY_HOST;
+}
+
+static void mwl8k_rxd_8366_refill(void *_rxd, dma_addr_t addr, int len)
+{
+       struct mwl8k_rxd_8366 *rxd = _rxd;
+
+       rxd->pkt_len = cpu_to_le16(len);
+       rxd->pkt_phys_addr = cpu_to_le32(addr);
+       wmb();
+       rxd->rx_ctrl = 0;
+}
+
+static int
+mwl8k_rxd_8366_process(void *_rxd, struct ieee80211_rx_status *status,
+                      __le16 *qos)
+{
+       struct mwl8k_rxd_8366 *rxd = _rxd;
+
+       if (!(rxd->rx_ctrl & MWL8K_8366_RX_CTRL_OWNED_BY_HOST))
+               return -1;
+       rmb();
+
+       memset(status, 0, sizeof(*status));
+
+       status->signal = -rxd->rssi;
+       status->noise = -rxd->noise_floor;
+
+       if (rxd->rate & MWL8K_8366_RATE_INFO_MCS_FORMAT) {
+               status->flag |= RX_FLAG_HT;
+               if (rxd->rate & MWL8K_8366_RATE_INFO_40MHZ)
+                       status->flag |= RX_FLAG_40MHZ;
+               status->rate_idx = MWL8K_8366_RATE_INFO_RATEID(rxd->rate);
+       } else {
+               int i;
+
+               for (i = 0; i < ARRAY_SIZE(mwl8k_rates); i++) {
+                       if (mwl8k_rates[i].hw_value == rxd->rate) {
+                               status->rate_idx = i;
+                               break;
+                       }
+               }
+       }
+
+       status->band = IEEE80211_BAND_2GHZ;
+       status->freq = ieee80211_channel_to_frequency(rxd->channel);
+
+       *qos = rxd->qos_control;
+
+       return le16_to_cpu(rxd->pkt_len);
+}
+
+static struct rxd_ops rxd_8366_ops = {
+       .rxd_size       = sizeof(struct mwl8k_rxd_8366),
+       .rxd_init       = mwl8k_rxd_8366_init,
+       .rxd_refill     = mwl8k_rxd_8366_refill,
+       .rxd_process    = mwl8k_rxd_8366_process,
+};
 
-struct mwl8k_rx_desc {
+/*
+ * Packet reception for 88w8687.
+ */
+struct mwl8k_rxd_8687 {
        __le16 pkt_len;
        __u8 link_quality;
        __u8 noise_level;
        __le32 pkt_phys_addr;
-       __le32 next_rx_desc_phys_addr;
+       __le32 next_rxd_phys_addr;
        __le16 qos_control;
        __le16 rate_info;
        __le32 pad0[4];
@@ -752,6 +829,78 @@ struct mwl8k_rx_desc {
        __u8 pad2[2];
 } __attribute__((packed));
 
+#define MWL8K_8687_RATE_INFO_SHORTPRE          0x8000
+#define MWL8K_8687_RATE_INFO_ANTSELECT(x)      (((x) >> 11) & 0x3)
+#define MWL8K_8687_RATE_INFO_RATEID(x)         (((x) >> 3) & 0x3f)
+#define MWL8K_8687_RATE_INFO_40MHZ             0x0004
+#define MWL8K_8687_RATE_INFO_SHORTGI           0x0002
+#define MWL8K_8687_RATE_INFO_MCS_FORMAT                0x0001
+
+#define MWL8K_8687_RX_CTRL_OWNED_BY_HOST       0x02
+
+static void mwl8k_rxd_8687_init(void *_rxd, dma_addr_t next_dma_addr)
+{
+       struct mwl8k_rxd_8687 *rxd = _rxd;
+
+       rxd->next_rxd_phys_addr = cpu_to_le32(next_dma_addr);
+       rxd->rx_ctrl = MWL8K_8687_RX_CTRL_OWNED_BY_HOST;
+}
+
+static void mwl8k_rxd_8687_refill(void *_rxd, dma_addr_t addr, int len)
+{
+       struct mwl8k_rxd_8687 *rxd = _rxd;
+
+       rxd->pkt_len = cpu_to_le16(len);
+       rxd->pkt_phys_addr = cpu_to_le32(addr);
+       wmb();
+       rxd->rx_ctrl = 0;
+}
+
+static int
+mwl8k_rxd_8687_process(void *_rxd, struct ieee80211_rx_status *status,
+                      __le16 *qos)
+{
+       struct mwl8k_rxd_8687 *rxd = _rxd;
+       u16 rate_info;
+
+       if (!(rxd->rx_ctrl & MWL8K_8687_RX_CTRL_OWNED_BY_HOST))
+               return -1;
+       rmb();
+
+       rate_info = le16_to_cpu(rxd->rate_info);
+
+       memset(status, 0, sizeof(*status));
+
+       status->signal = -rxd->rssi;
+       status->noise = -rxd->noise_level;
+       status->antenna = MWL8K_8687_RATE_INFO_ANTSELECT(rate_info);
+       status->rate_idx = MWL8K_8687_RATE_INFO_RATEID(rate_info);
+
+       if (rate_info & MWL8K_8687_RATE_INFO_SHORTPRE)
+               status->flag |= RX_FLAG_SHORTPRE;
+       if (rate_info & MWL8K_8687_RATE_INFO_40MHZ)
+               status->flag |= RX_FLAG_40MHZ;
+       if (rate_info & MWL8K_8687_RATE_INFO_SHORTGI)
+               status->flag |= RX_FLAG_SHORT_GI;
+       if (rate_info & MWL8K_8687_RATE_INFO_MCS_FORMAT)
+               status->flag |= RX_FLAG_HT;
+
+       status->band = IEEE80211_BAND_2GHZ;
+       status->freq = ieee80211_channel_to_frequency(rxd->channel);
+
+       *qos = rxd->qos_control;
+
+       return le16_to_cpu(rxd->pkt_len);
+}
+
+static struct rxd_ops rxd_8687_ops = {
+       .rxd_size       = sizeof(struct mwl8k_rxd_8687),
+       .rxd_init       = mwl8k_rxd_8687_init,
+       .rxd_refill     = mwl8k_rxd_8687_refill,
+       .rxd_process    = mwl8k_rxd_8687_process,
+};
+
+
 #define MWL8K_RX_DESCS         256
 #define MWL8K_RX_MAXSZ         3800
 
@@ -762,43 +911,44 @@ static int mwl8k_rxq_init(struct ieee80211_hw *hw, int index)
        int size;
        int i;
 
-       rxq->rx_desc_count = 0;
-       rxq->rx_head = 0;
-       rxq->rx_tail = 0;
+       rxq->rxd_count = 0;
+       rxq->head = 0;
+       rxq->tail = 0;
 
-       size = MWL8K_RX_DESCS * sizeof(struct mwl8k_rx_desc);
+       size = MWL8K_RX_DESCS * priv->rxd_ops->rxd_size;
 
-       rxq->rx_desc_area =
-               pci_alloc_consistent(priv->pdev, size, &rxq->rx_desc_dma);
-       if (rxq->rx_desc_area == NULL) {
+       rxq->rxd = pci_alloc_consistent(priv->pdev, size, &rxq->rxd_dma);
+       if (rxq->rxd == NULL) {
                printk(KERN_ERR "%s: failed to alloc RX descriptors\n",
-                      priv->name);
+                      wiphy_name(hw->wiphy));
                return -ENOMEM;
        }
-       memset(rxq->rx_desc_area, 0, size);
+       memset(rxq->rxd, 0, size);
 
-       rxq->rx_skb = kmalloc(MWL8K_RX_DESCS *
-                               sizeof(*rxq->rx_skb), GFP_KERNEL);
-       if (rxq->rx_skb == NULL) {
+       rxq->buf = kmalloc(MWL8K_RX_DESCS * sizeof(*rxq->buf), GFP_KERNEL);
+       if (rxq->buf == NULL) {
                printk(KERN_ERR "%s: failed to alloc RX skbuff list\n",
-                       priv->name);
-               pci_free_consistent(priv->pdev, size,
-                                   rxq->rx_desc_area, rxq->rx_desc_dma);
+                      wiphy_name(hw->wiphy));
+               pci_free_consistent(priv->pdev, size, rxq->rxd, rxq->rxd_dma);
                return -ENOMEM;
        }
-       memset(rxq->rx_skb, 0, MWL8K_RX_DESCS * sizeof(*rxq->rx_skb));
+       memset(rxq->buf, 0, MWL8K_RX_DESCS * sizeof(*rxq->buf));
 
        for (i = 0; i < MWL8K_RX_DESCS; i++) {
-               struct mwl8k_rx_desc *rx_desc;
+               int desc_size;
+               void *rxd;
                int nexti;
+               dma_addr_t next_dma_addr;
+
+               desc_size = priv->rxd_ops->rxd_size;
+               rxd = rxq->rxd + (i * priv->rxd_ops->rxd_size);
 
-               rx_desc = rxq->rx_desc_area + i;
-               nexti = (i + 1) % MWL8K_RX_DESCS;
+               nexti = i + 1;
+               if (nexti == MWL8K_RX_DESCS)
+                       nexti = 0;
+               next_dma_addr = rxq->rxd_dma + (nexti * desc_size);
 
-               rx_desc->next_rx_desc_phys_addr =
-                       cpu_to_le32(rxq->rx_desc_dma
-                                               + nexti * sizeof(*rx_desc));
-               rx_desc->rx_ctrl = MWL8K_RX_CTRL_OWNED_BY_HOST;
+               priv->rxd_ops->rxd_init(rxd, next_dma_addr);
        }
 
        return 0;
@@ -811,27 +961,28 @@ static int rxq_refill(struct ieee80211_hw *hw, int index, int limit)
        int refilled;
 
        refilled = 0;
-       while (rxq->rx_desc_count < MWL8K_RX_DESCS && limit--) {
+       while (rxq->rxd_count < MWL8K_RX_DESCS && limit--) {
                struct sk_buff *skb;
+               dma_addr_t addr;
                int rx;
+               void *rxd;
 
                skb = dev_alloc_skb(MWL8K_RX_MAXSZ);
                if (skb == NULL)
                        break;
 
-               rxq->rx_desc_count++;
+               addr = pci_map_single(priv->pdev, skb->data,
+                                     MWL8K_RX_MAXSZ, DMA_FROM_DEVICE);
 
-               rx = rxq->rx_tail;
-               rxq->rx_tail = (rx + 1) % MWL8K_RX_DESCS;
+               rxq->rxd_count++;
+               rx = rxq->tail++;
+               if (rxq->tail == MWL8K_RX_DESCS)
+                       rxq->tail = 0;
+               rxq->buf[rx].skb = skb;
+               pci_unmap_addr_set(&rxq->buf[rx], dma, addr);
 
-               rxq->rx_desc_area[rx].pkt_phys_addr =
-                       cpu_to_le32(pci_map_single(priv->pdev, skb->data,
-                                       MWL8K_RX_MAXSZ, DMA_FROM_DEVICE));
-
-               rxq->rx_desc_area[rx].pkt_len = cpu_to_le16(MWL8K_RX_MAXSZ);
-               rxq->rx_skb[rx] = skb;
-               wmb();
-               rxq->rx_desc_area[rx].rx_ctrl = 0;
+               rxd = rxq->rxd + (rx * priv->rxd_ops->rxd_size);
+               priv->rxd_ops->rxd_refill(rxd, addr, MWL8K_RX_MAXSZ);
 
                refilled++;
        }
@@ -847,24 +998,24 @@ static void mwl8k_rxq_deinit(struct ieee80211_hw *hw, int index)
        int i;
 
        for (i = 0; i < MWL8K_RX_DESCS; i++) {
-               if (rxq->rx_skb[i] != NULL) {
-                       unsigned long addr;
-
-                       addr = le32_to_cpu(rxq->rx_desc_area[i].pkt_phys_addr);
-                       pci_unmap_single(priv->pdev, addr, MWL8K_RX_MAXSZ,
-                                        PCI_DMA_FROMDEVICE);
-                       kfree_skb(rxq->rx_skb[i]);
-                       rxq->rx_skb[i] = NULL;
+               if (rxq->buf[i].skb != NULL) {
+                       pci_unmap_single(priv->pdev,
+                                        pci_unmap_addr(&rxq->buf[i], dma),
+                                        MWL8K_RX_MAXSZ, PCI_DMA_FROMDEVICE);
+                       pci_unmap_addr_set(&rxq->buf[i], dma, 0);
+
+                       kfree_skb(rxq->buf[i].skb);
+                       rxq->buf[i].skb = NULL;
                }
        }
 
-       kfree(rxq->rx_skb);
-       rxq->rx_skb = NULL;
+       kfree(rxq->buf);
+       rxq->buf = NULL;
 
        pci_free_consistent(priv->pdev,
-                           MWL8K_RX_DESCS * sizeof(struct mwl8k_rx_desc),
-                           rxq->rx_desc_area, rxq->rx_desc_dma);
-       rxq->rx_desc_area = NULL;
+                           MWL8K_RX_DESCS * priv->rxd_ops->rxd_size,
+                           rxq->rxd, rxq->rxd_dma);
+       rxq->rxd = NULL;
 }
 
 
@@ -880,9 +1031,11 @@ mwl8k_capture_bssid(struct mwl8k_priv *priv, struct ieee80211_hdr *wh)
                !compare_ether_addr(wh->addr3, priv->capture_bssid);
 }
 
-static inline void mwl8k_save_beacon(struct mwl8k_priv *priv,
-                                                       struct sk_buff *skb)
+static inline void mwl8k_save_beacon(struct ieee80211_hw *hw,
+                                    struct sk_buff *skb)
 {
+       struct mwl8k_priv *priv = hw->priv;
+
        priv->capture_beacon = false;
        memset(priv->capture_bssid, 0, ETH_ALEN);
 
@@ -893,8 +1046,7 @@ static inline void mwl8k_save_beacon(struct mwl8k_priv *priv,
         */
        priv->beacon_skb = skb_copy(skb, GFP_ATOMIC);
        if (priv->beacon_skb != NULL)
-               queue_work(priv->config_wq,
-                               &priv->finalize_join_worker);
+               ieee80211_queue_work(hw, &priv->finalize_join_worker);
 }
 
 static int rxq_process(struct ieee80211_hw *hw, int index, int limit)
@@ -904,53 +1056,47 @@ static int rxq_process(struct ieee80211_hw *hw, int index, int limit)
        int processed;
 
        processed = 0;
-       while (rxq->rx_desc_count && limit--) {
-               struct mwl8k_rx_desc *rx_desc;
+       while (rxq->rxd_count && limit--) {
                struct sk_buff *skb;
+               void *rxd;
+               int pkt_len;
                struct ieee80211_rx_status status;
-               unsigned long addr;
-               struct ieee80211_hdr *wh;
+               __le16 qos;
 
-               rx_desc = rxq->rx_desc_area + rxq->rx_head;
-               if (!(rx_desc->rx_ctrl & MWL8K_RX_CTRL_OWNED_BY_HOST))
+               skb = rxq->buf[rxq->head].skb;
+               if (skb == NULL)
                        break;
-               rmb();
 
-               skb = rxq->rx_skb[rxq->rx_head];
-               if (skb == NULL)
+               rxd = rxq->rxd + (rxq->head * priv->rxd_ops->rxd_size);
+
+               pkt_len = priv->rxd_ops->rxd_process(rxd, &status, &qos);
+               if (pkt_len < 0)
                        break;
-               rxq->rx_skb[rxq->rx_head] = NULL;
 
-               rxq->rx_head = (rxq->rx_head + 1) % MWL8K_RX_DESCS;
-               rxq->rx_desc_count--;
+               rxq->buf[rxq->head].skb = NULL;
+
+               pci_unmap_single(priv->pdev,
+                                pci_unmap_addr(&rxq->buf[rxq->head], dma),
+                                MWL8K_RX_MAXSZ, PCI_DMA_FROMDEVICE);
+               pci_unmap_addr_set(&rxq->buf[rxq->head], dma, 0);
 
-               addr = le32_to_cpu(rx_desc->pkt_phys_addr);
-               pci_unmap_single(priv->pdev, addr,
-                                       MWL8K_RX_MAXSZ, PCI_DMA_FROMDEVICE);
+               rxq->head++;
+               if (rxq->head == MWL8K_RX_DESCS)
+                       rxq->head = 0;
 
-               skb_put(skb, le16_to_cpu(rx_desc->pkt_len));
-               mwl8k_remove_dma_header(skb);
+               rxq->rxd_count--;
 
-               wh = (struct ieee80211_hdr *)skb->data;
+               skb_put(skb, pkt_len);
+               mwl8k_remove_dma_header(skb, qos);
 
                /*
-                * Check for pending join operation. save a copy of
-                * the beacon and schedule a tasklet to send finalize
-                * join command to the firmware.
+                * Check for a pending join operation.  Save a
+                * copy of the beacon and schedule a tasklet to
+                * send a FINALIZE_JOIN command to the firmware.
                 */
-               if (mwl8k_capture_bssid(priv, wh))
-                       mwl8k_save_beacon(priv, skb);
-
-               memset(&status, 0, sizeof(status));
-               status.mactime = 0;
-               status.signal = -rx_desc->rssi;
-               status.noise = -rx_desc->noise_level;
-               status.qual = rx_desc->link_quality;
-               status.antenna = 1;
-               status.rate_idx = 1;
-               status.flag = 0;
-               status.band = IEEE80211_BAND_2GHZ;
-               status.freq = ieee80211_channel_to_frequency(rx_desc->channel);
+               if (mwl8k_capture_bssid(priv, (void *)skb->data))
+                       mwl8k_save_beacon(hw, skb);
+
                memcpy(IEEE80211_SKB_RXCB(skb), &status, sizeof(status));
                ieee80211_rx_irqsafe(hw, skb);
 
@@ -965,30 +1111,18 @@ static int rxq_process(struct ieee80211_hw *hw, int index, int limit)
  * Packet transmission.
  */
 
-/* Transmit queue assignment.  */
-enum {
-       MWL8K_WME_AC_BK = 0,            /* background access */
-       MWL8K_WME_AC_BE = 1,            /* best effort access */
-       MWL8K_WME_AC_VI = 2,            /* video access */
-       MWL8K_WME_AC_VO = 3,            /* voice access */
-};
-
-/* Transmit packet ACK policy */
-#define MWL8K_TXD_ACK_POLICY_NORMAL            0
-#define MWL8K_TXD_ACK_POLICY_BLOCKACK          3
-
-#define GET_TXQ(_ac) (\
-               ((_ac) == WME_AC_VO) ? MWL8K_WME_AC_VO : \
-               ((_ac) == WME_AC_VI) ? MWL8K_WME_AC_VI : \
-               ((_ac) == WME_AC_BK) ? MWL8K_WME_AC_BK : \
-               MWL8K_WME_AC_BE)
-
 #define MWL8K_TXD_STATUS_OK                    0x00000001
 #define MWL8K_TXD_STATUS_OK_RETRY              0x00000002
 #define MWL8K_TXD_STATUS_OK_MORE_RETRY         0x00000004
 #define MWL8K_TXD_STATUS_MULTICAST_TX          0x00000008
 #define MWL8K_TXD_STATUS_FW_OWNED              0x80000000
 
+#define MWL8K_QOS_QLEN_UNSPEC                  0xff00
+#define MWL8K_QOS_ACK_POLICY_MASK              0x0060
+#define MWL8K_QOS_ACK_POLICY_NORMAL            0x0000
+#define MWL8K_QOS_ACK_POLICY_BLOCKACK          0x0060
+#define MWL8K_QOS_EOSP                         0x0010
+
 struct mwl8k_tx_desc {
        __le32 status;
        __u8 data_rate;
@@ -997,7 +1131,7 @@ struct mwl8k_tx_desc {
        __le32 pkt_phys_addr;
        __le16 pkt_len;
        __u8 dest_MAC_addr[ETH_ALEN];
-       __le32 next_tx_desc_phys_addr;
+       __le32 next_txd_phys_addr;
        __le32 reserved;
        __le16 rate_info;
        __u8 peer_id;
@@ -1013,44 +1147,40 @@ static int mwl8k_txq_init(struct ieee80211_hw *hw, int index)
        int size;
        int i;
 
-       memset(&txq->tx_stats, 0, sizeof(struct ieee80211_tx_queue_stats));
-       txq->tx_stats.limit = MWL8K_TX_DESCS;
-       txq->tx_head = 0;
-       txq->tx_tail = 0;
+       memset(&txq->stats, 0, sizeof(struct ieee80211_tx_queue_stats));
+       txq->stats.limit = MWL8K_TX_DESCS;
+       txq->head = 0;
+       txq->tail = 0;
 
        size = MWL8K_TX_DESCS * sizeof(struct mwl8k_tx_desc);
 
-       txq->tx_desc_area =
-               pci_alloc_consistent(priv->pdev, size, &txq->tx_desc_dma);
-       if (txq->tx_desc_area == NULL) {
+       txq->txd = pci_alloc_consistent(priv->pdev, size, &txq->txd_dma);
+       if (txq->txd == NULL) {
                printk(KERN_ERR "%s: failed to alloc TX descriptors\n",
-                      priv->name);
+                      wiphy_name(hw->wiphy));
                return -ENOMEM;
        }
-       memset(txq->tx_desc_area, 0, size);
+       memset(txq->txd, 0, size);
 
-       txq->tx_skb = kmalloc(MWL8K_TX_DESCS * sizeof(*txq->tx_skb),
-                                                               GFP_KERNEL);
-       if (txq->tx_skb == NULL) {
+       txq->skb = kmalloc(MWL8K_TX_DESCS * sizeof(*txq->skb), GFP_KERNEL);
+       if (txq->skb == NULL) {
                printk(KERN_ERR "%s: failed to alloc TX skbuff list\n",
-                      priv->name);
-               pci_free_consistent(priv->pdev, size,
-                                   txq->tx_desc_area, txq->tx_desc_dma);
+                      wiphy_name(hw->wiphy));
+               pci_free_consistent(priv->pdev, size, txq->txd, txq->txd_dma);
                return -ENOMEM;
        }
-       memset(txq->tx_skb, 0, MWL8K_TX_DESCS * sizeof(*txq->tx_skb));
+       memset(txq->skb, 0, MWL8K_TX_DESCS * sizeof(*txq->skb));
 
        for (i = 0; i < MWL8K_TX_DESCS; i++) {
                struct mwl8k_tx_desc *tx_desc;
                int nexti;
 
-               tx_desc = txq->tx_desc_area + i;
+               tx_desc = txq->txd + i;
                nexti = (i + 1) % MWL8K_TX_DESCS;
 
                tx_desc->status = 0;
-               tx_desc->next_tx_desc_phys_addr =
-                       cpu_to_le32(txq->tx_desc_dma +
-                                               nexti * sizeof(*tx_desc));
+               tx_desc->next_txd_phys_addr =
+                       cpu_to_le32(txq->txd_dma + nexti * sizeof(*tx_desc));
        }
 
        return 0;
@@ -1065,109 +1195,106 @@ static inline void mwl8k_tx_start(struct mwl8k_priv *priv)
        ioread32(priv->regs + MWL8K_HIU_INT_CODE);
 }
 
-static inline int mwl8k_txq_busy(struct mwl8k_priv *priv)
-{
-       return priv->pending_tx_pkts;
-}
-
-struct mwl8k_txq_info {
-       u32 fw_owned;
-       u32 drv_owned;
-       u32 unused;
-       u32 len;
-       u32 head;
-       u32 tail;
-};
-
-static int mwl8k_scan_tx_ring(struct mwl8k_priv *priv,
-                               struct mwl8k_txq_info *txinfo)
+static void mwl8k_dump_tx_rings(struct ieee80211_hw *hw)
 {
-       int count, desc, status;
-       struct mwl8k_tx_queue *txq;
-       struct mwl8k_tx_desc *tx_desc;
-       int ndescs = 0;
+       struct mwl8k_priv *priv = hw->priv;
+       int i;
 
-       memset(txinfo, 0, MWL8K_TX_QUEUES * sizeof(struct mwl8k_txq_info));
+       for (i = 0; i < MWL8K_TX_QUEUES; i++) {
+               struct mwl8k_tx_queue *txq = priv->txq + i;
+               int fw_owned = 0;
+               int drv_owned = 0;
+               int unused = 0;
+               int desc;
 
-       spin_lock_bh(&priv->tx_lock);
-       for (count = 0; count < MWL8K_TX_QUEUES; count++) {
-               txq = priv->txq + count;
-               txinfo[count].len = txq->tx_stats.len;
-               txinfo[count].head = txq->tx_head;
-               txinfo[count].tail = txq->tx_tail;
                for (desc = 0; desc < MWL8K_TX_DESCS; desc++) {
-                       tx_desc = txq->tx_desc_area + desc;
-                       status = le32_to_cpu(tx_desc->status);
+                       struct mwl8k_tx_desc *tx_desc = txq->txd + desc;
+                       u32 status;
 
+                       status = le32_to_cpu(tx_desc->status);
                        if (status & MWL8K_TXD_STATUS_FW_OWNED)
-                               txinfo[count].fw_owned++;
+                               fw_owned++;
                        else
-                               txinfo[count].drv_owned++;
+                               drv_owned++;
 
                        if (tx_desc->pkt_len == 0)
-                               txinfo[count].unused++;
+                               unused++;
                }
-       }
-       spin_unlock_bh(&priv->tx_lock);
 
-       return ndescs;
+               printk(KERN_ERR "%s: txq[%d] len=%d head=%d tail=%d "
+                      "fw_owned=%d drv_owned=%d unused=%d\n",
+                      wiphy_name(hw->wiphy), i,
+                      txq->stats.len, txq->head, txq->tail,
+                      fw_owned, drv_owned, unused);
+       }
 }
 
 /*
- * Must be called with hw->fw_mutex held and tx queues stopped.
+ * Must be called with priv->fw_mutex held and tx queues stopped.
  */
+#define MWL8K_TX_WAIT_TIMEOUT_MS       1000
+
 static int mwl8k_tx_wait_empty(struct ieee80211_hw *hw)
 {
        struct mwl8k_priv *priv = hw->priv;
-       DECLARE_COMPLETION_ONSTACK(cmd_wait);
-       u32 count;
-       unsigned long timeout;
+       DECLARE_COMPLETION_ONSTACK(tx_wait);
+       int retry;
+       int rc;
 
        might_sleep();
 
-       spin_lock_bh(&priv->tx_lock);
-       count = mwl8k_txq_busy(priv);
-       if (count) {
-               priv->tx_wait = &cmd_wait;
-               if (priv->radio_on)
-                       mwl8k_tx_start(priv);
-       }
-       spin_unlock_bh(&priv->tx_lock);
+       /*
+        * The TX queues are stopped at this point, so this test
+        * doesn't need to take ->tx_lock.
+        */
+       if (!priv->pending_tx_pkts)
+               return 0;
 
-       if (count) {
-               struct mwl8k_txq_info txinfo[MWL8K_TX_QUEUES];
-               int index;
-               int newcount;
+       retry = 0;
+       rc = 0;
 
-               timeout = wait_for_completion_timeout(&cmd_wait,
-                                       msecs_to_jiffies(5000));
-               if (timeout)
-                       return 0;
+       spin_lock_bh(&priv->tx_lock);
+       priv->tx_wait = &tx_wait;
+       while (!rc) {
+               int oldcount;
+               unsigned long timeout;
+
+               oldcount = priv->pending_tx_pkts;
 
-               spin_lock_bh(&priv->tx_lock);
-               priv->tx_wait = NULL;
-               newcount = mwl8k_txq_busy(priv);
                spin_unlock_bh(&priv->tx_lock);
+               timeout = wait_for_completion_timeout(&tx_wait,
+                           msecs_to_jiffies(MWL8K_TX_WAIT_TIMEOUT_MS));
+               spin_lock_bh(&priv->tx_lock);
+
+               if (timeout) {
+                       WARN_ON(priv->pending_tx_pkts);
+                       if (retry) {
+                               printk(KERN_NOTICE "%s: tx rings drained\n",
+                                      wiphy_name(hw->wiphy));
+                       }
+                       break;
+               }
+
+               if (priv->pending_tx_pkts < oldcount) {
+                       printk(KERN_NOTICE "%s: timeout waiting for tx "
+                              "rings to drain (%d -> %d pkts), retrying\n",
+                              wiphy_name(hw->wiphy), oldcount,
+                              priv->pending_tx_pkts);
+                       retry = 1;
+                       continue;
+               }
 
-               printk(KERN_ERR "%s(%u) TIMEDOUT:5000ms Pend:%u-->%u\n",
-                      __func__, __LINE__, count, newcount);
+               priv->tx_wait = NULL;
 
-               mwl8k_scan_tx_ring(priv, txinfo);
-               for (index = 0; index < MWL8K_TX_QUEUES; index++)
-                       printk(KERN_ERR
-                               "TXQ:%u L:%u H:%u T:%u FW:%u DRV:%u U:%u\n",
-                                       index,
-                                       txinfo[index].len,
-                                       txinfo[index].head,
-                                       txinfo[index].tail,
-                                       txinfo[index].fw_owned,
-                                       txinfo[index].drv_owned,
-                                       txinfo[index].unused);
+               printk(KERN_ERR "%s: tx rings stuck for %d ms\n",
+                      wiphy_name(hw->wiphy), MWL8K_TX_WAIT_TIMEOUT_MS);
+               mwl8k_dump_tx_rings(hw);
 
-               return -ETIMEDOUT;
+               rc = -ETIMEDOUT;
        }
+       spin_unlock_bh(&priv->tx_lock);
 
-       return 0;
+       return rc;
 }
 
 #define MWL8K_TXD_SUCCESS(status)                              \
@@ -1181,7 +1308,7 @@ static void mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int force)
        struct mwl8k_tx_queue *txq = priv->txq + index;
        int wake = 0;
 
-       while (txq->tx_stats.len > 0) {
+       while (txq->stats.len > 0) {
                int tx;
                struct mwl8k_tx_desc *tx_desc;
                unsigned long addr;
@@ -1190,8 +1317,8 @@ static void mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int force)
                struct ieee80211_tx_info *info;
                u32 status;
 
-               tx = txq->tx_head;
-               tx_desc = txq->tx_desc_area + tx;
+               tx = txq->head;
+               tx_desc = txq->txd + tx;
 
                status = le32_to_cpu(tx_desc->status);
 
@@ -1202,20 +1329,20 @@ static void mwl8k_txq_reclaim(struct ieee80211_hw *hw, int index, int force)
                                ~cpu_to_le32(MWL8K_TXD_STATUS_FW_OWNED);
                }
 
-               txq->tx_head = (tx + 1) % MWL8K_TX_DESCS;
-               BUG_ON(txq->tx_stats.len == 0);
-               txq->tx_stats.len--;
+               txq->head = (tx + 1) % MWL8K_TX_DESCS;
+               BUG_ON(txq->stats.len == 0);
+               txq->stats.len--;
                priv->pending_tx_pkts--;
 
                addr = le32_to_cpu(tx_desc->pkt_phys_addr);
                size = le16_to_cpu(tx_desc->pkt_len);
-               skb = txq->tx_skb[tx];
-               txq->tx_skb[tx] = NULL;
+               skb = txq->skb[tx];
+               txq->skb[tx] = NULL;
 
                BUG_ON(skb == NULL);
                pci_unmap_single(priv->pdev, addr, size, PCI_DMA_TODEVICE);
 
-               mwl8k_remove_dma_header(skb);
+               mwl8k_remove_dma_header(skb, tx_desc->qos_control);
 
                /* Mark descriptor as unused */
                tx_desc->pkt_phys_addr = 0;
@@ -1243,13 +1370,13 @@ static void mwl8k_txq_deinit(struct ieee80211_hw *hw, int index)
 
        mwl8k_txq_reclaim(hw, index, 1);
 
-       kfree(txq->tx_skb);
-       txq->tx_skb = NULL;
+       kfree(txq->skb);
+       txq->skb = NULL;
 
        pci_free_consistent(priv->pdev,
                            MWL8K_TX_DESCS * sizeof(struct mwl8k_tx_desc),
-                           txq->tx_desc_area, txq->tx_desc_dma);
-       txq->tx_desc_area = NULL;
+                           txq->txd, txq->txd_dma);
+       txq->txd = NULL;
 }
 
 static int
@@ -1292,24 +1419,17 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
        if (ieee80211_is_mgmt(wh->frame_control) ||
            ieee80211_is_ctl(wh->frame_control)) {
                txdatarate = 0;
-               qos = mwl8k_qos_setbit_eosp(qos);
-               /* Set Queue size to unspecified */
-               qos = mwl8k_qos_setbit_qlen(qos, 0xff);
+               qos |= MWL8K_QOS_QLEN_UNSPEC | MWL8K_QOS_EOSP;
        } else if (ieee80211_is_data(wh->frame_control)) {
                txdatarate = 1;
                if (is_multicast_ether_addr(wh->addr1))
                        txstatus |= MWL8K_TXD_STATUS_MULTICAST_TX;
 
-               /* Send pkt in an aggregate if AMPDU frame.  */
+               qos &= ~MWL8K_QOS_ACK_POLICY_MASK;
                if (tx_info->flags & IEEE80211_TX_CTL_AMPDU)
-                       qos = mwl8k_qos_setbit_ack(qos,
-                               MWL8K_TXD_ACK_POLICY_BLOCKACK);
+                       qos |= MWL8K_QOS_ACK_POLICY_BLOCKACK;
                else
-                       qos = mwl8k_qos_setbit_ack(qos,
-                               MWL8K_TXD_ACK_POLICY_NORMAL);
-
-               if (qos & IEEE80211_QOS_CONTROL_A_MSDU_PRESENT)
-                       qos = mwl8k_qos_setbit_amsdu(qos);
+                       qos |= MWL8K_QOS_ACK_POLICY_NORMAL;
        }
 
        dma = pci_map_single(priv->pdev, skb->data,
@@ -1317,7 +1437,7 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
 
        if (pci_dma_mapping_error(priv->pdev, dma)) {
                printk(KERN_DEBUG "%s: failed to dma map skb, "
-                       "dropping TX frame.\n", priv->name);
+                      "dropping TX frame.\n", wiphy_name(hw->wiphy));
                dev_kfree_skb(skb);
                return NETDEV_TX_OK;
        }
@@ -1326,10 +1446,10 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
 
        txq = priv->txq + index;
 
-       BUG_ON(txq->tx_skb[txq->tx_tail] != NULL);
-       txq->tx_skb[txq->tx_tail] = skb;
+       BUG_ON(txq->skb[txq->tail] != NULL);
+       txq->skb[txq->tail] = skb;
 
-       tx = txq->tx_desc_area + txq->tx_tail;
+       tx = txq->txd + txq->tail;
        tx->data_rate = txdatarate;
        tx->tx_priority = index;
        tx->qos_control = cpu_to_le16(qos);
@@ -1340,15 +1460,15 @@ mwl8k_txq_xmit(struct ieee80211_hw *hw, int index, struct sk_buff *skb)
        wmb();
        tx->status = cpu_to_le32(MWL8K_TXD_STATUS_FW_OWNED | txstatus);
 
-       txq->tx_stats.count++;
-       txq->tx_stats.len++;
+       txq->stats.count++;
+       txq->stats.len++;
        priv->pending_tx_pkts++;
 
-       txq->tx_tail++;
-       if (txq->tx_tail == MWL8K_TX_DESCS)
-               txq->tx_tail = 0;
+       txq->tail++;
+       if (txq->tail == MWL8K_TX_DESCS)
+               txq->tail = 0;
 
-       if (txq->tx_head == txq->tx_tail)
+       if (txq->head == txq->tail)
                ieee80211_stop_queue(hw, index);
 
        mwl8k_tx_start(priv);
@@ -1417,8 +1537,8 @@ static void mwl8k_fw_unlock(struct ieee80211_hw *hw)
  * Command processing.
  */
 
-/* Timeout firmware commands after 2000ms */
-#define MWL8K_CMD_TIMEOUT_MS   2000
+/* Timeout firmware commands after 10s */
+#define MWL8K_CMD_TIMEOUT_MS   10000
 
 static int mwl8k_post_cmd(struct ieee80211_hw *hw, struct mwl8k_cmd_pkt *cmd)
 {
@@ -1431,7 +1551,7 @@ static int mwl8k_post_cmd(struct ieee80211_hw *hw, struct mwl8k_cmd_pkt *cmd)
        unsigned long timeout = 0;
        u8 buf[32];
 
-       cmd->result = 0xFFFF;
+       cmd->result = 0xffff;
        dma_size = le16_to_cpu(cmd->length);
        dma_addr = pci_map_single(priv->pdev, cmd, dma_size,
                                  PCI_DMA_BIDIRECTIONAL);
@@ -1464,26 +1584,35 @@ static int mwl8k_post_cmd(struct ieee80211_hw *hw, struct mwl8k_cmd_pkt *cmd)
 
        if (!timeout) {
                printk(KERN_ERR "%s: Command %s timeout after %u ms\n",
-                      priv->name,
+                      wiphy_name(hw->wiphy),
                       mwl8k_cmd_name(cmd->code, buf, sizeof(buf)),
                       MWL8K_CMD_TIMEOUT_MS);
                rc = -ETIMEDOUT;
        } else {
+               int ms;
+
+               ms = MWL8K_CMD_TIMEOUT_MS - jiffies_to_msecs(timeout);
+
                rc = cmd->result ? -EINVAL : 0;
                if (rc)
                        printk(KERN_ERR "%s: Command %s error 0x%x\n",
-                              priv->name,
+                              wiphy_name(hw->wiphy),
                               mwl8k_cmd_name(cmd->code, buf, sizeof(buf)),
                               le16_to_cpu(cmd->result));
+               else if (ms > 2000)
+                       printk(KERN_NOTICE "%s: Command %s took %d ms\n",
+                              wiphy_name(hw->wiphy),
+                              mwl8k_cmd_name(cmd->code, buf, sizeof(buf)),
+                              ms);
        }
 
        return rc;
 }
 
 /*
- * GET_HW_SPEC.
+ * CMD_GET_HW_SPEC (STA version).
  */
-struct mwl8k_cmd_get_hw_spec {
+struct mwl8k_cmd_get_hw_spec_sta {
        struct mwl8k_cmd_pkt header;
        __u8 hw_rev;
        __u8 host_interface;
@@ -1499,13 +1628,13 @@ struct mwl8k_cmd_get_hw_spec {
        __le32 tx_queue_ptrs[MWL8K_TX_QUEUES];
        __le32 caps2;
        __le32 num_tx_desc_per_queue;
-       __le32 total_rx_desc;
+       __le32 total_rxd;
 } __attribute__((packed));
 
-static int mwl8k_cmd_get_hw_spec(struct ieee80211_hw *hw)
+static int mwl8k_cmd_get_hw_spec_sta(struct ieee80211_hw *hw)
 {
        struct mwl8k_priv *priv = hw->priv;
-       struct mwl8k_cmd_get_hw_spec *cmd;
+       struct mwl8k_cmd_get_hw_spec_sta *cmd;
        int rc;
        int i;
 
@@ -1518,12 +1647,12 @@ static int mwl8k_cmd_get_hw_spec(struct ieee80211_hw *hw)
 
        memset(cmd->perm_addr, 0xff, sizeof(cmd->perm_addr));
        cmd->ps_cookie = cpu_to_le32(priv->cookie_dma);
-       cmd->rx_queue_ptr = cpu_to_le32(priv->rxq[0].rx_desc_dma);
+       cmd->rx_queue_ptr = cpu_to_le32(priv->rxq[0].rxd_dma);
        cmd->num_tx_queues = cpu_to_le32(MWL8K_TX_QUEUES);
        for (i = 0; i < MWL8K_TX_QUEUES; i++)
-               cmd->tx_queue_ptrs[i] = cpu_to_le32(priv->txq[i].tx_desc_dma);
+               cmd->tx_queue_ptrs[i] = cpu_to_le32(priv->txq[i].txd_dma);
        cmd->num_tx_desc_per_queue = cpu_to_le32(MWL8K_TX_DESCS);
-       cmd->total_rx_desc = cpu_to_le32(MWL8K_RX_DESCS);
+       cmd->total_rxd = cpu_to_le32(MWL8K_RX_DESCS);
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
 
@@ -1539,58 +1668,192 @@ static int mwl8k_cmd_get_hw_spec(struct ieee80211_hw *hw)
 }
 
 /*
- * CMD_MAC_MULTICAST_ADR.
+ * CMD_GET_HW_SPEC (AP version).
  */
-struct mwl8k_cmd_mac_multicast_adr {
+struct mwl8k_cmd_get_hw_spec_ap {
        struct mwl8k_cmd_pkt header;
-       __le16 action;
-       __le16 numaddr;
-       __u8 addr[0][ETH_ALEN];
-};
-
-#define MWL8K_ENABLE_RX_MULTICAST 0x000F
+       __u8 hw_rev;
+       __u8 host_interface;
+       __le16 num_wcb;
+       __le16 num_mcaddrs;
+       __u8 perm_addr[ETH_ALEN];
+       __le16 region_code;
+       __le16 num_antenna;
+       __le32 fw_rev;
+       __le32 wcbbase0;
+       __le32 rxwrptr;
+       __le32 rxrdptr;
+       __le32 ps_cookie;
+       __le32 wcbbase1;
+       __le32 wcbbase2;
+       __le32 wcbbase3;
+} __attribute__((packed));
 
-static struct mwl8k_cmd_pkt *
-__mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw,
-                             int mc_count, struct dev_addr_list *mclist)
+static int mwl8k_cmd_get_hw_spec_ap(struct ieee80211_hw *hw)
 {
        struct mwl8k_priv *priv = hw->priv;
-       struct mwl8k_cmd_mac_multicast_adr *cmd;
-       int size;
-       int i;
+       struct mwl8k_cmd_get_hw_spec_ap *cmd;
+       int rc;
 
-       if (mc_count > priv->num_mcaddrs)
-               mc_count = priv->num_mcaddrs;
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
 
-       size = sizeof(*cmd) + mc_count * ETH_ALEN;
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_GET_HW_SPEC);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
 
-       cmd = kzalloc(size, GFP_ATOMIC);
-       if (cmd == NULL)
-               return NULL;
+       memset(cmd->perm_addr, 0xff, sizeof(cmd->perm_addr));
+       cmd->ps_cookie = cpu_to_le32(priv->cookie_dma);
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_MAC_MULTICAST_ADR);
-       cmd->header.length = cpu_to_le16(size);
-       cmd->action = cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST);
-       cmd->numaddr = cpu_to_le16(mc_count);
+       rc = mwl8k_post_cmd(hw, &cmd->header);
 
-       for (i = 0; i < mc_count && mclist; i++) {
-               if (mclist->da_addrlen != ETH_ALEN) {
-                       kfree(cmd);
-                       return NULL;
-               }
-               memcpy(cmd->addr[i], mclist->da_addr, ETH_ALEN);
-               mclist = mclist->next;
+       if (!rc) {
+               int off;
+
+               SET_IEEE80211_PERM_ADDR(hw, cmd->perm_addr);
+               priv->num_mcaddrs = le16_to_cpu(cmd->num_mcaddrs);
+               priv->fw_rev = le32_to_cpu(cmd->fw_rev);
+               priv->hw_rev = cmd->hw_rev;
+
+               off = le32_to_cpu(cmd->wcbbase0) & 0xffff;
+               iowrite32(cpu_to_le32(priv->txq[0].txd_dma), priv->sram + off);
+
+               off = le32_to_cpu(cmd->rxwrptr) & 0xffff;
+               iowrite32(cpu_to_le32(priv->rxq[0].rxd_dma), priv->sram + off);
+
+               off = le32_to_cpu(cmd->rxrdptr) & 0xffff;
+               iowrite32(cpu_to_le32(priv->rxq[0].rxd_dma), priv->sram + off);
+
+               off = le32_to_cpu(cmd->wcbbase1) & 0xffff;
+               iowrite32(cpu_to_le32(priv->txq[1].txd_dma), priv->sram + off);
+
+               off = le32_to_cpu(cmd->wcbbase2) & 0xffff;
+               iowrite32(cpu_to_le32(priv->txq[2].txd_dma), priv->sram + off);
+
+               off = le32_to_cpu(cmd->wcbbase3) & 0xffff;
+               iowrite32(cpu_to_le32(priv->txq[3].txd_dma), priv->sram + off);
        }
 
-       return &cmd->header;
+       kfree(cmd);
+       return rc;
 }
 
 /*
- * CMD_802_11_GET_STAT.
+ * CMD_SET_HW_SPEC.
  */
-struct mwl8k_cmd_802_11_get_stat {
+struct mwl8k_cmd_set_hw_spec {
+       struct mwl8k_cmd_pkt header;
+       __u8 hw_rev;
+       __u8 host_interface;
+       __le16 num_mcaddrs;
+       __u8 perm_addr[ETH_ALEN];
+       __le16 region_code;
+       __le32 fw_rev;
+       __le32 ps_cookie;
+       __le32 caps;
+       __le32 rx_queue_ptr;
+       __le32 num_tx_queues;
+       __le32 tx_queue_ptrs[MWL8K_TX_QUEUES];
+       __le32 flags;
+       __le32 num_tx_desc_per_queue;
+       __le32 total_rxd;
+} __attribute__((packed));
+
+#define MWL8K_SET_HW_SPEC_FLAG_HOST_DECR_MGMT  0x00000080
+
+static int mwl8k_cmd_set_hw_spec(struct ieee80211_hw *hw)
+{
+       struct mwl8k_priv *priv = hw->priv;
+       struct mwl8k_cmd_set_hw_spec *cmd;
+       int rc;
+       int i;
+
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_HW_SPEC);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+
+       cmd->ps_cookie = cpu_to_le32(priv->cookie_dma);
+       cmd->rx_queue_ptr = cpu_to_le32(priv->rxq[0].rxd_dma);
+       cmd->num_tx_queues = cpu_to_le32(MWL8K_TX_QUEUES);
+       for (i = 0; i < MWL8K_TX_QUEUES; i++)
+               cmd->tx_queue_ptrs[i] = cpu_to_le32(priv->txq[i].txd_dma);
+       cmd->flags = cpu_to_le32(MWL8K_SET_HW_SPEC_FLAG_HOST_DECR_MGMT);
+       cmd->num_tx_desc_per_queue = cpu_to_le32(MWL8K_TX_DESCS);
+       cmd->total_rxd = cpu_to_le32(MWL8K_RX_DESCS);
+
+       rc = mwl8k_post_cmd(hw, &cmd->header);
+       kfree(cmd);
+
+       return rc;
+}
+
+/*
+ * CMD_MAC_MULTICAST_ADR.
+ */
+struct mwl8k_cmd_mac_multicast_adr {
        struct mwl8k_cmd_pkt header;
        __le16 action;
+       __le16 numaddr;
+       __u8 addr[0][ETH_ALEN];
+};
+
+#define MWL8K_ENABLE_RX_DIRECTED       0x0001
+#define MWL8K_ENABLE_RX_MULTICAST      0x0002
+#define MWL8K_ENABLE_RX_ALL_MULTICAST  0x0004
+#define MWL8K_ENABLE_RX_BROADCAST      0x0008
+
+static struct mwl8k_cmd_pkt *
+__mwl8k_cmd_mac_multicast_adr(struct ieee80211_hw *hw, int allmulti,
+                             int mc_count, struct dev_addr_list *mclist)
+{
+       struct mwl8k_priv *priv = hw->priv;
+       struct mwl8k_cmd_mac_multicast_adr *cmd;
+       int size;
+
+       if (allmulti || mc_count > priv->num_mcaddrs) {
+               allmulti = 1;
+               mc_count = 0;
+       }
+
+       size = sizeof(*cmd) + mc_count * ETH_ALEN;
+
+       cmd = kzalloc(size, GFP_ATOMIC);
+       if (cmd == NULL)
+               return NULL;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_MAC_MULTICAST_ADR);
+       cmd->header.length = cpu_to_le16(size);
+       cmd->action = cpu_to_le16(MWL8K_ENABLE_RX_DIRECTED |
+                                 MWL8K_ENABLE_RX_BROADCAST);
+
+       if (allmulti) {
+               cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_ALL_MULTICAST);
+       } else if (mc_count) {
+               int i;
+
+               cmd->action |= cpu_to_le16(MWL8K_ENABLE_RX_MULTICAST);
+               cmd->numaddr = cpu_to_le16(mc_count);
+               for (i = 0; i < mc_count && mclist; i++) {
+                       if (mclist->da_addrlen != ETH_ALEN) {
+                               kfree(cmd);
+                               return NULL;
+                       }
+                       memcpy(cmd->addr[i], mclist->da_addr, ETH_ALEN);
+                       mclist = mclist->next;
+               }
+       }
+
+       return &cmd->header;
+}
+
+/*
+ * CMD_GET_STAT.
+ */
+struct mwl8k_cmd_get_stat {
+       struct mwl8k_cmd_pkt header;
        __le32 stats[64];
 } __attribute__((packed));
 
@@ -1599,10 +1862,10 @@ struct mwl8k_cmd_802_11_get_stat {
 #define MWL8K_STAT_FCS_ERROR   24
 #define MWL8K_STAT_RTS_SUCCESS 11
 
-static int mwl8k_cmd_802_11_get_stat(struct ieee80211_hw *hw,
-                               struct ieee80211_low_level_stats *stats)
+static int mwl8k_cmd_get_stat(struct ieee80211_hw *hw,
+                             struct ieee80211_low_level_stats *stats)
 {
-       struct mwl8k_cmd_802_11_get_stat *cmd;
+       struct mwl8k_cmd_get_stat *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
@@ -1611,7 +1874,6 @@ static int mwl8k_cmd_802_11_get_stat(struct ieee80211_hw *hw,
 
        cmd->header.code = cpu_to_le16(MWL8K_CMD_GET_STAT);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le16(MWL8K_CMD_GET);
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        if (!rc) {
@@ -1630,9 +1892,9 @@ static int mwl8k_cmd_802_11_get_stat(struct ieee80211_hw *hw,
 }
 
 /*
- * CMD_802_11_RADIO_CONTROL.
+ * CMD_RADIO_CONTROL.
  */
-struct mwl8k_cmd_802_11_radio_control {
+struct mwl8k_cmd_radio_control {
        struct mwl8k_cmd_pkt header;
        __le16 action;
        __le16 control;
@@ -1640,10 +1902,10 @@ struct mwl8k_cmd_802_11_radio_control {
 } __attribute__((packed));
 
 static int
-mwl8k_cmd_802_11_radio_control(struct ieee80211_hw *hw, bool enable, bool force)
+mwl8k_cmd_radio_control(struct ieee80211_hw *hw, bool enable, bool force)
 {
        struct mwl8k_priv *priv = hw->priv;
-       struct mwl8k_cmd_802_11_radio_control *cmd;
+       struct mwl8k_cmd_radio_control *cmd;
        int rc;
 
        if (enable == priv->radio_on && !force)
@@ -1668,36 +1930,32 @@ mwl8k_cmd_802_11_radio_control(struct ieee80211_hw *hw, bool enable, bool force)
        return rc;
 }
 
-static int mwl8k_cmd_802_11_radio_disable(struct ieee80211_hw *hw)
+static int mwl8k_cmd_radio_disable(struct ieee80211_hw *hw)
 {
-       return mwl8k_cmd_802_11_radio_control(hw, 0, 0);
+       return mwl8k_cmd_radio_control(hw, 0, 0);
 }
 
-static int mwl8k_cmd_802_11_radio_enable(struct ieee80211_hw *hw)
+static int mwl8k_cmd_radio_enable(struct ieee80211_hw *hw)
 {
-       return mwl8k_cmd_802_11_radio_control(hw, 1, 0);
+       return mwl8k_cmd_radio_control(hw, 1, 0);
 }
 
 static int
 mwl8k_set_radio_preamble(struct ieee80211_hw *hw, bool short_preamble)
 {
-       struct mwl8k_priv *priv;
-
-       if (hw == NULL || hw->priv == NULL)
-               return -EINVAL;
-       priv = hw->priv;
+       struct mwl8k_priv *priv = hw->priv;
 
        priv->radio_short_preamble = short_preamble;
 
-       return mwl8k_cmd_802_11_radio_control(hw, 1, 1);
+       return mwl8k_cmd_radio_control(hw, 1, 1);
 }
 
 /*
- * CMD_802_11_RF_TX_POWER.
+ * CMD_RF_TX_POWER.
  */
 #define MWL8K_TX_POWER_LEVEL_TOTAL     8
 
-struct mwl8k_cmd_802_11_rf_tx_power {
+struct mwl8k_cmd_rf_tx_power {
        struct mwl8k_cmd_pkt header;
        __le16 action;
        __le16 support_level;
@@ -1706,9 +1964,9 @@ struct mwl8k_cmd_802_11_rf_tx_power {
        __le16 power_level_list[MWL8K_TX_POWER_LEVEL_TOTAL];
 } __attribute__((packed));
 
-static int mwl8k_cmd_802_11_rf_tx_power(struct ieee80211_hw *hw, int dBm)
+static int mwl8k_cmd_rf_tx_power(struct ieee80211_hw *hw, int dBm)
 {
-       struct mwl8k_cmd_802_11_rf_tx_power *cmd;
+       struct mwl8k_cmd_rf_tx_power *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
@@ -1726,6 +1984,39 @@ static int mwl8k_cmd_802_11_rf_tx_power(struct ieee80211_hw *hw, int dBm)
        return rc;
 }
 
+/*
+ * CMD_RF_ANTENNA.
+ */
+struct mwl8k_cmd_rf_antenna {
+       struct mwl8k_cmd_pkt header;
+       __le16 antenna;
+       __le16 mode;
+} __attribute__((packed));
+
+#define MWL8K_RF_ANTENNA_RX            1
+#define MWL8K_RF_ANTENNA_TX            2
+
+static int
+mwl8k_cmd_rf_antenna(struct ieee80211_hw *hw, int antenna, int mask)
+{
+       struct mwl8k_cmd_rf_antenna *cmd;
+       int rc;
+
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_RF_ANTENNA);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+       cmd->antenna = cpu_to_le16(antenna);
+       cmd->mode = cpu_to_le16(mask);
+
+       rc = mwl8k_post_cmd(hw, &cmd->header);
+       kfree(cmd);
+
+       return rc;
+}
+
 /*
  * CMD_SET_PRE_SCAN.
  */
@@ -1817,58 +2108,61 @@ static int mwl8k_cmd_set_rf_channel(struct ieee80211_hw *hw,
 }
 
 /*
- * CMD_SET_SLOT.
+ * CMD_SET_AID.
  */
-struct mwl8k_cmd_set_slot {
-       struct mwl8k_cmd_pkt header;
-       __le16 action;
-       __u8 short_slot;
+#define MWL8K_FRAME_PROT_DISABLED                      0x00
+#define MWL8K_FRAME_PROT_11G                           0x07
+#define MWL8K_FRAME_PROT_11N_HT_40MHZ_ONLY             0x02
+#define MWL8K_FRAME_PROT_11N_HT_ALL                    0x06
+
+struct mwl8k_cmd_update_set_aid {
+       struct  mwl8k_cmd_pkt header;
+       __le16  aid;
+
+        /* AP's MAC address (BSSID) */
+       __u8    bssid[ETH_ALEN];
+       __le16  protection_mode;
+       __u8    supp_rates[14];
 } __attribute__((packed));
 
-static int mwl8k_cmd_set_slot(struct ieee80211_hw *hw, bool short_slot_time)
+static int
+mwl8k_cmd_set_aid(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 {
-       struct mwl8k_cmd_set_slot *cmd;
+       struct mwl8k_vif *mv_vif = MWL8K_VIF(vif);
+       struct ieee80211_bss_conf *info = &mv_vif->bss_info;
+       struct mwl8k_cmd_update_set_aid *cmd;
+       u16 prot_mode;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_SLOT);
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_AID);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le16(MWL8K_CMD_SET);
-       cmd->short_slot = short_slot_time;
-
-       rc = mwl8k_post_cmd(hw, &cmd->header);
-       kfree(cmd);
-
-       return rc;
-}
-
-/*
- * CMD_MIMO_CONFIG.
- */
-struct mwl8k_cmd_mimo_config {
-       struct mwl8k_cmd_pkt header;
-       __le32 action;
-       __u8 rx_antenna_map;
-       __u8 tx_antenna_map;
-} __attribute__((packed));
+       cmd->aid = cpu_to_le16(info->aid);
 
-static int mwl8k_cmd_mimo_config(struct ieee80211_hw *hw, __u8 rx, __u8 tx)
-{
-       struct mwl8k_cmd_mimo_config *cmd;
-       int rc;
+       memcpy(cmd->bssid, mv_vif->bssid, ETH_ALEN);
 
-       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
-       if (cmd == NULL)
-               return -ENOMEM;
+       if (info->use_cts_prot) {
+               prot_mode = MWL8K_FRAME_PROT_11G;
+       } else {
+               switch (info->ht_operation_mode &
+                       IEEE80211_HT_OP_MODE_PROTECTION) {
+               case IEEE80211_HT_OP_MODE_PROTECTION_20MHZ:
+                       prot_mode = MWL8K_FRAME_PROT_11N_HT_40MHZ_ONLY;
+                       break;
+               case IEEE80211_HT_OP_MODE_PROTECTION_NONHT_MIXED:
+                       prot_mode = MWL8K_FRAME_PROT_11N_HT_ALL;
+                       break;
+               default:
+                       prot_mode = MWL8K_FRAME_PROT_DISABLED;
+                       break;
+               }
+       }
+       cmd->protection_mode = cpu_to_le16(prot_mode);
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_MIMO_CONFIG);
-       cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le32((u32)MWL8K_CMD_SET);
-       cmd->rx_antenna_map = rx;
-       cmd->tx_antenna_map = tx;
+       memcpy(cmd->supp_rates, mwl8k_rateids, sizeof(mwl8k_rateids));
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
@@ -1877,25 +2171,30 @@ static int mwl8k_cmd_mimo_config(struct ieee80211_hw *hw, __u8 rx, __u8 tx)
 }
 
 /*
- * CMD_ENABLE_SNIFFER.
+ * CMD_SET_RATE.
  */
-struct mwl8k_cmd_enable_sniffer {
-       struct mwl8k_cmd_pkt header;
-       __le32 action;
+struct mwl8k_cmd_set_rate {
+       struct  mwl8k_cmd_pkt header;
+       __u8    legacy_rates[14];
+
+       /* Bitmap for supported MCS codes.  */
+       __u8    mcs_set[16];
+       __u8    reserved[16];
 } __attribute__((packed));
 
-static int mwl8k_enable_sniffer(struct ieee80211_hw *hw, bool enable)
+static int
+mwl8k_cmd_set_rate(struct ieee80211_hw *hw, struct ieee80211_vif *vif)
 {
-       struct mwl8k_cmd_enable_sniffer *cmd;
+       struct mwl8k_cmd_set_rate *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_ENABLE_SNIFFER);
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_RATE);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le32(!!enable);
+       memcpy(cmd->legacy_rates, mwl8k_rateids, sizeof(mwl8k_rateids));
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
@@ -1904,27 +2203,39 @@ static int mwl8k_enable_sniffer(struct ieee80211_hw *hw, bool enable)
 }
 
 /*
- * CMD_SET_RATEADAPT_MODE.
+ * CMD_FINALIZE_JOIN.
  */
-struct mwl8k_cmd_set_rate_adapt_mode {
+#define MWL8K_FJ_BEACON_MAXLEN 128
+
+struct mwl8k_cmd_finalize_join {
        struct mwl8k_cmd_pkt header;
-       __le16 action;
-       __le16 mode;
+       __le32 sleep_interval;  /* Number of beacon periods to sleep */
+       __u8 beacon_data[MWL8K_FJ_BEACON_MAXLEN];
 } __attribute__((packed));
 
-static int mwl8k_cmd_setrateadaptmode(struct ieee80211_hw *hw, __u16 mode)
+static int mwl8k_cmd_finalize_join(struct ieee80211_hw *hw, void *frame,
+                                  int framelen, int dtim)
 {
-       struct mwl8k_cmd_set_rate_adapt_mode *cmd;
+       struct mwl8k_cmd_finalize_join *cmd;
+       struct ieee80211_mgmt *payload = frame;
+       int payload_len;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_RATEADAPT_MODE);
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_FINALIZE_JOIN);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le16(MWL8K_CMD_SET);
-       cmd->mode = cpu_to_le16(mode);
+       cmd->sleep_interval = cpu_to_le32(dtim ? dtim : 1);
+
+       payload_len = framelen - ieee80211_hdrlen(payload->frame_control);
+       if (payload_len < 0)
+               payload_len = 0;
+       else if (payload_len > MWL8K_FJ_BEACON_MAXLEN)
+               payload_len = MWL8K_FJ_BEACON_MAXLEN;
+
+       memcpy(cmd->beacon_data, &payload->u.beacon, payload_len);
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
@@ -1933,59 +2244,57 @@ static int mwl8k_cmd_setrateadaptmode(struct ieee80211_hw *hw, __u16 mode)
 }
 
 /*
- * CMD_SET_WMM_MODE.
+ * CMD_SET_RTS_THRESHOLD.
  */
-struct mwl8k_cmd_set_wmm {
+struct mwl8k_cmd_set_rts_threshold {
        struct mwl8k_cmd_pkt header;
        __le16 action;
+       __le16 threshold;
 } __attribute__((packed));
 
-static int mwl8k_set_wmm(struct ieee80211_hw *hw, bool enable)
+static int mwl8k_cmd_set_rts_threshold(struct ieee80211_hw *hw,
+                                      u16 action, u16 threshold)
 {
-       struct mwl8k_priv *priv = hw->priv;
-       struct mwl8k_cmd_set_wmm *cmd;
+       struct mwl8k_cmd_set_rts_threshold *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_WMM_MODE);
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_RTS_THRESHOLD);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le16(!!enable);
+       cmd->action = cpu_to_le16(action);
+       cmd->threshold = cpu_to_le16(threshold);
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
 
-       if (!rc)
-               priv->wmm_enabled = enable;
-
        return rc;
 }
 
 /*
- * CMD_SET_RTS_THRESHOLD.
+ * CMD_SET_SLOT.
  */
-struct mwl8k_cmd_rts_threshold {
+struct mwl8k_cmd_set_slot {
        struct mwl8k_cmd_pkt header;
        __le16 action;
-       __le16 threshold;
+       __u8 short_slot;
 } __attribute__((packed));
 
-static int mwl8k_rts_threshold(struct ieee80211_hw *hw,
-                              u16 action, u16 threshold)
+static int mwl8k_cmd_set_slot(struct ieee80211_hw *hw, bool short_slot_time)
 {
-       struct mwl8k_cmd_rts_threshold *cmd;
+       struct mwl8k_cmd_set_slot *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_RTS_THRESHOLD);
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_SLOT);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->action = cpu_to_le16(action);
-       cmd->threshold = cpu_to_le16(threshold);
+       cmd->action = cpu_to_le16(MWL8K_CMD_SET);
+       cmd->short_slot = short_slot_time;
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
@@ -2005,17 +2314,34 @@ struct mwl8k_cmd_set_edca_params {
        /* TX opportunity in units of 32 us */
        __le16 txop;
 
-       /* Log exponent of max contention period: 0...15*/
-       __u8 log_cw_max;
+       union {
+               struct {
+                       /* Log exponent of max contention period: 0...15 */
+                       __le32 log_cw_max;
+
+                       /* Log exponent of min contention period: 0...15 */
+                       __le32 log_cw_min;
+
+                       /* Adaptive interframe spacing in units of 32us */
+                       __u8 aifs;
+
+                       /* TX queue to configure */
+                       __u8 txq;
+               } ap;
+               struct {
+                       /* Log exponent of max contention period: 0...15 */
+                       __u8 log_cw_max;
 
-       /* Log exponent of min contention period: 0...15 */
-       __u8 log_cw_min;
+                       /* Log exponent of min contention period: 0...15 */
+                       __u8 log_cw_min;
 
-       /* Adaptive interframe spacing in units of 32us */
-       __u8 aifs;
+                       /* Adaptive interframe spacing in units of 32us */
+                       __u8 aifs;
 
-       /* TX queue to configure */
-       __u8 txq;
+                       /* TX queue to configure */
+                       __u8 txq;
+               } sta;
+       };
 } __attribute__((packed));
 
 #define MWL8K_SET_EDCA_CW      0x01
@@ -2027,10 +2353,11 @@ struct mwl8k_cmd_set_edca_params {
                                 MWL8K_SET_EDCA_AIFS)
 
 static int
-mwl8k_set_edca_params(struct ieee80211_hw *hw, __u8 qnum,
-               __u16 cw_min, __u16 cw_max,
-               __u8 aifs, __u16 txop)
+mwl8k_cmd_set_edca_params(struct ieee80211_hw *hw, __u8 qnum,
+                         __u16 cw_min, __u16 cw_max,
+                         __u8 aifs, __u16 txop)
 {
+       struct mwl8k_priv *priv = hw->priv;
        struct mwl8k_cmd_set_edca_params *cmd;
        int rc;
 
@@ -2038,14 +2365,27 @@ mwl8k_set_edca_params(struct ieee80211_hw *hw, __u8 qnum,
        if (cmd == NULL)
                return -ENOMEM;
 
+       /*
+        * Queues 0 (BE) and 1 (BK) are swapped in hardware for
+        * this call.
+        */
+       qnum ^= !(qnum >> 1);
+
        cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_EDCA_PARAMS);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
        cmd->action = cpu_to_le16(MWL8K_SET_EDCA_ALL);
        cmd->txop = cpu_to_le16(txop);
-       cmd->log_cw_max = (u8)ilog2(cw_max + 1);
-       cmd->log_cw_min = (u8)ilog2(cw_min + 1);
-       cmd->aifs = aifs;
-       cmd->txq = qnum;
+       if (priv->ap_fw) {
+               cmd->ap.log_cw_max = cpu_to_le32(ilog2(cw_max + 1));
+               cmd->ap.log_cw_min = cpu_to_le32(ilog2(cw_min + 1));
+               cmd->ap.aifs = aifs;
+               cmd->ap.txq = qnum;
+       } else {
+               cmd->sta.log_cw_max = (u8)ilog2(cw_max + 1);
+               cmd->sta.log_cw_min = (u8)ilog2(cw_min + 1);
+               cmd->sta.aifs = aifs;
+               cmd->sta.txq = qnum;
+       }
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
@@ -2054,229 +2394,60 @@ mwl8k_set_edca_params(struct ieee80211_hw *hw, __u8 qnum,
 }
 
 /*
- * CMD_FINALIZE_JOIN.
- */
-
-/* FJ beacon buffer size is compiled into the firmware.  */
-#define MWL8K_FJ_BEACON_MAXLEN 128
-
-struct mwl8k_cmd_finalize_join {
-       struct mwl8k_cmd_pkt header;
-       __le32 sleep_interval;  /* Number of beacon periods to sleep */
-       __u8 beacon_data[MWL8K_FJ_BEACON_MAXLEN];
-} __attribute__((packed));
-
-static int mwl8k_finalize_join(struct ieee80211_hw *hw, void *frame,
-                               __u16 framelen, __u16 dtim)
-{
-       struct mwl8k_cmd_finalize_join *cmd;
-       struct ieee80211_mgmt *payload = frame;
-       u16 hdrlen;
-       u32 payload_len;
-       int rc;
-
-       if (frame == NULL)
-               return -EINVAL;
-
-       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
-       if (cmd == NULL)
-               return -ENOMEM;
-
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_FINALIZE_JOIN);
-       cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->sleep_interval = cpu_to_le32(dtim ? dtim : 1);
-
-       hdrlen = ieee80211_hdrlen(payload->frame_control);
-
-       payload_len = framelen > hdrlen ? framelen - hdrlen : 0;
-
-       /* XXX TBD Might just have to abort and return an error */
-       if (payload_len > MWL8K_FJ_BEACON_MAXLEN)
-               printk(KERN_ERR "%s(): WARNING: Incomplete beacon "
-                       "sent to firmware. Sz=%u MAX=%u\n", __func__,
-                       payload_len, MWL8K_FJ_BEACON_MAXLEN);
-
-       if (payload_len > MWL8K_FJ_BEACON_MAXLEN)
-               payload_len = MWL8K_FJ_BEACON_MAXLEN;
-
-       if (payload && payload_len)
-               memcpy(cmd->beacon_data, &payload->u.beacon, payload_len);
-
-       rc = mwl8k_post_cmd(hw, &cmd->header);
-       kfree(cmd);
-       return rc;
-}
-
-/*
- * CMD_UPDATE_STADB.
+ * CMD_SET_WMM_MODE.
  */
-struct mwl8k_cmd_update_sta_db {
+struct mwl8k_cmd_set_wmm_mode {
        struct mwl8k_cmd_pkt header;
-
-       /* See STADB_ACTION_TYPE */
-       __le32  action;
-
-       /* Peer MAC address */
-       __u8    peer_addr[ETH_ALEN];
-
-       __le32  reserved;
-
-       /* Peer info - valid during add/update.  */
-       struct peer_capability_info     peer_info;
-} __attribute__((packed));
-
-static int mwl8k_cmd_update_sta_db(struct ieee80211_hw *hw,
-               struct ieee80211_vif *vif, __u32 action)
-{
-       struct mwl8k_vif *mv_vif = MWL8K_VIF(vif);
-       struct ieee80211_bss_conf *info = &mv_vif->bss_info;
-       struct mwl8k_cmd_update_sta_db *cmd;
-       struct peer_capability_info *peer_info;
-       struct ieee80211_rate *bitrates = mv_vif->legacy_rates;
-       int rc;
-       __u8 count, *rates;
-
-       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
-       if (cmd == NULL)
-               return -ENOMEM;
-
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_UPDATE_STADB);
-       cmd->header.length = cpu_to_le16(sizeof(*cmd));
-
-       cmd->action = cpu_to_le32(action);
-       peer_info = &cmd->peer_info;
-       memcpy(cmd->peer_addr, mv_vif->bssid, ETH_ALEN);
-
-       switch (action) {
-       case MWL8K_STA_DB_ADD_ENTRY:
-       case MWL8K_STA_DB_MODIFY_ENTRY:
-               /* Build peer_info block */
-               peer_info->peer_type = MWL8K_PEER_TYPE_ACCESSPOINT;
-               peer_info->basic_caps = cpu_to_le16(info->assoc_capability);
-               peer_info->interop = 1;
-               peer_info->amsdu_enabled = 0;
-
-               rates = peer_info->legacy_rates;
-               for (count = 0; count < mv_vif->legacy_nrates; count++)
-                       rates[count] = bitrates[count].hw_value;
-
-               rc = mwl8k_post_cmd(hw, &cmd->header);
-               if (rc == 0)
-                       mv_vif->peer_id = peer_info->station_id;
-
-               break;
-
-       case MWL8K_STA_DB_DEL_ENTRY:
-       case MWL8K_STA_DB_FLUSH:
-       default:
-               rc = mwl8k_post_cmd(hw, &cmd->header);
-               if (rc == 0)
-                       mv_vif->peer_id = 0;
-               break;
-       }
-       kfree(cmd);
-
-       return rc;
-}
-
-/*
- * CMD_SET_AID.
- */
-#define MWL8K_RATE_INDEX_MAX_ARRAY                     14
-
-#define MWL8K_FRAME_PROT_DISABLED                      0x00
-#define MWL8K_FRAME_PROT_11G                           0x07
-#define MWL8K_FRAME_PROT_11N_HT_40MHZ_ONLY             0x02
-#define MWL8K_FRAME_PROT_11N_HT_ALL                    0x06
-
-struct mwl8k_cmd_update_set_aid {
-       struct  mwl8k_cmd_pkt header;
-       __le16  aid;
-
-        /* AP's MAC address (BSSID) */
-       __u8    bssid[ETH_ALEN];
-       __le16  protection_mode;
-       __u8    supp_rates[MWL8K_RATE_INDEX_MAX_ARRAY];
+       __le16 action;
 } __attribute__((packed));
 
-static int mwl8k_cmd_set_aid(struct ieee80211_hw *hw,
-                                       struct ieee80211_vif *vif)
+static int mwl8k_cmd_set_wmm_mode(struct ieee80211_hw *hw, bool enable)
 {
-       struct mwl8k_vif *mv_vif = MWL8K_VIF(vif);
-       struct ieee80211_bss_conf *info = &mv_vif->bss_info;
-       struct mwl8k_cmd_update_set_aid *cmd;
-       struct ieee80211_rate *bitrates = mv_vif->legacy_rates;
-       int count;
-       u16 prot_mode;
+       struct mwl8k_priv *priv = hw->priv;
+       struct mwl8k_cmd_set_wmm_mode *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_AID);
-       cmd->header.length = cpu_to_le16(sizeof(*cmd));
-       cmd->aid = cpu_to_le16(info->aid);
-
-       memcpy(cmd->bssid, mv_vif->bssid, ETH_ALEN);
-
-       if (info->use_cts_prot) {
-               prot_mode = MWL8K_FRAME_PROT_11G;
-       } else {
-               switch (info->ht_operation_mode &
-                       IEEE80211_HT_OP_MODE_PROTECTION) {
-               case IEEE80211_HT_OP_MODE_PROTECTION_20MHZ:
-                       prot_mode = MWL8K_FRAME_PROT_11N_HT_40MHZ_ONLY;
-                       break;
-               case IEEE80211_HT_OP_MODE_PROTECTION_NONHT_MIXED:
-                       prot_mode = MWL8K_FRAME_PROT_11N_HT_ALL;
-                       break;
-               default:
-                       prot_mode = MWL8K_FRAME_PROT_DISABLED;
-                       break;
-               }
-       }
-       cmd->protection_mode = cpu_to_le16(prot_mode);
-
-       for (count = 0; count < mv_vif->legacy_nrates; count++)
-               cmd->supp_rates[count] = bitrates[count].hw_value;
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_WMM_MODE);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+       cmd->action = cpu_to_le16(!!enable);
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
 
+       if (!rc)
+               priv->wmm_enabled = enable;
+
        return rc;
 }
 
 /*
- * CMD_SET_RATE.
+ * CMD_MIMO_CONFIG.
  */
-struct mwl8k_cmd_update_rateset {
-       struct  mwl8k_cmd_pkt header;
-       __u8    legacy_rates[MWL8K_RATE_INDEX_MAX_ARRAY];
-
-       /* Bitmap for supported MCS codes.  */
-       __u8    mcs_set[MWL8K_IEEE_LEGACY_DATA_RATES];
-       __u8    reserved[MWL8K_IEEE_LEGACY_DATA_RATES];
+struct mwl8k_cmd_mimo_config {
+       struct mwl8k_cmd_pkt header;
+       __le32 action;
+       __u8 rx_antenna_map;
+       __u8 tx_antenna_map;
 } __attribute__((packed));
 
-static int mwl8k_update_rateset(struct ieee80211_hw *hw,
-               struct ieee80211_vif *vif)
+static int mwl8k_cmd_mimo_config(struct ieee80211_hw *hw, __u8 rx, __u8 tx)
 {
-       struct mwl8k_vif *mv_vif = MWL8K_VIF(vif);
-       struct mwl8k_cmd_update_rateset *cmd;
-       struct ieee80211_rate *bitrates = mv_vif->legacy_rates;
-       int count;
+       struct mwl8k_cmd_mimo_config *cmd;
        int rc;
 
        cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
        if (cmd == NULL)
                return -ENOMEM;
 
-       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_RATE);
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_MIMO_CONFIG);
        cmd->header.length = cpu_to_le16(sizeof(*cmd));
-
-       for (count = 0; count < mv_vif->legacy_nrates; count++)
-               cmd->legacy_rates[count] = bitrates[count].hw_value;
+       cmd->action = cpu_to_le32((u32)MWL8K_CMD_SET);
+       cmd->rx_antenna_map = rx;
+       cmd->tx_antenna_map = tx;
 
        rc = mwl8k_post_cmd(hw, &cmd->header);
        kfree(cmd);
@@ -2341,9 +2512,10 @@ static int mwl8k_cmd_use_fixed_rate(struct ieee80211_hw *hw,
        cmd->rate_type = cpu_to_le32(rate_type);
 
        if (rate_table != NULL) {
-               /* Copy over each field manually so
-               * that bitflipping can be done
-               */
+               /*
+                * Copy over each field manually so that endian
+                * conversion can be done.
+                */
                cmd->rate_table.allow_rate_drop =
                                cpu_to_le32(rate_table->allow_rate_drop);
                cmd->rate_table.num_rates =
@@ -2368,6 +2540,169 @@ static int mwl8k_cmd_use_fixed_rate(struct ieee80211_hw *hw,
        return rc;
 }
 
+/*
+ * CMD_ENABLE_SNIFFER.
+ */
+struct mwl8k_cmd_enable_sniffer {
+       struct mwl8k_cmd_pkt header;
+       __le32 action;
+} __attribute__((packed));
+
+static int mwl8k_cmd_enable_sniffer(struct ieee80211_hw *hw, bool enable)
+{
+       struct mwl8k_cmd_enable_sniffer *cmd;
+       int rc;
+
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_ENABLE_SNIFFER);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+       cmd->action = cpu_to_le32(!!enable);
+
+       rc = mwl8k_post_cmd(hw, &cmd->header);
+       kfree(cmd);
+
+       return rc;
+}
+
+/*
+ * CMD_SET_MAC_ADDR.
+ */
+struct mwl8k_cmd_set_mac_addr {
+       struct mwl8k_cmd_pkt header;
+       union {
+               struct {
+                       __le16 mac_type;
+                       __u8 mac_addr[ETH_ALEN];
+               } mbss;
+               __u8 mac_addr[ETH_ALEN];
+       };
+} __attribute__((packed));
+
+static int mwl8k_cmd_set_mac_addr(struct ieee80211_hw *hw, u8 *mac)
+{
+       struct mwl8k_priv *priv = hw->priv;
+       struct mwl8k_cmd_set_mac_addr *cmd;
+       int rc;
+
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_MAC_ADDR);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+       if (priv->ap_fw) {
+               cmd->mbss.mac_type = 0;
+               memcpy(cmd->mbss.mac_addr, mac, ETH_ALEN);
+       } else {
+               memcpy(cmd->mac_addr, mac, ETH_ALEN);
+       }
+
+       rc = mwl8k_post_cmd(hw, &cmd->header);
+       kfree(cmd);
+
+       return rc;
+}
+
+/*
+ * CMD_SET_RATEADAPT_MODE.
+ */
+struct mwl8k_cmd_set_rate_adapt_mode {
+       struct mwl8k_cmd_pkt header;
+       __le16 action;
+       __le16 mode;
+} __attribute__((packed));
+
+static int mwl8k_cmd_set_rateadapt_mode(struct ieee80211_hw *hw, __u16 mode)
+{
+       struct mwl8k_cmd_set_rate_adapt_mode *cmd;
+       int rc;
+
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_SET_RATEADAPT_MODE);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+       cmd->action = cpu_to_le16(MWL8K_CMD_SET);
+       cmd->mode = cpu_to_le16(mode);
+
+       rc = mwl8k_post_cmd(hw, &cmd->header);
+       kfree(cmd);
+
+       return rc;
+}
+
+/*
+ * CMD_UPDATE_STADB.
+ */
+struct mwl8k_cmd_update_stadb {
+       struct mwl8k_cmd_pkt header;
+
+       /* See STADB_ACTION_TYPE */
+       __le32  action;
+
+       /* Peer MAC address */
+       __u8    peer_addr[ETH_ALEN];
+
+       __le32  reserved;
+
+       /* Peer info - valid during add/update.  */
+       struct peer_capability_info     peer_info;
+} __attribute__((packed));
+
+static int mwl8k_cmd_update_stadb(struct ieee80211_hw *hw,
+               struct ieee80211_vif *vif, __u32 action)
+{
+       struct mwl8k_vif *mv_vif = MWL8K_VIF(vif);
+       struct ieee80211_bss_conf *info = &mv_vif->bss_info;
+       struct mwl8k_cmd_update_stadb *cmd;
+       struct peer_capability_info *peer_info;
+       int rc;
+
+       cmd = kzalloc(sizeof(*cmd), GFP_KERNEL);
+       if (cmd == NULL)
+               return -ENOMEM;
+
+       cmd->header.code = cpu_to_le16(MWL8K_CMD_UPDATE_STADB);
+       cmd->header.length = cpu_to_le16(sizeof(*cmd));
+
+       cmd->action = cpu_to_le32(action);
+       peer_info = &cmd->peer_info;
+       memcpy(cmd->peer_addr, mv_vif->bssid, ETH_ALEN);
+
+       switch (action) {
+       case MWL8K_STA_DB_ADD_ENTRY:
+       case MWL8K_STA_DB_MODIFY_ENTRY:
+               /* Build peer_info block */
+               peer_info->peer_type = MWL8K_PEER_TYPE_ACCESSPOINT;
+               peer_info->basic_caps = cpu_to_le16(info->assoc_capability);
+               memcpy(peer_info->legacy_rates, mwl8k_rateids,
+                      sizeof(mwl8k_rateids));
+               peer_info->interop = 1;
+               peer_info->amsdu_enabled = 0;
+
+               rc = mwl8k_post_cmd(hw, &cmd->header);
+               if (rc == 0)
+                       mv_vif->peer_id = peer_info->station_id;
+
+               break;
+
+       case MWL8K_STA_DB_DEL_ENTRY:
+       case MWL8K_STA_DB_FLUSH:
+       default:
+               rc = mwl8k_post_cmd(hw, &cmd->header);
+               if (rc == 0)
+                       mv_vif->peer_id = 0;
+               break;
+       }
+       kfree(cmd);
+
+       return rc;
+}
+
 
 /*
  * Interrupt handling.
@@ -2399,7 +2734,7 @@ static irqreturn_t mwl8k_interrupt(int irq, void *dev_id)
 
        if (status & MWL8K_A2H_INT_QUEUE_EMPTY) {
                if (!mutex_is_locked(&priv->fw_mutex) &&
-                   priv->radio_on && mwl8k_txq_busy(priv))
+                   priv->radio_on && priv->pending_tx_pkts)
                        mwl8k_tx_start(priv);
        }
 
@@ -2418,7 +2753,7 @@ static int mwl8k_tx(struct ieee80211_hw *hw, struct sk_buff *skb)
 
        if (priv->current_channel == NULL) {
                printk(KERN_DEBUG "%s: dropped TX frame since radio "
-                      "disabled\n", priv->name);
+                      "disabled\n", wiphy_name(hw->wiphy));
                dev_kfree_skb(skb);
                return NETDEV_TX_OK;
        }
@@ -2433,11 +2768,11 @@ static int mwl8k_start(struct ieee80211_hw *hw)
        struct mwl8k_priv *priv = hw->priv;
        int rc;
 
-       rc = request_irq(priv->pdev->irq, &mwl8k_interrupt,
+       rc = request_irq(priv->pdev->irq, mwl8k_interrupt,
                         IRQF_SHARED, MWL8K_NAME, hw);
        if (rc) {
                printk(KERN_ERR "%s: failed to register IRQ handler\n",
-                      priv->name);
+                      wiphy_name(hw->wiphy));
                return -EIO;
        }
 
@@ -2449,23 +2784,25 @@ static int mwl8k_start(struct ieee80211_hw *hw)
 
        rc = mwl8k_fw_lock(hw);
        if (!rc) {
-               rc = mwl8k_cmd_802_11_radio_enable(hw);
+               rc = mwl8k_cmd_radio_enable(hw);
 
-               if (!rc)
-                       rc = mwl8k_cmd_set_pre_scan(hw);
+               if (!priv->ap_fw) {
+                       if (!rc)
+                               rc = mwl8k_cmd_enable_sniffer(hw, 0);
 
-               if (!rc)
-                       rc = mwl8k_cmd_set_post_scan(hw,
-                                       "\x00\x00\x00\x00\x00\x00");
+                       if (!rc)
+                               rc = mwl8k_cmd_set_pre_scan(hw);
 
-               if (!rc)
-                       rc = mwl8k_cmd_setrateadaptmode(hw, 0);
+                       if (!rc)
+                               rc = mwl8k_cmd_set_post_scan(hw,
+                                               "\x00\x00\x00\x00\x00\x00");
+               }
 
                if (!rc)
-                       rc = mwl8k_set_wmm(hw, 0);
+                       rc = mwl8k_cmd_set_rateadapt_mode(hw, 0);
 
                if (!rc)
-                       rc = mwl8k_enable_sniffer(hw, 0);
+                       rc = mwl8k_cmd_set_wmm_mode(hw, 0);
 
                mwl8k_fw_unlock(hw);
        }
@@ -2484,7 +2821,7 @@ static void mwl8k_stop(struct ieee80211_hw *hw)
        struct mwl8k_priv *priv = hw->priv;
        int i;
 
-       mwl8k_cmd_802_11_radio_disable(hw);
+       mwl8k_cmd_radio_disable(hw);
 
        ieee80211_stop_queues(hw);
 
@@ -2500,9 +2837,6 @@ static void mwl8k_stop(struct ieee80211_hw *hw)
        /* Stop tx reclaim tasklet */
        tasklet_disable(&priv->tx_reclaim_task);
 
-       /* Stop config thread */
-       flush_workqueue(priv->config_wq);
-
        /* Return all skbs to mac80211 */
        for (i = 0; i < MWL8K_TX_QUEUES; i++)
                mwl8k_txq_reclaim(hw, i, 1);
@@ -2526,21 +2860,29 @@ static int mwl8k_add_interface(struct ieee80211_hw *hw,
        if (conf->type != NL80211_IFTYPE_STATION)
                return -EINVAL;
 
+       /*
+        * Reject interface creation if sniffer mode is active, as
+        * STA operation is mutually exclusive with hardware sniffer
+        * mode.
+        */
+       if (priv->sniffer_enabled) {
+               printk(KERN_INFO "%s: unable to create STA "
+                      "interface due to sniffer mode being enabled\n",
+                      wiphy_name(hw->wiphy));
+               return -EINVAL;
+       }
+
        /* Clean out driver private area */
        mwl8k_vif = MWL8K_VIF(conf->vif);
        memset(mwl8k_vif, 0, sizeof(*mwl8k_vif));
 
-       /* Save the mac address */
+       /* Set and save the mac address */
+       mwl8k_cmd_set_mac_addr(hw, conf->mac_addr);
        memcpy(mwl8k_vif->mac_addr, conf->mac_addr, ETH_ALEN);
 
        /* Back pointer to parent config block */
        mwl8k_vif->priv = priv;
 
-       /* Setup initial PHY parameters */
-       memcpy(mwl8k_vif->legacy_rates,
-               priv->rates, sizeof(mwl8k_vif->legacy_rates));
-       mwl8k_vif->legacy_nrates = ARRAY_SIZE(priv->rates);
-
        /* Set Initial sequence number to zero */
        mwl8k_vif->seqno = 0;
 
@@ -2558,6 +2900,8 @@ static void mwl8k_remove_interface(struct ieee80211_hw *hw,
        if (priv->vif == NULL)
                return;
 
+       mwl8k_cmd_set_mac_addr(hw, "\x00\x00\x00\x00\x00\x00");
+
        priv->vif = NULL;
 }
 
@@ -2568,7 +2912,7 @@ static int mwl8k_config(struct ieee80211_hw *hw, u32 changed)
        int rc;
 
        if (conf->flags & IEEE80211_CONF_IDLE) {
-               mwl8k_cmd_802_11_radio_disable(hw);
+               mwl8k_cmd_radio_disable(hw);
                priv->current_channel = NULL;
                return 0;
        }
@@ -2577,7 +2921,7 @@ static int mwl8k_config(struct ieee80211_hw *hw, u32 changed)
        if (rc)
                return rc;
 
-       rc = mwl8k_cmd_802_11_radio_enable(hw);
+       rc = mwl8k_cmd_radio_enable(hw);
        if (rc)
                goto out;
 
@@ -2589,12 +2933,17 @@ static int mwl8k_config(struct ieee80211_hw *hw, u32 changed)
 
        if (conf->power_level > 18)
                conf->power_level = 18;
-       rc = mwl8k_cmd_802_11_rf_tx_power(hw, conf->power_level);
+       rc = mwl8k_cmd_rf_tx_power(hw, conf->power_level);
        if (rc)
                goto out;
 
-       if (mwl8k_cmd_mimo_config(hw, 0x7, 0x7))
-               rc = -EINVAL;
+       if (priv->ap_fw) {
+               rc = mwl8k_cmd_rf_antenna(hw, MWL8K_RF_ANTENNA_RX, 0x7);
+               if (!rc)
+                       rc = mwl8k_cmd_rf_antenna(hw, MWL8K_RF_ANTENNA_TX, 0x7);
+       } else {
+               rc = mwl8k_cmd_mimo_config(hw, 0x7, 0x7);
+       }
 
 out:
        mwl8k_fw_unlock(hw);
@@ -2611,9 +2960,6 @@ static void mwl8k_bss_info_changed(struct ieee80211_hw *hw,
        struct mwl8k_vif *mwl8k_vif = MWL8K_VIF(vif);
        int rc;
 
-       if (changed & BSS_CHANGED_BSSID)
-               memcpy(mwl8k_vif->bssid, info->bssid, ETH_ALEN);
-
        if ((changed & BSS_CHANGED_ASSOC) == 0)
                return;
 
@@ -2627,8 +2973,10 @@ static void mwl8k_bss_info_changed(struct ieee80211_hw *hw,
                memcpy(&mwl8k_vif->bss_info, info,
                        sizeof(struct ieee80211_bss_conf));
 
+               memcpy(mwl8k_vif->bssid, info->bssid, ETH_ALEN);
+
                /* Install rates */
-               rc = mwl8k_update_rateset(hw, vif);
+               rc = mwl8k_cmd_set_rate(hw, vif);
                if (rc)
                        goto out;
 
@@ -2649,7 +2997,7 @@ static void mwl8k_bss_info_changed(struct ieee80211_hw *hw,
                        goto out;
 
                /* Update peer rate info */
-               rc = mwl8k_cmd_update_sta_db(hw, vif,
+               rc = mwl8k_cmd_update_stadb(hw, vif,
                                MWL8K_STA_DB_MODIFY_ENTRY);
                if (rc)
                        goto out;
@@ -2666,7 +3014,7 @@ static void mwl8k_bss_info_changed(struct ieee80211_hw *hw,
                memcpy(priv->capture_bssid, mwl8k_vif->bssid, ETH_ALEN);
                priv->capture_beacon = true;
        } else {
-               rc = mwl8k_cmd_update_sta_db(hw, vif, MWL8K_STA_DB_DEL_ENTRY);
+               rc = mwl8k_cmd_update_stadb(hw, vif, MWL8K_STA_DB_DEL_ENTRY);
                memset(&mwl8k_vif->bss_info, 0,
                        sizeof(struct ieee80211_bss_conf));
                memset(mwl8k_vif->bssid, 0, ETH_ALEN);
@@ -2681,32 +3029,108 @@ static u64 mwl8k_prepare_multicast(struct ieee80211_hw *hw,
 {
        struct mwl8k_cmd_pkt *cmd;
 
-       cmd = __mwl8k_cmd_mac_multicast_adr(hw, mc_count, mclist);
+       /*
+        * Synthesize and return a command packet that programs the
+        * hardware multicast address filter.  At this point we don't
+        * know whether FIF_ALLMULTI is being requested, but if it is,
+        * we'll end up throwing this packet away and creating a new
+        * one in mwl8k_configure_filter().
+        */
+       cmd = __mwl8k_cmd_mac_multicast_adr(hw, 0, mc_count, mclist);
 
        return (unsigned long)cmd;
 }
 
+static int
+mwl8k_configure_filter_sniffer(struct ieee80211_hw *hw,
+                              unsigned int changed_flags,
+                              unsigned int *total_flags)
+{
+       struct mwl8k_priv *priv = hw->priv;
+
+       /*
+        * Hardware sniffer mode is mutually exclusive with STA
+        * operation, so refuse to enable sniffer mode if a STA
+        * interface is active.
+        */
+       if (priv->vif != NULL) {
+               if (net_ratelimit())
+                       printk(KERN_INFO "%s: not enabling sniffer "
+                              "mode because STA interface is active\n",
+                              wiphy_name(hw->wiphy));
+               return 0;
+       }
+
+       if (!priv->sniffer_enabled) {
+               if (mwl8k_cmd_enable_sniffer(hw, 1))
+                       return 0;
+               priv->sniffer_enabled = true;
+       }
+
+       *total_flags &= FIF_PROMISC_IN_BSS | FIF_ALLMULTI |
+                       FIF_BCN_PRBRESP_PROMISC | FIF_CONTROL |
+                       FIF_OTHER_BSS;
+
+       return 1;
+}
+
 static void mwl8k_configure_filter(struct ieee80211_hw *hw,
                                   unsigned int changed_flags,
                                   unsigned int *total_flags,
                                   u64 multicast)
 {
        struct mwl8k_priv *priv = hw->priv;
-       struct mwl8k_cmd_pkt *multicast_adr_cmd;
+       struct mwl8k_cmd_pkt *cmd = (void *)(unsigned long)multicast;
+
+       /*
+        * AP firmware doesn't allow fine-grained control over
+        * the receive filter.
+        */
+       if (priv->ap_fw) {
+               *total_flags &= FIF_ALLMULTI | FIF_BCN_PRBRESP_PROMISC;
+               kfree(cmd);
+               return;
+       }
+
+       /*
+        * Enable hardware sniffer mode if FIF_CONTROL or
+        * FIF_OTHER_BSS is requested.
+        */
+       if (*total_flags & (FIF_CONTROL | FIF_OTHER_BSS) &&
+           mwl8k_configure_filter_sniffer(hw, changed_flags, total_flags)) {
+               kfree(cmd);
+               return;
+       }
 
        /* Clear unsupported feature flags */
-       *total_flags &= FIF_BCN_PRBRESP_PROMISC;
+       *total_flags &= FIF_ALLMULTI | FIF_BCN_PRBRESP_PROMISC;
 
        if (mwl8k_fw_lock(hw))
                return;
 
+       if (priv->sniffer_enabled) {
+               mwl8k_cmd_enable_sniffer(hw, 0);
+               priv->sniffer_enabled = false;
+       }
+
        if (changed_flags & FIF_BCN_PRBRESP_PROMISC) {
-               if (*total_flags & FIF_BCN_PRBRESP_PROMISC)
+               if (*total_flags & FIF_BCN_PRBRESP_PROMISC) {
+                       /*
+                        * Disable the BSS filter.
+                        */
                        mwl8k_cmd_set_pre_scan(hw);
-               else {
+               else {
                        u8 *bssid;
 
-                       bssid = "\x00\x00\x00\x00\x00\x00";
+                       /*
+                        * Enable the BSS filter.
+                        *
+                        * If there is an active STA interface, use that
+                        * interface's BSSID, otherwise use a dummy one
+                        * (where the OUI part needs to be nonzero for
+                        * the BSSID to be accepted by POST_SCAN).
+                        */
+                       bssid = "\x01\x00\x00\x00\x00\x00";
                        if (priv->vif != NULL)
                                bssid = MWL8K_VIF(priv->vif)->bssid;
 
@@ -2714,10 +3138,20 @@ static void mwl8k_configure_filter(struct ieee80211_hw *hw,
                }
        }
 
-       multicast_adr_cmd = (void *)(unsigned long)multicast;
-       if (multicast_adr_cmd != NULL) {
-               mwl8k_post_cmd(hw, multicast_adr_cmd);
-               kfree(multicast_adr_cmd);
+       /*
+        * If FIF_ALLMULTI is being requested, throw away the command
+        * packet that ->prepare_multicast() built and replace it with
+        * a command packet that enables reception of all multicast
+        * packets.
+        */
+       if (*total_flags & FIF_ALLMULTI) {
+               kfree(cmd);
+               cmd = __mwl8k_cmd_mac_multicast_adr(hw, 1, 0, NULL);
+       }
+
+       if (cmd != NULL) {
+               mwl8k_post_cmd(hw, cmd);
+               kfree(cmd);
        }
 
        mwl8k_fw_unlock(hw);
@@ -2725,7 +3159,7 @@ static void mwl8k_configure_filter(struct ieee80211_hw *hw,
 
 static int mwl8k_set_rts_threshold(struct ieee80211_hw *hw, u32 value)
 {
-       return mwl8k_rts_threshold(hw, MWL8K_CMD_SET, value);
+       return mwl8k_cmd_set_rts_threshold(hw, MWL8K_CMD_SET, value);
 }
 
 static int mwl8k_conf_tx(struct ieee80211_hw *hw, u16 queue,
@@ -2737,14 +3171,14 @@ static int mwl8k_conf_tx(struct ieee80211_hw *hw, u16 queue,
        rc = mwl8k_fw_lock(hw);
        if (!rc) {
                if (!priv->wmm_enabled)
-                       rc = mwl8k_set_wmm(hw, 1);
+                       rc = mwl8k_cmd_set_wmm_mode(hw, 1);
 
                if (!rc)
-                       rc = mwl8k_set_edca_params(hw, queue,
-                                                  params->cw_min,
-                                                  params->cw_max,
-                                                  params->aifs,
-                                                  params->txop);
+                       rc = mwl8k_cmd_set_edca_params(hw, queue,
+                                                      params->cw_min,
+                                                      params->cw_max,
+                                                      params->aifs,
+                                                      params->txop);
 
                mwl8k_fw_unlock(hw);
        }
@@ -2762,7 +3196,7 @@ static int mwl8k_get_tx_stats(struct ieee80211_hw *hw,
        spin_lock_bh(&priv->tx_lock);
        for (index = 0; index < MWL8K_TX_QUEUES; index++) {
                txq = priv->txq + index;
-               memcpy(&stats[index], &txq->tx_stats,
+               memcpy(&stats[index], &txq->stats,
                        sizeof(struct ieee80211_tx_queue_stats));
        }
        spin_unlock_bh(&priv->tx_lock);
@@ -2773,7 +3207,7 @@ static int mwl8k_get_tx_stats(struct ieee80211_hw *hw,
 static int mwl8k_get_stats(struct ieee80211_hw *hw,
                           struct ieee80211_low_level_stats *stats)
 {
-       return mwl8k_cmd_802_11_get_stat(hw, stats);
+       return mwl8k_cmd_get_stat(hw, stats);
 }
 
 static const struct ieee80211_ops mwl8k_ops = {
@@ -2802,7 +3236,7 @@ static void mwl8k_tx_reclaim_handler(unsigned long data)
        for (i = 0; i < MWL8K_TX_QUEUES; i++)
                mwl8k_txq_reclaim(hw, i, 0);
 
-       if (priv->tx_wait != NULL && mwl8k_txq_busy(priv) == 0) {
+       if (priv->tx_wait != NULL && !priv->pending_tx_pkts) {
                complete(priv->tx_wait);
                priv->tx_wait = NULL;
        }
@@ -2816,12 +3250,42 @@ static void mwl8k_finalize_join_worker(struct work_struct *work)
        struct sk_buff *skb = priv->beacon_skb;
        u8 dtim = MWL8K_VIF(priv->vif)->bss_info.dtim_period;
 
-       mwl8k_finalize_join(priv->hw, skb->data, skb->len, dtim);
+       mwl8k_cmd_finalize_join(priv->hw, skb->data, skb->len, dtim);
        dev_kfree_skb(skb);
 
        priv->beacon_skb = NULL;
 }
 
+enum {
+       MWL8687 = 0,
+       MWL8366,
+};
+
+static struct mwl8k_device_info mwl8k_info_tbl[] __devinitdata = {
+       [MWL8687] = {
+               .part_name      = "88w8687",
+               .helper_image   = "mwl8k/helper_8687.fw",
+               .fw_image       = "mwl8k/fmimage_8687.fw",
+               .rxd_ops        = &rxd_8687_ops,
+               .modes          = BIT(NL80211_IFTYPE_STATION),
+       },
+       [MWL8366] = {
+               .part_name      = "88w8366",
+               .helper_image   = "mwl8k/helper_8366.fw",
+               .fw_image       = "mwl8k/fmimage_8366.fw",
+               .rxd_ops        = &rxd_8366_ops,
+               .modes          = 0,
+       },
+};
+
+static DEFINE_PCI_DEVICE_TABLE(mwl8k_pci_id_table) = {
+       { PCI_VDEVICE(MARVELL, 0x2a2b), .driver_data = MWL8687, },
+       { PCI_VDEVICE(MARVELL, 0x2a30), .driver_data = MWL8687, },
+       { PCI_VDEVICE(MARVELL, 0x2a40), .driver_data = MWL8366, },
+       { },
+};
+MODULE_DEVICE_TABLE(pci, mwl8k_pci_id_table);
+
 static int __devinit mwl8k_probe(struct pci_dev *pdev,
                                 const struct pci_device_id *id)
 {
@@ -2847,7 +3311,7 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
        if (rc) {
                printk(KERN_ERR "%s: Cannot obtain PCI resources\n",
                       MWL8K_NAME);
-               return rc;
+               goto err_disable_device;
        }
 
        pci_set_master(pdev);
@@ -2862,17 +3326,34 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
        priv = hw->priv;
        priv->hw = hw;
        priv->pdev = pdev;
+       priv->device_info = &mwl8k_info_tbl[id->driver_data];
+       priv->rxd_ops = priv->device_info->rxd_ops;
+       priv->sniffer_enabled = false;
        priv->wmm_enabled = false;
        priv->pending_tx_pkts = 0;
-       strncpy(priv->name, MWL8K_NAME, sizeof(priv->name));
 
        SET_IEEE80211_DEV(hw, &pdev->dev);
        pci_set_drvdata(pdev, hw);
 
+       priv->sram = pci_iomap(pdev, 0, 0x10000);
+       if (priv->sram == NULL) {
+               printk(KERN_ERR "%s: Cannot map device SRAM\n",
+                      wiphy_name(hw->wiphy));
+               goto err_iounmap;
+       }
+
+       /*
+        * If BAR0 is a 32 bit BAR, the register BAR will be BAR1.
+        * If BAR0 is a 64 bit BAR, the register BAR will be BAR2.
+        */
        priv->regs = pci_iomap(pdev, 1, 0x10000);
        if (priv->regs == NULL) {
-               printk(KERN_ERR "%s: Cannot map device memory\n", priv->name);
-               goto err_iounmap;
+               priv->regs = pci_iomap(pdev, 2, 0x10000);
+               if (priv->regs == NULL) {
+                       printk(KERN_ERR "%s: Cannot map device registers\n",
+                              wiphy_name(hw->wiphy));
+                       goto err_iounmap;
+               }
        }
 
        memcpy(priv->channels, mwl8k_channels, sizeof(mwl8k_channels));
@@ -2897,7 +3378,7 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
 
        hw->queues = MWL8K_TX_QUEUES;
 
-       hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION);
+       hw->wiphy->interface_modes = priv->device_info->modes;
 
        /* Set rssi and noise values to dBm */
        hw->flags |= IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_NOISE_DBM;
@@ -2916,11 +3397,6 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
                        mwl8k_tx_reclaim_handler, (unsigned long)hw);
        tasklet_disable(&priv->tx_reclaim_task);
 
-       /* Config workthread */
-       priv->config_wq = create_singlethread_workqueue("mwl8k_config");
-       if (priv->config_wq == NULL)
-               goto err_iounmap;
-
        /* Power management cookie */
        priv->cookie = pci_alloc_consistent(priv->pdev, 4, &priv->cookie_dma);
        if (priv->cookie == NULL)
@@ -2934,11 +3410,12 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
        mutex_init(&priv->fw_mutex);
        priv->fw_mutex_owner = NULL;
        priv->fw_mutex_depth = 0;
-       priv->tx_wait = NULL;
        priv->hostcmd_wait = NULL;
 
        spin_lock_init(&priv->tx_lock);
 
+       priv->tx_wait = NULL;
+
        for (i = 0; i < MWL8K_TX_QUEUES; i++) {
                rc = mwl8k_txq_init(hw, i);
                if (rc)
@@ -2950,11 +3427,11 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
        iowrite32(0, priv->regs + MWL8K_HIU_A2H_INTERRUPT_CLEAR_SEL);
        iowrite32(0xffffffff, priv->regs + MWL8K_HIU_A2H_INTERRUPT_STATUS_MASK);
 
-       rc = request_irq(priv->pdev->irq, &mwl8k_interrupt,
+       rc = request_irq(priv->pdev->irq, mwl8k_interrupt,
                         IRQF_SHARED, MWL8K_NAME, hw);
        if (rc) {
                printk(KERN_ERR "%s: failed to register IRQ handler\n",
-                      priv->name);
+                      wiphy_name(hw->wiphy));
                goto err_free_queues;
        }
 
@@ -2962,16 +3439,18 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
        mwl8k_hw_reset(priv);
 
        /* Ask userland hotplug daemon for the device firmware */
-       rc = mwl8k_request_firmware(priv, (u32)id->driver_data);
+       rc = mwl8k_request_firmware(priv);
        if (rc) {
-               printk(KERN_ERR "%s: Firmware files not found\n", priv->name);
+               printk(KERN_ERR "%s: Firmware files not found\n",
+                      wiphy_name(hw->wiphy));
                goto err_free_irq;
        }
 
        /* Load firmware into hardware */
-       rc = mwl8k_load_firmware(priv);
+       rc = mwl8k_load_firmware(hw);
        if (rc) {
-               printk(KERN_ERR "%s: Cannot start firmware\n", priv->name);
+               printk(KERN_ERR "%s: Cannot start firmware\n",
+                      wiphy_name(hw->wiphy));
                goto err_stop_firmware;
        }
 
@@ -2986,16 +3465,31 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
        iowrite32(MWL8K_A2H_EVENTS, priv->regs + MWL8K_HIU_A2H_INTERRUPT_MASK);
 
        /* Get config data, mac addrs etc */
-       rc = mwl8k_cmd_get_hw_spec(hw);
+       if (priv->ap_fw) {
+               rc = mwl8k_cmd_get_hw_spec_ap(hw);
+               if (!rc)
+                       rc = mwl8k_cmd_set_hw_spec(hw);
+       } else {
+               rc = mwl8k_cmd_get_hw_spec_sta(hw);
+       }
        if (rc) {
-               printk(KERN_ERR "%s: Cannot initialise firmware\n", priv->name);
+               printk(KERN_ERR "%s: Cannot initialise firmware\n",
+                      wiphy_name(hw->wiphy));
                goto err_stop_firmware;
        }
 
        /* Turn radio off */
-       rc = mwl8k_cmd_802_11_radio_disable(hw);
+       rc = mwl8k_cmd_radio_disable(hw);
+       if (rc) {
+               printk(KERN_ERR "%s: Cannot disable\n", wiphy_name(hw->wiphy));
+               goto err_stop_firmware;
+       }
+
+       /* Clear MAC address */
+       rc = mwl8k_cmd_set_mac_addr(hw, "\x00\x00\x00\x00\x00\x00");
        if (rc) {
-               printk(KERN_ERR "%s: Cannot disable\n", priv->name);
+               printk(KERN_ERR "%s: Cannot clear MAC address\n",
+                      wiphy_name(hw->wiphy));
                goto err_stop_firmware;
        }
 
@@ -3005,13 +3499,15 @@ static int __devinit mwl8k_probe(struct pci_dev *pdev,
 
        rc = ieee80211_register_hw(hw);
        if (rc) {
-               printk(KERN_ERR "%s: Cannot register device\n", priv->name);
+               printk(KERN_ERR "%s: Cannot register device\n",
+                      wiphy_name(hw->wiphy));
                goto err_stop_firmware;
        }
 
-       printk(KERN_INFO "%s: 88w%u v%d, %pM, firmware version %u.%u.%u.%u\n",
-              wiphy_name(hw->wiphy), priv->part_num, priv->hw_rev,
-              hw->wiphy->perm_addr,
+       printk(KERN_INFO "%s: %s v%d, %pM, %s firmware %u.%u.%u.%u\n",
+              wiphy_name(hw->wiphy), priv->device_info->part_name,
+              priv->hw_rev, hw->wiphy->perm_addr,
+              priv->ap_fw ? "AP" : "STA",
               (priv->fw_rev >> 24) & 0xff, (priv->fw_rev >> 16) & 0xff,
               (priv->fw_rev >> 8) & 0xff, priv->fw_rev & 0xff);
 
@@ -3038,14 +3534,16 @@ err_iounmap:
        if (priv->regs != NULL)
                pci_iounmap(pdev, priv->regs);
 
-       if (priv->config_wq != NULL)
-               destroy_workqueue(priv->config_wq);
+       if (priv->sram != NULL)
+               pci_iounmap(pdev, priv->sram);
 
        pci_set_drvdata(pdev, NULL);
        ieee80211_free_hw(hw);
 
 err_free_reg:
        pci_release_regions(pdev);
+
+err_disable_device:
        pci_disable_device(pdev);
 
        return rc;
@@ -3073,9 +3571,6 @@ static void __devexit mwl8k_remove(struct pci_dev *pdev)
        /* Remove tx reclaim tasklet */
        tasklet_kill(&priv->tx_reclaim_task);
 
-       /* Stop config thread */
-       destroy_workqueue(priv->config_wq);
-
        /* Stop hardware */
        mwl8k_hw_reset(priv);
 
@@ -3088,10 +3583,10 @@ static void __devexit mwl8k_remove(struct pci_dev *pdev)
 
        mwl8k_rxq_deinit(hw, 0);
 
-       pci_free_consistent(priv->pdev, 4,
-                               priv->cookie, priv->cookie_dma);
+       pci_free_consistent(priv->pdev, 4, priv->cookie, priv->cookie_dma);
 
        pci_iounmap(pdev, priv->regs);
+       pci_iounmap(pdev, priv->sram);
        pci_set_drvdata(pdev, NULL);
        ieee80211_free_hw(hw);
        pci_release_regions(pdev);
@@ -3100,7 +3595,7 @@ static void __devexit mwl8k_remove(struct pci_dev *pdev)
 
 static struct pci_driver mwl8k_driver = {
        .name           = MWL8K_NAME,
-       .id_table       = mwl8k_table,
+       .id_table       = mwl8k_pci_id_table,
        .probe          = mwl8k_probe,
        .remove         = __devexit_p(mwl8k_remove),
        .shutdown       = __devexit_p(mwl8k_shutdown),
@@ -3118,3 +3613,8 @@ static void __exit mwl8k_exit(void)
 
 module_init(mwl8k_init);
 module_exit(mwl8k_exit);
+
+MODULE_DESCRIPTION(MWL8K_DESC);
+MODULE_VERSION(MWL8K_VERSION);
+MODULE_AUTHOR("Lennert Buytenhek <buytenh@marvell.com>");
+MODULE_LICENSE("GPL");