]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/platform/x86/asus-wmi.c
asus-wmi: swap input name and phys
[karo-tx-linux.git] / drivers / platform / x86 / asus-wmi.c
index 4c3f68a495d780fddd0ace985d0332d51ec852ef..832a3fd7c1c8538ef77fd26c628e0ddd2c1644d6 100644 (file)
@@ -39,6 +39,8 @@
 #include <linux/rfkill.h>
 #include <linux/pci.h>
 #include <linux/pci_hotplug.h>
+#include <linux/hwmon.h>
+#include <linux/hwmon-sysfs.h>
 #include <linux/debugfs.h>
 #include <linux/seq_file.h>
 #include <linux/platform_device.h>
@@ -66,19 +68,46 @@ MODULE_LICENSE("GPL");
 #define NOTIFY_BRNDOWN_MAX             0x2e
 
 /* WMI Methods */
-#define ASUS_WMI_METHODID_DSTS         0x53544344
-#define ASUS_WMI_METHODID_DEVS         0x53564544
-#define ASUS_WMI_METHODID_CFVS         0x53564643
+#define ASUS_WMI_METHODID_SPEC         0x43455053 /* BIOS SPECification */
+#define ASUS_WMI_METHODID_SFBD         0x44424653 /* Set First Boot Device */
+#define ASUS_WMI_METHODID_GLCD         0x44434C47 /* Get LCD status */
+#define ASUS_WMI_METHODID_GPID         0x44495047 /* Get Panel ID?? (Resol) */
+#define ASUS_WMI_METHODID_QMOD         0x444F4D51 /* Quiet MODe */
+#define ASUS_WMI_METHODID_SPLV         0x4C425053 /* Set Panel Light Value */
+#define ASUS_WMI_METHODID_SFUN         0x4E554653 /* FUNCtionalities */
+#define ASUS_WMI_METHODID_SDSP         0x50534453 /* Set DiSPlay output */
+#define ASUS_WMI_METHODID_GDSP         0x50534447 /* Get DiSPlay output */
+#define ASUS_WMI_METHODID_DEVP         0x50564544 /* DEVice Policy */
+#define ASUS_WMI_METHODID_OSVR         0x5256534F /* OS VeRsion */
+#define ASUS_WMI_METHODID_DSTS         0x53544344 /* Device STatuS */
+#define ASUS_WMI_METHODID_DSTS2                0x53545344 /* Device STatuS #2*/
+#define ASUS_WMI_METHODID_BSTS         0x53545342 /* Bios STatuS ? */
+#define ASUS_WMI_METHODID_DEVS         0x53564544 /* DEVice Set */
+#define ASUS_WMI_METHODID_CFVS         0x53564643 /* CPU Frequency Volt Set */
+#define ASUS_WMI_METHODID_KBFT         0x5446424B /* KeyBoard FilTer */
+#define ASUS_WMI_METHODID_INIT         0x54494E49 /* INITialize */
+#define ASUS_WMI_METHODID_HKEY         0x59454B48 /* Hot KEY ?? */
+
+#define ASUS_WMI_UNSUPPORTED_METHOD    0xFFFFFFFE
 
 /* Wireless */
+#define ASUS_WMI_DEVID_HW_SWITCH       0x00010001
+#define ASUS_WMI_DEVID_WIRELESS_LED    0x00010002
 #define ASUS_WMI_DEVID_WLAN            0x00010011
 #define ASUS_WMI_DEVID_BLUETOOTH       0x00010013
+#define ASUS_WMI_DEVID_GPS             0x00010015
 #define ASUS_WMI_DEVID_WIMAX           0x00010017
 #define ASUS_WMI_DEVID_WWAN3G          0x00010019
+#define ASUS_WMI_DEVID_UWB             0x00010021
+
+/* Leds */
+/* 0x000200XX and 0x000400XX */
 
 /* Backlight and Brightness */
 #define ASUS_WMI_DEVID_BACKLIGHT       0x00050011
 #define ASUS_WMI_DEVID_BRIGHTNESS      0x00050012
+#define ASUS_WMI_DEVID_KBD_BACKLIGHT   0x00050021
+#define ASUS_WMI_DEVID_LIGHT_SENSOR    0x00050022 /* ?? */
 
 /* Misc */
 #define ASUS_WMI_DEVID_CAMERA          0x00060013
@@ -90,33 +119,57 @@ MODULE_LICENSE("GPL");
 #define ASUS_WMI_DEVID_TOUCHPAD                0x00100011
 #define ASUS_WMI_DEVID_TOUCHPAD_LED    0x00100012
 
+/* Fan, Thermal */
+#define ASUS_WMI_DEVID_THERMAL_CTRL    0x00110011
+#define ASUS_WMI_DEVID_FAN_CTRL                0x00110012
+
+/* Power */
+#define ASUS_WMI_DEVID_PROCESSOR_STATE 0x00120012
+
 /* DSTS masks */
 #define ASUS_WMI_DSTS_STATUS_BIT       0x00000001
+#define ASUS_WMI_DSTS_UNKNOWN_BIT      0x00000002
 #define ASUS_WMI_DSTS_PRESENCE_BIT     0x00010000
+#define ASUS_WMI_DSTS_USER_BIT         0x00020000
+#define ASUS_WMI_DSTS_BIOS_BIT         0x00040000
 #define ASUS_WMI_DSTS_BRIGHTNESS_MASK  0x000000FF
 #define ASUS_WMI_DSTS_MAX_BRIGTH_MASK  0x0000FF00
 
 struct bios_args {
-       u32 dev_id;
-       u32 ctrl_param;
-};
+       u32 arg0;
+       u32 arg1;
+} __packed;
 
 /*
  * <platform>/    - debugfs root directory
  *   dev_id      - current dev_id
  *   ctrl_param  - current ctrl_param
+ *   method_id   - current method_id
  *   devs        - call DEVS(dev_id, ctrl_param) and print result
  *   dsts        - call DSTS(dev_id)  and print result
+ *   call        - call method_id(dev_id, ctrl_param) and print result
  */
 struct asus_wmi_debug {
        struct dentry *root;
+       u32 method_id;
        u32 dev_id;
        u32 ctrl_param;
 };
 
+struct asus_rfkill {
+       struct asus_wmi *asus;
+       struct rfkill *rfkill;
+       u32 dev_id;
+};
+
 struct asus_wmi {
+       int dsts_id;
+       int spec;
+       int sfun;
+
        struct input_dev *inputdev;
        struct backlight_device *backlight_device;
+       struct device *hwmon_device;
        struct platform_device *platform_device;
 
        struct led_classdev tpd_led;
@@ -124,10 +177,10 @@ struct asus_wmi {
        struct workqueue_struct *led_workqueue;
        struct work_struct tpd_led_work;
 
-       struct rfkill *wlan_rfkill;
-       struct rfkill *bluetooth_rfkill;
-       struct rfkill *wimax_rfkill;
-       struct rfkill *wwan3g_rfkill;
+       struct asus_rfkill wlan;
+       struct asus_rfkill bluetooth;
+       struct asus_rfkill wimax;
+       struct asus_rfkill wwan3g;
 
        struct hotplug_slot *hotplug_slot;
        struct mutex hotplug_lock;
@@ -148,8 +201,8 @@ static int asus_wmi_input_init(struct asus_wmi *asus)
        if (!asus->inputdev)
                return -ENOMEM;
 
-       asus->inputdev->name = asus->driver->input_phys;
-       asus->inputdev->phys = asus->driver->input_name;
+       asus->inputdev->name = asus->driver->input_name;
+       asus->inputdev->phys = asus->driver->input_phys;
        asus->inputdev->id.bustype = BUS_HOST;
        asus->inputdev->dev.parent = &asus->platform_device->dev;
 
@@ -180,20 +233,24 @@ static void asus_wmi_input_exit(struct asus_wmi *asus)
        asus->inputdev = NULL;
 }
 
-static acpi_status asus_wmi_get_devstate(u32 dev_id, u32 *retval)
+static int asus_wmi_evaluate_method(u32 method_id, u32 arg0, u32 arg1,
+                                   u32 *retval)
 {
-       struct acpi_buffer input = { (acpi_size) sizeof(u32), &dev_id };
+       struct bios_args args = {
+               .arg0 = arg0,
+               .arg1 = arg1,
+       };
+       struct acpi_buffer input = { (acpi_size) sizeof(args), &args };
        struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
-       union acpi_object *obj;
        acpi_status status;
+       union acpi_object *obj;
        u32 tmp;
 
-       status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID,
-                                    1, ASUS_WMI_METHODID_DSTS,
+       status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1, method_id,
                                     &input, &output);
 
        if (ACPI_FAILURE(status))
-               return status;
+               goto exit;
 
        obj = (union acpi_object *)output.pointer;
        if (obj && obj->type == ACPI_TYPE_INTEGER)
@@ -206,70 +263,55 @@ static acpi_status asus_wmi_get_devstate(u32 dev_id, u32 *retval)
 
        kfree(obj);
 
-       return status;
+exit:
+       if (ACPI_FAILURE(status))
+               return -EIO;
+
+       if (tmp == ASUS_WMI_UNSUPPORTED_METHOD)
+               return -ENODEV;
 
+       return 0;
 }
 
-static acpi_status asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param,
-                                        u32 *retval)
+static int asus_wmi_get_devstate(struct asus_wmi *asus, u32 dev_id, u32 *retval)
 {
-       struct bios_args args = {
-               .dev_id = dev_id,
-               .ctrl_param = ctrl_param,
-       };
-       struct acpi_buffer input = { (acpi_size) sizeof(args), &args };
-       acpi_status status;
-
-       if (!retval) {
-               status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1,
-                                            ASUS_WMI_METHODID_DEVS,
-                                            &input, NULL);
-       } else {
-               struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
-               union acpi_object *obj;
-               u32 tmp;
-
-               status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID, 1,
-                                            ASUS_WMI_METHODID_DEVS,
-                                            &input, &output);
-
-               if (ACPI_FAILURE(status))
-                       return status;
-
-               obj = (union acpi_object *)output.pointer;
-               if (obj && obj->type == ACPI_TYPE_INTEGER)
-                       tmp = (u32) obj->integer.value;
-               else
-                       tmp = 0;
-
-               *retval = tmp;
-
-               kfree(obj);
-       }
+       return asus_wmi_evaluate_method(asus->dsts_id, dev_id, 0, retval);
+}
 
-       return status;
+static int asus_wmi_set_devstate(u32 dev_id, u32 ctrl_param,
+                                u32 *retval)
+{
+       return asus_wmi_evaluate_method(ASUS_WMI_METHODID_DEVS, dev_id,
+                                       ctrl_param, retval);
 }
 
 /* Helper for special devices with magic return codes */
-static int asus_wmi_get_devstate_bits(u32 dev_id, u32 mask)
+static int asus_wmi_get_devstate_bits(struct asus_wmi *asus,
+                                     u32 dev_id, u32 mask)
 {
        u32 retval = 0;
-       acpi_status status;
+       int err;
 
-       status = asus_wmi_get_devstate(dev_id, &retval);
+       err = asus_wmi_get_devstate(asus, dev_id, &retval);
 
-       if (ACPI_FAILURE(status))
-               return -EINVAL;
+       if (err < 0)
+               return err;
 
        if (!(retval & ASUS_WMI_DSTS_PRESENCE_BIT))
                return -ENODEV;
 
+       if (mask == ASUS_WMI_DSTS_STATUS_BIT) {
+               if (retval & ASUS_WMI_DSTS_UNKNOWN_BIT)
+                       return -ENODEV;
+       }
+
        return retval & mask;
 }
 
-static int asus_wmi_get_devstate_simple(u32 dev_id)
+static int asus_wmi_get_devstate_simple(struct asus_wmi *asus, u32 dev_id)
 {
-       return asus_wmi_get_devstate_bits(dev_id, ASUS_WMI_DSTS_STATUS_BIT);
+       return asus_wmi_get_devstate_bits(asus, dev_id,
+                                         ASUS_WMI_DSTS_STATUS_BIT);
 }
 
 /*
@@ -305,7 +347,7 @@ static void tpd_led_set(struct led_classdev *led_cdev,
 
 static int read_tpd_led_state(struct asus_wmi *asus)
 {
-       return asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_TOUCHPAD_LED);
+       return asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_TOUCHPAD_LED);
 }
 
 static enum led_brightness tpd_led_get(struct led_classdev *led_cdev)
@@ -356,7 +398,7 @@ static void asus_wmi_led_exit(struct asus_wmi *asus)
  */
 static bool asus_wlan_rfkill_blocked(struct asus_wmi *asus)
 {
-       int result = asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_WLAN);
+       int result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_WLAN);
 
        if (result < 0)
                return false;
@@ -377,8 +419,8 @@ static void asus_rfkill_hotplug(struct asus_wmi *asus)
 
        mutex_lock(&asus->hotplug_lock);
 
-       if (asus->wlan_rfkill)
-               rfkill_set_sw_state(asus->wlan_rfkill, blocked);
+       if (asus->wlan.rfkill)
+               rfkill_set_sw_state(asus->wlan.rfkill, blocked);
 
        if (asus->hotplug_slot) {
                bus = pci_find_bus(0, 1);
@@ -485,7 +527,8 @@ static void asus_unregister_rfkill_notifier(struct asus_wmi *asus, char *node)
 static int asus_get_adapter_status(struct hotplug_slot *hotplug_slot,
                                   u8 *value)
 {
-       int result = asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_WLAN);
+       struct asus_wmi *asus = hotplug_slot->private;
+       int result = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_WLAN);
 
        if (result < 0)
                return result;
@@ -570,34 +613,29 @@ error_workqueue:
  */
 static int asus_rfkill_set(void *data, bool blocked)
 {
-       int dev_id = (unsigned long)data;
+       struct asus_rfkill *priv = data;
        u32 ctrl_param = !blocked;
-       acpi_status status;
-
-       status = asus_wmi_set_devstate(dev_id, ctrl_param, NULL);
-
-       if (ACPI_FAILURE(status))
-               return -EIO;
 
-       return 0;
+       return asus_wmi_set_devstate(priv->dev_id, ctrl_param, NULL);
 }
 
 static void asus_rfkill_query(struct rfkill *rfkill, void *data)
 {
-       int dev_id = (unsigned long)data;
+       struct asus_rfkill *priv = data;
        int result;
 
-       result = asus_wmi_get_devstate_simple(dev_id);
+       result = asus_wmi_get_devstate_simple(priv->asus, priv->dev_id);
 
        if (result < 0)
                return;
 
-       rfkill_set_sw_state(rfkill, !result);
+       rfkill_set_sw_state(priv->rfkill, !result);
 }
 
 static int asus_rfkill_wlan_set(void *data, bool blocked)
 {
-       struct asus_wmi *asus = data;
+       struct asus_rfkill *priv = data;
+       struct asus_wmi *asus = priv->asus;
        int ret;
 
        /*
@@ -608,19 +646,14 @@ static int asus_rfkill_wlan_set(void *data, bool blocked)
         * any wmi method
         */
        mutex_lock(&asus->wmi_lock);
-       ret = asus_rfkill_set((void *)(long)ASUS_WMI_DEVID_WLAN, blocked);
+       ret = asus_rfkill_set(data, blocked);
        mutex_unlock(&asus->wmi_lock);
        return ret;
 }
 
-static void asus_rfkill_wlan_query(struct rfkill *rfkill, void *data)
-{
-       asus_rfkill_query(rfkill, (void *)(long)ASUS_WMI_DEVID_WLAN);
-}
-
 static const struct rfkill_ops asus_rfkill_wlan_ops = {
        .set_block = asus_rfkill_wlan_set,
-       .query = asus_rfkill_wlan_query,
+       .query = asus_rfkill_query,
 };
 
 static const struct rfkill_ops asus_rfkill_ops = {
@@ -629,20 +662,24 @@ static const struct rfkill_ops asus_rfkill_ops = {
 };
 
 static int asus_new_rfkill(struct asus_wmi *asus,
-                          struct rfkill **rfkill,
+                          struct asus_rfkill *arfkill,
                           const char *name, enum rfkill_type type, int dev_id)
 {
-       int result = asus_wmi_get_devstate_simple(dev_id);
+       int result = asus_wmi_get_devstate_simple(asus, dev_id);
+       struct rfkill **rfkill = &arfkill->rfkill;
 
        if (result < 0)
                return result;
 
+       arfkill->dev_id = dev_id;
+       arfkill->asus = asus;
+
        if (dev_id == ASUS_WMI_DEVID_WLAN && asus->driver->hotplug_wireless)
                *rfkill = rfkill_alloc(name, &asus->platform_device->dev, type,
-                                      &asus_rfkill_wlan_ops, asus);
+                                      &asus_rfkill_wlan_ops, arfkill);
        else
                *rfkill = rfkill_alloc(name, &asus->platform_device->dev, type,
-                                      &asus_rfkill_ops, (void *)(long)dev_id);
+                                      &asus_rfkill_ops, arfkill);
 
        if (!*rfkill)
                return -EINVAL;
@@ -662,10 +699,10 @@ static void asus_wmi_rfkill_exit(struct asus_wmi *asus)
        asus_unregister_rfkill_notifier(asus, "\\_SB.PCI0.P0P5");
        asus_unregister_rfkill_notifier(asus, "\\_SB.PCI0.P0P6");
        asus_unregister_rfkill_notifier(asus, "\\_SB.PCI0.P0P7");
-       if (asus->wlan_rfkill) {
-               rfkill_unregister(asus->wlan_rfkill);
-               rfkill_destroy(asus->wlan_rfkill);
-               asus->wlan_rfkill = NULL;
+       if (asus->wlan.rfkill) {
+               rfkill_unregister(asus->wlan.rfkill);
+               rfkill_destroy(asus->wlan.rfkill);
+               asus->wlan.rfkill = NULL;
        }
        /*
         * Refresh pci hotplug in case the rfkill state was changed after
@@ -677,20 +714,20 @@ static void asus_wmi_rfkill_exit(struct asus_wmi *asus)
        if (asus->hotplug_workqueue)
                destroy_workqueue(asus->hotplug_workqueue);
 
-       if (asus->bluetooth_rfkill) {
-               rfkill_unregister(asus->bluetooth_rfkill);
-               rfkill_destroy(asus->bluetooth_rfkill);
-               asus->bluetooth_rfkill = NULL;
+       if (asus->bluetooth.rfkill) {
+               rfkill_unregister(asus->bluetooth.rfkill);
+               rfkill_destroy(asus->bluetooth.rfkill);
+               asus->bluetooth.rfkill = NULL;
        }
-       if (asus->wimax_rfkill) {
-               rfkill_unregister(asus->wimax_rfkill);
-               rfkill_destroy(asus->wimax_rfkill);
-               asus->wimax_rfkill = NULL;
+       if (asus->wimax.rfkill) {
+               rfkill_unregister(asus->wimax.rfkill);
+               rfkill_destroy(asus->wimax.rfkill);
+               asus->wimax.rfkill = NULL;
        }
-       if (asus->wwan3g_rfkill) {
-               rfkill_unregister(asus->wwan3g_rfkill);
-               rfkill_destroy(asus->wwan3g_rfkill);
-               asus->wwan3g_rfkill = NULL;
+       if (asus->wwan3g.rfkill) {
+               rfkill_unregister(asus->wwan3g.rfkill);
+               rfkill_destroy(asus->wwan3g.rfkill);
+               asus->wwan3g.rfkill = NULL;
        }
 }
 
@@ -701,30 +738,27 @@ static int asus_wmi_rfkill_init(struct asus_wmi *asus)
        mutex_init(&asus->hotplug_lock);
        mutex_init(&asus->wmi_lock);
 
-       result = asus_new_rfkill(asus, &asus->wlan_rfkill,
-                                "asus-wlan", RFKILL_TYPE_WLAN,
-                                ASUS_WMI_DEVID_WLAN);
+       result = asus_new_rfkill(asus, &asus->wlan, "asus-wlan",
+                                RFKILL_TYPE_WLAN, ASUS_WMI_DEVID_WLAN);
 
        if (result && result != -ENODEV)
                goto exit;
 
-       result = asus_new_rfkill(asus, &asus->bluetooth_rfkill,
+       result = asus_new_rfkill(asus, &asus->bluetooth,
                                 "asus-bluetooth", RFKILL_TYPE_BLUETOOTH,
                                 ASUS_WMI_DEVID_BLUETOOTH);
 
        if (result && result != -ENODEV)
                goto exit;
 
-       result = asus_new_rfkill(asus, &asus->wimax_rfkill,
-                                "asus-wimax", RFKILL_TYPE_WIMAX,
-                                ASUS_WMI_DEVID_WIMAX);
+       result = asus_new_rfkill(asus, &asus->wimax, "asus-wimax",
+                                RFKILL_TYPE_WIMAX, ASUS_WMI_DEVID_WIMAX);
 
        if (result && result != -ENODEV)
                goto exit;
 
-       result = asus_new_rfkill(asus, &asus->wwan3g_rfkill,
-                                "asus-wwan3g", RFKILL_TYPE_WWAN,
-                                ASUS_WMI_DEVID_WWAN3G);
+       result = asus_new_rfkill(asus, &asus->wwan3g, "asus-wwan3g",
+                                RFKILL_TYPE_WWAN, ASUS_WMI_DEVID_WWAN3G);
 
        if (result && result != -ENODEV)
                goto exit;
@@ -759,12 +793,130 @@ exit:
        return result;
 }
 
+/*
+ * Hwmon device
+ */
+static ssize_t asus_hwmon_pwm1(struct device *dev,
+                           struct device_attribute *attr,
+                           char *buf)
+{
+       struct asus_wmi *asus = dev_get_drvdata(dev);
+       u32 value;
+       int err;
+
+       err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_FAN_CTRL, &value);
+
+       if (err < 0)
+               return err;
+
+       value |= 0xFF;
+
+       if (value == 1) /* Low Speed */
+               value = 85;
+       else if (value == 2)
+               value = 170;
+       else if (value == 3)
+               value = 255;
+       else if (value != 0) {
+               pr_err("Unknown fan speed %#x", value);
+               value = -1;
+       }
+
+       return sprintf(buf, "%d\n", value);
+}
+
+static SENSOR_DEVICE_ATTR(pwm1, S_IRUGO, asus_hwmon_pwm1, NULL, 0);
+
+static ssize_t
+show_name(struct device *dev, struct device_attribute *attr, char *buf)
+{
+       return sprintf(buf, "asus\n");
+}
+static SENSOR_DEVICE_ATTR(name, S_IRUGO, show_name, NULL, 0);
+
+static struct attribute *hwmon_attributes[] = {
+       &sensor_dev_attr_pwm1.dev_attr.attr,
+       &sensor_dev_attr_name.dev_attr.attr,
+       NULL
+};
+
+static mode_t asus_hwmon_sysfs_is_visible(struct kobject *kobj,
+                                   struct attribute *attr, int idx)
+{
+       struct device *dev = container_of(kobj, struct device, kobj);
+       struct platform_device *pdev = to_platform_device(dev->parent);
+       struct asus_wmi *asus = platform_get_drvdata(pdev);
+       bool ok = true;
+       int dev_id = -1;
+       u32 value = ASUS_WMI_UNSUPPORTED_METHOD;
+
+       if (attr == &sensor_dev_attr_pwm1.dev_attr.attr)
+               dev_id = ASUS_WMI_DEVID_FAN_CTRL;
+
+       if (dev_id != -1) {
+               int err = asus_wmi_get_devstate(asus, dev_id, &value);
+
+               if (err < 0)
+                       return err;
+       }
+
+       if (dev_id == ASUS_WMI_DEVID_FAN_CTRL) {
+               /*
+                * We need to find a better way, probably using sfun,
+                * bits or spec ...
+                * Currently we disable it if:
+                * - ASUS_WMI_UNSUPPORTED_METHOD is returned
+                * - reverved bits are non-zero
+                * - sfun and presence bit are not set
+                */
+               if (value != ASUS_WMI_UNSUPPORTED_METHOD || value & 0xFFF80000
+                   || (!asus->sfun && !(value & ASUS_WMI_DSTS_PRESENCE_BIT)))
+                       ok = false;
+       }
+
+       return ok ? attr->mode : 0;
+}
+
+static struct attribute_group hwmon_attribute_group = {
+       .is_visible = asus_hwmon_sysfs_is_visible,
+       .attrs = hwmon_attributes
+};
+
+static void asus_wmi_hwmon_exit(struct asus_wmi *asus)
+{
+       struct device *hwmon;
+
+       hwmon = asus->hwmon_device;
+       if (!hwmon)
+               return;
+       sysfs_remove_group(&hwmon->kobj, &hwmon_attribute_group);
+       hwmon_device_unregister(hwmon);
+       asus->hwmon_device = NULL;
+}
+
+static int asus_wmi_hwmon_init(struct asus_wmi *asus)
+{
+       struct device *hwmon;
+       int result;
+
+       hwmon = hwmon_device_register(&asus->platform_device->dev);
+       if (IS_ERR(hwmon)) {
+               pr_err("Could not register asus hwmon device\n");
+               return PTR_ERR(hwmon);
+       }
+       asus->hwmon_device = hwmon;
+       result = sysfs_create_group(&hwmon->kobj, &hwmon_attribute_group);
+       if (result)
+               asus_wmi_hwmon_exit(asus);
+       return result;
+}
+
 /*
  * Backlight
  */
-static int read_backlight_power(void)
+static int read_backlight_power(struct asus_wmi *asus)
 {
-       int ret = asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_BACKLIGHT);
+       int ret = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_BACKLIGHT);
 
        if (ret < 0)
                return ret;
@@ -772,43 +924,60 @@ static int read_backlight_power(void)
        return ret ? FB_BLANK_UNBLANK : FB_BLANK_POWERDOWN;
 }
 
+static int read_brightness_max(struct asus_wmi *asus)
+{
+       u32 retval;
+       int err;
+
+       err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);
+
+       if (err < 0)
+               return err;
+
+       retval = retval & ASUS_WMI_DSTS_MAX_BRIGTH_MASK;
+       retval >>= 8;
+
+       if (!retval)
+               return -ENODEV;
+
+       return retval;
+}
+
 static int read_brightness(struct backlight_device *bd)
 {
+       struct asus_wmi *asus = bl_get_data(bd);
        u32 retval;
-       acpi_status status;
+       int err;
 
-       status = asus_wmi_get_devstate(ASUS_WMI_DEVID_BRIGHTNESS, &retval);
+       err = asus_wmi_get_devstate(asus, ASUS_WMI_DEVID_BRIGHTNESS, &retval);
 
-       if (ACPI_FAILURE(status))
-               return -EIO;
-       else
-               return retval & ASUS_WMI_DSTS_BRIGHTNESS_MASK;
+       if (err < 0)
+               return err;
+
+       return retval & ASUS_WMI_DSTS_BRIGHTNESS_MASK;
 }
 
 static int update_bl_status(struct backlight_device *bd)
 {
+       struct asus_wmi *asus = bl_get_data(bd);
        u32 ctrl_param;
-       acpi_status status;
-       int power;
+       int power, err;
 
        ctrl_param = bd->props.brightness;
 
-       status = asus_wmi_set_devstate(ASUS_WMI_DEVID_BRIGHTNESS,
-                                      ctrl_param, NULL);
+       err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BRIGHTNESS,
+                                   ctrl_param, NULL);
 
-       if (ACPI_FAILURE(status))
-               return -EIO;
+       if (err < 0)
+               return err;
 
-       power = read_backlight_power();
+       power = read_backlight_power(asus);
        if (power != -ENODEV && bd->props.power != power) {
                ctrl_param = !!(bd->props.power == FB_BLANK_UNBLANK);
-               status = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT,
-                                              ctrl_param, NULL);
-
-               if (ACPI_FAILURE(status))
-                       return -EIO;
+               err = asus_wmi_set_devstate(ASUS_WMI_DEVID_BACKLIGHT,
+                                           ctrl_param, NULL);
        }
-       return 0;
+       return err;
 }
 
 static const struct backlight_ops asus_wmi_bl_ops = {
@@ -841,23 +1010,19 @@ static int asus_wmi_backlight_init(struct asus_wmi *asus)
        int max;
        int power;
 
-       max = asus_wmi_get_devstate_bits(ASUS_WMI_DEVID_BRIGHTNESS,
-                                        ASUS_WMI_DSTS_MAX_BRIGTH_MASK);
-       power = read_backlight_power();
+       max = read_brightness_max(asus);
 
-       if (max < 0 && power < 0) {
-               /* Try to keep the original error */
-               if (max == -ENODEV && power == -ENODEV)
-                       return -ENODEV;
-               if (max != -ENODEV)
-                       return max;
-               else
-                       return power;
-       }
        if (max == -ENODEV)
                max = 0;
+       else if (max < 0)
+               return max;
+
+       power = read_backlight_power(asus);
+
        if (power == -ENODEV)
                power = FB_BLANK_UNBLANK;
+       else if (power < 0)
+               return power;
 
        memset(&props, 0, sizeof(struct backlight_properties));
        props.max_brightness = max;
@@ -937,27 +1102,28 @@ static int parse_arg(const char *buf, unsigned long count, int *val)
        return count;
 }
 
-static ssize_t store_sys_wmi(int devid, const char *buf, size_t count)
+static ssize_t store_sys_wmi(struct asus_wmi *asus, int devid,
+                            const char *buf, size_t count)
 {
-       acpi_status status;
        u32 retval;
-       int rv, value;
+       int rv, err, value;
 
-       value = asus_wmi_get_devstate_simple(devid);
+       value = asus_wmi_get_devstate_simple(asus, devid);
        if (value == -ENODEV)   /* Check device presence */
                return value;
 
        rv = parse_arg(buf, count, &value);
-       status = asus_wmi_set_devstate(devid, value, &retval);
+       err = asus_wmi_set_devstate(devid, value, &retval);
+
+       if (err < 0)
+               return err;
 
-       if (ACPI_FAILURE(status))
-               return -EIO;
        return rv;
 }
 
-static ssize_t show_sys_wmi(int devid, char *buf)
+static ssize_t show_sys_wmi(struct asus_wmi *asus, int devid, char *buf)
 {
-       int value = asus_wmi_get_devstate_simple(devid);
+       int value = asus_wmi_get_devstate_simple(asus, devid);
 
        if (value < 0)
                return value;
@@ -970,13 +1136,17 @@ static ssize_t show_sys_wmi(int devid, char *buf)
                                    struct device_attribute *attr,      \
                                    char *buf)                          \
        {                                                               \
-               return show_sys_wmi(_cm, buf);                          \
+               struct asus_wmi *asus = dev_get_drvdata(dev);           \
+                                                                       \
+               return show_sys_wmi(asus, _cm, buf);                    \
        }                                                               \
        static ssize_t store_##_name(struct device *dev,                \
                                     struct device_attribute *attr,     \
                                     const char *buf, size_t count)     \
        {                                                               \
-               return store_sys_wmi(_cm, buf, count);                  \
+               struct asus_wmi *asus = dev_get_drvdata(dev);           \
+                                                                       \
+               return store_sys_wmi(asus, _cm, buf, count);            \
        }                                                               \
        static struct device_attribute dev_attr_##_name = {             \
                .attr = {                                               \
@@ -994,21 +1164,13 @@ static ssize_t store_cpufv(struct device *dev, struct device_attribute *attr,
                           const char *buf, size_t count)
 {
        int value;
-       struct acpi_buffer input = { (acpi_size) sizeof(value), &value };
-       acpi_status status;
 
        if (!count || sscanf(buf, "%i", &value) != 1)
                return -EINVAL;
        if (value < 0 || value > 2)
                return -EINVAL;
 
-       status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID,
-                                    1, ASUS_WMI_METHODID_CFVS, &input, NULL);
-
-       if (ACPI_FAILURE(status))
-               return -EIO;
-       else
-               return count;
+       return asus_wmi_evaluate_method(ASUS_WMI_METHODID_CFVS, value, 0, NULL);
 }
 
 static DEVICE_ATTR(cpufv, S_IRUGO | S_IWUSR, NULL, store_cpufv);
@@ -1024,7 +1186,10 @@ static struct attribute *platform_attributes[] = {
 static mode_t asus_sysfs_is_visible(struct kobject *kobj,
                                    struct attribute *attr, int idx)
 {
-       bool supported = true;
+       struct device *dev = container_of(kobj, struct device, kobj);
+       struct platform_device *pdev = to_platform_device(dev);
+       struct asus_wmi *asus = platform_get_drvdata(pdev);
+       bool ok = true;
        int devid = -1;
 
        if (attr == &dev_attr_camera.attr)
@@ -1035,9 +1200,9 @@ static mode_t asus_sysfs_is_visible(struct kobject *kobj,
                devid = ASUS_WMI_DEVID_TOUCHPAD;
 
        if (devid != -1)
-               supported = asus_wmi_get_devstate_simple(devid) != -ENODEV;
+               ok = !(asus_wmi_get_devstate_simple(asus, devid) < 0);
 
-       return supported ? attr->mode : 0;
+       return ok ? attr->mode : 0;
 }
 
 static struct attribute_group platform_attribute_group = {
@@ -1060,6 +1225,46 @@ static int asus_wmi_sysfs_init(struct platform_device *device)
  */
 static int __init asus_wmi_platform_init(struct asus_wmi *asus)
 {
+       int rv;
+
+       /* INIT enable hotkeys on some models */
+       if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_INIT, 0, 0, &rv))
+               pr_info("Initialization: %#x", rv);
+
+       /* We don't know yet what to do with this version... */
+       if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_SPEC, 0, 0x9, &rv)) {
+               pr_info("BIOS WMI version: %d.%d", rv >> 8, rv & 0xFF);
+               asus->spec = rv;
+       }
+
+       /*
+        * The SFUN method probably allows the original driver to get the list
+        * of features supported by a given model. For now, 0x0100 or 0x0800
+        * bit signifies that the laptop is equipped with a Wi-Fi MiniPCI card.
+        * The significance of others is yet to be found.
+        */
+       if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_SFUN, 0, 0, &rv)) {
+               pr_info("SFUN value: %#x", rv);
+               asus->sfun = rv;
+       }
+
+       /*
+        * Eee PC and Notebooks seems to have different method_id for DSTS,
+        * but it may also be related to the BIOS's SPEC.
+        * Note, on most Eeepc, there is no way to check if a method exist
+        * or note, while on notebooks, they returns 0xFFFFFFFE on failure,
+        * but once again, SPEC may probably be used for that kind of things.
+        */
+       if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS, 0, 0, NULL))
+               asus->dsts_id = ASUS_WMI_METHODID_DSTS;
+       else if (!asus_wmi_evaluate_method(ASUS_WMI_METHODID_DSTS2, 0, 0, NULL))
+               asus->dsts_id = ASUS_WMI_METHODID_DSTS2;
+
+       if (!asus->dsts_id) {
+               pr_err("Can't find DSTS");
+               return -ENODEV;
+       }
+
        return asus_wmi_sysfs_init(asus->platform_device);
 }
 
@@ -1080,15 +1285,15 @@ struct asus_wmi_debugfs_node {
 static int show_dsts(struct seq_file *m, void *data)
 {
        struct asus_wmi *asus = m->private;
-       acpi_status status;
+       int err;
        u32 retval = -1;
 
-       status = asus_wmi_get_devstate(asus->debug.dev_id, &retval);
+       err = asus_wmi_get_devstate(asus, asus->debug.dev_id, &retval);
 
-       if (ACPI_FAILURE(status))
-               return -EIO;
+       if (err < 0)
+               return err;
 
-       seq_printf(m, "DSTS(%x) = %x\n", asus->debug.dev_id, retval);
+       seq_printf(m, "DSTS(%#x) = %#x\n", asus->debug.dev_id, retval);
 
        return 0;
 }
@@ -1096,16 +1301,51 @@ static int show_dsts(struct seq_file *m, void *data)
 static int show_devs(struct seq_file *m, void *data)
 {
        struct asus_wmi *asus = m->private;
-       acpi_status status;
+       int err;
        u32 retval = -1;
 
-       status = asus_wmi_set_devstate(asus->debug.dev_id,
-                                      asus->debug.ctrl_param, &retval);
+       err = asus_wmi_set_devstate(asus->debug.dev_id, asus->debug.ctrl_param,
+                                   &retval);
+
+       if (err < 0)
+               return err;
+
+       seq_printf(m, "DEVS(%#x, %#x) = %#x\n", asus->debug.dev_id,
+                  asus->debug.ctrl_param, retval);
+
+       return 0;
+}
+
+static int show_call(struct seq_file *m, void *data)
+{
+       struct asus_wmi *asus = m->private;
+       struct bios_args args = {
+               .arg0 = asus->debug.dev_id,
+               .arg1 = asus->debug.ctrl_param,
+       };
+       struct acpi_buffer input = { (acpi_size) sizeof(args), &args };
+       struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL };
+       union acpi_object *obj;
+       acpi_status status;
+
+       status = wmi_evaluate_method(ASUS_WMI_MGMT_GUID,
+                                    1, asus->debug.method_id,
+                                    &input, &output);
+
        if (ACPI_FAILURE(status))
                return -EIO;
 
-       seq_printf(m, "DEVS(%x, %x) = %x\n", asus->debug.dev_id,
-                  asus->debug.ctrl_param, retval);
+       obj = (union acpi_object *)output.pointer;
+       if (obj && obj->type == ACPI_TYPE_INTEGER)
+               seq_printf(m, "%#x(%#x, %#x) = %#x\n", asus->debug.method_id,
+                          asus->debug.dev_id, asus->debug.ctrl_param,
+                          (u32) obj->integer.value);
+       else
+               seq_printf(m, "%#x(%#x, %#x) = t:%d\n", asus->debug.method_id,
+                          asus->debug.dev_id, asus->debug.ctrl_param,
+                          obj ? obj->type : -1);
+
+       kfree(obj);
 
        return 0;
 }
@@ -1113,6 +1353,7 @@ static int show_devs(struct seq_file *m, void *data)
 static struct asus_wmi_debugfs_node asus_wmi_debug_files[] = {
        {NULL, "devs", show_devs},
        {NULL, "dsts", show_dsts},
+       {NULL, "call", show_call},
 };
 
 static int asus_wmi_debugfs_open(struct inode *inode, struct file *file)
@@ -1146,6 +1387,11 @@ static int asus_wmi_debugfs_init(struct asus_wmi *asus)
                goto error_debugfs;
        }
 
+       dent = debugfs_create_x32("method_id", S_IRUGO | S_IWUSR,
+                                 asus->debug.root, &asus->debug.method_id);
+       if (!dent)
+               goto error_debugfs;
+
        dent = debugfs_create_x32("dev_id", S_IRUGO | S_IWUSR,
                                  asus->debug.root, &asus->debug.dev_id);
        if (!dent)
@@ -1207,6 +1453,10 @@ static int asus_wmi_add(struct platform_device *pdev)
        if (err)
                goto fail_input;
 
+       err = asus_wmi_hwmon_init(asus);
+       if (err)
+               goto fail_hwmon;
+
        err = asus_wmi_led_init(asus);
        if (err)
                goto fail_leds;
@@ -1245,6 +1495,8 @@ fail_backlight:
 fail_rfkill:
        asus_wmi_led_exit(asus);
 fail_leds:
+       asus_wmi_hwmon_exit(asus);
+fail_hwmon:
        asus_wmi_input_exit(asus);
 fail_input:
        asus_wmi_platform_exit(asus);
@@ -1261,6 +1513,7 @@ static int asus_wmi_remove(struct platform_device *device)
        wmi_remove_notify_handler(asus->driver->event_guid);
        asus_wmi_backlight_exit(asus);
        asus_wmi_input_exit(asus);
+       asus_wmi_hwmon_exit(asus);
        asus_wmi_led_exit(asus);
        asus_wmi_rfkill_exit(asus);
        asus_wmi_debugfs_exit(asus);
@@ -1277,7 +1530,7 @@ static int asus_hotk_thaw(struct device *device)
 {
        struct asus_wmi *asus = dev_get_drvdata(device);
 
-       if (asus->wlan_rfkill) {
+       if (asus->wlan.rfkill) {
                bool wlan;
 
                /*
@@ -1285,7 +1538,7 @@ static int asus_hotk_thaw(struct device *device)
                 * during suspend.  Normally it restores it on resume, but
                 * we should kick it ourselves in case hibernation is aborted.
                 */
-               wlan = asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_WLAN);
+               wlan = asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_WLAN);
                asus_wmi_set_devstate(ASUS_WMI_DEVID_WLAN, wlan, NULL);
        }
 
@@ -1298,20 +1551,21 @@ static int asus_hotk_restore(struct device *device)
        int bl;
 
        /* Refresh both wlan rfkill state and pci hotplug */
-       if (asus->wlan_rfkill)
+       if (asus->wlan.rfkill)
                asus_rfkill_hotplug(asus);
 
-       if (asus->bluetooth_rfkill) {
-               bl = !asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_BLUETOOTH);
-               rfkill_set_sw_state(asus->bluetooth_rfkill, bl);
+       if (asus->bluetooth.rfkill) {
+               bl = !asus_wmi_get_devstate_simple(asus,
+                                                  ASUS_WMI_DEVID_BLUETOOTH);
+               rfkill_set_sw_state(asus->bluetooth.rfkill, bl);
        }
-       if (asus->wimax_rfkill) {
-               bl = !asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_WIMAX);
-               rfkill_set_sw_state(asus->wimax_rfkill, bl);
+       if (asus->wimax.rfkill) {
+               bl = !asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_WIMAX);
+               rfkill_set_sw_state(asus->wimax.rfkill, bl);
        }
-       if (asus->wwan3g_rfkill) {
-               bl = !asus_wmi_get_devstate_simple(ASUS_WMI_DEVID_WWAN3G);
-               rfkill_set_sw_state(asus->wwan3g_rfkill, bl);
+       if (asus->wwan3g.rfkill) {
+               bl = !asus_wmi_get_devstate_simple(asus, ASUS_WMI_DEVID_WWAN3G);
+               rfkill_set_sw_state(asus->wwan3g.rfkill, bl);
        }
 
        return 0;