]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/scsi/scsi_error.c
scsi: avoid ->change_queue_depth indirection for queue full tracking
[karo-tx-linux.git] / drivers / scsi / scsi_error.c
index c2bef46e90e064537ac5af2e84b4765589587701..2d0f5155ee518238fb5a53c78d61f662dcc202f8 100644 (file)
@@ -36,6 +36,7 @@
 #include <scsi/scsi_transport.h>
 #include <scsi/scsi_host.h>
 #include <scsi/scsi_ioctl.h>
+#include <scsi/sg.h>
 
 #include "scsi_priv.h"
 #include "scsi_logging.h"
@@ -157,8 +158,9 @@ scmd_eh_abort_handler(struct work_struct *work)
                } else {
                        SCSI_LOG_ERROR_RECOVERY(3,
                                scmd_printk(KERN_INFO, scmd,
-                                           "scmd %p abort failed, rtn %d\n",
-                                           scmd, rtn));
+                                           "scmd %p abort %s\n", scmd,
+                                           (rtn == FAST_IO_FAIL) ?
+                                           "not send" : "failed"));
                }
        }
 
@@ -355,7 +357,7 @@ static inline void scsi_eh_prt_fail_stats(struct Scsi_Host *shost,
 
                if (cmd_cancel || cmd_failed) {
                        SCSI_LOG_ERROR_RECOVERY(3,
-                               sdev_printk(KERN_INFO, sdev,
+                               shost_printk(KERN_INFO, shost,
                                            "%s: cmds failed: %d, cancel: %d\n",
                                            __func__, cmd_failed,
                                            cmd_cancel));
@@ -608,7 +610,7 @@ static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
        struct scsi_host_template *sht = sdev->host->hostt;
        struct scsi_device *tmp_sdev;
 
-       if (!sht->change_queue_depth ||
+       if (!sht->track_queue_depth ||
            sdev->queue_depth >= sdev->max_queue_depth)
                return;
 
@@ -629,12 +631,8 @@ static void scsi_handle_queue_ramp_up(struct scsi_device *sdev)
                    tmp_sdev->id != sdev->id ||
                    tmp_sdev->queue_depth == sdev->max_queue_depth)
                        continue;
-               /*
-                * call back into LLD to increase queue_depth by one
-                * with ramp up reason code.
-                */
-               sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth + 1,
-                                       SCSI_QDEPTH_RAMP_UP);
+
+               scsi_adjust_queue_depth(tmp_sdev, tmp_sdev->queue_depth + 1);
                sdev->last_queue_ramp_up = jiffies;
        }
 }
@@ -644,7 +642,7 @@ static void scsi_handle_queue_full(struct scsi_device *sdev)
        struct scsi_host_template *sht = sdev->host->hostt;
        struct scsi_device *tmp_sdev;
 
-       if (!sht->change_queue_depth)
+       if (!sht->track_queue_depth)
                return;
 
        shost_for_each_device(tmp_sdev, sdev->host) {
@@ -656,8 +654,7 @@ static void scsi_handle_queue_full(struct scsi_device *sdev)
                 * the device when we got the queue full so we start
                 * from the highest possible value and work our way down.
                 */
-               sht->change_queue_depth(tmp_sdev, tmp_sdev->queue_depth - 1,
-                                       SCSI_QDEPTH_QFULL);
+               scsi_track_queue_full(tmp_sdev, tmp_sdev->queue_depth - 1);
        }
 }
 
@@ -869,7 +866,24 @@ static int scsi_try_bus_device_reset(struct scsi_cmnd *scmd)
        return rtn;
 }
 
-static int scsi_try_to_abort_cmd(struct scsi_host_template *hostt, struct scsi_cmnd *scmd)
+/**
+ * scsi_try_to_abort_cmd - Ask host to abort a SCSI command
+ * @scmd:      SCSI cmd used to send a target reset
+ *
+ * Return value:
+ *     SUCCESS, FAILED, or FAST_IO_FAIL
+ *
+ * Notes:
+ *    SUCCESS does not necessarily indicate that the command
+ *    has been aborted; it only indicates that the LLDDs
+ *    has cleared all references to that command.
+ *    LLDDs should return FAILED only if an abort was required
+ *    but could not be executed. LLDDs should return FAST_IO_FAIL
+ *    if the device is temporarily unavailable (eg due to a
+ *    link down on FibreChannel)
+ */
+static int scsi_try_to_abort_cmd(struct scsi_host_template *hostt,
+                                struct scsi_cmnd *scmd)
 {
        if (!hostt->eh_abort_handler)
                return FAILED;
@@ -2293,39 +2307,36 @@ scsi_reset_provider_done_command(struct scsi_cmnd *scmd)
 {
 }
 
-/*
- * Function:   scsi_reset_provider
- *
- * Purpose:    Send requested reset to a bus or device at any phase.
- *
- * Arguments:  device  - device to send reset to
- *             flag - reset type (see scsi.h)
- *
- * Returns:    SUCCESS/FAILURE.
- *
- * Notes:      This is used by the SCSI Generic driver to provide
- *             Bus/Device reset capability.
+/**
+ * scsi_ioctl_reset: explicitly reset a host/bus/target/device
+ * @dev:       scsi_device to operate on
+ * @arg:       reset type (see sg.h)
  */
 int
-scsi_reset_provider(struct scsi_device *dev, int flag)
+scsi_ioctl_reset(struct scsi_device *dev, int __user *arg)
 {
        struct scsi_cmnd *scmd;
        struct Scsi_Host *shost = dev->host;
        struct request req;
        unsigned long flags;
-       int rtn;
+       int error = 0, rtn, val;
+
+       if (!capable(CAP_SYS_ADMIN) || !capable(CAP_SYS_RAWIO))
+               return -EACCES;
+
+       error = get_user(val, arg);
+       if (error)
+               return error;
 
        if (scsi_autopm_get_host(shost) < 0)
-               return FAILED;
+               return -EIO;
 
-       if (!get_device(&dev->sdev_gendev)) {
-               rtn = FAILED;
+       error = -EIO;
+       if (!get_device(&dev->sdev_gendev))
                goto out_put_autopm_host;
-       }
 
        scmd = scsi_get_command(dev, GFP_KERNEL);
        if (!scmd) {
-               rtn = FAILED;
                put_device(&dev->sdev_gendev);
                goto out_put_autopm_host;
        }
@@ -2346,39 +2357,37 @@ scsi_reset_provider(struct scsi_device *dev, int flag)
        shost->tmf_in_progress = 1;
        spin_unlock_irqrestore(shost->host_lock, flags);
 
-       switch (flag) {
-       case SCSI_TRY_RESET_DEVICE:
+       switch (val & ~SG_SCSI_RESET_NO_ESCALATE) {
+       case SG_SCSI_RESET_NOTHING:
+               rtn = SUCCESS;
+               break;
+       case SG_SCSI_RESET_DEVICE:
                rtn = scsi_try_bus_device_reset(scmd);
-               if (rtn == SUCCESS)
+               if (rtn == SUCCESS || (val & SG_SCSI_RESET_NO_ESCALATE))
                        break;
                /* FALLTHROUGH */
-       case SCSI_TRY_RESET_TARGET:
+       case SG_SCSI_RESET_TARGET:
                rtn = scsi_try_target_reset(scmd);
-               if (rtn == SUCCESS)
+               if (rtn == SUCCESS || (val & SG_SCSI_RESET_NO_ESCALATE))
                        break;
                /* FALLTHROUGH */
-       case SCSI_TRY_RESET_BUS:
+       case SG_SCSI_RESET_BUS:
                rtn = scsi_try_bus_reset(scmd);
-               if (rtn == SUCCESS)
+               if (rtn == SUCCESS || (val & SG_SCSI_RESET_NO_ESCALATE))
                        break;
                /* FALLTHROUGH */
-       case SCSI_TRY_RESET_HOST:
-       case SCSI_TRY_RESET_HOST | SCSI_TRY_RESET_NO_ESCALATE:
+       case SG_SCSI_RESET_HOST:
                rtn = scsi_try_host_reset(scmd);
-               break;
-       case SCSI_TRY_RESET_DEVICE | SCSI_TRY_RESET_NO_ESCALATE:
-               rtn = scsi_try_bus_device_reset(scmd);
-               break;
-       case SCSI_TRY_RESET_TARGET | SCSI_TRY_RESET_NO_ESCALATE:
-               rtn = scsi_try_target_reset(scmd);
-               break;
-       case SCSI_TRY_RESET_BUS | SCSI_TRY_RESET_NO_ESCALATE:
-               rtn = scsi_try_bus_reset(scmd);
-               break;
+               if (rtn == SUCCESS)
+                       break;
        default:
+               /* FALLTHROUGH */
                rtn = FAILED;
+               break;
        }
 
+       error = (rtn == SUCCESS) ? 0 : -EIO;
+
        spin_lock_irqsave(shost->host_lock, flags);
        shost->tmf_in_progress = 0;
        spin_unlock_irqrestore(shost->host_lock, flags);
@@ -2398,9 +2407,9 @@ scsi_reset_provider(struct scsi_device *dev, int flag)
        scsi_next_command(scmd);
 out_put_autopm_host:
        scsi_autopm_put_host(shost);
-       return rtn;
+       return error;
 }
-EXPORT_SYMBOL(scsi_reset_provider);
+EXPORT_SYMBOL(scsi_ioctl_reset);
 
 /**
  * scsi_normalize_sense - normalize main elements from either fixed or