]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - drivers/staging/hv/hv_mouse.c
Staging: hv: mousevsc: Cleanup and properly implement reportdesc_callback()
[karo-tx-linux.git] / drivers / staging / hv / hv_mouse.c
index 016d7e570d1cb5f47dc6de8594f4c3b19d7656e1..8d94aef9010290bc42aacaaa380b27a431fb34ed 100644 (file)
@@ -162,10 +162,7 @@ struct mousevsc_dev {
        struct mousevsc_prt_msg protocol_req;
        struct mousevsc_prt_msg protocol_resp;
        /* Synchronize the request/response if needed */
-       wait_queue_head_t       protocol_wait_event;
-       wait_queue_head_t       dev_info_wait_event;
-       int                     protocol_wait_condition;
-       int                     device_wait_condition;
+       struct completion       wait_event;
        int                     dev_info_status;
 
        struct hid_descriptor   *hid_desc;
@@ -194,6 +191,7 @@ static struct mousevsc_dev *alloc_input_device(struct hv_device *device)
 
        input_dev->device = device;
        hv_set_drvdata(device, input_dev);
+       init_completion(&input_dev->wait_event);
 
        return input_dev;
 }
@@ -329,7 +327,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
        desc = &device_info->hid_descriptor;
        WARN_ON(desc->bLength == 0);
 
-       input_device->hid_desc = kzalloc(desc->bLength, GFP_KERNEL);
+       input_device->hid_desc = kzalloc(desc->bLength, GFP_ATOMIC);
 
        if (!input_device->hid_desc) {
                pr_err("unable to allocate hid descriptor - size %d",
@@ -341,8 +339,10 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
 
        /* Save the report desc */
        input_device->report_desc_size = desc->desc[0].wDescriptorLength;
+       if (input_device->report_desc_size == 0)
+               goto cleanup;
        input_device->report_desc = kzalloc(input_device->report_desc_size,
-                                         GFP_KERNEL);
+                                         GFP_ATOMIC);
 
        if (!input_device->report_desc) {
                pr_err("unable to allocate report descriptor - size %d",
@@ -377,8 +377,7 @@ static void mousevsc_on_receive_device_info(struct mousevsc_dev *input_device,
                goto cleanup;
        }
 
-       input_device->device_wait_condition = 1;
-       wake_up(&input_device->dev_info_wait_event);
+       complete(&input_device->wait_event);
 
        return;
 
@@ -390,8 +389,7 @@ cleanup:
        input_device->report_desc = NULL;
 
        input_device->dev_info_status = -1;
-       input_device->device_wait_condition = 1;
-       wake_up(&input_device->dev_info_wait_event);
+       complete(&input_device->wait_event);
 }
 
 static void mousevsc_on_receive_input_report(struct mousevsc_dev *input_device,
@@ -442,8 +440,7 @@ static void mousevsc_on_receive(struct hv_device *device,
                memcpy(&input_dev->protocol_resp, pipe_msg,
                       pipe_msg->size + sizeof(struct pipe_prt_msg) -
                       sizeof(unsigned char));
-               input_dev->protocol_wait_condition = 1;
-               wake_up(&input_dev->protocol_wait_event);
+               complete(&input_dev->wait_event);
                break;
 
        case SynthHidInitialDeviceInfo:
@@ -541,7 +538,7 @@ static void mousevsc_on_channel_callback(void *context)
                } else if (ret == -ENOBUFS) {
                        /* Handle large packet */
                        bufferlen = bytes_recvd;
-                       buffer = kzalloc(bytes_recvd, GFP_KERNEL);
+                       buffer = kzalloc(bytes_recvd, GFP_ATOMIC);
 
                        if (buffer == NULL) {
                                buffer = packet;
@@ -563,6 +560,7 @@ static void mousevsc_on_channel_callback(void *context)
 static int mousevsc_connect_to_vsp(struct hv_device *device)
 {
        int ret = 0;
+       int t;
        struct mousevsc_dev *input_dev;
        struct mousevsc_prt_msg *request;
        struct mousevsc_prt_msg *response;
@@ -574,8 +572,6 @@ static int mousevsc_connect_to_vsp(struct hv_device *device)
                return -1;
        }
 
-       init_waitqueue_head(&input_dev->protocol_wait_event);
-       init_waitqueue_head(&input_dev->dev_info_wait_event);
 
        request = &input_dev->protocol_req;
 
@@ -588,7 +584,7 @@ static int mousevsc_connect_to_vsp(struct hv_device *device)
        request->size = sizeof(struct synthhid_protocol_request);
 
        request->request.header.type = SynthHidProtocolRequest;
-       request->request.header.size = sizeof(unsigned long);
+       request->request.header.size = sizeof(unsigned int);
        request->request.version_requested.version = SYNTHHID_INPUT_VERSION;
 
        pr_info("synthhid protocol request...");
@@ -605,10 +601,8 @@ static int mousevsc_connect_to_vsp(struct hv_device *device)
                goto cleanup;
        }
 
-       input_dev->protocol_wait_condition = 0;
-       wait_event_timeout(input_dev->protocol_wait_event,
-               input_dev->protocol_wait_condition, msecs_to_jiffies(1000));
-       if (input_dev->protocol_wait_condition == 0) {
+       t = wait_for_completion_timeout(&input_dev->wait_event, 5*HZ);
+       if (t == 0) {
                ret = -ETIMEDOUT;
                goto cleanup;
        }
@@ -622,10 +616,8 @@ static int mousevsc_connect_to_vsp(struct hv_device *device)
                goto cleanup;
        }
 
-       input_dev->device_wait_condition = 0;
-       wait_event_timeout(input_dev->dev_info_wait_event,
-               input_dev->device_wait_condition, msecs_to_jiffies(1000));
-       if (input_dev->device_wait_condition == 0) {
+       t = wait_for_completion_timeout(&input_dev->wait_event, 5*HZ);
+       if (t == 0) {
                ret = -ETIMEDOUT;
                goto cleanup;
        }
@@ -654,56 +646,45 @@ static void mousevsc_hid_close(struct hid_device *hid)
 {
 }
 
+static struct hid_ll_driver mousevsc_ll_driver = {
+       .open = mousevsc_hid_open,
+       .close = mousevsc_hid_close,
+};
+
+static struct hid_driver mousevsc_hid_driver;
+
 static void reportdesc_callback(struct hv_device *dev, void *packet, u32 len)
 {
        struct hid_device *hid_dev;
        struct mousevsc_dev *input_device = hv_get_drvdata(dev);
 
-       /* hid_debug = -1; */
-       hid_dev = kmalloc(sizeof(struct hid_device), GFP_KERNEL);
+       hid_dev = hid_allocate_device();
+       if (IS_ERR(hid_dev))
+               return;
+
+       hid_dev->ll_driver = &mousevsc_ll_driver;
+       hid_dev->driver = &mousevsc_hid_driver;
 
        if (hid_parse_report(hid_dev, packet, len)) {
                DPRINT_INFO(INPUTVSC_DRV, "Unable to call hd_parse_report");
                return;
        }
 
-       if (hid_dev) {
-               DPRINT_INFO(INPUTVSC_DRV, "hid_device created");
-
-               hid_dev->ll_driver->open  = mousevsc_hid_open;
-               hid_dev->ll_driver->close = mousevsc_hid_close;
+       hid_dev->bus = BUS_VIRTUAL;
+       hid_dev->vendor = input_device->hid_dev_info.vendor;
+       hid_dev->product = input_device->hid_dev_info.product;
+       hid_dev->version = input_device->hid_dev_info.version;
 
-               hid_dev->bus = BUS_VIRTUAL;
-               hid_dev->vendor = input_device->hid_dev_info.vendor;
-               hid_dev->product = input_device->hid_dev_info.product;
-               hid_dev->version = input_device->hid_dev_info.version;
-               hid_dev->dev = dev->device;
+       sprintf(hid_dev->name, "%s", "Microsoft Vmbus HID-compliant Mouse");
 
-               sprintf(hid_dev->name, "%s",
-                       "Microsoft Vmbus HID-compliant Mouse");
+       if (!hidinput_connect(hid_dev, 0)) {
+               hid_dev->claimed |= HID_CLAIMED_INPUT;
 
-               /*
-                * HJ Do we want to call it with a 0
-                */
-               if (!hidinput_connect(hid_dev, 0)) {
-                       hid_dev->claimed |= HID_CLAIMED_INPUT;
-
-                       input_device->connected = 1;
-
-                       DPRINT_INFO(INPUTVSC_DRV,
-                                    "HID device claimed by input\n");
-               }
-
-               if (!hid_dev->claimed) {
-                       DPRINT_ERR(INPUTVSC_DRV,
-                                   "HID device not claimed by "
-                                   "input or hiddev\n");
-               }
+               input_device->connected = 1;
 
-               input_device->hid_device = hid_dev;
        }
 
-       kfree(hid_dev);
+       input_device->hid_device = hid_dev;
 }
 
 static int mousevsc_on_device_add(struct hv_device *device,
@@ -833,6 +814,7 @@ static int mousevsc_remove(struct hv_device *dev)
        if (input_dev->connected) {
                hidinput_disconnect(input_dev->hid_device);
                input_dev->connected = 0;
+               hid_destroy_device(input_dev->hid_device);
        }
 
        /*