]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - drivers/staging/udlfb/udlfb.c
Merge branch 'staging-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh...
[mv-sheeva.git] / drivers / staging / udlfb / udlfb.c
index 6977b71e8c3c83ebc15c3a56e7c6fcb84bd2ecb6..fed25105970a94d06ca185fa81603f79968d67f8 100644 (file)
@@ -27,7 +27,6 @@
 #include <linux/slab.h>
 #include <linux/delay.h>
 
-
 #include "udlfb.h"
 
 static struct fb_fix_screeninfo dlfb_fix = {
@@ -59,19 +58,9 @@ static struct usb_device_id id_table[] = {
 };
 MODULE_DEVICE_TABLE(usb, id_table);
 
-#ifndef CONFIG_FB_DEFERRED_IO
-#warning Please set CONFIG_FB_DEFFERRED_IO option to support generic fbdev apps
-#endif
-
-#ifndef CONFIG_FB_SYS_IMAGEBLIT
-#ifndef CONFIG_FB_SYS_IMAGEBLIT_MODULE
-#warning Please set CONFIG_FB_SYS_IMAGEBLIT option to support fb console
-#endif
-#endif
-
-#ifndef CONFIG_FB_MODE_HELPERS
-#warning CONFIG_FB_MODE_HELPERS required. Expect build break
-#endif
+/* module options */
+static int console;   /* Optionally allow fbcon to consume first framebuffer */
+static int fb_defio;  /* Optionally enable experimental fb_defio mmap support */
 
 /* dlfb keeps a list of urbs for efficient bulk transfers */
 static void dlfb_urb_completion(struct urb *urb);
@@ -80,11 +69,6 @@ static int dlfb_submit_urb(struct dlfb_data *dev, struct urb * urb, size_t len);
 static int dlfb_alloc_urb_list(struct dlfb_data *dev, int count, size_t size);
 static void dlfb_free_urb_list(struct dlfb_data *dev);
 
-/* other symbols with dependents */
-#ifdef CONFIG_FB_DEFERRED_IO
-static struct fb_deferred_io dlfb_defio;
-#endif
-
 /*
  * All DisplayLink bulk operations start with 0xAF, followed by specific code
  * All operations are written to buffers which then later get sent to device
@@ -271,6 +255,7 @@ static int dlfb_set_video_mode(struct dlfb_data *dev,
        urb = dlfb_get_urb(dev);
        if (!urb)
                return -ENOMEM;
+
        buf = (char *) urb->transfer_buffer;
 
        /*
@@ -303,13 +288,14 @@ static int dlfb_ops_mmap(struct fb_info *info, struct vm_area_struct *vma)
        unsigned long offset = vma->vm_pgoff << PAGE_SHIFT;
        unsigned long page, pos;
 
-       dl_notice("MMAP: %lu %u\n", offset + size, info->fix.smem_len);
-
        if (offset + size > info->fix.smem_len)
                return -EINVAL;
 
        pos = (unsigned long)info->fix.smem_start + offset;
 
+       dl_notice("mmap() framebuffer addr:%lu size:%lu\n",
+                 pos, size);
+
        while (size > 0) {
                page = vmalloc_to_pfn((void *)pos);
                if (remap_pfn_range(vma, start, page, PAGE_SIZE, PAGE_SHARED))
@@ -325,7 +311,6 @@ static int dlfb_ops_mmap(struct fb_info *info, struct vm_area_struct *vma)
 
        vma->vm_flags |= VM_RESERVED;   /* avoid to swap out this VMA */
        return 0;
-
 }
 
 /*
@@ -387,13 +372,13 @@ static int dlfb_trim_hline(const u8 *bback, const u8 **bfront, int *width_bytes)
  * A single command can transmit a maximum of 256 pixels,
  * regardless of the compression ratio (protocol design limit).
  * To the hardware, 0 for a size byte means 256
- * 
+ *
  * Rather than 256 pixel commands which are either rl or raw encoded,
  * the rlx command simply assumes alternating raw and rl spans within one cmd.
  * This has a slightly larger header overhead, but produces more even results.
  * It also processes all data (read and write) in a single pass.
  * Performance benchmarks of common cases show it having just slightly better
- * compression than 256 pixel raw -or- rle commands, with similar CPU consumpion.
+ * compression than 256 pixel raw or rle commands, with similar CPU consumpion.
  * But for very rl friendly data, will compress not quite as well.
  */
 static void dlfb_compress_hline(
@@ -414,15 +399,14 @@ static void dlfb_compress_hline(
                uint8_t *cmd_pixels_count_byte = 0;
                const uint16_t *raw_pixel_start = 0;
                const uint16_t *cmd_pixel_start, *cmd_pixel_end = 0;
-               const uint32_t be_dev_addr = cpu_to_be32(dev_addr);
 
                prefetchw((void *) cmd); /* pull in one cache line at least */
 
                *cmd++ = 0xAF;
                *cmd++ = 0x6B;
-               *cmd++ = (uint8_t) ((be_dev_addr >> 8) & 0xFF);
-               *cmd++ = (uint8_t) ((be_dev_addr >> 16) & 0xFF);
-               *cmd++ = (uint8_t) ((be_dev_addr >> 24) & 0xFF);
+               *cmd++ = (uint8_t) ((dev_addr >> 16) & 0xFF);
+               *cmd++ = (uint8_t) ((dev_addr >> 8) & 0xFF);
+               *cmd++ = (uint8_t) ((dev_addr) & 0xFF);
 
                cmd_pixels_count_byte = cmd++; /*  we'll know this later */
                cmd_pixel_start = pixel;
@@ -492,7 +476,7 @@ static void dlfb_compress_hline(
  * (that we can only write to, slowly, and can never read), and (optionally)
  * our shadow copy that tracks what's been sent to that hardware buffer.
  */
-static void dlfb_render_hline(struct dlfb_data *dev, struct urb **urb_ptr,
+static int dlfb_render_hline(struct dlfb_data *dev, struct urb **urb_ptr,
                              const char *front, char **urb_buf_ptr,
                              u32 byte_offset, u32 byte_width,
                              int *ident_ptr, int *sent_ptr)
@@ -534,11 +518,11 @@ static void dlfb_render_hline(struct dlfb_data *dev, struct urb **urb_ptr,
                if (cmd >= cmd_end) {
                        int len = cmd - (u8 *) urb->transfer_buffer;
                        if (dlfb_submit_urb(dev, urb, len))
-                               return; /* lost pixels is set */
+                               return 1; /* lost pixels is set */
                        *sent_ptr += len;
                        urb = dlfb_get_urb(dev);
                        if (!urb)
-                               return; /* lost_pixels is set */
+                               return 1; /* lost_pixels is set */
                        *urb_ptr = urb;
                        cmd = urb->transfer_buffer;
                        cmd_end = &cmd[urb->transfer_buffer_length];
@@ -546,6 +530,8 @@ static void dlfb_render_hline(struct dlfb_data *dev, struct urb **urb_ptr,
        }
 
        *urb_buf_ptr = cmd;
+
+       return 0;
 }
 
 int dlfb_handle_damage(struct dlfb_data *dev, int x, int y,
@@ -582,9 +568,11 @@ int dlfb_handle_damage(struct dlfb_data *dev, int x, int y,
                const int line_offset = dev->info->fix.line_length * i;
                const int byte_offset = line_offset + (x * BPP);
 
-               dlfb_render_hline(dev, &urb, (char *) dev->info->fix.smem_start,
-                                 &cmd, byte_offset, width * BPP,
-                                 &bytes_identical, &bytes_sent);
+               if (dlfb_render_hline(dev, &urb,
+                                     (char *) dev->info->fix.smem_start,
+                                     &cmd, byte_offset, width * BPP,
+                                     &bytes_identical, &bytes_sent))
+                       goto error;
        }
 
        if (cmd > (char *) urb->transfer_buffer) {
@@ -595,6 +583,7 @@ int dlfb_handle_damage(struct dlfb_data *dev, int x, int y,
        } else
                dlfb_urb_completion(urb);
 
+error:
        atomic_add(bytes_sent, &dev->bytes_sent);
        atomic_add(bytes_identical, &dev->bytes_identical);
        atomic_add(width*height*2, &dev->bytes_rendered);
@@ -696,6 +685,70 @@ static void dlfb_ops_fillrect(struct fb_info *info,
 
 }
 
+#ifdef CONFIG_FB_DEFERRED_IO
+/*
+ * NOTE: fb_defio.c is holding info->fbdefio.mutex
+ *   Touching ANY framebuffer memory that triggers a page fault
+ *   in fb_defio will cause a deadlock, when it also tries to
+ *   grab the same mutex.
+ */
+static void dlfb_dpy_deferred_io(struct fb_info *info,
+                               struct list_head *pagelist)
+{
+       struct page *cur;
+       struct fb_deferred_io *fbdefio = info->fbdefio;
+       struct dlfb_data *dev = info->par;
+       struct urb *urb;
+       char *cmd;
+       cycles_t start_cycles, end_cycles;
+       int bytes_sent = 0;
+       int bytes_identical = 0;
+       int bytes_rendered = 0;
+
+       if (!fb_defio)
+               return;
+
+       if (!atomic_read(&dev->usb_active))
+               return;
+
+       start_cycles = get_cycles();
+
+       urb = dlfb_get_urb(dev);
+       if (!urb)
+               return;
+
+       cmd = urb->transfer_buffer;
+
+       /* walk the written page list and render each to device */
+       list_for_each_entry(cur, &fbdefio->pagelist, lru) {
+
+               if (dlfb_render_hline(dev, &urb, (char *) info->fix.smem_start,
+                                 &cmd, cur->index << PAGE_SHIFT,
+                                 PAGE_SIZE, &bytes_identical, &bytes_sent))
+                       goto error;
+               bytes_rendered += PAGE_SIZE;
+       }
+
+       if (cmd > (char *) urb->transfer_buffer) {
+               /* Send partial buffer remaining before exiting */
+               int len = cmd - (char *) urb->transfer_buffer;
+               dlfb_submit_urb(dev, urb, len);
+               bytes_sent += len;
+       } else
+               dlfb_urb_completion(urb);
+
+error:
+       atomic_add(bytes_sent, &dev->bytes_sent);
+       atomic_add(bytes_identical, &dev->bytes_identical);
+       atomic_add(bytes_rendered, &dev->bytes_rendered);
+       end_cycles = get_cycles();
+       atomic_add(((unsigned int) ((end_cycles - start_cycles)
+                   >> 10)), /* Kcycles */
+                  &dev->cpu_kcycles_used);
+}
+
+#endif
+
 static int dlfb_get_edid(struct dlfb_data *dev, char *edid, int len)
 {
        int i;
@@ -745,6 +798,16 @@ static int dlfb_ops_ioctl(struct fb_info *info, unsigned int cmd,
        /* TODO: Help propose a standard fb.h ioctl to report mmap damage */
        if (cmd == DLFB_IOCTL_REPORT_DAMAGE) {
 
+               /*
+                * If we have a damage-aware client, turn fb_defio "off"
+                * To avoid perf imact of unecessary page fault handling.
+                * Done by resetting the delay for this fb_info to a very
+                * long period. Pages will become writable and stay that way.
+                * Reset to normal value when all clients have closed this fb.
+                */
+               if (info->fbdefio)
+                       info->fbdefio->delay = DL_DEFIO_WRITE_DISABLE;
+
                area = (struct dloarea *)arg;
 
                if (area->x < 0)
@@ -759,8 +822,6 @@ static int dlfb_ops_ioctl(struct fb_info *info, unsigned int cmd,
                if (area->y > info->var.yres)
                        area->y = info->var.yres;
 
-               atomic_set(&dev->use_defio, 0);
-
                dlfb_handle_damage(dev, area->x, area->y, area->w, area->h,
                           info->screen_base);
        }
@@ -804,9 +865,13 @@ static int dlfb_ops_open(struct fb_info *info, int user)
 {
        struct dlfb_data *dev = info->par;
 
-/*     if (user == 0)
- *             We could special case kernel mode clients (fbcon) here
- */
+       /*
+        * fbcon aggressively connects to first framebuffer it finds,
+        * preventing other clients (X) from working properly. Usually
+        * not what the user wants. Fail by default with option to enable.
+        */
+       if ((user == 0) & (!console))
+               return -EBUSY;
 
        /* If the USB device is gone, we don't accept new opens */
        if (dev->virtualized)
@@ -817,9 +882,19 @@ static int dlfb_ops_open(struct fb_info *info, int user)
        kref_get(&dev->kref);
 
 #ifdef CONFIG_FB_DEFERRED_IO
-       if ((atomic_read(&dev->use_defio)) && (info->fbdefio == NULL)) {
-               /* enable defio */
-               info->fbdefio = &dlfb_defio;
+       if (fb_defio && (info->fbdefio == NULL)) {
+               /* enable defio at last moment if not disabled by client */
+
+               struct fb_deferred_io *fbdefio;
+
+               fbdefio = kmalloc(sizeof(struct fb_deferred_io), GFP_KERNEL);
+
+               if (fbdefio) {
+                       fbdefio->delay = DL_DEFIO_WRITE_DELAY;
+                       fbdefio->deferred_io = dlfb_dpy_deferred_io;
+               }
+
+               info->fbdefio = fbdefio;
                fb_deferred_io_init(info);
        }
 #endif
@@ -853,6 +928,13 @@ static void dlfb_free(struct kref *kref)
        kfree(dev);
 }
 
+static void dlfb_release_urb_work(struct work_struct *work)
+{
+       struct urb_node *unode = container_of(work, struct urb_node,
+                                             release_urb_work.work);
+
+       up(&unode->dev->urbs.limit_sem);
+}
 
 static void dlfb_free_framebuffer_work(struct work_struct *work)
 {
@@ -1307,51 +1389,51 @@ static ssize_t edid_show(
        return count;
 }
 
-
-static ssize_t metrics_reset_store(struct device *fbdev,
-                          struct device_attribute *attr,
-                          const char *buf, size_t count)
-{
+static ssize_t edid_store(
+                       struct file *filp,
+                       struct kobject *kobj, struct bin_attribute *a,
+                       char *src, loff_t src_off, size_t src_size) {
+       struct device *fbdev = container_of(kobj, struct device, kobj);
        struct fb_info *fb_info = dev_get_drvdata(fbdev);
        struct dlfb_data *dev = fb_info->par;
 
-       atomic_set(&dev->bytes_rendered, 0);
-       atomic_set(&dev->bytes_identical, 0);
-       atomic_set(&dev->bytes_sent, 0);
-       atomic_set(&dev->cpu_kcycles_used, 0);
+       /* We only support write of entire EDID at once, no offset*/
+       if ((src_size < MIN_EDID_SIZE) ||
+           (src_size > MAX_EDID_SIZE) ||
+           (src_off != 0))
+               return 0;
 
-       return count;
-}
+       dlfb_setup_modes(dev, fb_info, src, src_size);
 
-static ssize_t use_defio_show(struct device *fbdev,
-                                  struct device_attribute *a, char *buf) {
-       struct fb_info *fb_info = dev_get_drvdata(fbdev);
-       struct dlfb_data *dev = fb_info->par;
-       return snprintf(buf, PAGE_SIZE, "%d\n",
-                       atomic_read(&dev->use_defio));
+       if (dev->edid && (memcmp(src, dev->edid, src_size) == 0)) {
+               dl_info("sysfs written EDID is new default\n");
+               dlfb_ops_set_par(fb_info);
+               return src_size;
+       } else
+               return 0;
 }
 
-static ssize_t use_defio_store(struct device *fbdev,
+static ssize_t metrics_reset_store(struct device *fbdev,
                           struct device_attribute *attr,
                           const char *buf, size_t count)
 {
        struct fb_info *fb_info = dev_get_drvdata(fbdev);
        struct dlfb_data *dev = fb_info->par;
 
-       if (count > 0) {
-               if (buf[0] == '0')
-                       atomic_set(&dev->use_defio, 0);
-               if (buf[0] == '1')
-                       atomic_set(&dev->use_defio, 1);
-       }
+       atomic_set(&dev->bytes_rendered, 0);
+       atomic_set(&dev->bytes_identical, 0);
+       atomic_set(&dev->bytes_sent, 0);
+       atomic_set(&dev->cpu_kcycles_used, 0);
+
        return count;
 }
 
 static struct bin_attribute edid_attr = {
        .attr.name = "edid",
-       .attr.mode = 0444,
-       .size = 128,
+       .attr.mode = 0666,
+       .size = MAX_EDID_SIZE,
        .read = edid_show,
+       .write = edid_store
 };
 
 static struct device_attribute fb_device_attrs[] = {
@@ -1360,68 +1442,8 @@ static struct device_attribute fb_device_attrs[] = {
        __ATTR_RO(metrics_bytes_sent),
        __ATTR_RO(metrics_cpu_kcycles_used),
        __ATTR(metrics_reset, S_IWUGO, NULL, metrics_reset_store),
-       __ATTR_RW(use_defio),
-};
-
-#ifdef CONFIG_FB_DEFERRED_IO
-static void dlfb_dpy_deferred_io(struct fb_info *info,
-                               struct list_head *pagelist)
-{
-       struct page *cur;
-       struct fb_deferred_io *fbdefio = info->fbdefio;
-       struct dlfb_data *dev = info->par;
-       struct urb *urb;
-       char *cmd;
-       cycles_t start_cycles, end_cycles;
-       int bytes_sent = 0;
-       int bytes_identical = 0;
-       int bytes_rendered = 0;
-
-       if (!atomic_read(&dev->use_defio))
-               return;
-
-       if (!atomic_read(&dev->usb_active))
-               return;
-
-       start_cycles = get_cycles();
-
-       urb = dlfb_get_urb(dev);
-       if (!urb)
-               return;
-       cmd = urb->transfer_buffer;
-
-       /* walk the written page list and render each to device */
-       list_for_each_entry(cur, &fbdefio->pagelist, lru) {
-               dlfb_render_hline(dev, &urb, (char *) info->fix.smem_start,
-                                 &cmd, cur->index << PAGE_SHIFT,
-                                 PAGE_SIZE, &bytes_identical, &bytes_sent);
-               bytes_rendered += PAGE_SIZE;
-       }
-
-       if (cmd > (char *) urb->transfer_buffer) {
-               /* Send partial buffer remaining before exiting */
-               int len = cmd - (char *) urb->transfer_buffer;
-               dlfb_submit_urb(dev, urb, len);
-               bytes_sent += len;
-       } else
-               dlfb_urb_completion(urb);
-
-       atomic_add(bytes_sent, &dev->bytes_sent);
-       atomic_add(bytes_identical, &dev->bytes_identical);
-       atomic_add(bytes_rendered, &dev->bytes_rendered);
-       end_cycles = get_cycles();
-       atomic_add(((unsigned int) ((end_cycles - start_cycles)
-                   >> 10)), /* Kcycles */
-                  &dev->cpu_kcycles_used);
-}
-
-static struct fb_deferred_io dlfb_defio = {
-       .delay          = 5,
-       .deferred_io    = dlfb_dpy_deferred_io,
 };
 
-#endif
-
 /*
  * This is necessary before we can communicate with the display controller.
  */
@@ -1514,8 +1536,8 @@ static int dlfb_usb_probe(struct usb_interface *interface,
        struct usb_device *usbdev;
        struct dlfb_data *dev = 0;
        struct fb_info *info = 0;
-       int i;
        int retval = -ENOMEM;
+       int i;
 
        /* usb initialization */
 
@@ -1540,6 +1562,8 @@ static int dlfb_usb_probe(struct usb_interface *interface,
        dl_info("vid_%04x&pid_%04x&rev_%04x driver's dlfb_data struct at %p\n",
                usbdev->descriptor.idVendor, usbdev->descriptor.idProduct,
                usbdev->descriptor.bcdDevice, dev);
+       dl_info("console enable=%d\n", console);
+       dl_info("fb_defio enable=%d\n", fb_defio);
 
        dev->sku_pixel_limit = 2048 * 1152; /* default to maximum */
 
@@ -1588,9 +1612,6 @@ static int dlfb_usb_probe(struct usb_interface *interface,
 
        /* ready to begin using device */
 
-#ifdef CONFIG_FB_DEFERRED_IO
-       atomic_set(&dev->use_defio, 1);
-#endif
        atomic_set(&dev->usb_active, 1);
        dlfb_select_std_channel(dev);
 
@@ -1729,7 +1750,14 @@ static void dlfb_urb_completion(struct urb *urb)
        dev->urbs.available++;
        spin_unlock_irqrestore(&dev->urbs.lock, flags);
 
-       up(&dev->urbs.limit_sem);
+       /*
+        * When using fb_defio, we deadlock if up() is called
+        * while another is waiting. So queue to another process.
+        */
+       if (fb_defio)
+               schedule_delayed_work(&unode->release_urb_work, 0);
+       else
+               up(&dev->urbs.limit_sem);
 }
 
 static void dlfb_free_urb_list(struct dlfb_data *dev)
@@ -1788,6 +1816,9 @@ static int dlfb_alloc_urb_list(struct dlfb_data *dev, int count, size_t size)
                        break;
                unode->dev = dev;
 
+               INIT_DELAYED_WORK(&unode->release_urb_work,
+                         dlfb_release_urb_work);
+
                urb = usb_alloc_urb(0, GFP_KERNEL);
                if (!urb) {
                        kfree(unode);
@@ -1834,7 +1865,8 @@ static struct urb *dlfb_get_urb(struct dlfb_data *dev)
        ret = down_timeout(&dev->urbs.limit_sem, GET_URB_TIMEOUT);
        if (ret) {
                atomic_set(&dev->lost_pixels, 1);
-               dl_err("wait for urb interrupted: %x\n", ret);
+               dl_warn("wait for urb interrupted: %x available: %d\n",
+                      ret, dev->urbs.available);
                goto error;
        }
 
@@ -1870,6 +1902,12 @@ static int dlfb_submit_urb(struct dlfb_data *dev, struct urb *urb, size_t len)
        return ret;
 }
 
+module_param(console, bool, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP);
+MODULE_PARM_DESC(console, "Allow fbcon to consume first framebuffer found");
+
+module_param(fb_defio, bool, S_IWUSR | S_IRUSR | S_IWGRP | S_IRGRP);
+MODULE_PARM_DESC(fb_defio, "Enable fb_defio mmap support. *Experimental*");
+
 MODULE_AUTHOR("Roberto De Ioris <roberto@unbit.it>, "
              "Jaya Kumar <jayakumar.lkml@gmail.com>, "
              "Bernie Thompson <bernie@plugable.com>");