static void uhci_free_td(struct uhci_hcd *uhci, struct uhci_td *td)
{
- if (!list_empty(&td->list))
- dev_WARN(uhci_dev(uhci), "td %p still in list!\n", td);
- if (!list_empty(&td->fl_list))
- dev_WARN(uhci_dev(uhci), "td %p still in fl_list!\n", td);
+ dev_WARN(uhci_dev(uhci), !list_empty(&td->list),
+ "td %p still in list!\n", td);
+
+ dev_WARN(uhci_dev(uhci), !list_empty(&td->fl_list),
+ "td %p still in fl_list!\n", td);
dma_pool_free(uhci->td_pool, td, td->dma_handle);
}
static void uhci_free_qh(struct uhci_hcd *uhci, struct uhci_qh *qh)
{
WARN_ON(qh->state != QH_STATE_IDLE && qh->udev);
- if (!list_empty(&qh->queue))
- dev_WARN(uhci_dev(uhci), "qh %p list not empty!\n", qh);
+
+ dev_WARN(uhci_dev(uhci), !list_empty(&qh->queue),
+ "qh %p list not empty!\n", qh);
list_del(&qh->node);
if (qh->udev) {
{
struct uhci_td *td, *tmp;
- if (!list_empty(&urbp->node))
- dev_WARN(uhci_dev(uhci), "urb %p still on QH's list!\n",
- urbp->urb);
+ dev_WARN(uhci_dev(uhci), !list_empty(&urbp->node),
+ "urb %p still on QH's list!\n",
+ urbp->urb);
list_for_each_entry_safe(td, tmp, &urbp->td_list, list) {
uhci_remove_td_from_urbp(td);