]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - fs/cifs/connect.c
cifs: temporarily rename cifs_sb->tcon to ptcon to catch stragglers
[mv-sheeva.git] / fs / cifs / connect.c
index 5f68b968faa7135a28077ff5aea78d5a4f77b6fc..b4bacea54626f9519d2fe5755842bdab60ecbfae 100644 (file)
@@ -47,7 +47,6 @@
 #include "ntlmssp.h"
 #include "nterr.h"
 #include "rfc1002pdu.h"
-#include "cn_cifs.h"
 #include "fscache.h"
 
 #define CIFS_PORT 445
@@ -100,11 +99,13 @@ struct smb_vol {
        bool noautotune:1;
        bool nostrictsync:1; /* do not force expensive SMBflush on every sync */
        bool fsc:1;     /* enable fscache */
+       bool mfsymlinks:1; /* use Minshall+French Symlinks */
        unsigned int rsize;
        unsigned int wsize;
        bool sockopt_tcp_nodelay:1;
        unsigned short int port;
        char *prepath;
+       struct sockaddr_storage srcaddr; /* allow binding to a local IP */
        struct nls_table *local_nls;
 };
 
@@ -416,14 +417,6 @@ incomplete_rcv:
                        } else
                                continue;
                } else if (length <= 0) {
-                       if (server->tcpStatus == CifsNew) {
-                               cFYI(1, "tcp session abend after SMBnegprot");
-                               /* some servers kill the TCP session rather than
-                                  returning an SMB negprot error, in which
-                                  case reconnecting here is not going to help,
-                                  and so simply return error to mount */
-                               break;
-                       }
                        cFYI(1, "Reconnect after unexpected peek error %d",
                                length);
                        cifs_reconnect(server);
@@ -464,27 +457,19 @@ incomplete_rcv:
                           an error on SMB negprot response */
                        cFYI(1, "Negative RFC1002 Session Response Error 0x%x)",
                                pdu_length);
-                       if (server->tcpStatus == CifsNew) {
-                               /* if nack on negprot (rather than
-                               ret of smb negprot error) reconnecting
-                               not going to help, ret error to mount */
-                               break;
-                       } else {
-                               /* give server a second to
-                               clean up before reconnect attempt */
-                               msleep(1000);
-                               /* always try 445 first on reconnect
-                               since we get NACK on some if we ever
-                               connected to port 139 (the NACK is
-                               since we do not begin with RFC1001
-                               session initialize frame) */
-                               server->addr.sockAddr.sin_port =
-                                       htons(CIFS_PORT);
-                               cifs_reconnect(server);
-                               csocket = server->ssocket;
-                               wake_up(&server->response_q);
-                               continue;
-                       }
+                       /* give server a second to clean up  */
+                       msleep(1000);
+                       /* always try 445 first on reconnect since we get NACK
+                        * on some if we ever connected to port 139 (the NACK
+                        * is since we do not begin with RFC1001 session
+                        * initialize frame)
+                        */
+                       cifs_set_port((struct sockaddr *)
+                                       &server->addr.sockAddr, CIFS_PORT);
+                       cifs_reconnect(server);
+                       csocket = server->ssocket;
+                       wake_up(&server->response_q);
+                       continue;
                } else if (temp != (char) 0) {
                        cERROR(1, "Unknown RFC 1002 frame");
                        cifs_dump_mem(" Received Data: ", (char *)smb_buffer,
@@ -1062,6 +1047,22 @@ cifs_parse_mount_options(char *options, const char *devname,
                                                    "long\n");
                                return 1;
                        }
+               } else if (strnicmp(data, "srcaddr", 7) == 0) {
+                       vol->srcaddr.ss_family = AF_UNSPEC;
+
+                       if (!value || !*value) {
+                               printk(KERN_WARNING "CIFS: srcaddr value"
+                                      " not specified.\n");
+                               return 1;       /* needs_arg; */
+                       }
+                       i = cifs_convert_address((struct sockaddr *)&vol->srcaddr,
+                                                value, strlen(value));
+                       if (i < 0) {
+                               printk(KERN_WARNING "CIFS:  Could not parse"
+                                      " srcaddr: %s\n",
+                                      value);
+                               return 1;
+                       }
                } else if (strnicmp(data, "prefixpath", 10) == 0) {
                        if (!value || !*value) {
                                printk(KERN_WARNING
@@ -1341,6 +1342,8 @@ cifs_parse_mount_options(char *options, const char *devname,
                                "/proc/fs/cifs/LookupCacheEnabled to 0\n");
                } else if (strnicmp(data, "fsc", 3) == 0) {
                        vol->fsc = true;
+               } else if (strnicmp(data, "mfsymlinks", 10) == 0) {
+                       vol->mfsymlinks = true;
                } else
                        printk(KERN_WARNING "CIFS: Unknown mount option %s\n",
                                                data);
@@ -1390,8 +1393,36 @@ cifs_parse_mount_options(char *options, const char *devname,
        return 0;
 }
 
+/** Returns true if srcaddr isn't specified and rhs isn't
+ * specified, or if srcaddr is specified and
+ * matches the IP address of the rhs argument.
+ */
 static bool
-match_address(struct TCP_Server_Info *server, struct sockaddr *addr)
+srcip_matches(struct sockaddr *srcaddr, struct sockaddr *rhs)
+{
+       switch (srcaddr->sa_family) {
+       case AF_UNSPEC:
+               return (rhs->sa_family == AF_UNSPEC);
+       case AF_INET: {
+               struct sockaddr_in *saddr4 = (struct sockaddr_in *)srcaddr;
+               struct sockaddr_in *vaddr4 = (struct sockaddr_in *)rhs;
+               return (saddr4->sin_addr.s_addr == vaddr4->sin_addr.s_addr);
+       }
+       case AF_INET6: {
+               struct sockaddr_in6 *saddr6 = (struct sockaddr_in6 *)srcaddr;
+               struct sockaddr_in6 *vaddr6 = (struct sockaddr_in6 *)&rhs;
+               return ipv6_addr_equal(&saddr6->sin6_addr, &vaddr6->sin6_addr);
+       }
+       default:
+               WARN_ON(1);
+               return false; /* don't expect to be here */
+       }
+}
+
+
+static bool
+match_address(struct TCP_Server_Info *server, struct sockaddr *addr,
+             struct sockaddr *srcaddr)
 {
        struct sockaddr_in *addr4 = (struct sockaddr_in *)addr;
        struct sockaddr_in6 *addr6 = (struct sockaddr_in6 *)addr;
@@ -1418,6 +1449,9 @@ match_address(struct TCP_Server_Info *server, struct sockaddr *addr)
                break;
        }
 
+       if (!srcip_matches(srcaddr, (struct sockaddr *)&server->srcaddr))
+               return false;
+
        return true;
 }
 
@@ -1476,16 +1510,8 @@ cifs_find_tcp_session(struct sockaddr *addr, struct smb_vol *vol)
 
        write_lock(&cifs_tcp_ses_lock);
        list_for_each_entry(server, &cifs_tcp_ses_list, tcp_ses_list) {
-               /*
-                * the demux thread can exit on its own while still in CifsNew
-                * so don't accept any sockets in that state. Since the
-                * tcpStatus never changes back to CifsNew it's safe to check
-                * for this without a lock.
-                */
-               if (server->tcpStatus == CifsNew)
-                       continue;
-
-               if (!match_address(server, addr))
+               if (!match_address(server, addr,
+                                  (struct sockaddr *)&vol->srcaddr))
                        continue;
 
                if (!match_security(server, vol))
@@ -1600,6 +1626,8 @@ cifs_get_tcp_session(struct smb_vol *volume_info)
         * no need to spinlock this init of tcpStatus or srv_count
         */
        tcp_ses->tcpStatus = CifsNew;
+       memcpy(&tcp_ses->srcaddr, &volume_info->srcaddr,
+              sizeof(tcp_ses->srcaddr));
        ++tcp_ses->srv_count;
 
        if (addr.ss_family == AF_INET6) {
@@ -1722,9 +1750,6 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
        if (ses) {
                cFYI(1, "Existing smb sess found (status=%d)", ses->status);
 
-               /* existing SMB ses has a server reference already */
-               cifs_put_tcp_session(server);
-
                mutex_lock(&ses->session_mutex);
                rc = cifs_negotiate_protocol(xid, ses);
                if (rc) {
@@ -1747,6 +1772,9 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
                        }
                }
                mutex_unlock(&ses->session_mutex);
+
+               /* existing SMB ses has a server reference already */
+               cifs_put_tcp_session(server);
                FreeXid(xid);
                return ses;
        }
@@ -1756,6 +1784,8 @@ cifs_get_smb_ses(struct TCP_Server_Info *server, struct smb_vol *volume_info)
        if (ses == NULL)
                goto get_ses_fail;
 
+       ses->tilen = 0;
+       ses->tiblob = NULL;
        /* new SMB session uses our server ref */
        ses->server = server;
        if (server->addr.sockAddr6.sin6_family == AF_INET6)
@@ -2013,6 +2043,33 @@ static void rfc1002mangle(char *target, char *source, unsigned int length)
 
 }
 
+static int
+bind_socket(struct TCP_Server_Info *server)
+{
+       int rc = 0;
+       if (server->srcaddr.ss_family != AF_UNSPEC) {
+               /* Bind to the specified local IP address */
+               struct socket *socket = server->ssocket;
+               rc = socket->ops->bind(socket,
+                                      (struct sockaddr *) &server->srcaddr,
+                                      sizeof(server->srcaddr));
+               if (rc < 0) {
+                       struct sockaddr_in *saddr4;
+                       struct sockaddr_in6 *saddr6;
+                       saddr4 = (struct sockaddr_in *)&server->srcaddr;
+                       saddr6 = (struct sockaddr_in6 *)&server->srcaddr;
+                       if (saddr6->sin6_family == AF_INET6)
+                               cERROR(1, "cifs: "
+                                      "Failed to bind to: %pI6c, error: %d\n",
+                                      &saddr6->sin6_addr, rc);
+                       else
+                               cERROR(1, "cifs: "
+                                      "Failed to bind to: %pI4, error: %d\n",
+                                      &saddr4->sin_addr.s_addr, rc);
+               }
+       }
+       return rc;
+}
 
 static int
 ipv4_connect(struct TCP_Server_Info *server)
@@ -2038,6 +2095,10 @@ ipv4_connect(struct TCP_Server_Info *server)
                cifs_reclassify_socket4(socket);
        }
 
+       rc = bind_socket(server);
+       if (rc < 0)
+               return rc;
+
        /* user overrode default port */
        if (server->addr.sockAddr.sin_port) {
                rc = socket->ops->connect(socket, (struct sockaddr *)
@@ -2200,6 +2261,10 @@ ipv6_connect(struct TCP_Server_Info *server)
                cifs_reclassify_socket6(socket);
        }
 
+       rc = bind_socket(server);
+       if (rc < 0)
+               return rc;
+
        /* user overrode default port */
        if (server->addr.sockAddr6.sin6_port) {
                rc = socket->ops->connect(socket,
@@ -2482,6 +2547,14 @@ static void setup_cifs_sb(struct smb_vol *pvolume_info,
                cFYI(1, "mounting share using direct i/o");
                cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_DIRECT_IO;
        }
+       if (pvolume_info->mfsymlinks) {
+               if (pvolume_info->sfu_emul) {
+                       cERROR(1,  "mount option mfsymlinks ignored if sfu "
+                                  "mount option is used");
+               } else {
+                       cifs_sb->mnt_cifs_flags |= CIFS_MOUNT_MF_SYMLINKS;
+               }
+       }
 
        if ((pvolume_info->cifs_acl) && (pvolume_info->dynperm))
                cERROR(1, "mount option dynperm ignored if cifsacl "
@@ -2654,7 +2727,7 @@ try_mount_again:
                goto remote_path_check;
        }
 
-       cifs_sb->tcon = tcon;
+       cifs_sb->ptcon = tcon;
 
        /* do not care if following two calls succeed - informational */
        if (!tcon->ipc) {
@@ -2953,10 +3026,10 @@ cifs_umount(struct super_block *sb, struct cifs_sb_info *cifs_sb)
        int rc = 0;
        char *tmp;
 
-       if (cifs_sb->tcon)
-               cifs_put_tcon(cifs_sb->tcon);
+       if (cifs_sb_tcon(cifs_sb))
+               cifs_put_tcon(cifs_sb_tcon(cifs_sb));
 
-       cifs_sb->tcon = NULL;
+       cifs_sb->ptcon = NULL;
        tmp = cifs_sb->prepath;
        cifs_sb->prepathlen = 0;
        cifs_sb->prepath = NULL;