]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - net/batman-adv/originator.c
batman-adv: initialise last_ttvn and tt_crc for the orig_node structure
[karo-tx-linux.git] / net / batman-adv / originator.c
index 0b9133022d2dd58f3f91d55940667ede6dab9e50..f3c3f620d1952eaab745a049cb5ed314f77529eb 100644 (file)
@@ -19,8 +19,6 @@
  *
  */
 
-/* increase the reference counter for this originator */
-
 #include "main.h"
 #include "originator.h"
 #include "hash.h"
@@ -39,6 +37,14 @@ static void start_purge_timer(struct bat_priv *bat_priv)
        queue_delayed_work(bat_event_workqueue, &bat_priv->orig_work, 1 * HZ);
 }
 
+/* returns 1 if they are the same originator */
+static int compare_orig(const struct hlist_node *node, const void *data2)
+{
+       const void *data1 = container_of(node, struct orig_node, hash_entry);
+
+       return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0);
+}
+
 int originator_init(struct bat_priv *bat_priv)
 {
        if (bat_priv->orig_hash)
@@ -56,23 +62,30 @@ err:
        return 0;
 }
 
-static void neigh_node_free_rcu(struct rcu_head *rcu)
+void neigh_node_free_ref(struct neigh_node *neigh_node)
 {
-       struct neigh_node *neigh_node;
-
-       neigh_node = container_of(rcu, struct neigh_node, rcu);
-       kfree(neigh_node);
+       if (atomic_dec_and_test(&neigh_node->refcount))
+               kfree_rcu(neigh_node, rcu);
 }
 
-void neigh_node_free_ref(struct neigh_node *neigh_node)
+/* increases the refcounter of a found router */
+struct neigh_node *orig_node_get_router(struct orig_node *orig_node)
 {
-       if (atomic_dec_and_test(&neigh_node->refcount))
-               call_rcu(&neigh_node->rcu, neigh_node_free_rcu);
+       struct neigh_node *router;
+
+       rcu_read_lock();
+       router = rcu_dereference(orig_node->router);
+
+       if (router && !atomic_inc_not_zero(&router->refcount))
+               router = NULL;
+
+       rcu_read_unlock();
+       return router;
 }
 
 struct neigh_node *create_neighbor(struct orig_node *orig_node,
                                   struct orig_node *orig_neigh_node,
-                                  uint8_t *neigh,
+                                  const uint8_t *neigh,
                                   struct hard_iface *if_incoming)
 {
        struct bat_priv *bat_priv = netdev_priv(if_incoming->soft_iface);
@@ -81,12 +94,13 @@ struct neigh_node *create_neighbor(struct orig_node *orig_node,
        bat_dbg(DBG_BATMAN, bat_priv,
                "Creating new last-hop neighbor of originator\n");
 
-       neigh_node = kzalloc(sizeof(struct neigh_node), GFP_ATOMIC);
+       neigh_node = kzalloc(sizeof(*neigh_node), GFP_ATOMIC);
        if (!neigh_node)
                return NULL;
 
        INIT_HLIST_NODE(&neigh_node->list);
        INIT_LIST_HEAD(&neigh_node->bonding_list);
+       spin_lock_init(&neigh_node->tq_lock);
 
        memcpy(neigh_node->addr, neigh, ETH_ALEN);
        neigh_node->orig_node = orig_neigh_node;
@@ -128,9 +142,10 @@ static void orig_node_free_rcu(struct rcu_head *rcu)
        spin_unlock_bh(&orig_node->neigh_list_lock);
 
        frag_list_free(&orig_node->frag_list);
-       hna_global_del_orig(orig_node->bat_priv, orig_node,
+       tt_global_del_orig(orig_node->bat_priv, orig_node,
                            "originator timed out");
 
+       kfree(orig_node->tt_buff);
        kfree(orig_node->bcast_own);
        kfree(orig_node->bcast_own_sum);
        kfree(orig_node);
@@ -177,7 +192,7 @@ void originator_free(struct bat_priv *bat_priv)
 
 /* this function finds or creates an originator entry for the given
  * address if it does not exits */
-struct orig_node *get_orig_node(struct bat_priv *bat_priv, uint8_t *addr)
+struct orig_node *get_orig_node(struct bat_priv *bat_priv, const uint8_t *addr)
 {
        struct orig_node *orig_node;
        int size;
@@ -190,7 +205,7 @@ struct orig_node *get_orig_node(struct bat_priv *bat_priv, uint8_t *addr)
        bat_dbg(DBG_BATMAN, bat_priv,
                "Creating new originator: %pM\n", addr);
 
-       orig_node = kzalloc(sizeof(struct orig_node), GFP_ATOMIC);
+       orig_node = kzalloc(sizeof(*orig_node), GFP_ATOMIC);
        if (!orig_node)
                return NULL;
 
@@ -199,14 +214,20 @@ struct orig_node *get_orig_node(struct bat_priv *bat_priv, uint8_t *addr)
        spin_lock_init(&orig_node->ogm_cnt_lock);
        spin_lock_init(&orig_node->bcast_seqno_lock);
        spin_lock_init(&orig_node->neigh_list_lock);
+       spin_lock_init(&orig_node->tt_buff_lock);
 
        /* extra reference for return */
        atomic_set(&orig_node->refcount, 2);
 
+       orig_node->tt_poss_change = false;
        orig_node->bat_priv = bat_priv;
        memcpy(orig_node->orig, addr, ETH_ALEN);
        orig_node->router = NULL;
-       orig_node->hna_buff = NULL;
+       orig_node->tt_crc = 0;
+       atomic_set(&orig_node->last_ttvn, 0);
+       orig_node->tt_buff = NULL;
+       orig_node->tt_buff_len = 0;
+       atomic_set(&orig_node->tt_size, 0);
        orig_node->bcast_seqno_reset = jiffies - 1
                                        - msecs_to_jiffies(RESET_PROTECTION_MS);
        orig_node->batman_seqno_reset = jiffies - 1
@@ -316,9 +337,7 @@ static bool purge_orig_node(struct bat_priv *bat_priv,
                if (purge_orig_neighbors(bat_priv, orig_node,
                                                        &best_neigh_node)) {
                        update_routes(bat_priv, orig_node,
-                                     best_neigh_node,
-                                     orig_node->hna_buff,
-                                     orig_node->hna_buff_len);
+                                     best_neigh_node);
                }
        }
 
@@ -389,29 +408,33 @@ int orig_seq_print_text(struct seq_file *seq, void *offset)
        struct hashtable_t *hash = bat_priv->orig_hash;
        struct hlist_node *node, *node_tmp;
        struct hlist_head *head;
+       struct hard_iface *primary_if;
        struct orig_node *orig_node;
-       struct neigh_node *neigh_node;
+       struct neigh_node *neigh_node, *neigh_node_tmp;
        int batman_count = 0;
        int last_seen_secs;
        int last_seen_msecs;
-       int i;
+       int i, ret = 0;
 
-       if ((!bat_priv->primary_if) ||
-           (bat_priv->primary_if->if_status != IF_ACTIVE)) {
-               if (!bat_priv->primary_if)
-                       return seq_printf(seq, "BATMAN mesh %s disabled - "
-                                    "please specify interfaces to enable it\n",
-                                    net_dev->name);
+       primary_if = primary_if_get_selected(bat_priv);
 
-               return seq_printf(seq, "BATMAN mesh %s "
-                                 "disabled - primary interface not active\n",
-                                 net_dev->name);
+       if (!primary_if) {
+               ret = seq_printf(seq, "BATMAN mesh %s disabled - "
+                                "please specify interfaces to enable it\n",
+                                net_dev->name);
+               goto out;
        }
 
-       seq_printf(seq, "[B.A.T.M.A.N. adv %s%s, MainIF/MAC: %s/%pM (%s)]\n",
-                  SOURCE_VERSION, REVISION_VERSION_STR,
-                  bat_priv->primary_if->net_dev->name,
-                  bat_priv->primary_if->net_dev->dev_addr, net_dev->name);
+       if (primary_if->if_status != IF_ACTIVE) {
+               ret = seq_printf(seq, "BATMAN mesh %s "
+                                "disabled - primary interface not active\n",
+                                net_dev->name);
+               goto out;
+       }
+
+       seq_printf(seq, "[B.A.T.M.A.N. adv %s, MainIF/MAC: %s/%pM (%s)]\n",
+                  SOURCE_VERSION, primary_if->net_dev->name,
+                  primary_if->net_dev->dev_addr, net_dev->name);
        seq_printf(seq, "  %-15s %s (%s/%i) %17s [%10s]: %20s ...\n",
                   "Originator", "last-seen", "#", TQ_MAX_VALUE, "Nexthop",
                   "outgoingIF", "Potential nexthops");
@@ -421,40 +444,47 @@ int orig_seq_print_text(struct seq_file *seq, void *offset)
 
                rcu_read_lock();
                hlist_for_each_entry_rcu(orig_node, node, head, hash_entry) {
-                       if (!orig_node->router)
+                       neigh_node = orig_node_get_router(orig_node);
+                       if (!neigh_node)
                                continue;
 
-                       if (orig_node->router->tq_avg == 0)
-                               continue;
+                       if (neigh_node->tq_avg == 0)
+                               goto next;
 
                        last_seen_secs = jiffies_to_msecs(jiffies -
                                                orig_node->last_valid) / 1000;
                        last_seen_msecs = jiffies_to_msecs(jiffies -
                                                orig_node->last_valid) % 1000;
 
-                       neigh_node = orig_node->router;
                        seq_printf(seq, "%pM %4i.%03is   (%3i) %pM [%10s]:",
                                   orig_node->orig, last_seen_secs,
                                   last_seen_msecs, neigh_node->tq_avg,
                                   neigh_node->addr,
                                   neigh_node->if_incoming->net_dev->name);
 
-                       hlist_for_each_entry_rcu(neigh_node, node_tmp,
+                       hlist_for_each_entry_rcu(neigh_node_tmp, node_tmp,
                                                 &orig_node->neigh_list, list) {
-                               seq_printf(seq, " %pM (%3i)", neigh_node->addr,
-                                               neigh_node->tq_avg);
+                               seq_printf(seq, " %pM (%3i)",
+                                          neigh_node_tmp->addr,
+                                          neigh_node_tmp->tq_avg);
                        }
 
                        seq_printf(seq, "\n");
                        batman_count++;
+
+next:
+                       neigh_node_free_ref(neigh_node);
                }
                rcu_read_unlock();
        }
 
-       if ((batman_count == 0))
+       if (batman_count == 0)
                seq_printf(seq, "No batman nodes in range ...\n");
 
-       return 0;
+out:
+       if (primary_if)
+               hardif_free_ref(primary_if);
+       return ret;
 }
 
 static int orig_node_add_if(struct orig_node *orig_node, int max_if_num)
@@ -541,7 +571,7 @@ static int orig_node_del_if(struct orig_node *orig_node,
        memcpy(data_ptr, orig_node->bcast_own, del_if_num * chunk_size);
 
        /* copy second part */
-       memcpy(data_ptr + del_if_num * chunk_size,
+       memcpy((char *)data_ptr + del_if_num * chunk_size,
               orig_node->bcast_own + ((del_if_num + 1) * chunk_size),
               (max_if_num - del_if_num) * chunk_size);
 
@@ -561,7 +591,7 @@ free_bcast_own:
        memcpy(data_ptr, orig_node->bcast_own_sum,
               del_if_num * sizeof(uint8_t));
 
-       memcpy(data_ptr + del_if_num * sizeof(uint8_t),
+       memcpy((char *)data_ptr + del_if_num * sizeof(uint8_t),
               orig_node->bcast_own_sum + ((del_if_num + 1) * sizeof(uint8_t)),
               (max_if_num - del_if_num) * sizeof(uint8_t));