Merge branch 'master' of master.kernel.org:/pub/scm/linux/kernel/git/davem/net-2.6

[mv-sheeva.git] / net / bridge / br_multicast.c

diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 326e599f83fb2a8fa80b55a46819e708f7040a14..f03e2e98cd44fdfa0e7328b50bda742d075032f4 100644 (file)
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -445,7 +445,7 @@ static struct sk_buff *br_ip6_multicast_alloc_query(struct net_bridge *br,
        ip6h = ipv6_hdr(skb);
 
        *(__force __be32 *)ip6h = htonl(0x60000000);
-       ip6h->payload_len = 8 + sizeof(*mldq);
+       ip6h->payload_len = htons(8 + sizeof(*mldq));
        ip6h->nexthdr = IPPROTO_HOPOPTS;
        ip6h->hop_limit = 1;
        ipv6_addr_set(&ip6h->saddr, 0, 0, 0, 0);
@@ -654,11 +654,13 @@ static struct net_bridge_mdb_entry *br_multicast_new_group(
        struct net_bridge_mdb_htable *mdb;
        struct net_bridge_mdb_entry *mp;
        int hash;
+       int err;
 
        mdb = rcu_dereference_protected(br->mdb, 1);
        if (!mdb) {
-               if (br_mdb_rehash(&br->mdb, BR_HASH_SIZE, 0))
-                       return NULL;
+               err = br_mdb_rehash(&br->mdb, BR_HASH_SIZE, 0);
+               if (err)
+                       return ERR_PTR(err);
                goto rehash;
        }
 
@@ -680,7 +682,7 @@ rehash:
 
        mp = kzalloc(sizeof(*mp), GFP_ATOMIC);
        if (unlikely(!mp))
-               goto out;
+               return ERR_PTR(-ENOMEM);
 
        mp->br = br;
        mp->addr = *group;
@@ -713,7 +715,7 @@ static int br_multicast_add_group(struct net_bridge *br,
 
        mp = br_multicast_new_group(br, port, group);
        err = PTR_ERR(mp);
-       if (unlikely(IS_ERR(mp) || !mp))
+       if (IS_ERR(mp))
                goto err;
 
        if (!port) {