[NET]: Fix incorrect sg_mark_end() calls.

[mv-sheeva.git] / net / ipv6 / esp6.c

diff --git a/net/ipv6/esp6.c b/net/ipv6/esp6.c
index 7355bb0345e2b76d288bb63f6d47157a314a27d6..7db66f10e00d18f80d705fd83459ac5aec43f327 100644 (file)
--- a/net/ipv6/esp6.c
+++ b/net/ipv6/esp6.c
@@ -29,7 +29,7 @@
 #include <net/ip.h>
 #include <net/xfrm.h>
 #include <net/esp.h>
-#include <asm/scatterlist.h>
+#include <linux/scatterlist.h>
 #include <linux/crypto.h>
 #include <linux/kernel.h>
 #include <linux/pfkeyv2.h>
@@ -43,8 +43,7 @@
 static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
 {
        int err;
-       struct ipv6hdr *top_iph;
-       struct ipv6_esp_hdr *esph;
+       struct ip_esp_hdr *esph;
        struct crypto_blkcipher *tfm;
        struct blkcipher_desc desc;
        struct sk_buff *trailer;
@@ -54,13 +53,8 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
        int nfrags;
        u8 *tail;
        struct esp_data *esp = x->data;
-       int hdr_len = (skb_transport_offset(skb) +
-                      sizeof(*esph) + esp->conf.ivlen);
 
-       /* Strip IP+ESP header. */
-       __skb_pull(skb, hdr_len);
-
-       /* Now skb is pure payload to encrypt */
+       /* skb is pure payload to encrypt */
        err = -ENOMEM;
 
        /* Round to block size */
@@ -89,10 +83,8 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
        tail[clen-skb->len - 2] = (clen - skb->len) - 2;
        pskb_put(skb, trailer, clen - skb->len);
 
-       __skb_push(skb, -skb_network_offset(skb));
-       top_iph = ipv6_hdr(skb);
-       esph = (struct ipv6_esp_hdr *)skb_transport_header(skb);
-       top_iph->payload_len = htons(skb->len + alen - sizeof(*top_iph));
+       skb_push(skb, -skb_network_offset(skb));
+       esph = ip_esp_hdr(skb);
        *(skb_tail_pointer(trailer) - 1) = *skb_mac_header(skb);
        *skb_mac_header(skb) = IPPROTO_ESP;
 
@@ -117,7 +109,11 @@ static int esp6_output(struct xfrm_state *x, struct sk_buff *skb)
                        if (!sg)
                                goto unlock;
                }
-               skb_to_sgvec(skb, sg, esph->enc_data+esp->conf.ivlen-skb->data, clen);
+               sg_init_table(sg, nfrags);
+               skb_to_sgvec(skb, sg,
+                            esph->enc_data +
+                            esp->conf.ivlen -
+                            skb->data, clen);
                err = crypto_blkcipher_encrypt(&desc, sg, sg, clen);
                if (unlikely(sg != &esp->sgbuf[0]))
                        kfree(sg);
@@ -147,19 +143,19 @@ error:
 static int esp6_input(struct xfrm_state *x, struct sk_buff *skb)
 {
        struct ipv6hdr *iph;
-       struct ipv6_esp_hdr *esph;
+       struct ip_esp_hdr *esph;
        struct esp_data *esp = x->data;
        struct crypto_blkcipher *tfm = esp->conf.tfm;
        struct blkcipher_desc desc = { .tfm = tfm };
        struct sk_buff *trailer;
        int blksize = ALIGN(crypto_blkcipher_blocksize(tfm), 4);
        int alen = esp->auth.icv_trunc_len;
-       int elen = skb->len - sizeof(struct ipv6_esp_hdr) - esp->conf.ivlen - alen;
+       int elen = skb->len - sizeof(*esph) - esp->conf.ivlen - alen;
        int hdr_len = skb_network_header_len(skb);
        int nfrags;
        int ret = 0;
 
-       if (!pskb_may_pull(skb, sizeof(struct ipv6_esp_hdr))) {
+       if (!pskb_may_pull(skb, sizeof(*esph))) {
                ret = -EINVAL;
                goto out;
        }
@@ -194,7 +190,7 @@ static int esp6_input(struct xfrm_state *x, struct sk_buff *skb)
 
        skb->ip_summed = CHECKSUM_NONE;
 
-       esph = (struct ipv6_esp_hdr*)skb->data;
+       esph = (struct ip_esp_hdr *)skb->data;
        iph = ipv6_hdr(skb);
 
        /* Get ivec. This can be wrong, check against another impls. */
@@ -213,7 +209,10 @@ static int esp6_input(struct xfrm_state *x, struct sk_buff *skb)
                                goto out;
                        }
                }
-               skb_to_sgvec(skb, sg, sizeof(struct ipv6_esp_hdr) + esp->conf.ivlen, elen);
+               sg_init_table(sg, nfrags);
+               skb_to_sgvec(skb, sg,
+                            sizeof(*esph) + esp->conf.ivlen,
+                            elen);
                ret = crypto_blkcipher_decrypt(&desc, sg, sg, elen);
                if (unlikely(sg != &esp->sgbuf[0]))
                        kfree(sg);
@@ -265,7 +264,7 @@ static void esp6_err(struct sk_buff *skb, struct inet6_skb_parm *opt,
                     int type, int code, int offset, __be32 info)
 {
        struct ipv6hdr *iph = (struct ipv6hdr*)skb->data;
-       struct ipv6_esp_hdr *esph = (struct ipv6_esp_hdr*)(skb->data+offset);
+       struct ip_esp_hdr *esph = (struct ip_esp_hdr *)(skb->data + offset);
        struct xfrm_state *x;
 
        if (type != ICMPV6_DEST_UNREACH &&
@@ -361,9 +360,17 @@ static int esp6_init_state(struct xfrm_state *x)
        if (crypto_blkcipher_setkey(tfm, x->ealg->alg_key,
                                    (x->ealg->alg_key_len + 7) / 8))
                goto error;
-       x->props.header_len = sizeof(struct ipv6_esp_hdr) + esp->conf.ivlen;
-       if (x->props.mode == XFRM_MODE_TUNNEL)
+       x->props.header_len = sizeof(struct ip_esp_hdr) + esp->conf.ivlen;
+       switch (x->props.mode) {
+       case XFRM_MODE_BEET:
+       case XFRM_MODE_TRANSPORT:
+               break;
+       case XFRM_MODE_TUNNEL:
                x->props.header_len += sizeof(struct ipv6hdr);
+               break;
+       default:
+               goto error;
+       }
        x->data = esp;
        return 0;