]> git.karo-electronics.de Git - karo-tx-linux.git/blobdiff - net/mac80211/status.c
nl80211: correctly validate MU-MIMO groups
[karo-tx-linux.git] / net / mac80211 / status.c
index 83b8b11f24ea1dadc0501bd8a4c15598195524a2..be47ac5cd8c8dd44a23247979f0d1742cf089026 100644 (file)
@@ -200,6 +200,7 @@ static void ieee80211_frame_acked(struct sta_info *sta, struct sk_buff *skb)
        }
 
        if (ieee80211_is_action(mgmt->frame_control) &&
+           !ieee80211_has_protected(mgmt->frame_control) &&
            mgmt->u.action.category == WLAN_CATEGORY_HT &&
            mgmt->u.action.u.ht_smps.action == WLAN_HT_ACTION_SMPS &&
            ieee80211_sdata_running(sdata)) {
@@ -630,61 +631,6 @@ static int ieee80211_tx_get_rates(struct ieee80211_hw *hw,
        return rates_idx;
 }
 
-void ieee80211_tx_status_noskb(struct ieee80211_hw *hw,
-                              struct ieee80211_sta *pubsta,
-                              struct ieee80211_tx_info *info)
-{
-       struct ieee80211_local *local = hw_to_local(hw);
-       struct ieee80211_supported_band *sband;
-       int retry_count;
-       bool acked, noack_success;
-
-       ieee80211_tx_get_rates(hw, info, &retry_count);
-
-       sband = hw->wiphy->bands[info->band];
-
-       acked = !!(info->flags & IEEE80211_TX_STAT_ACK);
-       noack_success = !!(info->flags & IEEE80211_TX_STAT_NOACK_TRANSMITTED);
-
-       if (pubsta) {
-               struct sta_info *sta;
-
-               sta = container_of(pubsta, struct sta_info, sta);
-
-               if (!acked)
-                       sta->status_stats.retry_failed++;
-               sta->status_stats.retry_count += retry_count;
-
-               if (acked) {
-                       sta->status_stats.last_ack = jiffies;
-
-                       if (sta->status_stats.lost_packets)
-                               sta->status_stats.lost_packets = 0;
-
-                       /* Track when last TDLS packet was ACKed */
-                       if (test_sta_flag(sta, WLAN_STA_TDLS_PEER_AUTH))
-                               sta->status_stats.last_tdls_pkt_time = jiffies;
-               } else {
-                       ieee80211_lost_packet(sta, info);
-               }
-
-               rate_control_tx_status_noskb(local, sband, sta, info);
-       }
-
-       if (acked || noack_success) {
-               I802_DEBUG_INC(local->dot11TransmittedFrameCount);
-               if (!pubsta)
-                       I802_DEBUG_INC(local->dot11MulticastTransmittedFrameCount);
-               if (retry_count > 0)
-                       I802_DEBUG_INC(local->dot11RetryCount);
-               if (retry_count > 1)
-                       I802_DEBUG_INC(local->dot11MultipleRetryCount);
-       } else {
-               I802_DEBUG_INC(local->dot11FailedCount);
-       }
-}
-EXPORT_SYMBOL(ieee80211_tx_status_noskb);
-
 void ieee80211_tx_monitor(struct ieee80211_local *local, struct sk_buff *skb,
                          struct ieee80211_supported_band *sband,
                          int retry_count, int shift, bool send_to_cooked)
@@ -742,15 +688,16 @@ void ieee80211_tx_monitor(struct ieee80211_local *local, struct sk_buff *skb,
        dev_kfree_skb(skb);
 }
 
-void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
+static void __ieee80211_tx_status(struct ieee80211_hw *hw,
+                                 struct ieee80211_tx_status *status)
 {
+       struct sk_buff *skb = status->skb;
        struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
        struct ieee80211_local *local = hw_to_local(hw);
-       struct ieee80211_tx_info *info = IEEE80211_SKB_CB(skb);
+       struct ieee80211_tx_info *info = status->info;
+       struct sta_info *sta;
        __le16 fc;
        struct ieee80211_supported_band *sband;
-       struct rhlist_head *tmp;
-       struct sta_info *sta;
        int retry_count;
        int rates_idx;
        bool send_to_cooked;
@@ -761,16 +708,11 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 
        rates_idx = ieee80211_tx_get_rates(hw, info, &retry_count);
 
-       rcu_read_lock();
-
        sband = local->hw.wiphy->bands[info->band];
        fc = hdr->frame_control;
 
-       for_each_sta_info(local, hdr->addr1, sta, tmp) {
-               /* skip wrong virtual interface */
-               if (!ether_addr_equal(hdr->addr2, sta->sdata->vif.addr))
-                       continue;
-
+       if (status->sta) {
+               sta = container_of(status->sta, struct sta_info, sta);
                shift = ieee80211_vif_get_shift(&sta->sdata->vif);
 
                if (info->flags & IEEE80211_TX_STATUS_EOSP)
@@ -790,7 +732,6 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
                         * that this TX packet failed because of that.
                         */
                        ieee80211_handle_filtered_frame(local, sta, skb);
-                       rcu_read_unlock();
                        return;
                }
 
@@ -840,7 +781,6 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
 
                if (info->flags & IEEE80211_TX_STAT_TX_FILTERED) {
                        ieee80211_handle_filtered_frame(local, sta, skb);
-                       rcu_read_unlock();
                        return;
                } else {
                        if (!acked)
@@ -856,7 +796,7 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
                        }
                }
 
-               rate_control_tx_status(local, sband, sta, skb);
+               rate_control_tx_status(local, sband, status);
                if (ieee80211_vif_is_mesh(&sta->sdata->vif))
                        ieee80211s_update_metric(local, sta, skb);
 
@@ -883,8 +823,6 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
                }
        }
 
-       rcu_read_unlock();
-
        ieee80211_led_tx(local);
 
        /* SNMP counters
@@ -949,8 +887,96 @@ void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
        /* send to monitor interfaces */
        ieee80211_tx_monitor(local, skb, sband, retry_count, shift, send_to_cooked);
 }
+
+void ieee80211_tx_status(struct ieee80211_hw *hw, struct sk_buff *skb)
+{
+       struct ieee80211_hdr *hdr = (struct ieee80211_hdr *) skb->data;
+       struct ieee80211_local *local = hw_to_local(hw);
+       struct ieee80211_tx_status status = {
+               .skb = skb,
+               .info = IEEE80211_SKB_CB(skb),
+       };
+       struct rhlist_head *tmp;
+       struct sta_info *sta;
+
+       rcu_read_lock();
+
+       for_each_sta_info(local, hdr->addr1, sta, tmp) {
+               /* skip wrong virtual interface */
+               if (!ether_addr_equal(hdr->addr2, sta->sdata->vif.addr))
+                       continue;
+
+               status.sta = &sta->sta;
+               break;
+       }
+
+       __ieee80211_tx_status(hw, &status);
+       rcu_read_unlock();
+}
 EXPORT_SYMBOL(ieee80211_tx_status);
 
+void ieee80211_tx_status_ext(struct ieee80211_hw *hw,
+                            struct ieee80211_tx_status *status)
+{
+       struct ieee80211_local *local = hw_to_local(hw);
+       struct ieee80211_tx_info *info = status->info;
+       struct ieee80211_sta *pubsta = status->sta;
+       struct ieee80211_supported_band *sband;
+       int retry_count;
+       bool acked, noack_success;
+
+       if (status->skb)
+               return __ieee80211_tx_status(hw, status);
+
+       if (!status->sta)
+               return;
+
+       ieee80211_tx_get_rates(hw, info, &retry_count);
+
+       sband = hw->wiphy->bands[info->band];
+
+       acked = !!(info->flags & IEEE80211_TX_STAT_ACK);
+       noack_success = !!(info->flags & IEEE80211_TX_STAT_NOACK_TRANSMITTED);
+
+       if (pubsta) {
+               struct sta_info *sta;
+
+               sta = container_of(pubsta, struct sta_info, sta);
+
+               if (!acked)
+                       sta->status_stats.retry_failed++;
+               sta->status_stats.retry_count += retry_count;
+
+               if (acked) {
+                       sta->status_stats.last_ack = jiffies;
+
+                       if (sta->status_stats.lost_packets)
+                               sta->status_stats.lost_packets = 0;
+
+                       /* Track when last TDLS packet was ACKed */
+                       if (test_sta_flag(sta, WLAN_STA_TDLS_PEER_AUTH))
+                               sta->status_stats.last_tdls_pkt_time = jiffies;
+               } else {
+                       ieee80211_lost_packet(sta, info);
+               }
+
+               rate_control_tx_status(local, sband, status);
+       }
+
+       if (acked || noack_success) {
+               I802_DEBUG_INC(local->dot11TransmittedFrameCount);
+               if (!pubsta)
+                       I802_DEBUG_INC(local->dot11MulticastTransmittedFrameCount);
+               if (retry_count > 0)
+                       I802_DEBUG_INC(local->dot11RetryCount);
+               if (retry_count > 1)
+                       I802_DEBUG_INC(local->dot11MultipleRetryCount);
+       } else {
+               I802_DEBUG_INC(local->dot11FailedCount);
+       }
+}
+EXPORT_SYMBOL(ieee80211_tx_status_ext);
+
 void ieee80211_report_low_ack(struct ieee80211_sta *pubsta, u32 num_packets)
 {
        struct sta_info *sta = container_of(pubsta, struct sta_info, sta);