]> git.karo-electronics.de Git - mv-sheeva.git/blobdiff - sound/pci/oxygen/xonar_pcm179x.c
Merge branch 'x86-uv-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git...
[mv-sheeva.git] / sound / pci / oxygen / xonar_pcm179x.c
index 97574dbec2b6905b11763c4e50b315e120bbf041..ba18fb546b4f9d7c8ace8b82d5100e3c82d0e3b1 100644 (file)
 #define I2C_DEVICE_PCM1796(i)  (0x98 + ((i) << 1))     /* 10011, ii, /W=0 */
 #define I2C_DEVICE_CS2000      0x9c                    /* 100111, 0, /W=0 */
 
+#define PCM1796_REG_BASE       16
+
 
 struct xonar_pcm179x {
        struct xonar_generic generic;
        unsigned int dacs;
-       u8 oversampling;
+       u8 pcm1796_regs[4][5];
+       unsigned int current_rate;
+       bool os_128;
+       bool hp_active;
+       s8 hp_gain_offset;
+       bool has_cs2000;
        u8 cs2000_fun_cfg_1;
 };
 
@@ -204,54 +211,79 @@ static inline void pcm1796_write_i2c(struct oxygen *chip, unsigned int codec,
 static void pcm1796_write(struct oxygen *chip, unsigned int codec,
                          u8 reg, u8 value)
 {
+       struct xonar_pcm179x *data = chip->model_data;
+
        if ((chip->model.function_flags & OXYGEN_FUNCTION_2WIRE_SPI_MASK) ==
            OXYGEN_FUNCTION_SPI)
                pcm1796_write_spi(chip, codec, reg, value);
        else
                pcm1796_write_i2c(chip, codec, reg, value);
+       if ((unsigned int)(reg - PCM1796_REG_BASE)
+           < ARRAY_SIZE(data->pcm1796_regs[codec]))
+               data->pcm1796_regs[codec][reg - PCM1796_REG_BASE] = value;
 }
 
-static void cs2000_write(struct oxygen *chip, u8 reg, u8 value)
+static void pcm1796_write_cached(struct oxygen *chip, unsigned int codec,
+                                u8 reg, u8 value)
 {
-       oxygen_write_i2c(chip, I2C_DEVICE_CS2000, reg, value);
+       struct xonar_pcm179x *data = chip->model_data;
+
+       if (value != data->pcm1796_regs[codec][reg - PCM1796_REG_BASE])
+               pcm1796_write(chip, codec, reg, value);
 }
 
-static void update_pcm1796_volume(struct oxygen *chip)
+static void cs2000_write(struct oxygen *chip, u8 reg, u8 value)
 {
        struct xonar_pcm179x *data = chip->model_data;
-       unsigned int i;
 
-       for (i = 0; i < data->dacs; ++i) {
-               pcm1796_write(chip, i, 16, chip->dac_volume[i * 2]);
-               pcm1796_write(chip, i, 17, chip->dac_volume[i * 2 + 1]);
-       }
+       oxygen_write_i2c(chip, I2C_DEVICE_CS2000, reg, value);
+       if (reg == CS2000_FUN_CFG_1)
+               data->cs2000_fun_cfg_1 = value;
 }
 
-static void update_pcm1796_mute(struct oxygen *chip)
+static void cs2000_write_cached(struct oxygen *chip, u8 reg, u8 value)
 {
        struct xonar_pcm179x *data = chip->model_data;
-       unsigned int i;
-       u8 value;
 
-       value = PCM1796_DMF_DISABLED | PCM1796_FMT_24_LJUST | PCM1796_ATLD;
-       if (chip->dac_mute)
-               value |= PCM1796_MUTE;
-       for (i = 0; i < data->dacs; ++i)
-               pcm1796_write(chip, i, 18, value);
+       if (reg != CS2000_FUN_CFG_1 ||
+           value != data->cs2000_fun_cfg_1)
+               cs2000_write(chip, reg, value);
 }
 
-static void pcm1796_init(struct oxygen *chip)
+static void pcm1796_registers_init(struct oxygen *chip)
 {
        struct xonar_pcm179x *data = chip->model_data;
        unsigned int i;
+       s8 gain_offset;
 
+       gain_offset = data->hp_active ? data->hp_gain_offset : 0;
        for (i = 0; i < data->dacs; ++i) {
-               pcm1796_write(chip, i, 19, PCM1796_FLT_SHARP | PCM1796_ATS_1);
-               pcm1796_write(chip, i, 20, data->oversampling);
+               /* set ATLD before ATL/ATR */
+               pcm1796_write(chip, i, 18,
+                             data->pcm1796_regs[0][18 - PCM1796_REG_BASE]);
+               pcm1796_write(chip, i, 16, chip->dac_volume[i * 2]
+                             + gain_offset);
+               pcm1796_write(chip, i, 17, chip->dac_volume[i * 2 + 1]
+                             + gain_offset);
+               pcm1796_write(chip, i, 19,
+                             data->pcm1796_regs[0][19 - PCM1796_REG_BASE]);
+               pcm1796_write(chip, i, 20,
+                             data->pcm1796_regs[0][20 - PCM1796_REG_BASE]);
                pcm1796_write(chip, i, 21, 0);
        }
-       update_pcm1796_mute(chip); /* set ATLD before ATL/ATR */
-       update_pcm1796_volume(chip);
+}
+
+static void pcm1796_init(struct oxygen *chip)
+{
+       struct xonar_pcm179x *data = chip->model_data;
+
+       data->pcm1796_regs[0][18 - PCM1796_REG_BASE] = PCM1796_MUTE |
+               PCM1796_DMF_DISABLED | PCM1796_FMT_24_LJUST | PCM1796_ATLD;
+       data->pcm1796_regs[0][19 - PCM1796_REG_BASE] =
+               PCM1796_FLT_SHARP | PCM1796_ATS_1;
+       data->pcm1796_regs[0][20 - PCM1796_REG_BASE] = PCM1796_OS_64;
+       pcm1796_registers_init(chip);
+       data->current_rate = 48000;
 }
 
 static void xonar_d2_init(struct oxygen *chip)
@@ -261,7 +293,6 @@ static void xonar_d2_init(struct oxygen *chip)
        data->generic.anti_pop_delay = 300;
        data->generic.output_enable_bit = GPIO_D2_OUTPUT_ENABLE;
        data->dacs = 4;
-       data->oversampling = PCM1796_OS_64;
 
        pcm1796_init(chip);
 
@@ -304,7 +335,6 @@ static void xonar_hdav_init(struct oxygen *chip)
        data->pcm179x.generic.ext_power_int_reg = OXYGEN_GPI_INTERRUPT_MASK;
        data->pcm179x.generic.ext_power_bit = GPI_EXT_POWER;
        data->pcm179x.dacs = chip->model.private_data ? 4 : 1;
-       data->pcm179x.oversampling = PCM1796_OS_64;
 
        pcm1796_init(chip);
 
@@ -335,7 +365,7 @@ static void xonar_st_init_common(struct oxygen *chip)
        data->generic.anti_pop_delay = 100;
        data->generic.output_enable_bit = GPIO_ST_OUTPUT_ENABLE;
        data->dacs = chip->model.private_data ? 4 : 1;
-       data->oversampling = PCM1796_OS_64;
+       data->hp_gain_offset = 2*-18;
 
        pcm1796_init(chip);
 
@@ -378,6 +408,7 @@ static void xonar_st_init(struct oxygen *chip)
 {
        struct xonar_pcm179x *data = chip->model_data;
 
+       data->has_cs2000 = 1;
        data->cs2000_fun_cfg_1 = CS2000_REF_CLK_DIV_1;
 
        oxygen_write16(chip, OXYGEN_I2S_A_FORMAT,
@@ -438,7 +469,7 @@ static void xonar_st_suspend(struct oxygen *chip)
 
 static void xonar_d2_resume(struct oxygen *chip)
 {
-       pcm1796_init(chip);
+       pcm1796_registers_init(chip);
        xonar_enable_output(chip);
 }
 
@@ -446,14 +477,14 @@ static void xonar_hdav_resume(struct oxygen *chip)
 {
        struct xonar_hdav *data = chip->model_data;
 
-       pcm1796_init(chip);
+       pcm1796_registers_init(chip);
        xonar_hdmi_resume(chip, &data->hdmi);
        xonar_enable_output(chip);
 }
 
 static void xonar_stx_resume(struct oxygen *chip)
 {
-       pcm1796_init(chip);
+       pcm1796_registers_init(chip);
        xonar_enable_output(chip);
 }
 
@@ -463,52 +494,136 @@ static void xonar_st_resume(struct oxygen *chip)
        xonar_stx_resume(chip);
 }
 
+static unsigned int mclk_from_rate(struct oxygen *chip, unsigned int rate)
+{
+       struct xonar_pcm179x *data = chip->model_data;
+
+       if (rate <= 32000)
+               return OXYGEN_I2S_MCLK_512;
+       else if (rate <= 48000 && data->os_128)
+               return OXYGEN_I2S_MCLK_512;
+       else if (rate <= 96000)
+               return OXYGEN_I2S_MCLK_256;
+       else
+               return OXYGEN_I2S_MCLK_128;
+}
+
+static unsigned int get_pcm1796_i2s_mclk(struct oxygen *chip,
+                                        unsigned int channel,
+                                        struct snd_pcm_hw_params *params)
+{
+       if (channel == PCM_MULTICH)
+               return mclk_from_rate(chip, params_rate(params));
+       else
+               return oxygen_default_i2s_mclk(chip, channel, params);
+}
+
+static void update_pcm1796_oversampling(struct oxygen *chip)
+{
+       struct xonar_pcm179x *data = chip->model_data;
+       unsigned int i;
+       u8 reg;
+
+       if (data->current_rate <= 32000)
+               reg = PCM1796_OS_128;
+       else if (data->current_rate <= 48000 && data->os_128)
+               reg = PCM1796_OS_128;
+       else if (data->current_rate <= 96000 || data->os_128)
+               reg = PCM1796_OS_64;
+       else
+               reg = PCM1796_OS_32;
+       for (i = 0; i < data->dacs; ++i)
+               pcm1796_write_cached(chip, i, 20, reg);
+}
+
 static void set_pcm1796_params(struct oxygen *chip,
                               struct snd_pcm_hw_params *params)
+{
+       struct xonar_pcm179x *data = chip->model_data;
+
+       data->current_rate = params_rate(params);
+       update_pcm1796_oversampling(chip);
+}
+
+static void update_pcm1796_volume(struct oxygen *chip)
+{
+       struct xonar_pcm179x *data = chip->model_data;
+       unsigned int i;
+       s8 gain_offset;
+
+       gain_offset = data->hp_active ? data->hp_gain_offset : 0;
+       for (i = 0; i < data->dacs; ++i) {
+               pcm1796_write_cached(chip, i, 16, chip->dac_volume[i * 2]
+                                    + gain_offset);
+               pcm1796_write_cached(chip, i, 17, chip->dac_volume[i * 2 + 1]
+                                    + gain_offset);
+       }
+}
+
+static void update_pcm1796_mute(struct oxygen *chip)
 {
        struct xonar_pcm179x *data = chip->model_data;
        unsigned int i;
+       u8 value;
 
-       data->oversampling =
-               params_rate(params) >= 96000 ? PCM1796_OS_32 : PCM1796_OS_64;
+       value = PCM1796_DMF_DISABLED | PCM1796_FMT_24_LJUST | PCM1796_ATLD;
+       if (chip->dac_mute)
+               value |= PCM1796_MUTE;
        for (i = 0; i < data->dacs; ++i)
-               pcm1796_write(chip, i, 20, data->oversampling);
-}
-
-static void set_cs2000_params(struct oxygen *chip,
-                             struct snd_pcm_hw_params *params)
-{
-       /* XXX Why is the I2S A MCLK half the actual I2S multich MCLK? */
-       static const u8 rate_mclks[] = {
-               [OXYGEN_RATE_32000] = OXYGEN_RATE_32000 | OXYGEN_I2S_MCLK_128,
-               [OXYGEN_RATE_44100] = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_128,
-               [OXYGEN_RATE_48000] = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_128,
-               [OXYGEN_RATE_64000] = OXYGEN_RATE_32000 | OXYGEN_I2S_MCLK_256,
-               [OXYGEN_RATE_88200] = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_256,
-               [OXYGEN_RATE_96000] = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_256,
-               [OXYGEN_RATE_176400] = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_256,
-               [OXYGEN_RATE_192000] = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_256,
-       };
+               pcm1796_write_cached(chip, i, 18, value);
+}
+
+static void update_cs2000_rate(struct oxygen *chip, unsigned int rate)
+{
        struct xonar_pcm179x *data = chip->model_data;
-       unsigned int rate_index;
-       u8 rate_mclk;
+       u8 rate_mclk, reg;
 
-       rate_index = oxygen_read16(chip, OXYGEN_I2S_MULTICH_FORMAT)
-               & OXYGEN_I2S_RATE_MASK;
-       rate_mclk = rate_mclks[rate_index];
+       switch (rate) {
+               /* XXX Why is the I2S A MCLK half the actual I2S MCLK? */
+       case 32000:
+               rate_mclk = OXYGEN_RATE_32000 | OXYGEN_I2S_MCLK_256;
+               break;
+       case 44100:
+               if (data->os_128)
+                       rate_mclk = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_256;
+               else
+                       rate_mclk = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_128;
+               break;
+       default: /* 48000 */
+               if (data->os_128)
+                       rate_mclk = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_256;
+               else
+                       rate_mclk = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_128;
+               break;
+       case 64000:
+               rate_mclk = OXYGEN_RATE_32000 | OXYGEN_I2S_MCLK_256;
+               break;
+       case 88200:
+               rate_mclk = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_256;
+               break;
+       case 96000:
+               rate_mclk = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_256;
+               break;
+       case 176400:
+               rate_mclk = OXYGEN_RATE_44100 | OXYGEN_I2S_MCLK_256;
+               break;
+       case 192000:
+               rate_mclk = OXYGEN_RATE_48000 | OXYGEN_I2S_MCLK_256;
+               break;
+       }
        oxygen_write16_masked(chip, OXYGEN_I2S_A_FORMAT, rate_mclk,
                              OXYGEN_I2S_RATE_MASK | OXYGEN_I2S_MCLK_MASK);
        if ((rate_mclk & OXYGEN_I2S_MCLK_MASK) <= OXYGEN_I2S_MCLK_128)
-               data->cs2000_fun_cfg_1 = CS2000_REF_CLK_DIV_1;
+               reg = CS2000_REF_CLK_DIV_1;
        else
-               data->cs2000_fun_cfg_1 = CS2000_REF_CLK_DIV_2;
-       cs2000_write(chip, CS2000_FUN_CFG_1, data->cs2000_fun_cfg_1);
+               reg = CS2000_REF_CLK_DIV_2;
+       cs2000_write_cached(chip, CS2000_FUN_CFG_1, reg);
 }
 
 static void set_st_params(struct oxygen *chip,
                          struct snd_pcm_hw_params *params)
 {
-       set_cs2000_params(chip, params);
+       update_cs2000_rate(chip, params_rate(params));
        set_pcm1796_params(chip, params);
 }
 
@@ -530,6 +645,120 @@ static const struct snd_kcontrol_new alt_switch = {
        .private_value = GPIO_D2_ALT,
 };
 
+static int rolloff_info(struct snd_kcontrol *ctl,
+                       struct snd_ctl_elem_info *info)
+{
+       static const char *const names[2] = {
+               "Sharp Roll-off", "Slow Roll-off"
+       };
+
+       info->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
+       info->count = 1;
+       info->value.enumerated.items = 2;
+       if (info->value.enumerated.item >= 2)
+               info->value.enumerated.item = 1;
+       strcpy(info->value.enumerated.name, names[info->value.enumerated.item]);
+       return 0;
+}
+
+static int rolloff_get(struct snd_kcontrol *ctl,
+                      struct snd_ctl_elem_value *value)
+{
+       struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
+
+       value->value.enumerated.item[0] =
+               (data->pcm1796_regs[0][19 - PCM1796_REG_BASE] &
+                PCM1796_FLT_MASK) != PCM1796_FLT_SHARP;
+       return 0;
+}
+
+static int rolloff_put(struct snd_kcontrol *ctl,
+                      struct snd_ctl_elem_value *value)
+{
+       struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
+       unsigned int i;
+       int changed;
+       u8 reg;
+
+       mutex_lock(&chip->mutex);
+       reg = data->pcm1796_regs[0][19 - PCM1796_REG_BASE];
+       reg &= ~PCM1796_FLT_MASK;
+       if (!value->value.enumerated.item[0])
+               reg |= PCM1796_FLT_SHARP;
+       else
+               reg |= PCM1796_FLT_SLOW;
+       changed = reg != data->pcm1796_regs[0][19 - PCM1796_REG_BASE];
+       if (changed) {
+               for (i = 0; i < data->dacs; ++i)
+                       pcm1796_write(chip, i, 19, reg);
+       }
+       mutex_unlock(&chip->mutex);
+       return changed;
+}
+
+static const struct snd_kcontrol_new rolloff_control = {
+       .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+       .name = "DAC Filter Playback Enum",
+       .info = rolloff_info,
+       .get = rolloff_get,
+       .put = rolloff_put,
+};
+
+static int os_128_info(struct snd_kcontrol *ctl, struct snd_ctl_elem_info *info)
+{
+       static const char *const names[2] = { "64x", "128x" };
+
+       info->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
+       info->count = 1;
+       info->value.enumerated.items = 2;
+       if (info->value.enumerated.item >= 2)
+               info->value.enumerated.item = 1;
+       strcpy(info->value.enumerated.name, names[info->value.enumerated.item]);
+       return 0;
+}
+
+static int os_128_get(struct snd_kcontrol *ctl,
+                     struct snd_ctl_elem_value *value)
+{
+       struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
+
+       value->value.enumerated.item[0] = data->os_128;
+       return 0;
+}
+
+static int os_128_put(struct snd_kcontrol *ctl,
+                     struct snd_ctl_elem_value *value)
+{
+       struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
+       int changed;
+
+       mutex_lock(&chip->mutex);
+       changed = value->value.enumerated.item[0] != data->os_128;
+       if (changed) {
+               data->os_128 = value->value.enumerated.item[0];
+               if (data->has_cs2000)
+                       update_cs2000_rate(chip, data->current_rate);
+               oxygen_write16_masked(chip, OXYGEN_I2S_MULTICH_FORMAT,
+                                     mclk_from_rate(chip, data->current_rate),
+                                     OXYGEN_I2S_MCLK_MASK);
+               update_pcm1796_oversampling(chip);
+       }
+       mutex_unlock(&chip->mutex);
+       return changed;
+}
+
+static const struct snd_kcontrol_new os_128_control = {
+       .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+       .name = "DAC Oversampling Playback Enum",
+       .info = os_128_info,
+       .get = os_128_get,
+       .put = os_128_put,
+};
+
 static int st_output_switch_info(struct snd_kcontrol *ctl,
                                 struct snd_ctl_elem_info *info)
 {
@@ -567,6 +796,7 @@ static int st_output_switch_put(struct snd_kcontrol *ctl,
                                struct snd_ctl_elem_value *value)
 {
        struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
        u16 gpio_old, gpio;
 
        mutex_lock(&chip->mutex);
@@ -584,16 +814,83 @@ static int st_output_switch_put(struct snd_kcontrol *ctl,
                break;
        }
        oxygen_write16(chip, OXYGEN_GPIO_DATA, gpio);
+       data->hp_active = gpio & GPIO_ST_HP;
+       update_pcm1796_volume(chip);
        mutex_unlock(&chip->mutex);
        return gpio != gpio_old;
 }
 
-static const struct snd_kcontrol_new st_output_switch = {
-       .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
-       .name = "Analog Output",
-       .info = st_output_switch_info,
-       .get = st_output_switch_get,
-       .put = st_output_switch_put,
+static int st_hp_volume_offset_info(struct snd_kcontrol *ctl,
+                                   struct snd_ctl_elem_info *info)
+{
+       static const char *const names[3] = {
+               "< 64 ohms", "64-300 ohms", "300-600 ohms"
+       };
+
+       info->type = SNDRV_CTL_ELEM_TYPE_ENUMERATED;
+       info->count = 1;
+       info->value.enumerated.items = 3;
+       if (info->value.enumerated.item > 2)
+               info->value.enumerated.item = 2;
+       strcpy(info->value.enumerated.name, names[info->value.enumerated.item]);
+       return 0;
+}
+
+static int st_hp_volume_offset_get(struct snd_kcontrol *ctl,
+                                  struct snd_ctl_elem_value *value)
+{
+       struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
+
+       mutex_lock(&chip->mutex);
+       if (data->hp_gain_offset < 2*-6)
+               value->value.enumerated.item[0] = 0;
+       else if (data->hp_gain_offset < 0)
+               value->value.enumerated.item[0] = 1;
+       else
+               value->value.enumerated.item[0] = 2;
+       mutex_unlock(&chip->mutex);
+       return 0;
+}
+
+
+static int st_hp_volume_offset_put(struct snd_kcontrol *ctl,
+                                  struct snd_ctl_elem_value *value)
+{
+       static const s8 offsets[] = { 2*-18, 2*-6, 0 };
+       struct oxygen *chip = ctl->private_data;
+       struct xonar_pcm179x *data = chip->model_data;
+       s8 offset;
+       int changed;
+
+       if (value->value.enumerated.item[0] > 2)
+               return -EINVAL;
+       offset = offsets[value->value.enumerated.item[0]];
+       mutex_lock(&chip->mutex);
+       changed = offset != data->hp_gain_offset;
+       if (changed) {
+               data->hp_gain_offset = offset;
+               update_pcm1796_volume(chip);
+       }
+       mutex_unlock(&chip->mutex);
+       return changed;
+}
+
+static const struct snd_kcontrol_new st_controls[] = {
+       {
+               .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+               .name = "Analog Output",
+               .info = st_output_switch_info,
+               .get = st_output_switch_get,
+               .put = st_output_switch_put,
+       },
+       {
+               .iface = SNDRV_CTL_ELEM_IFACE_MIXER,
+               .name = "Headphones Impedance Playback Enum",
+               .info = st_hp_volume_offset_info,
+               .get = st_hp_volume_offset_get,
+               .put = st_hp_volume_offset_put,
+       },
 };
 
 static void xonar_line_mic_ac97_switch(struct oxygen *chip,
@@ -625,14 +922,52 @@ static int xonar_st_control_filter(struct snd_kcontrol_new *template)
        return 0;
 }
 
+static int add_pcm1796_controls(struct oxygen *chip)
+{
+       int err;
+
+       err = snd_ctl_add(chip->card, snd_ctl_new1(&rolloff_control, chip));
+       if (err < 0)
+               return err;
+       err = snd_ctl_add(chip->card, snd_ctl_new1(&os_128_control, chip));
+       if (err < 0)
+               return err;
+       return 0;
+}
+
 static int xonar_d2_mixer_init(struct oxygen *chip)
 {
-       return snd_ctl_add(chip->card, snd_ctl_new1(&alt_switch, chip));
+       int err;
+
+       err = snd_ctl_add(chip->card, snd_ctl_new1(&alt_switch, chip));
+       if (err < 0)
+               return err;
+       err = add_pcm1796_controls(chip);
+       if (err < 0)
+               return err;
+       return 0;
+}
+
+static int xonar_hdav_mixer_init(struct oxygen *chip)
+{
+       return add_pcm1796_controls(chip);
 }
 
 static int xonar_st_mixer_init(struct oxygen *chip)
 {
-       return snd_ctl_add(chip->card, snd_ctl_new1(&st_output_switch, chip));
+       unsigned int i;
+       int err;
+
+       for (i = 0; i < ARRAY_SIZE(st_controls); ++i) {
+               err = snd_ctl_add(chip->card,
+                                 snd_ctl_new1(&st_controls[i], chip));
+               if (err < 0)
+                       return err;
+       }
+       err = add_pcm1796_controls(chip);
+       if (err < 0)
+               return err;
+       return 0;
 }
 
 static const struct oxygen_model model_xonar_d2 = {
@@ -644,6 +979,7 @@ static const struct oxygen_model model_xonar_d2 = {
        .cleanup = xonar_d2_cleanup,
        .suspend = xonar_d2_suspend,
        .resume = xonar_d2_resume,
+       .get_i2s_mclk = get_pcm1796_i2s_mclk,
        .set_dac_params = set_pcm1796_params,
        .set_adc_params = xonar_set_cs53x1_params,
        .update_dac_volume = update_pcm1796_volume,
@@ -670,10 +1006,12 @@ static const struct oxygen_model model_xonar_hdav = {
        .longname = "Asus Virtuoso 200",
        .chip = "AV200",
        .init = xonar_hdav_init,
+       .mixer_init = xonar_hdav_mixer_init,
        .cleanup = xonar_hdav_cleanup,
        .suspend = xonar_hdav_suspend,
        .resume = xonar_hdav_resume,
        .pcm_hardware_filter = xonar_hdmi_pcm_hardware_filter,
+       .get_i2s_mclk = get_pcm1796_i2s_mclk,
        .set_dac_params = set_hdav_params,
        .set_adc_params = xonar_set_cs53x1_params,
        .update_dac_volume = update_pcm1796_volume,
@@ -704,6 +1042,7 @@ static const struct oxygen_model model_xonar_st = {
        .cleanup = xonar_st_cleanup,
        .suspend = xonar_st_suspend,
        .resume = xonar_st_resume,
+       .get_i2s_mclk = get_pcm1796_i2s_mclk,
        .set_dac_params = set_st_params,
        .set_adc_params = xonar_set_cs53x1_params,
        .update_dac_volume = update_pcm1796_volume,