]> git.karo-electronics.de Git - linux-beck.git/blobdiff - sound/soc/codecs/wm8711.c
ASoC: Remove snd_soc_suspend_device()
[linux-beck.git] / sound / soc / codecs / wm8711.c
index 84ead3f9293f639858a687dabc7ff62d7bd299f3..54189fbf9e935912411c804cb4af200743ac36f4 100644 (file)
 #include <linux/pm.h>
 #include <linux/i2c.h>
 #include <linux/platform_device.h>
+#include <linux/spi/spi.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
 #include <sound/soc.h>
 #include <sound/soc-dapm.h>
+#include <sound/tlv.h>
 #include <sound/initval.h>
 
 #include "wm8711.h"
 
-#define AUDIO_NAME "wm8711"
-#define WM8711_VERSION "0.3"
+static struct snd_soc_codec *wm8711_codec;
 
 /* codec private data */
 struct wm8711_priv {
+       struct snd_soc_codec codec;
+       u16 reg_cache[WM8711_CACHEREGNUM];
        unsigned int sysclk;
 };
 
@@ -47,81 +50,19 @@ static const u16 wm8711_reg[WM8711_CACHEREGNUM] = {
        0x009f, 0x000a, 0x0000, 0x0000
 };
 
-/*
- * read wm8711 register cache
- */
-static inline unsigned int wm8711_read_reg_cache(struct snd_soc_codec *codec,
-       unsigned int reg)
-{
-       u16 *cache = codec->reg_cache;
-       if (reg == WM8711_RESET)
-               return 0;
-       if (reg >= WM8711_CACHEREGNUM)
-               return -1;
-       return cache[reg];
-}
+#define wm8711_reset(c)        snd_soc_write(c, WM8711_RESET, 0)
 
-/*
- * write wm8711 register cache
- */
-static inline void wm8711_write_reg_cache(struct snd_soc_codec *codec,
-       u16 reg, unsigned int value)
-{
-       u16 *cache = codec->reg_cache;
-       if (reg >= WM8711_CACHEREGNUM)
-               return;
-       cache[reg] = value;
-}
-
-/*
- * write to the WM8711 register space
- */
-static int wm8711_write(struct snd_soc_codec *codec, unsigned int reg,
-       unsigned int value)
-{
-       u8 data[2];
-
-       /* data is
-        *   D15..D9 WM8753 register offset
-        *   D8...D0 register data
-        */
-       data[0] = (reg << 1) | ((value >> 8) & 0x0001);
-       data[1] = value & 0x00ff;
-
-       wm8711_write_reg_cache(codec, reg, value);
-       if (codec->hw_write(codec->control_data, data, 2) == 2)
-               return 0;
-       else
-               return -EIO;
-}
-
-#define wm8711_reset(c)        wm8711_write(c, WM8711_RESET, 0)
+static const DECLARE_TLV_DB_SCALE(out_tlv, -12100, 100, 1);
 
 static const struct snd_kcontrol_new wm8711_snd_controls[] = {
 
-SOC_DOUBLE_R("Master Playback Volume", WM8711_LOUT1V, WM8711_ROUT1V,
-       0, 127, 0),
+SOC_DOUBLE_R_TLV("Master Playback Volume", WM8711_LOUT1V, WM8711_ROUT1V,
+                0, 127, 0, out_tlv),
 SOC_DOUBLE_R("Master Playback ZC Switch", WM8711_LOUT1V, WM8711_ROUT1V,
        7, 1, 0),
 
 };
 
-/* add non dapm controls */
-static int wm8711_add_controls(struct snd_soc_codec *codec)
-{
-       int err, i;
-
-       for (i = 0; i < ARRAY_SIZE(wm8711_snd_controls); i++) {
-               err = snd_ctl_add(codec->card,
-                               snd_soc_cnew(&wm8711_snd_controls[i], codec,
-                                       NULL));
-               if (err < 0)
-                       return err;
-       }
-
-       return 0;
-}
-
 /* Output Mixer */
 static const struct snd_kcontrol_new wm8711_output_mixer_controls[] = {
 SOC_DAPM_SINGLE("Line Bypass Switch", WM8711_APANA, 3, 1, 0),
@@ -223,12 +164,12 @@ static int wm8711_hw_params(struct snd_pcm_substream *substream,
 {
        struct snd_soc_codec *codec = dai->codec;
        struct wm8711_priv *wm8711 = codec->private_data;
-       u16 iface = wm8711_read_reg_cache(codec, WM8711_IFACE) & 0xfffc;
+       u16 iface = snd_soc_read(codec, WM8711_IFACE) & 0xfffc;
        int i = get_coeff(wm8711->sysclk, params_rate(params));
        u16 srate = (coeff_div[i].sr << 2) |
                (coeff_div[i].bosr << 1) | coeff_div[i].usb;
 
-       wm8711_write(codec, WM8711_SRATE, srate);
+       snd_soc_write(codec, WM8711_SRATE, srate);
 
        /* bit size */
        switch (params_format(params)) {
@@ -242,7 +183,7 @@ static int wm8711_hw_params(struct snd_pcm_substream *substream,
                break;
        }
 
-       wm8711_write(codec, WM8711_IFACE, iface);
+       snd_soc_write(codec, WM8711_IFACE, iface);
        return 0;
 }
 
@@ -252,7 +193,7 @@ static int wm8711_pcm_prepare(struct snd_pcm_substream *substream,
        struct snd_soc_codec *codec = dai->codec;
 
        /* set active */
-       wm8711_write(codec, WM8711_ACTIVE, 0x0001);
+       snd_soc_write(codec, WM8711_ACTIVE, 0x0001);
 
        return 0;
 }
@@ -265,19 +206,19 @@ static void wm8711_shutdown(struct snd_pcm_substream *substream,
        /* deactivate */
        if (!codec->active) {
                udelay(50);
-               wm8711_write(codec, WM8711_ACTIVE, 0x0);
+               snd_soc_write(codec, WM8711_ACTIVE, 0x0);
        }
 }
 
 static int wm8711_mute(struct snd_soc_dai *dai, int mute)
 {
        struct snd_soc_codec *codec = dai->codec;
-       u16 mute_reg = wm8711_read_reg_cache(codec, WM8711_APDIGI) & 0xfff7;
+       u16 mute_reg = snd_soc_read(codec, WM8711_APDIGI) & 0xfff7;
 
        if (mute)
-               wm8711_write(codec, WM8711_APDIGI, mute_reg | 0x8);
+               snd_soc_write(codec, WM8711_APDIGI, mute_reg | 0x8);
        else
-               wm8711_write(codec, WM8711_APDIGI, mute_reg);
+               snd_soc_write(codec, WM8711_APDIGI, mute_reg);
 
        return 0;
 }
@@ -355,7 +296,7 @@ static int wm8711_set_dai_fmt(struct snd_soc_dai *codec_dai,
        }
 
        /* set iface */
-       wm8711_write(codec, WM8711_IFACE, iface);
+       snd_soc_write(codec, WM8711_IFACE, iface);
        return 0;
 }
 
@@ -363,31 +304,27 @@ static int wm8711_set_dai_fmt(struct snd_soc_dai *codec_dai,
 static int wm8711_set_bias_level(struct snd_soc_codec *codec,
        enum snd_soc_bias_level level)
 {
-       u16 reg = wm8711_read_reg_cache(codec, WM8711_PWR) & 0xff7f;
+       u16 reg = snd_soc_read(codec, WM8711_PWR) & 0xff7f;
 
        switch (level) {
        case SND_SOC_BIAS_ON:
-               wm8711_write(codec, WM8711_PWR, reg);
+               snd_soc_write(codec, WM8711_PWR, reg);
                break;
        case SND_SOC_BIAS_PREPARE:
                break;
        case SND_SOC_BIAS_STANDBY:
-               wm8711_write(codec, WM8711_PWR, reg | 0x0040);
+               snd_soc_write(codec, WM8711_PWR, reg | 0x0040);
                break;
        case SND_SOC_BIAS_OFF:
-               wm8711_write(codec, WM8711_ACTIVE, 0x0);
-               wm8711_write(codec, WM8711_PWR, 0xffff);
+               snd_soc_write(codec, WM8711_ACTIVE, 0x0);
+               snd_soc_write(codec, WM8711_PWR, 0xffff);
                break;
        }
        codec->bias_level = level;
        return 0;
 }
 
-#define WM8711_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\
-               SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 |\
-               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |\
-               SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |\
-               SNDRV_PCM_RATE_96000)
+#define WM8711_RATES SNDRV_PCM_RATE_8000_96000
 
 #define WM8711_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\
        SNDRV_PCM_FMTBIT_S24_LE)
@@ -408,7 +345,8 @@ struct snd_soc_dai wm8711_dai = {
                .channels_min = 1,
                .channels_max = 2,
                .rates = WM8711_RATES,
-               .formats = WM8711_FORMATS,},
+               .formats = WM8711_FORMATS,
+       },
        .ops = &wm8711_ops,
 };
 EXPORT_SYMBOL_GPL(wm8711_dai);
@@ -418,7 +356,7 @@ static int wm8711_suspend(struct platform_device *pdev, pm_message_t state)
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
 
-       wm8711_write(codec, WM8711_ACTIVE, 0x0);
+       snd_soc_write(codec, WM8711_ACTIVE, 0x0);
        wm8711_set_bias_level(codec, SND_SOC_BIAS_OFF);
        return 0;
 }
@@ -442,241 +380,260 @@ static int wm8711_resume(struct platform_device *pdev)
        return 0;
 }
 
-/*
- * initialise the WM8711 driver
- * register the mixer and dsp interfaces with the kernel
- */
-static int wm8711_init(struct snd_soc_device *socdev)
+static int wm8711_probe(struct platform_device *pdev)
 {
-       struct snd_soc_codec *codec = socdev->card->codec;
-       int reg, ret = 0;
-
-       codec->name = "WM8711";
-       codec->owner = THIS_MODULE;
-       codec->read = wm8711_read_reg_cache;
-       codec->write = wm8711_write;
-       codec->set_bias_level = wm8711_set_bias_level;
-       codec->dai = &wm8711_dai;
-       codec->num_dai = 1;
-       codec->reg_cache_size = ARRAY_SIZE(wm8711_reg);
-       codec->reg_cache = kmemdup(wm8711_reg, sizeof(wm8711_reg), GFP_KERNEL);
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+       struct snd_soc_codec *codec;
+       int ret = 0;
 
-       if (codec->reg_cache == NULL)
-               return -ENOMEM;
+       if (wm8711_codec == NULL) {
+               dev_err(&pdev->dev, "Codec device not registered\n");
+               return -ENODEV;
+       }
 
-       wm8711_reset(codec);
+       socdev->card->codec = wm8711_codec;
+       codec = wm8711_codec;
 
        /* register pcms */
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
        if (ret < 0) {
-               printk(KERN_ERR "wm8711: failed to create pcms\n");
+               dev_err(codec->dev, "failed to create pcms: %d\n", ret);
                goto pcm_err;
        }
 
-       /* power on device */
-       wm8711_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-
-       /* set the update bits */
-       reg = wm8711_read_reg_cache(codec, WM8711_LOUT1V);
-       wm8711_write(codec, WM8711_LOUT1V, reg | 0x0100);
-       reg = wm8711_read_reg_cache(codec, WM8711_ROUT1V);
-       wm8711_write(codec, WM8711_ROUT1V, reg | 0x0100);
-
-       wm8711_add_controls(codec);
+       snd_soc_add_controls(codec, wm8711_snd_controls,
+                            ARRAY_SIZE(wm8711_snd_controls));
        wm8711_add_widgets(codec);
        ret = snd_soc_init_card(socdev);
        if (ret < 0) {
-               printk(KERN_ERR "wm8711: failed to register card\n");
+               dev_err(codec->dev, "failed to register card: %d\n", ret);
                goto card_err;
        }
+
        return ret;
 
 card_err:
        snd_soc_free_pcms(socdev);
        snd_soc_dapm_free(socdev);
 pcm_err:
-       kfree(codec->reg_cache);
        return ret;
 }
 
-static struct snd_soc_device *wm8711_socdev;
-
-#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-
-/*
- * WM8711 2 wire address is determined by GPIO5
- * state during powerup.
- *    low  = 0x1a
- *    high = 0x1b
- */
-#define I2C_DRIVERID_WM8711 0xfefe /* liam -  need a proper id */
-
-static unsigned short normal_i2c[] = { 0, I2C_CLIENT_END };
+/* power down chip */
+static int wm8711_remove(struct platform_device *pdev)
+{
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
 
-/* Magic definition of all other variables and things */
-I2C_CLIENT_INSMOD;
+       snd_soc_free_pcms(socdev);
+       snd_soc_dapm_free(socdev);
 
-static struct i2c_driver wm8711_i2c_driver;
-static struct i2c_client client_template;
+       return 0;
+}
 
-/* If the i2c layer weren't so broken, we could pass this kind of data
-   around */
+struct snd_soc_codec_device soc_codec_dev_wm8711 = {
+       .probe =        wm8711_probe,
+       .remove =       wm8711_remove,
+       .suspend =      wm8711_suspend,
+       .resume =       wm8711_resume,
+};
+EXPORT_SYMBOL_GPL(soc_codec_dev_wm8711);
 
-static int wm8711_codec_probe(struct i2c_adapter *adap, int addr, int kind)
+static int wm8711_register(struct wm8711_priv *wm8711,
+                          enum snd_soc_control_type control)
 {
-       struct snd_soc_device *socdev = wm8711_socdev;
-       struct wm8711_setup_data *setup = socdev->codec_data;
-       struct snd_soc_codec *codec = socdev->card->codec;
-       struct i2c_client *i2c;
        int ret;
+       struct snd_soc_codec *codec = &wm8711->codec;
+       u16 reg;
 
-       if (addr != setup->i2c_address)
-               return -ENODEV;
-
-       client_template.adapter = adap;
-       client_template.addr = addr;
-
-       i2c = kmemdup(&client_template, sizeof(client_template), GFP_KERNEL);
-       if (i2c == NULL) {
-               kfree(codec);
-               return -ENOMEM;
+       if (wm8711_codec) {
+               dev_err(codec->dev, "Another WM8711 is registered\n");
+               return -EINVAL;
        }
 
-       i2c_set_clientdata(i2c, codec);
+       mutex_init(&codec->mutex);
+       INIT_LIST_HEAD(&codec->dapm_widgets);
+       INIT_LIST_HEAD(&codec->dapm_paths);
+
+       codec->private_data = wm8711;
+       codec->name = "WM8711";
+       codec->owner = THIS_MODULE;
+       codec->bias_level = SND_SOC_BIAS_OFF;
+       codec->set_bias_level = wm8711_set_bias_level;
+       codec->dai = &wm8711_dai;
+       codec->num_dai = 1;
+       codec->reg_cache_size = WM8711_CACHEREGNUM;
+       codec->reg_cache = &wm8711->reg_cache;
 
-       codec->control_data = i2c;
+       memcpy(codec->reg_cache, wm8711_reg, sizeof(wm8711_reg));
 
-       ret = i2c_attach_client(i2c);
+       ret = snd_soc_codec_set_cache_io(codec, 7, 9, control);
        if (ret < 0) {
-               pr_err("failed to attach codec at addr %x\n", addr);
+               dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret);
                goto err;
        }
 
-       ret = wm8711_init(socdev);
+       ret = wm8711_reset(codec);
        if (ret < 0) {
-               pr_err("failed to initialise WM8711\n");
+               dev_err(codec->dev, "Failed to issue reset\n");
+               goto err;
+       }
+
+       wm8711_dai.dev = codec->dev;
+
+       wm8711_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+
+       /* Latch the update bits */
+       reg = snd_soc_read(codec, WM8711_LOUT1V);
+       snd_soc_write(codec, WM8711_LOUT1V, reg | 0x0100);
+       reg = snd_soc_read(codec, WM8711_ROUT1V);
+       snd_soc_write(codec, WM8711_ROUT1V, reg | 0x0100);
+
+       wm8711_codec = codec;
+
+       ret = snd_soc_register_codec(codec);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register codec: %d\n", ret);
                goto err;
        }
-       return ret;
 
+       ret = snd_soc_register_dai(&wm8711_dai);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register DAI: %d\n", ret);
+               goto err_codec;
+       }
+
+       return 0;
+
+err_codec:
+       snd_soc_unregister_codec(codec);
 err:
-       kfree(codec);
-       kfree(i2c);
+       kfree(wm8711);
        return ret;
 }
 
-static int wm8711_i2c_detach(struct i2c_client *client)
+static void wm8711_unregister(struct wm8711_priv *wm8711)
 {
-       struct snd_soc_codec *codec = i2c_get_clientdata(client);
+       wm8711_set_bias_level(&wm8711->codec, SND_SOC_BIAS_OFF);
+       snd_soc_unregister_dai(&wm8711_dai);
+       snd_soc_unregister_codec(&wm8711->codec);
+       kfree(wm8711);
+       wm8711_codec = NULL;
+}
 
-       i2c_detach_client(client);
-       kfree(codec->reg_cache);
-       kfree(client);
-       return 0;
+#if defined(CONFIG_SPI_MASTER)
+static int __devinit wm8711_spi_probe(struct spi_device *spi)
+{
+       struct snd_soc_codec *codec;
+       struct wm8711_priv *wm8711;
+
+       wm8711 = kzalloc(sizeof(struct wm8711_priv), GFP_KERNEL);
+       if (wm8711 == NULL)
+               return -ENOMEM;
+
+       codec = &wm8711->codec;
+       codec->control_data = spi;
+       codec->dev = &spi->dev;
+
+       dev_set_drvdata(&spi->dev, wm8711);
+
+       return wm8711_register(wm8711, SND_SOC_SPI);
 }
 
-static int wm8711_i2c_attach(struct i2c_adapter *adap)
+static int __devexit wm8711_spi_remove(struct spi_device *spi)
 {
-       return i2c_probe(adap, &addr_data, wm8711_codec_probe);
+       struct wm8711_priv *wm8711 = dev_get_drvdata(&spi->dev);
+
+       wm8711_unregister(wm8711);
+
+       return 0;
 }
 
-/* corgi i2c codec control layer */
-static struct i2c_driver wm8711_i2c_driver = {
+static struct spi_driver wm8711_spi_driver = {
        .driver = {
-               .name = "WM8711 I2C Codec",
-               .owner = THIS_MODULE,
+               .name   = "wm8711",
+               .bus    = &spi_bus_type,
+               .owner  = THIS_MODULE,
        },
-       .id =             I2C_DRIVERID_WM8711,
-       .attach_adapter = wm8711_i2c_attach,
-       .detach_client =  wm8711_i2c_detach,
-       .command =        NULL,
+       .probe          = wm8711_spi_probe,
+       .remove         = __devexit_p(wm8711_spi_remove),
 };
+#endif /* CONFIG_SPI_MASTER */
 
-static struct i2c_client client_template = {
-       .name =   "WM8711",
-       .driver = &wm8711_i2c_driver,
-};
-#endif
-
-static int wm8711_probe(struct platform_device *pdev)
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+static __devinit int wm8711_i2c_probe(struct i2c_client *i2c,
+                                     const struct i2c_device_id *id)
 {
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct wm8711_setup_data *setup;
-       struct snd_soc_codec *codec;
        struct wm8711_priv *wm8711;
-       int ret = 0;
-
-       pr_info("WM8711 Audio Codec %s", WM8711_VERSION);
-
-       setup = socdev->codec_data;
-       codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
-       if (codec == NULL)
-               return -ENOMEM;
+       struct snd_soc_codec *codec;
 
        wm8711 = kzalloc(sizeof(struct wm8711_priv), GFP_KERNEL);
-       if (wm8711 == NULL) {
-               kfree(codec);
+       if (wm8711 == NULL)
                return -ENOMEM;
-       }
-
-       codec->private_data = wm8711;
-       socdev->card->codec = codec;
-       mutex_init(&codec->mutex);
-       INIT_LIST_HEAD(&codec->dapm_widgets);
-       INIT_LIST_HEAD(&codec->dapm_paths);
 
-       wm8711_socdev = socdev;
-#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-       if (setup->i2c_address) {
-               normal_i2c[0] = setup->i2c_address;
-               codec->hw_write = (hw_write_t)i2c_master_send;
-               ret = i2c_add_driver(&wm8711_i2c_driver);
-               if (ret != 0)
-                       printk(KERN_ERR "can't add i2c driver");
-       }
-#else
-       /* Add other interfaces here */
-#endif
-       return ret;
-}
+       codec = &wm8711->codec;
+       codec->hw_write = (hw_write_t)i2c_master_send;
 
-/* power down chip */
-static int wm8711_remove(struct platform_device *pdev)
-{
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct snd_soc_codec *codec = socdev->card->codec;
+       i2c_set_clientdata(i2c, wm8711);
+       codec->control_data = i2c;
 
-       if (codec->control_data)
-               wm8711_set_bias_level(codec, SND_SOC_BIAS_OFF);
+       codec->dev = &i2c->dev;
 
-       snd_soc_free_pcms(socdev);
-       snd_soc_dapm_free(socdev);
-#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-       i2c_del_driver(&wm8711_i2c_driver);
-#endif
-       kfree(codec->private_data);
-       kfree(codec);
+       return wm8711_register(wm8711, SND_SOC_I2C);
+}
 
+static __devexit int wm8711_i2c_remove(struct i2c_client *client)
+{
+       struct wm8711_priv *wm8711 = i2c_get_clientdata(client);
+       wm8711_unregister(wm8711);
        return 0;
 }
 
-struct snd_soc_codec_device soc_codec_dev_wm8711 = {
-       .probe =        wm8711_probe,
-       .remove =       wm8711_remove,
-       .suspend =      wm8711_suspend,
-       .resume =       wm8711_resume,
+static const struct i2c_device_id wm8711_i2c_id[] = {
+       { "wm8711", 0 },
+       { }
 };
-EXPORT_SYMBOL_GPL(soc_codec_dev_wm8711);
+MODULE_DEVICE_TABLE(i2c, wm8711_i2c_id);
+
+static struct i2c_driver wm8711_i2c_driver = {
+       .driver = {
+               .name = "WM8711 I2C Codec",
+               .owner = THIS_MODULE,
+       },
+       .probe =    wm8711_i2c_probe,
+       .remove =   __devexit_p(wm8711_i2c_remove),
+       .id_table = wm8711_i2c_id,
+};
+#endif
 
 static int __init wm8711_modinit(void)
 {
-       return snd_soc_register_dai(&wm8711_dai);
+       int ret;
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+       ret = i2c_add_driver(&wm8711_i2c_driver);
+       if (ret != 0) {
+               printk(KERN_ERR "Failed to register WM8711 I2C driver: %d\n",
+                      ret);
+       }
+#endif
+#if defined(CONFIG_SPI_MASTER)
+       ret = spi_register_driver(&wm8711_spi_driver);
+       if (ret != 0) {
+               printk(KERN_ERR "Failed to register WM8711 SPI driver: %d\n",
+                      ret);
+       }
+#endif
+       return 0;
 }
 module_init(wm8711_modinit);
 
 static void __exit wm8711_exit(void)
 {
-       snd_soc_unregister_dai(&wm8711_dai);
+#if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
+       i2c_del_driver(&wm8711_i2c_driver);
+#endif
+#if defined(CONFIG_SPI_MASTER)
+       spi_unregister_driver(&wm8711_spi_driver);
+#endif
 }
 module_exit(wm8711_exit);