]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mmc: sdhci: Setting the host->mrq to NULL before executing tuning
authorChuansheng Liu <chuansheng.liu@intel.com>
Tue, 5 Nov 2013 06:52:45 +0000 (14:52 +0800)
committerChris Ball <cjb@laptop.org>
Tue, 26 Nov 2013 22:50:39 +0000 (17:50 -0500)
commit00442f6039afc684529462e35702ac4ea6d20dc5
treec89586c8e06849433e4a79113270571193514159
parent06cafa78ebe9edfb1e1b3bdda52850924321b46a
mmc: sdhci: Setting the host->mrq to NULL before executing tuning

In function sdhci_request(), it is possible to do the tuning execution
like below:

sdhci_request() {
spin_lock_irqsave(&host->lock, flags);
host->mrq = mrq;
...
spin_unlock_irqrestore(&host->lock, flags);

<=== Here it is possible one pending finish_tasklet get running
     and it will operate the original mrq, and notified the mrq
     is done, and causes memory corruption.

sdhci_execute_tuning(mmc, tuning_opcode);
spin_lock_irqsave(&host->lock, flags);
host->mrq = mrq;
...
}

In the above race place, the original mrq should not be finished wrongly,
so here before unlock the spinlock, we need to set the host->mrq to NULL
to avoid this case.

Signed-off-by: Liu, Chuansheng <chuansheng.liu@intel.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
drivers/mmc/host/sdhci.c