]> git.karo-electronics.de Git - linux-beck.git/commit
ALSA: pcm: remove structure member of 'struct snd_pcm_hwptr_log *' type because this...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 13 Sep 2015 10:00:05 +0000 (19:00 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sun, 13 Sep 2015 10:03:15 +0000 (12:03 +0200)
commit0052b7dcf9d9ec6be4fc3fe815a2ceda623bb9d1
tree77f72d8866c2384c0756e44a8ce2a164cf245cc9
parent29d28c5060023e661965c51c7e8f53bc9eb44fc4
ALSA: pcm: remove structure member of 'struct snd_pcm_hwptr_log *' type because this structure had been removed

This structure was added by 4d96eb255c53 ('ALSA: pcm_lib - add possibility
to log last 10 DMA ring buffer positions') to store PCM pointers
information of latest 10 pointer movements (=XRUN_LOG_CNT). When
CONFIG_SND_PCM_XRUN_DEBUG is configured, 'struct snd_pcm_runtime' has
'hwptr_log' member with a pointer to the structure. When calling
xrun_log() in pcm_lib.c, the structure was allocated to the pointer.
When calling snd_pcm_detach_substream() in pcm.c, the allocated pointer
is released.

In f5914908a5b7 ('ALSA: pcm: Replace PCM hwptr tracking with tracepoints'),
the pointer logging is replaced with using Linux Kernel Tracepoints. The
structure was also removed, while it's just declared. The member and kfree
still remains.

This commit removes the member and related codes. I think this was
overlooked because it brings no errors/warnings to C compilers.

Fixes: f5914908a5b7 ('ALSA: pcm: Replace PCM hwptr tracking with tracepoints')
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
include/sound/pcm.h
sound/core/pcm.c