]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net: packet: fix information leak to userland
authorVasiliy Kulikov <segooon@gmail.com>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
committerWilly Tarreau <w@1wt.eu>
Sat, 30 Apr 2011 14:53:33 +0000 (16:53 +0200)
commit008c3e5897181fe8f64d6e00411e795a97b52709
treef3939a596ecbfa612e0093d32e05dd36e3648f7f
parentfa0b3c99f7ce9972476a5fd99d0afbf9c9e46aff
net: packet: fix information leak to userland

commit 67286640f638f5ad41a946b9a3dc75327950248f upstream.

packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Moritz Muehlenhoff <jmm@debian.org>
[jmm: Backported to 2.6.32]
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/packet/af_packet.c