]> git.karo-electronics.de Git - karo-tx-linux.git/commit
b43legacy: Release mutex in error handling code
authorJulia Lawall <julia@diku.dk>
Wed, 30 Jul 2008 18:20:12 +0000 (18:20 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 1 Aug 2008 19:43:12 +0000 (12:43 -0700)
commit00b289bb9a03f0550f6015efdbf00807e3056b8a
tree662d41877b23a1c8f38fd6efb4249db5119cfe19
parent04f496871e8af87a1e40c504371a206fd7389193
b43legacy: Release mutex in error handling code

commit 4104863fb4a724723d1d5f3cba9d3c5084087e45 upstream

The mutex is released on a successful return, so it would seem that it
should be released on an error return as well.

The semantic patch finds this problem is as follows:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
expression l;
@@

mutex_lock(l);
.. when != mutex_unlock(l)
    when any
    when strict
(
if (...) { ... when != mutex_unlock(l)
+   mutex_unlock(l);
    return ...;
}
|
mutex_unlock(l);
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Michael Buesch <mb@bu3sch.de>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/b43legacy/main.c