]> git.karo-electronics.de Git - karo-tx-linux.git/commit
x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI
authorBehan Webster <behanw@converseincode.com>
Wed, 12 Feb 2014 20:58:46 +0000 (21:58 +0100)
committerMatthew Garrett <matthew.garrett@nebula.com>
Sun, 6 Apr 2014 15:48:56 +0000 (11:48 -0400)
commit01502f23b9725bffe5c606b12fb8b0cef4479963
tree8bed762872da77b0ba74867fc53727bd7a37edb5
parent73e0157860c8c06f86611abd820d5dbb726b0fc6
x86, acpi: LLVMLinux: Remove nested functions from Thinkpad ACPI

The only real change is passing in event_mask to the formerly nested functions.
Otherwise it's just moving around function and macro code.

This is the only place in the Linux kernel where nested functions are still in
use. Nested functions aren't part of the C standards, and complicate the
generated code. Although the Linux Kernel has never set out to be entirely C
standard compliant, it is increasingly compliant to the standard which is
supported by other compilers such as Clang. The LLVMLinux project is working on
being able to compile the Linux kernel with Clang. The use of nested functions
blocks this effort.

Signed-off-by: Behan Webster <behanw@converseincode.com>
Signed-off-by: Jan-Simon Möller <dl9pf@gmx.de>
CC: David Woodhouse <David.Woodhouse@intel.com>
CC: Matthew Garrett <matthew.garrett@nebula.com>
CC: ibm-acpi-devel@lists.sourceforge.net
CC: platform-driver-x86@vger.kernel.org
CC: linux-kernel@vger.kernel.org
Signed-off-by: Matthew Garrett <matthew.garrett@nebula.com>
drivers/platform/x86/thinkpad_acpi.c