]> git.karo-electronics.de Git - karo-tx-linux.git/commit
skip sense logging for some ATA PASS-THROUGH cdbs
authorDouglas Gilbert <dgilbert@interlog.com>
Sun, 3 Jan 2010 18:51:15 +0000 (13:51 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 May 2010 22:02:52 +0000 (15:02 -0700)
commit023db2c37409af735e9eaee9bef89a1852e814fc
treeb18d9545a0f417da864f72fbe10248c2f75f1442
parentab6beee9920960fb14034b45a53267aa1cc8198e
skip sense logging for some ATA PASS-THROUGH cdbs

commit e7efe5932b1d3916c79326a4221693ea90a900e2 upstream.

Further to the lsml thread titled:
"does scsi_io_completion need to dump sense data for ata pass through (ck_cond =
1) ?"

This is a patch to skip logging when the sense data is
associated with a SENSE_KEY of "RECOVERED_ERROR" and the
additional sense code is "ATA PASS-THROUGH INFORMATION
AVAILABLE". This only occurs with the SAT ATA PASS-THROUGH
commands when CK_COND=1 (in the cdb). It indicates that
the sense data contains ATA registers.

Smartmontools uses such commands on ATA disks connected via
SAT. Periodic checks such as those done by smartd cause
nuisance entries into logs that are:
    - neither errors nor warnings
    - pointless unless the cdb that caused them are also logged

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/scsi_lib.c