]> git.karo-electronics.de Git - linux-beck.git/commit
rbd: fix buffer size for writes to images with snapshots
authorJosh Durgin <josh.durgin@inktank.com>
Tue, 27 Aug 2013 21:45:46 +0000 (14:45 -0700)
committerSage Weil <sage@inktank.com>
Wed, 4 Sep 2013 05:08:46 +0000 (22:08 -0700)
commit03507db631c94a48e316c7f638ffb2991544d617
treeb2035f4289b911bb4172804b2a7b46958a749d0c
parent9542cf0bf9b1a3adcc2ef271edbcbdba03abf345
rbd: fix buffer size for writes to images with snapshots

rbd_osd_req_create() needs to know the snapshot context size to create
a buffer large enough to send it with the message front. It gets this
from the img_request, which was not set for the obj_request yet. This
resulted in trying to write past the end of the front payload, hitting
this BUG:

libceph: BUG_ON(p > msg->front.iov_base + msg->front.iov_len);

Fix this by associating the obj_request with its img_request
immediately after it's created, before the osd request is created.

Fixes: http://tracker.ceph.com/issues/5760
Suggested-by: Alex Elder <alex.elder@linaro.org>
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Reviewed-by: Alex Elder <alex.elder@linaro.org>
drivers/block/rbd.c