]> git.karo-electronics.de Git - karo-tx-linux.git/commit
btree: fix tree corruption in btree_get_prev()
authorRoland Dreier <roland@purestorage.com>
Thu, 7 Jun 2012 21:21:13 +0000 (14:21 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Sun, 10 Jun 2012 13:42:10 +0000 (14:42 +0100)
commit043d295af99c056807d9647fe9fa8dd784a9ebb5
tree91ec53d78d84daf5be5551eab57dde5afa467447
parent74886d5f1a04e444f910d0e09e288793690bec96
btree: fix tree corruption in btree_get_prev()

commit cbf8ae32f66a9ceb8907ad9e16663c2a29e48990 upstream.

The memory the parameter __key points to is used as an iterator in
btree_get_prev(), so if we save off a bkey() pointer in retry_key and
then assign that to __key, we'll end up corrupting the btree internals
when we do eg

longcpy(__key, bkey(geo, node, i), geo->keylen);

to return the key value.  What we should do instead is use longcpy() to
copy the key value that retry_key points to __key.

This can cause a btree to get corrupted by seemingly read-only
operations such as btree_for_each_safe.

[akpm@linux-foundation.org: avoid the double longcpy()]
Signed-off-by: Roland Dreier <roland@purestorage.com>
Acked-by: Joern Engel <joern@logfs.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
lib/btree.c