]> git.karo-electronics.de Git - karo-tx-linux.git/commit
iscsi-target: Add explicit set of cache_dynamic_acls=1 for TPG demo-mode
authorNicholas Bellinger <nab@linux-iscsi.org>
Sun, 30 Sep 2012 19:20:02 +0000 (12:20 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 17 Oct 2012 02:49:24 +0000 (03:49 +0100)
commit0450a208da987620b839d0eecd6dbf3bb50b38e8
treebe6425041d47ff27d9ceb231a9008fa346b1e29b
parent14b557c19dbe677059243246522da15800ca94f0
iscsi-target: Add explicit set of cache_dynamic_acls=1 for TPG demo-mode

commit 38b11bae6ba02da352340aff12ee25755977b222 upstream.

We've had reports in the past about this specific case, so it's time to
go ahead and explicitly set cache_dynamic_acls=1 for generate_node_acls=1
(TPG demo-mode) operation.

During normal generate_node_acls=0 operation with explicit NodeACLs ->
se_node_acl memory is persistent to the configfs group located at
/sys/kernel/config/target/$TARGETNAME/$TPGT/acls/$INITIATORNAME, so in
the generate_node_acls=1 case we want the reservation logic to reference
existing per initiator IQN se_node_acl memory (not to generate a new
se_node_acl), so go ahead and always set cache_dynamic_acls=1 when
TPG demo-mode is enabled.

Reported-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/target/iscsi/iscsi_target_tpg.c