]> git.karo-electronics.de Git - karo-tx-linux.git/commit
USB: FHCI: cq_get() should check kfifo_out()'s return value
authorAnton Vorontsov <avorontsov@mvista.com>
Fri, 14 May 2010 14:33:18 +0000 (18:33 +0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 5 Jul 2010 18:22:07 +0000 (11:22 -0700)
commit068c984526dcdafae7fde7ce8d6135bcc48950da
tree81d3cc52628f2eba54652d431c3c66f3371aede5
parent4a8b98282f192abc27f1c18dc81ed2e59929e168
USB: FHCI: cq_get() should check kfifo_out()'s return value

commit 7f1cccd3ec8789e52897bc34420ca81a5e2edeab upstream.

Since commit 7acd72eb85f1c7a15e8b5eb554994949241737f1 ("kfifo: rename
kfifo_put... into kfifo_in... and kfifo_get... into kfifo_out..."),
kfifo_out() is marked __must_check, and that causes gcc to produce
lots of warnings like this:

  CC      drivers/usb/host/fhci-mem.o
In file included from drivers/usb/host/fhci-hcd.c:34:
drivers/usb/host/fhci.h: In function 'cq_get':
drivers/usb/host/fhci.h:520: warning: ignoring return value of 'kfifo_out', declared with attribute warn_unused_result
...

This patch fixes the issue by properly checking the return value.

Signed-off-by: Anton Vorontsov <avorontsov@mvista.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/fhci.h