]> git.karo-electronics.de Git - linux-beck.git/commit
bcache: fix race of writeback thread starting before complete initialization
authorEric Wheeler <git@linux.ewheeler.net>
Fri, 26 Feb 2016 22:39:06 +0000 (14:39 -0800)
committerJens Axboe <axboe@fb.com>
Tue, 8 Mar 2016 16:17:30 +0000 (09:17 -0700)
commit07cc6ef8edc47f8b4fc1e276d31127a0a5863d4d
treef70c53b8aa72129040a75222086ed6590d63bd3e
parent08095e70783f1d8296f858d37a9e1878f5da0623
bcache: fix race of writeback thread starting before complete initialization

The bch_writeback_thread might BUG_ON in read_dirty() if
dc->sb==BDEV_STATE_DIRTY and bch_sectors_dirty_init has not yet completed
its related initialization.  This patch downs the dc->writeback_lock until
after initialization is complete, thus preventing bch_writeback_thread
from proceeding prematurely.

See this thread:
  http://thread.gmane.org/gmane.linux.kernel.bcache.devel/3453

Signed-off-by: Eric Wheeler <bcache@linux.ewheeler.net>
Tested-by: Marc MERLIN <marc@merlins.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/md/bcache/super.c