]> git.karo-electronics.de Git - karo-tx-linux.git/commit
savagedb: Fix typo causing regression in savage4 series video chip detection
authorJohn Stanley <jpsinthemix@verizon.net>
Thu, 4 Aug 2011 00:41:00 +0000 (20:41 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 3 Oct 2011 18:39:57 +0000 (11:39 -0700)
commit088412ec9929d1a1aa58e30aba1304a0fee68c98
tree1f71466fc1cd2d15585274c173b7e4ce9fe95c05
parentdea592062aeaa1269cfc6f1b23a15bb03a65b6df
savagedb: Fix typo causing regression in savage4 series video chip detection

commit 4b00e4b3940eabb38adeec0823751820fe2d6fda upstream.

Two additional savage4 variants were added, but the S3_SAVAGE4_SERIES
macro was incompletely modified, resulting in a false positive detection
of a savage4 card regardless of which savage card is actually present.

For non-savage4 series cards, such as a Savage/IX-MV card, this results
in garbled video and/or a hard-hang at boot time.  Fix this by changing
an '||' to an '&&' in the S3_SAVAGE4_SERIES macro.

Signed-off-by: John P. Stanley <jpsinthemix@verizon.net>
Reviewed-by: Tormod Volden <debian.tormod@gmail.com>
[ The macros have incomplete parenthesis too, but whatever ..  -Linus ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/video/savage/savagefb.h