]> git.karo-electronics.de Git - linux-beck.git/commit
drm/i915: BUG_ON bad PPGTT offset
authorBen Widawsky <ben@bwidawsk.net>
Wed, 24 Apr 2013 06:15:30 +0000 (23:15 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Mon, 6 May 2013 09:40:47 +0000 (11:40 +0200)
commit0a73287060cdd8fc2b50ecd216c918c2d097de59
tree6d2c42f8396e76eab86a0d6fa7162b35e91189b8
parent186507e9e8e89d5920305fdffd8cbba6366da795
drm/i915: BUG_ON bad PPGTT offset

Because PPGTT PDEs within the GTT are calculated in cachelines
(HW guys consistency ftw) we do a divide which will wreak havoc if this
is wrong, and I know that from experience).

If/when we move to multiple PPGTTs this will have to become a WARN, and
return an error. For now however it should always be considered fatal,
and only a developer could hit it.

Signed-off-by: Ben Widawsky <ben@bwidawsk.net>
Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
[danvet: s/BUG/WARN]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
drivers/gpu/drm/i915/i915_gem_gtt.c