]> git.karo-electronics.de Git - karo-tx-linux.git/commit
net/core: neighbour update Oops
authorDoug Kehn <rdkehn@yahoo.com>
Thu, 15 Jul 2010 01:02:16 +0000 (18:02 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:26:29 +0000 (10:26 -0700)
commit0a9f8b4059504bbf26e336b843972cedd17d23e0
tree6bdb08c7e6313baf8d7acd9d6f079da0d20b0a66
parent8b788148700f031c4f42ebd091e22d86ed3fcb71
net/core: neighbour update Oops

commit 91a72a70594e5212c97705ca6a694bd307f7a26b upstream.

When configuring DMVPN (GRE + openNHRP) and a GRE remote
address is configured a kernel Oops is observed.  The
obserseved Oops is caused by a NULL header_ops pointer
(neigh->dev->header_ops) in neigh_update_hhs() when

void (*update)(struct hh_cache*, const struct net_device*, const unsigned char *)
= neigh->dev->header_ops->cache_update;

is executed.  The dev associated with the NULL header_ops is
the GRE interface.  This patch guards against the
possibility that header_ops is NULL.

This Oops was first observed in kernel version 2.6.26.8.

Signed-off-by: Doug Kehn <rdkehn@yahoo.com>
Acked-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/core/neighbour.c