]> git.karo-electronics.de Git - karo-tx-linux.git/commit
lib-vsprintf-optimize-put_dec_trunc8-fix
authorGeorge Spelvin <linux@horizon.com>
Fri, 28 Sep 2012 00:20:13 +0000 (10:20 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Wed, 3 Oct 2012 06:50:40 +0000 (16:50 +1000)
commit0affaace0ddfa921d4340e54d507d9301c0389e4
tree7e06ba4b4ca5e279e996916045a8b677d8ca1afd
parentcb8ab9f6266e398dcbb83fe0ed5a235d7e1e5b84
lib-vsprintf-optimize-put_dec_trunc8-fix

Rabin Vincent <rabin@rab.in> wrote:
> This patch breaks IP address printing with "%pI4" (and by extension,
> nfsroot).  Example:
>
>  - Before: 10.0.0.1
>  - After: 10...1

Mea culpa, and thank you for catching it!  As I said in my earlier
comment, I tested this most extensively wrapped by some sprintf code
that liked 0 converted to a 0-length string, as that works naturally
with the ANSI spec for %.0u.  And it turns out not to matter for the
usual printf code, as num_to_str special-cases that anyway.

The fix is straightforward:

Signed-off-by: George Spelvin <linux@horizon.com>
Cc: Rabin Vincent <rabin@rab.in>
Cc: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Michal Nazarewicz <mina86@mina86.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
lib/vsprintf.c