]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mm: iov_iter: have iov_iter_advance() decrement nr_segs appropriately
authorJeff Layton <jlayton@redhat.com>
Wed, 5 Oct 2011 00:43:03 +0000 (11:43 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 7 Oct 2011 06:06:39 +0000 (17:06 +1100)
commit0b20a560b6bf0ca1f3bb70e87b9711c4ff283015
tree8079a8e2b3a03a1672e9cf220bf206e8751e77b1
parentdaf988bfda33462d0d17e160a67163624065882b
mm: iov_iter: have iov_iter_advance() decrement nr_segs appropriately

Currently, when you call iov_iter_advance, then the pointer to the iovec
array can be incremented, but it does not decrement the nr_segs value in
the iov_iter struct.  The result is a iov_iter struct with a nr_segs value
that goes beyond the end of the array.

While I'm not aware of anything that's specifically broken by this, it
seems odd and a bit dangerous not to decrement that value.  If someone
were to trust the nr_segs value to be correct, then they could end up
walking off the end of the array.

Changing this might also provide some micro-optimization when dealing with
the last iovec in an array.  Many of the other routines that deal with
iov_iter have optimized codepaths when nr_segs == 1.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
Cc: Nick Piggin <npiggin@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/filemap.c