]> git.karo-electronics.de Git - karo-tx-linux.git/commit
mm: softdirty: make freshly remapped file pages being softdirty unconditionally
authorCyrill Gorcunov <gorcunov@openvz.org>
Thu, 22 May 2014 00:42:43 +0000 (10:42 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 22 May 2014 00:42:43 +0000 (10:42 +1000)
commit0b526116c74914179043b926ca7ed50eb88d7c09
tree2a0042a12a1df0c3db06b3089ba31c65097be59c
parent9e9df4dda900317c0a431d096d1dface033ebbd9
mm: softdirty: make freshly remapped file pages being softdirty unconditionally

Hugh reported:

 | I noticed your soft_dirty work in install_file_pte(): which looked
 | good at first, until I realized that it's propagating the soft_dirty
 | of a pte it's about to zap completely, to the unrelated entry it's
 | about to insert in its place.  Which seems very odd to me.

Indeed this code ends up being nop in result -- pte_file_mksoft_dirty()
operates with pte_t argument and returns new pte_t which were never used
after.  After looking more I think what we need is to soft-dirtify all
newely remapped file pages because it should look like a new mapping for
memory tracker.

Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
Reported-by: Hugh Dickins <hughd@google.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/fremap.c