]> git.karo-electronics.de Git - karo-tx-linux.git/commit
target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd
authorNicholas Bellinger <nab@linux-iscsi.org>
Thu, 6 Jun 2013 08:36:41 +0000 (01:36 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Thu, 20 Jun 2013 21:10:41 +0000 (14:10 -0700)
commit0b66818ac6de67a6125ae203272fb76e79b3a20f
treed0bbb25b6b486c9152b9b37d26b7221f5ca64d2c
parent862e6389a78992d4ee44bf4f60051fe560470320
target: Drop unnecessary CMD_T_DEV_ACTIVE check from transport_lun_remove_cmd

This patch drops an unnecessary acquire/release of se_cmd->t_state_lock within
transport_lun_remove_cmd() when checking CMD_T_DEV_ACTIVE for invoking
target_remove_from_state_list().

For all fast path completion cases, transport_lun_remove_cmd() is always
called ahead of transport_cmd_check_stop(), and since transport_cmd_check_stop()
is calling target_remove_from_state_list() when remove_from_lists=true,
the t_state_lock usage in transport_lun_remove_cmd() can safely be removed.

Cc: Christoph Hellwig <hch@lst.de>
Cc: Roland Dreier <roland@kernel.org>
Cc: Kent Overstreet <koverstreet@google.com>
Cc: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Moussa Ba <moussaba@micron.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/target_core_transport.c