]> git.karo-electronics.de Git - linux-beck.git/commit
padata: make the sequence counter an atomic_t
authorMathias Krause <mathias.krause@secunet.com>
Fri, 25 Oct 2013 10:14:15 +0000 (12:14 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Wed, 30 Oct 2013 04:02:58 +0000 (12:02 +0800)
commit0b6b098efcddac2bf4e2a895c9b655560bbfcee4
tree0facc6f31504a5be471d4592f99bce0b28f995e2
parentcfc6f11b768a9bdda17aac280474de1f0e344fea
padata: make the sequence counter an atomic_t

Using a spinlock to atomically increase a counter sounds wrong -- we've
atomic_t for this!

Also move 'seq_nr' to a different cache line than 'lock' to reduce cache
line trashing. This has the nice side effect of decreasing the size of
struct parallel_data from 192 to 128 bytes for a x86-64 build, e.g.
occupying only two instead of three cache lines.

Those changes results in a 5% performance increase on an IPsec test run
using pcrypt.

Btw. the seq_lock spinlock was never explicitly initialized -- one more
reason to get rid of it.

Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
include/linux/padata.h
kernel/padata.c