]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sound/soc/mxs/mxs-saif.c: add missing kfree
authorJulia Lawall <julia@diku.dk>
Sun, 21 Aug 2011 11:18:45 +0000 (13:18 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 22 Aug 2011 22:34:37 +0000 (23:34 +0100)
commit0bb98ba2b045e53b4724f34509455b7653c329d3
tree1349e4b612c47fc2bced520f673912391a03ba30
parentbbe8ff5e25afd4d06c8a8bad009aca5f0d0c22ef
sound/soc/mxs/mxs-saif.c: add missing kfree

Move the test on pdev->id before the kzalloc to avoid requiring kfree when
the test fails.  This fix was suggested by Wolfram Sang.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
expression E1!=0,E2,E3,E4;
statement S;
iterator I;
@@

(
if (...) { ... when != kfree(x)
               when != x = E3
               when != E3 = x
*  return ...;
 }
... when != x = E2
    when != I(...,x,...) S
if (...) { ... when != x = E4
 kfree(x); ... return ...; }
)
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Dong Aisheng <b29396@freescale.com>
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
Acked-by: Liam Girdwood <lrg@ti.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/mxs/mxs-saif.c