]> git.karo-electronics.de Git - karo-tx-linux.git/commit
kbuild: Fix modpost segfault
authorKrzysztof Halasa <khc@pm.waw.pl>
Thu, 10 Jun 2010 23:08:20 +0000 (01:08 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:26:50 +0000 (10:26 -0700)
commit0bbd0365fabbccfda730b672e0f4e8a12440aa36
treefe070840bdc283573488272282370e3f9bccde99
parentcf50b2cde07046a88a19d5ef100421be7efc4e5a
kbuild: Fix modpost segfault

commit 1c938663d58b5b2965976a6f54cc51b5d6f691aa upstream.

Alan <alan@clueserver.org> writes:

> program: /home/alan/GitTrees/linux-2.6-mid-ref/scripts/mod/modpost -o
> Module.symvers -S vmlinux.o
>
> Program received signal SIGSEGV, Segmentation fault.

It just hit me.
It's the offset calculation in reloc_location() which overflows:
        return (void *)elf->hdr + sechdrs[section].sh_offset +
               (r->r_offset - sechdrs[section].sh_addr);

E.g. for the first rodata r entry:
r->r_offset < sechdrs[section].sh_addr
and the expression in the parenthesis produces 0xFFFFFFE0 or something
equally wise.

Reported-by: Alan <alan@clueserver.org>
Signed-off-by: Krzysztof HaƂasa <khc@pm.waw.pl>
Tested-by: Alan <alan@clueserver.org>
Signed-off-by: Michal Marek <mmarek@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
scripts/mod/modpost.c