]> git.karo-electronics.de Git - karo-tx-linux.git/commit
The current implementation of dmi_name_in_vendors() is an invitation to
authorJean Delvare <khali@linux-fr.org>
Wed, 3 Aug 2011 00:52:44 +0000 (10:52 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 9 Aug 2011 03:12:24 +0000 (13:12 +1000)
commit0bde6ba448aaf7d18d6404a077e5383477162f3c
tree134ec2f0bff6119b83525ca055fd9c7f6fd830c7
parentddc8d264e683ee7f5ab74e0267a68ceb14beea6c
The current implementation of dmi_name_in_vendors() is an invitation to
lazy coding and false positives [1].  Searching for a string in 8 know
what you're looking for, so you should know where to look.  strstr isn't
fast, especially when it fails, so we should avoid calling it when it just
can't succeed.

Looking at the current users of the function, it seems clear to me that
they are looking for a system or board vendor name, so let's limit
dmi_name_in_vendors to these two DMI fields.  This much better matches the
function name, BTW.

[1] We currently have code looking for short names in DMI data, such
as "IBM", "ASUS" or "Acer". I let you guess what will happen the day
other vendors ship products named, for example, "SCHREIBMEISTER",
"PEGASUS" or "Acerola".

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/firmware/dmi_scan.c