]> git.karo-electronics.de Git - karo-tx-linux.git/commit
null_blk: mem garbage on NUMA systems during init
authorMatias Bjorling <m@bjorling.me>
Tue, 10 Dec 2013 15:50:38 +0000 (16:50 +0100)
committerJens Axboe <axboe@kernel.dk>
Thu, 19 Dec 2013 15:09:38 +0000 (08:09 -0700)
commit0c56010c83703e1f33325838eda9a2077827b6f1
tree573b750f8ced88b592bc0d6ccfbaa06d5cb76304
parenta26ba7faddd51be3dd8957543a9d984a4ddd104a
null_blk: mem garbage on NUMA systems during init

For NUMA systems, initializing the blk-mq layer and using per node hctx.
We initialize submit queues to 1, while blk-mq nr_hw_queues is
initialized to the number of NUMA nodes.

This makes the null_init_hctx function overwrite memory outside of what
it allocated.  In my case it lead to writing garbage into struct
request_queue's mq_map.

Signed-off-by: Matias Bjorling <m@bjorling.me>
Cc: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/block/null_blk.c