]> git.karo-electronics.de Git - karo-tx-linux.git/commit
memblock, memhotplug: fix wrong type in memblock_find_in_range_node().
authorTang Chen <tangchen@cn.fujitsu.com>
Fri, 29 Aug 2014 22:18:31 +0000 (15:18 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 29 Aug 2014 23:28:15 +0000 (16:28 -0700)
commit0cfb8f0c3e21e36d4a6e472e4c419d58ba848698
treeb1a56e06c5ec06051c4f9b3717e6771bc0dfdd53
parent800df627e2eabaf4a921d342a1d5162c843b7fc2
memblock, memhotplug: fix wrong type in memblock_find_in_range_node().

In memblock_find_in_range_node(), we defined ret as int.  But it should
be phys_addr_t because it is used to store the return value from
__memblock_find_range_bottom_up().

The bug has not been triggered because when allocating low memory near
the kernel end, the "int ret" won't turn out to be negative.  When we
started to allocate memory on other nodes, and the "int ret" could be
minus.  Then the kernel will panic.

A simple way to reproduce this: comment out the following code in
numa_init(),

        memblock_set_bottom_up(false);

and the kernel won't boot.

Reported-by: Xishi Qiu <qiuxishi@huawei.com>
Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Tested-by: Xishi Qiu <qiuxishi@huawei.com>
Cc: <stable@vger.kernel.org> [3.13+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/memblock.c