]> git.karo-electronics.de Git - karo-tx-linux.git/commit
drivers/mailbox/omap: make mbox->irq signed for error handling
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 3 Jan 2014 03:10:06 +0000 (14:10 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Fri, 3 Jan 2014 03:10:06 +0000 (14:10 +1100)
commit0d6f095fd0b77ffd358e754725525070068110b5
treef82d9852768b084a77f493a6f2b939ded972b727
parent23b9f967d399d5772806be29e32caeb48d783cc6
drivers/mailbox/omap: make mbox->irq signed for error handling

There is a bug in omap2_mbox_probe() where we try do:

mbox->irq = platform_get_irq(pdev, info->irq_id);
if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/mailbox/omap-mbox.h