]> git.karo-electronics.de Git - karo-tx-linux.git/commit
sound: Prevent buffer overflow in OSS load_mixer_volumes
authorDan Rosenberg <drosenberg@vsecurity.com>
Sat, 25 Dec 2010 21:23:40 +0000 (16:23 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 21 Mar 2011 19:44:31 +0000 (12:44 -0700)
commit0dd40482f3d6bf04eb477c14d9e9443a3d59f1e9
treec01b330087836a1cab28e0898aad3973cd2849b6
parentd7d4c798c903b0463787c21a5a2f41ccebb026b8
sound: Prevent buffer overflow in OSS load_mixer_volumes

commit d81a12bc29ae4038770e05dce4ab7f26fd5880fb upstream.

The load_mixer_volumes() function, which can be triggered by
unprivileged users via the SOUND_MIXER_SETLEVELS ioctl, is vulnerable to
a buffer overflow.  Because the provided "name" argument isn't
guaranteed to be NULL terminated at the expected 32 bytes, it's possible
to overflow past the end of the last element in the mixer_vols array.
Further exploitation can result in an arbitrary kernel write (via
subsequent calls to load_mixer_volumes()) leading to privilege
escalation, or arbitrary kernel reads via get_mixer_levels().  In
addition, the strcmp() may leak bytes beyond the mixer_vols array.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
sound/oss/soundcard.c